--- loncom/interface/lonfeedback.pm	2006/07/18 17:44:43	1.212
+++ loncom/interface/lonfeedback.pm	2006/08/08 19:02:04	1.214
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.212 2006/07/18 17:44:43 albertel Exp $
+# $Id: lonfeedback.pm,v 1.214 2006/08/08 19:02:04 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -186,8 +186,8 @@ sub list_discussion {
             push @{$roleinfo{$student}}, 'st:'.$section.':'.$status;
         }
 	($classgroups,$studentgroups) = 
-         &Apache::loncoursedata::get_group_memberships($classlist,$keylist,
-                                                       $cdom,$cnum);
+	    &Apache::loncoursedata::get_group_memberships($classlist,$keylist,
+							  $cdom,$cnum);
     }
 
 # Get discussion display default settings for user
@@ -713,8 +713,8 @@ END
     if ($discussiononly) {
         my $now = time;
         my $attachnum = 0;
-        my $currnewattach;
-        my $currdelold;
+        my $currnewattach = [];
+        my $currdelold = [];
         my $comment = '';
         my $subject = '';
         if ($env{'form.origpage'}) {
@@ -1683,7 +1683,7 @@ END
                 }
             }
             if ($attachmsg) {
-                $r->print("<b>Retained attachments</b>:$attachmsg<br />\n");
+                $r->print("<br /><b>Retained attachments</b>:$attachmsg<br />\n");
             }
             if ($newattachmsg) {
                 $r->print("$newattachmsg<br />");
@@ -2061,6 +2061,7 @@ $start_page
     <option value="all" selected="selected" />$status_types{'all'}</option>
     <option value="Active" />$status_types{'Active'}</option>
     <option value="Expired" />$status_types{'Expired'}</option>
+    <option value="Future" />$status_types{'Future'}</option>
    </select>
   </td>
   <td>&nbsp;</td>
@@ -2920,7 +2921,7 @@ END
             }
         }
     }
-    if (@{$currnewattach} > 0) {
+    if ((ref($currnewattach) eq 'ARRAY') && (@{$currnewattach} > 0)) {
         $r->print("The following attachments have been uploaded for inclusion with this posting.<br />Check the checkboxes for any you wish to remove<br />\n");
         foreach (@{$currnewattach}) {
             $_ =~ m#/([^/]+)$#;
@@ -3168,8 +3169,9 @@ sub sort_filter_names {
                    );
     %{$status_types} = (
                      all     => 'Roles of any status',
-                     Active => 'Only active roles',
-                     Expired => 'Only inactive roles'
+                     Active  => 'Only active roles',
+                     Expired => 'Only past roles',
+                     Future  => 'Only future roles',
                    );
 }