+
+
@@ -3287,6 +3298,10 @@ sub handler {
&Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
['hide','unhide','deldisc','postdata','preview','replydisc','editdisc','cmd','symb','onlyunread','allposts','onlyunmark','previous','markread','markonread','markondisp','toggoff','toggon','modifydisp','changes','navtime','navmaps','navurl','sortposts','applysort','rolefilter','statusfilter','sectionpick','groupick','posterlist','userpick','attach','origpage','currnewattach','deloldattach','keepold','allversions','export','sendmessageonly','group','ref']);
my $group = $env{'form.group'};
+ my %attachmax = (
+ text => '(128 KB max size)',
+ num => 131072,
+ );
if ($env{'form.editdisc'}) {
if (!(&editing_allowed($env{'form.editdisc'},$env{'form.group'}))) {
my $symb=(split(/\:\:\:/,$env{'form.editdisc'}))[0];
@@ -3557,7 +3572,7 @@ ENDREDIR
my ($symb,$feedurl)=&get_feedurl_and_clean_symb($env{'form.symb'});
if ($env{'form.cmd'} eq 'threadedon') {
&Apache::lonnet::put('environment',{'threadeddiscussion' => 'on'});
- &Apache::lonnet::appenv('environment.threadeddiscussion' => 'on');
+ &Apache::lonnet::appenv({'environment.threadeddiscussion' => 'on'});
} else {
&Apache::lonnet::del('environment',['threadeddiscussion']);
&Apache::lonnet::delenv('environment\.threadeddiscussion');
@@ -3595,13 +3610,15 @@ ENDREDIR
&Apache::loncommon::content_type($r,'text/html');
$r->send_http_header;
&Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},['subject','comment','addnewattach','delnewattach','timestamp','numoldver','idx','discuss','blog']);
- my (@currnewattach,@currdelold,@keepold);
+ my (@currnewattach,@currdelold,@keepold,$toolarge);
&process_attachments(\@currnewattach,\@currdelold,\@keepold);
if (exists($env{'form.addnewattach.filename'})) {
- unless (length($env{'form.addnewattach'})>131072) {
+ if (length($env{'form.addnewattach'})<=$attachmax{'num'}) {
my $subdir = 'feedback/'.$env{'form.timestamp'};
my $newattachment=&Apache::lonnet::userfileupload('addnewattach',undef,$subdir);
push(@currnewattach, $newattachment);
+ } else {
+ $toolarge = ''.&mt('Attachment not included - exceeded permitted length').'
';
}
}
my $attachmenturls;
@@ -3614,7 +3631,7 @@ ENDREDIR
$attachmenturls = $contrib{$idx.':attachmenturl'};
}
&modify_attachments($r,\@currnewattach,\@currdelold,$symb,$idx,
- $attachmenturls);
+ $attachmenturls,$attachmax{'text'},$toolarge);
return OK;
} elsif ($env{'form.export'}) {
&Apache::loncommon::content_type($r,'text/html');
@@ -3703,7 +3720,7 @@ ENDREDIR
}
my $options=&screen_header($feedurl,$symb);
if ($options) {
- &mail_screen($r,$feedurl,$options,$symb);
+ &mail_screen($r,$feedurl,$options,$symb,$attachmax{'text'});
} else {
&fail_redirect($r,$feedurl);
}
@@ -3720,7 +3737,7 @@ ENDREDIR
my $usersaw=&resource_output($feedurl);
# Get resource answer (need to allow student to view grades for this to work)
- &Apache::lonnet::appenv(('allowed.vgr'=>'F'));
+ &Apache::lonnet::appenv({'allowed.vgr'=>'F'});
my $usersymb = &Apache::lonenc::check_encrypt($symb);
my $useranswer=
&Apache::loncommon::get_student_answers(
@@ -3729,6 +3746,7 @@ ENDREDIR
&Apache::lonnet::delenv('allowed.vgr');
# Get attachments, if any, and not too large
my $attachmenturl='';
+ my $toolarge='';
if (($env{'form.origpage'}) || ($env{'form.editdisc'}) ||
($env{'form.replydisc'})) {
my ($symb,$idx);
@@ -3747,9 +3765,13 @@ ENDREDIR
$symb=~s|(bulletin___\d+___)adm/wrapper/|$1|;
$attachmenturl=&construct_attachmenturl(\@currnewattach,\@keepold,$symb,$idx);
} elsif ($env{'form.attachment.filename'}) {
- unless (length($env{'form.attachment'})>131072) {
- $attachmenturl=&Apache::lonnet::userfileupload('attachment',undef,'feedback');
- }
+ if (length($env{'form.attachment'})<=$attachmax{'num'}) {
+ my $now = time;
+ my $subdir = 'feedback/'.$now;
+ $attachmenturl=&Apache::lonnet::userfileupload('attachment',undef,$subdir);
+ } else {
+ $toolarge = ''.&mt('Attachment not included - exceeded permitted length').'
';
+ }
}
# Filter HTML out of message (could be nasty)
my $message=&clear_out_html($env{'form.comment'});
@@ -3792,7 +3814,7 @@ ENDREDIR
}
# Receipt screen and redirect back to where came from
- &redirect_back($r,$feedurl,$typestyle,$numsent,$numpost,$blog,$status,$env{'form.previous'},undef,undef,undef,undef,undef,undef,$group);
+ &redirect_back($r,$feedurl,$typestyle,$numsent,$numpost,$blog,$status,$env{'form.previous'},undef,undef,undef,undef,undef,undef,$group,$toolarge);
}
return OK;
}
@@ -3937,3 +3959,131 @@ sub get_resource_title {
1;
__END__
+
+
+=pod
+
+=head1 NAME
+
+Apache::lonfeedback.pm
+
+=head1 SYNOPSIS
+
+Handles feedback from students to instructors and system administrators.
+
+Provides a screenshot of the current resource, as well as previous attempts if the resource was a homework.
+
+Used by lonmsg.pm.
+
+This is part of the LearningOnline Network with CAPA project
+described at http://www.lon-capa.org.
+
+=head1 OVERVIEW
+
+None
+
+=head1 SUBROUTINES
+
+=over
+
+=item discussion_open()
+
+=item discussion_visible()
+
+=item list_discussion()
+
+=item send_feedback_link()
+
+=item send_message_link()
+
+=item action_links_bar()
+
+=item postingform_display()
+
+=item build_posting_display
+
+=item filter_regexp()
+
+=item get_post_contents()
+
+=item replicate_attachments()
+
+=item mail_screen()
+
+=item print_display_options()
+
+=item print_sortfilter_options()
+
+=item print_showposters()
+
+=item get_post_versions()
+
+=item get_post_attachments()
+
+=item fail_redirect()
+
+=item redirect_back()
+
+=item no_redirect_back()
+
+=item screen_header()
+
+=item resource_output()
+
+=item clear_out_html()
+
+=item assemble_email()
+
+=item feedback_available()
+
+=item send_msg()
+
+=item adddiscuss()
+
+=item get_discussion_info()
+
+=item show_preview()
+
+=item newline_to_br()
+
+=item generate_preview_button()
+
+=item modify_attachments()
+
+=item process_attachments()
+
+=item generate_attachments_button()
+
+=item extract_attachments()
+
+=item construct_attachmenturl()
+
+=item add_blog_checkbox()
+
+=item has_discussion()
+
+=item sort_filter_names()
+
+=item handler()
+
+=item blocked_reply_or_edit()
+
+=item wrap_symb()
+
+=item dewrapper()
+
+=item get_feedurl()
+
+=item get_feedurl_and_clean_symb()
+
+=item editing_allowed()
+
+=item check_group_priv()
+
+=item group_args()
+
+=item get_resource_title()
+
+=back
+
+=cut
\ No newline at end of file