--- loncom/interface/lonfeedback.pm 2001/02/10 14:10:13 1.8 +++ loncom/interface/lonfeedback.pm 2002/07/24 19:57:38 1.28 @@ -1,6 +1,30 @@ # The LearningOnline Network # Feedback # +# $Id: lonfeedback.pm,v 1.28 2002/07/24 19:57:38 www Exp $ +# +# Copyright Michigan State University Board of Trustees +# +# This file is part of the LearningOnline Network with CAPA (LON-CAPA). +# +# LON-CAPA is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# LON-CAPA is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with LON-CAPA; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +# +# /home/httpd/html/adm/gpl.txt +# +# http://www.lon-capa.org/ +# # (Internal Server Error Handler # # (Login Screen @@ -12,12 +36,20 @@ # 3/1,2/3,2/5,2/6,2/8 Gerd Kortemeyer # 2/9 Guy Albertelli # 2/10 Gerd Kortemeyer +# 2/13 Guy Albertelli +# 7/25 Gerd Kortemeyer +# 7/26 Guy Albertelli +# 7/26,8/10,10/1,11/5,11/6,12/27,12/29 Gerd Kortemeyer +# YEAR=2002 +# 1/1,1/16 Gerd Kortemeyer +# package Apache::lonfeedback; use strict; use Apache::Constants qw(:common); use Apache::lonmsg(); +use Apache::loncommon(); sub mail_screen { my ($r,$feedurl,$options) = @_; @@ -29,26 +61,36 @@ sub mail_screen { <script> function gosubmit() { var rec=0; - if (document.mailform.elements.author!=undefined) { + if (typeof(document.mailform.elements.author)!="undefined") { if (document.mailform.elements.author.checked) { rec=1; } } - if (document.mailform.elements.question!=undefined) { + if (typeof(document.mailform.elements.question)!="undefined") { if (document.mailform.elements.question.checked) { rec=1; } } - if (document.mailform.elements.course!=undefined) { + if (typeof(document.mailform.elements.course)!="undefined") { if (document.mailform.elements.course.checked) { rec=1; } } - if (document.mailform.elements.policy!=undefined) { + if (typeof(document.mailform.elements.policy)!="undefined") { if (document.mailform.elements.policy.checked) { rec=1; } } + if (typeof(document.mailform.elements.discuss)!="undefined") { + if (document.mailform.elements.discuss.checked) { + rec=1; + } + } + if (typeof(document.mailform.elements.anondiscuss)!="undefined") { + if (document.mailform.elements.anondiscuss.checked) { + rec=1; + } + } if (rec) { document.mailform.submit(); @@ -60,14 +102,14 @@ sub mail_screen { </head> <body bgcolor="#FFFFFF" onLoad="window.focus();"> <img align=right src=/adm/lonIcons/lonlogos.gif> -<h1>Feedback</h1> +<h1>Resource Feedback and Discussion</h1> <h2><tt>$feedurl</tt></h2> <form action="/adm/feedback" method=post name=mailform> <input type=hidden name=postdata value="$feedurl"> Please check at least one of the following feedback types: $options<hr> My question/comment/feedback:<p> -<textarea name=comment cols=60 rows=10> +<textarea name=comment cols=60 rows=10 wrap=hard> </textarea><p> <input type=hidden name=sendit value=1> <input type=button value="Send Feedback" onClick='gosubmit();'></input> @@ -155,53 +197,19 @@ sub screen_header { '<br><input type=checkbox name=policy> '. 'Question/Comment/Feedback about course policy'; } - return $options; -} -sub get_previous_attempt { - my ($symb)=@_; - my $prevattempts=''; - if ($symb) { - my $answer=&Apache::lonnet::reply( - "restore:".$ENV{'user.domain'}.':'.$ENV{'user.name'}.':'. - $ENV{'request.course.id'}.':'. - &Apache::lonnet::escape($symb), - $ENV{'user.home'}); - my %returnhash=(); - map { - my ($name,$value)=split(/\=/,$_); - $returnhash{&Apache::lonnet::unescape($name)}= - &Apache::lonnet::unescape($value); - } split(/\&/,$answer); - if ($returnhash{'version'}) { - my %lasthash=(); - my $version; - for ($version=1;$version<=$returnhash{'version'};$version++) { - map { - $lasthash{$_}=$returnhash{$version.':'.$_}; - } split(/\:/,$returnhash{$version.':keys'}); - } - $prevattempts='<table border=2></tr><th>History</th>'; - map { - $prevattempts.='<th>'.$_.'</th>'; - } keys %lasthash; - for ($version=1;$version<=$returnhash{'version'};$version++) { - $prevattempts.='</tr><tr><th>Attempt '.$version.'</th>'; - map { - $prevattempts.='<td>'.$returnhash{$version.':'.$_}.'</td>'; - } keys %lasthash; + if ($ENV{'request.course.id'}) { + if (&Apache::lonnet::allowed('pch', + $ENV{'request.course.id'}. + ($ENV{'request.course.sec'}?'/'.$ENV{'request.course.sec'}:''))) { + $options.='<br><input type=checkbox name=discuss> '. + '<b>Contribution to course discussion of resource</b>'; + $options.='<br><input type=checkbox name=anondiscuss> '. + '<b>Anonymous contribution to course discussion of resource</b>'. + ' (name only visible to course faculty)'; } - $prevattempts.='</tr><tr><th>Current</th>'; - map { - $prevattempts.='<td>'.$lasthash{$_}.'</td>'; - } keys %lasthash; - $prevattempts.='</tr></table>'; - } else { - $prevattempts='Nothing submitted - no attempts.'; - } - } else { - $prevattempts='No data.'; } + return $options; } sub resource_output { @@ -252,24 +260,27 @@ sub decide_receiver { } if ($ENV{'form.question'}) { $typestyle.='Submitting as Question<br>'; - map { + foreach (split(/\,/, + $ENV{'course.'.$ENV{'request.course.id'}.'.question.email'}) + ) { $to{$_}=1; - } split(/\,/, - $ENV{'course.'.$ENV{'request.course.id'}.'.question.email'}); + } } if ($ENV{'form.course'}) { $typestyle.='Submitting as Comment<br>'; - map { + foreach (split(/\,/, + $ENV{'course.'.$ENV{'request.course.id'}.'.comment.email'}) + ) { $to{$_}=1; - } split(/\,/, - $ENV{'course.'.$ENV{'request.course.id'}.'.comment.email'}); + } } if ($ENV{'form.policy'}) { $typestyle.='Submitting as Policy Feedback<br>'; - map { + foreach (split(/\,/, + $ENV{'course.'.$ENV{'request.course.id'}.'.policy.email'}) + ) { $to{$_}=1; - } split(/\,/, - $ENV{'course.'.$ENV{'request.course.id'}.'.policy.email'}); + } } return ($typestyle,%to); } @@ -278,20 +289,75 @@ sub send_msg { my ($feedurl,$email,$citations,%to)=@_; my $status=''; my $sendsomething=0; - map { + foreach (keys %to) { if ($_) { + my $declutter=&Apache::lonnet::declutter($feedurl); unless (&Apache::lonmsg::user_normal_msg(split(/\:/,$_), - 'Feedback '.$feedurl,$email,$citations) eq 'ok') { + 'Feedback ['.$declutter.']',$email,$citations) eq 'ok') { $status.='<br>Error sending message to '.$_.'<br>'; } else { - #$status.='<br>Message sent to '.$_.'<br>'; $sendsomething++; } } - } keys %to; + } + + my %record=&Apache::lonnet::restore('_feedback'); + my ($temp)=keys %record; + unless ($temp=~/^error\:/) { + my %newrecord=(); + $newrecord{'resource'}=$feedurl; + $newrecord{'subnumber'}=$record{'subnumber'}+1; + unless (&Apache::lonnet::cstore(\%newrecord,'_feedback') eq 'ok') { + $status.='<br>Not registered<br>'; + } + } + return ($status,$sendsomething); } +sub adddiscuss { + my ($symb,$email,$anon)=@_; + my $status=''; + if (&Apache::lonnet::allowed('pch',$ENV{'request.course.id'}. + ($ENV{'request.course.sec'}?'/'.$ENV{'request.course.sec'}:''))) { + + my %contrib=('message' => $email, + 'sendername' => $ENV{'user.name'}, + 'senderdomain' => $ENV{'user.domain'}, + 'screenname' => $ENV{'environment.screenname'}, + 'plainname' => $ENV{'environment.firstname'}.' '. + $ENV{'environment.middlename'}.' '. + $ENV{'environment.lastname'}.' '. + $ENV{'enrironment.generation'}); + if ($anon) { + $contrib{'anonymous'}='true'; + } + if (($symb) && ($email)) { + $status='Adding to class discussion'.($anon?' (anonymous)':'').': '. + &Apache::lonnet::store(\%contrib,$symb,$ENV{'request.course.id'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.domain'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.num'}); + my %storenewentry=($symb => time); + $status.='<br>Updating discussion time: '. + &Apache::lonnet::put('discussiontimes',\%storenewentry, + $ENV{'course.'.$ENV{'request.course.id'}.'.domain'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.num'}); + } + my %record=&Apache::lonnet::restore('_discussion'); + my ($temp)=keys %record; + unless ($temp=~/^error\:/) { + my %newrecord=(); + $newrecord{'resource'}=$symb; + $newrecord{'subnumber'}=$record{'subnumber'}+1; + $status.='<br>Registering: '. + &Apache::lonnet::cstore(\%newrecord,'_discussion'); + } + } else { + $status.='Failed.'; + } + return $status.'<br>'; +} + sub handler { my $r = shift; if ($r->header_only) { @@ -299,7 +365,45 @@ sub handler { $r->send_http_header; return OK; } - + +# --------------------------- Get query string for limited number of parameters + + &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, + ['hide','unhide','postdata']); + + if (($ENV{'form.hide'}) || ($ENV{'form.unhide'})) { +# ----------------------------------------------------------------- Hide/unhide + $r->content_type('text/html'); + $r->send_http_header; + + my $entry=$ENV{'form.hide'}?$ENV{'form.hide'}:$ENV{'form.unhide'}; + + my ($symb,$idx)=split(/\:\:\:/,$entry); + my ($map,$ind,$url)=split(/\_\_\_/,$symb); + + my %contrib=&Apache::lonnet::restore($symb,$ENV{'request.course.id'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.domain'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.num'}); + + + my $currenthidden=$contrib{'hidden'}; + + if ($ENV{'form.hide'}) { + $currenthidden.='.'.$idx.'.'; + } else { + $currenthidden=~s/\.$idx\.//g; + } + my %newhash=('hidden' => $currenthidden); + + &Apache::lonnet::store(\%newhash,$symb,$ENV{'request.course.id'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.domain'}, + $ENV{'course.'.$ENV{'request.course.id'}.'.num'}); + + &redirect_back($r,'/res/'.$url,'Changed discussion status<p>','0'); + + + } else { +# ------------------------------------------------------------- Normal feedback my $feedurl=$ENV{'form.postdata'}; $feedurl=~s/^http\:\/\///; $feedurl=~s/^$ENV{'SERVER_NAME'}//; @@ -334,7 +438,9 @@ sub handler { } else { # Get previous user input - my $prevattempts=&get_previous_attempt($symb); + my $prevattempts=&Apache::loncommon::get_previous_attempt( + $symb,$ENV{'user.name'},$ENV{'user.domain'}, + $ENV{'request.course.id'}); # Get output from resource my $usersaw=&resource_output($feedurl); @@ -352,6 +458,17 @@ sub handler { # Actually send mail my ($status,$numsent)=&send_msg($feedurl,$email,$citations,%to); +# Discussion? Store that. + + if ($ENV{'form.discuss'}) { + $typestyle.=&adddiscuss($symb,$message); + } + + if ($ENV{'form.anondiscuss'}) { + $typestyle.=&adddiscuss($symb,$message,1); + } + + # Receipt screen and redirect back to where came from &redirect_back($r,$feedurl,$typestyle,$numsent,$status); @@ -364,6 +481,7 @@ sub handler { # Ambiguous Problem Resource $r->internal_redirect('/adm/ambiguous'); } +} return OK; } @@ -372,3 +490,4 @@ __END__ +