CVS log for loncom/interface/lonfeedback.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  Backport 1.391, 1.392

- For 2.11.4 (modified)
  Include changes in 1.393

- For 2.11
  Backport 1.393

- Bug 6929

- For 2.11.4 (modified)
  Include changes in rev. 1.392

- Cache user's aboutme page availability to speed up display of discussion posts.

- For 2.11.4 (modified)
  Include changes in rev. 1.391

- Use cached names to speed up display of discussion posts.

- For 2.11.4 (modified)
  Include changes in 1.388, 1.389, 1.390

- For 2.11
  Backport 1.388, 1.389, 1.390

- Default delay before closing window or reloading page is 2s.

Bug 6955
 -  If IP-based blocking set in domain config is in effect for user's
    current IP address, and 'Messaging 'is among blocked functions:
   (a) 'Send Feedback' (in course context), for resource(s) which allow it
       is only messaging mechanism available to users with out 'evb' priv.
   (b) Subject and Content for messages sent to instructor(s) via 'Send Feedback'
       are replaced in user's Sent Folder with: "Not shown due to IP block".

- Handle case where URL on which feedback is to be sent is unavailable or
  is /adm/feedback itself.
- Handle cases where &fail_redirect() and no_redirect_back() are called when
  feedback is composed in modal window (i.e., "Send Feedback" link was used).
- Delay (s) can be passed as arg to &fail_redirect() and no_redirect_back()
  to allow user time to read message before window closes or page reloads.
- If there is only one available feedback option automatically check the
  radio button for that option.
- If there are no available feedback options display "Sorry, no recipients"
  before pop-up close or page reload.

- For 2.11.4 (modified)
  Include changes in 1.378, 1.385, 1.386, 1.387

- Parentheses change from rev. 1.378

- Footer hiding options from menu collection also enforced when discussion
  blocking is in effect.

- Bug 6907
  Configuration for a numbered menu collection includes option to hide
  footer shown below a resource, and/or hide Discussion or Feedback links.

- For 2.11
  Backport 1.384

- Retrieval of requestor's IP address centralized in lonnet::get_requestor_ip()
- Domain configuration to allow domain's LON-CAPA nodes to operate behind a
  WAF/Reverse Proxy using aliased hostname (CNAME).
- Web requests from other nodes bypass the WAF as their requests are made
  directly to the server hostname (A record); same for internal LON-CAPA
  connections for lonc -> lond.

- For 2.11
  Backport 1.371, 1.381, 1.382, 1.383

- Prepend LC_ to id of hidden form element used in client-side checking for
  uploaded file size, for purposes of namespacing.

- Prepend LC_ to id of hidden form element used in client-side checking for
  uploaded file size, for purposes of namespacing.

- Prepend LC_ to class name in client-side checking for uploaded file size,
  for purposes of namespacing.

- For 2.11
  - Backport 1.380

- Some previously defined localized phrases still needed in interface when
  editing an existing post.

- For 2.11
  Backport 1.374, 1.375, 1.376.

- Bug 6754 LON-CAPA as LTI Provider
  - No page flip arrows in inline menu if LTI launch was or a resource
  - No forward arrow if LTI launch was for map and this is last resource.
  - No reverse arrow if LTI launch was for map and this is first resource.
  - No Contents in inline breadcrumbs if LTI launch was for resource or map.

- Bug 6754 LON-CAPA as LTI Consumer
  - Inline menu can include "Communicate" icon for External Tools
  - Functions menu for course personnel can include "Content Grades"
    item if External Tool instance is set to "gradable".

- Remove trailing white space.

- For 2.11.2 (modified).
  - Include changes in 1.374, 1.375, 1.376.

- Replace use of open(PIPE "zip -r ...  2> /dev/null |") with use of
  Archive::Zip. LONCAPA-prerequisites will need perl-Archive-Zip.

- Eliminate unnecessary border attribute, as LC_noBorder class is in use.

- Sanity checking.

- For 2.11
  - Backport 1.373

- Don't bleed unencrypted URL in discussion action links.

- Bug 5917. Course preference to disable anonymous posts to discussion.
  - uses 'pac' priv.

Adding upload file size checking to discussion comments and feedback messages.
This functionality was intruduced with file_upload.js

fixed bug 6782, and escaped most localized messages used in Javascript blocks to make sure bugs like that do not happen again

- Internationalization:
    - Added missing &mt() call
    - Proper compilation of translation phrases
- Standard styles

- Facilitate translation by applying &mt() to complete sentences.

Consistent wording:
Replaced "bulletin board" by more modern (in web context) and better fitting word "discussion board"
as already started in redesign project and already in use

XHTML: action attribute in <form> tag required (dummy attribute added)

- Possible confirmation messages are mututally exclusive; concatenator not
  needed.

Improved and corrected screen layout for feedback about discussion setting changes:
- Corrected screen layout: No overlapping elements anymore
- Consistent layout: confirmwrapper and actionbox

- Likely what was meant in change included in rev. 1.306.

- Likely what was meant in change included in rev. 1.306.

- Fix quotes (typo in rev. 1.360).

- Localization.
  - Use complete sentences to facilitate transalation.

Use standard styles (info/warning/error):

- Display of discussion posts where liking/unliking is enabled.
  - Styles used for posted text based on classification
    (mean +/- 1sigma; mean +/- 2sigma etc.) are now configurable from
    course settings.
  - Default is for no change to display of text.

- Customization for MITrelate.
  - Backport 1.357.

- Include items with no votes when computing mean and std. dev.

- xhtml
- fewer columns in textarea for composition works better in modal window.

- xhtml.

discussion/feedback
- put quoted message in a pick box
- changed order of buttons, "add attachment" button is now below already attached files

- Customization for MITrelate.
  - Correction to backports in 1.290.2.7.2.4.

- Customization for MITrelate
  - Backport 1.331 (part), 1.332, 1.333, 1.339, 1.344, 1.345, 1.346, 1.347,
             1.348, 1.349, 1.351, 1.352, 1.353.

- Update names of routines in POD.

- Streamline the code used to retrieve old versions of a post when
  replying to, or editing a discussion post.

- No voting for own posts, hidden posts or deleted posts.
- Thumbs up and thumbs down icons grayed out for hidden posts displayed
  to users with privileges to see them.

- Bug 6087.

- Change to aggregate data stored for likes/votes totals for posters.
  - replace totalvotes with totalunlikes (totalvotes now computed
    when needed from totalunlikes + totallikes, to avoid multiple counts
    in totalvotes when voter changes his/her mind.
  - context (like, unlike, delete, undelete, hide, unhide) stored for each
    record in poster's aggregate data instead of likes (was 1 or -1).
  - deletion, undeletion, hiding and unhiding a post cause totalunlikes and
    totallikes for poster to be updated appropriately.

- Fix name of routine in call included in 1.347.

- Right to see ID behind anonymous posting is separate from right to delete
  and undelete postings for discussion boardss in groups.
- New routine: &can_see_hidden() used to determine if user can hide/unhide
  or delete/undelete postings by other users.

- $group is set to $env{'form.group'} early in &handler() so use it.

- Disallow users from voting for their own posts.
- Display information to user in cases where vote was not recorded.

- Second and third args passed to &storediscussionlikes() need to be
  username, domain of person who posted discussion item, so counts used
  for karma etc. are incremented for poster not current voter.

- Modifications to changes in rev. 1.340.
  - Indentation.
  - Move perl variables outside single quotes.

- Reverse unwanted deletion in 1.341.

- Reinstating changes in 1.336, 1.337, 1.338 & 1.339 which were removed in 1.340.

added pickboxes to unify the ui.
tidied up text and buttons to be more clear.
changed a headline to fit to context.

- Like/Unlike discussion posts.
  - Parameter: discussvote: possible values: yes, notended, no.
    (i.e., voting like/unlike possible, only possible if discussion
     open for posting, or not available (default).
  - Setting of discussvote to yes or notended for course/map/resource
    will require session hosting on LON-CAPA 2.11 or newer.

- Customization for MITrelate
  - Backport 1.338.

- Improved data structure for storing which users like/unlike a particular
  posting.
  (LON-CAPA 1.3 and later -- lonnet.pm 1.557 onwards -- handle storage of
  perl data structures).

- Customization for MITrelate
  - Like/unlike discussion posts.
  - Backport 1.318, 1.319 (part), 1.321 (part), 1.322 (part), 1.323, 1.324 (part),
    1.325, 1.326, 1.330, 1.331 (part), 1.334 (part), 1.337.

- Fix typo in 1.330 -- extra comma.

- Customization for MITrelate.
  - Backport 1.336.

- Bug 5991
  - Only append username:domain to poster's nickname if viewer has priv to
    see identity behnid anonymous postings.
  - Only wrap poster's name with &aboutmewrapper() if aboutme page service
    is available for the poster.

improved layout and button labeling.

User testing:
* you should vote on whether or not you "like" something AFTER you read it
* the you-know-you-have-done-this-because-you-cannot-do-it-anymore logic escaped users

Bug #6545: discussion "karma"

Weird: this was mispelled. Not sure if it was needed anywhere

Work on Bug #6545

Icons for Like/Unlike

Less whitespace in message composition window

Turn Feedback link into modal window

Bug #6293: undelete discussion entries

Like/unlike working

Work on likes/unlikes

Work on like/unlike

Saving my work

More work on likes/dislikes

Work towards bugs #2174 and #6543

This had been double-counting for a while ...
... no big deal, since we never looked at the data, and it is limited by course

Work towards bugs #2174 and #6543

Routine to get discussion records for a user

Make normal links visible. Use specific styles if not wanted.

Trying to make the discussion look more like the rest of LON-CAPA

Cleanup

Couldn't figure out what applied to what

Modal window for sorting/filtering

Can stay modal if not modal itself ...

Cannot have modal help windows inside modal windows

Fix XHTML and use big enough modal window

Work in progress: a little bit more compact output of modal window

Bug #2359: modal windows for feedback

Reply uses modal link, less copy/paste

Saving my work: Bug 2359

Trying to get rid of some of the copy/paste regular expressions.

- Backport 1.303, 1.304.

- Backport 1.303, 1.304.

- If pgd priv is used to allow feedback, check that symb is for a group
  bulletin board.
- Fix a typo in regexp used to check symb when showing posters in group board.

- Consistent behavior for bulletin boards for course configuration:
  exclusion from contributing to discussions (role or user-based) -- pch priv.
  - Textarea for posting not shown if pch priv prevents posts by current user.
  - Show "Discussion closed" if unable to post.
  - If board is a group board and user has pgd priv for the group, this
    trumps exclusion based on pch priv.

- Backport 1.302.

- Backport 1.302.

- Part of 1.294 omitted in backport (in 1.273.4.9).

- Bug 6363. For bulletinboard need to use real symb instead of fake symb in second arg
  passed to &discussion_open().

- Typo in 1.290.2.3.

- Typo in 1.290.2.3 (backport of 1.300).

- Backport 1.300, 1.301.

- Bug 3716.
  - If "Allow limited HTML in discussion" is not "Yes" in course preferences,
    Richtext editor is unavailable when composing discussion posts.

- Display discussion controls if there is at least one posting.
- Efficiency - map hidden and deleted post IDs to hash in place of
               regexp match for each post ID
- Transactions which were to hide/unhide or delete posts do not contribute
  to count of visible postings.

- Backport 1.294, 1.298.

- Backport 1.294, 1.295, 1.296, 1.297, 1.298, 1.299.

- Coding style.
    - Gather together items which are not to be displayed when outparttarget is 'tex'.

- Consistent format for "This discussion is closed".
- If user has advanced role, include not to indicate that discussion is closed for
  non-advanced roles.

- Eliminate routines no longer needed following switch from FCKEditor 2 to CKEdi
tor 3
- Eliminate checking for environment.wysiwygeditor (no longer used).
- Access to "Richtext" editor available via link on each textarea for which it is
  to be made available.
- When editing an HTML document provide "Edit Math" button to allow
  insertion of TeX within the textarea. Button is hidden if Richtext editor in use.
- Additional tags permitted by clear_out_html() - <pre> and <chem>.

- Backport 1.294 for GCI_3.

Bug #6162: Internationalizable removal of function links during printout

Bug #6162: some unused phrases in printouts of discussions

Bug #5435: discussend overrides problem open status.

- Backport 1.292, 1.293.

Consistent icon for feedback.

Created some new icons. These should be more meaningful concerning the menu-items they are linked with.

In process of removing remote control, remote navmap and different icon modes code
Also some minor refactoring.

Localization:
Added missing &mt() call

Removed double spacing from translation phrases
 -> HTML/Browsers ignore them anyway
 -> less error prone for translators
Adjusted language files accordingly (de, es, zh)

- Backport 1.276 (part).

- Backport 1.283, 1.284, 1.285.

- Backport 1.282 (part).

- Backport 1.281, 1.287, 1.288.

- Add white space removed in 1.287.

- <b> </b> only applies to Sender's Name (not links: Reply etc.).

- Backport 1.280 and 1.286 (part).

- Simplify regexp in &contains_block_html().
- Coding style - indentation in &contains_block_html().
- Use &contains_block_html() to eliminate unwanted <br /> in display
  of discussion posts composed in Rich Text Editor.
- On post composition page decode() encoded HTML when displaying post
  to which user is replying.

- Avoid unbalanced <p> tag in ceratin cases.
- xhtml

- Backport 1.279.

- Backport 1.278.

- Valid XML in imsmanifest.xml for discussion posts included in IMS exports of courses.

-- Adds <table>, <tbody>, etc. to list of acceptable tags
-- Adds HTML Tidy code to clean invalid HTML where needed
   **Commented out pending adding new dependencies**

Changes for XHTML 1.0 transitional conformity.

- Corrected unbalanced tags (b, td, font)
- Corrected tag hierarchy (b, font)
- Real table headers for group discussion options
(Currently keep deprecated tags)

Adds check before calling lonfeedback::newline_to_br to see if
the text contains block-level HTML elements (such as <table> or <p> or <br />).
If HTML is detected, newlines will no longer be automatically converted
to <br /> tags -- this resolves bugs such as 5550, where for
example, inserting a table using the WYSIWYG editor causes
erroneous break tags to be created.

Link to Course Preferences

- Accommodate Communities.
 - role names when filtering post by role type from &Apache::lonnet::plaintext()
 - (C)course -> (C)community
   (S)student -> (M)member

- Backport 1.277.

- Eliminate duplicate code used for table cell.

- Added missing breadcrumbs
- Consistent "username:domain" display (standard separator character)

Moved blocking status table to popup.

Changes on feedback_link bar. Now even shown when "Post Discussion" link is not shown.

XHTML: Attributes in lower-case only (<form method="post" ...)

Communication, Messages, Feedback:
Optimized and consistent wording and icons

Eliminate white spaces between HTML attribute and value

CSS-ing the discussions

XHTML conform tags (input, br, hr)

- Backport 1.268.

- Backport 1.265.

- Backport 1.264.

- Backport 1.263

- Backport 1.262

Localization:
Added missing &mt() call to maxsize output

help_open_topic:
- Repaired unbalanced tags
  (only close help span, if opened before due to existing help link text)
- Localized alt content for help icon
- Added title to help icon
- Optimized CSS usage
- Optimized screen layout:
    - text and help icon now with same background again
    - less agressive background color
    - Added padding

Cheatsheet:
- Replaced <table> structure by <span>s
- Added missing &mt() call to additional help icons text

Adjusted screen layout creation in related scripts to keep old functionality:
lonfeedback.pm, lonmsgdisplay.pm

Table styles in construction space need to be revisited.

replaced the old lettericon feedback.gif with the new one com.png

- Starting with lonnet.pm rev 1.981, default for &lonnet::delenv() has been to \Q escape arg in regexp used to identify items in environment to delete.
  - No longer need to escape special characters in arg passed to lonnet::delenv().
- Call to lonnet::delenv() in rat/lonuserstate now includes second arg, because in this case first arg is to be treated as a regexp (so \Q escape is not wanted).

consistent wording

Message Preview:
  - Use pick_box
  - Added headline

XHTML conform multiple selection

- Backport 1.261.

- "Output Tags" help button only is included in row of help items in authhoring context.
- Third argument to loncommon::helpLatexCheatsheet():  not_author (if true) suppresses display of "Output Tags" item.

- Backport 1.260.

- Check that navmap object could be created to avoid ISE.
  - Display error message and log to lonnet.log if navmap object undefined.
- Regular Expressions for both http and https.

- Backport 1.259.

- Less risk of typos.

Added missing ";" to all " "

Fixd POD documentation

Added/updated/converted POD. Many files had their POD redone to new standards.

Bugs: 3706 5677 5678.
- Single attachment allowed in messages (whether sent via COM or FDBK).
- Warning displayed if uploaded file exceeded maximum size allowed for attachments (and was therefors discarded).
- Attachments included in forwarded messages (from both single message display, or from forward of multiple messages from folder display).
- Max size definition moved to a single location in lonmsgdisplay.pm and lonfeedback.pm
- Some appearance changes in modify_attachments display (for attachements associated with discussion posts).
- Subdirectory for storage of attachment file in sender's userfiles directory changed from feedback to feedback/$now (i.e., current UNIX time) to lessen likelihood of file being overwritten by a sequent message with an attachment of the same name.

Localization:
- Added missing &mt() calls
- Corrected &mt() call
- Changed user display in discussion post to LON-CAPA-standard (username:domain)

Change arguments accepted by lonnet::appenv() to:
1. reference to hash
2. (optional) reference to array.

Change all instances where lonnet::appenv() is called to replace first argument passed (originally a hash) to a reference to the hash.

- Modify lonnet.pm rev 1.35 code intended to prevent "dangerous" modifications of the environment, so it will actually do this.
- Allow these modifications to be made in certain instances:
   DC switching to adhoc role
   CC switching to a different course role in the current course.
   user self-enrolling as a student

Bugfix:
Corrected wrong closing html tag for discussion link

- separate post/message links to opposite sides of the screen

- BUG#5364

- revert debugging change

- BUG#5350

- switch Store to Save

- error checking course email addresses
   - both at the setting stage for proper form and that the user exists
   - at the sending stage for proper form

- style police

Bug #4996: student photos in feedback and discussions

Bug #5177: configure what it says in feedback window

- making error messages get sent again for print failures (BUG#2231)
  - moving decide_receivers to lonmsg for easier inclusion/use by
    cgi scripts

When discussion postings are not displayed to a user because of a COM block, FDBK button should not provide the user with a way to post to the discussion.

Checkbox for copying posted message to user's course blog not shown if discussion osting are blocked.

If resource is encrypted for the correspondent, encrypted symb needs to be used in message ID as it will be accessible in the student's Sent Folder.

- prevent waring on startup

Fix typo.

Include symb in msgid when sending feedback about a resource.

Include an error bit in msgid (1 if message is a "bomb" caused by an error when rendering a problem.

Include symb and resource title in messsage (<symb> and <resource_title> tags) when feedback is about a resource.

Navigate Contents page now checks for unread feedback or errors using symb instead of just resource url.

Navigate Contents page checks for resource context based on symb in msgid instead of in [url] included in message subject.  Backwards compatibility with old-style messages retained.

Subject for feedback messages about resources appends message title instead of url inside [].

Title on feedback page now avoids leaking unencrypted file name in cases where no title was assigned to a resource with hidden url.

When displaying feedback messages about a resource in a course, "Refers to" link displayed when viewer has corresponding course role selected includes symb in the link. Link text is now resource title.

"Refers to" link points to unencrypted resource url if feedback message is viewed under role other than original course, only if user has bre privilege for the resource, otherwise "Refers to" link is not displayed.

lonfeedback -- Some replacement of decode_symb() and &clutter() and &dewrapper() with &get_feedurl_and_clean_symb() for replies and edits of discussion posts.

lonfeedback -- More work on in ensuring hidden urls are encrypted or unencrypted as required.

bug 5037 - destinations for resource content, course content, or course policy can now be filtered based on sender's group memberships.

Use loncommon::blocking_status() to call block checking and generate information for display if discussion board access is blocked.

Restore blocking for bulletin boards.

Provide a message about blocking if a user attempts to edit or reply to a post when he/she is subject to a blocking event.

&check_encrypt() is needed in more places.  Work in progress.

Bug 4972

"Send Message" link now displayed when discussion is closed and hidden.

Also shown when discussion is blocked.

Bugs 1402 and 4309.

When a discussion posting is hidden or deleted, if that post was the last discussion item, then the entry in discussiontimes.db for the resource is set back to the timestamp of the most recent unhidden or undeleted post.

- sigh

- the coprrect typo fix. sorry about that

Apparently a typo.

My best guess about how to fix the syntax errors in this file.

- lots of \w -> probper regexp replacements

- typo

Posts to bulletin boards can now be added to a user's course blog (previously this was only the case for replies).

State of "Add to course blog" checkbox is preserved when user uploads attachments at secondary screen before returning to main composition screen to submit post.

Fixed a typo in &mt('Re: ').

Can set blocking of posting to discussion boards in a course, and to a user's course blog via FDBK.

More concise use of &mt() for internationalization.

Ignore the duplication of message in disnew() and disfolder(), for now, because disnew()'s days are numbered.

bug 4772. Duplicate discussion control bar at the end of the display of discussions to reduce scrolling.

Eliminate $_

Style - push() keys() sort() split()

Internationalization

bug 3872.  Deleting a post now requires clicking a confirm button in the case where a user deletes his/her own post, and when a CC deletes another user's post.

- need to make sure that start page occurs before mstextconverted gets called and before end_page gets called

- xhtml

- reverting 1.194 to fix bug#4968 (real fix will be to swtich to a real html cleaner)

- xhmtl

- BUG#4954 - adding future to the coursedata view of students status

Attachments included in bulletin board posts were not being stored in one case.

- xhtml

- grp_args -> group_args

- style

- style

Access to edit/hide/delete functionality in discussions in group bulletin boards dependent on group privileges.  Breadcrumbs include link back to all grups list when discussion was accessed via 'Groups' link.  For both bulletin boards and discussion attached to resources, filtered display of posts can now be based on group affiliation. For users with mdg or vcg privileges in the course, selection is from all groups, for others selection is from user's own active groups.

- BUG#4895, non-anon bulletin borad posting was broken

- missing end tag

Bulletin Board Posting screen looks better with "Click to add/remove attachments:" and attachments + preview buttons below the textarea rather than at the right side.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

- sticking elments back in there (not needed in firefox but might be somewhere else)
- making the 'Edit an anon post then set the type to anon' JS work again

- convert to use radiobutton to select feedback destination

- had broken anon discussion posting in bulletin boadrs, fixed

- in remote less mode hitting 'send' could cause a new window to get spawned, this occured because the onload handler was trying to submit to the 'loncapaclient' window which could be a different window

- this seems lika better idea

- blog posting setting is remebered when going to a from attachments screen
- page headers added back to attachment screen
- anon versus nonanon is a radiobutton now

- morphing get_sections so it's easier to use

- data_tableing

- data tabling the display options table

- always clear out all bad html in the subject/title line

 -sigh

- adding a missing stat_page

- start_page

Bug #4718: really show first resource

- start_page takes care of registering urls and the loadeventes/ unloadevents needed

- one mode bodytag call

- start_page
-elimintate Continue links in favor of the auto-generated ones

- add redirect abitilies to the head tag and start_page
- get lonfeedback to use them
- add function override to start_page

Re-activating RSS

- converting some interface pages to stop generating </body> <head> </head> </html> and use the helper functions instead

Bug #2748: extra window after feedback

- move putstore logic to lond's side of things
    - changes currently don't handle newer client talking to older lond

Don't throw away the subject of a FDBK message, but make sure that people
do not fake bombs.

Bug 4651.  Specify which roles can edit their own discussion posts.

$newpostsflag is a reference to a scalar. Need to dereference it.

- when no feedback possible, don't show the feedback screen

- diabling access to blog/rss for 2.1

HTML rendering of RSS
Saving my work: edit interface

Implementing Course Journals

- cleanup

Bug #4413: Anonymous not talking to Anonymous (number participants)
Links to appropriate preferences
Deal with "+" in filenames (need to escape symb in links)

Make nicknames work again in discussions

Bug #3495: preview on mail

ADV roles need discussion open at any time. They might have granted extensions,
etc, to certain students or sections, and need to be able to reply to
student postings, even the resource is in another mode for themselves.

- remove course_id as an argument to loncoursedata::get_classlist

- bringing tasks more generally into Lon-CAPA

Bug #3945: there have been enough complaints from authors by now ...

Bug #2977: make anonymous more prominent

- bug#2667, can;t do blin \n to <b /> replaces since, well the newlines might be inside ofa tag. need to parse the HTMl to get it correct

- some silly typos that mad adding attchments not work

- xhtmlizing and adding docs

- wrap_symb ddoes the checking so no need to check it before calling it

- er ? ressymb()? pretty sure it ws supposed to be wrap_symb

Add wrap_symb methods to lonnavmaps::navmap and lonnavmaps::resource to wrap bulletinboard symbs. Use method for resource in lonfeedback and lonwhatsnew to wrap symbs for bulletinboards.

Simplify rewriting of $resource->symb for bulletinboards. More use of &wrap_symb() and &dewrapper().

- increasing the use of loncommon::get_env_multiple

- ENV -> env

- BUG#4021 print discussion setting smaller

- <algebra> works in FDBK

- $r->content_type -> loncommon::content_type

- <html> -> &Apache::lonxml::xmlbegin, thus valid doctypes are now getting output, Yeah! StandardsCmpliance

- backing out the encoding changes for now

- some xhtml cleanups
- one icon -> lonhttpd

- Fixes the WYSIWIG problems, the problem is since we are setting the encoding to UTF-8 on the homewor page, adn we _aren't_ setting it on the feed back generation page, when the WYSIWIG editor generates a   it becoms what ever rthe local encoding that was randomlypicked represents as a non-breaking space. Which muck things up to hell and back. So the fix is set the encoding to UTF-8 everywhere.

- xhtml cleanups
- stuck in a bunch of <label>s

- more icons -> lonhttpd

- more lonhttpd redirects

- making  few more logos go against lonhttpd

Export to IMS now exports discussion content - uses lonfeedback::listdiscussion().  Modification to export of templated documents (syllabus, aboutme, simplepage etc.) to IMS. Simple problems now converted to standard LON-CAPA problem format before export to IMS. Same routines could be used to dump simple problems to CSTR.

Correction to href value for discussion content in IMS export.

Fix so symb is available to create the redirect after clicking "Show all posts" link. Required for 1.137 and later.

Sections in Sort/filter display come from loncommon::get_sections().  Some small display improvements.

Fix bug #3607.  Extend filtering to support multiple selections of roles and/or sections.

- er typo?

Need to pass $symb for discussion_open() to determine if discussion is closed.

Correcting indentation

- encrypturl on discussions should be complet now
	- attachements work and url stays encrypted
- tested with both normal resources and bulletin boards

- off is 0 and on is 1, what a novel concept. :-)

- some more consolidations

- okay convinced myself that chgread never matters, discsymb takes care of it

- moved some $r handling in redirect_back

- restoring indiviual post read/unread toggle form

- even more better encrypturl support in discussions

- ugly, but ixes BUG#3603

Saving my work: cleanup

- adding use lonenc in needed places
- reenabling encrypturl in DOCS

- DISC properly handles encrypturl

- add in an untieHashes

 backport changes from lonnavmaps 1.297 and 1.299, and lonfeedbak 1.127 and 1.128

Fix bug #3515. identification of resources with discussion now occurs in lonfeedback after 'Mark all posts as read call'. To simplify further we might want to eliminate the extra code in lonnavmaps, called when sort is by "Has Discussion" and always do the resource->has_discussion call in lonfeedback.

- always pass navtime
- mark posts read as of navtime

- my backport wasn't correct

- eliminating the visit counting for 1.2, will return in an improved form in 1.3 and right now it is just slowin things down

- backport 1.126

- eliminate the get call on disc prefs, already in $ENV

-  elimintate the screnname/plainname calls already have them in the message

- backport 1.123

Eliminate debugging messages. Indentation changes. Save messages from replication of attachments for IMS.

Escaping discussion post subject and content in attachments upload display.

Fix bug #3469. Make sure that hash values are not only defined but also are NOT ''.

1. Guy's fixes so close date for bulletin boards work correctly, and advanced users can still see posts after close, when display blocked fro students.
2. A fix so subject and comment are preserved when added via HTMLarea during round-trip to add attachments screen.
3. Clean-up: sub build_ims() no longer needed. Export achieved via other routines.

- backport 1.120 1.121

 add <br/> to make things prettier

- add continue links

- typo

- somedays I can speel.

- backport 1.113

- bug#3385, non-htmlarea feedback fails on IE

- logic was incorrect, and thus invalid html was generated in tex mode and thus printing broke.

Moved construction of display of each discussion posting to subroutines (build_posting_display, get_post_contents, get_post_versions, get_post_attachments).  Added support for export of postings to IMS package (still needs additional work).

Cleanup for bug 2838 is done.

Bug 2838 (print attached discussions too) is fixed (finally). I am open to change any info (which can be relevant or not) but the general scheme seems works.

XML now used to store information about multiple attachments.  Still to do: option to set display of attachments inline in post.

Versions of messages and subjects in discussion posts stored in XML.

User can now toggle read/unread for individual discussion posts.

Editing now works for bulletin board posts.

Course Coordinators (and others with lonnet::allowed('rin',$crs)) can now display all versions of a discussion post.

Allow multiple attachments in discussion posts.  Different edited versions can include different (or the same) attachments.
Work still required: clean-up interface, change storage of versioned attachmenturl, message and subject in .db file to XML, add interface for course coordinators (i.e., for lonnet::allowed('rin',$crs)) to display old versions of posts.
Known issues: Edits are not currently stored for bulletin board posts.

Spelling links

 - remove 1.104 and backport 1.105

Spellchecker in Feedback Preview (somehow again missing HTML tags)

More comprehensive fix for Bug #3232 - detects presence of HTMLarea at
runtime, since HTMLarea - even if the code is sent out - can "decide" to
not load.

- backport 1.104

 BUG#3232

- need to protect anything that is going to be put into a <textarea>

Allow posters to edit/delete their own discussion postings.  Controlled by
course parameter set via PARM. Previous versions of postings are preserved.
Deleted postings are hidden. Course Coordinators etc. will be able to see
all versions of postings (interface still needed). Editing currently works for
resource discussions, but not bulletin boards (work in progress).

Use filtering to control which posts are displayed.  1. Restrict display of posts to users with specific roles, status, sections OR 2. Select from list of users whoc have posted.  User interface needs more work.

Can choose different sorting mechanism for discussion posts. Interface provided for filtering of posts for display (by poster's role, status -active/inactive, section). Choices currently have no effect (work-in-progress).

1 - Single click to remove all speech bubbles from NavMap.
2 - Suppress display of link to open empty folder in NavMap

Bug fixes for colspan for threaded discussions, and inline display afetr storing new discussion settings.

Bug 3091 fixes.
Discussion settings now appear after posts, and made more succinct.  Change link goes to another page, where choices can be made.

Not implemented: (a) filtering using ENV{'user.adv'} to disable these options for students - I actually think students might find these options useful rather than confusing. (b) Code to allow user to make any changes also the default option (PREF) - will add this tomorrow.

Work still needed: (a) modify code that builds display when target is 'tex'

- saving some notes

Bug 2838 (print attached discussions too) is fixed.

Bug #3082: submission of feedback in non-htmlarea mode

- remove debug spew

- adding the ability to choose between whether 'closed' discussions are also 'hidden'
 - which is the last of BUG#2636

Misspelled subroutine names are annoying.

- if the discussion is closed, make sure they can't post at all

- discussend parameter now added, closes and hides discussion
    -BUGS#86,2862,and some of 2636

HTMLarea - only have 5 minutes.

There are lots of odd problems with Mozilla, not just meta-refresh, but
also popup windows and one random segmentation fault.

Preview button works now. Only hoping that not some other browsers actually
submit their form when calling their onSubmit method.

* Getting the logic right for "not not blocked"
* Editor language selection from localization files
* Needed to call standard onSubmit before real submit - posting works now
* Preview is still kaputt ...

Bringing up HTMLArea. Doesn't appear to be working, though:

* Preview button is kaputt (but could be disabled if HTMLArea is active)
* Doesn't even seem to post discussions

Stay tuned.

Interface changes. User can toggle two settings:
1. display all posts/only new posts
2. new posts considered read when (a) users marks as read, or (b) automatically, following
display.
Settings for specific discussion override 'global' user preferences.  If no global or local preferences have been set, default is to display all posts, and require user to iclick a link to mark new posts as read.

Set a default display setting for discussions (show only unread/ show all). Default will be overridden by a discussion-specific setting.

- finishuploadfile works better with a directory specfied
- bb posts, and emails no longer use token wrapper

Reverting lonbulletin to v 1.120. Time of the previous visit passed in a query string retrieved in lonfeedback instead, so labelling of posts as "NEW" until user leaves board/resource works for both boards and resources.

Posts in discussions now identified as "NEW" if posts were added since user's last visit to resource or bulletin board.  "Speech bubbles" in NAVMAP also displayed for each resource or bulletin board if posts have been added since last visit.

User can set display to be all posts, or only unread posts.  To support cases where there are several "NEW" posts, the time of the previous visit is passed in a query string during hide/make visible, reply or delete operations so that the differentiation of "NEW" posts is retained until the user leaves the bulletin board.  This behavior does not currently apply to discussions associated with resources.

nohist db file now used.  Also fix bug 2962. Time now recorded for last visit to discussion. "NEW" tag displayed alongside more recent posts.

For discussion posts: added "Title" for each post, and the ability for a user to mark posts as read/unread, and to display only unread posts, or all posts. Read/unread information stored for visible posts for each user in a course-specific db file (e.g., msu_35101d1a78a4060msul1_discuss.db) in lonUsers/$dom/a/b/c/abcuser.  Should this be made a nohist_...db instead???

- backport relevant portions of 1.76 and 1.77

Bug #2712: reply works on bulletin boards
Bug #2696: reply to anonymous postings possible

- sets the http header  BUG#2723

- turning on the code to hide the FDBK discussion if the problem shouldn't allow it.
-  currently only allows view of discussion when in 'CAN_ANSWER' 'CANNOT_ANSWER' modes

Working through some of the FDBK/COM comments, bug #2187

- Part of BUG#2416, make the new bulletin boards backward compatabile with the old ones

- Fixup html
- send headers for threadon/off switch

Send out correct encoding headers.

Bug #2321: Bulletin Board was framed, conflict in non-remote mode.

Threaded discussion done (looks like).

Saving my work on threaded discussions.

Set up table for later display of threads.

Start to respect the "Reply" button. No threaded display yet.

Just saving my work, not a good idea yet.

Tiny steps toward threaded discussion. The "Reply" link does nothing at all
yet.

- xhtmlize

Bug #2226: remove query string from refers-to-URL

Bugs #1960 and #2156: <m> in CHAT and FDBK, just like everywhere else.

- stupid typo
- removing the blind acceptance of the answers target as a form parameter

- an even better solution

- maybe this is better, should fix 2190

Getting status info into list_discussion.