--- loncom/interface/lonhtmlcommon.pm	2004/11/23 14:53:05	1.98
+++ loncom/interface/lonhtmlcommon.pm	2004/11/30 08:06:38	1.100
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common html routines
 #
-# $Id: lonhtmlcommon.pm,v 1.98 2004/11/23 14:53:05 matthew Exp $
+# $Id: lonhtmlcommon.pm,v 1.100 2004/11/30 08:06:38 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -899,23 +899,25 @@ sub crumbs {
     if (! defined($size)) {
         $size = '+2';
     }
+    if ($target) {
+        $target = ' target="'.
+                  &Apache::loncommon::escape_single($target).'"';
+    }
     my $output='';
     unless ($noformat) { $output.='<br /><tt><b>'; }
     $output.='<font size="'.$size.'">'.$prefix.'/';
     if ($ENV{'user.adv'}) {
 	my $path=$prefix.'/';
-	foreach (split('/',$uri)) {
-	    unless ($_) { next; }
-	    $path.=$_;
+	foreach my $dir (split('/',$uri)) {
+            if (! $dir) { next; }
+            $path .= $dir;
 	    unless ($path eq $uri) { $path.='/'; }
-            my $escaped_linkpath = &Apache::loncommon::escape_single($path);
+            my $linkpath = &Apache::loncommon::escape_single($path);
             if ($form) {
-		$escaped_linkpath="javascript:$form.action='".
-                    &Apache::loncommon::escape_single($path).
-                    "';$form.submit();";
+		$linkpath=
+                    qq{javascript:$form.action='$linkpath';$form.submit();};
             }
-	    my $escaped_target   = &Apache::loncommon::escape_single($target);
-	    $output.='<a href="'.$escaped_linkpath.'"'.($target?' target="'.$escaped_target.'"':'').'>'.$_.'</a>/';
+	    $output.=qq{<a href="$linkpath" $target>$dir</a>/};
 	}
     } else {
 	$output.=$uri;