--- loncom/interface/lonindexer.pm	2009/12/02 18:33:27	1.203
+++ loncom/interface/lonindexer.pm	2012/05/07 05:15:00	1.213.4.1
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Directory Indexer
 #
-# $Id: lonindexer.pm,v 1.203 2009/12/02 18:33:27 bisitz Exp $
+# $Id: lonindexer.pm,v 1.213.4.1 2012/05/07 05:15:00 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -120,8 +120,8 @@ sub handler {
     my $colspan=''; 
     
     $extrafield='';
-    my $diropendb = 
-	"/home/httpd/perl/tmp/$env{'user.domain'}_$env{'user.name'}_sel_res.db";
+    my $diropendb = LONCAPA::tempdir() .
+	"$env{'user.domain'}_$env{'user.name'}_sel_res.db";
     %hash = ();
     {
 	my %dbfile;
@@ -165,6 +165,7 @@ sub handler {
 ENDSUBM
        $r->print(&Apache::loncommon::start_page(undef,$js,
 						{'only_body'   =>1,
+                                                 'add_modal' => 1,
 						 'add_entries' =>
 						     {'onload' => "load();"},}
 						).
@@ -321,10 +322,8 @@ function select_group() {
 
 function changeURL(val) {
     if (window.opener.document) {
-        var elementname  = "$element"+"_value";
-        var checkboxname = "$element"+"_setparmval";
+        var elementname  = "$element";
 	window.opener.document.forms["$form"].elements[elementname].value=val;
-        window.opener.document.forms["$form"].elements[checkboxname].checked=true;
     } else {
 	    alert("The file you selected is: "+val);
     }
@@ -392,6 +391,7 @@ function uncheckAll() {
         }
     }
 }
+
 function openWindow(url, wdwName, w, h, toolbar,scrollbar,locationbar) {
     var xpos = (screen.width-w)/2;
     xpos = (xpos < 0) ? '0' : xpos;
@@ -403,6 +403,7 @@ function openWindow(url, wdwName, w, h,
     var newWin = window.open(url, wdwName, options);
     newWin.focus();
 }
+
 function gothere(val) {
     window.location=val+'?acts='+document.forms.fileattr.acts.value$inhibit_menu;
 }
@@ -415,7 +416,7 @@ ENDHEADER
         if ($env{'form.catalogmode'}) {
             # "Popup mode"
             $r->print(&Apache::loncommon::start_page('Browse published resources',$js,
-                                                     {'only_body' => 1,
+                                                     {'only_body' => 1, 'add_modal' =>1, 
                                                       'domain' => $headerdom,}));
         } else {
             # Only display page header and breadcrumbs in non-popup mode
@@ -452,26 +453,29 @@ ENDHEADER
 	    }
 	}
 
+        my @file_categories = &Apache::loncommon::filecategories();
+        my %select_file_categories;
+        my @select_form_order = ('');
+        $select_file_categories{''} = &mt('All file types');
+        foreach my $cat (@file_categories) {
+            my $types = join(",",&Apache::loncommon::filecategorytypes($cat));
+            $select_file_categories{$types} = &mt($cat);
+            push(@select_form_order,$types);
+        }
+        $select_file_categories{'select_form_order'} = \@select_form_order;
+        my $onchange = 'this.form.submit();';
+        my $type_element=
+            &Apache::loncommon::select_form(
+                $typeselect,
+                'only',
+                \%select_file_categories,$onchange);
+        my $type_selector = '<label>'.&mt('File Type Displayed: [_1]',
+                                          $type_element).'</label>';
+
 # ------------------------------- output state of file attributes to be showing
 #                                 All versions has to the last item
 #                                 since it does not take an extra col
 	my %lt=&Apache::lonlocal::texthash(
-					   'ti' => 'Title',
-					   'si' => 'Size',
-					   'la' => 'Last access',
-					   'lm' => 'Last modified',
-					   'st' => 'Statistics',
-					   'au' => 'Author',
-					   'kw' => 'Keywords',
-					   'sb' => 'Subject',
-					   'nt' => 'Notes',
-					   'ab' => 'Abstract',
-					   'ln' => 'Language',
-					   'gl' => 'Grade Level',
-					   'sd' => 'Standards',
-					   'sa' => 'Source Available',
-					   'sr' => 'Show resource',
-					   'li' => 'Linked/Related Resources',
 					   'av' => 'All versions',
 					   'ud' => 'Update Display',
 					   'pr' => 'Problems',
@@ -479,59 +483,61 @@ ENDHEADER
 					   'at' => 'All types',
 					   'hd' => 'Display Options'
 					   );
-	$r->print(<<END);
-<form method="post" name="fileattr" action="$uri" enctype="application/x-www-form-urlencoded">
+        my @disp_order = ('0','4','5','6','13','1','2','3','10','14','8','11','7','12','15','16');
+        my %disp_options = &Apache::lonlocal::texthash (
+                              0  => 'Title',
+                              4  => 'Author',
+                              5  => 'Keywords',
+                              6  => 'Language',
+                              13 => 'Notes',
+                              1  => 'Size',
+                              2  => 'Last access',
+                              3  => 'Last modified',
+                              10 => 'Source Available',
+                              14 => 'Abstract',
+                              8  => 'Statistics',
+                              11 => 'Linked/Related Resources',
+                              7  => 'Show resource',
+                              12 => 'Subject',
+                              15 => 'Grade Level',
+                              16 => 'Standards',
+                           );
+        my $cell = 0;
+        my $numinrow = 4;
+	$r->print('
+<form method="post" name="fileattr" action="'.$uri.'" enctype="application/x-www-form-urlencoded">
 <fieldset>
-<legend>$lt{'hd'}</legend>
-<label><input type="checkbox" name="attr9" value="1" $attrchk[9] onclick="this.form.submit();" /> $lt{'av'}</label>
-<table border="0">
-<tr>
-<td><label><input type="checkbox" name="attr0" value="1" $attrchk[0] onclick="this.form.submit();" /> $lt{'ti'}</label></td>
-<td><label><input type="checkbox" name="attr4" value="1" $attrchk[4] onclick="this.form.submit();" /> $lt{'au'}</label></td>
-<td><label><input type="checkbox" name="attr5" value="1" $attrchk[5] onclick="this.form.submit();" /> $lt{'kw'}</label></td>
-<td><label><input type="checkbox" name="attr6" value="1" $attrchk[6] onclick="this.form.submit();" /> $lt{'ln'}</label></td>
-<td><label><input type="checkbox" name="attr13" value="1" $attrchk[13] onclick="this.form.submit();" /> $lt{'nt'}</label></td>
-<td><label><input type="checkbox" name="attr16" value="1" $attrchk[16] onclick="this.form.submit();" /> $lt{'sd'}</label></td>
-</tr>
-<tr>
-<td><label><input type="checkbox" name="attr1" value="1" $attrchk[1] onclick="this.form.submit();" /> $lt{'si'}</label></td>
-<td><label><input type="checkbox" name="attr2" value="1" $attrchk[2] onclick="this.form.submit();" /> $lt{'la'}</label></td>
-<td><label><input type="checkbox" name="attr3" value="1" $attrchk[3] onclick="this.form.submit();" /> $lt{'lm'}</label></td>
-<td><label><input type="checkbox" name="attr10" value="1" $attrchk[10] onclick="this.form.submit();" /> $lt{'sa'}</label></td>
-<td><label><input type="checkbox" name="attr14" value="1" $attrchk[14] onclick="this.form.submit();" /> $lt{'ab'}</label></td>
-<td>&nbsp;</td>
-</tr>
+<legend>'.$lt{'hd'}.'</legend>
+<table style=" border-collapse: collapse; border-style: none;">'."\n");
+        foreach my $item (@disp_order) {
+            my $style = 'padding-left: 12px; padding-right: 8px;';
+            if ($cell%$numinrow == 0) {
+                $r->print('<tr>');
+            }
+            $cell ++;
+            if ($cell > 3 * $numinrow) {
+                $style .= ' padding-bottom: 6px;'; 
+            }
+            if (defined($disp_options{$item})) {
+                $r->print('<td style="'.$style.'"><span class="LC_nobreak">'.
+                          '<label><input type="checkbox" name="attr'.$item.'" value="1" '.
+                          $attrchk[$item].' onclick="this.form.submit();" /> '.$disp_options{$item}.
+                          '</label></span></td>'."\n");
+            }
+            if ($cell > 1 && $cell%$numinrow == 0) {
+                $r->print('</tr>');
+            }
+        }
+        $r->print(<<END);
 <tr>
-<td><label><input type="checkbox" name="attr8" value="1" $attrchk[8] onclick="this.form.submit();" /> $lt{'st'}</label></td>
-<td><label><input type="checkbox" name="attr11" value="1" $attrchk[11] onclick="this.form.submit();" /> $lt{'li'}</label></td>
-<td><label><input type="checkbox" name="attr7" value="1" $attrchk[7] onclick="this.form.submit();" /> $lt{'sr'}</label></td>
-<td><label><input type="checkbox" name="attr12" value="1" $attrchk[12] onclick="this.form.submit();" /> $lt{'sb'}</label></td>
-<td><label><input type="checkbox" name="attr15" value="1" $attrchk[15] onclick="this.form.submit();" /> $lt{'gl'}</label></td>
-<td>&nbsp;</td>
+<td style="font-style: italic; border-top: 1px solid black; padding-top: 6px"> 
+<label><input type="checkbox" name="attr9" value="1" $attrchk[9] onclick="this.form.submit();" /> $lt{'av'}</label>
+</td>
+<td colspan="3" style="padding-left:8px; padding-top: 4px; font-style: italic; border-top: 1px solid black; padding-top: 8px">$type_selector</td>
 </tr>
 </table>
 <input type="hidden" name="attrs" value="1" />
-END
-        my @file_categories = &Apache::loncommon::filecategories();
-        my %select_file_categories;
-        my @select_form_order = ('');
-        $select_file_categories{''} = &mt('All file types');
-        foreach my $cat (@file_categories) {
-	    my $types = join(",",&Apache::loncommon::filecategorytypes($cat));
-	    $select_file_categories{$types} = &mt($cat);
-	    push(@select_form_order,$types);
-	}
-        $select_file_categories{'select_form_order'} = \@select_form_order;
-        my $type_element=
-            &Apache::loncommon::select_form(
-                $typeselect,
-                'only',
-                %select_file_categories);
-        $type_element = '<label>'.&mt('File Type Displayed: [_1]',
-				      $type_element).'</label>';
-        $r->print($type_element
-                 .'</fieldset>');
-        $r->print(<<END);
+</fieldset>
 <input type="submit" name="updatedisplay" value="$lt{'ud'}" />
 <input type="hidden" name="acts" value="" />
 $closebutton $groupimportbutton
@@ -751,6 +757,8 @@ sub scanDir {
 sub get_list {
     my ($r,$uri)=@_;
     my @list=();
+    my $listerror;
+    
     (my $luri = $uri) =~ s/\//_/g;
     if ($env{'form.updatedisplay'}) {
 	foreach (keys %hash) {
@@ -774,10 +782,20 @@ sub get_list {
 	$hash{'dirlist_files_'.$luri} = join("\n",@list);
     } else {
 # is really a directory
-	@list = &Apache::lonnet::dirlist($uri);
+	(my $listref,$listerror) = &Apache::lonnet::dirlist($uri);
+        if (ref($listref) eq 'ARRAY') {
+            @list = @{$listref};
+        }
 	$hash{'dirlist_files_'.$luri} = join("\n",@list);
 	$hash{'dirlist_timestamp_files_'.$luri} = time;
     }
+#Checking for error messages associated with empty directories or inaccessible servers (See Bug 4984)
+    if (($listerror eq 'no_such_dir') || ($listerror eq 'no_such_host') || ($listerror eq 'no_host')) { 
+        $r->print("<p class='LC_info'>" . &mt("Directory does not exist."). "</p>");
+    } elsif ($listerror eq 'con_lost') {
+        $r->print("<p class='LC_info'>" . &mt("Directory temporarily not accessible."). "</p>");
+    }
+
     return @list=&match_ext($r,@list);    
 }
 
@@ -986,7 +1004,7 @@ $r->print ('<input type="hidden" name="a
         $r->print ($listname.'</a>');
 
         if (defined($plainname) && $plainname) { $r->print(" ($plainname) "); }
-        $r->print('</form>'.$tabtag);
+        $r->print('</form></td>');
         $r->print(&Apache::loncommon::end_data_table_row());
         return OK;
     }
@@ -1068,14 +1086,10 @@ $r->print ('<input type="hidden" name="a
 	$r->print("<img alt=\"\" src='$iconname' class='LC_fileicon' />\n");
 	my $quotable_filelink = &Apache::loncommon::escape_single($filelink);
 
-	$r->print (" <a href=\"javascript:openWindow('".$quotable_filelink.
-		   "?inhibitmenu=yes','previewfile','450','500','no','yes','yes');\"".
-		   " target=\"_self\">$listname</a> ");
+	$r->print (" <a href=\"javascript:openMyModal('".$quotable_filelink."?inhibitmenu=yes',500,500,'yes');\">$listname</a> ");
 	$quotable_filelink = &Apache::loncommon::escape_single($filelink.'.meta');
 	&Apache::loncommon::inhibit_menu_check(\$quotable_filelink);
-	$r->print (" (<a href=\"javascript:openWindow('".$quotable_filelink.
-		   "?inhibitmenu=yes','metadatafile','500','550','no','yes','no');\" ".
-		   " target=\"_self\">".&mt('metadata')."</a>) ");
+	$r->print (" (<a href=\"javascript:openMyModal('".$quotable_filelink."?inhibitmenu=yes',500,500,'yes');\">".&mt('metadata')."</a>) ");
 # Close form to open/close sequence
 	if ($filelink=~/\.(page|sequence)$/) {
 	    $r->print('</form>');
@@ -1223,12 +1237,13 @@ $r->print ('<input type="hidden" name="a
         
         my $location = &Apache::loncommon::lonhttpdurl("/adm/lonIcons");
 	my $icon = "navmap.folder.".($nowOpen ? "open":"closed").'.gif';
-        $r->print ('<a href="javascript:gothere(\''
-		   .$quotable_curdir.'\')"">'
-		   .'<img class="LC_fileicon" alt="'.&mt('Open Folder').'" src="'.
-                   $location."/".$icon.'" />'.
-                   "\n");
-	$r->print ("$listname</a></form></td>\n");
+        $r->print ('<a href="javascript:gothere('
+                  ."'$quotable_curdir'".');">'
+                  .'<img class="LC_fileicon" alt="'.&mt('Open Folder').'" src="'
+                  .$location.'/'.$icon.'" />'
+                  ."\n");
+	$r->print ("$listname</a></form>");
+        $r->print('</td>');
 # Attributes
 	my $filelink = $startdir.$filecom[0].'/default';