CVS log for loncom/interface/lonindexer.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  Backport 1.226, 1.230

- Improve readability in modal pop-up for .js, .css, .txt, and .tab files.

- Reverse change in 1.228. (Modify lonnet.pm instead).

- Fewer calls to courseiddump().

- Trust settings.

- distinguish between home in lonindexer and home in inline menu (requires different translations in German)
- avoid double translation of 'Stored Links' in lonwishlist

- Course Editor has "Standard Problem" item (Grading tab) for creation
  of new problem in user's Authoring Space, or in a Course "Authoring" Space.
- Course Editor has "Import from Course Resources" item (Import tab) to
  import published content from Course "Authoring" Space.
- Course "Authoring" Space
  - default.rights -- course-only access
  - quota is shared with content uploaded directly to course
  - content only browsable in course context
  - metadata not included in searchable meatdata MySQL table
CVs: ----------------------------------------------------------------------

- Coding style.

- For 2.11
  - Backport 1.222, 1.223

- Accommodate single quotes in resource URL in "Stored Links" and in "Edit" link
- Accommodate single quotes in URLs in options in "Select Recent" dropdown list
  when browsing Resource Space.
- Consistent escaping of special characters for Stored Links added when displaying
  a resource in a course, and when browsing Resource Space.

- Coding style: keys()

- For 2.11
  - Backport 1.221

- No import into a course/community for a Stored Link pointing at a directory
  in the Shared Content Repository.

- For 2.11
  - Backport 1.220.

- Remove unused scalars.

- For 2.11
  - Backport 1.219

Exclude HTML tags from translation phrases.
Update corresponding German translation file phrases and translations.

- For 2.11
  - Backport 1.218.

- Test for https in addition to http, when determining if preview should be shown.

- For 2.11
  - Backport 1.216, 1.217.

- Remove package global no longer used, and obsolete documentation following
  changes in rev 1.28, 1.29, 1.31.

Correction to breadcrumbs of "Browse Resources" (-> rev. 1.198):
Replaced hardcoded domain by last accessed domain

FIXME entered

- For 2.11
  - Reverse 1.213.4.1.  Stored Links ("Wishlist") in 2.11.
  - Backport 1.214.

- Wishlist.
  - Replace term "Wishlist" with Stored Links.
  - Modification to documentation in Wishlist.tex to clarify explanation
    of functionality.
  - Rename javascript function: open_Wishlist_Import() in lonmenu.pm
    as open_StoredLinks_Import().

- For 2.11
  Wishlist not in 2.11.

Fix wishlist link in lonindexer
Eliminate some popups in favor of modal windows

Not sure why we have both no_host and no_such_host, but we do

- Change to way lonnet::dirlist() reports an error condition (i.e., no_host,
  con_lost, no_such_dir, empty etc.) when retrieving directory list information
  with ls3, ls2 or ls.
  - error is passed as second item in a pair of return values.
  - first item in return values is a reference to an array of actual files.

Bug 4984

Centralize knowledge of where the tmp directory is within LONCAPA.pm

Added icon for "Set a link for this resource/folder to wishlist". Therefor added a new column in "Browse Resources" containing the icon. In "Search" the icon is just printed after the resource-title. These aren't optimal position for the wishlistlink-icon. The best would be to create a kind of header for resource-previews. There you could place icons like "Set link to wishlist" and "Printout".

- Bug 6251.
  - Third arg is now a ref to a hash, instead of a hash.
  - New (optional) fourth arg, is an additional attribute for the
    select tag, e.g., an onchange action.
- Update calls to loncommon::select_form() accordingly.

- Backport 1.206.

- Fix bug 6231.

- Replace newer <th></th> tags around recent column headings with
   <td><b></b></td> for consistency with older headings (pre 2.10 style).
- Backport 1.205.

- Keep display option attached to corresponding checkbox.
- Reduce number of columns so display options fit within window, when RES browse is a pop-up (e.g.,
  in colorful editor in CSTR).
- CSS to separate display options from filters.
- Generate row mark-up via a loop to reduce repetitive static HTML.

- Eliminate duplicate double quote added in rev 1.190.
- Simplify quoting used for link to javascript:gothere(), used to open folder.

- Backport 1.201, 1.203.

- Customization for GCI_3. (Same change as 1.181.6.2 for GCI_2).

Localization - Corrected "loncommon::select_form" usage:
Only translate once but translate what needs to be translated. Don't translate custom text, e.g. custom folder names.
Even avoid ISE: Unusual but possible special folder names on messages screen used to be misinterpreted.

- Suppress unwanted button/text from lonindexer::showpreview()
   when called by londocsgci.pm in GCI Test assembly.
- Restore standard structuretags.pm behavior in other contexts (e.g., browsing
  in RES space).
- Unwanted <hr/> tag removed in GCI Test assembly context.
- Preview files have .tn extension when generated for GCI Test Assembly.

- Backport 1.183, 1.184, 1.185, 1.186, 1.187, 1.188,
           1.193, 1.194, 1.195, 1.196, 1.197, part of 1.198, 1.199

Font size standardisation for filenames, links, crumbs / Bug 6114:
- lonhtmlcommon::crumbs:
    - Eliminated size (font resize) parameter: Always generate code which uses standard font size. Removed deprecated font size tag.
    - Eliminated noformat parameter: The routine should generate content, not special styles or formats. If a different style/format is really needed, it can be added from outside. Due to consistency, currently no special styles/formats are used, only LC_filename. loncommon:CSTR_pageheader needs to be revisited anyway.
    - Use LC_filename for path and filename
    - Only single space before target attribute
    - Standard code indention
- Decrease default font size for LC_filename
- No different font size for links (<a>)
- CSTR Header: only display lastitem when not empty
- Optimized line breaks on browse resource / import resource screen

- Restricted browsing of RES for Community Coordinators based on bro priv.

Bug 6006

- Backport 1.199.

- Backport part of 1.198.

Improved XHTML validity.

Changes related to modification of LON-CAPA screen header.
- Added breadcrumbs to "Browse Resources" page
- Adjusted page header for popup mode (Edit Course >> Import)
- Consistent Wording: Replaced "Content Library" by "Browse published resources"

- Backport 1.183, 1.184, 1.185, 1.186, 1.187, 1.188,
           1.193, 1.194, 1.195, 1.196, 1.197

XHTML: Added quotes to HTML attribute values in input fields

Refactoring.

Added "Standards" field

Reverted to changes made in 1.192, and added Grade Level to fields

Grade Level and Standards added to import screen

Styles related to earlier changes of "Browse Resources" optimized.

Changed the arrow-icon for sequences, and some little changes on displaying the content in the data-table.

Replace deprecated HTML-Attributes with CSS. Optimized tablelayout for ergonomic reasons.

Box title is now the main title of the next page and the link text or the former page title will be set to the subtitle in the near future.
Group: consistent wording

Unnecessary whitespace removed from 2 fields

Removed unneeded blanks in text of new options
introduced in lonindexer.pm 1.186

Added Notes and Abstract view options to Import table

"Subject" field for importing now an option

- Fix quotes.

- Backport 1.184.
  - xhtml

Replaced all hardcoded nowrap styles with LC_nobreak classes

Added fieldset to display options

"Browse Resources" table:
  - Now uses LON-CAPA standard table
  - Removed hardcoded styles

Note:
Due to the usage of standard sub routines some styles are lost now, e.g. special background color for absolute links and vertical alignment in some cases (which actually needed to be improved anyway). I kept these code lines as comments starting with "#SB".
Another idea is to use a different background color for domain and folder rows.

Localization:
- Added missing mt() call to 'source available' link text
  and changed link text from "Yes" to "Source Code"
- Call locallocaltime now to get localized date/time display for 'last modified' and 'last access'

Localization:
Added missing &mt() for metadata link

	Show or restrict files regardless of letter case of extension.

- tabination
- style
- &mt

	Bug 2633. I think it works now.

	Bug 2633. Use filecategories.tab to populate select.

	Bug 2633. Change from checkbox to dropdown. Might be done.

	Start of filtering by file type. Works, but needs better
	interface. Bug 2633

	Bug 5080: Warn user problem has changed after selecting from
	indexer.

- elimintate some copyied code

- only show (Un)check All buttons of there will be check boxes

- BUG#4168 inhibit the inline menu in the seraching/browsing popup window.

- gettitle only take one arg

	Make check all and uncheck all actually affect what's imported.

	Store fact that title has not been retrieved.

	Call lonnet::gettitle only once and only if needed.

	Should allow sticky checks without breaking other stuff.

	Make the resource selection stick after opening or closing
	directories.

	Bug 4773. Add 'Check All' and 'Uncheck All' buttons.

- fix html errors in lonindexer
- some cssing starts

	Bug 4773. Import folder in its entirety.
	It might work, needs more testing. Also needs
	a "check all" button.

	Saving work in progress. So far just adds useless checkbox
	in front of directories.

	Quote html tag attributes.

- eliminating the domain hash globals in favor of functional access

- starting work on moving to distributed DNS, eliminate usage of the lonnet hostanme global

- flipping open a sequece in lonindexer didn't work correct when resource url had , in it

- the 'All versions' toggle was causing a empty <td> to get added to the listing of directories

- lots of \w -> probper regexp replacements

- BUG#4872

- xhtml

- style

* Bug #4941: avoid getting trapped when clicking previewing during search
* Make display of external resources less ugly

- actually fix #4931

Show me if I am already using a resource in a course

A little bit more Bug #4833: unlink old tmp file on "Update Display"

Partial solution for Bug #4833: don't store thumbnails that were generated in course context.

Jump from Search into Resource Space

Clean up: no need for three database files.
Next step: being able to flip back and forth between import and search

Need at least this so dynamic metadata could work on top level of an author
Still defunct, though

- change add_entries to pass the hash

- some more start_page stuff

Bug #563: show preview in Search

Bug #4546: show courses in RES

- Apache 2 doesn't like it when PerlCleanupHandlers don't return an Apache::Constant (like OK or DECLINED ...)

- figured out how to stop forms from casuing extra newlines in Standards Compliance mode in mozilla/firefox

Back in town.

Trying to persuade Safari to waste less space, only partly successful

Bug #4131 - extra linebreak in sequence display

- ENV -> env

- stupid firefox

- more xhtml fixes

- $r->content_type -> loncommon::content_type

- <html> -> &Apache::lonxml::xmlbegin, thus valid doctypes are now getting output, Yeah! StandardsCmpliance

- backing out the encoding changes for now

- some xhtml cleanups
- one icon -> lonhttpd

Changed javascript_escape calls to escape_single.  I think this module
may be pretty well funky URL clean.

Move javascript_escape into loncommon.pm per Guy's good suggestion.

Move javacript_escape sub to end of file to be consistent with commenting
on file organization in the front of the file.

Defect 3560 fix and probably a few other defects that
have not yet been reported as I got rather global with
this fix within this file.

Escape strings going into javascript sequences so that
- \  -> \\
- '  -> \'

This currently is intended to handle cases where javascript will be handed
'$variable'.

<label>s

Bug 661: Renamed 'group import' 'import'.  There are ways to do this without
breaking the translations if that is deemed important.

- remove log spew

- timestamp the remebered dirlistings  and ignore them after 10 minutes

Added phrase 'updated periodically' to the "Usage Statistics" heading.

Here is the rest of the source code moving code, I also attempted to
keep it all tabinated, anyway, going to close the bug now #78

- 'select' in randomlabel search was failing to work due to thinking blank was a valid HTML form element name.

Also read dynamic metadata for resources inside sequences and pages.

Removing unused (and weird) code.

Resource rendering must be shown in last column, since it takes up so much
room.

Displaying dynamic metadata, including possibility to follow "selection" trail
when browsing.

"People who got this also get that" now works. Still needs stats.

Just saving my work - which doesn't.

New column for links, remove statistics garbage code.

- style police
- spelling police
- trailing if police


- The Police Never Go On Vacation


:-)

More of bug #78 you can now view the code and comming soon copy it to a directory in your construction space (which is proving to be slightly
more hard than expected)

Anyway

- since group sort gets titles, and we do a second pas to grab and set the tile, no need to ever preseed with titles, just slows us down
- fixes bug where if a title wasn't wanted in 'interactive' mode it would blow  up

- when listing /res/ all of domains ended up with the 'inside a map' background color

I like code that compiles.

There we go, titles are nice and happy for when you do a single pick, Group import is being left alone, as it works just great for group imports.  This should
work just fine, will work with all modes, however, it only seems to be useful in edit mode.  If there are more modes it needs to workwith.  it's just a quick
couple of lines of code in the data javascript function and everything is good.

I'm closing bug 2884 now, really, stop reopening it.... <cough> guy </cough> :P

- this properly handles the metadata avoidance to speed things up
 it now
    1) checks if the metadata file already exists, if it does, it always loads the metadata up for that file
    2) if the user is browsing with a metadata field display turned on (stats/title) it always replicates/loads up the metadata for that file
    3) it always provides the link to the metadata

- this means in the simplest case (no metadata display turned on) (just wandering around)
   no data is replicated, but in all cases where metadata is desired to be shown it is shown and is replicated.

Here is the fix for bug 2884 that is better and fixes the problem
without slowing everything down, leaving the 1.101 in there as it
seems
to be good.  If these changes seem to open up some type of blackhole
of
some sort or anything else that is no good, just let me know.

Teaches groupsort about metadata to sort it's self out.  Tested and
works ok.

Better workaround, forces replication.

Bug #2884: titles are back in group import

Bug #2969: HOME in Resource Space for Publishers.

Also moved CC on course creation screen down to the bottom - it had gotten
lost between all of the other settings.

- trying to be UTF8 transparent

Better handling of the "UP" arrow in sequences

Bug #479: View sequence containment history
Be able to group import from sequences and nested sequences

Now correctly registers open/close for sequences. Work on listing next.

Work on making sequences and pages browse- and groupimportable

Improve workflow after sending messages, fix "Cancel"
Start of experiment with lonindexer.pm to display pages and sequences

- fix tabination

Ok, new version, improved, shouldn't replicate Metadata, I hope, passed all the checks I could throw at it, now back to this paper I keep putting off by coding :P

Whoops, cleanup

The bits and pieces to make it use the lond is obsolete process, should be a little faster as it does not depend on ANY meta data so long as you don't have any of the checkboxes checked.  I think, but I don't know how to profile if it's making a call to lonnet or not

Cache renderings in "show resource" mode.

* Fixing problem with the dirPointer hidden variable (should not have been set
in upper form)
* Making groupimport remember selected files when using crumbs to navigate

Work in progress:
* fixed caching of RES directory listings
* reduced number of clicks when selecting view options
* implemented list of recent folders as pulldown (I believe better than bookmarks)

Bug #2335: directory catalog information from default.meta

Remember where we were in Resource Space

- was getting broken images on .rights files
- now all of the icons are genetarted in the same place &Apache::loncommon::icon($file or $url)
- BUG#2531

Crumbs on both /priv and /res

Bread crumbs on top of lonindexer.

Added one &mt() call.

- BUG#2362, sort files listing case insesitively

- needed for BUG#1473, the 'Select' link can now also get you the title of a resource back

Internationalization, some German translations.

Start to respect "obsolete"

Internationalizing.

- part of BUG#1083, versions are pure numbers, not 1a, show files such as
   filename.1a.problem

Use correct domain design.

- Fixes BUG#2033, can rotate the arrows at the domain level again

1. When list /res there is no reason to do any network calls, as it was
   we were trying to do bre checks on /res/msu//res/msu
   which is
    a) wrong
    b) doesn't have a trailing / so metdata tried to get metadata
       which meant we tried to do a repcopy, which meant we tried to find what home server
       user res in domain msu was on which is
        i) stupid
        ii) kinda funny
        iii) cuased us to try to do a network call to everymachine
2. Fixes BUG1963, since we no longer make any network calls when listing /res

3. Have I mentioned how much I love the caller function. Introspection is so much fun.

4. One last line in an attempt to pad out my commit message

Remove review link and change refresh to update display.

fix bug 1357 - show usage stat on number of courses/network hits

Need to be able to see URL of previewed file, also for copy-paste

- BUG 1615, use scoping to force perl to frree the tie variable, so that the tie goes away.
   (At least it looks like it goes away now, and it remebers my last setup)

Bug: 1615.  No longer keep hash tied throught network calls.  Copy all
of the db file into memory, do the lonindexer stuff, copy it back to the
filesystem.  No longer 'untie(%hash)' on errors since the hash is not tied.

- should be using the _users_ domain not the servers domain, (lonsequence.pm was already doing this, only by luck was this not blowing up.)

- bluh, user.name isn't neccessarily unique

Toward bug #1500: this might have already done the trick, but needs lots more
testing.

When show resource option is checked, paint cell if not a resource.
Line up name at top of the cell if resource option is checked - makes it
easier to read name and see resource at the same time.

- trying to use a file named ).problem

Created new subroutine to output only the body of a server-side included
document, both internal and external. Added non-framed mode to lonwrapper
for text-based interface, which still needs a little work.

- added authors name to the lonindexer listing

best wishes to all.

Bug #325
Now shows previews and thumbnails of files in resource space

Now also shows preview of images if desired.

First steps towards being able to render resource in directory browsing

Attempt to better catch and log untied hashes by usage of cleanup handlers.

Together with the cleanup hander on lonsearchcat.pm, we will hopefully never
see "cannot tie hash" again during group search and group import

- fixes startup warnings

Starting to implement common header and color scheme for LON-CAPA handlers
(non-content pages).

Instead of <body bgcolor="#...."><h1>... call

   &Apache::loncommon::bodytag(title,[role],[add_body_parms]);

title: what it says in the header
role (OPTIONAL): override role choice
                 ('admin','coordinator','student','author')
add_body_parms: additional parameters to be put into the body tag, for
                example 'onLoad="init();" or stuff

Colors and layout will likely change in the future, including domain
customization, help function calls, (css?)

COULD PROBABLY GO INTO VERSION 0.5: does list plain text domain name

- emit the no cache headers

- i think the last of bug#574

Minor cleanups and name changes.

add a filter so that files a user does not have permission to view are not
listed.

Change table border color to grey. Should make someone happy.

Add the option to display the title.

Change outline color for table listing of resources.

Fixes Bug 524.  @Omit and @Only are now undef'ed in the handler() call.  The
bug resulted from stale values hanging around.

- lonindexer now deals with titles with HTML and " in them properly (BUG#487)
- Complex RAT needs to escape " before sending them out. (And currently uses &#34 rather than &quot)
- Simple Rat seems to work okay.

Forward "mode" to groupsort

Added 'omit=' and 'only=' tags which cause the indexer to omit (or only
include) files with the given extension.

Changes to allow lonparmset to call lonindexer.  lonindexer now has a
'parmset' mode as well as the earlier added 'edit' mode.  Hopefully these
will be sufficient.  If another mode is needed perhaps a more generalized
interface should be developed.

Fix javascript error, bug #174

Removed debugging call.

Sanity checking on parameters passed in.

Changes to support new browsing functionality in construction space.

okay.. title escaping is really fixed now

escaping single quotes for proper javascript

fixing handling of metadata title so that it gets passed through

sub BEGIN should be BEGIN

use Apache::loncommon added -Scott Harrison

removing language.tab reading since use loncommon function -Scott Harrison

replacing lonnet::fileembstyle with loncommon::fileembstyle -Scott Harrison

removing void context map blocks and replacing with foreach blocks
-Scott Harrison

Now use "unknown.gif" as default icon for 'unk' files (see filetypes.tab).

Added file types taken from www.filext.com (no copyright information is found
on that site).

GPL

updating documentation; entering POD-style tags -Scott

forcing untie of hash at beginning of handler -Scott

fixing authorship info

passing the catalogmode to the groupsort handler

modifying script tag

add an option to suppress/show all versions of a file.

cleaning up code and enabling path into second phase (group sorting)

functional now for group import

catalog mode is now persistent and freshly instantiated

causing display of extrafield to be conditional for interactive

add open just that directory if you click on folder, user or domain icon.
add ability to move up the directory when viewing sub-dir
need a new arrow_up.gif icon.

allow browsing by providing the uri at location. If /res/ is provided, it allows
browsing thru the whole network. Anything else will show only that directory.

working on links without having to go thru all the domains.
clean a few lines of codes

fixing icon directory

group import now creates a long linked list on the RAT user
interface (still in a meaningless order though) -Scott

beginning to implement group import -Scott

altered to support the browse function off of the 'rat' edit
resource window

remembers attribute settings
fix bug in refresh option

minor change in the looping - cut down on looping

fix a bug in meta file link
consolidate all tmp files into one db file
create whitespace gif files based on indent space

add anchors to domain/directory link
add test conditions to scandir

lonindexer now works

Lonindexer moved