--- loncom/interface/lonmenu.pm	2012/08/03 01:23:38	1.383
+++ loncom/interface/lonmenu.pm	2012/10/31 12:54:13	1.389
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Routines to control the menu
 #
-# $Id: lonmenu.pm,v 1.383 2012/08/03 01:23:38 raeburn Exp $
+# $Id: lonmenu.pm,v 1.389 2012/10/31 12:54:13 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -393,8 +393,10 @@ sub secondary_menu {
     }
     $menu =~ s/\[uname\]/$$author{user}/g;
     $menu =~ s/\[udom\]/$$author{dom}/g;
-
-    return "<ul id=\"LC_secondary_menu\">$menu</ul>";
+    if ($menu) {
+        $menu = "<ul id=\"LC_secondary_menu\">$menu</ul>";
+    }
+    return $menu;
 }
 
 sub create_submenu {
@@ -521,7 +523,7 @@ sub innerregister {
         ###
         my $editbutton = '';
         my $noeditbutton = 1;
-        my ($cnum,$cdom);
+        my ($cnum,$cdom,$cfile,$switchserver,$home,$uploaded);
         if ($env{'request.course.id'}) {
             $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
             $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
@@ -553,95 +555,50 @@ sub innerregister {
                 my $home = &Apache::lonnet::homeserver($caname,$cadom);
 		my $allowed=0;
 		my @ids=&Apache::lonnet::current_machine_ids();
-		foreach my $id (@ids) { if ($id eq $home) { $allowed=1; } }
-		if (!$allowed) {
+		if (($home ne 'no_host') && (grep(/^\Q$home\E$/,@ids))) {
 		    $editbutton=&switch('','',6,1,$top,,$bottom,$action,$desc);
-                    $noeditbutton = 0;
                 }
-            }
+            } else {
 #
 # We are an author for some stuff, but currently do not have the role of author.
 # Figure out if we have authoring privileges for the resource we are looking at.
-# This should maybe become a privilege check in lonnet
 #
-            ##
-            ## Determine if user can edit url.
-            ##
-            my $cfile='';
-            my $cfuname='';
-            my $cfudom='';
-            my $uploaded;
-            my $switchserver='';
-            my $home;
-            if ($env{'request.filename'}) {
-                my $file=&Apache::lonnet::declutter($env{'request.filename'});
-                if (defined($cnum) && defined($cdom)) {
-                    $uploaded = &is_course_upload($file,$cnum,$cdom);
-                }
-                if (!$uploaded) {
-
-                    $file=~s{^(priv/$match_domain/$match_username)}{/$1};
-                    $file=~s{^($match_domain/$match_username)}{/priv/$1};
-
-                    # Check that the user has permission to edit this resource
-                    my $setpriv = 1;
-                    ($cfuname,$cfudom)=&Apache::loncacc::constructaccess($file,$setpriv);
-                    if (defined($cfudom)) {
-		        $home=&Apache::lonnet::homeserver($cfuname,$cfudom);
-		        my $allowed=0;
-		        my @ids=&Apache::lonnet::current_machine_ids();
-		        foreach my $id (@ids) { if ($id eq $home) { $allowed=1; } }
-		        if ($allowed) {
-                            $cfile=$file;
-                        } else {
-                            $switchserver=$file;
+                my ($cfile,$switchserver,$home,$uploaded);
+                if ($env{'request.filename'}) {
+                    my $file=&Apache::lonnet::declutter($env{'request.filename'});
+                    ##
+                    ## Determine if user can edit url.
+                    ##
+                    ($cfile,$home,$switchserver,$uploaded) =
+                        &Apache::lonnet::can_edit_resource($file,$cnum,$cdom);
+                }
+                # Turn the button on or off
+                if (($cfile) && ($home ne '') && ($home ne 'no_host')) {
+                    my $nocrsedit;
+                    # Suppress display where CC has switched to student role.
+                    if ($env{'request.course.id'}) {
+                        unless(&Apache::lonnet::allowed('mdc',
+                                                        $env{'request.course.id'})) {
+                            $nocrsedit = 1;
                         }
                     }
-                }
-            }
-            # Finally, turn the button on or off
-            if (($cfile || $switchserver) && !$const_space) {
-                my $nocrsedit;
-                # Suppress display where CC has switched to student role.
-                if ($env{'request.course.id'}) {
-                    unless(&Apache::lonnet::allowed('mdc',
-                                                    $env{'request.course.id'})) {
-                        $nocrsedit = 1;
+                    if ($nocrsedit) {
+                        $editbutton=&clear(6,1);
+                    } else {
+                        $editbutton = &get_editbutton($cfile,$home,$switchserver,$uploaded);
                     }
-                }
-                if ($nocrsedit) {
+                } elsif ($editbutton eq '') {
                     $editbutton=&clear(6,1);
-                } else {
-                    my $bot = "go('$cfile')";
-                    if ($switchserver) {
-                        if ( $env{'request.symb'} && $env{'request.course.id'} ) {
-                            $cfile = '/adm/switchserver?otherserver='.$home.'&amp;role='.
-                                     &HTML::Entities::encode($env{'request.role'},'"<>&').'&amp;symb='.
-                                     &HTML::Entities::encode($env{'request.symb'},'"<>&');
-                            $bot = "need_switchserver('$cfile');";
-                        }
-                    }
-                    $editbutton=&switch
-                       ('','',6,1,'pcstr.png','Edit','resource[_2]',
-                        $bot,"Edit this resource");
-                    $noeditbutton = 0;
                 }
-            } elsif ($editbutton eq '') {
-                $editbutton=&clear(6,1);
             }
-        }
-        if (($noeditbutton) && ($env{'request.filename'})) { 
+        } elsif (($env{'request.filename'}) && $env{'request.course.id'}) {
             if (&Apache::lonnet::allowed('mdc',$env{'request.course.id'})) {
                 my $file=&Apache::lonnet::declutter($env{'request.filename'});
-                if (defined($cnum) && defined($cdom)) {
-                    if (&is_course_upload($file,$cnum,$cdom)) {
-                        my $cfile = &edit_course_upload($file,$cnum,$cdom);
-                        if ($cfile) {
-                            $editbutton=&switch
-                                        ('','',6,1,'pcstr.png','Edit',
-                                         'resource[_2]',"go('".$cfile."');",
-                                         'Edit this resource');
-                        }
+                if (($cnum =~ /$match_courseid/) && ($cdom =~ /$match_domain/)) {
+                    my ($cfile,$home,$switchserver,$uploaded) =
+                        &Apache::lonnet::can_edit_resource($file,$cnum,$cdom);
+                    if (($uploaded) && ($cfile ne '')) {
+                        $editbutton = &get_editbutton($cfile,$home,$switchserver,$uploaded);
                     }
                 }
             }
@@ -753,7 +710,7 @@ ENDREALRES
 	        $menuitems .= (<<ENDMENUITEMS);
 s&8&3&prt.png&Print&printout[_1]&gopost('/adm/printout',currentURL)&Prepare a printable document
 ENDMENUITEMS
-                $gotprt = 1;
+                $got_prt = 1;
             }
             unless ($got_wishlist) {
                 if (($env{'user.adv'}) && (!$env{'request.enc'})) {
@@ -827,40 +784,14 @@ ENDMENUITEMS
            . &Apache::lonhtmlcommon::scripttag('', 'end');
 }
 
-sub is_course_upload {
-    my ($file,$cnum,$cdom) = @_;
-    my $uploadpath = &LONCAPA::propath($cdom,$cnum);
-    $uploadpath =~ s{^\/}{};
-    if (($file =~ m{^\Q$uploadpath\E/userfiles/docs/}) ||
-        ($file =~ m{^userfiles/\Q$cdom\E/\Q$cnum\E/docs/})) {
-        return 1;
-    }
-    return;
-}
-
-sub edit_course_upload {
-    my ($file,$cnum,$cdom) = @_;
-    my $cfile;
-    if ($file =~/\.(htm|html|css|js|txt)$/) {
-        my $ext = $1;
-        my $url = &Apache::lonnet::hreflocation('',$file);
-        my $home = &Apache::lonnet::homeserver($cnum,$cdom);
-        my @ids=&Apache::lonnet::current_machine_ids();
-        my $dest;
-        if ($home && grep(/^\Q$home\E$/,@ids)) {
-            $dest = $url.'?forceedit=1';
-        } else {
-            unless (&Apache::lonnet::get_locks()) {
-                $dest = '/adm/switchserver?otherserver='.
-                        $home.'&role='.$env{'request.role'}.
-                        '&url='.$url.'&forceedit=1';
-            }
-        }
-        if ($dest) {
-            $cfile = &HTML::Entities::encode($dest,'"<>&');
-        }
+sub get_editbutton {
+    my ($cfile,$home,$switchserver,$uploaded) = @_;
+    my $jscall = &Apache::lonhtmlcommon::jump_to_editres($cfile,$home,$switchserver,
+                                                         $uploaded,$env{'request.symb'});
+    if ($jscall) {
+        return &switch('','',6,1,'pcstr.png','Edit','resource[_2]',
+                       $jscall,"Edit this resource");
     }
-    return $cfile;
 }
 
 # ================================================================== Raw Config
@@ -1262,8 +1193,7 @@ sub utilityfunctions {
     my $end_page_annotate = 
         &Apache::loncommon::end_page({'js_ready' => 1});
 
-    my $confirm_switch = &mt("Editing requires switching to the resource's home server.").'\n'.
-                         &mt('Switch server?');
+    my $jumptores = &Apache::lonhtmlcommon::javascript_jumpto_resource();
 
     my $esc_url=&escape($currenturl);
     my $esc_symb=&escape($currentsymb);
@@ -1278,22 +1208,7 @@ return (<<ENDUTILITY)
 
 $dc_popup_cid
 
-function go(url) {
-   if (url!='' && url!= null) {
-       currentURL = null;
-       currentSymb= null;
-       window.location.href=url;
-   }
-}
-
-function need_switchserver(url) {
-    if (url!='' && url!= null) {
-        if (confirm("$confirm_switch")) {
-            go(url); 
-        }
-    }
-    return;
-}
+$jumptores
 
 function gopost(url,postdata) {
    if (url!='') {
@@ -1477,8 +1392,22 @@ sub roles_selector {
     } else {
         $ccrole = 'cc';
     }
-    my $priv;
+    my ($priv,$gotsymb,$destsymb);
     my $destinationurl = $ENV{'REQUEST_URI'};
+    if ($destinationurl =~ /\?symb=/) {
+        $gotsymb = 1;
+    } elsif ($destinationurl =~ m{^/enc/}) {
+        my $plainurl = &Apache::lonenc::unencrypted($destinationurl);
+        if ($plainurl =~ /\?symb=/) {
+            $gotsymb = 1;
+        }
+    }
+    unless ($gotsymb) {
+        $destsymb = &Apache::lonnet::symbread();
+        if ($destsymb ne '') {
+            $destsymb = &Apache::lonenc::check_encrypt($destsymb);
+        }
+    }
     my $reqprivs = &required_privs();
     if (ref($reqprivs) eq 'HASH') {
         my $destination = $destinationurl;
@@ -1566,7 +1495,12 @@ sub roles_selector {
                 $role_selector .= "\n".'<option value="'.$role.'">'.&Apache::lonnet::plaintext($role).'</option>'; 
             }
         }
-        $role_selector .= '</select>'."\n".
+        $role_selector .= '</select>'."\n";
+        if ($destsymb ne '') {
+            $role_selector .= '<input type="hidden" name="destsymb" value="'.
+                              &HTML::Entities::encode($destsymb).'" />'."\n";
+        }
+        $role_selector .=
                '<input type="hidden" name="destinationurl" value="'.
                &HTML::Entities::encode($destinationurl).'" />'."\n".
                '<input type="hidden" name="gotorole" value="1" />'."\n".
@@ -1822,8 +1756,27 @@ sub required_privs {
 
 sub countdown_timer {
     if (($env{'request.course.id'}) && ($env{'request.symb'} ne '') &&
-        ($env{'request.filename'}=~/$LONCAPA::assess_re/) &&
-        ($Apache::inputtags::status[-1] eq 'CAN_ANSWER')) {
+        ($env{'request.filename'}=~/$LONCAPA::assess_re/)) {
+        my ($type,$hastimeleft,$slothastime);
+        my $now = time;
+        if ($env{'request.filename'} =~ /\.task$/) {
+            $type = 'Task';
+        } else {
+            $type = 'problem';
+        }
+        my ($status,$accessmsg,$slot_name,$slot) =
+            &Apache::lonhomework::check_slot_access('0',$type);
+        if ($slot_name ne '') {
+            if (ref($slot) eq 'HASH') {
+                if (($slot->{'starttime'} < $now) &&
+                    ($slot->{'endtime'} > $now)) {
+                    $slothastime = 1;
+                }
+            }
+        }
+        if ($status ne 'CAN_ANSWER') {
+            return;
+        }
         my $duedate = &Apache::lonnet::EXT("resource.0.duedate");
         my @interval=&Apache::lonnet::EXT("resource.0.interval");
         my $hastimeleft;
@@ -1836,9 +1789,11 @@ sub countdown_timer {
             }
         }
         if (($duedate && $duedate > time) ||
-            (!$duedate && $hastimeleft)) {
+            (!$duedate && $hastimeleft) ||
+            ($slot_name ne '' && $slothastime)) {
             my ($collapse,$expand,$alttxt,$title,$currdisp);
-            if (@interval > 1 && $hastimeleft) {
+            if ((@interval > 1 && $hastimeleft) ||
+                ($type eq 'Task' && $slothastime)) {
                 $currdisp = 'inline';
                 $collapse = '&#9658;&nbsp;';
             } else {