--- loncom/interface/lonmodifycourse.pm 2016/10/05 13:59:46 1.86 +++ loncom/interface/lonmodifycourse.pm 2017/01/05 16:17:11 1.90 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # handler for DC-only modifiable course settings # -# $Id: lonmodifycourse.pm,v 1.86 2016/10/05 13:59:46 raeburn Exp $ +# $Id: lonmodifycourse.pm,v 1.90 2017/01/05 16:17:11 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -182,7 +182,7 @@ sub print_course_search_page { $r->print(&Apache::loncommon::build_filters($filterlist,$type,undef,undef,$filter,$action, \$numtitles,'modifycourse',undef,undef,undef, \@codetitles,$dom)); - + my ($actiontext,$roleoption,$settingsoption); if ($type eq 'Community') { $actiontext = &mt('Actions available after searching for a community:'); @@ -203,28 +203,24 @@ sub print_course_search_page { $settingsoption = &mt('View or modify course settings which only a [_1] may modify.',$dctitle); } } elsif (&Apache::lonnet::allowed('rar',$dom)) { - my %adhocroles = &Apache::lonnet::userenvironment($env{'user.domain'},$env{'user.name'}, - 'adhocroles.'.$dom); - if (keys(%adhocroles)) { - my @adhoc = split(',',$adhocroles{'adhocroles.'.$dom}); - if (@adhoc > 1) { + my ($roles_by_num,$description,$accessref,$accessinfo) = &Apache::lonnet::get_all_adhocroles($dom); + if ((ref($roles_by_num) eq 'ARRAY') && (ref($description) eq 'HASH')) { + if (@{$roles_by_num} > 1) { if ($type eq 'Community') { - $roleoption = &mt('Enter the community with one of the available ad hoc roles: [_1].', - join(', ',@adhoc)); + $roleoption = &mt('Enter the community with one of the available ad hoc roles'); } elsif ($type eq 'Placement') { - $roleoption = &mt('Enter the placement test with one of the available ad hoc roles: [_1].', - join(', ',@adhoc)); + $roleoption = &mt('Enter the placement test with one of the available ad hoc roles.'); } else { - $roleoption = &mt('Enter the course with one of the available ad hoc roles: [_1].', - join(', ',@adhoc)); + $roleoption = &mt('Enter the course with one of the available ad hoc roles.'); } } else { + my $rolename = $description->{$roles_by_num->[0]}; if ($type eq 'Community') { - $roleoption = &mt('Enter the community with the ad hoc role of: [_1]',$adhoc[0]); + $roleoption = &mt('Enter the community with the ad hoc role of: [_1]',$rolename); } elsif ($type eq 'Placement') { - $roleoption = &mt('Enter the placement test with the ad hoc role of: [_1]',$adhoc[0]); + $roleoption = &mt('Enter the placement test with the ad hoc role of: [_1]',$rolename); } else { - $roleoption = &mt('Enter the course with the ad hoc role of: [_1]',$adhoc[0]); + $roleoption = &mt('Enter the course with the ad hoc role of: [_1]',$rolename); } } } @@ -245,14 +241,131 @@ sub print_course_search_page { } sub print_course_selection_page { - my ($r,$dom,$domdesc) = @_; + my ($r,$dom,$domdesc,$permission) = @_; my $type = $env{'form.type'}; if (!defined($type)) { $type = 'Course'; } &print_header($r,$type); -# Criteria for course search + if ($permission->{'adhocrole'} eq 'custom') { + my %lt = &Apache::lonlocal::texthash( + title => 'Ad hoc role selection', + preamble => 'Please choose an ad hoc role in the course.', + cancel => 'Click "OK" to enter the course, or "Cancel" to choose a different course.', + ); + my %jslt = &Apache::lonlocal::texthash ( + none => 'You are not eligible to use an ad hoc role for the selected course', + ok => 'OK', + exit => 'Cancel', + ); + &js_escape(\%jslt); + $r->print(<<"END"); + + +
$lt{'preamble'}
+ +$lt{'cancel'}
+
-$porthelpitem $lt{'gpqu'}: MB
+$porthelpitem $lt{'gpqu'}: MB
-$uploadhelpitem $lt{'upqu'}: MB
+$uploadhelpitem $lt{'upqu'}: MB
- +$submit
$hidden_elements $lt{'back'} @@ -632,7 +779,7 @@ ENDDOCUMENT } sub print_set_anonsurvey_threshold { - my ($r,$cdom,$cnum,$cdesc,$type) = @_; + my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; my %lt = &Apache::lonlocal::texthash( 'resp' => 'Responder threshold for anonymous survey submissions display:', 'sufa' => 'Anonymous survey submissions displayed when responders exceeds', @@ -655,13 +802,19 @@ sub print_set_anonsurvey_threshold { } &print_header($r,$type); my $hidden_elements = &hidden_form_elements(); + my ($disabled,$submit); + if ($readonly) { + $disabled = ' disabled="disabled"'; + } else { + $submit = ''; + } my $helpitem = &Apache::loncommon::help_open_topic('Modify_Anonsurvey_Threshold'); $r->print(<-$helpitem $lt{'sufa'}: - +$helpitem $lt{'sufa'}: +$submit
$hidden_elements $lt{'back'} @@ -671,7 +824,7 @@ ENDDOCUMENT } sub print_postsubmit_config { - my ($r,$cdom,$cnum,$cdesc,$type) = @_; + my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; my %lt = &Apache::lonlocal::texthash ( 'conf' => 'Configure submit button behavior after student makes a submission', 'disa' => 'Disable submit button/keypress following student submission', @@ -712,21 +865,27 @@ sub print_postsubmit_config { } &print_header($r,$type); my $hidden_elements = &hidden_form_elements(); + my ($disabled,$submit); + if ($readonly) { + $disabled = ' disabled="disabled"'; + } else { + $submit = ''; + } my $helpitem = &Apache::loncommon::help_open_topic('Modify_Postsubmit_Config'); $r->print(<$helpitem $lt{'disa'}: -
$hidden_elements $lt{'back'} @@ -763,7 +922,7 @@ sub domain_postsubtimeout { } sub print_catsettings { - my ($r,$cdom,$cnum,$cdesc,$type) = @_; + my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; &print_header($r,$type); my %lt = &Apache::lonlocal::texthash( 'back' => 'Pick another action', @@ -784,6 +943,10 @@ sub print_catsettings { my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$cdom); my @cat_params = &catalog_settable($domconf{'coursecategories'},$type); if (@cat_params > 0) { + my $disabled; + if ($readonly) { + $disabled = ' disabled="disabled"'; + } my %currsettings = &Apache::lonnet::get('environment',['hidefromcat','categories'],$cdom,$cnum); if (grep(/^togglecats$/,@cat_params)) { @@ -795,7 +958,7 @@ sub print_catsettings { } $r->print('');
+ '
');
if ($type eq 'Community') {
$r->print(&mt("If a community has been categorized using at least one of the categories defined for communities in the domain, it will be listed in the domain's publicly accessible Course/Community Catalog, unless excluded."));
} elsif ($type eq 'Placement') {
@@ -814,7 +977,7 @@ sub print_catsettings {
if (ref($cathash) eq 'HASH') {
$r->print($lt{'assi'}.'
'.
&Apache::loncommon::assign_categories_table($cathash,
- $currsettings{'categories'},$type));
+ $currsettings{'categories'},$type,$disabled));
} else {
$r->print(&mt('No categories defined for this domain'));
}
@@ -825,8 +988,10 @@ sub print_catsettings {
$r->print('
'.&mt('If auto-cataloging based on institutional code is enabled in the domain, a course will continue to be listed in the catalog of official courses, in addition to receiving a listing under any manually assigned categor(ies).').'
'); } } - $r->print(''); + unless ($readonly) { + $r->print(''); + } } else { $r->print(''); if ($type eq 'Community') { @@ -843,7 +1008,7 @@ sub print_catsettings { } sub print_course_modification_page { - my ($r,$cdom,$cnum,$cdesc,$crstype) = @_; + my ($r,$cdom,$cnum,$cdesc,$crstype,$readonly) = @_; my %lt=&Apache::lonlocal::texthash( 'actv' => "Active", 'inac' => "Inactive", @@ -857,12 +1022,11 @@ sub print_course_modification_page { 'domd' => 'Domain default', 'whom' => 'Who configures', ); - my ($ownertable,$ccrole,$javascript_validations,$authenitems,$ccname); + my ($ownertable,$ccrole,$javascript_validations,$authenitems,$ccname,$disabled); my %enrollvar = &get_enrollment_settings($cdom,$cnum); my %settings = &Apache::lonnet::get('environment',['internal.coursecode','internal.textbook', 'internal.selfenrollmgrdc','internal.selfenrollmgrcc', - 'internal.mysqltables'], - $cdom,$cnum); + 'internal.mysqltables'],$cdom,$cnum); my $type = &Apache::lonuserutils::get_extended_type($cdom,$cnum,$crstype,\%settings); my @specific_managebydc = split(/,/,$settings{'internal.selfenrollmgrdc'}); my @specific_managebycc = split(/,/,$settings{'internal.selfenrollmgrcc'}); @@ -873,9 +1037,12 @@ sub print_course_modification_page { $lt{'nocc'} = &mt('There is currently no owner set for this community.'); } else { $ccrole ='cc'; - ($javascript_validations,$authenitems) = &gather_authenitems($cdom,\%enrollvar); + ($javascript_validations,$authenitems) = &gather_authenitems($cdom,\%enrollvar,$readonly); } $ccname = &Apache::lonnet::plaintext($ccrole,$crstype); + if ($readonly) { + $disabled = ' disabled="disabled"'; + } my %roleshash = &Apache::lonnet::get_my_roles($cnum,$cdom,'','',[$ccrole]); my (@local_ccs,%cc_status,%pname); foreach my $item (keys(%roleshash)) { @@ -916,9 +1083,9 @@ sub print_course_modification_page { foreach my $cc (@local_ccs) { $ownertable .= &Apache::loncommon::start_data_table_row()."\n"; if ($cc eq $enrollvar{'courseowner'}) { - $ownertable .= ''.$hidden_elements. - 'print('this.form.submit();"'); - } else { - $r->print('javascript:verify_message(this.form);"'); + &Apache::lonhtmlcommon::end_pick_box().'
'.$hidden_elements); + unless ($readonly) { + $r->print('print('this.form.submit();"'); + } else { + $r->print('javascript:verify_message(this.form);"'); + } + $r->print(' value="'.$lt{'gobt'}.'" />'); } - $r->print(' value="'.$lt{'gobt'}.'" />
'); + $r->print(''); return; } sub print_selfenrollconfig { - my ($r,$type,$cdesc,$coursehash) = @_; + my ($r,$type,$cdesc,$coursehash,$readonly) = @_; return unless(ref($coursehash) eq 'HASH'); my $cnum = $coursehash->{'num'}; my $cdom = $coursehash->{'domain'}; @@ -1038,7 +1208,7 @@ sub print_selfenrollconfig { ''.$cdesc.'').''."\n"); &Apache::loncreateuser::print_selfenroll_menu($r,'domain',$env{'form.pickedcourse'}, $cdom,$cnum,\%currsettings, - &hidden_form_elements()); + &hidden_form_elements(),$readonly); return; } @@ -1094,7 +1264,7 @@ sub modifiable_only_title { } sub gather_authenitems { - my ($cdom,$enrollvar) = @_; + my ($cdom,$enrollvar,$readonly) = @_; my ($krbdef,$krbdefdom)=&Apache::loncommon::get_kerberos_defaults($cdom); my $curr_authtype = ''; my $curr_authfield = ''; @@ -1118,7 +1288,8 @@ sub gather_authenitems { kerb_def_auth => $krbdef, mode => 'modifycourse', curr_authtype => $curr_authtype, - curr_autharg => $enrollvar->{'autharg'} + curr_autharg => $enrollvar->{'autharg'}, + readonly => $readonly, ); my (%authform,$authenitems); $authform{'krb'} = &Apache::loncommon::authform_kerberos(%param); @@ -2005,13 +2176,7 @@ function changePage(formname,newphase) { if ($phase eq 'setparms') { $js .= $javascript_validations; } elsif ($phase eq 'courselist') { - $js .= qq| - -function gochoose(cname,cdom,cdesc) { - document.courselist.pickedcourse.value = cdom+'_'+cname; - document.courselist.submit(); -} - + $js .= <<"ENDJS"; function hide_searching() { if (document.getElementById('searching')) { document.getElementById('searching').style.display = 'none'; @@ -2019,7 +2184,7 @@ function hide_searching() { return; } -|; +ENDJS } elsif ($phase eq 'setquota') { my $invalid = &mt('The quota you entered contained invalid characters.'); my $alert = &mt('You must enter a number'); @@ -2273,23 +2438,31 @@ sub get_permission { if (&Apache::lonnet::allowed('ccc',$dom)) { $allowed = 1; %permission = ( - setquota => 1, - processquota => 1, - setanon => 1, - processthreshold => 1, - setpostsubmit => 1, - processpostsubmit => 1, - viewparms => 1, - setparms => 1, - processparms => 1, - catsettings => 1, - processcat => 1, - selfenroll => 1, + setquota => 'edit', + processquota => 'edit', + setanon => 'edit', + processthreshold => 'edit', + setpostsubmit => 'edit', + processpostsubmit => 'edit', + viewparms => 'view', + setparms => 'edit', + processparms => 'edit', + catsettings => 'edit', + processcat => 'edit', + selfenroll => 'edit', + adhocrole => 'coord', ); } elsif (&Apache::lonnet::allowed('rar',$dom)) { $allowed = 1; %permission = ( - viewparms => 1, + setquota => 'view', + viewparms => 'view', + setanon => 'view', + setpostsubmit => 'view', + setparms => 'view', + catsettings => 'view', + selfenroll => 'view', + adhocrole => 'custom', ); } return ($allowed,\%permission); @@ -2344,7 +2517,7 @@ sub handler { {href=>"javascript:changePage(document.$phase,'courselist')", text=>$choose_text}); if ($phase eq 'courselist') { - &print_course_selection_page($r,$dom,$domdesc); + &print_course_selection_page($r,$dom,$domdesc,$permission); } else { my ($checked,$cdesc,$coursehash) = &check_course($dom,$domdesc); if ($checked eq 'ok') { @@ -2367,17 +2540,26 @@ sub handler { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'adhocrole')", text=>$enter_text}); - &print_adhocrole_selected($r,$type); + &print_adhocrole_selected($r,$type,$permission); } else { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'menu')", text=>"Pick action"}); my ($cdom,$cnum) = split(/_/,$env{'form.pickedcourse'}); + my ($readonly,$linktext); + if ($permission->{$phase} eq 'view') { + $readonly = 1; + } if (($phase eq 'setquota') && ($permission->{'setquota'})) { + if ($permission->{'setquota'} eq 'view') { + $linktext = 'Set quota'; + } else { + $linktext = 'Display quota'; + } &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')", - text=>"Set quota",}); - &print_setquota($r,$cdom,$cnum,$cdesc,$type); + text=>$linktext}); + &print_setquota($r,$cdom,$cnum,$cdesc,$type,$readonly); } elsif (($phase eq 'processquota') && ($permission->{'processquota'})) { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'setquota')", @@ -2390,7 +2572,7 @@ sub handler { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')", text=>"Threshold for anonymous submissions display"}); - &print_set_anonsurvey_threshold($r,$cdom,$cnum,$cdesc,$type); + &print_set_anonsurvey_threshold($r,$cdom,$cnum,$cdesc,$type,$readonly); } elsif (($phase eq 'processthreshold') && ($permission->{'processthreshold'})) { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'setanon')", @@ -2400,10 +2582,15 @@ sub handler { text=>"Result"}); &modify_anonsurvey_threshold($r,$cdom,$cnum,$cdesc,$domdesc,$type); } elsif (($phase eq 'setpostsubmit') && ($permission->{'setpostsubmit'})) { + if ($permission->{'setpostsubmit'} eq 'view') { + $linktext = 'Submit button behavior post-submission'; + } else { + $linktext = 'Configure submit button behavior post-submission'; + } &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')", - text=>"Configure submit button behavior post-submission"}); - &print_postsubmit_config($r,$cdom,$cnum,$cdesc,$type); + text=>$linktext}); + &print_postsubmit_config($r,$cdom,$cnum,$cdesc,$type,$readonly); } elsif (($phase eq 'processpostsubmit') && ($permission->{'processpostsubmit'})) { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')", @@ -2415,10 +2602,15 @@ sub handler { text=>"Display settings"}); &print_settings_display($r,$cdom,$cnum,$cdesc,$type,$permission); } elsif (($phase eq 'setparms') && ($permission->{'setparms'})) { + if ($permission->{'setparms'} eq 'view') { + $linktext = 'Display settings'; + } else { + $linktext = 'Change settings'; + } &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')", - text=>"Change settings"}); - &print_course_modification_page($r,$cdom,$cnum,$cdesc,$type); + text=>$linktext}); + &print_course_modification_page($r,$cdom,$cnum,$cdesc,$type,$readonly); } elsif (($phase eq 'processparms') && ($permission->{'processparms'})) { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'setparms')", @@ -2431,7 +2623,7 @@ sub handler { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')", text=>"Catalog settings"}); - &print_catsettings($r,$cdom,$cnum,$cdesc,$type); + &print_catsettings($r,$cdom,$cnum,$cdesc,$type,$readonly); } elsif (($phase eq 'processcat') && ($permission->{'processcat'})) { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'catsettings')", @@ -2445,7 +2637,7 @@ sub handler { ({href => "javascript:changePage(document.$phase,'$phase')", text => "Self-enrollment settings"}); if (!exists($env{'form.state'})) { - &print_selfenrollconfig($r,$type,$cdesc,$coursehash); + &print_selfenrollconfig($r,$type,$cdesc,$coursehash,$readonly); } elsif ($env{'form.state'} eq 'done') { &Apache::lonhtmlcommon::add_breadcrumb ({href=>"javascript:changePage(document.$phase,'$phase')",