--- loncom/interface/lonmodifycourse.pm 2004/06/29 14:56:32 1.10
+++ loncom/interface/lonmodifycourse.pm 2009/05/08 17:22:17 1.44
@@ -1,3 +1,8 @@
+# The LearningOnline Network with CAPA
+# handler for DC-only modifiable course settings
+#
+# $Id: lonmodifycourse.pm,v 1.44 2009/05/08 17:22:17 raeburn Exp $
+#
# Copyright Michigan State University Board of Trustees
#
# This file is part of the LearningOnline Network with CAPA (LON-CAPA).
@@ -26,130 +31,353 @@ use strict;
use Apache::Constants qw(:common :http);
use Apache::lonnet;
use Apache::loncommon;
+use Apache::lonhtmlcommon;
use Apache::lonlocal;
-use Apache::londropadd;
+use Apache::lonuserutils;
+use Apache::lonpickcourse;
use LONCAPA::Enrollment;
use lib '/home/httpd/lib/perl';
-use localenroll;
+use LONCAPA;
-sub print_course_selection_page {
- my ($r,$tasklongref) = @_;
- my $dom = $ENV{'user.domain'};
+sub get_dc_settable {
+ return ('courseowner','coursecode','authtype','autharg');
+}
+
+sub catalog_settable {
+ my ($confhash) = @_;
+ my @settable;
+ if (ref($confhash) eq 'HASH') {
+ if ($confhash->{'togglecats'} ne 'crs') {
+ push(@settable,'togglecats');
+ }
+ if ($confhash->{'categorize'} ne 'crs') {
+ push(@settable,'categorize');
+ }
+ } else {
+ push(@settable,('togglecats','categorize'));
+ }
+ return @settable;
+}
+
+sub get_enrollment_settings {
+ my ($cdom,$cnum) = @_;
+ my %settings = &Apache::lonnet::dump('environment',$cdom,$cnum);
+ my %enrollvar;
+ $enrollvar{'autharg'} = '';
+ $enrollvar{'authtype'} = '';
my %lt=&Apache::lonlocal::texthash(
- 'csae' => "Course settings for automated enrollment",
- 'unst' => "Unlike standard LON-CAPA course parameters, such as course description, feedback addresses, and top level map, which are displayed and/or modified using the 'Course Environment Parameters' screen, settings that control automated enrollment based on classlist data available from your institution's student information system are handled differently. Automated enrollment settings fall into two groups: (a) settings that can be modified by a Course Coordinator using the Automated Enrollment Manager and (b) settings that may only be modified by a Domain Coordinator via the 'View/Modify Course settings' menu accessed from this page.",
- 'chcs' => "Choose the course for which you wish to view/modify automated enrollment settings from the select box below and click 'Go' to proceed.",
- 'eaen' => "Each entry in the select box contains: course code -- course title ------- course owner, and entries are ordered alphabetically by course code.",
- 'psac' => "Please select a course",
- 'ccrs' => "Choose a course",
- 'gobt' => "Go"
+ 'noen' => "No end date",
);
-
-# Determine the courses
- my %courseIDs = &Apache::lonnet::courseiddump($dom,'.',1);
- &print_header($r,$tasklongref);
- $r->print(<
-
$lt{'csae'}
-
$lt{'unst'}
-
$lt{'chcs'}
- $lt{'eaen'}
-
-$lt{'ccrs'}:
-
-
-
-
-
-");
- &print_footer($r);
+ return %enrollvar;
+}
+
+sub print_course_search_page {
+ my ($r,$dom,$domdesc) = @_;
+ &print_header($r);
+ my $filterlist = ['descriptfilter',
+ 'instcodefilter','ownerfilter',
+ 'coursefilter'];
+ my $filter = {};
+ my $numtitles;
+ my $type = 'Course';
+ my $action = '/adm/modifycourse';
+ my $cctitle = &Apache::lonnet::plaintext('cc',$type);
+ my $dctitle = &Apache::lonnet::plaintext('dc');
+ $r->print(
+ '
'.&mt('Search for a course in the [_1] domain',$domdesc).'
'.
+ &mt('Actions available after searching for a course:').'
'.
+ '
'.&mt('Enter the course with the role of [_1]',$cctitle).'
'."\n".
+ '
'.&mt('View or modify course settings which only a [_1] may modify.'
+ ,$dctitle).'
'."\n".'
');
+ $r->print(&Apache::lonpickcourse::build_filters($filterlist,$type,
+ undef,undef,$filter,$action,\$numtitles,'modifycourse'));
+}
+
+sub print_course_selection_page {
+ my ($r,$dom,$domdesc) = @_;
+ &print_header($r);
+
+# Criteria for course search
+ my $filterlist = ['descriptfilter',
+ 'instcodefilter','ownerfilter',
+ 'ownerdomfilter','coursefilter'];
+ my %filter;
+ my $type = $env{'form.type'};
+ if ($type eq '') {
+ $type = 'Course';
+ }
+ my $action = '/adm/modifycourse';
+ my $dctitle = &Apache::lonnet::plaintext('dc');
+ $r->print(&mt('Revise your search criteria for this domain').' ('.$domdesc.').
');
+ $r->print(&Apache::lonpickcourse::build_filters($filterlist,$type,
+ undef,undef,\%filter,$action));
+ $filter{'domainfilter'} = $dom;
+ my %courses = &Apache::lonpickcourse::search_courses($r,$type,0,
+ \%filter);
+ &Apache::lonpickcourse::display_matched_courses($r,$type,0,$action,undef,
+ %courses);
return;
}
-sub print_course_modification_page {
- my ($r,$tasklongref,$typeref) = @_;
- my %enrollvar = ();
- my $javascript_validations;
- my $course = '';
- my $dom = $ENV{'user.domain'};
- if ( defined($ENV{'form.course'}) ) {
- $course = $ENV{'form.course'};
- }
- my $ok_course = 'ok';
- if ( ($course == -1) || ($course == '-2') || ($course eq '') ) {
- $ok_course = 'invalid';
- } else {
- $ok_course = &check_course($dom,$course);
+sub print_modification_menu {
+ my ($r,$cdesc,$domdesc,$dom) = @_;
+ &print_header($r,$cdesc);
+ my $type = 'Course';
+ my $action = '/adm/modifycourse';
+ my $cctitle = &Apache::lonnet::plaintext('cc',$type);
+ my $dctitle = &Apache::lonnet::plaintext('dc');
+ my %lt=&Apache::lonlocal::texthash(
+ 'some' => "Certain settings which control auto-enrollment of students from your institution's student information system.",
+ 'crqo' => 'The total disk space allocated for storage of portfolio files in all groups in a course.',
+ );
+ my @menu =
+ (
+ { text => 'Modify quota for group portfolio',
+ phase => 'setquota',
+ },
+ { text => 'Display current settings for automated enrollment',
+ phase => 'viewparms',
+ },
+ { text => 'Modify institutional code, course owner and/or default authentication',
+ phase => 'setparms',
+ },
+ );
+ my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$dom);
+ my @additional_params = &catalog_settable($domconf{'coursecategories'});
+ if (@additional_params > 0) {
+ push (@menu, { text => 'Modify course catalog settings for course',
+ phase => 'catsettings',
+ });
+ }
+ my $menu_html = '
'.&mt('View/Modify settings for: ').$cdesc.'
'."\n".
+ &mt('Although almost all course settings can be modified by a [_1], a number of settings exist which only a [_2] may change:',$cctitle,$dctitle).'
+
+
'.$lt{'some'}.'
+
'.$lt{'crqo'}.'
'."\n";
+ foreach my $item (@additional_params) {
+ if ($item eq 'togglecats') {
+ $menu_html .= '
'.&mt('Hiding a course from the course catalog (can be [_1]configured[_2] to be modifiable in course context)','','').'
';
}
+
+ $r->print($menu_html);
+ return;
+}
- unless ($ok_course eq 'ok') {
- &print_header($r,$tasklongref,'',\$javascript_validations);
- my $reply = " ".&mt("The LON-CAPA course selected was not a valid course for this domain");
- $r->print($reply);
- &print_footer($r);
- return;
+sub print_ccrole_selected {
+ my ($r,$cdesc,$domdesc) = @_;
+ &print_header($r);
+ my ($cdom,$cnum) = split(/_/,$env{'form.pickedcourse'});
+ $r->print('');
+}
+
+sub print_settings_display {
+ my ($r,$cdom,$cnum,$cdesc,$type) = @_;
+ my %enrollvar = &get_enrollment_settings($cdom,$cnum);
+ my %longtype = &course_settings_descrip();
+ my %lt = &Apache::lonlocal::texthash(
+ 'cset' => "Course setting",
+ 'valu' => "Current value",
+ 'caes' => 'Current automated enrollment settings for ',
+ 'cour' => "Course settings that control automated enrollment in this LON-CAPA course are currently:",
+ 'cose' => "Course settings for LON-CAPA courses that control auto-enrollment based on classlist data available from your institution's student information system fall into two groups:",
+ 'dcon' => "Modifiable by DC only",
+ 'back' => "Back to options page",
+ );
+
+ my @bgcolors = ('#eeeeee','#cccccc');
+ my $cctitle = &Apache::lonnet::plaintext('cc',$type);
+ my $dctitle = &Apache::lonnet::plaintext('dc');
+ my @modifiable_params = &get_dc_settable();
+
+ my $disp_table = &Apache::loncommon::start_data_table()."\n".
+ &Apache::loncommon::start_data_table_header_row()."\n".
+ "
+'.$lt{'back'}.'
+'.&mt('Modify [_1]-only settings',$dctitle).''."\n".
+&hidden_form_elements().
+'');
+}
- my @bgcolors=("#eeeeee","#cccccc");
+sub print_setquota {
+ my ($r,$cdom,$cnum,$cdesc,$type) = @_;
+ my $dctitle = &Apache::lonnet::plaintext('dc');
+ my $cctitle = &Apache::lonnet::plaintext('cc',$type);
+ my $subdiv = &mt('Although a [_1] will assign the disk quota for each individual group, the size of the quota is constrained by the total disk space allocated by the [_2] for portfolio files in a course.',$cctitle,$dctitle);
+ my %lt = &Apache::lonlocal::texthash(
+ 'cquo' => 'Disk space for storage of group portfolio',
+ 'gpqu' => 'Course portfolio files disk space',
+ 'each' => 'Each course group can be assigned a quota for portfolio files uploaded to the group.',
+ 'modi' => 'Save',
+ 'back' => "Back to options page",
+ );
+ my %settings = &Apache::lonnet::get('environment',['internal.coursequota'],$cdom,$cnum);
+ my $coursequota = $settings{'internal.coursequota'};
+ if ($coursequota eq '') {
+ $coursequota = 20;
+ }
+ &print_header($r,$cdesc);
+ my $hidden_elements = &hidden_form_elements();
+ $r->print(<
+
$lt{'cquo'}.
+
+$lt{'each'}
+$subdiv
+
+$lt{'gpqu'}: Mb
+
+
+$hidden_elements
+$lt{'back'}
+
+ENDDOCUMENT
+ return;
+}
+
+sub print_catsettings {
+ my ($r,$cdom,$cnum,$cdesc) = @_;
+ &print_header($r,$cdesc);
+ my %lt = &Apache::lonlocal::texthash(
+ 'back' => 'Back to options page',
+ );
+ $r->print(''."\n");
+ return;
+}
+
+sub print_course_modification_page {
+ my ($r,$cdom,$cnum,$cdesc,$domdesc) = @_;
+ my %longtype = &course_settings_descrip();
+ my %enrollvar = &get_enrollment_settings($cdom,$cnum);
my $ownertable;
my %lt=&Apache::lonlocal::texthash(
'actv' => "Active",
@@ -158,21 +386,20 @@ sub print_course_modification_page {
'noen' => "No end date",
'ownr' => "Owner",
'name' => "Name",
- 'unme' => "Username",
+ 'unme' => "Username:Domain",
'stus' => "Status",
- 'aecs' => "Automated Enrollment Course Settings",
+ 'cquo' => "Disk space for storage of group portfolio",
+ 'gpqu' => "Course portfolio files disk space",
+ 'each' => "Each course group can be assigned a quota for portfolio files uploaded to the group.",
'cose' => "Course settings for LON-CAPA courses that control automated student enrollment based on classlist data available from your institution's student information system fall into two groups: (a) settings that can be modified by a Course Coordinator using the ",
'aenm' => "Automated Enrollment Manager",
'andb' => " and (b) settings that may only be modified by a Domain Coordinator via this page.",
'caes' => 'Current automated enrollment settings',
'cour' => "Course settings that control automated enrollment in this LON-CAPA course
are currently:",
- 'cset' => "Course setting",
- 'valu' => "Current value",
'nocc' => "There is currently no course owner set for this course. In addition, no active course coordinators from this LON-CAPA domain were found, so you will not be able assign a course owner. If you wish to assign a course owner, it is recommended that you use the 'User Roles' screen to add a course coordinator with a LON-CAPA account in this domain to the course.",
'ccus' => "A course coordinator can use the 'Automated Enrollment Manager' to change
all settings except course code, course owner, and default authentication method for students added to your course (who are also new to the LON-CAPA system at this domain).",
- 'mkch' => "Make changes to course settings set by Domain Coordinator",
'ccod' => "Course Code",
'ccus' => "The course code is used during automated enrollment to map the internal LON-CAPA course ID for this course to the corresponding course section ID(s) used by the office responsible for providing official class lists for courses at your institution.",
'cown' => "Course Owner",
@@ -181,73 +408,50 @@ all settings except course code, course
'usrd' => 'Use the radio buttons to select a different course owner.',
'deam' => "Default Authentication method",
'deus' => "The default authentication method, and default authentication parameter (domain, initial password or argument) are used when automatic enrollment of students in a course requires addition of new user accounts in your domain, and the class list file contains empty entries for the <authtype> and <autharg> properties for the new student. If you choose 'internally authenticated', and leave the initial password field empty, the automated enrollment process will create a randomized password for each new student account that it adds to your LON-CAPA domain.",
- 'gobt' => "Modify settings",
+ 'gobt' => "Save",
);
+ my @bgcolors = ('#eeeeee','#cccccc');
- my %settings = &Apache::lonnet::dump('environment',$dom,$course);
- $enrollvar{'autharg'} = '';
- $enrollvar{'authtype'} = '';
- foreach my $item (keys %settings) {
- if ($item =~ m/^internal\.(.+)$/) {
- if ( ($1 eq "autoadds") || ($1 eq "autodrops") ) {
- if ($settings{$item} == 1) {
- $enrollvar{$1} = "ON";
- } else {
- $enrollvar{$1} = "OFF";
- }
- } elsif ( ($1 eq "autostart") || ($1 eq "autoend") ) {
- if ( ($1 eq "autoend") && ($settings{$item} == 0) ) {
- $enrollvar{$1} = $lt{'noen'};
- } else {
- $enrollvar{$1} = localtime($settings{$item});
- }
- } elsif ($1 eq "courseowner" || $1 eq "authtype" || $1 eq "autharg" || $1 eq "sectionnums" || $1 eq "coursecode" || $1 eq "crosslistings") {
- $enrollvar{$1} = $settings{$item};
- }
- } elsif ($item =~ m/^default_enrollment_(start|end)_date$/) {
- if ( ($1 eq 'end') && ($settings{$item} == 0) ) {
- $enrollvar{$item} = $lt{'noen'};
- } elsif ( ($1 eq 'start') && ($settings{$item} eq '') ) {
- $enrollvar{$item} = 'When enrolled';
- } else {
- $enrollvar{$item} = localtime($settings{$item});
- }
- }
- }
-
- my @coursepersonnel = &Apache::lonnet::getkeys('nohist_userroles',$dom,$course);
+ my @coursepersonnel = &Apache::lonnet::getkeys('nohist_userroles',$cdom,$cnum);
my @local_ccs = ();
my %cc_status = ();
my %pname = ();
my $active_cc;
- foreach (@coursepersonnel) {
- my @roleinfo = split/:/,$_;
- if ( ($roleinfo[0] eq 'cc') && ($roleinfo[2] eq $dom) ) {
- unless (grep/^$roleinfo[1]$/,@local_ccs) {
- $active_cc = &LONCAPA::Enrollment::check_user_status($roleinfo[2],$roleinfo[1],$dom,$course,'cc');
- if ($active_cc eq 'ok') {
- push @local_ccs, $roleinfo[1];
- $pname{$roleinfo[1]} = &Apache::loncommon::plainname($roleinfo[1],$roleinfo[2]);
- $cc_status{$roleinfo[1]} = $lt{'actv'};
+ foreach my $person (@coursepersonnel) {
+ my ($role,$user) = split(/:/,$person,2);
+ $user =~ s/:$//;
+ if (($role eq 'cc') && ($user ne '')) {
+ if (!grep(/^\Q$user\E$/,@local_ccs)) {
+ my ($ccname,$ccdom) = split(/:/,$user);
+ $active_cc =
+ &Apache::loncommon::check_user_status($ccdom,$ccname,$cdom,
+ $cnum,'cc');
+ if ($active_cc eq 'active') {
+ push(@local_ccs,$user);
+ $pname{$user} = &Apache::loncommon::plainname($ccname,$ccdom);
+ $cc_status{$user} = $lt{'actv'};
}
}
}
}
- unless ( (grep/^$enrollvar{'courseowner'}$/,@local_ccs) || ($enrollvar{'courseowner'} eq '') ) {
- push @local_ccs, $enrollvar{'courseowner'};
- $pname{$enrollvar{'courseowner'}} = &Apache::loncommon::plainname($enrollvar{'courseowner'},$dom);
- $active_cc = &LONCAPA::Enrollment::check_user_status($dom,$enrollvar{'coursecode'},$dom,$course,'cc');
- if ($active_cc eq 'ok') {
+ if ( (!grep(/^$enrollvar{'courseowner'}$/,@local_ccs)) &&
+ ($enrollvar{'courseowner'} ne '') ) {
+ my ($owneruname,$ownerdom) = split(/:/,$enrollvar{'courseowner'});
+ push(@local_ccs,$enrollvar{'courseowner'});
+ $pname{$enrollvar{'courseowner'}} =
+ &Apache::loncommon::plainname($owneruname,$ownerdom);
+ $active_cc = &Apache::loncommon::check_user_status($ownerdom,$owneruname,
+ $cdom,$cnum,'cc');
+ if ($active_cc eq 'active') {
$cc_status{$enrollvar{'courseowner'}} = $lt{'actv'};
} else {
$cc_status{$enrollvar{'courseowner'}} = $lt{'inac'};
}
}
my $numlocalcc = @local_ccs;
- my $bodytag=&Apache::loncommon::bodytag(&mt("Modify Course Settings"));
+
my $helplink=&Apache::loncommon::help_open_topic('Modify_Course',&mt("Help on Modifying Courses"));
- my $defdom=$ENV{'request.role.domain'};
- my ($krbdef,$krbdefdom)=&Apache::loncommon::get_kerberos_defaults($defdom);
+ my ($krbdef,$krbdefdom)=&Apache::loncommon::get_kerberos_defaults($cdom);
my $curr_authtype = '';
my $curr_authfield = '';
if ($enrollvar{'authtype'} =~ /^krb/) {
@@ -259,48 +463,24 @@ all settings except course code, course
}
unless ($curr_authtype eq '') {
$curr_authfield = $curr_authtype.'arg';
- }
- $javascript_validations=&Apache::londropadd::javascript_validations('modifycourse',$krbdefdom,$curr_authtype,$curr_authfield);
- my %param = ( formname => 'document.cmod',
+ }
+ my $javascript_validations=&Apache::lonuserutils::javascript_validations('modifycourse',$krbdefdom,$curr_authtype,$curr_authfield);
+ my %param = ( formname => 'document.'.$env{'form.phase'},
kerb_def_dom => $krbdefdom,
kerb_def_auth => $krbdef,
mode => 'modifycourse',
curr_authtype => $curr_authtype,
curr_autharg => $enrollvar{'autharg'}
);
- my $krbform = &Apache::loncommon::authform_kerberos(%param);
- my $intform = &Apache::loncommon::authform_internal(%param);
- my $locform = &Apache::loncommon::authform_local(%param);
-
- my $disp_table = qq|
-
-
-
-
-
-
-
-
$lt{'cset'}
-
$lt{'valu'}
-
- |;
- my $iter = 0;
- foreach my $key (sort keys %enrollvar) {
- my $colflag = $iter%2;
- $disp_table .= "
-
$$typeref{$key}
-
$enrollvar{$key}
-
";
- $iter ++;
- }
- $disp_table .= "
-
-
-
-
-
-
";
-
+ my (%authform,$authenitems);
+ $authform{'krb'} = &Apache::loncommon::authform_kerberos(%param);
+ $authform{'int'} = &Apache::loncommon::authform_internal(%param);
+ $authform{'loc'} = &Apache::loncommon::authform_local(%param);
+ foreach my $item ('krb','int','loc') {
+ if ($authform{$item} ne '') {
+ $authenitems .= $authform{$item}.' ';
+ }
+ }
if ($numlocalcc == 0) {
$ownertable = $lt{'nocc'};
}
@@ -311,81 +491,53 @@ all settings except course code, course
-
$lt{'tabl'} ($dom). $lt{'usrd'}
+
$lt{'tabl'} - $cdom ($domdesc). $lt{'usrd'}
-
-
-
-
-
-
-
-
-
-
$lt{'ownr'}
-
$lt{'name'}
-
$lt{'unme'}
-
$lt{'stus'}
-
- );
- for (my $i=0; $i<@local_ccs; $i++) {
- my $colflag = $i%2;
- $ownertable .= "
Use the appropriate text boxes and radio buttons below to change some or all of the four automated enrollment settings that may only be changed by a Domain Coordinator. Click the "$lt{'gobt'}" button to save your changes.
+
Use the appropriate text boxes and radio buttons below to change some or all of the four automated enrollment settings that may only be changed by a Domain Coordinator.
ENDDOCUMENT
- &print_footer($r);
return;
}
sub modify_course {
- my ($r,$tasklongref,$typeref) = @_;
- my $dom = $ENV{'user.domain'};
- my $crs = $ENV{'form.course'};
- unless ( &check_course($dom,$crs) eq 'ok' ) {
- &print_header($r,$tasklongref);
- my $reply = " ".&mt("The LON-CAPA course selected was not a valid course for this domain");
- $r->print($reply);
- &print_footer($r);
- return;
- }
-
- my %settings = &Apache::lonnet::get('environment',['internal.courseowner','internal.coursecode','internal.authtype','internal.autharg','internal.sectionnums','internal.crosslistings','description'],$dom,$crs);
+ my ($r,$cdom,$cnum,$cdesc,$domdesc,$type) = @_;
+ my %longtype = &course_settings_descrip();
+ my %settings = &Apache::lonnet::get('environment',['internal.courseowner','internal.coursecode','internal.authtype','internal.autharg','internal.sectionnums','internal.crosslistings','description'],$cdom,$cnum);
my %currattr = ();
my %newattr = ();
my %cenv = ();
@@ -458,9 +593,10 @@ sub modify_course {
my @nochanges = ();
my @sections = ();
my @xlists = ();
- my $changecode = 0;
- my $changeowner = 0;
- unless ($settings{'internal.sectionnums'} eq'') {
+ my %changed = ( code => 0,
+ owner => 0,
+ );
+ unless ($settings{'internal.sectionnums'} eq '') {
if ($settings{'internal.sectionnums'} =~ m/,/) {
@sections = split/,/,$settings{'internal.sectionnums'};
} else {
@@ -475,29 +611,27 @@ sub modify_course {
}
}
- my @params = ('courseowner','coursecode','authtype','autharg');
- foreach (@params) {
- my $attr = 'internal.'.$_;
- $currattr{$_} = $settings{$attr};
+ my @modifiable_params = &get_dc_settable();
+ foreach my $param (@modifiable_params) {
+ my $attr = 'internal.'.$param;
+ $currattr{$param} = $settings{$attr};
}
my $description = $settings{'description'};
- my %cenv = ();
- if ($ENV{'form.login'} eq 'krb') {
- $newattr{'authtype'} = $ENV{'form.login'};
- $newattr{'authtype'} .= $ENV{'form.krbver'};
- $newattr{'autharg'} = $ENV{'form.krbarg'};
- $newattr{'autharg'} =~ tr/a-z/A-Z/;
- } elsif ($ENV{'form.login'} eq 'int') {
+ if ($env{'form.login'} eq 'krb') {
+ $newattr{'authtype'} = $env{'form.login'};
+ $newattr{'authtype'} .= $env{'form.krbver'};
+ $newattr{'autharg'} = $env{'form.krbarg'};
+ } elsif ($env{'form.login'} eq 'int') {
$newattr{'authtype'} ='internal';
- if ((defined($ENV{'form.intarg'})) && ($ENV{'form.intarg'})) {
- $newattr{'autharg'} = $ENV{'form.intarg'};
+ if ((defined($env{'form.intarg'})) && ($env{'form.intarg'})) {
+ $newattr{'autharg'} = $env{'form.intarg'};
}
- } elsif ($ENV{'form.login'} eq 'loc') {
+ } elsif ($env{'form.login'} eq 'loc') {
$newattr{'authtype'} = 'localauth';
- if ((defined($ENV{'form.locarg'})) && ($ENV{'form.locarg'})) {
- $newattr{'autharg'} = $ENV{'form.locarg'};
+ if ((defined($env{'form.locarg'})) && ($env{'form.locarg'})) {
+ $newattr{'autharg'} = $env{'form.locarg'};
}
}
if ( $newattr{'authtype'}=~ /^krb/) {
@@ -507,65 +641,68 @@ sub modify_course {
}
}
- if ( exists($ENV{'form.courseowner'}) ) {
- my $ownerparam = 'username_'.$ENV{'form.courseowner'};
- if ( exists($ENV{"form.$ownerparam"}) ) {
- $newattr{'courseowner'}=$ENV{"form.$ownerparam"};
- unless ( $newattr{'courseowner'} eq $currattr{'courseowner'} ) {
- $changeowner = 1;
- }
+ if ( exists($env{'form.courseowner'}) ) {
+ $newattr{'courseowner'}=$env{'form.courseowner'};
+ unless ( $newattr{'courseowner'} eq $currattr{'courseowner'} ) {
+ $changed{'owner'} = 1;
}
}
- if ( exists($ENV{'form.coursecode'}) ) {
- $newattr{'coursecode'}=$ENV{'form.coursecode'};
+ if ( exists($env{'form.coursecode'}) ) {
+ $newattr{'coursecode'}=$env{'form.coursecode'};
unless ( $newattr{'coursecode'} eq $currattr{'coursecode'} ) {
- $changecode = 1;
- my $courseid_entry = &Apache::lonnet::escape($dom.'_'.$crs).'='.&Apache::lonnet::escape($description).'='.&Apache::lonnet::escape($ENV{'form.coursecode'});
- &Apache::lonnet::courseidput($dom,$courseid_entry,&Apache::lonnet::homeserver($crs,$dom));
+ $changed{'code'} = 1;
}
}
-
- foreach (@params) {
- if ($currattr{$_} eq $newattr{$_}) {
- push @nochanges, $_;
+ if ($changed{'owner'} || $changed{'code'}) {
+ my %crsinfo = &Apache::lonnet::courseiddump($cdom,'.',1,'.','.',$cnum,
+ undef,undef,'.');
+ if (ref($crsinfo{$env{'form.pickedcourse'}}) eq 'HASH') {
+ $crsinfo{$env{'form.pickedcourse'}}{'inst_code'} = $env{'form.coursecode'};
+ $crsinfo{$env{'form.pickedcourse'}}{'owner'} = $env{'form.courseowner'};
+ my $chome = &Apache::lonnet::homeserver($cnum,$cdom);
+ my $putres = &Apache::lonnet::courseidput($cdom,\%crsinfo,$chome,'notime');
+ }
+ }
+ foreach my $param (@modifiable_params) {
+ if ($currattr{$param} eq $newattr{$param}) {
+ push(@nochanges,$param);
} else {
- my $attr = 'internal.'.$_;
- $cenv{$attr} = $newattr{$_};
- push @changes, $_;
+ my $attr = 'internal.'.$param;
+ $cenv{$attr} = $newattr{$param};
+ push(@changes,$param);
}
}
-
if (@changes > 0) {
$chgresponse = &mt("The following automated enrollment parameters have been changed:
");
}
if (@nochanges > 0) {
$nochgresponse = &mt("The following automated enrollment parameters remain unchanged:
");
}
- if (@changes > 0) {
- my $putreply = &Apache::lonnet::put('environment',\%cenv,$dom,$crs);
+ if (@changes > 0) {
+ my $putreply = &Apache::lonnet::put('environment',\%cenv,$cdom,$cnum);
if ($putreply !~ /^ok$/) {
- $response = &mt("There was a problem processing your requested changes. The automated enrollment settings for this course have been left unchanged. ");
+ $response = &mt("There was a problem processing your requested changes. The automated enrollment settings for this course have been left unchanged. ").&mt('Error: ').$putreply;
} else {
- foreach my $attr (@params) {
+ foreach my $attr (@modifiable_params) {
if (grep/^$attr$/,@changes) {
- $chgresponse .= "
$$typeref{$attr} ".&mt("now set to \"").$newattr{$attr}."\".
";
+ $chgresponse .= "
$longtype{$attr} ".&mt("now set to \"").$newattr{$attr}."\".
";
} else {
- $nochgresponse .= "
$$typeref{$attr} ".&mt("still set to \"").$currattr{$attr}."\".
";
+ $nochgresponse .= "
$longtype{$attr} ".&mt("still set to \"").$currattr{$attr}."\".
";
}
}
- if ($changecode || $changeowner) {
+ if ($changed{'code'} || $changed{'owner'}) {
if ( $newattr{'courseowner'} eq '') {
$warning .= &mt("There is no owner associated with this LON-CAPA course. If automated enrollment in LON-CAPA courses at your institution requires validation of course owners, automated enrollment will fail for this course. ");
} else {
if (@sections > 0) {
- if ($changecode) {
+ if ($changed{'code'}) {
foreach my $sec (@sections) {
if ($sec =~ m/^(.+):/) {
my $inst_course_id = $newattr{'coursecode'}.$1;
- my $course_check = &Apache::lonnet::auto_validate_courseID($crs,$dom,$inst_course_id);
+ my $course_check = &Apache::lonnet::auto_validate_courseID($cnum,$cdom,$inst_course_id);
if ($course_check eq 'ok') {
- my $outcome = &Apache::lonnet::auto_new_course($crs,$dom,$inst_course_id,$newattr{'courseowner'});
+ my $outcome = &Apache::lonnet::auto_new_course($cnum,$cdom,$inst_course_id,$newattr{'courseowner'});
unless ($outcome eq 'ok') {
$warning .= &mt("If automatic enrollment is enabled for LON-CAPA course: ").$description.&mt(", automated enrollment may fail for ").$newattr{'coursecode'}.&mt(" - section $1 for the following reason: $outcome. ");
}
@@ -576,11 +713,11 @@ sub modify_course {
$warning .= &mt("If automatic enrollment is enabled for LON-CAPA course: ").$description.&mt(", automated enrollment may fail for ").$newattr{'coursecode'}.&mt(" - section $sec because this is not a valid section entry. ");
}
}
- } elsif ($changeowner) {
+ } elsif ($changed{'owner'}) {
foreach my $sec (@sections) {
if ($sec =~ m/^(.+):/) {
my $inst_course_id = $newattr{'coursecode'}.$1;
- my $outcome = &Apache::lonnet::auto_new_course($crs,$dom,$inst_course_id,$newattr{'courseowner'});
+ my $outcome = &Apache::lonnet::auto_new_course($cnum,$cdom,$inst_course_id,$newattr{'courseowner'});
unless ($outcome eq 'ok') {
$warning .= &mt("If automatic enrollment is enabled for LON-CAPA course: ").$description.&mt(", automated enrollment may fail for ").$newattr{'coursecode'}.&mt(" - section $1 for the following reason: $outcome. ");
}
@@ -592,26 +729,25 @@ sub modify_course {
} else {
$warning .= &mt("As no section numbers are currently listed for LON-CAPA course: ").$description.&mt(", automated enrollment will not occur for any sections of coursecode: ").$newattr{'coursecode'}." ";
}
- if ( (@xlists > 0) && ($changeowner) ) {
+ if ( (@xlists > 0) && ($changed{'owner'}) ) {
foreach my $xlist (@xlists) {
if ($xlist =~ m/^(.+):/) {
- my $outcome = &Apache::lonnet::auto_new_course($crs,$dom,$1,$newattr{'courseowner'});
+ my $outcome = &Apache::lonnet::auto_new_course($cnum,$cdom,$1,$newattr{'courseowner'});
unless ($outcome eq 'ok') {
$warning .= &mt("If automatic enrollment is enabled for LON-CAPA course: ").$description.&mt(", automated enrollment may fail for crosslisted class: ").$1.&mt(" for the following reason: $outcome. ");
}
- }
+ }
}
}
}
}
}
} else {
- foreach my $attr (@params) {
- $nochgresponse .= "
$$typeref{$attr} ".&mt("still set to")." \"".$currattr{$attr}."\".