--- loncom/interface/lonmodifycourse.pm 2019/08/27 15:34:34 1.79.2.8 +++ loncom/interface/lonmodifycourse.pm 2016/10/05 13:59:46 1.86 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # handler for DC-only modifiable course settings # -# $Id: lonmodifycourse.pm,v 1.79.2.8 2019/08/27 15:34:34 raeburn Exp $ +# $Id: lonmodifycourse.pm,v 1.86 2016/10/05 13:59:46 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -39,9 +39,6 @@ use Apache::lonpickcourse; use lib '/home/httpd/lib/perl'; use LONCAPA qw(:DEFAULT :match); -my $registered_cleanup; -my $modified_dom; - sub get_dc_settable { my ($type,$cdom) = @_; if ($type eq 'Community') { @@ -52,10 +49,6 @@ sub get_dc_settable { if (&showcredits($cdom)) { push(@items,'defaultcredits'); } - my %passwdconf = &Apache::lonnet::get_passwdconf($cdom); - if (($passwdconf{'crsownerchg'}) && ($type ne 'Placement')) { - push(@items,'nopasswdchg'); - } return @items; } } @@ -79,6 +72,13 @@ sub catalog_settable { if ($confhash->{'categorizecomm'} ne 'comm') { push(@settable,'categorize'); } + } elsif ($type eq 'Placement') { + if ($confhash->{'togglecatsplace'} ne 'place') { + push(@settable,'togglecats'); + } + if ($confhash->{'categorizeplace'} ne 'place') { + push(@settable,'categorize'); + } } else { if ($confhash->{'togglecats'} ne 'crs') { push(@settable,'togglecats'); @@ -101,7 +101,6 @@ sub get_enrollment_settings { @items = map { 'internal.'.$_; } (@{$internals}); push(@items,@{$accessdates}); } - push(@items,'internal.nopasswdchg'); my %settings = &Apache::lonnet::get('environment',\@items,$cdom,$cnum); my %enrollvar; $enrollvar{'autharg'} = ''; @@ -127,7 +126,7 @@ sub get_enrollment_settings { } elsif ($type eq "authtype" || $type eq "autharg" || $type eq "coursecode" || $type eq "crosslistings" || $type eq "selfenrollmgr" - || $type eq "autodropfailsafe" || $type eq 'nopasswdchg') { + || $type eq "autodropfailsafe") { $enrollvar{$type} = $settings{$item}; } elsif ($type eq 'defaultcredits') { if (&showcredits($cdom)) { @@ -175,16 +174,20 @@ sub print_course_search_page { $r->print(&Apache::loncommon::js_changer()); if ($type eq 'Community') { $r->print('

'.&mt('Search for a community in the [_1] domain',$domdesc).'

'); + } elsif ($type eq 'Placement') { + $r->print('

'.&mt('Search for a placement test in the [_1] domain',$domdesc).'

'); } else { $r->print('

'.&mt('Search for a course in the [_1] domain',$domdesc).'

'); } $r->print(&Apache::loncommon::build_filters($filterlist,$type,undef,undef,$filter,$action, \$numtitles,'modifycourse',undef,undef,undef, \@codetitles,$dom)); - + my ($actiontext,$roleoption,$settingsoption); if ($type eq 'Community') { $actiontext = &mt('Actions available after searching for a community:'); + } elsif ($type eq 'Placement') { + $actiontext = &mt('Actions available after searching for a placement test:') } else { $actiontext = &mt('Actions available after searching for a course:'); } @@ -192,30 +195,43 @@ sub print_course_search_page { if ($type eq 'Community') { $roleoption = &mt('Enter the community with the role of [_1]',$cctitle); $settingsoption = &mt('View or modify community settings which only a [_1] may modify.',$dctitle); + } elsif ($type eq 'Placement') { + $roleoption = &mt('Enter the placement test with the role of [_1]',$cctitle); + $settingsoption = &mt('View or modify placement test settings which only a [_1] may modify.',$dctitle); } else { $roleoption = &mt('Enter the course with the role of [_1]',$cctitle); $settingsoption = &mt('View or modify course settings which only a [_1] may modify.',$dctitle); } } elsif (&Apache::lonnet::allowed('rar',$dom)) { - my ($roles_by_num,$description,$accessref,$accessinfo) = &Apache::lonnet::get_all_adhocroles($dom); - if ((ref($roles_by_num) eq 'ARRAY') && (ref($description) eq 'HASH')) { - if (@{$roles_by_num} > 1) { + my %adhocroles = &Apache::lonnet::userenvironment($env{'user.domain'},$env{'user.name'}, + 'adhocroles.'.$dom); + if (keys(%adhocroles)) { + my @adhoc = split(',',$adhocroles{'adhocroles.'.$dom}); + if (@adhoc > 1) { if ($type eq 'Community') { - $roleoption = &mt('Enter the community with one of the available ad hoc roles'); + $roleoption = &mt('Enter the community with one of the available ad hoc roles: [_1].', + join(', ',@adhoc)); + } elsif ($type eq 'Placement') { + $roleoption = &mt('Enter the placement test with one of the available ad hoc roles: [_1].', + join(', ',@adhoc)); } else { - $roleoption = &mt('Enter the course with one of the available ad hoc roles.'); + $roleoption = &mt('Enter the course with one of the available ad hoc roles: [_1].', + join(', ',@adhoc)); } } else { - my $rolename = $description->{$roles_by_num->[0]}; if ($type eq 'Community') { - $roleoption = &mt('Enter the community with the ad hoc role of: [_1]',$rolename); + $roleoption = &mt('Enter the community with the ad hoc role of: [_1]',$adhoc[0]); + } elsif ($type eq 'Placement') { + $roleoption = &mt('Enter the placement test with the ad hoc role of: [_1]',$adhoc[0]); } else { - $roleoption = &mt('Enter the course with the ad hoc role of: [_1]',$rolename); + $roleoption = &mt('Enter the course with the ad hoc role of: [_1]',$adhoc[0]); } } } if ($type eq 'Community') { $settingsoption = &mt('View community settings which only a [_1] may modify.',$dctitle); + } elsif ($type eq 'Placement') { + $settingsoption = &mt('View placement test settings which only a [_1] may modify.',$dctitle); } else { $settingsoption = &mt('View course settings which only a [_1] may modify.',$dctitle); } @@ -229,133 +245,14 @@ sub print_course_search_page { } sub print_course_selection_page { - my ($r,$dom,$domdesc,$permission) = @_; + my ($r,$dom,$domdesc) = @_; my $type = $env{'form.type'}; if (!defined($type)) { $type = 'Course'; } &print_header($r,$type); - if ($permission->{'adhocrole'} eq 'custom') { - my %lt = &Apache::lonlocal::texthash( - title => 'Ad hoc role selection', - preamble => 'Please choose an ad hoc role in the course.', - cancel => 'Click "OK" to enter the course, or "Cancel" to choose a different course.', - ); - my %jslt = &Apache::lonlocal::texthash ( - none => 'You are not eligible to use an ad hoc role for the selected course', - ok => 'OK', - exit => 'Cancel', - ); - &js_escape(\%jslt); - $r->print(<<"END"); - - - -END - } elsif ($permission->{'adhocrole'} eq 'coord') { - $r->print(<<"END"); - -END - } - -# Criteria for course search +# Criteria for course search my ($filterlist,$filter) = &get_filters(); my $action = '/adm/modifycourse'; my $dctitle = &Apache::lonnet::plaintext('dc'); @@ -391,7 +288,8 @@ sub get_filters { sub print_modification_menu { my ($r,$cdesc,$domdesc,$dom,$type,$cid,$coursehash,$permission) = @_; &print_header($r,$type); - my ($ccrole,$categorytitle,$setquota_text,$setuploadquota_text,$cdom,$cnum); + my ($ccrole,$categorytitle,$setquota_text,$setuploadquota_text,$setparams_text,$cat_text, + $cdom,$cnum); if (ref($coursehash) eq 'HASH') { $cdom = $coursehash->{'domain'}; $cnum = $coursehash->{'num'}; @@ -403,59 +301,26 @@ sub print_modification_menu { } else { $ccrole = 'cc'; } - my %linktext; - if ($permission->{'setparms'} eq 'edit') { - %linktext = ( - 'setquota' => 'View/Modify quotas for group portfolio files, and for uploaded content', - 'setanon' => 'View/Modify responders threshold for anonymous survey submissions display', - 'selfenroll' => 'View/Modify Self-Enrollment configuration', - 'setpostsubmit' => 'View/Modify submit button behavior, post-submission', - ); - } else { - %linktext = ( - 'setquota' => 'View quotas for group portfolio files, and for uploaded content', - 'setanon' => 'View responders threshold for anonymous survey submissions display', - 'selfenroll' => 'View Self-Enrollment configuration', - 'setpostsubmit' => 'View submit button behavior, post-submission', - ); - } if ($type eq 'Community') { - if ($permission->{'setparms'} eq 'edit') { - $categorytitle = 'View/Modify Community Settings'; - $linktext{'setparms'} = 'View/Modify community owner'; - $linktext{'catsettings'} = 'View/Modify catalog settings for community'; - } else { - $categorytitle = 'View Community Settings'; - $linktext{'setparms'} = 'View community owner'; - $linktext{'catsettings'} = 'View catalog settings for community'; - } + $categorytitle = 'View/Modify Community Settings'; $setquota_text = &mt('Total disk space allocated for storage of portfolio files in all groups in a community.'); - $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a community via Content Editor.'); + $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a community via Content Editor.'); + $setparams_text = 'View/Modify community owner'; + $cat_text = 'View/Modify catalog settings for community'; } else { - if ($permission->{'setparms'} eq 'edit') { - $categorytitle = 'View/Modify Course Settings'; - $linktext{'catsettings'} = 'View/Modify catalog settings for course'; - if (($type ne 'Placement') && (&showcredits($dom))) { - $linktext{'setparms'} = 'View/Modify course owner, institutional code, default authentication, credits, self-enrollment and table lifetime'; - } else { - $linktext{'setparms'} = 'View/Modify course owner, institutional code, default authentication, self-enrollment and table lifetime'; - } - } else { - $categorytitle = 'View Course Settings'; - $linktext{'catsettings'} = 'View catalog settings for course'; - if (($type ne 'Placement') && (&showcredits($dom))) { - $linktext{'setparms'} = 'View course owner, institutional code, default authentication, credits, self-enrollment and table lifetime'; - } else { - $linktext{'setparms'} = 'View course owner, institutional code, default authentication, self-enrollment and table lifetime'; - } - } + $categorytitle = 'View/Modify Course Settings'; $setquota_text = &mt('Total disk space allocated for storage of portfolio files in all groups in a course.'); $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a course via Content Editor.'); + if (($type ne 'Placement') && (&showcredits($dom))) { + $setparams_text = 'View/Modify course owner, institutional code, default authentication, credits, self-enrollment and table lifetime'; + } else { + $setparams_text = 'View/Modify course owner, institutional code, default authentication, self-enrollment and table lifetime'; + } + $cat_text = 'View/Modify catalog settings for course'; } my $anon_text = &mt('Responder threshold required to display anonymous survey submissions.'); my $postsubmit_text = &mt('Override defaults for submit button behavior post-submission for this specific course.'); my $mysqltables_text = &mt('Override default for lifetime of "temporary" MySQL tables containing student performance data.'); - $linktext{'viewparms'} = 'Display current settings for automated enrollment'; my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$dom); my @additional_params = &catalog_settable($domconf{'coursecategories'},$type); @@ -467,7 +332,7 @@ sub print_modification_menu { if (ref($managed_by_dc) eq 'ARRAY') { if (@{$managed_by_dc}) { return 1; - } + } } } return 0; @@ -481,7 +346,7 @@ sub print_modification_menu { ({ categorytitle => $categorytitle, items => [ { - linktext => $linktext{'setparms'}, + linktext => $setparams_text, url => &phaseurl('setparms'), permission => $permission->{'setparms'}, #help => '', @@ -489,7 +354,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => $linktext{'setquota'}, + linktext => 'View/Modify quotas for group portfolio files, and for uploaded content.', url => &phaseurl('setquota'), permission => $permission->{'setquota'}, #help => '', @@ -497,7 +362,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => $linktext{'setanon'}, + linktext => 'View/Modify responders threshold for anonymous survey submissions display', url => &phaseurl('setanon'), permission => $permission->{'setanon'}, #help => '', @@ -505,7 +370,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => $linktext{'catsettings'}, + linktext => $cat_text, url => &phaseurl('catsettings'), permission => (($permission->{'catsettings'}) && (@additional_params > 0)), #help => '', @@ -513,15 +378,15 @@ sub print_modification_menu { linktitle => '' }, { - linktext => $linktext{'viewparms'}, + linktext => 'Display current settings for automated enrollment', url => &phaseurl('viewparms'), - permission => ($permission->{'viewparms'} && ($type ne 'Community')), + permission => ($permission->{'viewparms'} && ($type ne 'Community') && ($type ne 'Placement')), #help => '', icon => 'roles.png', linktitle => '' }, { - linktext => $linktext{'selfenroll'}, + linktext => 'View/Modify Self-Enrollment configuration', icon => 'self_enroll.png', #help => 'Course_Self_Enrollment', url => &phaseurl('selfenroll'), @@ -529,7 +394,7 @@ sub print_modification_menu { linktitle => 'Configure user self-enrollment.', }, { - linktext => $linktext{'setpostsubmit'}, + linktext => 'View/Modify submit button behavior, post-submission', icon => 'emblem-readonly.png', #help => '', url => &phaseurl('setpostsubmit'), @@ -557,7 +422,7 @@ sub print_modification_menu { } else { $menu_html .= '
  • '.&mt('Course owner (permitted to assign Course Coordinator roles in the course).').'
    • '."\n". '
  • '.&mt("Institutional code and default authentication (both required for auto-enrollment of students from institutional datafeeds).").'
    • '."\n"; - if (&showcredits($dom)) { + if (($type ne 'Placement') && &showcredits($dom)) { $menu_html .= '
  • '.&mt('Default credits earned by student on course completion.').'
    • '."\n"; } $menu_html .= '
  • '.&mt('Override defaults for who configures self-enrollment for this specific course.').'
    • '."\n"; @@ -568,7 +433,7 @@ sub print_modification_menu { '
  • '.$anon_text.'
    • '."\n". '
  • '.$postsubmit_text.'
    • '."\n"; my ($categories_link_start,$categories_link_end); - if ($permission->{'catsettings'} eq 'edit') { + if ($permission->{'catsettings'}) { $categories_link_start = ''; $categories_link_end = ''; } @@ -600,25 +465,29 @@ sub print_modification_menu { } sub print_adhocrole_selected { - my ($r,$type,$permission) = @_; + my ($r,$type) = @_; &print_header($r,$type); my ($cdom,$cnum) = split(/_/,$env{'form.pickedcourse'}); my ($newrole,$selectrole); - if ($permission->{'adhocrole'} eq 'coord') { + if (&Apache::lonnet::allowed('ccc',$cdom)) { if ($type eq 'Community') { $newrole = "co./$cdom/$cnum"; } else { $newrole = "cc./$cdom/$cnum"; } $selectrole = 1; - } elsif ($permission->{'adhocrole'} eq 'custom') { - my ($okroles,$description) = &Apache::lonnet::get_my_adhocroles($env{'form.pickedcourse'},1); - if (ref($okroles) eq 'ARRAY') { - my $possrole = $env{'form.adhocrole'}; - if (($possrole ne '') && (grep(/^\Q$possrole\E$/,@{$okroles}))) { - my $confname = &Apache::lonnet::get_domainconfiguser($cdom); - $newrole = "cr/$cdom/$confname/$possrole./$cdom/$cnum"; - $selectrole = 1; + } elsif (&Apache::lonnet::allowed('rar',$cdom)) { + my %adhocroles = &Apache::lonnet::userenvironment($env{'user.domain'},$env{'user.name'}, + 'adhocroles.'.$cdom); + if (keys(%adhocroles)) { + my $possrole = $env{'form.adhocrole'}; + if ($possrole ne '') { + my @adhoc = split(',',$adhocroles{'adhocroles.'.$cdom}); + if (grep(/^\Q$possrole\E$/,@adhoc)) { + my $confname = &Apache::lonnet::get_domainconfiguser($cdom); + $newrole = "cr/$cdom/$confname/$possrole./$cdom/$cnum"; + $selectrole = 1; + } } } } @@ -708,7 +577,7 @@ sub print_settings_display { } sub print_setquota { - my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; + my ($r,$cdom,$cnum,$cdesc,$type) = @_; my $lctype = lc($type); my $headline = &mt("Set disk space quotas for $lctype: [_1]", ''.$cdesc.''); @@ -741,25 +610,19 @@ sub print_setquota { my $hidden_elements = &hidden_form_elements(); my $porthelpitem = &Apache::loncommon::help_open_topic('Modify_Course_Quota'); my $uploadhelpitem = &Apache::loncommon::help_open_topic('Modify_Course_Upload_Quota'); - my ($disabled,$submit); - if ($readonly) { - $disabled = ' disabled="disabled"'; - } else { - $submit = ''; - } $r->print(<

    $headline

    -$porthelpitem $lt{'gpqu'}: MB +$porthelpitem $lt{'gpqu'}: MB
    -$uploadhelpitem $lt{'upqu'}: MB +$uploadhelpitem $lt{'upqu'}: MB

    -$submit +

    $hidden_elements $lt{'back'} @@ -769,7 +632,7 @@ ENDDOCUMENT } sub print_set_anonsurvey_threshold { - my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; + my ($r,$cdom,$cnum,$cdesc,$type) = @_; my %lt = &Apache::lonlocal::texthash( 'resp' => 'Responder threshold for anonymous survey submissions display:', 'sufa' => 'Anonymous survey submissions displayed when responders exceeds', @@ -792,19 +655,13 @@ sub print_set_anonsurvey_threshold { } &print_header($r,$type); my $hidden_elements = &hidden_form_elements(); - my ($disabled,$submit); - if ($readonly) { - $disabled = ' disabled="disabled"'; - } else { - $submit = ''; - } my $helpitem = &Apache::loncommon::help_open_topic('Modify_Anonsurvey_Threshold'); $r->print(<

    $lt{'resp'} $cdesc

    -$helpitem $lt{'sufa'}:      -$submit +$helpitem $lt{'sufa'}:      +

    $hidden_elements $lt{'back'} @@ -814,7 +671,7 @@ ENDDOCUMENT } sub print_postsubmit_config { - my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; + my ($r,$cdom,$cnum,$cdesc,$type) = @_; my %lt = &Apache::lonlocal::texthash ( 'conf' => 'Configure submit button behavior after student makes a submission', 'disa' => 'Disable submit button/keypress following student submission', @@ -855,27 +712,21 @@ sub print_postsubmit_config { } &print_header($r,$type); my $hidden_elements = &hidden_form_elements(); - my ($disabled,$submit); - if ($readonly) { - $disabled = ' disabled="disabled"'; - } else { - $submit = ''; - } my $helpitem = &Apache::loncommon::help_open_topic('Modify_Postsubmit_Config'); $r->print(<

    $lt{'conf'} ($cdesc)

    $helpitem $lt{'disa'}: -

    -$lt{'nums'}
    +$lt{'nums'}
    $zero

    -$submit +

    $hidden_elements $lt{'back'} @@ -888,7 +739,7 @@ sub domain_postsubtimeout { my ($cdom,$type,$settings) = @_; return unless (ref($settings) eq 'HASH'); my $lctype = lc($type); - unless ($type eq 'Community') { + unless (($type eq 'Community') || ($type eq 'Placement')) { $lctype = 'unofficial'; if ($settings->{'internal.coursecode'}) { $lctype = 'official'; @@ -912,7 +763,7 @@ sub domain_postsubtimeout { } sub print_catsettings { - my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; + my ($r,$cdom,$cnum,$cdesc,$type) = @_; &print_header($r,$type); my %lt = &Apache::lonlocal::texthash( 'back' => 'Pick another action', @@ -933,10 +784,6 @@ sub print_catsettings { my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$cdom); my @cat_params = &catalog_settable($domconf{'coursecategories'},$type); if (@cat_params > 0) { - my $disabled; - if ($readonly) { - $disabled = ' disabled="disabled"'; - } my %currsettings = &Apache::lonnet::get('environment',['hidefromcat','categories'],$cdom,$cnum); if (grep(/^togglecats$/,@cat_params)) { @@ -948,9 +795,11 @@ sub print_catsettings { } $r->print('

    '.$lt{'visi'}.'

    '. $lt{'exclude'}. - '    

    '); + '    

    '); if ($type eq 'Community') { $r->print(&mt("If a community has been categorized using at least one of the categories defined for communities in the domain, it will be listed in the domain's publicly accessible Course/Community Catalog, unless excluded.")); + } elsif ($type eq 'Placement') { + $r->print(&mt("If a placement test has been categorized using at least one of the categories defined for placement tests in the domain, it will be listed in the domain's publicly accessible Course/Community Catalog, unless excluded.")); } else { $r->print(&mt("Unless excluded, a course will be listed in the domain's publicly accessible Course/Community Catalog, if at least one of the following applies").':

      '. '
    • '.&mt('Auto-cataloging is enabled and the course is assigned an institutional code.').'
      • '. @@ -965,21 +814,19 @@ sub print_catsettings { if (ref($cathash) eq 'HASH') { $r->print($lt{'assi'}.'

      '. &Apache::loncommon::assign_categories_table($cathash, - $currsettings{'categories'},$type,$disabled)); + $currsettings{'categories'},$type)); } else { $r->print(&mt('No categories defined for this domain')); } } else { $r->print(&mt('No categories defined for this domain')); } - unless ($type eq 'Community') { + unless (($type eq 'Community') || ($type eq 'Placement')) { $r->print('

      '.&mt('If auto-cataloging based on institutional code is enabled in the domain, a course will continue to be listed in the catalog of official courses, in addition to receiving a listing under any manually assigned categor(ies).').'

      '); } } - unless ($readonly) { - $r->print('

      '); - } + $r->print('

      '); } else { $r->print(''); if ($type eq 'Community') { @@ -996,7 +843,7 @@ sub print_catsettings { } sub print_course_modification_page { - my ($r,$cdom,$cnum,$cdesc,$crstype,$readonly) = @_; + my ($r,$cdom,$cnum,$cdesc,$crstype) = @_; my %lt=&Apache::lonlocal::texthash( 'actv' => "Active", 'inac' => "Inactive", @@ -1010,28 +857,25 @@ sub print_course_modification_page { 'domd' => 'Domain default', 'whom' => 'Who configures', ); - my ($ownertable,$ccrole,$javascript_validations,$authenitems,$ccname,$disabled); + my ($ownertable,$ccrole,$javascript_validations,$authenitems,$ccname); my %enrollvar = &get_enrollment_settings($cdom,$cnum); my %settings = &Apache::lonnet::get('environment',['internal.coursecode','internal.textbook', 'internal.selfenrollmgrdc','internal.selfenrollmgrcc', - 'internal.mysqltables'],$cdom,$cnum); + 'internal.mysqltables'], + $cdom,$cnum); my $type = &Apache::lonuserutils::get_extended_type($cdom,$cnum,$crstype,\%settings); my @specific_managebydc = split(/,/,$settings{'internal.selfenrollmgrdc'}); my @specific_managebycc = split(/,/,$settings{'internal.selfenrollmgrcc'}); my %domdefaults = &Apache::lonnet::get_domain_defaults($cdom); - my %passwdconf = &Apache::lonnet::get_passwdconf($cdom); my @default_managebydc = split(/,/,$domdefaults{$type.'selfenrolladmdc'}); if ($crstype eq 'Community') { $ccrole = 'co'; $lt{'nocc'} = &mt('There is currently no owner set for this community.'); } else { $ccrole ='cc'; - ($javascript_validations,$authenitems) = &gather_authenitems($cdom,\%enrollvar,$readonly); + ($javascript_validations,$authenitems) = &gather_authenitems($cdom,\%enrollvar); } $ccname = &Apache::lonnet::plaintext($ccrole,$crstype); - if ($readonly) { - $disabled = ' disabled="disabled"'; - } my %roleshash = &Apache::lonnet::get_my_roles($cnum,$cdom,'','',[$ccrole]); my (@local_ccs,%cc_status,%pname); foreach my $item (keys(%roleshash)) { @@ -1072,9 +916,9 @@ sub print_course_modification_page { foreach my $cc (@local_ccs) { $ownertable .= &Apache::loncommon::start_data_table_row()."\n"; if ($cc eq $enrollvar{'courseowner'}) { - $ownertable .= ''."\n"; + $ownertable .= ''."\n"; } else { - $ownertable .= ''."\n"; + $ownertable .= ''."\n"; } $ownertable .= ''.$pname{$cc}.''."\n". @@ -1094,19 +938,18 @@ sub print_course_modification_page { if ($crstype eq 'Community') { $r->print(&Apache::lonhtmlcommon::row_title( &Apache::loncommon::help_open_topic('Modify_Community_Owner'). - ' '.&mt('Community Owner'))."\n". - $ownertable."\n".&Apache::lonhtmlcommon::row_closure()); + ' '.&mt('Community Owner'))."\n"); } else { $r->print(&Apache::lonhtmlcommon::row_title( &Apache::loncommon::help_open_topic('Modify_Course_Instcode'). ' '.&mt('Course Code'))."\n". - ''. + ''. &Apache::lonhtmlcommon::row_closure()); - if (&showcredits($cdom)) { + if (($crstype eq 'Course') && (&showcredits($cdom))) { $r->print(&Apache::lonhtmlcommon::row_title( &Apache::loncommon::help_open_topic('Modify_Course_Credithours'). - ' '.&mt('Credits (students)'))."\n". - ''. + ' '.&mt('Credits (students)'))."\n". + ''. &Apache::lonhtmlcommon::row_closure()); } $r->print(&Apache::lonhtmlcommon::row_title( @@ -1115,21 +958,8 @@ sub print_course_modification_page { $authenitems."\n". &Apache::lonhtmlcommon::row_closure(). &Apache::lonhtmlcommon::row_title( - &Apache::loncommon::help_open_topic('Modify_Course_Owner'). - ' '.&mt('Course Owner'))."\n". - $ownertable."\n".&Apache::lonhtmlcommon::row_closure()); - if (($passwdconf{'crsownerchg'}) && ($type ne 'Placement')) { - my $checked; - if ($enrollvar{'nopasswdchg'}) { - $checked = ' checked="checked"'; - } - $r->print(&Apache::lonhtmlcommon::row_title( - &Apache::loncommon::help_open_topic('Modify_Course_Chgpasswd'). - ' '.&mt('Changing passwords (internal)'))."\n". - '