--- loncom/interface/lonmodifycourse.pm 2016/10/23 02:24:51 1.79.2.3 +++ loncom/interface/lonmodifycourse.pm 2019/08/27 15:34:34 1.79.2.8 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # handler for DC-only modifiable course settings # -# $Id: lonmodifycourse.pm,v 1.79.2.3 2016/10/23 02:24:51 raeburn Exp $ +# $Id: lonmodifycourse.pm,v 1.79.2.8 2019/08/27 15:34:34 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -39,6 +39,9 @@ use Apache::lonpickcourse; use lib '/home/httpd/lib/perl'; use LONCAPA qw(:DEFAULT :match); +my $registered_cleanup; +my $modified_dom; + sub get_dc_settable { my ($type,$cdom) = @_; if ($type eq 'Community') { @@ -49,6 +52,10 @@ sub get_dc_settable { if (&showcredits($cdom)) { push(@items,'defaultcredits'); } + my %passwdconf = &Apache::lonnet::get_passwdconf($cdom); + if (($passwdconf{'crsownerchg'}) && ($type ne 'Placement')) { + push(@items,'nopasswdchg'); + } return @items; } } @@ -94,6 +101,7 @@ sub get_enrollment_settings { @items = map { 'internal.'.$_; } (@{$internals}); push(@items,@{$accessdates}); } + push(@items,'internal.nopasswdchg'); my %settings = &Apache::lonnet::get('environment',\@items,$cdom,$cnum); my %enrollvar; $enrollvar{'autharg'} = ''; @@ -119,7 +127,7 @@ sub get_enrollment_settings { } elsif ($type eq "authtype" || $type eq "autharg" || $type eq "coursecode" || $type eq "crosslistings" || $type eq "selfenrollmgr" - || $type eq "autodropfailsafe") { + || $type eq "autodropfailsafe" || $type eq 'nopasswdchg') { $enrollvar{$type} = $settings{$item}; } elsif ($type eq 'defaultcredits') { if (&showcredits($cdom)) { @@ -189,23 +197,20 @@ sub print_course_search_page { $settingsoption = &mt('View or modify course settings which only a [_1] may modify.',$dctitle); } } elsif (&Apache::lonnet::allowed('rar',$dom)) { - my %adhocroles = &Apache::lonnet::userenvironment($env{'user.domain'},$env{'user.name'}, - 'adhocroles.'.$dom); - if (keys(%adhocroles)) { - my @adhoc = split(',',$adhocroles{'adhocroles.'.$dom}); - if (@adhoc > 1) { + my ($roles_by_num,$description,$accessref,$accessinfo) = &Apache::lonnet::get_all_adhocroles($dom); + if ((ref($roles_by_num) eq 'ARRAY') && (ref($description) eq 'HASH')) { + if (@{$roles_by_num} > 1) { if ($type eq 'Community') { - $roleoption = &mt('Enter the community with one of the available ad hoc roles: [_1].', - join(', ',@adhoc)); + $roleoption = &mt('Enter the community with one of the available ad hoc roles'); } else { - $roleoption = &mt('Enter the course with one of the available ad hoc roles: [_1].', - join(', ',@adhoc)); + $roleoption = &mt('Enter the course with one of the available ad hoc roles.'); } } else { + my $rolename = $description->{$roles_by_num->[0]}; if ($type eq 'Community') { - $roleoption = &mt('Enter the community with the ad hoc role of: [_1]',$adhoc[0]); + $roleoption = &mt('Enter the community with the ad hoc role of: [_1]',$rolename); } else { - $roleoption = &mt('Enter the course with the ad hoc role of: [_1]',$adhoc[0]); + $roleoption = &mt('Enter the course with the ad hoc role of: [_1]',$rolename); } } } @@ -224,14 +229,133 @@ sub print_course_search_page { } sub print_course_selection_page { - my ($r,$dom,$domdesc) = @_; + my ($r,$dom,$domdesc,$permission) = @_; my $type = $env{'form.type'}; if (!defined($type)) { $type = 'Course'; } &print_header($r,$type); -# Criteria for course search + if ($permission->{'adhocrole'} eq 'custom') { + my %lt = &Apache::lonlocal::texthash( + title => 'Ad hoc role selection', + preamble => 'Please choose an ad hoc role in the course.', + cancel => 'Click "OK" to enter the course, or "Cancel" to choose a different course.', + ); + my %jslt = &Apache::lonlocal::texthash ( + none => 'You are not eligible to use an ad hoc role for the selected course', + ok => 'OK', + exit => 'Cancel', + ); + &js_escape(\%jslt); + $r->print(<<"END"); + + +
+END + } elsif ($permission->{'adhocrole'} eq 'coord') { + $r->print(<<"END"); + +END + } + +# Criteria for course search my ($filterlist,$filter) = &get_filters(); my $action = '/adm/modifycourse'; my $dctitle = &Apache::lonnet::plaintext('dc'); @@ -267,8 +391,7 @@ sub get_filters { sub print_modification_menu { my ($r,$cdesc,$domdesc,$dom,$type,$cid,$coursehash,$permission) = @_; &print_header($r,$type); - my ($ccrole,$categorytitle,$setquota_text,$setuploadquota_text,$setparams_text,$cat_text, - $cdom,$cnum); + my ($ccrole,$categorytitle,$setquota_text,$setuploadquota_text,$cdom,$cnum); if (ref($coursehash) eq 'HASH') { $cdom = $coursehash->{'domain'}; $cnum = $coursehash->{'num'}; @@ -280,26 +403,59 @@ sub print_modification_menu { } else { $ccrole = 'cc'; } + my %linktext; + if ($permission->{'setparms'} eq 'edit') { + %linktext = ( + 'setquota' => 'View/Modify quotas for group portfolio files, and for uploaded content', + 'setanon' => 'View/Modify responders threshold for anonymous survey submissions display', + 'selfenroll' => 'View/Modify Self-Enrollment configuration', + 'setpostsubmit' => 'View/Modify submit button behavior, post-submission', + ); + } else { + %linktext = ( + 'setquota' => 'View quotas for group portfolio files, and for uploaded content', + 'setanon' => 'View responders threshold for anonymous survey submissions display', + 'selfenroll' => 'View Self-Enrollment configuration', + 'setpostsubmit' => 'View submit button behavior, post-submission', + ); + } if ($type eq 'Community') { - $categorytitle = 'View/Modify Community Settings'; + if ($permission->{'setparms'} eq 'edit') { + $categorytitle = 'View/Modify Community Settings'; + $linktext{'setparms'} = 'View/Modify community owner'; + $linktext{'catsettings'} = 'View/Modify catalog settings for community'; + } else { + $categorytitle = 'View Community Settings'; + $linktext{'setparms'} = 'View community owner'; + $linktext{'catsettings'} = 'View catalog settings for community'; + } $setquota_text = &mt('Total disk space allocated for storage of portfolio files in all groups in a community.'); - $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a community via Content Editor.'); - $setparams_text = 'View/Modify community owner'; - $cat_text = 'View/Modify catalog settings for community'; + $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a community via Content Editor.'); } else { - $categorytitle = 'View/Modify Course Settings'; - $setquota_text = &mt('Total disk space allocated for storage of portfolio files in all groups in a course.'); - $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a course via Content Editor.'); - if (&showcredits($dom)) { - $setparams_text = 'View/Modify course owner, institutional code, default authentication, credits, self-enrollment and table lifetime'; + if ($permission->{'setparms'} eq 'edit') { + $categorytitle = 'View/Modify Course Settings'; + $linktext{'catsettings'} = 'View/Modify catalog settings for course'; + if (($type ne 'Placement') && (&showcredits($dom))) { + $linktext{'setparms'} = 'View/Modify course owner, institutional code, default authentication, credits, self-enrollment and table lifetime'; + } else { + $linktext{'setparms'} = 'View/Modify course owner, institutional code, default authentication, self-enrollment and table lifetime'; + } } else { - $setparams_text = 'View/Modify course owner, institutional code, default authentication, self-enrollment and table lifetime'; + $categorytitle = 'View Course Settings'; + $linktext{'catsettings'} = 'View catalog settings for course'; + if (($type ne 'Placement') && (&showcredits($dom))) { + $linktext{'setparms'} = 'View course owner, institutional code, default authentication, credits, self-enrollment and table lifetime'; + } else { + $linktext{'setparms'} = 'View course owner, institutional code, default authentication, self-enrollment and table lifetime'; + } } - $cat_text = 'View/Modify catalog settings for course'; + $setquota_text = &mt('Total disk space allocated for storage of portfolio files in all groups in a course.'); + $setuploadquota_text = &mt('Disk space allocated for storage of content uploaded directly to a course via Content Editor.'); } my $anon_text = &mt('Responder threshold required to display anonymous survey submissions.'); my $postsubmit_text = &mt('Override defaults for submit button behavior post-submission for this specific course.'); my $mysqltables_text = &mt('Override default for lifetime of "temporary" MySQL tables containing student performance data.'); + $linktext{'viewparms'} = 'Display current settings for automated enrollment'; my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$dom); my @additional_params = &catalog_settable($domconf{'coursecategories'},$type); @@ -325,7 +481,7 @@ sub print_modification_menu { ({ categorytitle => $categorytitle, items => [ { - linktext => $setparams_text, + linktext => $linktext{'setparms'}, url => &phaseurl('setparms'), permission => $permission->{'setparms'}, #help => '', @@ -333,7 +489,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => 'View/Modify quotas for group portfolio files, and for uploaded content.', + linktext => $linktext{'setquota'}, url => &phaseurl('setquota'), permission => $permission->{'setquota'}, #help => '', @@ -341,7 +497,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => 'View/Modify responders threshold for anonymous survey submissions display', + linktext => $linktext{'setanon'}, url => &phaseurl('setanon'), permission => $permission->{'setanon'}, #help => '', @@ -349,7 +505,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => $cat_text, + linktext => $linktext{'catsettings'}, url => &phaseurl('catsettings'), permission => (($permission->{'catsettings'}) && (@additional_params > 0)), #help => '', @@ -357,7 +513,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => 'Display current settings for automated enrollment', + linktext => $linktext{'viewparms'}, url => &phaseurl('viewparms'), permission => ($permission->{'viewparms'} && ($type ne 'Community')), #help => '', @@ -365,7 +521,7 @@ sub print_modification_menu { linktitle => '' }, { - linktext => 'View/Modify Self-Enrollment configuration', + linktext => $linktext{'selfenroll'}, icon => 'self_enroll.png', #help => 'Course_Self_Enrollment', url => &phaseurl('selfenroll'), @@ -373,7 +529,7 @@ sub print_modification_menu { linktitle => 'Configure user self-enrollment.', }, { - linktext => 'View/Modify submit button behavior, post-submission', + linktext => $linktext{'setpostsubmit'}, icon => 'emblem-readonly.png', #help => '', url => &phaseurl('setpostsubmit'), @@ -412,7 +568,7 @@ sub print_modification_menu { '
-$porthelpitem $lt{'gpqu'}: MB
+$porthelpitem $lt{'gpqu'}: MB
-$uploadhelpitem $lt{'upqu'}: MB
+$uploadhelpitem $lt{'upqu'}: MB
- +$submit
$hidden_elements $lt{'back'} @@ -611,7 +769,7 @@ ENDDOCUMENT } sub print_set_anonsurvey_threshold { - my ($r,$cdom,$cnum,$cdesc,$type) = @_; + my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; my %lt = &Apache::lonlocal::texthash( 'resp' => 'Responder threshold for anonymous survey submissions display:', 'sufa' => 'Anonymous survey submissions displayed when responders exceeds', @@ -634,13 +792,19 @@ sub print_set_anonsurvey_threshold { } &print_header($r,$type); my $hidden_elements = &hidden_form_elements(); + my ($disabled,$submit); + if ($readonly) { + $disabled = ' disabled="disabled"'; + } else { + $submit = ''; + } my $helpitem = &Apache::loncommon::help_open_topic('Modify_Anonsurvey_Threshold'); $r->print(<-$helpitem $lt{'sufa'}: - +$helpitem $lt{'sufa'}: +$submit
$hidden_elements $lt{'back'} @@ -650,7 +814,7 @@ ENDDOCUMENT } sub print_postsubmit_config { - my ($r,$cdom,$cnum,$cdesc,$type) = @_; + my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; my %lt = &Apache::lonlocal::texthash ( 'conf' => 'Configure submit button behavior after student makes a submission', 'disa' => 'Disable submit button/keypress following student submission', @@ -691,21 +855,27 @@ sub print_postsubmit_config { } &print_header($r,$type); my $hidden_elements = &hidden_form_elements(); + my ($disabled,$submit); + if ($readonly) { + $disabled = ' disabled="disabled"'; + } else { + $submit = ''; + } my $helpitem = &Apache::loncommon::help_open_topic('Modify_Postsubmit_Config'); $r->print(<$helpitem $lt{'disa'}: -
$hidden_elements $lt{'back'} @@ -742,7 +912,7 @@ sub domain_postsubtimeout { } sub print_catsettings { - my ($r,$cdom,$cnum,$cdesc,$type) = @_; + my ($r,$cdom,$cnum,$cdesc,$type,$readonly) = @_; &print_header($r,$type); my %lt = &Apache::lonlocal::texthash( 'back' => 'Pick another action', @@ -763,6 +933,10 @@ sub print_catsettings { my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$cdom); my @cat_params = &catalog_settable($domconf{'coursecategories'},$type); if (@cat_params > 0) { + my $disabled; + if ($readonly) { + $disabled = ' disabled="disabled"'; + } my %currsettings = &Apache::lonnet::get('environment',['hidefromcat','categories'],$cdom,$cnum); if (grep(/^togglecats$/,@cat_params)) { @@ -774,7 +948,7 @@ sub print_catsettings { } $r->print('');
+ '
');
if ($type eq 'Community') {
$r->print(&mt("If a community has been categorized using at least one of the categories defined for communities in the domain, it will be listed in the domain's publicly accessible Course/Community Catalog, unless excluded."));
} else {
@@ -791,7 +965,7 @@ sub print_catsettings {
if (ref($cathash) eq 'HASH') {
$r->print($lt{'assi'}.'
'.
&Apache::loncommon::assign_categories_table($cathash,
- $currsettings{'categories'},$type));
+ $currsettings{'categories'},$type,$disabled));
} else {
$r->print(&mt('No categories defined for this domain'));
}
@@ -802,8 +976,10 @@ sub print_catsettings {
$r->print('
'.&mt('If auto-cataloging based on institutional code is enabled in the domain, a course will continue to be listed in the catalog of official courses, in addition to receiving a listing under any manually assigned categor(ies).').'
'); } } - $r->print(''); + unless ($readonly) { + $r->print(''); + } } else { $r->print(''); if ($type eq 'Community') { @@ -820,7 +996,7 @@ sub print_catsettings { } sub print_course_modification_page { - my ($r,$cdom,$cnum,$cdesc,$crstype) = @_; + my ($r,$cdom,$cnum,$cdesc,$crstype,$readonly) = @_; my %lt=&Apache::lonlocal::texthash( 'actv' => "Active", 'inac' => "Inactive", @@ -834,7 +1010,7 @@ sub print_course_modification_page { 'domd' => 'Domain default', 'whom' => 'Who configures', ); - my ($ownertable,$ccrole,$javascript_validations,$authenitems,$ccname); + my ($ownertable,$ccrole,$javascript_validations,$authenitems,$ccname,$disabled); my %enrollvar = &get_enrollment_settings($cdom,$cnum); my %settings = &Apache::lonnet::get('environment',['internal.coursecode','internal.textbook', 'internal.selfenrollmgrdc','internal.selfenrollmgrcc', @@ -843,15 +1019,19 @@ sub print_course_modification_page { my @specific_managebydc = split(/,/,$settings{'internal.selfenrollmgrdc'}); my @specific_managebycc = split(/,/,$settings{'internal.selfenrollmgrcc'}); my %domdefaults = &Apache::lonnet::get_domain_defaults($cdom); + my %passwdconf = &Apache::lonnet::get_passwdconf($cdom); my @default_managebydc = split(/,/,$domdefaults{$type.'selfenrolladmdc'}); if ($crstype eq 'Community') { $ccrole = 'co'; $lt{'nocc'} = &mt('There is currently no owner set for this community.'); } else { $ccrole ='cc'; - ($javascript_validations,$authenitems) = &gather_authenitems($cdom,\%enrollvar); + ($javascript_validations,$authenitems) = &gather_authenitems($cdom,\%enrollvar,$readonly); } $ccname = &Apache::lonnet::plaintext($ccrole,$crstype); + if ($readonly) { + $disabled = ' disabled="disabled"'; + } my %roleshash = &Apache::lonnet::get_my_roles($cnum,$cdom,'','',[$ccrole]); my (@local_ccs,%cc_status,%pname); foreach my $item (keys(%roleshash)) { @@ -892,9 +1072,9 @@ sub print_course_modification_page { foreach my $cc (@local_ccs) { $ownertable .= &Apache::loncommon::start_data_table_row()."\n"; if ($cc eq $enrollvar{'courseowner'}) { - $ownertable .= ''.$hidden_elements. - 'print('this.form.submit();"'); - } else { - $r->print('javascript:verify_message(this.form);"'); + &Apache::lonhtmlcommon::end_pick_box().'
'.$hidden_elements); + unless ($readonly) { + $r->print('print('this.form.submit();"'); + } else { + $r->print('javascript:verify_message(this.form);"'); + } + $r->print(' value="'.$lt{'gobt'}.'" />'); } - $r->print(' value="'.$lt{'gobt'}.'" />
'); + $r->print(''); return; } sub print_selfenrollconfig { - my ($r,$type,$cdesc,$coursehash) = @_; + my ($r,$type,$cdesc,$coursehash,$readonly) = @_; return unless(ref($coursehash) eq 'HASH'); my $cnum = $coursehash->{'num'}; my $cdom = $coursehash->{'domain'}; @@ -1014,7 +1210,7 @@ sub print_selfenrollconfig { ''.$cdesc.'').''."\n"); &Apache::loncreateuser::print_selfenroll_menu($r,'domain',$env{'form.pickedcourse'}, $cdom,$cnum,\%currsettings, - &hidden_form_elements()); + &hidden_form_elements(),$readonly); return; } @@ -1070,7 +1266,7 @@ sub modifiable_only_title { } sub gather_authenitems { - my ($cdom,$enrollvar) = @_; + my ($cdom,$enrollvar,$readonly) = @_; my ($krbdef,$krbdefdom)=&Apache::loncommon::get_kerberos_defaults($cdom); my $curr_authtype = ''; my $curr_authfield = ''; @@ -1094,7 +1290,8 @@ sub gather_authenitems { kerb_def_auth => $krbdef, mode => 'modifycourse', curr_authtype => $curr_authtype, - curr_autharg => $enrollvar->{'autharg'} + curr_autharg => $enrollvar->{'autharg'}, + readonly => $readonly, ); my (%authform,$authenitems); $authform{'krb'} = &Apache::loncommon::authform_kerberos(%param); @@ -1121,6 +1318,10 @@ sub modify_course { if (&showcredits($cdom)) { push(@items,'internal.defaultcredits'); } + my %passwdconf = &Apache::lonnet::get_passwdconf($cdom); + if ($passwdconf{'crsownerchg'}) { + push(@items,'internal.nopasswdchg'); + } } my %settings = &Apache::lonnet::get('environment',\@items,$cdom,$cnum); my $description = $settings{'description'}; @@ -1136,6 +1337,7 @@ sub modify_course { } else { %changed = ( code => 0, owner => 0, + passwd => 0, ); $ccrole = 'cc'; unless ($settings{'internal.sectionnums'} eq '') { @@ -1188,9 +1390,21 @@ sub modify_course { $newattr{'mysqltables'} = $env{'form.mysqltables'}; $newattr{'mysqltables'} =~ s/\D+//g; } - if (&showcredits($cdom) && exists($env{'form.defaultcredits'})) { - $newattr{'defaultcredits'}=$env{'form.defaultcredits'}; - $newattr{'defaultcredits'} =~ s/[^\d\.]//g; + if ($type ne 'Placement') { + if (&showcredits($cdom) && exists($env{'form.defaultcredits'})) { + $newattr{'defaultcredits'}=$env{'form.defaultcredits'}; + $newattr{'defaultcredits'} =~ s/[^\d\.]//g; + } + if (grep(/^nopasswdchg$/,@modifiable_params)) { + if ($env{'form.nopasswdchg'}) { + $newattr{'nopasswdchg'} = 1; + unless ($currattr{'nopasswdchg'}) { + $changed{'passwd'} = 1; + } + } elsif ($currattr{'nopasswdchg'}) { + $changed{'passwd'} = 1; + } + } } } @@ -1225,7 +1439,7 @@ sub modify_course { } } - if ($changed{'owner'} || $changed{'code'}) { + if ($changed{'owner'} || $changed{'code'} || $changed{'passwd'}) { my %crsinfo = &Apache::lonnet::courseiddump($cdom,'.',1,'.','.',$cnum, undef,undef,'.'); if (ref($crsinfo{$env{'form.pickedcourse'}}) eq 'HASH') { @@ -1235,10 +1449,29 @@ sub modify_course { if ($changed{'owner'}) { $crsinfo{$env{'form.pickedcourse'}}{'owner'} = $env{'form.courseowner'}; } + if ($changed{'passwd'}) { + if ($env{'form.nopasswdchg'}) { + $crsinfo{$env{'form.pickedcourse'}}{'nopasswdchg'} = 1; + } else { + delete($crsinfo{'nopasswdchg'}); + } + } my $chome = &Apache::lonnet::homeserver($cnum,$cdom); my $putres = &Apache::lonnet::courseidput($cdom,\%crsinfo,$chome,'notime'); - if ($putres eq 'ok') { + if (($putres eq 'ok') && (($changed{'owner'} || $changed{'code'}))) { &update_coowners($cdom,$cnum,$chome,\%settings,\%newattr); + if ($changed{'code'}) { + &Apache::lonnet::devalidate_cache_new('instcats',$cdom); + # Update cache of self-cataloging courses on institution's server(s). + if (&Apache::lonnet::shared_institution($cdom)) { + unless ($registered_cleanup) { + my $handlers = $r->get_handlers('PerlCleanupHandler'); + $r->set_handlers('PerlCleanupHandler' => [\&devalidate_remote_instcats,@{$handlers}]); + $registered_cleanup=1; + $modified_dom = $cdom; + } + } + } } } } @@ -1284,6 +1517,12 @@ sub modify_course { $shown = &mt('None'); } elsif (($attr eq 'mysqltables') && ($shown eq '')) { $shown = &mt('domain default'); + } elsif ($attr eq 'nopasswdchg') { + if ($shown) { + $shown = &mt('Yes'); + } else { + $shown = &mt('No'); + } } $chgresponse .= '