--- loncom/interface/lonmsg.pm	2024/08/22 14:41:09	1.239.2.5.2.1
+++ loncom/interface/lonmsg.pm	2022/01/18 17:33:13	1.248
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Routines for messaging
 #
-# $Id: lonmsg.pm,v 1.239.2.5.2.1 2024/08/22 14:41:09 raeburn Exp $
+# $Id: lonmsg.pm,v 1.248 2022/01/18 17:33:13 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -200,9 +200,9 @@ Returns
 
 use strict;
 use Apache::lonnet;
+use Apache::loncommon;
 use HTML::TokeParser();
 use Apache::lonlocal;
-use Mail::Send;
 use HTML::Entities;
 use Encode;
 use LONCAPA qw(:DEFAULT :match);
@@ -428,7 +428,6 @@ sub unpackmsgid {
     $shortsubj = &unescape($shortsubj);
     $shortsubj = &HTML::Entities::decode($shortsubj);
     $symb = &unescape($symb);
-    if (!defined($processid)) { $fromcid = ''; }
     my %status=();
     unless ($skipstatus) {
 	if (ref($status_cache)) {
@@ -445,7 +444,7 @@ sub unpackmsgid {
 
 
 sub sendemail {
-    my ($to,$subject,$body,$to_uname,$to_udom,$user_lh)=@_;
+    my ($to,$subject,$body,$to_uname,$to_udom,$user_lh,$attachmenturl)=@_;
     my $senderaddress='';
     my $replytoaddress='';
     my $msgsent;
@@ -455,17 +454,14 @@ sub sendemail {
         $replytoaddress = 'do-not-reply@'.$hostname;
     } else {
         my %senderemails;
-        my ($have_sender,$setreplyto);
+        my $have_sender;
         if ($env{'form.reply_to_addr'}) {
             my ($replytoname,$replytodom) = split(/:/,$env{'form.reply_to_addr'});
-            if (($replytoname eq $env{'user.name'} && $replytodom eq $env{'user.domain'})) {
-                $setreplyto = 1;
-            } else {
+            if (!($replytoname eq $env{'user.name'} && $replytodom eq $env{'user.domain'})) {
                 if (&Apache::lonnet::homeserver($replytoname,$replytodom) ne 'no_host') {
                     %senderemails = 
                         &Apache::loncommon::getemails($replytoname,$replytodom);
                     $have_sender = 1;
-                    $setreplyto = 1;
                 }
             }
         }
@@ -475,12 +471,7 @@ sub sendemail {
         foreach my $type ('permanentemail','critnotification','notification') {
             if ($senderemails{$type}) {
                 ($senderaddress) = split(/,/,$senderemails{$type});
-                if ($senderaddress) {
-                    if ($setreplyto) {
-                        $replytoaddress = $senderaddress;
-                    }
-                    last;
-                }
+                last if ($senderaddress);
             }
         }
     }
@@ -489,19 +480,18 @@ sub sendemail {
     "*** ".($senderaddress?&mt_user($user_lh,'You can reply to this e-mail'):&mt_user($user_lh,'Please do not reply to this address.')."\n*** ".
     &mt_user($user_lh,'A reply will not be received by the recipient!'))."\n\n".$body;
     
-    my $msg = new Mail::Send;
-    $msg->to($to);
-    $msg->subject('[LON-CAPA] '.$subject);
-    if ($replytoaddress) {
-        $msg->add('Reply-to',$replytoaddress);
-    }
-    if ($senderaddress) {
-        $msg->add('From',$senderaddress);
-    }
-    $msg->add('Content-type','text/plain; charset=UTF-8');
-    if (my $fh = $msg->open()) {
-	print $fh $body;
-	$fh->close;
+    $attachmenturl = &Apache::lonnet::filelocation("",$attachmenturl);
+    my $filesize = (stat($attachmenturl))[7];
+    if ($filesize > 1048576) {
+        # Don't send if it exceeds 1 MB.
+        print '<p><span class="LC_error">' 
+            .&mt('Email not sent.  Attachment exceeds permitted length.')
+            .'</span><br /></p>';
+    } else {
+        # Otherwise build and send the email
+        $subject = '[LON-CAPA] '.$subject;
+        &Apache::loncommon::mime_email($senderaddress,$replytoaddress,$to,
+                                       $subject,$body,'','',$attachmenturl,'','');
         $msgsent = 1;
     }
     return $msgsent;
@@ -510,7 +500,7 @@ sub sendemail {
 # ==================================================== Send notification emails
 
 sub sendnotification {
-    my ($to,$touname,$toudom,$subj,$crit,$text,$msgid)=@_;
+    my ($to,$touname,$toudom,$subj,$crit,$text,$msgid,$attachmenturl)=@_;
     my $sender=$env{'environment.firstname'}.' '.$env{'environment.lastname'};
     unless ($sender=~/\w/) { 
 	$sender=$env{'user.name'}.':'.$env{'user.domain'};
@@ -520,8 +510,12 @@ sub sendnotification {
 
     $text=~s/\&lt\;/\</gs;
     $text=~s/\&gt\;/\>/gs;
-    my $touhome = &Apache::lonnet::homeserver($touname,$toudom);
-    my $url = &Apache::lonnet::url_prefix('',$toudom,$touhome,'email').
+    my $homeserver = &Apache::lonnet::homeserver($touname,$toudom);
+    my $hostname = &Apache::lonnet::hostname($homeserver);
+    my $protocol = $Apache::lonnet::protocol{$homeserver};
+    $protocol = 'http' if ($protocol ne 'https');
+#FIXME
+    my $url = $protocol.'://'.$hostname.
               '/adm/email?username='.$touname.'&domain='.$toudom.
               '&display='.&escape($msgid);
     my ($sendtime,$shortsubj,$fromname,$fromdomain,$status,$fromcid,
@@ -596,7 +590,7 @@ to access the full message.',$url);
                 }
                 $body = $bodybegin.$bodysubj.$sendtext.$bodyend;
             }
-            if (&sendemail($addr,$subject,$body,$touname,$toudom,$user_lh)) {
+            if (&sendemail($addr,$subject,$body,$touname,$toudom,$user_lh,$attachmenturl)) {
                 $numsent ++;
             }
         }
@@ -607,7 +601,7 @@ to access the full message.',$url);
             my $htmlfree = &make_htmlfree($text);
             $body = $bodybegin.$bodysubj.$htmlfree.$bodyend;
         }
-        if (&sendemail($to,$subject,$body,$touname,$toudom,$user_lh)) {
+        if (&sendemail($to,$subject,$body,$touname,$toudom,$user_lh,$attachmenturl)) {
             $numsent ++;
         }
     }
@@ -780,7 +774,7 @@ sub user_crit_msg_raw {
     my $numperm = 0;
     my $permlogmsgstatus;
     if ($critnotify) {
-        $numcrit = &sendnotification($critnotify,$user,$domain,$subject,1,$text,$msgid);
+        $numcrit = &sendnotification($critnotify,$user,$domain,$subject,1,$text,$msgid,$attachmenturl);
     }
     if ($toperm && $permemail) {
         if ($critnotify && $numcrit) {
@@ -789,7 +783,7 @@ sub user_crit_msg_raw {
             }
         }
         unless ($numperm) {
-            $numperm = &sendnotification($permemail,$user,$domain,$subject,1,$text,$msgid);
+            $numperm = &sendnotification($permemail,$user,$domain,$subject,1,$text,$msgid,$attachmenturl);
         }
     }
     if ($toperm) {
@@ -910,7 +904,7 @@ sub user_normal_msg_raw {
            if ($status eq 'ok' || $status eq 'con_delayed') {
                if ($senthide && $sentmsgid) {
                    &store_sent_mail($sentmsgid,$packed_message_no_citation);
-               } else { 
+               } else {
                    &store_sent_mail($msgid,$packed_message_no_citation);
                }
            }
@@ -929,7 +923,7 @@ sub user_normal_msg_raw {
        my $numperm = 0;
        my $permlogmsgstatus;
        if ($notify) {
-           $numnotify = &sendnotification($notify,$user,$domain,$subject,0,$text,$msgid);
+           $numnotify = &sendnotification($notify,$user,$domain,$subject,0,$text,$msgid,$attachmenturl);
        }
        if ($toperm && $permemail) {
            if ($notify && $numnotify) {
@@ -939,7 +933,7 @@ sub user_normal_msg_raw {
            }
            unless ($numperm) {
                $numperm = &sendnotification($permemail,$user,$domain,$subject,0,
-                                            $text,$msgid);
+                                            $text,$msgid,$attachmenturl);
            }
        }
        if ($toperm) {