--- loncom/interface/lonnavmaps.pm	2022/10/04 14:38:08	1.561
+++ loncom/interface/lonnavmaps.pm	2025/02/03 19:07:54	1.571
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Navigate Maps Handler
 #
-# $Id: lonnavmaps.pm,v 1.561 2022/10/04 14:38:08 raeburn Exp $
+# $Id: lonnavmaps.pm,v 1.571 2025/02/03 19:07:54 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -48,7 +48,8 @@ described at http://www.lon-capa.org.
 
 =head1 OVERVIEW
 
-X<lonnavmaps, overview> When a user enters a course, LON-CAPA examines the
+X<lonnavmaps, overview>
+When a user enters a course, LON-CAPA examines the
 course structure and caches it in what is often referred to as the
 "big hash" X<big hash>. You can see it if you are logged into
 LON-CAPA, in a course, by going to /adm/test. The content of 
@@ -549,6 +550,10 @@ my %colormap =
       $resObj->EXCUSED                => '#3333FF',
       $resObj->PAST_DUE_ANSWER_LATER  => '',
       $resObj->PAST_DUE_NO_ANSWER     => '',
+      $resObj->PAST_DUE_ATMPT_ANS     => '',
+      $resObj->PAST_DUE_ATMPT_NOANS   => '',
+      $resObj->PAST_DUE_NO_ATMT_ANS   => '',
+      $resObj->PAST_DUE_NO_ATMT_NOANS => '',
       $resObj->ANSWER_OPEN            => '#006600',
       $resObj->OPEN_LATER             => '',
       $resObj->TRIES_LEFT             => '',
@@ -694,10 +699,10 @@ sub getDescription {
             return &Apache::lonhtmlcommon::direct_parm_link(&mt("Open, no due date"),$res->symb(),'duedate',$part).$slotinfo;
         }
     }
-    if ($status == $res->PAST_DUE_ANSWER_LATER) {
+    if (($status == $res->PAST_DUE_ANSWER_LATER) || ($status == $res->PAST_DUE_ATMPT_ANS) || ($status == $res->PAST_DUE_NO_ATMT_ANS)) {
         return &mt("Answer open [_1]",&Apache::lonhtmlcommon::direct_parm_link(&timeToHumanString($answer,'start'),$res->symb(),'answerdate',$part));
     }
-    if ($status == $res->PAST_DUE_NO_ANSWER) {
+    if (($status == $res->PAST_DUE_NO_ANSWER) || ($status == $res->PAST_DUE_ATMPT_NOANS) || ($status == $res->PAST_DUE_NO_ATMT_NOANS)) {
 	if ($res->is_practice()) {
 	    return &mt("Closed [_1]",&Apache::lonhtmlcommon::direct_parm_link(&timeToHumanString($due,'start'),$res->symb(),'answerdate,duedate',$part));
 	} else {
@@ -1020,8 +1025,12 @@ sub render_resource {
         if ($it->{CONDITION}) {
             $nowOpen = !$nowOpen;
         }
-	
-	my $folderType = $resource->is_sequence() ? 'folder' : 'page';
+	my $folderType;
+	if (&advancedUser() && $resource->is_missing_map()) {
+	    $folderType = 'none';
+	} else {
+	    $folderType = $resource->is_sequence() ? 'folder' : 'page';
+	}
         my $title=$resource->title;
 		$title=~s/\"/\&qout;/g;
         if (!$params->{'resource_no_folder_link'}) {
@@ -1112,7 +1121,7 @@ sub render_resource {
     }
 
     # Decide what to display
-    $result .= "$newBranchText$linkopen$icon$linkclose";
+    $result .= "$newBranchText$linkopen$icon";
     
     my $curMarkerBegin = '';
     my $curMarkerEnd = '';
@@ -1152,7 +1161,7 @@ sub render_resource {
             $linkopen = "<a href=\"$link\">";
         }
     }
-    $result .= "$curMarkerBegin$linkopen$title$partLabel$linkclose$curMarkerEnd$editmapLink$nonLinkedText</td>";
+    $result .= "$curMarkerBegin$title$partLabel$curMarkerEnd$linkclose$editmapLink$nonLinkedText</td>";
 
     return $result;
 }
@@ -1564,10 +1573,15 @@ sub render {
     my $curRes;
     my $foundJump = 0;
     my $counter = 0;
-    
+
     while (($curRes = $mapIterator->next()) && !$foundJump) {
         if (ref($curRes)) { $counter++; }
-        
+        # Speed up display after course initialization
+        # when $jump is empty. Note: we still need
+        # $counter to be 1 in that case if there is at
+        # least one resource.
+        last if (($jump eq '') && ($counter));
+
         if (ref($curRes) && $jump eq $curRes->symb()) {
             
             # This is why we have to use the main iterator instead of the
@@ -1586,27 +1600,19 @@ sub render {
     my $printKey = $args->{'printKey'};
     my $printCloseAll = $args->{'printCloseAll'};
     if (!defined($printCloseAll)) { $printCloseAll = 1; }
-   
+
     # Print key?
     if ($printKey) {
-        $result .= '<table border="0" cellpadding="2" cellspacing="0">';
-        $result.='<tr><td align="right" valign="bottom">Key:&nbsp;&nbsp;</td>';
-	my $location=&Apache::loncommon::lonhttpdurl("/adm/lonMisc");
-        if ($navmap->{LAST_CHECK}) {
-            $result .= 
-                '<img src="'.$location.'/chat.gif" alt="" /> '.&mt('New discussion since').' '.
-                strftime("%A, %b %e at %I:%M %P", localtime($navmap->{LAST_CHECK})).
-                '</td><td align="center" valign="bottom">&nbsp;&nbsp;'.
-                '<img src="'.$location.'/feedback.gif" alt="" /> '.&mt('New message (click to open)').'<p>'.
-                '</td>'; 
-        } else {
-            $result .= '<td align="center" valign="bottom">&nbsp;&nbsp;'.
-                '<img src="'.$location.'/chat.gif" alt="" /> '.&mt('Discussions').'</td><td align="center" valign="bottom">'.
-                '&nbsp;&nbsp;<img src="'.$location.'/feedback.gif" alt="" /> '.&mt('New message (click to open)').
-                '</td>'; 
-        }
-
-        $result .= '</tr></table>';
+        my $location = &Apache::loncommon::lonhttpdurl("/adm/lonMisc");
+        $result .= '<div class="LC_navtools">'."\n".
+                   '<span class="LC_middle LC_right">'.&mt('Key').':</span>'.
+                   '<span class="LC_middle LC_center">&nbsp;&nbsp;'.
+                   '<img src="'.$location.'/chat.gif" alt="" /> '.&mt('Unread Discussion').
+                   '&nbsp;&nbsp;'.
+                   '<img src="'.$location.'/feedback.gif" alt="" /> '.
+                   &mt('New message (click to open)').
+                   '</span></div>'.
+                   '<div style="padding:0;clear:both;margin:0;border:0"></div>'."\n";
     }
 
     if ($printCloseAll && !$args->{'resource_no_folder_link'}) {
@@ -1633,17 +1639,19 @@ sub render {
 
     # Check for any unread discussions in all resources.
     if (($args->{'caller'} eq 'navmapsdisplay') && (!$args->{'notools'})) {
+        my $markread = 'Mark all posts read';
 	&add_linkitem($args->{'linkitems'},'clearbubbles',
 		      'document.clearbubbles.submit()',
-		      'Mark all posts read');
+		      $markread);
 	my $time=time;
+        my $submit = &mt($markread);
         my $querystr = &HTML::Entities::encode($ENV{'QUERY_STRING'},'<>&"');
 	$result .= (<<END);
-    <form name="clearbubbles" method="post" action="/adm/feedback">
+    <form name="clearbubbles" method="post" action="/adm/feedback" aria-hidden="true">
 	<input type="hidden" name="navurl" value="$querystr" />
 	<input type="hidden" name="navtime" value="$time" />
 END
-        if ($args->{'sort'} eq 'discussion') { 
+        if ($args->{'sort'} eq 'discussion') {
 	    my $totdisc = 0;
 	    my $haveDisc = '';
 	    my @allres=$navmap->retrieveResources();
@@ -1657,11 +1665,13 @@ END
 		$haveDisc =~ s/:$//;
 		$result .= (<<END);
 	<input type="hidden" name="navmaps" value="$haveDisc" />
-    </form>
 END
             }
 	}
-	$result.='</form>';
+	$result .= <<END;
+        <input type="submit" value="$submit" class="LC_visually_hidden" tabindex="-1" disabled="disabled" />
+    </form>
+END
     }
     if (($args->{'caller'} eq 'navmapsdisplay') && ($env{'request.course.id'})) {
         my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
@@ -1699,7 +1709,9 @@ END
     $result .= "<br />\n";
 
     # Data
-    $result.=&Apache::loncommon::start_data_table("LC_tableOfContent");    
+    if ($counter) {
+        $result.=&Apache::loncommon::start_data_table("LC_tableOfContent");
+    }
 
     my $res = "Apache::lonnavmaps::resource";
     my %condenseStatuses =
@@ -2097,7 +2109,9 @@ END
 	}
     }
 
-    $result.=&Apache::loncommon::end_data_table();
+    if ($counter) {
+        $result.=&Apache::loncommon::end_data_table();
+    }
     
     # Print out the part that jumps to #curloc if it exists
     # delay needed because the browser is processing the jump before
@@ -2136,14 +2150,12 @@ sub show_linkitems_toolbar {
         if (ref($args->{'linkitems'}) eq 'HASH') {
             my $numlinks = scalar(keys(%{$args->{'linkitems'}}));
             if ($numlinks > 1) {
-                $result = '<td>'.
+                $result = '<div class="LC_navtools">'.
                           &Apache::loncommon::help_open_menu('Navigation Screen','Navigation_Screen',
                                                              undef,'RAT').
-                          '</td>'.
-                          '<td>&nbsp;</td>'.
-                          '<td class="LC_middle">'.&mt('Tools:').'</td>';
+                          '</div><div class="LC_navtools">&nbsp;'.&mt('Tools:').'</div>';
             }
-            $result .= '<td align="left">'."\n".
+            $result .= '<div class="LC_navtools">'."\n".
                        '<ul id="LC_toolbar">';
             my @linkorder = ('firsthomework','everything','uncompleted',
                              'changefolder','clearbubbles','printout','edittoplevel');
@@ -2171,19 +2183,21 @@ sub show_linkitems_toolbar {
                 }
             }
             $result .= '</ul>'.
-                       '</td>';
+                       '</div>';
             if (($numlinks==1) && (exists($args->{'linkitems'}{'edittoplevel'}))) {
-                $result .= '<td><a href="'.$args->{'linkitems'}{'edittoplevel'}{'cmd'}.'">'.
-                           &mt('Content Editor').'</a></td>';
+                $result .= '<div class="LC_navtools">'.
+                           '&nbsp;<a href="'.$args->{'linkitems'}{'edittoplevel'}{'cmd'}.'">'.
+                           &mt('Content Editor').'</a></div>';
             }
         }
         if ($args->{'sort_html'}) {
-            $result .= '<td>&nbsp;</td><td>&nbsp;</td><td>&nbsp;</td>'.
-                       '<td align="right">'.$args->{'sort_html'}.'</td>';
+            $result .= '<div class="LC_navtools">&nbsp;&nbsp;&nbsp;'.
+                       $args->{'sort_html'}.'</div>';
         }
     }
     if ($result) {
-        $result = "<table><tr>$result</tr></table>";
+        $result = '<div class="LC_navtools">'.$result.'</div>'."\n".
+                  '<div style="padding:0;clear:both;margin:0;border:0"></div>'."\n";
     }
     return $result;
 }
@@ -2278,10 +2292,17 @@ sub new {
 
     $self->{USERNAME} = shift || $env{'user.name'};
     $self->{DOMAIN}   = shift || $env{'user.domain'};
+    $self->{SECTION}  = shift;
     $self->{CODE}     = shift;
-    $self->{NOHIDE} = shift;
+    $self->{NOHIDE}   = shift;
 
 
+    if (($self->{SECTION} eq '') && ($env{'request.course.sec'} ne '')) {
+        if (($self->{USERNAME} eq $env{'user.name'}) &&
+            ($self->{USERNAME} eq $env{'user.domain'})) {
+            $self->{SECTION} = $env{'request.course.sec'};
+        }
+    }
 
     # Resource cache stores navmap resources as we reference them. We generate
     # them on-demand so we don't pay for creating resources unless we use them.
@@ -2323,7 +2344,7 @@ sub new {
 	$self->{PARM_HASH} = \%parmhash;
 	$self->{PARM_CACHE} = {};
     } else {
-	$self->change_user($self->{USERNAME}, $self->{DOMAIN},  $self->{CODE}, $self->{NOHIDE});
+	$self->change_user($self->{USERNAME}, $self->{DOMAIN}, $self->{SECTION}, $self->{CODE}, $self->{NOHIDE});
     }
 
     return $self;
@@ -2334,15 +2355,17 @@ sub new {
 # username/domain associated with a navmap (e.g. to navigate for someone
 # else besides the current user...if sufficiently privileged.
 # Parameters:
-#    user  - New user.
-#    domain- Domain the user belongs to.
-#    code  - Anonymous CODE in use.
+#    user    - New user.
+#    domain  - Domain to which the user belongs.
+#    section - Section to which the user belongs.
+#    code    - Anonymous CODE in use.
 # Implicit inputs:
 #   
 sub change_user {
     my $self = shift;
     $self->{USERNAME} = shift;
     $self->{DOMAIN}   = shift;
+    $self->{SECTION}  = shift;
     $self->{CODE}     = shift;
     $self->{NOHIDE}   = shift;
 
@@ -2849,7 +2872,7 @@ sub parmval_real {
     $self->generate_course_user_opt();
 
     my $cid=$env{'request.course.id'};
-    my $csec=$env{'request.course.sec'};
+    my $csec=$self->{SECTION};
     my $cgroup='';
     my @cgrps=split(/:/,$env{'request.course.groups'});
     if (@cgrps > 0) {
@@ -3038,7 +3061,7 @@ sub parmval_real {
 }
 
 sub recurseup_maps {
-    my ($self,$mapname) = @_;
+    my ($self,$mapname,$getsymb) = @_;
     my @recurseup;
     if ($mapname) {
         my $res = $self->getResourceByUrl($mapname);
@@ -3046,7 +3069,11 @@ sub recurseup_maps {
             my @pcs = split(/,/,$res->map_hierarchy());
             shift(@pcs);
             if (@pcs) {
-                @recurseup = map { &Apache::lonnet::declutter($self->getByMapPc($_)->src()); } reverse(@pcs);
+                if ($getsymb) {
+                    @recurseup = map { &Apache::lonnet::declutter($self->getByMapPc($_)->symb()); } reverse(@pcs);
+                } else {
+                    @recurseup = map { &Apache::lonnet::declutter($self->getByMapPc($_)->src()); } reverse(@pcs);
+                }
             }
         }
     }
@@ -3174,7 +3201,7 @@ sub get_mapparam {
     # Get the course id and section if there is one.
 
     my $cid=$env{'request.course.id'};
-    my $csec=$env{'request.course.sec'};
+    my $csec=$self->{SECTION};
     my $cgroup='';
     my @cgrps=split(/:/,$env{'request.course.groups'});
     if (@cgrps > 0) {
@@ -3375,11 +3402,11 @@ sub getcourseparam {
 
     my $uname = $self->{USERNAME};
     my $udom  = $self->{DOMAIN};
+    my $csec  = $self->{SECTION};
     
-    # Course, section, group ids come from the env:
+    # Course and group ids come from the env:
 
     my $cid   = $env{'request.course.id'};
-    my $csec  = $env{'request.course.sec'};
     my $cgroup = '';		# Assume no group
 
     my @cgroups = split(/:/, $env{'request.course.groups'});
@@ -4805,6 +4832,11 @@ sub is_sequence {
     return $self->navHash("is_map_", 1) && 
     $self->navHash("map_type_" . $self->map_pc()) eq 'sequence';
 }
+sub is_missing_map {
+    my $self=shift;
+    return $self->navHash("is_map_", 1) &&
+    $self->navHash("map_type_" . $self->map_pc()) eq 'none';
+}
 sub is_survey {
     my $self = shift();
     my $part = shift();
@@ -5232,7 +5264,7 @@ sub weight {
     my $weight = &Apache::lonnet::EXT('resource.'.$part.'.weight',
                                 $self->{SYMB}, $self->{DOMAIN},
                                 $self->{USERNAME},
-                                $env{'request.course.sec'});
+                                $self->{SECTION});  
     return $weight;
 }
 sub part_display {
@@ -5706,7 +5738,6 @@ The problem will be opened later.
 
 Open and not yet due.
 
-
 =item * B<PAST_DUE_ANSWER_LATER>:
 
 The due date has passed, but the answer date has not yet arrived.
@@ -5719,6 +5750,26 @@ The due date has passed and there is no
 
 The answer date is here.
 
+=item * B<NOTHING_SET>:
+
+No dates have been set for this problem at all.
+
+=item * B<PAST_DUE_ATMPT_ANS>:
+
+The due date has passed, feedback is suppressed, the problem was attempted, and the answer date has not yet arrived.
+
+=item * B<PAST_DUE_ATMPT_NOANS>:
+
+The due date has passed, feedback is suppressed, the problem was attempted, and there is no answer opening date set.
+
+=item * B<PAST_DUE_NO_ATMT_ANS>:
+
+The due date has passed, feedback is suppressed, the problem was not attempted, and the answer date has not yet arrived.
+
+=item * B<PAST_DUE_NO_ATMT_NOANS>:
+
+The due date has passed, feedback is suppressed, the problem was not attempted, and there is no answer opening date set.
+
 =item * B<NETWORK_FAILURE>:
 
 The information is unknown due to network failure.
@@ -5734,6 +5785,10 @@ sub PAST_DUE_NO_ANSWER     { return 2; }
 sub PAST_DUE_ANSWER_LATER  { return 3; }
 sub ANSWER_OPEN            { return 4; }
 sub NOTHING_SET            { return 5; }
+sub PAST_DUE_ATMPT_ANS     { return 6; }
+sub PAST_DUE_ATMPT_NOANS   { return 7; }
+sub PAST_DUE_NO_ATMT_ANS   { return 8; }
+sub PAST_DUE_NO_ATMT_NOANS { return 9; }
 sub NETWORK_FAILURE        { return 100; }
 
 # getDateStatus gets the date status for a given problem part. 
@@ -5937,6 +5992,26 @@ set.
 The problem is past due, not considered correct, and an answer date in
 the future is set.
 
+=item * B<PAST_DUE_ATMPT_ANS>:
+
+The problem is past due, feedback is suppressed, the problem was
+attempted and an answer date in the future is set.
+
+=item * B<PAST_DUE_ATMPT_NOANS>:
+
+The problem is past due, feedback is suppressed, the problem was
+attempted and no answer date is set.
+
+=item * B<PAST_DUE_NO_ATMT_ANS>:
+
+The problem is past due, feedback is suppressed, the problem was
+not attempted and an answer date in the future is set.
+
+=item * B<PAST_DUE_NO_ATMT_NOANS>:
+
+The problem is past due, feedback is suppressed, the problem was
+not attempted and no answer date is set.
+
 =item * B<ANSWER_OPEN>:
 
 The problem is past due, not correct, and the answer is now available.
@@ -6020,7 +6095,18 @@ sub status {
     if ($completionStatus == CORRECT ||
         $completionStatus == CORRECT_BY_OVERRIDE ||
         $completionStatus == CORRECT_BY_PASSBACK ) {
-	if ( $suppressFeedback ) { return ANSWER_SUBMITTED }
+	if ( $suppressFeedback ) {
+            if ($dateStatus == PAST_DUE_ANSWER_LATER ||
+                $dateStatus == PAST_DUE_NO_ANSWER ) {
+                if ($dateStatus == PAST_DUE_ANSWER_LATER) {
+                    return PAST_DUE_ATMPT_ANS;
+                } else {
+                    return PAST_DUE_ATMPT_NOANS;
+                }
+            } else {
+                return ANSWER_SUBMITTED;
+            }
+        }
 	my $awarded=$self->awarded($part);
 	if ($awarded < 1 && $awarded > 0) {
             return PARTIALLY_CORRECT;
@@ -6060,7 +6146,23 @@ sub status {
 
     if ($dateStatus == PAST_DUE_ANSWER_LATER ||
         $dateStatus == PAST_DUE_NO_ANSWER ) {
-        return $suppressFeedback ? ANSWER_SUBMITTED : $dateStatus; 
+        if ($suppressFeedback) {
+            if ($completionStatus == NOT_ATTEMPTED) {
+                if ($dateStatus == PAST_DUE_ANSWER_LATER) {
+                    return PAST_DUE_NO_ATMT_ANS;
+                } else {
+                    return PAST_DUE_NO_ATMT_NOANS;
+                }
+            } else {
+                if ($dateStatus == PAST_DUE_ANSWER_LATER) {
+                    return PAST_DUE_ATMPT_ANS;
+                } else {
+                    return PAST_DUE_ATMPT_NOANS;
+                }
+            }
+        } else {
+            return $dateStatus;
+        }
     }
 
     if ($dateStatus == ANSWER_OPEN) {
@@ -6306,6 +6408,10 @@ my %compositeToSimple =
       EXCUSED()               => CORRECT,
       PAST_DUE_NO_ANSWER()    => INCORRECT,
       PAST_DUE_ANSWER_LATER() => INCORRECT,
+      PAST_DUE_ATMPT_ANS()    => ATTEMPTED,
+      PAST_DUE_ATMPT_NOANS()  => ATTEMPTED,
+      PAST_DUE_NO_ATMT_ANS()  => CLOSED,
+      PAST_DUE_NO_ATMT_NOANS() => CLOSED,
       ANSWER_OPEN()           => INCORRECT,
       OPEN_LATER()            => CLOSED,
       TRIES_LEFT()            => OPEN,