--- loncom/interface/lonparmset.pm	2022/01/03 20:09:40	1.522.2.28.4.1
+++ loncom/interface/lonparmset.pm	2022/03/24 16:18:42	1.522.2.28.4.4
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.522.2.28.4.1 2022/01/03 20:09:40 raeburn Exp $
+# $Id: lonparmset.pm,v 1.522.2.28.4.4 2022/03/24 16:18:42 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1313,13 +1313,11 @@ sub print_row {
         my ($domltistr,$crsltistr);
         my %lti =
             &Apache::lonnet::get_domain_lti($env{'course.'.$env{'request.course.id'}.'.domain'},
-                                            'provider');
+                                            'linkprot');
         if (keys(%lti)) {
             foreach my $item (sort { $a <=> $b }  (keys(%lti))) {
-                if (ref($lti{$item}) eq 'HASH') {
-                    unless ($lti{$item}{'requser'}) {
-                        $domltistr .= $item.':'.&escape(&escape($lti{$item}{'consumer'})).',';
-                    }
+                if (($item =~ /^\d+$/) && (ref($lti{$item}) eq 'HASH')) {
+                    $domltistr .= $item.':'.&escape(&escape($lti{$item}{'name'})).',';
                 }
             }
             $domltistr =~ s/,$//;
@@ -2675,6 +2673,7 @@ sub assessparms {
         my $chome = $env{'course.'.$env{'request.course.id'}.'.home'};
         my ($got_chostname,$chostname,$cmajor,$cminor);
         my $totalstored = 0;
+        my $totalskippeduser = 0;
         my $now = time;
         for (my $i=0;$i<=$#markers;$i++) {
             my ($needsrelease,$needsnewer,$name);
@@ -2683,6 +2682,11 @@ sub assessparms {
             }
             if ($markers[$i] =~ /\&(6|5|4)$/) {
                 next if ($noeditgrp);
+            } elsif ($markers[$i] =~ /\&(3|2|1)$/) {
+                if ($uname eq '') {
+                    $totalskippeduser ++;
+                    next;
+                }
             }
             if ($markers[$i] =~ /^[\d.]+\&0_availablestudent\&(1|2|3)$/) {
                 my (@ok_slots,@fail_slots,@del_slots);
@@ -2760,9 +2764,27 @@ sub assessparms {
 # ---------------------------------------------------------------- Done storing
         if ($totalstored) {
             $message.='<p class="LC_warning">'
+                     .&mt('Changes for [quant,_1,parameter] saved.',$totalstored)
+                     .'<br />'
                      .&mt('Changes can take up to 10 minutes before being active for all students.')
                      .&Apache::loncommon::help_open_topic('Caching')
                      .'</p>';
+        } else {
+            $message.='<p class="LC_info">'.&mt('No parameter changes saved.').'</p>';
+        }
+        if ($totalskippeduser) {
+            $message .= '<p class="LC_warning">';
+            if ($uhome eq 'no_host') {
+                $message .= &mt('Changes for [quant,_1,user-specific parameter] not saved because the username or ID was invalid.',
+                                $totalskippeduser);
+            } elsif ($env{'form.userroles'} eq 'any') {
+                $message .= &mt('Changes for [quant,_1,user-specific parameter] not saved because the user does not have a course role.',
+                                $totalskippeduser);
+            } else {
+                $message .= &mt('Changes for [quant,_1,user-specific parameter] not saved because the user is not a student.',
+                                $totalskippeduser);
+            }
+            $message .= '</p>';
         }
     }
 #----------------------------------------------- if all selected, fill in array
@@ -2785,13 +2807,20 @@ sub assessparms {
 
     # ----- Start Parameter Selection
 
-    # Hide parm selection?
+    # Hide parm selection and possibly table?
+    my ($tablejs,$tabledivsty);
+    if (((($env{'form.uname'} ne '') || ($env{'form.id'} ne '')) && ($uname eq '')) &&
+        ($env{'form.dis'}) && ($pssymb eq '')) {
+        $tablejs = 'document.getElementById('."'parmtable'".').style.display = "";';
+        $tabledivsty = ' style="display:none"';
+    }
     $r->print(<<ENDPARMSELSCRIPT);
 <script type="text/javascript">
 // <![CDATA[
 function parmsel_show() {
   document.getElementById('parmsel').style.display = "";
   document.getElementById('parmsellink').style.display = "none";
+  $tablejs
 }
 // ]]>
 </script>
@@ -2903,6 +2932,7 @@ ENDPARMSELSCRIPT
         if ($parm_permission->{'edit'}) {
             undef($readonly);
         }
+        $r->print('<div id="parmtable"'.$tabledivsty.'>');
 
         if ($parmlev eq 'full') {
 #
@@ -3311,6 +3341,7 @@ ENDMAPONE
                      .'</center>'
             );
         } # end of $parmlev eq general
+        $r->print('</div>');
     }
     $r->print('</form>');
     $r->print(&Apache::loncommon::end_page());
@@ -4005,12 +4036,10 @@ sub string_deeplink_selector {
     }
     my %lti =
         &Apache::lonnet::get_domain_lti($env{'course.'.$env{'request.course.id'}.'.domain'},
-                                        'provider');
+                                        'linkprot');
     foreach my $item (keys(%lti)) {
-        if (ref($lti{$item}) eq 'HASH') {
-            unless ($lti{$item}{'requser'}) {
-                $domlti{$item} = $lti{$item}{'consumer'};
-            }
+        if (($item =~ /^\d+$/) && (ref($lti{$item}) eq 'HASH')) {
+            $domlti{$item} = $lti{$item}{'name'};
         }
     }
     if ($env{'course.'.$env{'request.course.id'}.'.menucollections'}) {