CVS log for loncom/interface/lonpickcourse.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Hide role selection text used in modal window until needed.

- Domain Helpdesk Assistant role for use by domain helpdesk student employees
  - browse access to shared repository (including own domain) is excluded.

Ad hoc roles for helpdesk personnel.
  - Entering a course with one of the available ad hoc roles via
    Main Menu > View a course or community (Domain helpdesk role)
    uses modal pop-up to select role, after choosing course, if more
    than one ad hoc role is available to current user.

- Remove early version of &get_my_adhocroles() subroutine within this module;
  (the one in lonnet.pm is used instead).

- Ad hoc roles for helpdesk personnel.
  - Domain configuration for:
    - which user(s) with dh role in domain may use each ad hoc role.
      - set by institutional status, or by include specific people, or by
        exclude specific people.
    - assign role description (displayed on Roles page, and at top left of
      page, when role active).
    - assign role order (numerical).
  - Course configuration (available for editing by course owner, and viewing
    by co-owner(s).
    - can override domain defaults for which dh role users can use ad hoc role(s)
      in course.
    - can override domain defaults set for course-level privileges for ad hoc
      role(s).

- "Enter the course with one of the available ad hoc roles" radio button only
  displayed to user with Domain Heldesk role if custom ad hoc roles assigned.

- Support case where only one custom ad hoc role is available to current
  user.

- Link(s) to course/community selector(s) for ad hoc custom roles included
  with Domain Helpdesk role entry, for any custom helpdesk roles assigned
  to user.

- Domain configuration (Support Settings) allows custom course role(s) to be
  defined which will be available for domain helpdesk staff to select as
  ad hoc role(s) via "View a course or community" in main menu.

- Bug 6808. New course container -- "Placement" for Placement Tests.

- Bug 6808. New course container -- "Placement" for Placement Tests.
  Work in progress.

- Support checking of course cloning rights based on (a) domain defaults
  (where no course-specific rights set), or (b) course specific rights
  for official courses, based on institutional code category/ies set in
  courseprefs, e.g., department=phy etc.

- Only include setDefaultCredits() in javascript functions called on page
  load for course/community selection form where appropriate.

Improved internationalization:
- Properly compile translation phrases
- Updated related translation file entries

- Results of course search.
 - Text : 'Searching ...' hidden on completion of loading of results.

- &search_courses() and &js_changer() moved from lonpickcourse.pm to
  loncommon.pm to facilitate reuse.

- Moving &build_filters(), &timebased_select_form, &js_changer()
  from lonpickcourse.pm to loncommon.pm to facilitate re-use.

- Moving &instcode_selectors() from lonpickcourse.pm to courseclassifier.pm
  to facilitate re-use.

- New course request type -- textbook.
  - Can assign rights to request this type of course.
  - "textbook" can have different uploaded content quota, default credits etc.
    from official or unofficial course types.
  - Domain Coordinators can specify subject, tile, authors(s) and upload an
    image of the textbook cover.
- Work-in-progress.

XHTML: JavaScript event handlers in lower case

- No need to pass output from js_changer() to lonhtmlcommon::scripttag().
- Remove unnecessary concatenator.

- Credits earned for a course can be different for a specific student
  (specify when CC or DC enrolls a single student or a CC uploads a classlist
  file.

XHTML

- Internationalization
- Standard style

- Improve readability of "Course/Community Level" box in DC's create/modify
  user screen.

Bug 5853: Don't use tradmarked brandname "scantron" in interface anymore.
Some rests have been found and changed to "bubblesheet":
- Updated related scripts
- Consistent wording
- Tidy up translation files: Synchronized existing entries with used phrases in the current scripts.
  If the translation of an updated phrase is unclear, the old translation is kept as a comment and the original English phrase is used instead.

- Eventual implementation of storage of co-owners in nohist_courseids.db
  (LON-CAPA 2.9.0) was to store as comma separated list, not as anonymous array.

- Backport 1.100.

Give a different warning if the intended course owner was not specified yet.

- Backport 1.94, 1.98n being filtered by (used when DC is using course creation form). .

- Bug 6333.
  Ensure that form element names for select boxes for institutional codes
  are always named Year, Semester, Department, Number, for consistency with
  names used in javascript to update select box items dynamically.
  - Names of categories in domain from localenroll::instcode_format():
    codetitles array can differ from these form element names.

- DC can override course-specific cloning rights:
  (a) when DC creates a single course in a domain:
    (All courses in that domain are cloneable for all course owners).
  (b) when DC creates a single community in a domain:
    (All communities in that domain are cloneable for all community owners).

- Backport 1.97.

- Selection of clonable courses based on *:domain.
  - Need to match on $clonerudom ($env{'form.clonerudom'} doesn't exist).

Removed leftovers of already removed alternative login mode (accessibility).

- Bug 6251.
  - Third arg is now a ref to a hash, instead of a hash.
  - New (optional) fourth arg, is an additional attribute for the
    select tag, e.g., an onchange action.
- Update calls to loncommon::select_form() accordingly.

- Bug 6175.
  - Course created filter available to DCs - today, last week, last month etc.
    for domains responding to lonnet::get_server_loncaparev(),
    i.e., 2.9 or later (also have creation date in nohist_courseids.db).
  - selector for activity and creation date from new routine:
    &timebased_select_form().

- Make "view or modify course settings" the default when DC selects
  a course via "Modify Course".
- Display fullname instead of username:domain in Owner/Co-owner column
  in display of selectable courses matching current filters.

- Move generation of list of cloneable courses based on active CC role for
  a user to subroutine: &get_coordinator_cloneable() to facilitate reuse.

Localization - Corrected "loncommon::select_form" usage:
Only translate once but translate what needs to be translated. Don't translate custom text, e.g. custom folder names.
Even avoid ISE: Unusual but possible special folder names on messages screen used to be misinterpreted.

- Accommodate communities.
   - Additional arg in opencrbrowser() javascription function call.
     - typeelement in opener page set when course or community is selected in coursepick pop-up window (DC selecting course for adding role).

- Accommodate Communities
  - Course Type is fixed if course picker is called when selecting a course or community to clone (course creation or course request) as clone must be of same type as target.
  - Coordinator role in Community is "co".
  - javascript: setRoles() used to set role names for both DC assigning a course role to a user, and DC uploading a file of users and assigning a default role to them.
  - display of matches from search excludes institutional code column if search is for Communities.

- Accommodate Communities
  - (C)course(s) -> (C)community(ies)
  - ad hoc role for DC - "co" role assigned for communities.

- Update names in Roles drop down (Course Level) when DC selects
   a Community in which to assign new role to a user.

- Wording change for cloneable filter.

- When used in course request or course creation context, courses display replaces select button with text warning for courses for which owner lacks cloning rights.
- In those contexts can filter based on cloneability.
- Hierarchy of linked select boxes used for institutional codes (with official/unofficial radio button selectors) now used for "Modify Course" function available to Domain Coordinator.
- Eliminate "command" form element added in lonpickcourse.pm rev 1.84. Revert to check for g'osearch' form element to trigger search.
-  No search if page updated by onchange event for Type or Domain
   (as detected based on non-null value of updater form element).

lonpickcourse.pm
- Wording change.  "Course Type" changed to "Type".
- course filter form now sets a form element named "command" to 'gosearch' on submit.
- course filter form will automatically reload, but not search,
  if either Domain or Type are changed.

courseclassifier.pm
 Javascript function "setOfficial() checks if caller arg is defined

lond
&dump_course_id_handler() change.
 - change to the effect regexp_ok arg.
 - now if arg has a value of -1, a course will be excluded from the resturned list,
   if the instcode matches the RE.
   This excludes "official" courses (i.e., those with an instcode matching the expected pattern for the domain) from the list returned in a search for "unofficial" courses.

- Term used for type of course used to facilitate collaborative activities,
  e.g., in a campus organization will be "Community".

Optimized page title:
- Corrected &mt usage/text concationaton to allow proper translation
- Don't translate twice (title is passed to &start_page which does the translation)

- Restoring $caller as the last argument (now eighth) in lonpickcourse::build_filters().
  (removed in rev 1.78).
- Modifying calls to lonpickcourse.pm routines: build_filters() and display_matched_courses() in lonmodifycourse.pm, to take account of changed args.

Case where there are linked select boxes for Year, Semester etc. to generate instcode filter.
  - Add radio button to toggle between "official" and unofficial" courses.
  - Appropriate instcodefilter now set when "unofficial" is selected.
  - Javascript to keep select boxes and radio buttons in consistent state.

- Owner username textbox and domain selectbox now in a single row.
- When "Select Course" is called by Scantron Operator, "Course owner/co-owner" row is replaced with "Course personnel includes: " row.
  - Can be used to search for courses where specified username:domain has active no-student role.

- Course Picking screen for Scantron Operators:
   - Domain select box replaced with static domain ($env{'request.role.domain'}
   - If domain is static, and domain has institutional code formats defined
     - Replace institutional code textbox with liked select boxes as used in Course Catalog, to pick: (for example) year, semester, department, number.

- &instcode_selectors() routine added (uses courseclassifier to build the linked slect boxes).

Increase size of username input box on pick course screen

Consistent wording:
Replaced "Course Description" by "Course Title"

- Type information hidden in search results table.

Replaced action selection pick box by fieldset.

Missing "

Backport optimizations to &mt() calls included in 1.74.

- Optimized some &mt() calls
- Wrapped course selection items in LON-CAPA standard table

- type information hidden in search results table.

- hide type selector

- Highlighted selection for course action by adding a table
- Localized course type selection

- calls to &Apache::loncommon::start_data_table_row() and &Apache::loncommon::end_data_table_row() moved to correct locations.
- xhtml

Added table to course selection list

Backport 1.70

Missing &mt().

- backport 1.68, 1.69

Eliminate duplicate declaration

Bug 4323. Ability for DC to enter a course as a Course Coordinator from the Main Menu, in case the user has only one role (DC), so roles screen is skipped on log-in.
- Some spaces added to text displayed for matched courses in course search.

- hide type selector

Bug 5422
More comprehensive listing of LON-CAPA users.  Available to Domain Coordinators, Authors and Course Coordinators. Lists displayable in HTML, CSV or Excel formats.
- filter by status and role.
- DCs can specify a subset of courses for display of course roles.

lonuserutils.pm
- Elimination of &domain_form() -- generates linked selectboxes for domain and server selection -- no longer required (as new users can now only be created in the domain of the user's current role).
- Added &domain_roles_select() - used for linked role type and role selection boxes for DC, when displaying user roles.
- Display of active advanced roles when viewing course classlist eliminated
  - replaced with selectable advanced roles in role filter for user lists.

loncommon.pm
- &linked_select_forms() can take an additional argument ($menuorder) which specifies order of items in the first select box.
  - %menuhash can include hash key,value pair: order = reference to array
    (order of contents of the second select box) as optional item.
- get_course_users() has new optional arg (statushash) to return information about status (Expired, Active or Future) for each section for user's roles.
  - studentID information now included in optional hash of user information for course users.

lonhtmlcommon.pm
- &course_selection() routine split from &course_select_row() to allow reuse when selecting course filter for DC's listing of user roles.

loncoursedata.pm
- Three subroutines added to return indices for permanentemail, role and extent, so user listings in lonuserutils:;show_user_lists() can sort by these using the existing sorting code.

loncreateuser.pm
- display of user lists included in menu on first page.
- some wording changes (as per bug 5506)
- switches on $env{'form.state'} for call to &print_userlist() eliminated (not needed).
- course selector included when in DC context

lonpickcourse.pm
- domain selector defaults to domain of user's role when course selector used for studentform.

Work in progress - role expiration and section switching still to be added to interface.

Bug 2593 csv file upload by DC to change passwords
- DCs can change authentication, add a domain or course role for uploaded users, and/or change user information (names, ID, e-mail address etc.)
- Authors can add co-authors
- Course Coordinators can add course roles.
- Some subroutines in londropdd.pm moved to lonuserutils.pm.  Some routines in loncreateuser.pm moved to lonuserutils.pm
- &process_pick() moved from lonroles.pm to lonpickcourse.pm
- Work in progress.  Ultimate goal is to provide user listing functionality in different contexts and eliminate separate ENRL button.

Bug 5191.  Decouple storage of last access time for a course in nohist_courseids.db from storage of course information.
- Retain backwards compatibility with legacy lonnet::courseiddump()

Other general change: uniform use of 'inst_code' as key in frozen hash instead of 'instcode'.

lond
&put_course_id_handler()
- last access stored in escaped lasttime:courseid key = value hash item
  if legacy lonnet::courseiddump() updates courseinfo.
&put_course_id_hash_handler()
- additional argument - $mode ('timeonly', 'notime' or 'all')
  - determines whether last access, or courseinfo (description,inst_code,owner,type) or both are stored
&dump_course_id_handler()
- documentation updated
- style (replacing unless)
- change location of unescaping when checking filters so double escaping no longer needed for courseinfo stored in frozen hash
- return courseinfo in hash form, if requested as hash, when record has yet to be converted to a frozen hash
&validate_class_access_handler()
- eliminate extra unescaping of $ownerlist

lonnet.pm
&flushcourselogs() includes 'timeonly' argument in call to courseidput().
&courseidput() - if in 'timeonly' mode only courseids are sent to lond in courseidputhash call.
&createcourse()
- courseinfo values in hash no longer escaped (freeze_hash handles this)
- call to flushcourselogs() replaced by call to courseidput()

lonmodifycourse.pm
- courseinfo values in hash no longer escaped
- call to courseidput() includes 'notime' as fourth arg.

coursecatalog.pm
- remove unneeded code, since entry for each course in %courses hash will now be a hash ref.

courseclassifier.pm
- remove unneeded code, since entry for each course in %courses hash will now be a hash ref.

lonpickcourse.pm
- Entry for each course in %courses hash should be a hash ref, when constructing for onlyown courses case.
- instcode to inst_code
- no need to unescape courseinfo value (thaw_hash in lonnet::courseiddump does it)

lonparmset.pm
- call to flushcourselogs() replaced by call to courseidput() after updating course description.
- appenv user's session with new course description.

Store data in nohist_courseids.db as a hash.  Maintain backwards compatibility with writes to the db from legacy lonnet.pm, and also reads from the db from legacy lonnet.pm.

Start towards inclusion of co-owners as well as a single owner, for the purposes of verifying access to official classlist data.

lond
- &put_course_id_hash_handler() added to handle storage of data in nohist_courseids.db as a frozen hash.
- &put_course_id_handler() will add to an existing hash if update is from a legacy lonnet which supplies : separated data.
- &dump_course_id_handler() $as_hash flag extracted from tail. If set, data are returned as a hash.
- validate_class_access_handler() will extract comma-separated owner and co-owners from ownerlist passed to it, and send array ref to localenroll::check_section() to determine if at least one on the owners is authorized to view classlist list data for the institutional section.

lonnet.pm
- storage of hash via call to courseidputhash in lond.  If command is unrecognized on the lond side, subset of the data sent as : separated values
- retrieval of data from nohist_courseids.db - additional $as_hash argument included in courseiddump call to indicate that data should be returned as a frozen hash.
- auto_validate_class_sec() - if third argument is an array ref, then an owner list is built from the supplied owners and co-owners.
- lasttime set on lonnet side (FIXME) - to be changed to lond side.

lomodifycourse.pm
- updated course settings sent as a ref to a hash to lonnet::courseidput()
- include LC_error in span for error messages
- eliminate duplicate error message
- display error if storage of changes fails
- form name corrected to cmod.

coursecatalog.pm
- eliminate unused arg from call to courseclassifier::retrieve_instcodes
- display owner and co-owners (sort by lastname)
- institutional section access for multiple owners

courseclassifier.pm
- course codes from course data if hash, or if : separated string.

lonpickcourse.pm
- course info extracted from hash
- owner info displayed in a list if owner and co-owners exist.

- hide typeselector

- hide type selector
- hide group creation

- bugs#5226, need to set a default domain in port conditions

- eliminating the domain hash globals in favor of functional access

- backport 1.61

- couldn't search for - . userna,es and domains

- hide type selector

evb privilege - with this privilege users evade blocking of communication functionality defined by blocks placed by users with dcm privilege.

dcm privilege - this is now used to determine if link to block setting is displayed.

loncommon::findallcourses() now return a hash, where the keys are courseIDs instead of an array of courseIDs.  Places where findallcourses() was called - lonannounce, lonpickcourse changed accordingly.

loncommon::findallcourses() now reports courses for a user where the user's only role was a custom role.

lonnet::allowed() can now take a fourth optional argument ($role) which allows privs to be investigated for roles other than the user's currently active role

&blockcheck, &parse_block_record(), and &build_block_table() moved from lonmsgdisplay to loncommon, so they are available for evaluation of blocking state for other communication functions besides COM.

Each block record for a blocking event in a course is now a hash, with key=values of the hash being setter = username:domain of user who set block, title=event title for block, and blocks = hash of blocked features ('com','chat','boards','port','groups').

Backwards compatibility retained with previous : separated text for block record value.

user.adv gets to pick from all courses.

setroles form element needed in search form for portfolio access.

Works better if new $multiple argument is included in call to gochooser_javascript().

Fix capitalizations in course types.

Include $action argument in &build_filters() to allow use outside lonpickcourse.pm.

Include $action argunment in &display_matched_courses() to allow use outside lonpickcourse.pm.

Include filterlist argument in &build_filters to allow restrictions to be placed on which filters are displayed.

Add $multiple argument to &gochoose_javascript().  Different Javascript function code now emitted depending on whether multiple course selections are allowed or not.

Updated documentation.

- add in missing :

Documentation added.  Reorganization of handler() continues.  Dynamic population of roles, access type, section and groups select boxes as required when adding course-based access control for a portfolio file moved to portfolio.pm.  Similarly dynamic population of section numbers when DC is using CUSR to add a course-level role moved to opener window - loncommon::setsec_javascript() - to satisfy IE 6 limitations which do not permit child window to change select box options in opener window.  Required data is sent to opener window in comma-separated text strings to hidden form elements.

Start on subdividing monolithic handler() into subroutines.  When pickcourse is called from portfolio form (to choose a course to set conditional course-based access controls) now only courses in which user has an active role are offered as choices, if user does not have $env{'user.adv'} = 1.

Non-standard courses no longer being called 'Groups'

- backport 1.51 1.52

Bug 4813.  Retain backwards compatibility with legacy courses in which only a course owner's username is stored in environment.internal.courseowner, and in the course's record in nohist_courseids.db.  New courses will include username:domain (escaped) in nohist_courseids.db.  MCRS can be used to update legacy course owner information (just click "Modify Settings" button, it will be necessary to select the correct course owner where the course domain is different from the owner's domain.

- institutional code didn't have a space between the : and the input field

- hiding course type from 2.2

- extra definitions removed

Funtionality in pickcourse used to build contents of section select box moved to loncommon and extended to permit building of select boxes containing available roles in a course, status types and course groups.

pickcourse extended to support use by portfolio.pm when picking a course for course-based access controls, and providing role-specific,status-specific,section-specific and group-specific access controls.

Adding thin veneer to support "ANGEL-style" Discussion groups. "Select course" page modified to permit filtering based on course/group character.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

&coursegroups() and &get_group_settings() moved to longroup.pm, which contains general utility functions for asking about groups.  Also contains &group_changes() which is used to add/drop group memberships as a result of role changes, as determined by group settings for auto-add and auto-drop. 'none' and 'all' are now reserved words which may not be used as section or group names, so they can be used instead of _all and _none  when specifying auto-add and auto-drop settings for all sections or no section roles.

- morphing get_sections so it's easier to use

- changing loncommon::coursegroups to be easier to use

Prevent course sections created through use of CUSR being named 'none', 'all' or the same name as a course group.

- change add_entries to pass the hash

- growing the use of $args in start_page, looklike eventually I'll eliminate all bodytag calls for start_page calls

- mode <head> </headh> <</body> elimination

- restore case-insesitive soriting (while preserving case at duisplay time)

Typo and getting rid of lowercasing

- looks more enprettinated

DC's "Select Course" link to become a CC in a course in the domain now works for regular link in "Domain" as well as link in "Recent Roles".

Making support for multiple selects in pickcourse more general.

- letting those else's know that they are loved

- if only one course met the critia things didn't work on Firefox

- <label> is my best friend

- style police

Allow selection of multiple courses if called from rolefilter form (in lonnotify.pm to display users with roles in specific courses).

Navigation links in bodytag not needed in pickcourse pop-up window.

Bug 3912.  DCs can use courseID (e.g., 257472759ae4061msul1) as a filter when using pickcourse.

- ENV -> env

- <html> -> &Apache::lonxml::xmlbegin, thus valid doctypes are now getting output, Yeah! StandardsCmpliance

- backing out the encoding changes for now

- some xhtml cleanups
- one icon -> lonhttpd

Guy's suggested style improvements.

Fix bug 3806.

When lonpickcourse is being used to display existing sections in CUSR, use a select box with single select if there is only one existing section, to minimize confusion.

Revert to a single selection selectbox when course has no existing sections.

When using CUSR as a CC, only show roles for possible revocation, deletion or
re-enabling for target user in current course.  Section choices can now be
made from existing sections or new sections. Multiple sections allowed except
for ST and CC roles.

Adding storage of course owner to nohist_courseids.db.  Pick course can permits use of institutional code and/or username of course owner as filters.

DC can now add user roles to courses without needing an role in the target course.  Choice of sections can be made from existing sections, or new sections can be added.  Still need to add contextual help, and javascript to alert/prohibit > 1 section for a student role.

Users with multiple DC roles can now select a CC role from any of the domains in which they are DC. Extra click eliminated -- selection in Pickcourse window loads CC role in opener window.

Include institutional course code in nohist_courseids.db.
Format of entries in nohist_courseids.db now -
course_id = description:institutional code:last activity
both (keys and values are escaped).
lonnet::courseiddump now returns escaped values in hash (keys are unescaped),
to preserve the : separator between description and institutional code.

-sigh, use entities enocde, please ?

Bug #2734: do not trash special characters in Course Description

- trying to be UTF8 transparent

- BUG# 2716, show course title when picking a course

- localize last commit

- Let them know if nothing is found.

- sort them by description, not by internal ID number

- sorted order ain't always the best, thus select_form

Internationalization, German Localization

Bugfixes and enhancements on pickstudent and pickcourse.

First use of "pick-a-course" - does not set domain yet.

Appears to work now, except somehow for the plaintext domain descriptions.
The "course activity" filter could not yet be tested, since all activity
would still be within one day.

Pick-a-course, continued.

Lists courses and select buttons

Additional work on pick-a-course function from reverse lookup. Does not work
yet, but getting there.

Handler to pick a courseID from the nohist_courseid.db's on the library
servers