--- loncom/interface/lonprintout.pm	2008/10/02 17:40:34	1.536.2.3
+++ loncom/interface/lonprintout.pm	2008/12/15 23:12:26	1.545.2.1
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Printout
 #
-# $Id: lonprintout.pm,v 1.536.2.3 2008/10/02 17:40:34 raeburn Exp $
+# $Id: lonprintout.pm,v 1.545.2.1 2008/12/15 23:12:26 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -229,9 +229,11 @@ sub printf_style_subst {
 #     %a    - Assignment name.
 #     %c    - Course name.
 #     %n    - Student name.
+#     %s    - The section if it is supplied.
 #
 sub format_page_header {
-    my ($width, $format, $assignment, $course, $student) = @_;
+    my ($width, $format, $assignment, $course, $student, $section) = @_;
+
     
     $width = &recalcto_mm($width); # Get width in mm.
     #  Default format?
@@ -248,38 +250,43 @@ sub format_page_header {
 	# - Allow the assignment to be 2 lines (wrapped).
 	#
 	my $chars_per_line = $width/2; # Character/textline.
+	
 
 
-	my $firstline = "$student $course";
-	if (length($firstline) > $chars_per_line) {
-	    my $lastchar = $chars_per_line - length($student) - 1;
-	    if ($lastchar > 0) {
-		$course = substr($course, 0, $lastchar);
-	    } else {		# Nothing left of course:
-		$course = '';
-	    }
-	}
-	if (length($assignment) > $chars_per_line) {
-	    $assignment = substr($assignment, 0, $chars_per_line);
+	my $name_length    = int($chars_per_line *3 /4);
+	my $sec_length     = int($chars_per_line / 5);
+
+	$format  = "%$name_length".'n';
+
+	if ($section) {
+	    $format .=  ' - Sec: '."%$sec_length".'s';
 	}
-	
-	$format =  "\\textbf{$student} $course \\hfill \\thepage \\\\ \\textit{$assignment}";
-	
-    } else {
-	# An open question is how to handle long user formatted page headers...
-	# A possible future is to support e.g. %na so that the user can control
-	# the truncation of the elements that can appear in the header.
-	#
-	$format =  &printf_style_subst("a", $format, $assignment);
-	$format =  &printf_style_subst("c", $format, $course);
-	$format =  &printf_style_subst("n", $format, $student);
-
-	# If the user put %'s in the format string, they  must be escaped
-	# to \% else LaTeX will think they are comments and terminate
-	# the line.. which is bad!!!
 
+	$format .= '\\\\%c \\\\ %a';
+        
 
     }
+    # An open question is how to handle long user formatted page headers...
+    # A possible future is to support e.g. %na so that the user can control
+    # the truncation of the elements that can appear in the header.
+    #
+    $format =  &printf_style_subst("a", $format, $assignment);
+    $format =  &printf_style_subst("c", $format, $course);
+    $format =  &printf_style_subst("n", $format, $student);
+    $format =  &printf_style_subst("s", $format, $section);
+    
+    
+    # If the user put %'s in the format string, they  must be escaped
+    # to \% else LaTeX will think they are comments and terminate
+    # the line.. which is bad!!!
+    
+    # If the user has role author, $course and $assignment are empty so
+    # there is '\\ \\ ' in the page header. That's cause a error in LaTeX
+    if($format =~ /\\\\\s\\\\\s/) {
+        #TODO find sensible caption for page header
+        my $testPrintout = '\\\\'.&mt('Construction Space').' \\\\'.&mt('Test-Printout ');
+        $format =~ s/\\\\\s\\\\\s/$testPrintout/;
+    }
     
 
     return $format;
@@ -978,6 +985,8 @@ sub get_course {
     my $courseidinfo;
     if (defined($env{'request.course.id'})) {
 	$courseidinfo = &Apache::lonxml::latex_special_symbols(&unescape($env{'course.'.$env{'request.course.id'}.'.description'}),'header');
+	my $sec = $env{'request.course.sec'};
+	    
     }
     return $courseidinfo;
 }
@@ -1000,7 +1009,6 @@ sub page_format_transformation {
 
     my $name = &get_name();
     my $courseidinfo = &get_course();
-    if (defined($courseidinfo)) { $courseidinfo=' - '.$courseidinfo }
     my $header_text  = $parmhash{'print_header_format'};
     $header_text     = &format_page_header($textwidth, $header_text, $assignment,
 					   $courseidinfo, $name);
@@ -1273,20 +1281,43 @@ sub recently_generated {
 	    $cuid,$cgid,$crdev,$csize,
 	    $catime,$cmtime,$cctime,
 	    $cblksize,$cblocks)=stat($prtspool.'/'.$filename);
-	my $result="<a href='/prtspool/$filename'>".
-	    &mt('Generated [_1] ([_2] bytes)',
-		&Apache::lonlocal::locallocaltime($cctime),$csize).
-		'</a><br />';
+        my $ext_text = 'pdf' ? &mt('PDF File'):&mt('Zip File');
+	my $result=&Apache::loncommon::start_data_table_row()
+                  .'<td>'
+                  .'<a href="/prtspool/'.$filename.'">'.$ext_text.'</a>'
+                  .'</td>'
+                  .'<td>'.&Apache::lonlocal::locallocaltime($cctime).'</td>'
+                  .'<td align="right">'.$csize.'</td>'
+                  .&Apache::loncommon::end_data_table_row();
 	if ($ext eq 'pdf') { $pdf_result .= $result; }
 	if ($ext eq 'zip') { $zip_result .= $result; }
     }
+    if ($zip_result || $pdf_result) {
+        $r->print('<hr />');
+    }
     if ($zip_result) {
-	$r->print('<h4>'.&mt('Recently generated printout zip files')."</h4>\n"
-		  .$zip_result);
+	$r->print('<h3>'.&mt('Recently generated printout zip files')."</h3>\n"
+                  .&Apache::loncommon::start_data_table()
+                  .&Apache::loncommon::start_data_table_header_row()
+                  .'<th>'.&mt('Download').'</th>'
+                  .'<th>'.&mt('Creation Date').'</th>'
+                  .'<th>'.&mt('File Size (Bytes)').'</th>'
+                  .&Apache::loncommon::end_data_table_header_row()
+                  .$zip_result
+                  .&Apache::loncommon::end_data_table()
+        );
     }
     if ($pdf_result) {
-	$r->print('<h4>'.&mt('Recently generated printouts')."</h4>\n"
-		  .$pdf_result);
+	$r->print('<h3>'.&mt('Recently generated printouts')."</h3>\n"
+                  .&Apache::loncommon::start_data_table()
+                  .&Apache::loncommon::start_data_table_header_row()
+                  .'<th>'.&mt('Download').'</th>'
+                  .'<th>'.&mt('Creation Date').'</th>'
+                  .'<th>'.&mt('File Size (Bytes)').'</th>'
+                  .&Apache::loncommon::end_data_table_header_row()
+                  .$pdf_result
+                  .&Apache::loncommon::end_data_table()
+        );
     }
 }
 
@@ -1780,7 +1811,6 @@ ENDPART
 		if (($selectionmade == 4) and ($assignment ne $prevassignment)) {
 		    my $name = &get_name();
 		    my $courseidinfo = &get_course();
-		    if (defined($courseidinfo)) { $courseidinfo=' - '.$courseidinfo }
 		    $prevassignment=$assignment;
 		    my $header_text = $parmhash{'print_header_format'};
 		    $header_text    = &format_page_header($textwidth, $header_text,
@@ -2365,12 +2395,10 @@ sub print_resources {
 	if (&Apache::loncommon::connection_aborted($r)) { last; }
     }
     my $courseidinfo = &get_course();
-    if (defined($courseidinfo)) { $courseidinfo=' - '.$courseidinfo }
-    if ($usersection ne '') {$courseidinfo.=' - Sec. '.$usersection}
     my $currentassignment=&Apache::lonxml::latex_special_symbols($helper->{VARS}->{'assignment'},'header');
     my $header_line =
 	&format_page_header($LaTeXwidth, $parmhash{'print_header_format'},
-			    $currentassignment, $courseidinfo, $fullname);
+			    $currentassignment, $courseidinfo, $fullname, $usersection);
     my $header_start = ($columns_in_format == 1) ? '\lhead'
 	                                         : '\fancyhead[LO]';
     $header_line = $header_start.'{'.$header_line.'}';
@@ -3122,10 +3150,18 @@ CHOOSE_FROM_ANY_SEQUENCE
 
     if (($perm{'pav'} and &Apache::lonnet::allowed('vgr',$env{'request.course.id'})) or 
 	($helper->{VARS}->{'construction'} eq '1')) {
-	addMessage("<hr width='33%' /><table><tr><td align='right'>".
-                   '<label for="ANSWER_TYPE_forminput">'.
-                   &mt('Print').
-                   "</label>: </td><td>");
+	&addMessage('<br />'
+                   .'<h3>'.&mt('Print Options').'</h3>'
+                   .&Apache::lonhtmlcommon::start_pick_box()
+#                  .&Apache::lonhtmlcommon::row_headline()
+#                  .'<h3>'.&mt('Print Options').'</h3>'
+#                  .&Apache::lonhtmlcommon::row_closure()
+                   .&Apache::lonhtmlcommon::row_title(
+                       '<label for="ANSWER_TYPE_forminput">'
+                      .&mt('Print Answers')
+                      .'</label>'
+                    )
+        );
         $paramHash = Apache::lonhelper::getParamHash();
 	$paramHash->{'variable'} = 'ANSWER_TYPE';   
 	$helper->declareVar('ANSWER_TYPE');         
@@ -3135,7 +3171,7 @@ CHOOSE_FROM_ANY_SEQUENCE
                                    ['Only Answers', 'only']
                                 ];
         Apache::lonhelper::dropdown->new();
-	addMessage("</td></tr>");
+	&addMessage(&Apache::lonhtmlcommon::row_closure());
 	$startedTable = 1;
     }
 
@@ -3147,10 +3183,12 @@ CHOOSE_FROM_ANY_SEQUENCE
                        "</label>: </td><td>");
 	    $startedTable = 1;
 	} else {
-	    addMessage("<tr><td align='right'>".
-                       '<label for="LATEX_TYPE_forminput">'.
-                        &mt('LaTeX mode').
-                       "</label>: </td><td>");
+	    &addMessage(&Apache::lonhtmlcommon::row_title(
+                           '<label for="LATEX_TYPE_forminput">'
+                           .&mt('LaTeX mode')
+                           .'</label>'
+                        )
+            );
 	}
         $paramHash = Apache::lonhelper::getParamHash();
 	$paramHash->{'variable'} = 'LATEX_TYPE';   
@@ -3166,10 +3204,13 @@ CHOOSE_FROM_ANY_SEQUENCE
 	}
         Apache::lonhelper::dropdown->new();
  
-	addMessage("</td></tr><tr><td align='right'>".
-                   '<label for="TABLE_CONTENTS_forminput">'.
-                   &mt('Print Table of Contents').
-                   "</label>: </td><td>");
+	&addMessage(&Apache::lonhtmlcommon::row_closure()
+                   .&Apache::lonhtmlcommon::row_title(
+                        '<label for="TABLE_CONTENTS_forminput">'
+                       .&mt('Print Table of Contents')
+                       .'</label>'
+                    )
+        );
         $paramHash = Apache::lonhelper::getParamHash();
 	$paramHash->{'variable'} = 'TABLE_CONTENTS';   
 	$helper->declareVar('TABLE_CONTENTS');         
@@ -3177,13 +3218,15 @@ CHOOSE_FROM_ANY_SEQUENCE
                                    ['No', 'no'],
                                    ['Yes', 'yes'] ];
         Apache::lonhelper::dropdown->new();
-	addMessage("</td></tr>");
+	&addMessage(&Apache::lonhtmlcommon::row_closure());
         
 	if (not $helper->{VARS}->{'construction'}) {
-	    addMessage("<tr><td align='right'>".
-                       '<label for="TABLE_INDEX_forminput">'.
-                       &mt('Print Index').
-                       "</label>: </td><td>");
+	    &addMessage(&Apache::lonhtmlcommon::row_title(
+                            '<label for="TABLE_INDEX_forminput">'
+                           .&mt('Print Index')
+                           .'</label>'
+                        )
+            );
 	    $paramHash = Apache::lonhelper::getParamHash();
 	    $paramHash->{'variable'} = 'TABLE_INDEX';   
 	    $helper->declareVar('TABLE_INDEX');         
@@ -3191,11 +3234,13 @@ CHOOSE_FROM_ANY_SEQUENCE
 				     ['No', 'no'],
 				     ['Yes', 'yes'] ];
 	    Apache::lonhelper::dropdown->new();
-	    addMessage("</td></tr>");
-	    addMessage("<tr><td align='right'>".
-                       '<label for="PRINT_DISCUSSIONS_forminput">'.
-                       &mt('Print Discussions').
-                       "</label>: </td><td>");
+            &addMessage(&Apache::lonhtmlcommon::row_closure());
+            &addMessage(&Apache::lonhtmlcommon::row_title(
+                            '<label for="PRINT_DISCUSSIONS_forminput">'
+                           .&mt('Print Discussions')
+                           .'</label>'
+                        )
+            );
 	    $paramHash = Apache::lonhelper::getParamHash();
 	    $paramHash->{'variable'} = 'PRINT_DISCUSSIONS';   
 	    $helper->declareVar('PRINT_DISCUSSIONS');         
@@ -3203,14 +3248,16 @@ CHOOSE_FROM_ANY_SEQUENCE
 				     ['No', 'no'],
 				     ['Yes', 'yes'] ];
 	    Apache::lonhelper::dropdown->new();
-	    addMessage("</td></tr>");
+            &addMessage(&Apache::lonhtmlcommon::row_closure());
 
 	    # Prompt for printing annotations too.
 		
-	    addMessage("<tr><td align='right'>".
-		       '<label for="PRINT_ANNOTATIONS_forminput">'.
-		       &mt('Print Annotations').
-		       "</label>:</td><td>");
+	    &addMessage(&Apache::lonhtmlcommon::row_title(
+                            '<label for="PRINT_ANNOTATIONS_forminput">'
+                           .&mt('Print Annotations')
+                           .'</label>'
+                        )
+            );
 	    $paramHash = Apache::lonhelper::getParamHash();
 	    $paramHash->{'variable'} = "PRINT_ANNOTATIONS";
 	    $helper->declareVar("PRINT_ANNOTATIONS");
@@ -3218,16 +3265,16 @@ CHOOSE_FROM_ANY_SEQUENCE
 				     ['No', 'no'],
 				     ['Yes', 'yes']];
 	    Apache::lonhelper::dropdown->new();
-	    addMessage("</td></tr>");
+            &addMessage(&Apache::lonhtmlcommon::row_closure());
 
-	    addMessage("<tr><td align = 'right'>  </td><td>");
+            &addMessage(&Apache::lonhtmlcommon::row_title(&mt('Foils')));
 	    $paramHash = Apache::lonhelper::getParamHash();
 	    $paramHash->{'multichoice'} = "true";
 	    $paramHash->{'allowempty'}  = "true";
 	    $paramHash->{'variable'}   = "showallfoils";
 	    $paramHash->{'CHOICES'} = [ ["Show all foils", "1"] ];
 	    Apache::lonhelper::choices->new();
-	    addMessage("</td></tr>");
+            &addMessage(&Apache::lonhtmlcommon::row_closure(1));
 	}
 
 	if ($helper->{'VARS'}->{'construction'}) { 
@@ -3236,32 +3283,44 @@ CHOOSE_FROM_ANY_SEQUENCE
             my $stylefiletext=&mt("Use style file");
             my $selectfiletext=&mt("Select style file");
 
-	    my $xmlfrag .= <<"RNDSEED";
-	    <message><tr><td align='right'>
-            <label for="curseed_forminput">$randseedtext</label>:
-            </td><td></message>
-	    <string variable="curseed" size="15" maxlength="15">
-		<defaultvalue>
-	            return $helper->{VARS}->{'curseed'};
-	        </defaultvalue>
-	    </string>
-	     <message></td></tr><tr><td align="right">
-             <label for="style_file">$stylefiletext</label>:
-             </td><td></message>
+	    my $xmlfrag .= '<message>'
+            .&Apache::lonhtmlcommon::row_title('<label for="curseed_forminput">'
+                                              .$randseedtext
+                                              .'</label>'
+             )
+            .'</message>
+            <string variable="curseed" size="15" maxlength="15">
+                <defaultvalue>
+                   return '.$helper->{VARS}->{'curseed'}.';
+                </defaultvalue>'
+            .'</string>'
+            .'<message>'
+            .&Apache::lonhtmlcommon::row_closure()
+            .&Apache::lonhtmlcommon::row_title('<label for="style_file">'
+                                              .$stylefiletext
+                                              .'</label>'
+             )
+            .'</message>
              <string variable="style_file" size="40">
-		<defaultvalue>
-	            return $stylevalue;
-	        </defaultvalue>
-             </string><message>&nbsp; <a href="javascript:openbrowser('helpform','style_file_forminput','sty')">$selectfiletext</a> </td></tr><tr><td></td><td align="left"></message>
+                <defaultvalue>
+                    return '.$stylevalue.';
+                </defaultvalue>
+             </string><message>&nbsp;'
+.qq|<a href="javascript:openbrowser('helpform','style_file_forminput','sty')">|
+.$selectfiletext.'</a>'
+            .&Apache::lonhtmlcommon::row_closure()
+            .&Apache::lonhtmlcommon::row_title(&mt('Show all foils'))
+            .'</message>
 	     <choices allowempty="1" multichoice="true" variable="showallfoils">
-                <choice computer="1">Show all foils</choice>
-             </choices>
-	     <message></td></tr></message>
-RNDSEED
+                <choice computer="1">&nbsp;</choice>
+             </choices>'
+	    .'<message>'
+            .&Apache::lonhtmlcommon::row_closure()
+            .'</message>';
             &Apache::lonxml::xmlparse($r, 'helper', $xmlfrag);
 
 
-	    addMessage("<tr><td>Problem Type:</td><td>");
+            &addMessage(&Apache::lonhtmlcommon::row_title(&mt('Problem Type')));
 	    #
 	    # Initial value from construction space:
 	    #
@@ -3280,16 +3339,16 @@ RNDSEED
 PROBTYPE
             &Apache::lonxml::xmlparse($r, 'helper', $xmlfrag);
 	    
-	    addMessage("</td></tr>"); 
+            &addMessage(&Apache::lonhtmlcommon::row_closure(1));
 
-	} 
+        }
     }
 
 
 
 
     if ($startedTable) {
-	addMessage("</table>");
+        &addMessage(&Apache::lonhtmlcommon::end_pick_box());
     }
 
     Apache::lonprintout::page_format_state->new("FORMAT");
@@ -3388,23 +3447,21 @@ sub render {
     my $PaperType=&mt('Paper type');
     my $landscape=&mt('Landscape');
     my $portrait=&mt('Portrait');
-    $result .= <<STATEHTML;
+    $result.='<h3>'.&mt('Layout Options').'</h3>'
+            .&Apache::loncommon::start_data_table()
+            .&Apache::loncommon::start_data_table_header_row()
+            .'<th>'.$PageLayout.'</th>'
+            .'<th>'.$NumberOfColumns.'</th>'
+            .'<th>'.$PaperType.'</th>'
+            .&Apache::loncommon::end_data_table_header_row()
+            .&Apache::loncommon::start_data_table_row()
+    .'<td>'
+    .'<label><input type="radio" name="'.${var}.'.layout" value="L" />'.$landscape.'</label><br />'
+    .'<label><input type="radio" name="'.${var}.'.layout" value="P" checked="checked" />'.$portrait.'</label>'
+    .'</td>';
 
-<hr width="33%" />
-<table cellpadding="3">
-  <tr>
-    <td align="center"><b>$PageLayout</b></td>
-    <td align="center"><b>$NumberOfColumns</b></td>
-    <td align="center"><b>$PaperType</b></td>
-  </tr>
-  <tr>
-    <td>
-      <label><input type="radio" name="${var}.layout" value="L" /> $landscape </label><br />
-      <label><input type="radio" name="${var}.layout" value="P" checked='1'  /> $portrait </label>
-    </td>
-    <td align="center">
-      <select name="${var}.cols">
-STATEHTML
+    $result.='<td align="center">'
+            .'<select name="'.${var}.'.cols">';
 
     my $i;
     for ($i = 1; $i <= $maxColumns; $i++) {
@@ -3433,7 +3490,13 @@ STATEHTML
         }
         $i++;
     }
-    $result .= "</select></td></tr></table>";
+    $result .= <<HTML;
+        </select>
+    </td>
+HTML
+    $result.=&Apache::loncommon::end_data_table_row()
+            .&Apache::loncommon::end_data_table();
+
     return $result;
 }