--- loncom/interface/lonquickgrades.pm 2011/05/28 16:55:49 1.95 +++ loncom/interface/lonquickgrades.pm 2011/06/01 20:32:30 1.96 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Quick Student Grades Display # -# $Id: lonquickgrades.pm,v 1.95 2011/05/28 16:55:49 www Exp $ +# $Id: lonquickgrades.pm,v 1.96 2011/06/01 20:32:30 www Exp $ # # Copyright Michigan State University Board of Trustees # @@ -588,8 +588,10 @@ sub process_category_edits { sub output_category_table { my ($r,$cangrade,$navmaps,%categories)=@_; - my $sum=0; - my $total=0; + + my $totalweight=0; + my $totalpoints=0; + $r->print(&Apache::loncommon::start_data_table()); # &output_category_table_header($r,$cangrade); @@ -600,14 +602,18 @@ sub output_category_table { my $maxpos=$#order; for (my $i=0;$i<=$maxpos;$i++) { my ($correct,$possible,$type,$weight)=&output_and_calc_category($r,$cangrade,$navmaps,$order[$i],$i,$maxpos,\%performance,1,%categories); - $sum+=$correct*$weight; - $total+=$weight; + unless ($possible) { next; } + $totalpoints+=$weight*$correct/$possible; + $totalweight+=$weight; } # - &bottom_line_category($r,$cangrade,$sum,$total); + my $perc=0; + if ($totalweight) { $perc=100.*$totalpoints/$totalweight; } + + &bottom_line_category($r,$cangrade,$perc); # $r->print(&Apache::loncommon::end_data_table()); - return $sum; + return $perc; } sub output_category_table_header { @@ -681,7 +687,7 @@ ENDMOVE if ($possible>0) { push(@individual,"$possible:$correct"); } if ($output) { $r->print('
  • '); - $r->print(&Apache::lonnet::gettitle($contentid).' ('.$correct.'/'.$possible.')'); + $r->print(&Apache::lonnet::gettitle($contentid).' ('.&numberout($correct).'/'.&numberout($possible).')'); if ($cangrade) { $r->print(' '.&mt('Delete').''); } @@ -693,7 +699,7 @@ ENDMOVE if ($cangrade) { $r->print('
    '.&Apache::loncommon::selectresource_link('quickform','addcont_'.$id,&mt('Add Problem or Folder')).'
    '); } - $r->print('

    '.&mt('Total raw points: [_1]/[_2]',$totalcorrect,$totalpossible).'

    '); + $r->print('

    '.&mt('Total raw points: [_1]/[_2]',&numberout($totalcorrect),&numberout($totalpossible)).'

    '); $r->print(''); } # Total @@ -718,7 +724,7 @@ ENDMOVE $totalpossible=1.*$categories{$id.'_total'}; } if ($output) { - $r->print('

    '.&mt('Adjusted raw points: [_1]/[_2]',$totalcorrect,$totalpossible).'

    '); + $r->print('

    '.&mt('Adjusted raw points: [_1]/[_2]',&numberout($totalcorrect),&numberout($totalpossible)).'

    '); } @@ -762,7 +768,7 @@ ENDMOVE if ($output) { $r->print(''); if ($cangrade) { $r->print('
    '.&new_calc_rule_form($id)); } - $r->print('

    '.&mt('Calculated points: [_1]/[_2]',$totalcorrect,$totalpossible).'

    '); + $r->print('

    '.&mt('Calculated points: [_1]/[_2]',&numberout($totalcorrect),&numberout($totalpossible)).'

    '); $r->print(''); } # @@ -795,17 +801,17 @@ ENDMOVE } } if ($output) { - $r->print('

    '); + $r->print('

    '); if ($type eq 'percent') { my $perc='---'; if ($totalpossible) { $perc=100.*$totalcorrect/$totalpossible; } - $r->print(&mt('[_1] percent',$perc)); + $r->print(&mt('[_1] percent',&numberout($perc))); } else { - $r->print(&mt('[_1]/[_2] points',$totalcorrect,$totalpossible)); + $r->print(&mt('[_1]/[_2] points',&numberout($totalcorrect),&numberout($totalpossible))); } - $r->print('

    '); + $r->print('

    '); } if ($output) { $r->print(''); } @@ -857,14 +863,21 @@ sub drop { # sub bottom_line_category { - my ($r,$cangrade,$sum,$total)=@_; + my ($r,$cangrade,$perc)=@_; $r->print(&Apache::loncommon::start_data_table_row()); if ($cangrade) { $r->print(''.&mt('Create New Category').''); } - $r->print(''.&mt('Current:').$sum.'
    '.&mt('Total:').$total.'
    '); + $r->print(''.&mt('Total: [_1] percent',&numberout($perc)).''); } +sub numberout { + my ($number)=@_; + my $printout=sprintf("%.3f", $number); + $printout=~s/0+$//; + $printout=~s/\.$//; + return $printout; +} # # Make one new category #