'.&Apache::lonhtmlcommon::start_pick_box().$codepicker.
+ $r->print(&mt('Specify the course to be created.').
+ '
'.&Apache::lonhtmlcommon::start_pick_box().
+ $codepicker.
&Apache::lonhtmlcommon::end_pick_box().'
');
} else {
$next = $states->{$action}[$page+2];
@@ -985,7 +1253,7 @@ sub print_request_form {
if ($instcode eq '') {
$prev = $states->{$action}[$page-2];
}
- $r->print(&courseinfo_form($dom,$formname,$crstype,$next));
+ $r->print(&courseinfo_form($dom,$formname,$crstype,$next,$description));
} elsif ($state eq 'enrollment') {
if ($crstype eq 'official') {
&Apache::lonnet::auto_possible_instcodes($dom,\@codetitles,\%cat_titles,
@@ -997,6 +1265,79 @@ sub print_request_form {
} elsif ($state eq 'personnel') {
$r->print(&print_personnel_menu($dom,$formname,$crstype,$invalidcrosslist));
} elsif ($state eq 'review') {
+ my (%alerts,%rulematch,%inst_results,%curr_rules,%got_rules,%disallowmsg);
+ my $now = time;
+ for (my $i=0; $i<$env{'form.persontotal'}; $i++) {
+ my $personname = $env{'form.person_'.$i.'_uname'};
+ my $persondom = $env{'form.person_'.$i.'_dom'};
+ if (($personname =~ /^$match_username$/) &&
+ ($persondom =~ /^$match_domain$/)) {
+ if (&Apache::lonnet::domain($persondom)) {
+ my $personhome =
+ &Apache::lonnet::homeserver($personname,$persondom);
+ if ($personhome eq 'no_host') {
+ if ($persondom ne $dom) {
+ my $skipuser = 1;
+ if ($env{'user.role.dc./'.$persondom.'/'}) {
+ my ($start,$end) = split('.',$env{'user.role.dc./'.$persondom.'/'});
+ if (((!$start) || ($start < $now)) &&
+ ((!$end) || ($end > $now))) {
+ $skipuser = 0;
+ }
+ }
+ if ($skipuser) {
+ push(@disallowed,$i);
+ $disallowmsg{$i} = &mt('[_1] was excluded because new users need be from the course domain','
'.$personname.':'.$persondom.' ');
+ next;
+ }
+ }
+ if (&get_cancreate_status($persondom,$personname,$dom)) {
+ my ($allowed,$msg) =
+ &check_newuser_rules($persondom,$personname,
+ \%alerts,\%rulematch,\%inst_results,
+ \%curr_rules,\%got_rules);
+ if ($allowed) {
+ if (ref($inst_results{$personname.':'.$persondom}) eq 'HASH') {
+ if ($inst_results{$personname.':'.$persondom}{'lastname'} ne '') {
+ $env{'form.person_'.$i.'_lastname'} = $inst_results{$personname.':'.$persondom}{'lastname'};
+ }
+ if ($inst_results{$personname.':'.$persondom}{'firstname'} ne '') {
+ $env{'form.person_'.$i.'_firstname'} = $inst_results{$personname.':'.$persondom}{'firstname'};
+ }
+ if ($inst_results{$personname.':'.$persondom}{'permanentemail'} ne '') {
+ $env{'form.person_'.$i.'_emailaddr'} = $inst_results{$personname.':'.$persondom}{'permanentemail'};
+ }
+ }
+ } else {
+ push(@disallowed,$i);
+ $disallowmsg{$i} = &mt('[_1] was excluded because the username violated format rules for the domain','
'.$personname.':'.$persondom.' ');
+ }
+ } else {
+ push(@disallowed,$i);
+ $disallowmsg{$i} = &mt('[_1] was excluded because you may not request new users in the domain','
'.$personname.':'.$persondom.' ');
+ }
+ } else {
+ my %userenv =
+ &Apache::lonnet::userenvironment($persondom,$personname,'lastname','firstname','permanentemail');
+ if ($env{'form.person_'.$i.'_lastname'} eq '') {
+ $env{'form.person_'.$i.'_lastname'} = $userenv{'lastname'};
+ }
+ if ($env{'form.person_'.$i.'_firstname'} eq '') {
+ $env{'form.person_'.$i.'_firstname'} = $userenv{'firstname'};
+ }
+ if ($env{'form.person_'.$i.'_emailaddr'} eq '') {
+ $env{'form.person_'.$i.'_emailaddr'} = $userenv{'permanentemail'};
+ }
+ }
+ } elsif ($personname ne '') {
+ push(@disallowed,$i);
+ $disallowmsg{$i} = &mt('[_1] was excluded because the domain is invalid','
'.$personname.':'.$persondom.' ');
+ }
+ } elsif ($personname ne '') {
+ push(@disallowed,$i);
+ $disallowmsg{$i} = &mt('[_1] was excluded because the username or domain is invalid.','
'.$personname.':'.$persondom.' ');
+ }
+ }
my $cnum;
if ($env{'form.origcnum'} =~ /^($match_courseid)$/) {
$cnum = $env{'form.origcnum'};
@@ -1005,10 +1346,18 @@ sub print_request_form {
}
&Apache::lonnet::auto_possible_instcodes($dom,\@codetitles,\%cat_titles,
\%cat_order,\@code_order);
- $r->print('
'.&mt('Review course request details before submission').' '.
- &print_review($dom,\@codetitles,\%cat_titles,\%cat_order,\@code_order).
+ if ($crstype eq 'community') {
+ $r->print('
'.&mt('Review community request details before submission').' ');
+ } else {
+ $r->print('
'.&mt('Review course request details before submission').' ');
+ }
+ $r->print(&print_review($dom,\@codetitles,\%cat_titles,\%cat_order,\@code_order,'','',\@disallowed,\%disallowmsg).
'
');
- $navtxt{'next'} = &mt('Submit course request');
+ if ($crstype eq 'community') {
+ $navtxt{'next'} = &mt('Submit community request');
+ } else {
+ $navtxt{'next'} = &mt('Submit course request');
+ }
} elsif ($state eq 'process') {
if ($crstype eq 'official') {
&Apache::lonnet::auto_possible_instcodes($dom,\@codetitles,\%cat_titles,
@@ -1031,14 +1380,80 @@ sub print_request_form {
if ($state eq 'personnel') {
push(@excluded,'persontotal');
}
+ if ($state eq 'review') {
+ if (@disallowed > 0) {
+ my @items = qw(uname dom lastname firstname emailaddr hidedom role newsec);
+ my @currsecs = ¤t_lc_sections();
+ if (@currsecs) {
+ push(@items,'sec');
+ }
+ my $count = 0;
+ for (my $i=0; $i<$env{'form.persontotal'}; $i++) {
+ unless ($env{'form.person_'.$i.'_uname'} eq '') {
+ if (grep(/^$i$/,@disallowed)) {
+ foreach my $item (@items) {
+ $env{'form.person_'.$i.'_'.$item} = '';
+ }
+ } else {
+ foreach my $item (@items) {
+ $env{'form.person_'.$count.'_'.$item} = $env{'form.person_'.$i.'_'.$item};
+ }
+ }
+ }
+ $count ++;
+ }
+ $env{'form.persontotal'} = $count;
+
+ }
+ }
if ($state eq 'enrollment') {
push(@excluded,'crosslisttotal');
}
$r->print(&Apache::lonhtmlcommon::echo_form_input(\@excluded).'');
- &display_navbuttons($r,$formname,$prev,$navtxt{'prev'},$next,$navtxt{'next'},$state);
+ &display_navbuttons($r,$dom,$formname,$prev,$navtxt{'prev'},$next,
+ $navtxt{'next'},$state);
return;
}
+sub get_cancreate_status {
+ my ($persondom,$personname,$dom) = @_;
+ my ($rules,$ruleorder) =
+ &Apache::lonnet::inst_userrules($persondom,'username');
+ my $usertype = &Apache::lonuserutils::check_usertype($persondom,$personname,
+ $rules);
+ return &Apache::lonuserutils::can_create_user($dom,'requestcrs',$usertype);
+}
+
+sub check_newuser_rules {
+ my ($persondom,$personname,$alerts,$rulematch,$inst_results,$curr_rules,
+ $got_rules) = @_;
+ my $allowed = 1;
+ my $newuser = 1;
+ my ($checkhash,$userchkmsg);
+ my $checks = { 'username' => 1 };
+ $checkhash->{$personname.':'.$persondom} = { 'newuser' => $newuser };
+ &Apache::loncommon::user_rule_check($checkhash,$checks,$alerts,$rulematch,
+ $inst_results,$curr_rules,$got_rules);
+ if (ref($alerts->{'username'}) eq 'HASH') {
+ if (ref($alerts->{'username'}{$persondom}) eq 'HASH') {
+ my $domdesc =
+ &Apache::lonnet::domain($persondom,'description');
+ if ($alerts->{'username'}{$persondom}{$personname}) {
+ if (ref($curr_rules->{$persondom}) eq 'HASH') {
+ $userchkmsg =
+ &Apache::loncommon::instrule_disallow_msg('username',
+ $domdesc,1).
+ &Apache::loncommon::user_rule_formats($persondom,
+ $domdesc,$curr_rules->{$persondom}{'username'},
+ 'username');
+ }
+ $allowed = 0;
+ }
+ }
+ }
+ return ($allowed,$userchkmsg);
+}
+
sub get_excluded_elements {
my ($dom,$states,$action,$state) = @_;
my @excluded = ('counter');
@@ -1070,7 +1485,7 @@ sub get_excluded_elements {
sub print_enrollment_menu {
my ($formname,$instcode,$dom,$codetitles,$cat_titles,$cat_order,$code_order,
$invalidcrosslist) =@_;
- my ($sections,$autoenroll,$access_dates,$output);
+ my ($sections,$autoenroll,$access_dates,$output,$hasauto);
my $starttime = time;
my $endtime = time+(6*30*24*60*60); # 6 months from now, approx
@@ -1089,7 +1504,8 @@ sub print_enrollment_menu {
$section_form = &inst_section_selector($dom,$instcode);
if ($section_form) {
$sections = &Apache::lonhtmlcommon::row_headline().
- '
'.&mt('Sections for auto-enrollment').' '.
+ '
'.&Apache::loncommon::help_open_topic('Course_Request_Sections').
+ ' '.&mt('Sections for auto-enrollment').' '.
&Apache::lonhtmlcommon::row_closure(1).
$section_form;
}
@@ -1106,7 +1522,7 @@ sub print_enrollment_menu {
}
if ($crosslist_form) {
$crosslist_form .=
- &Apache::lonhtmlcommon::row_title(&mt('Add another?')).
+ &Apache::lonhtmlcommon::row_title(&mt('Add another')).
'
'.
'
'.
' '.
&mt('Yes').' '.(' 'x3).'
'.
' '.
&mt('No').' '.
&Apache::lonhtmlcommon::row_closure(1).
- &Apache::lonhtmlcommon::row_title(&mt('Drop unregistered students automatically')).
+ &Apache::lonhtmlcommon::row_title(&Apache::loncommon::help_open_topic('Course_Request_Autodrop').' '.&mt('Drop unregistered students automatically')).
'
'.
' '.
&mt('Yes').' '.(' 'x3).''.
' '.
&mt('No').' '.
&Apache::lonhtmlcommon::row_closure(1).
- &date_setting_table($starttime,$endtime,$formname,'enroll',%enrolltitles);
+ &date_setting_table($starttime,$endtime,$formname,'enroll',
+ $hasauto,%enrolltitles);
}
}
my $access_dates =
- &date_setting_table($starttime,$endtime,$formname,'access',%accesstitles);
+ &date_setting_table($starttime,$endtime,$formname,'access',$hasauto,
+ %accesstitles);
$output .= &Apache::lonhtmlcommon::start_pick_box();
if ($sections) {
$output .= $sections;
@@ -1189,18 +1608,23 @@ sub inst_section_selector {
'
'.&mt('Include?').' '.
'
'.&mt('Institutional Section').' '.
- '
'.&mt('LON-CAPA section').' '.
+ '
'.&Apache::loncommon::help_open_topic('Course_Request_LCSection').
+ ' '.&mt('LON-CAPA section').' '.
&Apache::loncommon::end_data_table_row();
for (my $i=0; $i<@sections; $i++) {
my $colflag = $i%2;
- my $checked = ' checked="checked"';
+ my $secon = ' checked="checked"';
+ my $secoff = '';
if ($env{'form.origcnum'}) {
- $checked='';
+ $secoff = $secon;
+ $secon='';
}
$output .= &Apache::loncommon::start_data_table_row().
- '
'.
- '
'.$sections[$i].
+ ' '.&mt('Yes').' '.
+ (' 'x2).' '.&mt('No').''.
+ '
'.$sections[$i].
' '.
'
'.$plrole.''."\n";
@@ -1273,17 +1712,7 @@ sub print_personnel_menu {
}
}
- my @currsecs;
- if ($env{'form.sectotal'}) {
- for (my $i=0; $i<$env{'form.sectotal'}; $i++) {
- if (defined($env{'form.loncapasec_'.$i})) {
- my $lcsec = $env{'form.loncapasec_'.$i};
- unless (grep(/^\Q$lcsec\E$/,@currsecs)) {
- push(@currsecs,$lcsec);
- }
- }
- }
- }
+ my @currsecs = ¤t_lc_sections();
my ($existtitle,$existops,$existmult,$newtitle,$seccolspan);
if (@currsecs) {
@@ -1305,22 +1734,23 @@ sub print_personnel_menu {
}
if ($persontotal) {
+ my %lt = &Apache::lonlocal::texthash(
+ community => 'Requestor is automatically assigned Coordinator role.',
+ official => 'Requestor is automatically assigned Course Coordinator role.',
+ );
+ $lt{'unofficial'} = $lt{'official'};
$output .= &Apache::lonhtmlcommon::row_headline().
- ''.&mt('Requestor is automatically assigned Course Coordinator role.').' '.&mt('Include other personnel?').' ';
+ ''.&Apache::loncommon::help_open_topic('Course_Request_Personnel').' '.$lt{$crstype}.' '.&mt('Include other personnel?').' ';
}
for (my $i=0; $i<$persontotal; $i++) {
my @linkargs = map { 'person_'.$i.'_'.$_ } (@items);
my $linkargstr = join("','",@linkargs);
- my $userlink = &Apache::loncommon::selectuser_link($formname,@linkargs,$dom,$userlinktxt);
- my $uname_form = ' ';
+ my $uname_form = ' ';
my $onchange = 'javascript:fix_domain('."'$formname','person_".$i."_dom',".
- "'person_".$i."_hidedom'".');'.
- 'openuserbrowser('."'$formname','$linkargstr','$dom'".');';
+ "'person_".$i."_hidedom','person_".$i."_uname'".');';
my $udom_form = &Apache::loncommon::select_dom_form($dom,'person_'.$i.'_dom','',
1,$onchange).
- ' ';
+ ' ';
my %form_elems;
foreach my $item (@items) {
next if (($item eq 'dom') || ($item eq 'uname') || ($item eq 'hidedom'));
@@ -1336,40 +1766,64 @@ sub print_personnel_menu {
}
$sectionselector .= $newtitle.
' '."\n";
+ my $usersrchlinktxt = &mt('Search for user');
+ my $usersrchlink = &Apache::loncommon::selectuser_link($formname,@linkargs,$dom,
+ $usersrchlinktxt);
+ my $userchklinktxt = &mt('Check username');
+ my $userchklink = &Apache::loncommon::selectuser_link($formname,@linkargs,$dom,
+ $userchklinktxt,'checkusername');
$output .=
- &Apache::lonhtmlcommon::row_title(&mt('Additional Personnel').' '.
- ''.$userlink.
- ' ').
- ''.&mt('Username').' '.$uname_form.' '."\n".
- ''.&mt('Domain').' '.$udom_form.' '."\n".
+ &Apache::lonhtmlcommon::row_title(&mt('Additional Personnel')).
+ ''.$usersrchlink.' '."\n".
+ ''.
+ &mt('Username').': '.$uname_form.' '.$userchklink.' '."\n".
+ ''.&mt('Domain').': '.$udom_form.' '.
+ ' '."\n".''.
''.&mt('First Name').' '.$form_elems{'firstname'}.' '."\n".
''.&mt('Last Name').' '.$form_elems{'lastname'}.' '."\n".
''.&mt('E-mail').' '.$form_elems{'emailaddr'}.' '."\n".
- ''.&mt('Role').' '.$roleselector.' '."\n".
- ''.&mt('Section(s)').' '.$sectionselector.' '."\n".
+ ''.&Apache::loncommon::help_open_topic('Course_Roles').' '.&mt('Role').' '.$roleselector.' '."\n".
+ ''.
+ &Apache::loncommon::help_open_topic('Course_Request_Rolesection').' '.&mt('LON-CAPA Section(s)').' '.$sectionselector.' '."\n".
'
'.&Apache::lonhtmlcommon::row_closure();
}
- $output .= &Apache::lonhtmlcommon::row_title(&mt('Add another?')).
+ $output .= &Apache::lonhtmlcommon::row_title(&mt('Add another')).
' '.
' '.&mt('Add?').&Apache::lonhtmlcommon::row_closure(1).
&Apache::lonhtmlcommon::end_pick_box().'';
+ if ($crstype eq 'community') {
+ $output .= ''.&mt('You may also add users later, once the community has been created, by using the "Manage community users" link, accessible from the "Main Menu".').'
';
+ } else {
+ $output .= ''.&mt('You may also add users later, once the course has been created, by using the "Manage course users" link, accessible from the "Main Menu".').'
';
+ }
return $output;
}
+sub current_lc_sections {
+ my @currsecs;
+ if ($env{'form.sectotal'}) {
+ for (my $i=0; $i<$env{'form.sectotal'}; $i++) {
+ if ($env{'form.sec_'.$i}) {
+ if (defined($env{'form.loncapasec_'.$i})) {
+ my $lcsec = $env{'form.loncapasec_'.$i};
+ unless (grep(/^\Q$lcsec\E$/,@currsecs)) {
+ push(@currsecs,$lcsec);
+ }
+ }
+ }
+ }
+ }
+ return @currsecs;
+}
+
sub print_request_status {
my ($dom) = @_;
my %statusinfo = &Apache::lonnet::dump('courserequests',$env{'user.domain'},
$env{'user.name'},'^status:'.$dom);
- my ($output,$formname,%queue_by_date,%typenames);
- if ($env{'form.crstype'} eq 'any') {
- %typenames = &Apache::lonlocal::texthash (
- official => 'Official course',
- unofficial => 'Unofficial course',
- community => 'Community',
- );
- }
+ my ($output,$formname,%queue_by_date);
+ my ($types,$typenames) = &Apache::loncommon::course_types();
foreach my $key (keys(%statusinfo)) {
if (($statusinfo{$key} eq 'approval') || ($statusinfo{$key} eq 'pending')) {
(undef,my($cdom,$cnum)) = split(':',$key);
@@ -1415,10 +1869,18 @@ sub print_request_status {
' '."\n".
' '."\n";
if (@sortedtimes > 0) {
+ my $desctitle;
+ if ($env{'form.crstype'} eq 'any') {
+ $desctitle = &mt('Course/Community Description')
+ } elsif ($env{'form.crstype'} eq 'community') {
+ $desctitle = &mt('Community Description')
+ } else {
+ $desctitle = &mt('Course Description');
+ }
$output .= &Apache::loncommon::start_data_table().
&Apache::loncommon::start_data_table_header_row().
''.&mt('Action').' '.
- ''.&mt('Course Description').' '.
+ ''.$desctitle.' '.
''.&mt('Domain').' ';
if ($env{'form.crstype'} eq 'any') {
$output .= ''.&mt('Type').' ';
@@ -1440,7 +1902,10 @@ sub print_request_status {
''.&unescape($desc).' '.
''.$cdom.' ';
if ($env{'form.crstype'} eq 'any') {
- my $typename = $typenames{$type};
+ my $typename;
+ if (ref($typenames) eq 'HASH') {
+ $typename = &mt($typenames->{$type});
+ }
if ($typename eq '') {
$typename = &mt('Unknown type');
}
@@ -1463,11 +1928,16 @@ sub print_request_status {
}
$output .= &Apache::loncommon::end_data_table();
} else {
- $output .= ''.&mt('You have no matching course requests awaiting approval by a Domain Coordinator or held in a queue pending administrative action at your institution.').'
';
+ if ($env{'form.crstype'} eq 'any') {
+$output .= ''.&mt('You have no matching course or community requests awaiting approval by a Domain Coordinator or held in a queue pending administrative action at your institution.').'
';
+ } elsif ($env{'form.crstype'} eq 'community') {
+ $output .= ''.&mt('You have no matching community requests awaiting approval by a Domain Coordinator or held in a queue pending administrative action at your institution.').'
';
+ } else {
+ $output .= ''.&mt('You have no matching course requests awaiting approval by a Domain Coordinator or held in a queue pending administrative action at your institution.').'
';
+ }
}
$output .= '
-
-';
+ ';
return $output;
}
@@ -1489,7 +1959,7 @@ sub print_cancel_request {
}
$output = &mt('No further action will be taken');
} elsif (ref($history{'details'}) eq 'HASH') {
- my ($types,$typename) = &course_types();
+ my ($types,$typename) = &Apache::loncommon::course_types();
my $showtype = $crstype;
if (defined($typename->{$crstype})) {
$showtype = $typename->{$crstype};
@@ -1505,8 +1975,12 @@ sub print_cancel_request {
''.$showtype.' '.
&Apache::loncommon::end_data_table_row().
&Apache::loncommon::end_data_table().
- ''.
- &mt('Cancelling the request will remove it from the queue of pending course requests').'
';
+ '';
+ if ($crstype eq 'community') {
+ $output .= &mt('Cancelling the request will remove it from the queue of pending community requests').'
';
+ } else {
+ $output .= &mt('Cancelling the request will remove it from the queue of pending course requests').'';
+ }
$result = 'ok';
} else {
$output = ''.&mt('No record exists for the course ID').'
';
@@ -1573,8 +2047,9 @@ sub print_request_logs {
}
sub print_review {
- my ($dom,$codetitles,$cat_titles,$cat_order,$code_order,$uname,$udom) = @_;
- my ($types,$typename) = &course_types();
+ my ($dom,$codetitles,$cat_titles,$cat_order,$code_order,$uname,$udom,
+ $disallowed,$disallowmsg) = @_;
+ my ($types,$typename) = &Apache::loncommon::course_types();
my ($owner,$ownername,$owneremail);
if ($uname eq '' || $udom eq '') {
$uname = $env{'user.name'};
@@ -1593,7 +2068,7 @@ sub print_review {
$crstypename = $env{'form.crstype'};
if (ref($typename) eq 'HASH') {
unless ($typename->{$env{'form.crstype'}} eq '') {
- $crstypename = $typename->{$env{'form.crstype'}};
+ $crstypename = &mt($typename->{$env{'form.crstype'}});
}
}
my $category = 'Course';
@@ -1697,7 +2172,8 @@ sub print_review {
if (($env{'form.clonecrs'} =~ /^$match_name$/) &&
($env{'form.clonedom'} =~ /^$match_domain$/)) {
my $canclone = &Apache::loncoursequeueadmin::can_clone_course($env{'user.name'},
- $env{'user.domain'},$env{'form.clonecrs'}, $env{'form.clonedom'});
+ $env{'user.domain'},$env{'form.clonecrs'},$env{'form.clonedom'},
+ $env{'form.crstype'});
if ($canclone) {
my %courseenv = &Apache::lonnet::userenvironment($env{'form.clonedom'},
$env{'form.clonecrs'},('description','internal.coursecode'));
@@ -1739,26 +2215,40 @@ sub print_review {
}
my $container = 'Course';
+ my $ccrole = 'cc';
if ($env{'form.crstype'} eq 'community') {
$container = 'Community';
+ $ccrole = 'co';
}
$personnel_headers = ''.&mt('Name').' '.&mt('Username:Domain').
' '.&mt('Role').' '.&mt('LON-CAPA Sections').
' ';
+
$personnel_values .= ' '.$ownername.' '.$owner.' '.
- ''.&Apache::lonnet::plaintext('cc',$container).' '.
+ ''.&Apache::lonnet::plaintext($ccrole,$container).' '.
''.&mt('None').' ';
for (my $i=0; $i<$env{'form.persontotal'}; $i++) {
if ($env{'form.person_'.$i.'_uname'} ne '') {
- my @allsecs = &Apache::loncommon::get_env_multiple('form.person_'.$i.'_sec');
+ if (ref($disallowed) eq 'ARRAY') {
+ next if (grep(/^$i$/,@{$disallowed}));
+ }
+ my @officialsecs = &Apache::loncommon::get_env_multiple('form.person_'.$i.'_sec');
+ my @allsecs;
+ foreach my $sec (@officialsecs) {
+ next unless ($sec =~ /\w/);
+ next if ($sec =~ /\W/);
+ next if ($sec eq 'none');
+ push(@allsecs,$sec);
+ }
my $newsec = $env{'form.person_'.$i.'_newsec'};
$newsec =~ s/^\s+//;
$newsec =~s/\s+$//;
- my @newsecs = split(/[\s,;]+/,$newsec);
+ my @newsecs = split(/\s*[\s,;:]\s*/,$newsec);
foreach my $sec (@newsecs) {
+ next unless ($sec =~ /\w/);
next if ($sec =~ /\W/);
- next if ($newsec eq 'none');
+ next if ($sec eq 'none');
if ($sec ne '') {
unless (grep(/^\Q$sec\E$/,@allsecs)) {
push(@allsecs,$sec);
@@ -1772,7 +2262,7 @@ sub print_review {
if ($showsec eq '') {
$showsec = &mt('None');
}
- if ($env{'form.person_'.$i.'_role'} eq 'cc') {
+ if ($env{'form.person_'.$i.'_role'} eq $ccrole) {
$showsec = &mt('None');
}
my $role = $env{'form.person_'.$i.'_role'};
@@ -1785,8 +2275,20 @@ sub print_review {
''.$showsec.' ';
}
}
- my $output =
- ''.&Apache::lonhtmlcommon::start_pick_box().
+ my $output;
+ if (ref($disallowed) eq 'ARRAY') {
+ if (@{$disallowed} > 0) {
+ if (ref($disallowmsg) eq 'HASH') {
+ $output = '
'.
+ &mt('Not all requested personnel could be included.').'
';
+ foreach my $item (@{$disallowed}) {
+ $output .= ''.$disallowmsg->{$item}.' ';
+ }
+ $output .= ' ';
+ }
+ }
+ }
+ $output .= '
'.&Apache::lonhtmlcommon::start_pick_box().
&Apache::lonhtmlcommon::row_title(&mt('Owner')).
'
'.
''.&mt('Name').' '.
@@ -1832,15 +2334,19 @@ sub dates_from_form {
}
sub courseinfo_form {
- my ($dom,$formname,$crstype,$next) = @_;
- my $nodescr = &mt('You must provide a (brief) course description.');
+ my ($dom,$formname,$crstype,$next,$description) = @_;
+ my %lt = &Apache::lonlocal::texthash(
+ official => 'You must provide a (brief) course description.',
+ community => 'You must provide a (brief) community description.'
+ );
+ $lt{'unofficial'} = $lt{'official'};
my $js_validate = <<"ENDJS";