--- loncom/interface/lonrequestcourse.pm	2020/07/20 11:30:21	1.95.2.5.2.1
+++ loncom/interface/lonrequestcourse.pm	2021/12/14 02:54:52	1.95.2.7
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Request a course
 #
-# $Id: lonrequestcourse.pm,v 1.95.2.5.2.1 2020/07/20 11:30:21 raeburn Exp $
+# $Id: lonrequestcourse.pm,v 1.95.2.7 2021/12/14 02:54:52 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -559,7 +559,6 @@ sub form_elements {
                 clonedom         => 'selectbox',
                 datemode         => 'radio',
                 dateshift        => 'text',
-                tinyurls         => 'radio',
             },
             enrollment  => {
                 accessstart_month  => 'selectbox',
@@ -2396,7 +2395,7 @@ sub print_cancel_request {
                       &Apache::loncommon::start_data_table_row().
                       '<td>'.$history{details}{'cdescr'}.'</td><td>'.
                       &Apache::lonlocal::locallocaltime($timestamp).'</td>'.
-                      '<td>'.$showtype.'</td>'.
+                      '<td>'.&mt($showtype).'</td>'.
                       &Apache::loncommon::end_data_table_row().
                       &Apache::loncommon::end_data_table().
                       '<br /><div class="LC_warning">';
@@ -2750,7 +2749,7 @@ sub requestlog_display_filter {
                         $typename = $typenames->{$crstype};
                     }
                 }
-                $output .= '<option value="'.$crstype.'"'.$selstr.'>'.$typename.'</option>'."\n";
+                $output .= '<option value="'.$crstype.'"'.$selstr.'>'.&mt($typename).'</option>'."\n";
             }
             $output .= '</select></td>';
         }
@@ -2926,7 +2925,7 @@ sub print_review {
         $inst_values .= '<td>'.$env{'form.coursecredits'}.'</td>';
     }
 
-    my %ctxt = &clone_text($env{'form.crstype'});
+    my %ctxt = &clone_text();
     $inst_headers .= '<th>'.&mt('Clone From').'</th>';
     if (($env{'form.cloning'}) &&
         ($env{'form.clonecrs'} =~ /^$match_name$/) && 
@@ -2938,8 +2937,7 @@ sub print_review {
             my %courseenv = &Apache::lonnet::userenvironment($env{'form.clonedom'},
                               $env{'form.clonecrs'},('description','internal.coursecode'));
             if (keys(%courseenv) > 0) {
-                $inst_headers .= '<th>'.$ctxt{'dsh'}.'</th>'.
-                                 '<th>'.$ctxt{'dpl'}.'</th>';
+                $inst_headers .= '<th>'.$ctxt{'dsh'}.'</th>';
                 $inst_values .= '<td>'.$courseenv{'description'}.'&nbsp;';
                 my $cloneinst = $courseenv{'internal.coursecode'};
                 if ($cloneinst ne '') {
@@ -2955,14 +2953,6 @@ sub print_review {
                 } else {
                     $inst_values .= $ctxt{'ncd'};
                 }
-                $inst_values .= '</td><td>';
-                if ($env{'form.tinyurls'} eq 'delete') {
-                    $inst_values .= $ctxt{'nsl'};
-                } elsif ($env{'form.tinyurls'} eq 'transfer') {
-                    $inst_values .= $ctxt{'tsl'};
-                } else {
-                    $inst_values .= $ctxt{'csl'};
-                }
                 $inst_values .= '</td>';
              } else {
                  $inst_values .= '<td>'.&mt('Unknown').'</td>';
@@ -3191,7 +3181,7 @@ sub clone_form {
     if ($crstype eq 'community') {
         $type = 'Community';
     }
-    my %lt = &clone_text($crstype);
+    my %lt = &clone_text();
     my $output .= 
         &Apache::lonhtmlcommon::row_title($lt{'dmn'}).'<label>'.
         &Apache::loncommon::select_dom_form($dom,'clonedom').'</label>'.
@@ -3208,38 +3198,20 @@ sub clone_form {
         '</label><br /><label>'.
         '<input type="radio" name="datemode" value="shift" checked="checked" /> '.
         $lt{'shd'}.'</label>'.
-        '<input type="text" size="5" name="dateshift" value="365" />'.
-        &Apache::lonhtmlcommon::row_closure(1).
-        &Apache::lonhtmlcommon::row_title($lt{'dpl'}).'<label>'.
-        '<input type="radio" name="tinyurls" value="delete" /> '.$lt{'nsl'}.
-        '</label><br /><label>'.
-        '<input type="radio" name="tinyurls" value="transfer" /> '.$lt{'tsl'}.
-        '</label><br /><label>'.
-        '<input type="radio" name="tinyurls" value="create" checked="checked" /> '.$lt{'csl'}.
-        '</label>'.
+        '<input type="text" size="5" name="dateshift" value="364" />'.
         &Apache::lonhtmlcommon::row_closure(1);
     return $output;
 }
 
 sub clone_text {
-    my ($crstype) = @_;
-    my %lt = &Apache::lonlocal::texthash(
+    return &Apache::lonlocal::texthash(
                'cid'  => 'Course ID',
                'dmn'  => 'Domain',
                'dsh'  => 'Date Shift',
                'ncd'  => 'Do not clone date parameters',
                'prd'  => 'Clone date parameters as-is',
                'shd'  => 'Shift date parameters by number of days',
-               'dpl'  => 'URL shortcuts (for deep linking)',
-               'nsl'  => 'Do not clone URL shortcuts',
-               'tsl'  => 'Transfer URL shortcuts from existing course to new course',
-               'csl'  => 'Create new URL shortcuts in new course',
-    );
-    if ($crstype eq 'Community') {
-        $lt{'tsl'} = &mt('Transfer URL shortcuts from existing course to new community');
-        $lt{'csl'} = &mt('Create new URL shortcuts in new course');
-    }
-    return %lt;
+        );
 }
 
 sub coursecode_form {
@@ -3681,7 +3653,6 @@ sub print_request_outcome {
                     clonecrs       => $clonecrs,
                     datemode       => $env{'form.datemode'},
                     dateshift      => $env{'form.dateshift'},
-                    tinyurls       => $env{'form.tinyurls'},
                     sectotal       => $sectotal,
                     sections       => \%sections,
                     crosslisttotal => $crosslisttotal,
@@ -3813,9 +3784,7 @@ sub process_request {
             $storeresult = 'rejected';
         } elsif ($disposition eq 'process') {
             my %domdefs = &Apache::lonnet::get_domain_defaults($dom);
-            my ($logmsg,$newusermsg,$addresult,$enrollcount,$response,
-                $keysmsg,%longroles,$code);
-            my $clonemsg = [];
+            my ($logmsg,$newusermsg,$addresult,$enrollcount,$response,$keysmsg,%longroles,$code);
             my $type = 'Course';
             if ($crstype eq 'community') {
                 $type = 'Community';
@@ -3848,9 +3817,9 @@ sub process_request {
             $customitems{'_LC_coursestartdate'} = $accessstart;
             $customitems{'_LC_courseenddate'} = $accessend;
             my ($result,$postprocess) = &Apache::loncoursequeueadmin::course_creation($dom,$cnum,
-                                          'autocreate',$details,\$logmsg,$clonemsg,\$newusermsg,
-                                          \$addresult,\$enrollcount,\$response,\$keysmsg,\%domdefs,
-                                          \%longroles,\$code,\%customitems);
+                                          'autocreate',$details,\$logmsg,\$newusermsg,\$addresult,
+                                          \$enrollcount,\$response,\$keysmsg,\%domdefs,\%longroles,
+                                          \$code,\%customitems);
             if (ref($postprocess) eq 'HASH') {
                 $customized = $postprocess->{'createdcustomized'};
             }
@@ -3884,20 +3853,6 @@ sub process_request {
                     $output .= '<br />'.$role_result;
                 }
                 $output .= '</p>';
-                if ($logmsg) {
-                    $output .= '<p>'.$logmsg.'</p>';
-                }
-                if ((ref($clonemsg) eq 'ARRAY') && (@{$clonemsg})) {
-                    $output .= '<p class="LC_info">';
-                    my $user_lh = &Apache::loncommon::user_lang($env{'user.name'},$env{'user.domain'});
-                    foreach my $item (@{$clonemsg}) {
-                        if (ref($item) eq 'HASH') {
-                            $output .= &mt_user($user_lh,$item->{mt},
-                                                @{$item->{args}}).'<br />'."\n";
-                        }
-                    }
-                    $output .= '</p>'."\n";
-                }
                 $creationresult = 'created';
                 # Flush the course logs so reverse user roles immediately updated
                 unless ($registered_flush) {
@@ -4025,7 +3980,7 @@ sub process_request {
             } elsif ($disposition eq 'pending') {
                 my $pendingform;
                 if ($crstype ne 'official') {
-                    $pendingform = &pending_validation_form($dom,$cnum,$crstype,$now,$token,
+                    $pendingform = &pending_validation_form($r,$dom,$cnum,$crstype,$now,$token,
                                                             $lonhost,$env{'form.cdescr'});
                 }
                 if ($pendingform) {
@@ -4343,7 +4298,7 @@ sub notification_information {
 }
 
 sub pending_validation_form {
-    my ($cdom,$cnum,$crstype,$now,$token,$lonhost,$cdesc) = @_;
+    my ($r,$cdom,$cnum,$crstype,$now,$token,$lonhost,$cdesc) = @_;
     my $output;
     my %postvalues = (
                       'owner'      => $env{'user.name'}.':'.$env{'user.domain'},
@@ -4379,6 +4334,8 @@ sub pending_validation_form {
                 my $hostname = &Apache::lonnet::hostname($lonhost);
                 my $protocol = $Apache::lonnet::protocol{$lonhost};
                 $protocol = 'http' if ($protocol ne 'https');
+                my $alias = &Apache::lonnet::use_proxy_alias($r,$lonhost);
+                $hostname = $alias if ($alias ne '');
                 my $crscreator = $protocol.'://'.$hostname.'/cgi-bin/createpending.pl';
                 $output .= '<input type="hidden" name="crscreator" value="'.$crscreator.'" />'."\n".
                            '<input type="hidden" name="token" value="'.$token.'" />'."\n".
@@ -4455,7 +4412,6 @@ sub retrieve_settings {
             }
             $env{'form.datemode'} = $reqinfo{'datemode'};
             $env{'form.dateshift'} = $reqinfo{'dateshift'};
-            $env{'form.tinyurls'} = $reqinfo{'tinyurls'}; 
             if ($reqinfo{'crstype'} eq 'official') {
                 $env{'form.autoadds'} = $reqinfo{'autoadds'};
                 $env{'form.autodrops'} = $reqinfo{'autodrops'};
@@ -4858,26 +4814,17 @@ sub print_textbook_form {
 #
 # Table of user's current courses (owner and/or course coordinator)
 #
-    my %lt = &clone_text('Course');
+    my %lt = &clone_text();
     if (keys(%cloneable)) {
         $r->print('<div id="showexisting" style="display:none">'.
                   &clone_selection_table($dom,'owned',\%cloneable).
-                  '<fieldset style="display:inline-block"><legend>'.$lt{'dsh'}.'</legend><label>'.
-                  '<input type="radio" name="owndatemode" value="delete" /> '.$lt{'ncd'}.
+                  '<p><input type="radio" name="owndatemode" value="delete" /> '.$lt{'ncd'}.
                   '</label><br /><label>'.
                   '<input type="radio" name="owndatemode" value="preserve" /> '.$lt{'prd'}.
                   '</label><br /><label>'.
                   '<input type="radio" name="owndatemode" value="shift" checked="checked" /> '.
                   $lt{'shd'}.'</label>'.
-                  '<input type="text" size="5" name="owndateshift" value="365" />'.
-                  '</fieldset><fieldset style="display:inline-block">'.
-                  '<legend>'.$lt{'dpl'}.'</legend><label>'.
-                  '<input type="radio" name="owntinyurls" value="delete" />'.$lt{'nsl'}.
-                  '</label><br /><label>'.
-                  '<input type="radio" name="owntinyurls" value="transfer" />'.$lt{'tsl'}.
-                  '</label><br /><label>'.
-                  '<input type="radio" name="owntinyurls" value="create" checked="checked" />'.$lt{'csl'}.
-                  '</label></fieldset>'.
+                  '<input type="text" size="5" name="owndateshift" value="364" />'.
                   '</div>');
     }
 #
@@ -4886,20 +4833,13 @@ sub print_textbook_form {
     if (keys(%domcloneable)) {
         $r->print('<div id="showcolleague" style="display:none">'.
                   &clone_selection_table($dom,'colleague',\%domcloneable).
-                  '<fieldset style="display:inline-block"><legend>'.$lt{'dsh'}.'</legend><label>'.
-                  '<input type="radio" name="colldatemode" value="delete" /> '.$lt{'ncd'}.
+                  '<p><input type="radio" name="colldatemode" value="delete" /> '.$lt{'ncd'}.
                   '</label><br /><label>'.
                   '<input type="radio" name="colldatemode" value="preserve" /> '.$lt{'prd'}.
                   '</label><br /><label>'.
                   '<input type="radio" name="colldatemode" value="shift" checked="checked" /> '.
                   $lt{'shd'}.'</label>'.
-                  '<input type="text" size="5" name="colldateshift" value="365" />'.
-                  '</fieldset><fieldset style="display:inline-block">'.
-                  '<legend>'.$lt{'dpl'}.'</legend><label>'.
-                  '<input type="radio" name="colltinyurls" value="delete" />'.$lt{'nsl'}.
-                  '</label><br /><label>'.
-                  '<input type="radio" name="colltinyurls" value="create" checked="checked" />'.$lt{'csl'}.
-                  '</label></fieldset>'.
+                  '<input type="text" size="5" name="colldateshift" value="364" />'.
                   '</div>');
     }
 
@@ -5130,7 +5070,6 @@ sub process_textbook_request {
             } else {
                 $details->{dateshift} = '';
             }
-            $details->{tinyurls} = $env{'form.owntinyurls'};
         } elsif ($reqtype eq 'colleague') {
             $details->{datemode} = $env{'form.colldatemode'};
             if ($details->{datemode} eq 'shift') {
@@ -5138,11 +5077,9 @@ sub process_textbook_request {
             } else {
                 $details->{dateshift} = '';
             }
-            $details->{tinyurls} = $env{'form.colltinyurls'};
         } elsif (($reqtype eq 'textbook') || ($reqtype eq 'template')) {
             $details->{datemode} = 'delete';
             $details->{dateshift} = '';
-            $details->{tinyurls} = '';
         }
         if ($details->{dateshift} ne '') {
             $details->{dateshift} =~ s/[^\d\.]+//g;
@@ -5150,7 +5087,6 @@ sub process_textbook_request {
     } else {
         $details->{datemode} = '';
         $details->{dateshift} = '';
-        $details->{tinyurls} = '';
     }
     my $lonhost = $r->dir_config('lonHostID');
     $r->rflush();