CVS log for loncom/interface/lonrequestcourse.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  Backport 1.115 (modified), 1.116

- Accommodate argument changes in &selectbox() and &prettyinput() in lonmeta.pm
  rev. 1.255.

- For 2.11.4 (modified)
  Include changes in rev. 1.116

- processing_javascript() subroutine removed in rev. 1.115
- support domains with multiple library servers and in which requester selects
  'default' as new course's home server.

- For 2.11.4 (modified)
  Include changes in 1.115

- Reverse most of changes in rev. 1.84 and replace with progress indicator.

- Bug 6754
  - When storing mapping of Consumer system's courseID  to LON-CAPA's course
  "number" include LTI item id verified from signed payload.

- For 2.11.4 (modified)
  Include changes in 1.109

- For 2.11
  Backport 1.111, 1.112

- Bug 6754
  - Storing mapping of Consumer course identifier to LON-CAPA courseID
    honors rules for allowable course types, and also general Y/N option for
    any type.
  - When a course is created due to launch from LTI Consumer, course's
    environment.db contains internal.lti set to 1, and extended course type
    is identified as "lti".

- Bug 6959

- Bug 6914.
  Replace hostname with alias when creating absolute URLs, if alias in use.

- For 2.11.3 (modified)
  Include changes in rev. 1.110

- For 2.11
  Backport 1.110

- Some missing localizations call added.

- For 2.11.3 (modified)
  Include changes in 1.109

- For 2.11.2 modified
  Include changes in rev. 1.104 and 1.109:

- Bug 6400
  Options for transfer or creation of tiny URLs when cloning.

- For 2.11
  Backport 1.108

- Remove unwanted whitespace.

- For 2.11
  Backport 1.105, 1.107

- Devalidate cache for self-cataloging of courses based on institutional
  code for institution's nodes, if creating/modifying an "official" course.

- Trust settings for requesting course creation in another domain.
  - Eliminate %trustchecked (never populated).

- Call Apache::lonnet::hostname($lonhost) before accessing
  $Apache::lonnet::protocol{$lonhost) so %Apache::lonnet::protocol is populated.

- For 2.11
  Backport 1.104

- In request form when choice was to clone a textbook course or a template
  course, any date parameters will be deleted in the new course.

- Bug 6754 LON-CAPA as LTI Provider
  - Creation of new LON-CAPA user account available from an LTI Consumer.
  - Creation of new LON-CAPA course available from an LTI Consumer.
  - Self-enrollment in a LON-CAPA course available from an LTI Consumer.

- Typo in rev. 1.100

- Trust Settings
  - lonnet::trusted_domains() returns array or array refs, for passing to
    loncommon::select_dom_form() or lonnet::will_trust().

- Trust Settings
  Check if action is permissible based on trust settings for:
  catalog, domroles, enroll, reqcrs, msg, othcoau, or coaurem for current context.

- For 2.11
  - Backport 1.98

- Domain Configuration for LON-CAPA Directory searches for user information
  for users in a domain.
  - Can disable for all, or can disable only for other domains.
  - Default: enabled for all domains.

- For 2.11
  - Backport 1.97

- Bug 6808. New course container -- "Placement" for Placement Tests.

- Fix args in call to javascript:opencrsbrowser().

- Bug 6808. New course container -- "Placement" for Placement Tests.
  Work in progress.

- Display co-owners in own courses table in course request form.

- Display owner and co-owners in colleagues' courses table in course request
  form.

- Textbook/Template course requests
  - Additional items can be sent to localenroll::crsreq_updates():
    _LC_coursedescription, _LC_coursestartdate, _LC_courseenddate.
  - clone options: datemode and dateshift use different element names
    in "colleagues' courses" tab and "own courses" tab.

- Fix typo.

- Eliminate duplicate declaration.

- Textbook/Template course requests
  - Additional content option -- select from colleagues' courses for which
    requester has rights to clone.
  - Existing single-use code moved to new routines: clone_selection_table()
    and custom_formitems() to facilitate re-use.
  - Prompts to request author role or create another course, on page
    displayed after course request is processed can be suppressed, if
    custom output is planned from localenroll::crsreq_updates().
  - Additional items can be sent to localenroll::crsreq_updates():
   (_LC_coursedomainname, _LC_ownerfullname, _LC_owneremail).
  - Additional calls to lonnet::auto_crsreq_update() for new actions:
    (a) initializereview and (b) prereview used to support custom
    javascript in textbook request page, and custom onload action.

fixed bug 6782, and escaped most localized messages used in Javascript blocks to make sure bugs like that do not happen again

- Fix typo.

- Support checking of course cloning rights based on (a) domain defaults
  (where no course-specific rights set), or (b) course specific rights
  for official courses, based on institutional code category/ies set in
  courseprefs, e.g., department=phy etc.

- If cloning, include courseID of course being cloned in information sent
  sent to localenroll::validate_crsreq() and locallenroll::crsreq_updates()
  (key is _LC_clonefrom) in $custominfo and $incoming hashrefs respectively.

- Add missing subroutine: &textbook_request_disabled()
- In &get_breadcrumbs() sanity checking -- $states->{$action} needs to be
  a ref to an ARRAY.

- Course creation can take some time if a course is being cloned.
  - Display a message that processing is in progress, then flush the print
    buffer. Hide messge when page loading completes.

- Support display of queued "textbook" requests awaiting approval by DC.

- Add "publisher" field to display of available "textbooks" whicn may bea
  selected for cloning when requesting a textbook course.

- "Textbook" course requests can specify cloning from one of two types of
  prefabricated courses: either (a) "textbooks" or (b) "templates".

- Post-processing for course requests.
  - localenroll::crsreq_updates() can populate hash ref:
    $outgoing->{'createdactions'}->{'environment'} with a course's
    self-enrollment settings when processing course request.

- Eliminate javascript error when no textbooks have been assigned in the
  domain.

- Course requests for unofficial courses, textbook courses and communities
  can include validation.
  - lonrequestcourse.pm
    - New subroutine: pending_validation_form() generates web form used to
      proceed to validation (can be local script, or script on remote server)
    - Prepended new arg to args passed to: &print_request_outcome() and
      &process_request()  -- $lonhost (lonHostID of current server).
 - localenroll.pm
   - &validate_crsreq() accepts additional (optional) arg -- ref to hash of
     custominfo.
   - &crsreq_updates() supports additional action type ('prevalidate') which
     is used to generate form elements needed for validation of request.
 - lond
   - &validate_crsreq_handler() accepts additional -- $customdata
     which is a frozen hash of custominfo passed in from lonnet.pm
 - lonnet.pm
   - &auto_courserequest_validation() accepts additional arg -- ref to hash of
     custominfo (contains key => value for custm form elements retrieved from
     course request review page.

- Consistent naming for $context arg passed to loncoursequeuadmin::send_selfserve_notification()
  via &notification_information().
- Eliminate duplication of output to screen from two calls to &notification_information()
  (second to accommodate $postprocess) in case where request is queued for approval.

Consistent spelling (upper case): Authoring Space

- No domain selector shown if there are no other domains to choose from.

- Include course title in message sent to course requestor containing
  unique code.
- Change args passed to &notification_information() to include course domain
  as third arg. $dom is used to construct $cid argument when calling
  loncoursequeueadmin::send_selfserve_notification(), where appropriate.

- New routine in localenroll.pm -- &crsreq_updates() -- to support
  domain-specific operations during course request process.
- Tabbed interface used for textbook-type course requests, one tab
  for course creation, one for request logs.
- Column for unique codes included in user's request log display, if
  domain has enabled use of unique codes.
- Correction to LON-CAPA messaging of unique code -- recipient should
  be requestor.

- Simplified course request form in case where only request type available
  is "textbook".
  - Single page: title, clone choice, student access dates.
- Code used to process course requests moved out of &print_request_outcome to separate
  routine: &process_request to facilitate reuse
- Code used to suggest submission of request for author role moved to separate routine:
  &print_author_prompt to facilitate reuse.

- Domain configuration used to set generation of unique six character code
  as course identifier when processing course requests, can be set
  separately for different request types - official, unofficial, community
  or textbook.
- Where a unique code is set for a course store in nohist_courseids.db on
  domain's library server(s).

- Unique six character identifier for a course can be created automatically,
  when a course is created, if domain configuration set to include this for
  course requests.
  - Initial use case is for a separate portal (toke-based auth) where students
    enter the code to sign up for a specific "textbook" course.

- New course request type -- textbook.
  - Can assign rights to request this type of course.
  - "textbook" can have different uploaded content quota, default credits etc.
    from official or unofficial course types.
  - Domain Coordinators can specify subject, tile, authors(s) and upload an
    image of the textbook cover.
- Work-in-progress.

- For 2.10
 - Backport 1.67. (bug 6660).

Exclude HTML tags from translation phrases.
Update corresponding German translation file phrases and translations.

- With perl-5.8.8-40.el5_9, escaped double quotes became doubly escaped in
  javascript, resulting in a javascript error.

- Course credits for a particular institutional code can be provided as a
  third item returned by localenroll::validate_instcode()
- Course credits can be specified for an official course (or retrieved from
  localenroll::validate_instcode) or an unofficial course as part of a course
  request
- Credits earned for a course can also be different for a specific student
  (e.g., retrieved from institutional classlist data), or specified when
  CC adds a student to a course via the web GUI.

- Requests author roles by users who do not have them.
  - Move code from lonroles.pm to new routines in loncoursequeueadmin.pm
    is_active_author(), author_prompt(), reqauthor_check(), process_reqauthor()
    to facilitate re-use.
  - At conclusion of course/community request process, offer option to
    request an author role to users without one, who have to rights to
    request one.

- Add ability for users to request creation of an author role in their
  domain, if they do not already have an active author role.
  - Domain defaults can be assigned based on institutional status.
  - Defaults can be overridden for individual users by the DC.
  - Requests can either be processed automatically or queued for DC
    approval.
  - Notification message can be sent to DCs when queued for approval
  - Notification message sent to requester if approved/rejected.

- Bug 6287.
  Processing of requests for official courses queued pending validation
  by Autocreate.pl run by cron.
    - Send LON-CAPA message (with notification e-mail to permanentemail)
      to course requestor when course is created.

- Checking of right to create new user and of format rules for new username
  when processing personnel included in course request skipped for existing users.

- For official courses, where institutional code defined and auto-enroll enabled:
    - include textboxes for input of institutional section if no official sections known.
- A single help icon for multiple crosslisting rows.

- Authentication type and authentication arg (optional) need to be stored
  in course request for any users without existing accounts.
  Will use domain defaults if no usertype determined (i.e., no username
  format rules active).
  Otherwise will use values defined in localenroll::username_rules() for "official"
  users and internal auth with randomly generated password (e-mailed to new user)
  for "unofficial" users.

- Customization for GCI_3.
  - Suport for multiple Concept Inventories.

- Customization for GCI_3.
  - Use unique text in breadcrumb to facilitate "localization" to GCI context.

- Customization for GCI_3
  - Course timezone specified when creating a new Concept Test.

- Backport 1.59.

- Official courses without institutional code - review screen for DC consistent
  with stored data for autoadds and autodrops.

- Backport 1.58.

- Customization for GCI_3.
  - Separate initialization of course request page from handler into
    &generate_page() to allow calls this from londocs.pm and loncreateuser.pm
  - Construct breadcrumbs for case where user-defined Concept Test and
    roster upload occur during course creation.
  - rename action form element as reqaction (avoid JS conflicts with regular
    form action.
  - xhtml
  - hours, minutes and seconds on default access dates/times in course request
  - &done_display() to show management tools available, after course creation
    is complete.
  - consistent color scheme (norole) when user is selecting questions, or
    uploading classlist during course creation.
  - Roster upload togglable after concept test container created.

- Customization for GCI_3
  -  Backport 1.58.

- Server-side clean-up of LON-CAPA section names.

- Backport 1.57.

- Record autoadds and autodrops settings correctly.

- Backport 1.56.

- Bug 6338.
  - When DC displays details of queued course request, checking of cloning
  rights needs to be for course reqestor instead of current user (DC).

- Backport 1.55.

- bug 6338.

- Reverse changes in 1.52 for 2.9.X.
  ("Accessibility options" still included in 2.9).

- Bug 6332.

- bug 6288. Decrease likelihood of user error selecting course to clone.
  - "Select Course" link moved to left of Course ID text box.
  - Clicking inside Course ID text box launched pop-up window.

Removed leftovers of already removed alternative login mode (accessibility).

- Add escaped quotes to original phrase so translators will also escape them,
  thereby avoiding javascript errors when language in use is other than English.

- Wording change: Course/Community created -> Created

- Default for cloning radiobutton to "No".
- Fix args in call to &header() when displaying warning message when displaying
  existing request.
- Change args passed to &sorted_request_history()
  - replace third and fourth args with a single arg (ref to Hash of current filters (status, before, after, crstype).
- Check for form.queue (either approval or pending) to allow manual approval/rejection official courses pendng validation of instructor of record.

- A user can generate a filtered display of all course/community requests the user has made, including current status of each request.

- Include course type (Course or Community) as second arg in call to &generate_coursenum().

- Inserted texthash and &mt() for translation.
- Corrected pick_box-call.

- Customization for GCI_3
  - Backport 1.45.
  - Users creating Concept Tests can choose to clone a concept test for
    which they are an active CC.
  - Users can also choose to copy the course roster from the cloned course.
  - Three new subroutines:
     &show_cloneable() - returns 1 if user has CC role in existing tests.
     &select_oldtest() - select box containing courseIDs for existing tests.
     &roster_upload_form() - display of file upload of a CSV of students moved to its own subroutine to facilitate reuse.

- Bug 6050.
  - Y/N radio buttons for cloning in course request -> additional options in div
    block element displayed/hidden depending on radio button state.

- Customization for GCI_3
  - Automatically set course config to include suppress_tries in printouts for
    GCI Concept Tests.

- Code to update user's courserequests.db moved to &update_coursereq_status() in loncoursequeueadmin.pm
  to be more widely available.

- Customization for GCI_3
  - Let students know if there are missing items.

- Domain Coordinator Modify user screen.
  - Rights to request different course types in user's domain
    now shown if defaults apply to user.
  - &get_processtype moved from lonrequestcourse.pm loncoursequeueadmin.pm
    to be more widely available.
  - Additional arguments prepended to &get_processtype() to allow use
    where request rights are retrieved for a user different to the one
    requesting the information (i.e., a DC).

- Backport 1.42.

- Set start date for requestor's roles (excluding student) to
  1 second before last role refresh time, so role switcher will be functional.

- Customization for GCI_3.
  - New subroutine: &acquire_cc_role() to set requestor's role to CC in new course
    when request is processed.
  - Concept Test courses are cloned from Template course.

- Customization for GCI_3.
  - Custom instructions for creating a Concept Test
  - Cloning and additional personnel options excluded
  - &store_crsparms() - sets course level parameters: buttonshide, opendate,
      duedate, problemstatus, maxtries, discussend, discusshide.

- Accommodate Communities.

- Accommodate Communities.

- Additional optional arg for loncommon::select_dom_form()
  - can restrict available domains to those included in the array ref arg.
- Only display domains for which user can request courses in the domain select box
- Only included types of course a user can request in the Type select box
- Accommodate Communities
  - text changed depending on whether requests are possible for courses only, communitiesonly or both.
  - &loncoursequeueadmin::check_can_clone() - check user roles for active "co" role for a Community.

- Link to course request page if user has no active roles, and has rights to request creation of courses.
- Some wording changes to accommodate communities as well as courses.
- Additional argument for &lonnet::check_can_request() -
   hashref: $request_domains used to accumulate domains for each course
            type for which user has course request rights.
- New subroutine: &requestcourse_advice() in lonroles.pm

- Backport 1.37.

- Facilitate re-use:
  - move &check_can_request() from lonrequestcourse.pm to lonnet.pm
  - move &course_types() from lonrequestcourse.pm to loncommon.pm

- Customization for GCI.
- Initial Course Request page includes list of any existing Concept Test courses in gcitest domain in which user has active CC role with "Select" button to choose a role.

- Customiation for GCI
- 'unofficial' courses only
- logging unavailable
- course domain fixed as gcitest

- &Apache::lonnet::auto_validate_instcode() now returns an array containing:
  - the outcome ('valid' - or some other message) and
  - an (optional) brief description for the course retrieved from
     localenroll::validate_instcode() which likewise returns an array of 2 items.
- Used to set cdescr form element in the course request form for official courses when the instcode has been validated.

- If course is being created immediately, add CC role to assignment of new roles
  to requestor's %env, if no additional personnel were included in the request.
- Some localization of course types.

- Contextual help for Course Requests.

- Help item to explain privileges available to standard course roles.

- Wording differences where request is for a community not a course.

- Add javascript functions to check section names (in LON-CAPA) have a valif format (i.e., letters and/or numbers only) and are not the reserved word - 'none'.
- Used on enrollment page and personnel page.
- Exclude blank entries from section list on preview page (can originate from "None" option in official sections drop-down in personnel page).

- Side effect of changes to address bug 5595 was that checking of user creation privileges etc. no longer guaranteed to have occurred via mechanisms in lonpickuser.pm.
  - Check for user information for existing users, and if new user for rights to create one - &get_cancreate_status() and &check_newuser_rules() added.
  - Messages displayed above review table if requested user was excluded.
- Earlier change (rev 1.27) to multiple forms on main menu page requires different javascript functions to set form elements on this page compred with all other pages - &mainmenu_javascript() provides this.
  - onload call changed for main menu page accordingly.
  - $loaditems included in call to print_main_menu for view action as well as new action.

- Bug 5995.
 - Username field in "Additional" personnel accepts type-in input from user.
 - "Search for User" link provided for requestors who want to search.
 - "Check username" link provided for requestors who know the username and
   want to check it and/or complete the user information fields from stored data.
 - Javascript function - openuserbrowser() takes additional argument - caller - to trigger immediate username search if "check username" link used.
 - Javascript function - fix_domain() now fixes domain selector in opener
   only after a username and domain have been set from the pickuser pop-up.

- &update_requestors_roles()
   - New routine to immediately add roles to course requestor's session
     if request is processed immediately.
- Links to new course roles displayed following course creation.
- Change separators used in options in role selector from _ to /

- move breadcrumb generation to &get_breadcrumbs().
- breadcrumb links point to request main menu if course request submission was
  processed without error, or if course request was removed via cancel action.
- move validation of institutional code to &get_breadcrumbs() so trail is correct,
  if re-display of course code setting table is needed.
- validate institutional codes for crosslisted courses
- xhtml: use three separate forms on request main menu to satisfy valid tag nesting.
- Add row_headlines in pick_box tables and aggregate items on each page into a single
  pick_box table.
- Replace "Back" button on request outcome screen with link to "Make another request",
  (and if request is queued - link to "Modify this request".

- Domain Coordinators approving requests can view details of request in a pop-up window.

- courserequestqueue.db now stored in domainconfig user's directory.

- Institutional section settings and crosslistings correctly displayed in request review screen when modifying an existing request.
- Section choices and crosslistings can also now be modified on a pending request.

- Set $disposition for requests of process type 'validate'.
- Check for LC_adv override only if occurs if setting is not ''.

- Typo in call to &extract_instcode().
- Store crosslist section separately from crosslist institutional code, so
    form elements can be set when modifying a request which includes crosslistings.

- For users with type 'validate', use lonnet::auto_courserequest_validation()
instead of auto_validate_instcode() to determine if request can be processed immediately.
- Change response expected from &auto_validate_instcode() when course code is valid from 'ok' to 'valid' for consistency with localenroll.pm.

- Eliminate repeated line for HTTP header generation.
- coding style: unshift(), push()
- for an official course but with no institutional codes to pick from adjust pages reached by prev and next from courseinfo and access dates pages.

- Change mechanism for choosing domain to default to on course request main menu.
- Missing punctuation.
- Use approval instead of approve for name of option, for consistency with
  request processing.
- entries in reqcrsotherdom are in the form $dom:$value (where $value is approval, validate, autolimit etc.) not simply $dom.

- Consistent wording.

- lonrequestcourse.pm uses lonnet::auto_validate_instcode() to check if request should be
processed:
  - result (ultimately from localenroll.pm) will be one of: valid, pending, approval or
    error.

- Can modify pending requests.
- Can cancel pending requests.

Course Requests
- Client-side javascript validation to check a course description was provided.
- Server-side checking that requestor has rights to clone a course selected for cloning.

Course Requests
- Move &build_batchcreatehash() from lonrequestcourse.pm to loncoursequeueadmin.pm
- Move call to LONCAPA::batchcreatecourse into a separate routine: &course_creation()
  within loncoursequeueadmin.pm
- Code added for resolution of course requests subject to approval by DC.
   - either approve and create course, or reject.
   - formatting of LON-CAPA messages sent to notification list and requestor improved.
- Change in storage of status information for a request.
  - Status now stored in a separate key => value in courserequests.db file belonging to requestor
    - key is status:$cdom:$cnum
- User's display of pending requests now shows the required information.
(Select button to view/modify/cancel individual request currently inactive - work in progress).

- Changing names of hash keys used in storage of request data for consistency with nomeclature used in details hash in &batchcreatecourse::build_course().
- Adding option to select a course home server if there are multiple library servers in the course's domain.
- Process course sections, crosslisted courses and course personnel into data structures expected by &batchcreatecourse::build_course().
- Institutional status type where no assigned status exists is "default" not "other".

- placeholders for perldoc.

- Moving call to &print_request_status() inside &request_administration().
- Wording change in message displayed if there are no pending requests.

- Display user's pending and queued course requests,filtered by course type and course domain.
- Construct hashes of sections, crosslistings and personnel for storage in course request hash of a hash.
- If processing control is set to autolimit=N, accumulate numbers of prior course requests of each course type (where user still has active CC role) and compare witgh limit (N).

- %domconfig needed to retrieve list of users to be notified if course request requires approval.
- Pass ref to hash as additional arg to &get_processtype().

- Course Requests
lonrequestcourse.pm
  - &print_review() which displays details of a course request prior to submissi
on now includes a call to &Apache::lonnet::generate_coursenum() to retrieve a un
ique course number to be used for the requested course.
  - &print_request_outcome() determines how a request should be processed, based on course type, and domain setting for requestor's instiutional affiliations(s),  (overridden by user-specific settings), and performs the required actions.
  - &get_processtype() retrieves the setting: norequest, approval, validate, or autolimit=N (N is requests per user).
  - &check_autolimit() will check if requests per user limit reached.
  - Call to &Apache::lonnet::auto_courserequest_validation() to perform institutional check - response is either process or pending.
  - $disposition indicates how request should be handled
     - approval, rejected, process, or pending.
     - case: approval and pending - place in a queue (domain's courserequestqueue.db); approval means DC needs to approve; pending means institutional change ne
eded (e.g., assign owner as instructor of record)
     - case: process - create the course using &build_course() in batchcreatecourse.pm
     - case: rejected - course request not allowed
lonnet.pm
  - &store_coursereq() is used to store (versioned) course requests in a courserequests.db file which belongs to the requestor.  The unique key is the course number assigned to the (yet to be created) course.

Work in progress.

- Provide domain of requested course to routines used for pop-up "Pick User" window used to add course personnel to the request.

- CDATA in Javascript call for xhtml compliance
- Unbalanced <tr> tag in review table
- Display "None" for Sections and Crosslistings if course is "official" and auto-enrollment is active, but no sections/crosslistings were selected.

- Use code_order for display of institutional code in crosslistings
- Add column titles for institutional section and LON-CAPA section for summary of Sections and Crosslistings.

- Display details of course request prior to submission.

- Add breadcrumbs.

- Add infrastructure to support stepping backwards or forwards across multiple pages in the course request form.
- For official courses, if auto-enrollment available in course's domain:
   - Cross-listing of multiple course sections added to enrollment page
   - Auto-adds and Auto-drops can be enabled.
- Course personnel page uses pop-up window containing lonpickuser.pm to search for users.

Saving my work.

- Ability to make course requests.
- Saving my work.