--- loncom/interface/lonstatistics.pm 2010/09/11 19:08:19 1.148.2.4
+++ loncom/interface/lonstatistics.pm 2010/05/03 16:41:51 1.152
@@ -1,6 +1,6 @@
# The LearningOnline Network with CAPA
#
-# $Id: lonstatistics.pm,v 1.148.2.4 2010/09/11 19:08:19 raeburn Exp $
+# $Id: lonstatistics.pm,v 1.152 2010/05/03 16:41:51 www Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -405,10 +405,10 @@ sub StudentDataSelect {
$Str .= 'size="'.$numvisible.'" >'."\n";
#
# Deal with 'all'
- $Str .= ' <option value="all" ';
+ $Str .= ' <option value="all"';
foreach (@SelectedStudentData) {
if ($_ eq 'all') {
- $Str .= 'selected ';
+ $Str .= ' selected="selected"';
last;
}
}
@@ -416,10 +416,10 @@ sub StudentDataSelect {
#
# Loop through the student data fields
foreach my $item (@StudentDataOrder) {
- $Str .= ' <option value="'.$item.'" ';
+ $Str .= ' <option value="'.$item.'"';
foreach (@SelectedStudentData) {
if ($item eq $_ ) {
- $Str .= 'selected ';
+ $Str .= ' selected="selected"';
last;
}
}
@@ -506,9 +506,9 @@ sub map_select {
$form .= 'size="'.$numvisible.'" >'."\n";
#
# Put in option for 'all'
- $form .= ' <option value="all" ';
+ $form .= ' <option value="all"';
if ($selected_maps[0] eq 'all') {
- $form .= 'selected ';
+ $form .= ' selected="selected"';
}
$form .= ">all</option>\n";
#
@@ -521,10 +521,10 @@ sub map_select {
$navmap = shift(@sequences);
}
foreach my $seq (@sequences){
- $form .= ' <option value="'.$seq->symb.'" ';
+ $form .= ' <option value="'.$seq->symb.'"';
foreach (@selected_maps) {
if ($seq->symb eq $_) {
- $form .= 'selected ';
+ $form .= ' selected="selected"';
last;
}
}
@@ -556,10 +556,10 @@ sub SectionSelect {
#
# Loop through the sequences
foreach my $s (@Sections) {
- $Str .= ' <option value="'.$s.'" ';
+ $Str .= ' <option value="'.$s.'"';
foreach (&get_selected_sections()) {
if ($s eq $_) {
- $Str .= 'selected ';
+ $Str .= ' selected="selected"';
last;
}
}
@@ -591,10 +591,10 @@ sub GroupSelect {
#
# Loop through the groups
foreach my $s (@Groups) {
- $Str .= ' <option value="'.$s.'" ';
+ $Str .= ' <option value="'.$s.'"';
foreach my $group (&get_selected_groups()) {
if ($s eq $group) {
- $Str .= 'selected ';
+ $Str .= ' selected="selected"';
last;
}
}
@@ -749,7 +749,7 @@ sub CreateMainMenu {
{url => '/adm/statistics?reportSelected=problem_analysis',
permission => 'F',
- icon => 'edit-find.png',
+ icon => 'prob_ana.png',
linktext => ('Detailed Problem Analysis'),
linktitle => ('Detailed statistics and graphs of student performance on problems.')},
]},
@@ -766,19 +766,7 @@ sub CreateMainMenu {
icon => 'coprplot.png',
linktext => ('Correct Problems Plot'),
linktitle => ('Display a histogram of student performance in the course.')},
- ]});
- if (&Apache::loncommon::needs_gci_custom()) {
- push(@reports,
- {categorytitle => 'Reports',
- items => [
- {url => '/adm/statistics?reportSelected=student_submission_reports',
- permission => 'F',
- icon => 'edit-copy.png',
- linktext => ('Student Submission Reports'),
- linktitle => ('Prepare reports of student submissions.')},
- ]});
- } else {
- push(@reports,
+ ]},
{categorytitle => 'Reports',
items => [
{url => '/adm/statistics?reportSelected=student_submission_reports',
@@ -789,11 +777,10 @@ sub CreateMainMenu {
{url => '/adm/statistics?reportSelected=survey_reports',
permission => 'F',
- icon => 'docs.png',
+ icon => 'survey_rep.png',
linktext => ('Survey Reports'),
linktitle => ('Prepare reports on survey results.')},
]});
- }
return &Apache::lonhtmlcommon::generate_menu(@reports);
@@ -805,14 +792,6 @@ sub handler {
my $r=shift;
my $c = $r->connection();
#
- # Check for overloading
- my $loaderror=&Apache::lonnet::overloaderror($r);
- if ($loaderror) { return $loaderror; }
- $loaderror=
- &Apache::lonnet::overloaderror($r,
- $env{'course.'.$env{'request.course.id'}.'.home'});
- if ($loaderror) { return $loaderror; }
- #
# Check for access
if (! &Apache::lonnet::allowed('vgr',$env{'request.course.id'})) {
$env{'user.error.msg'}=
@@ -830,28 +809,6 @@ sub handler {
&Apache::loncommon::content_type($r,'text/html');
$r->send_http_header;
if ($r->header_only) { return OK; }
- my $gcicustom = &Apache::loncommon::needs_gci_custom();
- if ($gcicustom) {
- my $now = time;
- my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
- my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
- my $courseopt=&Apache::lonnet::get_courseresdata($cnum,$cdom);
- my $duedate = $courseopt->{$env{'request.course.id'}.'.0.duedate'};
- if ((!$duedate) || ($duedate > $now)) {
- $r->print(&Apache::loncommon::start_page("Course Statistics"));
- $r->print('<h3>'.&mt('Display of statistics').'</h3>');
- if ($duedate > $now) {
- $r->print('<p>'.&mt('Aggregate test performance data will be available after the Concept Test end date: [_1].',
- &Apache::lonlocal::locallocaltime($duedate)).'</p>');
- } else {
- $r->print('<p>'.
- &mt('Aggregate test performance data unavailable without definition of an end date for the Concept Test.').'</p>');
- }
- $r->print(&Apache::loncommon::end_page());
- return OK;
- }
- }
-
#
# Extract form elements from query string
&Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
@@ -916,7 +873,7 @@ ENDSTYLE
my $GoToPage = $env{'form.reportSelected'};
#
$r->print('<input type="hidden" name="reportSelected" value="'.
- $GoToPage.'">');
+ $GoToPage.'" />');
if($GoToPage eq 'activitylog') {
# &Apache::lonproblemstatistics::Activity();
} elsif($GoToPage eq 'problem_statistics') {
@@ -937,9 +894,9 @@ ENDSTYLE
&Apache::lonsubmissiontimeanalysis::BuildSubmissionTimePage($r,$c);
} elsif($GoToPage eq 'student_submission_reports') {
&Apache::lonhtmlcommon::add_breadcrumb
- ({href=>
- '/adm/statistics?reportselected=student_submission_reports',
- text=>'Student Submission Reports'});
+ ({href=>
+ '/adm/statistics?reportselected=student_submission_reports',
+ text=>'Student Submission Reports'});
&Apache::lonstudentsubmissions::BuildStudentSubmissionsPage($r,$c);
} elsif($GoToPage eq 'survey_reports') {
&Apache::lonhtmlcommon::add_breadcrumb
@@ -957,11 +914,7 @@ ENDSTYLE
&Apache::lonhtmlcommon::add_breadcrumb
({href=>'/adm/statistics?reportselected=student_assessment',
text=>'Chart'});
- if ($gcicustom) {
- $r->print(&mt('Only aggregate performance data are available for Concept Tests.'));
- } else {
- &Apache::lonstudentassessment::BuildStudentAssessmentPage($r,$c);
- }
+ &Apache::lonstudentassessment::BuildStudentAssessmentPage($r,$c);
} elsif($GoToPage eq 'grading_analysis') {
&Apache::lonhtmlcommon::add_breadcrumb
({href=>'/adm/statistics?reportselected=grading_anaylsis',