--- loncom/interface/lontrackstudent.pm	2006/01/16 17:34:15	1.17
+++ loncom/interface/lontrackstudent.pm	2007/02/13 01:44:02	1.23
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lontrackstudent.pm,v 1.17 2006/01/16 17:34:15 www Exp $
+# $Id: lontrackstudent.pm,v 1.23 2007/02/13 01:44:02 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -48,6 +48,8 @@ use Apache::lonmysql;
 use Apache::lonnet;
 use Apache::lonlocal;
 use Time::HiRes;
+use lib '/home/httpd/lib/perl/';
+use LONCAPA;
 
 my $num_records=500;
 
@@ -108,12 +110,21 @@ sub get_data {
     &Apache::lonhtmlcommon::Update_PrgWin
         ($r,$prog_state,&mt('Parsing results'));
     #
-    &output_results($r,$results_file,$navmap,$mode);
+    my $last = &output_results($r,$results_file,$navmap,$mode);
     my ($sname,$sdom) = ($mode=~/^student:(.*):(.*)$/);
-    $r->print(&Apache::loncommon::track_student_link(
-				  'View more activity by this student',
-				  $sname,$sdom,undef,
-				  ($env{'form.start'}+$num_records)));
+    
+    my ($text,$inc);
+    if ( $last > 0 && (($last+1) >= $env{'form.start'}+$num_records) ) {
+	$text = 'View more activity by this student';
+	$inc  = $num_records;
+	$r->print(&Apache::loncommon::track_student_link($text,$sname,$sdom,undef,
+							 ($env{'form.start'}+$inc)
+							 ));
+	$r->print('<br />');
+    }
+    $text = 'Resubmit last request to check for newer data';
+    $r->print(&Apache::loncommon::track_student_link($text,$sname,$sdom,undef,
+						     $env{'form.start'}));
 
     &Apache::lonhtmlcommon::Update_PrgWin($r,$prog_state,&mt('Finished!'));
     return;
@@ -183,7 +194,7 @@ sub get_max_time_in_db {
     my $timestr = '';
     while (my $line = <TIMEDATA>) {
         chomp($line);
-        $timestr = &Apache::lonnet::unescape($line);
+        $timestr = &unescape($line);
     }
     close(TIMEDATA);
     return &Apache::lonmysql::unsqltime($timestr);
@@ -237,7 +248,7 @@ sub output_results {
     if (! -s $results_file) {
         # results file is empty, just let them know there is no data
         $r->print('<h2>'.&mt('So far, no data has been returned for your request').'</h2>');
-        return;
+        return -1;
     }
     if (! open(ACTIVITYDATA,$results_file)) {
         $r->print('<h2>'.&mt('Unable to read results file.').'</h2>'.
@@ -246,7 +257,7 @@ sub output_results {
                       'You should contact your system administrator '.
                       'to resolve this issue.').
                   '</p>');
-        return;
+        return -2;
     }
     ##
     ##
@@ -278,7 +289,7 @@ sub output_results {
     while (my $line = <ACTIVITYDATA>) {
         # FIXME: does not pass symbs along :(
         chomp($line);
-        $line = &Apache::lonnet::unescape($line);
+        $line = &unescape($line);
         if (++$count % 50 == 0) {
             if ($count != 0) { 
                 $r->print('</table>'.$/);
@@ -293,7 +304,7 @@ sub output_results {
             ($symb,$timestamp,$action,$machine,$values) = split(',',$line,5);
         }
 	foreach ($symb,$timestamp,$student,$action,$machine) {
-	    $_=&Apache::lonnet::unescape($_);
+	    $_=&unescape($_);
 	}
         my ($title,$src);
         if ($symb =~ m:^/adm/:) {
@@ -305,10 +316,11 @@ sub output_results {
                 $title = $nav_res->compTitle();
                 $src   = $nav_res->src();
             } else {
-                if ($src =~ m|^/res|) {
-                    $title = $src;
-                } elsif ($values =~ /^\s*$/ && 
-                         (! defined($src) || $src =~ /^\s*$/)) {
+		$src = $symb;
+		if ($src !~ m{/adm}) {
+		    $title = &Apache::lonnet::gettitle($src);
+		} elsif ($values =~ /^\s*$/ && 
+		    (! defined($src) || $src =~ /^\s*$/)) {
                     next;
                 } elsif ($values =~ /^\s*$/) {
                     $values = $src;
@@ -368,7 +380,7 @@ sub output_results {
     }
     $r->print('</table>'.$/);### if (! $count % 50);
     close(ACTIVITYDATA);
-    return;
+    return $count;
 }
 
 ###################################################################
@@ -380,14 +392,17 @@ sub display_values {
 	my %values=map {split('=',$_,-1)} split(/\&/,$values);
 	foreach my $key (sort(keys(%values))) {
 	    $result.='<tr><td align="right">'.
-		&Apache::lonnet::unescape($key).
+		&unescape($key).
 		'</td><td>=</td><td align="left">'.
-		&Apache::lonnet::unescape($values{$key}).'</td></tr>';
+		&unescape($values{$key}).'</td></tr>';
 	}
 	$result.='</table>';
     } elsif ($action eq 'POST') {
-	my %values=
-	    map {split('=',&Apache::lonnet::unescape($_),-1)} split(/\&/,$values);
+	my %values;
+        foreach my $pair (split(/\&/,$values)) {
+            my ($key,$value) = split('=',&unescape($pair),-1);
+            $values{$key} = $value;
+        }
 	foreach my $key (sort(keys(%values))) {
 	    if ($key eq 'counter') { next; }
 	    $result.='<tr><td align="right">'.$key.'</td>'.
@@ -395,7 +410,7 @@ sub display_values {
 	}
 	$result.='</table>';
     } else {
-	$result=&Apache::lonnet::unescape($values)
+	$result=&unescape($values)
     }
     return $result;
 }
@@ -510,12 +525,8 @@ sub handler {
                                             bug=>'instructor interface'});
     #
     # Give the LON-CAPA page header
-    my $html=&Apache::lonxml::xmlbegin();
-    $r->print($html.'<head>'.&styles().'<title>'.
-              &mt('Student Activity').
-              "</title></head>\n".
-              &Apache::loncommon::bodytag('Student Activity').
-              &Apache::lonhtmlcommon::breadcrumbs(undef,'Student Activity'));
+    $r->print(&Apache::loncommon::start_page('Student Activity',&styles()).
+              &Apache::lonhtmlcommon::breadcrumbs('Student Activity'));
     $r->rflush();
     #
     # Begin form output
@@ -539,9 +550,10 @@ sub handler {
         # For now, just show all the data, in the future allow selection of
         # a student
         my ($sname,$sdom) = split(':',$env{'form.selected_student'});
-        if ($sname =~ /^\w*$/ && $sdom =~ /^\w*$/) {
+        if ($sname =~ /^$LONCAPA::username_re$/ 
+	    && $sdom =~ /^$LONCAPA::domain_re$/) {
             $r->print('<h2>'.
-                      &mt('Recent activity of [_1]@[_2]',$sname,$sdom).
+                      &mt('Recent activity of [_1]:[_2]',$sname,$sdom).
                       '</h2>');
             $r->print('<p>'.&mt(<<END).'</p>');
 Compiling student activity data can take a long time.
@@ -550,7 +562,7 @@ END
             &get_data($r,\%prog_state,$navmap,
                       'student:'.$env{'form.selected_student'});
         } else {
-            $r->print('<h2>'.&mt('Unable to process for [_1]@[_2]',
+            $r->print('<h2>'.&mt('Unable to process for [_1]:[_2]',
                                  $sname,$sdom).'</h2>');
         }
     } else {
@@ -562,7 +574,7 @@ END
     &Apache::lonhtmlcommon::Close_PrgWin($r,\%prog_state);
     #
     $r->print("</form>\n");
-    $r->print("</body>\n</html>\n");
+    $r->print(&Apache::loncommon::end_page());
     $r->rflush();
     #
     return OK;