--- loncom/interface/lonuserutils.pm 2023/10/06 02:27:26 1.184.4.10.2.5
+++ loncom/interface/lonuserutils.pm 2018/03/23 01:01:21 1.194
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Utility functions for managing LON-CAPA user accounts
#
-# $Id: lonuserutils.pm,v 1.184.4.10.2.5 2023/10/06 02:27:26 raeburn Exp $
+# $Id: lonuserutils.pm,v 1.194 2018/03/23 01:01:21 raeburn Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -438,7 +438,7 @@ sub javascript_validations {
} elsif ($context eq 'domain') {
$setsection_call = 'setCourse()';
$setsections_js = &dc_setcourse_js($param{'formname'},$mode,
- $context,$showcredits,$domain);
+ $context,$showcredits);
}
$finish = " var checkSec = $setsection_call\n".
" if (checkSec == 'ok') {\n".
@@ -510,7 +510,7 @@ END
";
} elsif ($mode eq 'modifycourse') {
$auth_checks .= "
- if ((current.argfield !== null) && (current.argfield !== undefined) && (current.argfield !== '') && (vf.elements[current.argfield].value == null || vf.elements[current.argfield].value == '')) {
+ if (vf.elements[current.argfield].value == null || vf.elements[current.argfield].value == '') {
";
}
if ( ($mode eq 'createcourse') || ($mode eq 'modifycourse') ) {
@@ -531,27 +531,22 @@ END
/* regexp here to check for non \d \. in credits */
END
} else {
- my ($numrules,$intargjs) =
- &Apache::loncommon::passwd_validation_js('vf.elements[current.argfield].value',$domain);
$auth_checks .= (<<END);
foundatype=1;
if (current.argfield == null || current.argfield == '') {
- // The login radiobutton checked does not have an associated textbox
- } else if (vf.elements[current.argfield].value == '') {
var alertmsg = '';
switch (current.radiovalue) {
case 'krb':
alertmsg = '$alert{'krb'}';
break;
- case 'int':
- alertmsg = '$alert{'ipass'}';
- break;
+ case 'loc':
case 'fsys':
alertmsg = '$alert{'ipass'}';
break;
- case 'loc':
+ case 'fsys':
alertmsg = '';
break;
+ case 'lti':
default:
alertmsg = '';
}
@@ -559,10 +554,6 @@ END
alert(alertmsg);
return;
}
- } else if (current.radiovalue == 'int') {
- if ($numrules > 0) {
-$intargjs
- }
}
END
}
@@ -651,7 +642,6 @@ END
$section_checks.$authheader;
return $result;
}
-
###############################################################
###############################################################
sub upload_manager_javascript_forward_associate {
@@ -909,6 +899,7 @@ sub print_upload_manager_footer {
my $krbform = &Apache::loncommon::authform_kerberos(%param);
my $intform = &Apache::loncommon::authform_internal(%param);
my $locform = &Apache::loncommon::authform_local(%param);
+ my $ltiform = &Apache::loncommon::authform_lti(%param);
my $date_table = &date_setting_table(undef,undef,$context,undef,
$formname,$permission,$crstype);
@@ -937,7 +928,7 @@ sub print_upload_manager_footer {
&Apache::loncommon::help_open_topic('Auth_Options').
"</p>\n";
}
- $Str .= &set_login($defdom,$krbform,$intform,$locform);
+ $Str .= &set_login($defdom,$krbform,$intform,$locform,$ltiform);
my ($home_server_pick,$numlib) =
&Apache::loncommon::home_server_form_item($defdom,'lcserver',
@@ -954,8 +945,14 @@ sub print_upload_manager_footer {
&Apache::lonhtmlcommon::row_closure();
}
+ my ($trusted,$untrusted);
+ if ($context eq 'course') {
+ ($trusted,$untrusted) = &Apache::lonnet::trusted_domains('enroll',$defdom);
+ } elsif ($context eq 'author') {
+ ($trusted,$untrusted) = &Apache::lonnet::trusted_domains('othcoau',$defdom);
+ }
$Str .= &Apache::lonhtmlcommon::row_title(&mt('Default domain'))
- .&Apache::loncommon::select_dom_form($defdom,'defaultdomain',undef,1)
+ .&Apache::loncommon::select_dom_form($defdom,'defaultdomain',undef,1,undef,$trusted,$untrusted)
.&Apache::lonhtmlcommon::row_closure();
$Str .= &Apache::lonhtmlcommon::row_title(&mt('Starting and Ending Dates'))
@@ -2298,6 +2295,7 @@ sub build_user_record {
sub courses_selector {
my ($cdom,$formname) = @_;
+ my %coursecodes = ();
my %codes = ();
my @codetitles = ();
my %cat_titles = ();
@@ -2310,15 +2308,14 @@ sub courses_selector {
my $jscript = '';
my $totcodes = 0;
- my $instcats = &Apache::lonnet::get_dom_instcats($cdom);
- if (ref($instcats) eq 'HASH') {
- if ((ref($instcats->{'codetitles'}) eq 'ARRAY') && (ref($instcats->{'codes'}) eq 'HASH') &&
- (ref($instcats->{'cat_titles'}) eq 'HASH') && (ref($instcats->{'cat_order'}) eq 'HASH')) {
- %codes = %{$instcats->{'codes'}};
- @codetitles = @{$instcats->{'codetitles'}};
- %cat_titles = %{$instcats->{'cat_titles'}};
- %cat_order = %{$instcats->{'cat_order'}};
- $totcodes = scalar(keys(%codes));
+ $totcodes =
+ &Apache::courseclassifier::retrieve_instcodes(\%coursecodes,
+ $cdom,$totcodes);
+ if ($totcodes > 0) {
+ $format_reply =
+ &Apache::lonnet::auto_instcode_format($caller,$cdom,\%coursecodes,
+ \%codes,\@codetitles,\%cat_titles,\%cat_order);
+ if ($format_reply eq 'ok') {
my $numtypes = @codetitles;
&Apache::courseclassifier::build_code_selections(\%codes,\@codetitles,\%cat_titles,\%cat_order,\%idlist,\%idnums,\%idlist_titles);
my ($scripttext,$longtitles) = &Apache::courseclassifier::javascript_definitions(\@codetitles,\%idlist,\%idlist_titles,\%idnums,\%cat_titles);
@@ -3532,8 +3529,6 @@ END
setSections(formname,'$crstype');
if (seccheck == 'ok') {
opener.document.$callingform.newsecs.value = formname.sections.value;
- } else {
- return;
}
END
} else {
@@ -4118,7 +4113,7 @@ sub print_first_users_upload_form {
.&Apache::lonhtmlcommon::end_pick_box();
$str .= '<p>'
- .'<input type="button" name="fileupload" value="'.&mt('Next').'"'
+ .'<input type="submit" name="fileupload" value="'.&mt('Next').'"'
.' onclick="javascript:checkUpload(this.form);" />'
.'</p>';
@@ -4159,7 +4154,7 @@ sub upfile_drop_add {
$fieldstype{$field.'_choice'} = 'scalar';
}
&Apache::loncommon::store_course_settings('enrollment_upload',\%fieldstype);
- my ($cid,$crstype,$setting,$crsdom,$crsnum,$oldcrsuserdoms);
+ my ($cid,$crstype,$setting,$crsdom);
if ($context eq 'domain') {
$setting = $env{'form.roleaction'};
}
@@ -4167,18 +4162,11 @@ sub upfile_drop_add {
$cid = $env{'request.course.id'};
$crstype = &Apache::loncommon::course_type();
$crsdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
- $crsnum = $env{'course.'.$env{'request.course.id'}.'.num'};
} elsif ($setting eq 'course') {
if (&Apache::lonnet::is_course($env{'form.dcdomain'},$env{'form.dccourse'})) {
$cid = $env{'form.dcdomain'}.'_'.$env{'form.dccourse'};
$crstype = &Apache::loncommon::course_type($cid);
$crsdom = $env{'form.dcdomain'};
- $crsnum = $env{'form.dccourse'};
- if (exists($env{'course.'.$cid.'.internal.userdomains'})) {
- $oldcrsuserdoms = 1;
- }
- my %coursedesc = &Apache::lonnet::coursedescription($cid,{ one_time => 1 });
- $env{'course.'.$cid.'.internal.userdomains'} = $coursedesc{'internal.userdomains'};
}
}
my ($startdate,$enddate) = &get_dates_from_form();
@@ -4189,7 +4177,47 @@ sub upfile_drop_add {
my $defdom=$env{'request.role.domain'};
my $domain;
if ($env{'form.defaultdomain'} ne '') {
- $domain = $env{'form.defaultdomain'};
+ if (($context eq 'course') || ($setting eq 'course')) {
+ if ($env{'form.defaultdomain'} eq $crsdom) {
+ $domain = $env{'form.defaultdomain'};
+ } else {
+ if (&Apache::lonnet::will_trust('enroll',$crsdom,$env{'form.defaultdomain'})) {
+ $domain = $env{'form.defaultdomain'};
+ } else {
+ $r->print('<span class="LC_error">'.&mt('Error').': '.
+ &mt('Enrollment of users not permitted for specified default domain: [_1].',
+ &Apache::lonnet::domain($env{'form.defaultdomain'},'description')).'</span>');
+ return 'untrusted';
+ }
+ }
+ } elsif ($context eq 'author') {
+ if ($env{'form.defaultdomain'} eq $defdom) {
+ $domain = $env{'form.defaultdomain'};
+ } else {
+ if ((&Apache::lonnet::will_trust('othcoau',$defdom,$env{'form.defaultdomain'})) &&
+ (&Apache::lonnet::will_trust('coaurem',$env{'form.defaultdomain'},$defdom))) {
+ $domain = $env{'form.defaultdomain'};
+ } else {
+ $r->print('<span class="LC_error">'.&mt('Error').': '.
+ &mt('Addition of users not permitted for specified default domain: [_1].',
+ &Apache::lonnet::domain($env{'form.defaultdomain'},'description')).'</span>');
+ return 'untrusted';
+ }
+ }
+ } elsif (($context eq 'domain') && ($setting eq 'domain')) {
+ if ($env{'form.defaultdomain'} eq $defdom) {
+ $domain = $env{'form.defaultdomain'};
+ } else {
+ if (&Apache::lonnet::will_trust('domroles',$defdom,$env{'form.defaultdomain'})) {
+ $domain = $env{'form.defaultdomain'};
+ } else {
+ $r->print('<span class="LC_error">'.&mt('Error').': '.
+ &mt('Addition of users not permitted for specified default domain: [_1].',
+ &Apache::lonnet::domain($env{'form.defaultdomain'},'description')).'</span>');
+ return 'untrusted';
+ }
+ }
+ }
} else {
$domain = $defdom;
}
@@ -4201,7 +4229,6 @@ sub upfile_drop_add {
if (! exists($home_servers{$desiredhost})) {
$r->print('<p class="LC_error">'.&mt('Error').': '.
&mt('Invalid home server specified').'</p>');
- $r->print(&Apache::loncommon::end_page());
return 'invalidhome';
}
}
@@ -4212,7 +4239,6 @@ sub upfile_drop_add {
}
my $amode = '';
my $genpwd = '';
- my @genpwdfail;
if ($env{'form.login'} eq 'krb') {
$amode='krb';
$amode.=$env{'form.krbver'};
@@ -4221,14 +4247,14 @@ sub upfile_drop_add {
$amode='internal';
if ((defined($env{'form.intarg'})) && ($env{'form.intarg'})) {
$genpwd=$env{'form.intarg'};
- @genpwdfail =
- &Apache::loncommon::check_passwd_rules($domain,$genpwd);
}
} elsif ($env{'form.login'} eq 'loc') {
$amode='localauth';
if ((defined($env{'form.locarg'})) && ($env{'form.locarg'})) {
$genpwd=$env{'form.locarg'};
}
+ } elsif ($env{'form.login'} eq 'lti') {
+ $amode='lti';
}
if ($amode =~ /^krb/) {
if (! defined($genpwd) || $genpwd eq '') {
@@ -4301,6 +4327,7 @@ sub upfile_drop_add {
\@statuses,\@poss_roles);
&gather_userinfo($context,'view',\%userlist,$indexhash,\%info,
\%cstr_roles,$permission);
+
}
}
}
@@ -4378,9 +4405,9 @@ sub upfile_drop_add {
my $newuserdom = $env{'request.role.domain'};
map { $cancreate{$_} = &can_create_user($newuserdom,$context,$_); } keys(%longtypes);
# Get new users list
- my (%existinguser,%userinfo,%disallow,%rulematch,%inst_results,%alerts,%checkuname,
- %showpasswdrules,$haspasswdmap);
+ my (%existinguser,%userinfo,%disallow,%rulematch,%inst_results,%alerts,%checkuname);
my $counter = -1;
+ my (%willtrust,%trustchecked);
foreach my $line (@userdata) {
$counter ++;
my @secs;
@@ -4428,6 +4455,28 @@ sub upfile_drop_add {
'"<b>'.$entries{$fields{'domain'}}.'</b>"',
$fname,$mname,$lname,$gen);
next;
+ } elsif ($entries{$fields{'domain'}} ne $domain) {
+ my $possdom = $entries{$fields{'domain'}};
+ if ($context eq 'course' || $setting eq 'course') {
+ unless ($trustchecked{$possdom}) {
+ $willtrust{$possdom} = &Apache::lonnet::will_trust('enroll',$domain,$possdom);
+ $trustchecked{$possdom} = 1;
+ }
+ } elsif ($context eq 'author') {
+ unless ($trustchecked{$possdom}) {
+ $willtrust{$possdom} = &Apache::lonnet::will_trust('othcoau',$domain,$possdom);
+ }
+ if ($willtrust{$possdom}) {
+ $willtrust{$possdom} = &Apache::lonnet::will_trust('coaurem',$possdom,$domain);
+ }
+ }
+ unless ($willtrust{$possdom}) {
+ $disallow{$counter} =
+ &mt('Unacceptable domain [_1] for user [_2] [_3] [_4] [_5]',
+ '"<b>'.$possdom.'</b>"',
+ $fname,$mname,$lname,$gen);
+ next;
+ }
}
my $username = $entries{$fields{'username'}};
my $userdomain = $entries{$fields{'domain'}};
@@ -4507,44 +4556,12 @@ sub upfile_drop_add {
}
}
# determine user password
- my $password;
- my $passwdfromfile;
+ my $password = $genpwd;
if (defined($fields{'ipwd'})) {
if ($entries{$fields{'ipwd'}}) {
$password=$entries{$fields{'ipwd'}};
- $passwdfromfile = 1;
- if ($env{'form.login'} eq 'int') {
- my $uhome=&Apache::lonnet::homeserver($username,$userdomain);
- if (($uhome eq 'no_host') || ($changeauth)) {
- my @brokepwdrules =
- &Apache::loncommon::check_passwd_rules($domain,$password);
- if (@brokepwdrules) {
- $disallow{$counter} = &mt('[_1]: Password included in file for this user did not meet requirements.',
- '<b>'.$username.'</b>');
- map { $showpasswdrules{$_} = 1; } @brokepwdrules;
- next;
- }
- }
- }
}
}
- unless ($passwdfromfile) {
- if ($env{'form.login'} eq 'int') {
- if (@genpwdfail) {
- my $uhome=&Apache::lonnet::homeserver($username,$userdomain);
- if (($uhome eq 'no_host') || ($changeauth)) {
- $disallow{$counter} = &mt('[_1]: No specific password in file for this user; default password did not meet requirements',
- '<b>'.$username.'</b>');
- unless ($haspasswdmap) {
- map { $showpasswdrules{$_} = 1; } @genpwdfail;
- $haspasswdmap = 1;
- }
- }
- next;
- }
- }
- $password = $genpwd;
- }
# determine user role
my $role = '';
if (defined($fields{'role'})) {
@@ -4612,7 +4629,7 @@ sub upfile_drop_add {
&mt('The user does not already exist, and you may not create a new user in a different domain.');
next;
} else {
- unless ($password || $env{'form.login'} eq 'loc') {
+ unless (($password ne '') || ($env{'form.login'} eq 'loc') || ($env{'form.login'} eq 'lti')) {
$disallow{$counter} =
&mt('[_1]: This is a new user but no default password was provided, and the authentication type requires one.',
'<b>'.$username.'</b>');
@@ -4815,16 +4832,6 @@ sub upfile_drop_add {
my (%userres,%authres,%roleres,%idres);
my $singlesec = '';
if ($role eq 'st') {
- if (($context eq 'domain') && ($changeauth eq 'Yes') && (!$newuser)) {
- if ((&Apache::lonnet::allowed('mau',$userdomain)) &&
- (&Apache::lonnet::homeserver($username,$userdomain) ne 'no_host')) {
- if ((($amode =~ /^krb4|krb5|internal$/) && $password ne '') ||
- ($amode eq 'localauth')) {
- $authresult =
- &Apache::lonnet::modifyuserauth($userdomain,$username,$amode,$password);
- }
- }
- }
my $sec;
if (ref($userinfo{$i}{'sections'}) eq 'ARRAY') {
if (@secs > 0) {
@@ -4866,16 +4873,16 @@ sub upfile_drop_add {
}
}
}
- }
- if (!$multiple) {
- ($userresult,$authresult,$roleresult,$idresult) =
- &modifyuserrole($context,$setting,
- $changeauth,$cid,$userdomain,$username,
- $id,$amode,$password,$fname,
- $mname,$lname,$gen,$singlesec,
- $env{'form.forceid'},$desiredhost,
- $email,$role,$enddate,$startdate,
- $checkid,$inststatus);
+ if (!$multiple) {
+ ($userresult,$authresult,$roleresult,$idresult) =
+ &modifyuserrole($context,$setting,
+ $changeauth,$cid,$userdomain,$username,
+ $id,$amode,$password,$fname,
+ $mname,$lname,$gen,$singlesec,
+ $env{'form.forceid'},$desiredhost,
+ $email,$role,$enddate,$startdate,
+ $checkid,$inststatus);
+ }
}
}
if ($multiple) {
@@ -4897,13 +4904,6 @@ sub upfile_drop_add {
} # end of loop
$r->print('</ul>');
&Apache::lonhtmlcommon::Close_PrgWin($r,\%prog_state);
- if (($context eq 'domain') && ($setting eq 'course')) {
- unless ($oldcrsuserdoms) {
- if (exists($env{'course.'.$cid.'.internal.userdomains'})) {
- delete($env{'course.'.$cid.'.internal.userdomains'});
- }
- }
- }
}
# Flush the course logs so reverse user roles immediately updated
$r->register_cleanup(\&Apache::lonnet::flushcourselogs);
@@ -4923,7 +4923,6 @@ sub upfile_drop_add {
$counts{'auth'})."</p>\n");
}
$r->print(&print_namespacing_alerts($domain,\%alerts,\%curr_rules));
- $r->print(&passwdrule_alerts($domain,\%showpasswdrules));
#####################################
# Display list of students to drop #
#####################################
@@ -4993,42 +4992,6 @@ sub print_namespacing_alerts {
}
}
-sub passwdrule_alerts {
- my ($domain,$passwdrules) = @_;
- my $warning;
- if (ref($passwdrules) eq 'HASH') {
- my %showrules = %{$passwdrules};
- if (keys(%showrules)) {
- my %passwdconf = &Apache::lonnet::get_passwdconf($domain);
- $warning = '<b>'.&mt('Password requirement(s) unmet for one or more users:').'</b><ul>';
- if ($showrules{'min'}) {
- my $min = $passwdconf{'min'};
- if ($min eq '') {
- $min = $Apache::lonnet::passwdmin;
- }
- $warning .= '<li>'.&mt('minimum [quant,_1,character]',$min).'</li>';
- }
- if ($showrules{'max'}) {
- $warning .= '<li>'.&mt('maximum [quant,_1,character]',$passwdconf{'max'}).'</li>';
- }
- if ($showrules{'uc'}) {
- $warning .= '<li>'.&mt('contain at least one upper case letter').'</li>';
- }
- if ($showrules{'lc'}) {
- $warning .= '<li>'.&mt('contain at least one lower case letter').'</li>';
- }
- if ($showrules{'num'}) {
- $warning .= '<li>'.&mt('contain at least one number').'</li>';
- }
- if ($showrules{'spec'}) {
- $warning .= '<li>'.&mt('contain at least one non-alphanumeric').'</li>';
- }
- $warning .= '</ul>';
- }
- }
- return $warning;
-}
-
sub user_change_result {
my ($r,$userresult,$authresult,$roleresult,$idresult,$counts,$flushc,
$username,$userdomain,$userchg) = @_;
@@ -5532,7 +5495,7 @@ END
}
sub set_login {
- my ($dom,$authformkrb,$authformint,$authformloc) = @_;
+ my ($dom,$authformkrb,$authformint,$authformloc,$authformlti) = @_;
my %domconfig = &Apache::lonnet::get_dom('configuration',['usercreation'],$dom);
my $response;
my ($authnum,%can_assign) =
@@ -5554,6 +5517,11 @@ sub set_login {
'<td>'.$authformloc.'</td>'.
&Apache::loncommon::end_data_table_row()."\n";
}
+ if ($can_assign{'lti'}) {
+ $response .= &Apache::loncommon::start_data_table_row().
+ '<td>'.$authformlti.'</td>'.
+ &Apache::loncommon::end_data_table_row()."\n";
+ }
$response .= &Apache::loncommon::end_data_table();
}
return $response;
@@ -5898,70 +5866,6 @@ sub can_modify_userinfo {
return %canmodify;
}
-sub can_change_internalpass {
- my ($uname,$udom,$crstype,$permission) = @_;
- my $canchange;
- if (&Apache::lonnet::allowed('mau',$udom)) {
- $canchange = 1;
- } elsif ((ref($permission) eq 'HASH') && ($permission->{'mip'}) &&
- ($udom eq $env{'request.role.domain'})) {
- unless ($env{'course.'.$env{'request.course.id'}.'.internal.nopasswdchg'}) {
- my ($cnum,$cdom) = &get_course_identity();
- if ((&Apache::lonnet::is_course_owner($cdom,$cnum)) && ($udom eq $env{'user.domain'})) {
- my @userstatuses = ('default');
- my %userenv = &Apache::lonnet::userenvironment($udom,$uname,'inststatus');
- if ($userenv{'inststatus'} ne '') {
- @userstatuses = split(/:/,$userenv{'inststatus'});
- }
- my $noupdate = 1;
- my %passwdconf = &Apache::lonnet::get_passwdconf($cdom);
- if (ref($passwdconf{'crsownerchg'}) eq 'HASH') {
- if (ref($passwdconf{'crsownerchg'}{'for'}) eq 'ARRAY') {
- foreach my $status (@userstatuses) {
- if (grep(/^\Q$status\E$/,@{$passwdconf{'crsownerchg'}{'for'}})) {
- undef($noupdate);
- last;
- }
- }
- }
- }
- if ($noupdate) {
- return;
- }
- my %owned = &Apache::lonnet::courseiddump($cdom,'.',1,'.',
- $env{'user.name'}.':'.$env{'user.domain'},
- undef,undef,undef,'.');
- my %roleshash = &Apache::lonnet::get_my_roles($uname,$udom,'userroles',
- ['active','future']);
- foreach my $key (keys(%roleshash)) {
- my ($name,$domain,$role) = split(/:/,$key);
- if ($role eq 'st') {
- next if (($name eq $cnum) && ($domain eq $cdom));
- if ($owned{$domain.'_'.$name}) {
- if (ref($owned{$domain.'_'.$name}) eq 'HASH') {
- if ($owned{$domain.'_'.$name}{'nopasswdchg'}) {
- $noupdate = 1;
- last;
- }
- }
- } else {
- $noupdate = 1;
- last;
- }
- } else {
- $noupdate = 1;
- last;
- }
- }
- unless ($noupdate) {
- $canchange = 1;
- }
- }
- }
- }
- return $canchange;
-}
-
sub check_usertype {
my ($dom,$uname,$rules,$curr_rules,$got_rules) = @_;
my $usertype;
@@ -6082,21 +5986,12 @@ sub get_permission {
$permission{'selfenrolladmin'} = 1;
}
}
- unless ($permission{'selfenrolladmin'}) {
- $permission{'selfenrollview'} = 1;
- }
}
if ($env{'request.course.id'}) {
- my $user;
- if (($env{'user.name'} ne '') && ($env{'user.domain'} ne '')) {
- $user = $env{'user.name'}.':'.$env{'user.domain'};
- }
+ my $user = $env{'user.name'}.':'.$env{'user.domain'};
if (($user ne '') && ($env{'course.'.$env{'request.course.id'}.'.internal.courseowner'} eq
$user)) {
$permission{'owner'} = 1;
- if (&Apache::lonnet::allowed('mip',$env{'request.course.id'})) {
- $permission{'mip'} = 1;
- }
} elsif (($user ne '') && ($env{'course.'.$env{'request.course.id'}.'.internal.co-owners'} ne '')) {
if (grep(/^\Q$user\E$/,split(/,/,$env{'course.'.$env{'request.course.id'}.'.internal.co-owners'}))) {
$permission{'co-owner'} = 1;
@@ -6133,9 +6028,8 @@ sub get_permission {
}
}
my $allowed = 0;
- foreach my $key (keys(%permission)) {
- next if (($key eq 'owner') || ($key eq 'co-owner'));
- if ($permission{$key}) { $allowed=1; last; }
+ foreach my $perm (values(%permission)) {
+ if ($perm) { $allowed=1; last; }
}
return (\%permission,$allowed);
}
@@ -6184,7 +6078,7 @@ sub get_course_identity {
}
sub dc_setcourse_js {
- my ($formname,$mode,$context,$showcredits,$domain) = @_;
+ my ($formname,$mode,$context,$showcredits) = @_;
my ($dc_setcourse_code,$authen_check);
my $cctext = &Apache::lonnet::plaintext('cc');
my $cotext = &Apache::lonnet::plaintext('co');
@@ -6193,7 +6087,7 @@ sub dc_setcourse_js {
if ($mode eq 'upload') {
$role = 'courserole';
} else {
- $authen_check = &verify_authen($formname,$context,$domain);
+ $authen_check = &verify_authen($formname,$context);
}
$dc_setcourse_code = (<<"SCRIPTTOP");
$authen_check
@@ -6337,14 +6231,12 @@ ENDSCRIPT
}
sub verify_authen {
- my ($formname,$context,$domain) = @_;
+ my ($formname,$context) = @_;
my %alerts = &authcheck_alerts();
my $finish = "return 'ok';";
if ($context eq 'author') {
$finish = "document.$formname.submit();";
}
- my ($numrules,$intargjs) =
- &Apache::loncommon::passwd_validation_js('argpicked',$domain);
my $outcome = <<"ENDSCRIPT";
function auth_check() {
@@ -6378,7 +6270,6 @@ function auth_check() {
break;
case 'int':
alertmsg = '$alerts{'ipass'}';
- break;
case 'fsys':
alertmsg = '$alerts{'ipass'}';
break;
@@ -6392,11 +6283,6 @@ function auth_check() {
alert(alertmsg);
return;
}
- } else if (logintype == 'int') {
- var numrules = $numrules;
- if (numrules > 0) {
-$intargjs
- }
}
$finish
}
@@ -6548,7 +6434,7 @@ sub selfenrollment_administration {
}
}
if ($settings{'internal.selfenrollmgrdc'} ne '') {
- @in_domain = split(/,/,$settings{'internal.selfenrollmgrdc'});
+ my @in_domain = split(/,/,$settings{'internal.selfenrollmgrdc'});
my @diffs = &Apache::loncommon::compare_arrays(\@in_domain,$possconfigs);
unless (@diffs) {
return (\@in_course,\@in_domain);