--- loncom/interface/lonuserutils.pm 2008/04/30 23:16:19 1.52 +++ loncom/interface/lonuserutils.pm 2008/05/12 17:52:08 1.54 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Utility functions for managing LON-CAPA user accounts # -# $Id: lonuserutils.pm,v 1.52 2008/04/30 23:16:19 raeburn Exp $ +# $Id: lonuserutils.pm,v 1.54 2008/05/12 17:52:08 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -925,8 +925,15 @@ sub setup_date_selectors { sub get_dates_from_form { - my $startdate = &Apache::lonhtmlcommon::get_date_from_form('startdate'); - my $enddate = &Apache::lonhtmlcommon::get_date_from_form('enddate'); + my ($startname,$endname) = @_; + if ($startname eq '') { + $startname = 'startdate'; + } + if ($endname eq '') { + $endname = 'enddate'; + } + my $startdate = &Apache::lonhtmlcommon::get_date_from_form($startname); + my $enddate = &Apache::lonhtmlcommon::get_date_from_form($endname); if ($env{'form.no_end_date'}) { $enddate = 0; } @@ -1252,34 +1259,11 @@ sub print_userlist { if ($env{'form.showrole'} eq 'Any') { $roleselected = ' selected="selected" '; } - my ($role_select,$cnum,$cdom); - if ($context eq 'domain') { - $role_select = &domain_roles_select(); - $r->print('<label>'.&mt('Role Type: [_1]',$role_select).'</label>'); - } else { - $role_select = '<select name="showrole">'."\n". - '<option value="Any" '.$roleselected.'>'. - &mt('Any role').'</option>'; - my @poss_roles = &curr_role_permissions($context); - foreach my $role (@poss_roles) { - $roleselected = ''; - if ($role eq $env{'form.showrole'}) { - $roleselected = ' selected="selected" '; - } - my $plrole; - if ($role eq 'cr') { - $plrole = &mt('Custom role'); - } else { - $plrole=&Apache::lonnet::plaintext($role); - } - $role_select .= '<option value="'.$role.'"'.$roleselected.'>'.$plrole.'</option>'; - } - $role_select .= '</select>'; - $r->print('<label>'.&mt('Role: [_1]',$role_select).'</label>'); - if ($context eq 'course') { - ($cnum,$cdom) = &get_course_identity(); - $r->print(§ion_group_filter($cnum,$cdom)); - } + my ($cnum,$cdom); + $r->print(&role_filter($context)); + if ($context eq 'course') { + ($cnum,$cdom) = &get_course_identity(); + $r->print(§ion_group_filter($cnum,$cdom)); } if (!(($context eq 'domain') && ($env{'form.roletype'} eq 'course'))) { $r->print(' '.&list_submit_button(&mt('Update Display')). @@ -1451,6 +1435,41 @@ sub print_userlist { $env{'form.phase'}.'" /></form>'); } +sub role_filter { + my ($context) = @_; + my $output; + my $roleselected = ''; + if ($env{'form.showrole'} eq 'Any') { + $roleselected = ' selected="selected" '; + } + my ($role_select); + if ($context eq 'domain') { + $role_select = &domain_roles_select(); + $output = '<label>'.&mt('Role Type: [_1]',$role_select).'</label>'; + } else { + $role_select = '<select name="showrole">'."\n". + '<option value="Any" '.$roleselected.'>'. + &mt('Any role').'</option>'; + my @poss_roles = &curr_role_permissions($context); + foreach my $role (@poss_roles) { + $roleselected = ''; + if ($role eq $env{'form.showrole'}) { + $roleselected = ' selected="selected" '; + } + my $plrole; + if ($role eq 'cr') { + $plrole = &mt('Custom role'); + } else { + $plrole=&Apache::lonnet::plaintext($role); + } + $role_select .= '<option value="'.$role.'"'.$roleselected.'>'.$plrole.'</option>'; + } + $role_select .= '</select>'; + $output = '<label>'.&mt('Role: [_1]',$role_select).'</label>'; + } + return $output; +} + sub section_group_filter { my ($cnum,$cdom) = @_; my @filters;