--- loncom/interface/lonwhatsnew.pm	2015/03/12 03:28:51	1.105.2.10
+++ loncom/interface/lonwhatsnew.pm	2013/10/21 22:34:33	1.114
@@ -1,5 +1,5 @@
 #
-# $Id: lonwhatsnew.pm,v 1.105.2.10 2015/03/12 03:28:51 raeburn Exp $
+# $Id: lonwhatsnew.pm,v 1.114 2013/10/21 22:34:33 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -600,7 +600,7 @@ sub display_actions_box {
     }
     my $classlist;
     if ($show{'oldroles'} || $show{'newroles'} || $show{'crslogin'}) {
-        $classlist = &Apache::loncoursedata::get_classlist();
+        $classlist = &Apache::loncoursedata::get_classlist(); 
     }
     if ($show{'coursenormalmail'}) {
         $msgcount = &getnormalmail(\@newmsgs);
@@ -799,7 +799,7 @@ function toggle_countunread(choice) {
              .'<br />'
              .&mt("This can increase the time taken to gather data for the [_1]What's New Page[_2] by a few seconds.",'<i>','</i>')
              .'&nbsp;&nbsp;'
-             .&mt('Currently set to [_1].','<b>'.$current.'</b>')
+             .&mt('Currently set to [_1].','<b>'.$current.'</b>.')
     );
     $r->print('<br /><br />
 <form method="post" name="discussionswitch" action="/adm/whatsnew">
@@ -1164,7 +1164,7 @@ sub get_curr_thresholds {
     my $thresholdcount = 0;
     my ($tmp) = %thresholdsettings;
     unless ($tmp =~ /^(con_lost|error|no_such_host)/i) {
-        foreach my $item (keys(%{$threshold})) { 
+        foreach my $item (keys %{$threshold}) { 
             if (exists($thresholdsettings{$cid.':threshold_'.$item})) {
                 $$threshold{$item} = 
                              $thresholdsettings{$cid.':threshold_'.$item};
@@ -1179,7 +1179,7 @@ sub get_curr_thresholds {
                                               $cdom,$crs,'internal.threshold');
     my ($temp) = %coursesettings;
     unless ($temp =~ /^(con_lost|error|no_such_host)/i) {  
-        foreach my $item (keys(%{$threshold})) {
+        foreach my $item (keys %{$threshold}) {
             unless (exists($thresholdsettings{$cid.':threshold_'.$item})) {
                 if (exists($coursesettings{'internal.threshold_'.$item})) {
                     $$threshold{$item} = 
@@ -1246,13 +1246,9 @@ sub process_reset {
 sub process_update {
     my ($uname,$udom,$threshold_titles) = @_;
     my $setoutput = '<b>'.&mt('Changes to threshold(s) for problem tracking:').'</b><br/><br />';
-    foreach my $key (keys(%env)) {
-        my $name;
-        if ($key =~/^form\.(.+)\_setparmval$/) {
-            $name  = $1;
-        } else {
-            next;
-        }
+    foreach (keys %env) {
+        next if ($_!~/^form\.(.+)\_setparmval$/);
+        my $name  = $1;
         my $value = $env{'form.'.$name.'_value'};
         if ($name && defined($value) && ($value ne '')) {
             my $put_result = &Apache::lonnet::put('nohist_whatsnew',
@@ -1622,13 +1618,13 @@ sub display_handgrade {
         foreach my $res (@{$tograde}) {
             $rowNum ++;
             my $css_class = $rowNum%2?' class="LC_odd_row"':'';
-            my ($map,$id,$url)=&Apache::lonnet::decode_symb($res);
-            my $linkurl=&Apache::lonnet::clutter($url);
-            $linkurl .= '?symb='.&escape($res);
+            my $linkurl='/adm/grades';
             if ($$ungraded{$res}{'enclink'}) {
-                $linkurl =
-                    $$ungraded{$res}{'enclink'}.'?symb='.$$ungraded{$res}{'encsymb'};
+                $linkurl.='?symb='.$$ungraded{$res}{'encsymb'};
+            } else {
+                $linkurl.='?symb='.&escape($res);
             }
+            $linkurl.='&amp;command=ungraded';
             $r->print('<tr'.$css_class.'><td><a href="'.$linkurl.'">'.$$ungraded{$res}{title}.'</a></td><td class="LC_right_item">'.$$ungraded{$res}{count}.'</td></tr>');
         }
     } elsif ($itemserror) {
@@ -1870,7 +1866,7 @@ sub display_crslogins {
                             my $udom = $user->{'udom'};
                             my $fullname;
                             if (ref($classlist->{$uname.':'.$udom}) eq 'ARRAY') {
-                                $fullname = $classlist->{$uname.':'.$udom}->[$fullnameidx];
+                                $fullname = $classlist->{$user}->[$fullnameidx];
                             } else {
                                 $fullname = &Apache::loncommon::plainname($uname,$udom,'lastname');
                             }
@@ -1950,7 +1946,7 @@ sub display_coursediscussion {
             my $forum_title = $$unread{$ressymb}{'title'};
             my $type = 'Resource';
             my $feedurl=&Apache::lonfeedback::get_feedurl($ressymb);
-            my $disclink = $feedurl.'?symb='.&escape($$unread{$ressymb}{symb});
+            my $disclink = $feedurl.'?symb='. &escape($$unread{$ressymb}{symb});
             if ($feedurl =~ /bulletinboard/) {
                 $type = 'Discussion Board';
             }