--- loncom/interface/lonwhatsnew.pm 2007/09/26 12:34:19 1.73
+++ loncom/interface/lonwhatsnew.pm 2012/02/08 17:07:02 1.101.2.1.2.1
@@ -1,5 +1,5 @@
#
-# $Id: lonwhatsnew.pm,v 1.73 2007/09/26 12:34:19 raeburn Exp $
+# $Id: lonwhatsnew.pm,v 1.101.2.1.2.1 2012/02/08 17:07:02 raeburn Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -36,11 +36,13 @@ use Apache::lonlocal;
use Apache::loncoursedata();
use Apache::lonnavmaps();
use Apache::lonuserstate;
+use Apache::lonuserutils;
use Apache::Constants qw(:common :http);
use Time::Local;
use GDBM_File;
use lib '/home/httpd/lib/perl/';
use LONCAPA;
+use HTML::Entities;
#----------------------------
# handler
@@ -68,6 +70,9 @@ sub handler {
['vgr','abovethreshold',1],
['opa','haserrors',1],
['mdc','versionchanges',0],
+ ['vcl','newroles',1],
+ ['vcl','oldroles',1],
+ ['whn','crslogin',1],
) {
my ($perm,$key,$check_section) = @{ $perm_check };
my $scope = $env{'request.course.id'};
@@ -84,7 +89,7 @@ sub handler {
if ( ! $env{'request.course.fn'} || ! $checkallowed{'whatsnew'}) {
# Not in a course, or no whn priv in course
- $env{'user.error.msg'}="/adm/whatsnew::whn:0:0:Cannot display what's new page";
+ $env{'user.error.msg'}="/adm/whatsnew:whn:0:0:Cannot display what's new page";
return HTTP_NOT_ACCEPTABLE;
}
@@ -96,7 +101,7 @@ sub handler {
&Apache::lonhtmlcommon::clear_breadcrumbs();
&Apache::lonhtmlcommon::add_breadcrumb
({href=>'/adm/whatsnew',
- text=>"Display Action Items"});
+ text=>"What's New?"});
if (($command eq 'chgthreshold') && $checkallowed{'abovethreshold'}) {
&Apache::lonhtmlcommon::add_breadcrumb
({href=>'/adm/whatsnew?command=chgthreshold&refpage='.$refpage,
@@ -125,6 +130,27 @@ sub handler {
$r->print(&Apache::lonhtmlcommon::breadcrumbs
("What's New?",#'Course_Action_Items_Initialization'
));
+ } elsif ($command eq 'chgoldroleinterval' && $checkallowed{'oldroles'}) {
+ &Apache::lonhtmlcommon::add_breadcrumb
+ ({href=>'/adm/whatsnew?command=chgoldroleinterval&refpage='.$refpage,
+ text=>"Change interval"});
+ $r->print(&Apache::lonhtmlcommon::breadcrumbs
+ ("What's New?",#'Course_Action_Items_Intervals'
+ ));
+ } elsif ($command eq 'chgnewroleinterval' && $checkallowed{'newroles'}) {
+ &Apache::lonhtmlcommon::add_breadcrumb
+ ({href=>'/adm/whatsnew?command=chgnewroleinterval&refpage='.$refpage,
+ text=>"Change interval"});
+ $r->print(&Apache::lonhtmlcommon::breadcrumbs
+ ("What's New?",#'Course_Action_Items_Intervals'
+ ));
+ } elsif ($command eq 'chgcrslogininterval' && $checkallowed{'crslogin'}) {
+ &Apache::lonhtmlcommon::add_breadcrumb
+ ({href=>'/adm/whatsnew?command=chgcrslogininterval&refpage='.$refpage,
+ text=>"Change interval"});
+ $r->print(&Apache::lonhtmlcommon::breadcrumbs
+ ("What's New?",#'Course_Action_Items_Intervals'
+ ));
} else {
$r->print(&Apache::lonhtmlcommon::breadcrumbs
("What's New?",#'Course_Action_Items_Display'
@@ -152,17 +178,39 @@ sub display_main_box {
degdiff => 'Degree of difficulty',
numstudents => 'Total number of students with submissions',
);
-
- my %interval_titles = &Apache::lonlocal::texthash (
- -1 => "since start of $lctype",
- 2592000 => 'since last month',
- 604800 => 'since last week',
- 86400 => 'since yesterday',
+ my %versions = (
+ -1 => "version changes since start of $lctype",
+ 2592000 => 'version changes since last month',
+ 604800 => 'version changes since last week',
+ 86400 => 'version changes since yesterday',
+ );
+ my %newroles = (
+ -1 => "roles which have become active since start of $lctype",
+ 2592000 => 'roles which have become active since last month',
+ 604800 => 'roles which have become active since last week',
+ 86400 => 'roles which have become active since yesterday',
+ );
+ my %oldroles = (
+ -1 => "roles which expired since start of $lctype",
+ 2592000 => 'roles which expired since last month',
+ 604800 => 'roles which expired since last week',
+ 86400 => 'roles which expired since yesterday',
+ );
+ my %crslogins = (
+ -1 => 'last logins for anyone who has ever logged in',
+ 2592000 => 'last logins for users in last 30 days',
+ 604800 => 'last logins for users in last 7 days',
+ 86400 => 'last logins for users in last 24 hours',
+ );
+ my %interval_titles = (
+ versions => \%versions,
+ newroles => \%newroles,
+ oldroles => \%oldroles,
+ crslogin => \%crslogins,
);
-
my %initpage = &Apache::lonlocal::texthash (
firstres => "first resource in the $lctype",
- whatsnew => "what's new? page",
+ whatsnew => "What's New Page",
userpref => 'your general user preferences',
coursespecific => "specific setting for this $lctype",
);
@@ -175,12 +223,21 @@ sub display_main_box {
$cdom,$crs);
} elsif (($command eq 'chginterval')
&& $checkallowed->{'versionchanges'}) {
- &display_interval_config($r,$refpage,\%interval_titles);
+ &display_interval_config($r,$refpage,\%interval_titles,'versions');
} elsif (($command eq 'chgdisc')
&& $checkallowed->{'coursediscussion'}) {
&display_discussion_config($r,$refpage);
} elsif ($command eq 'courseinit') {
&courseinit_config($r,$refpage,\%initpage);
+ } elsif (($command eq 'chgnewroleinterval')
+ && $checkallowed->{'newroles'}) {
+ &display_interval_config($r,$refpage,\%interval_titles,'newroles');
+ } elsif (($command eq 'chgoldroleinterval')
+ && $checkallowed->{'oldroles'}) {
+ &display_interval_config($r,$refpage,\%interval_titles,'oldroles');
+ } elsif (($command eq 'chgcrslogininterval')
+ && $checkallowed->{'crslogin'}) {
+ &display_interval_config($r,$refpage,\%interval_titles,'crslogin');
} else {
&display_actions_box($r,$command,$refpage,\%threshold_titles,
\%interval_titles,\%initpage,$cdom,$crs,$checkallowed);
@@ -205,12 +262,15 @@ sub display_header {
my ($command,$checkallowed) = @_;
my $scripttag;
- unless ($command eq 'chgthreshold' || $command eq 'chginterval') {
+ unless ($command eq 'chgthreshold' || $command eq 'chginterval' ||
+ $command eq 'chgoldroleinterval' ||
+ $command eq 'chgnewroleinterval' || $command eq 'chgcrslogininterval') {
$scripttag = <<"END";
';
}
my $course_type=&Apache::loncommon::course_type();
- return &Apache::loncommon::start_page($course_type.' Action Items',
+ return &Apache::loncommon::start_page("What's New?",
$scripttag);
}
@@ -249,7 +355,7 @@ sub display_actions_box {
my $lctype = lc($crstype);
my %stulabel = (
'Course' => 'students',
- 'Group' => 'members',
+ 'Community' => 'members',
);
my %lt = &Apache::lonlocal::texthash(
'yacc' => 'You are accessing an invalid course',
@@ -271,7 +377,12 @@ sub display_actions_box {
my @warnings = ();
my $msgcount = 0;
my $critmsgcount = 0;
-
+ my $expirecount;
+ my %expired;
+ my $activecount;
+ my %activated;
+ my %loggedin;
+ my $logincount;
my %res_title = ();
my %show = ();
my $needitems = 0;
@@ -285,7 +396,7 @@ sub display_actions_box {
my %threshold = ();
my %pagedesc = &Apache::lonlocal::texthash (
firstres => 'First resource',
- whatsnew => "What's New? page",
+ whatsnew => "What's New Page",
userpref => 'user preference',
coursespecific => $lctype.' only',
default => 'default',
@@ -299,19 +410,30 @@ sub display_actions_box {
return;
}
+ my $header = '';
if ($refpage eq 'start') {
if (tie(my %bighash,'GDBM_File',$env{'request.course.fn'}.'.db',
&GDBM_READER(),0640)) {
- my $furl=$bighash{'first_url'};
+ my $furl=&HTML::Entities::encode($bighash{'first_url'},'"<>&');
untie(%bighash);
- $r->print(''.$lt{'gtfr'}.
- ' ');
+ $header .= ''.$lt{'gtfr'}.
+ ' ';
}
}
- $r->print(&mt('Page set to be displayed after you have selected a role in this '.$lctype).
- '. '.&mt('Currently: [_1] ',$currinit).'. '.
- &mt('Change for just this '.$lctype.' ',$refpage).' '.
- &mt('or for all your courses .',$refpage).'
');
+ $header .= &mt('Page set to be displayed after you have selected a role in this '.$lctype).'.'
+ .' '
+ .&mt('Currently: [_1].',''.$currinit.' ')
+ .' '
+ .&mt('[_1]Change[_2] for just [_3]this '.$lctype.'[_4] or for [_5]all your courses/communities[_6].'
+ ,''
+ ,' '
+ ,''
+ ,' '
+ ,''
+ ,' ')
+ .' ';
+
+ $r->print(&Apache::loncommon::head_subbox($header));
if ($command eq 'reset') {
$result = &process_reset($cdom,$crs);
@@ -328,49 +450,119 @@ sub display_actions_box {
unless ($store_result eq 'ok') {
&Apache::lonnet::logthis('Error saving whatsnew settings: '.
$store_result.' for '.'user '.$uname.':'.$udom.' in '.$lctype.' '.$cid);
- $result .= &mt('Unable to save visibility settings due to [_1]',
- $store_result);
+ $result .= ''
+ .&mt('Unable to save visibility settings due to [_1]',
+ $store_result)
+ .' ';
}
if ($result) {
- $r->print($result.' ');
+ $r->print($result.' ');
}
$r->rflush();
-
+ my (%timediff,%interval);
my %display_settings = &get_display_settings($uname,$udom,$cid);
- my $timediff = $display_settings{$cid.':interval'};
- unless (defined($timediff)) { $timediff = 604800; }
- my $now = time;
- my $interval = $$interval_titles{$timediff};
- if ($timediff == -1) {
- $timediff = time;
- }
- my $starttime = $now - $timediff;
- my $countunread = $display_settings{$cid.':countunread'};
- unless (defined($countunread)) {
- $countunread = 'on';
- }
+ $timediff{'versions'} = $display_settings{$cid.':interval'};
+ unless (defined($timediff{'versions'})) { $timediff{'versions'} = 604800; }
+ $interval{'versions'} = $interval_titles->{'versions'}->{$timediff{'versions'}};
my %headings = &Apache::lonlocal::texthash(
- coursediscussion => 'Unread '.$lctype.' discussion posts',
- handgrading => 'Problems requiring handgrading',
- haserrors => 'Problems with errors',
- versionchanges => 'Resources in '.$lctype.' with version changes '.$interval,
+ coursediscussion => 'Unread '.$lctype.' discussion posts',
+ handgrading => 'Problems requiring handgrading',
+ haserrors => 'Problems with errors',
coursenormalmail => 'New '.$lctype.' messages',
- coursecritmail => 'New critical messages in '.$lctype,
+ coursecritmail => 'New critical messages in '.$lctype,
);
+ if ($timediff{'versions'} == -1) {
+ $headings{'versionchanges'} = &mt('Resources in '.$lctype.' with version changes since start of '.$lctype);
+ } elsif ($timediff{'versions'} == 2592000) {
+ $headings{'versionchanges'} = &mt('Resources in '.$lctype.' with version changes since last month');
+ } elsif ($timediff{'versions'} == 604800) {
+ $headings{'versionchanges'} = &mt('Resources in '.$lctype.' with version changes since last week');
+ } elsif ($timediff{'versions'} == 86400) {
+ $headings{'versionchanges'} = &mt('Resources in '.$lctype.' with version changes since yesterday');
+ }
+
+ $timediff{'oldroles'} = $display_settings{$cid.':oldroleinterval'};
+ unless (defined($timediff{'oldroles'})) { $timediff{'oldroles'} = 604800; }
+ $interval{'oldroles'} = $interval_titles->{'oldroles'}->{$timediff{'oldroles'}};
+
+ if ($timediff{'oldroles'} == -1) {
+ $headings{'oldroles'} = &mt('Roles for which access to '.$lctype.' has expired since start of '.$lctype);
+ } elsif ($timediff{'oldroles'} == 2592000) {
+ $headings{'oldroles'} = &mt('Roles for which access to '.$lctype.' has expired since last month');
+ } elsif ($timediff{'oldroles'} == 604800) {
+ $headings{'oldroles'} = &mt('Roles for which access to '.$lctype.' has expired since last week');
+ } elsif ($timediff{'oldroles'} == 86400) {
+ $headings{'oldroles'} = &mt('Roles for which access to '.$lctype.' has expired since yesterday');
+ }
+
+ $timediff{'newroles'} = $display_settings{$cid.':newroleinterval'};
+ unless (defined($timediff{'newroles'})) { $timediff{'newroles'} = 604800; }
+ $interval{'newroles'} = $interval_titles->{'newroles'}->{$timediff{'newroles'}};
+
+ if ($timediff{'newroles'} == -1) {
+ $headings{'newroles'} = &mt('Roles for which access to '.$lctype.' has become available since start of '.$lctype);
+ } elsif ($timediff{'newroles'} == 2592000) {
+ $headings{'newroles'} = &mt('Roles for which access to '.$lctype.' has become available since last month');
+ } elsif ($timediff{'newroles'} == 604800) {
+ $headings{'newroles'} = &mt('Roles for which access to '.$lctype.' has become available since last week');
+ } elsif ($timediff{'newroles'} == 86400) {
+ $headings{'newroles'} = &mt('Roles for which access to '.$lctype.' has become available since yesterday');
+ }
+
+ $timediff{'crslogin'} = $display_settings{$cid.':crslogininterval'};
+ unless (defined($timediff{'crslogin'})) { $timediff{'crslogin'} = 604800; }
+ $interval{'crslogin'} = $interval_titles->{'crslogin'}->{$timediff{'crslogin'}};
+
+ if ($timediff{'crslogin'} == -1) {
+ $headings{'crslogin'} = &mt('Last login for anyone who has ever logged in');
+ } elsif ($timediff{'crslogin'} == 2592000) {
+ $headings{'crslogin'} = &mt('Last login for users in last 30 days');
+ } elsif ($timediff{'crslogin'} == 604800) {
+ $headings{'crslogin'} = &mt('Last login for users in last 7 days');
+ } elsif ($timediff{'crslogin'} == 86400) {
+ $headings{'crslogin'} = &mt('Last login for users in last 24 hours');
+ }
+
+ my $now = time;
+ if ($timediff{'versions'} == -1) {
+ $timediff{'versions'} = time;
+ }
+ my $starttime = $now - $timediff{'versions'};
+
+ if ($timediff{'newroles'} == -1) {
+ $timediff{'newroles'} = time;
+ }
+ my $activatedstart = $now - $timediff{'newroles'};
+
+ if ($timediff{'oldroles'} == -1) {
+ $timediff{'oldroles'} = time;
+ }
+ my $expiredstart = $now - $timediff{'oldroles'};
+
+ if ($timediff{'crslogin'} == -1) {
+ $timediff{'crslogin'} = time;
+ }
+
+ my $crsloginstart = $now - $timediff{'crslogin'};
+
+ my $countunread = $display_settings{$cid.':countunread'};
+ unless (defined($countunread)) {
+ $countunread = 'on';
+ }
if ($$checkallowed{'abovethreshold'}) {
&get_curr_thresholds(\%threshold,$uname,$udom,$cid,$cdom,$crs);
}
$headings{'abovethreshold'} =
- &mt('Problems with av. attempts ≥ [_1] or deg. difficulty ≥ [_2] and total number of '.$stulabel{$crstype}.' with submissions ≥ [_3]',
+ &mt('(Problems with av. attempts ≥ [_1] or deg. difficulty ≥ [_2]) [_3] and total number of '.$stulabel{$crstype}.' with submissions ≥ [_4]',
$threshold{'av_attempts'},$threshold{'degdiff'},
- $threshold{'numstudents'});
+ ' ',$threshold{'numstudents'});
- my @actionorder = ('handgrading','haserrors','abovethreshold','versionchanges','coursediscussion','coursenormalmail','coursecritmail');
+ my @actionorder = ('handgrading','haserrors','abovethreshold','versionchanges','coursediscussion','coursenormalmail','coursecritmail','newroles','oldroles','crslogin');
foreach my $key (keys(%{$checkallowed})) {
if ($key =~ /_section$/) { next; }
@@ -383,7 +575,8 @@ sub display_actions_box {
}
foreach my $item (@actionorder) {
- unless ($item eq 'coursenormalmail' || $item eq 'coursecritmail') {
+ unless ($item eq 'coursenormalmail' || $item eq 'coursecritmail' ||
+ $item eq 'newroles' || $item eq 'oldroles') {
if ($show{$item}) {
$needitems = 1;
last;
@@ -391,8 +584,9 @@ sub display_actions_box {
}
}
+ my $itemserror;
if ($needitems) {
- &getitems(\%unread,\%ungraded,\%bombed,\%triggered,\%changed,\@newdiscussions,\@tograde,\@bombs,\@warnings,\%threshold,$cdom,$crs,\%res_title,\%show,$starttime,$countunread);
+ $itemserror = &getitems(\%unread,\%ungraded,\%bombed,\%triggered,\%changed,\@newdiscussions,\@tograde,\@bombs,\@warnings,\%threshold,$cdom,$crs,\%res_title,\%show,$starttime,$countunread);
}
if ($show{'coursenormalmail'}) {
$msgcount = &getnormalmail(\@newmsgs);
@@ -400,7 +594,15 @@ sub display_actions_box {
if ($show{'coursecritmail'}) {
$critmsgcount = &getcritmail(\@critmsgs);
}
-
+ if ($show{'oldroles'}) {
+ $expirecount = &getexpired(\%expired,$expiredstart,'previous');
+ }
+ if ($show{'newroles'}) {
+ $activecount = &getactivated(\%activated,$activatedstart,'active');
+ }
+ if ($show{'crslogin'}) {
+ $logincount = &getloggedin($cdom,$crs,\%loggedin,$crsloginstart);
+ }
$r->print(qq|$lt{'hial'}
$lt{'shal'}
');
+ } elsif ($itemserror) {
+ $r->print(''.$itemserror.' ');
} else {
$r->print(''.$lt{'nopr'}.' ');
}
}
sub display_versionchanges {
- my ($r,$changed,$res_title,$interval) = @_;
+ my ($r,$changed,$res_title,$interval,$itemserror) = @_;
my %lt = &Apache::lonlocal::texthash(
'reso' => 'Resource',
'revd' => 'Last revised',
'newv' => 'New version',
'veru' => 'Version used',
- 'noup' => 'No updated versions',
);
if (keys(%{$changed}) > 0) {
$r->print(''.
@@ -1253,15 +1739,160 @@ sub display_versionchanges {
$$changed{$item}{'current'}.' '.
$$changed{$item}{'version'}.' ');
}
+ } elsif ($itemserror) {
+ $r->print(''.$itemserror.' ');
+ } else {
+ $r->print(''
+ .&mt('No '.$interval).' ');
+ }
+ return;
+}
+
+sub display_rolechanges {
+ my ($r,$chgcount,$changed,$interval,$crstype) = @_;
+ my $now = time();
+ my %lt = &Apache::lonlocal::texthash(
+ 'user' => 'User',
+ 'tich' => 'Time of change',
+ 'role' => 'Role',
+ 'sec' => 'Section',
+ 'status' => 'Status',
+ );
+ if ($chgcount) {
+ $r->print(''.
+ ''.$lt{'tich'}.' '.
+ ''.$lt{'user'}.' '.
+ ''.$lt{'role'}.' '.
+ ''.$lt{'sec'}.' '.
+ ''.$lt{'status'}.' ');
+ if (ref($changed) eq 'HASH') {
+ my @changes = sort { $b <=> $a } (keys(%{$changed}));
+ my $changenum = 0;
+ foreach my $item (@changes) {
+ if (ref($changed->{$item}) eq 'ARRAY') {
+ foreach my $chg (@{$changed->{$item}}) {
+ if (ref($chg) eq 'HASH') {
+ my $section;
+ my $role =
+ &Apache::lonnet::plaintext($chg->{'role'},$crstype);
+ my $status = &mt($chg->{'status'});
+ if ($chg->{'section'} eq '') {
+ $section = &mt('none');
+ } else {
+ $section = $chg->{'section'};
+ }
+ my $uname = $chg->{'uname'};
+ my $udom = $chg->{'udom'};
+ $changenum ++;
+ my $css_class = $changenum%2?' class="LC_odd_row"':'';
+ my $link =
+ &Apache::loncommon::aboutmewrapper(&Apache::loncommon::plainname($uname,$udom),$uname,$udom);
+ $r->print(''.
+ ''.&Apache::lonlocal::locallocaltime($item).' '.
+ ''.$link.' '.
+ ''.$role.' '.
+ ''.$section.' '.
+ ''.$status.' ');
+ }
+ }
+ }
+ }
+ }
+ } else {
+ $r->print(''
+ .&mt('There are no '.$interval).' ');
+ }
+ return;
+}
+
+sub display_crslogins {
+ my ($r,$logincount,$loggedin,$interval,$crstype) = @_;
+ my %lt = &Apache::lonlocal::texthash(
+ 'user' => 'User',
+ 'role' => 'Role',
+ 'sec' => 'Section',
+ 'number' => 'Total number of logins',
+ );
+ if ($logincount) {
+
+ my $hdr = ''.
+ ''.$lt{'user'}.' '.
+ ''.$lt{'role'}.' '.
+ ''.$lt{'sec'}.' '.
+ ''.
+ ''.$lt{'number'}.' '.
+ ''.$lt{'role'}.' '.
+ ''.$lt{'sec'};
+ my (%bylastname,%counts);
+ if (ref($loggedin) eq 'HASH') {
+ my @logins = sort { $b <=> $a } (keys(%{$loggedin}));
+ my $numlogin = 0;
+ foreach my $item (@logins) {
+ if (ref($loggedin->{$item}) eq 'ARRAY') {
+ foreach my $user (@{$loggedin->{$item}}) {
+ if (ref($user) eq 'HASH') {
+ my $section;
+ my $role =
+ &Apache::lonnet::plaintext($user->{'role'},$crstype);
+ my $status = &mt($user->{'status'});
+ if ($user->{'section'} eq '') {
+ $section = &mt('none');
+ } else {
+ $section = $user->{'section'};
+ }
+ $counts{$user->{'role'}}{$section} ++;
+ my $uname = $user->{'uname'};
+ my $udom = $user->{'udom'};
+ my $fullname = &Apache::loncommon::plainname($uname,$udom,'lastname');
+ my $link =
+ &Apache::loncommon::aboutmewrapper($fullname,$uname,$udom);
+ push(@{$bylastname{$fullname}},
+ ' '.$link.' '.
+ ''.$role.' '.
+ ''.$section.' ');
+ }
+ }
+ }
+ }
+ my $table;
+ foreach my $person (sort(keys(%bylastname))) {
+ if (ref($bylastname{$person}) eq 'ARRAY') {
+ foreach my $item (@{$bylastname{$person}}) {
+ $numlogin ++;
+ my $css_class = $numlogin%2?' class="LC_odd_row"':'';
+ $table .= ' '.$item.' ';
+ }
+ }
+ }
+ my $numrow = 0;
+ foreach my $role (sort(keys(%counts))) {
+ my $showrole = &Apache::lonnet::plaintext($role,$crstype);
+ if (ref($counts{$role}) eq 'HASH') {
+ foreach my $sec (sort { $b <=> $a } (keys(%{$counts{$role}}))) {
+ $numrow ++;
+ my $css_class = $numrow%2?' class="LC_odd_row"':'';
+ $table .= ''.
+ ''.$counts{$role}{$sec}.' '.
+ ''.$showrole.' '.
+ ''.$sec.' ';
+ }
+ }
+ }
+ $r->print($hdr.' '.$table);
+ }
} else {
- $r->print(''.$lt{'noup'}.
- ' '.$interval.' ');
+ $r->print(''.
+ &mt('There are no '.$interval).
+ ' ');
}
return;
}
sub display_coursediscussion {
- my ($r,$newdiscussions,$unread,$countunread,$res_title) = @_;
+ my ($r,$newdiscussions,$unread,$countunread,$res_title,$itemserror) = @_;
my $lctype = lc(&Apache::loncommon::course_type());
my %lt = &Apache::lonlocal::texthash(
'loca' => 'Location',
@@ -1291,7 +1922,7 @@ sub display_coursediscussion {
my $feedurl=&Apache::lonfeedback::get_feedurl($ressymb);
my $disclink = $feedurl.'?symb='.$$unread{$ressymb}{symb};
if ($feedurl =~ /bulletinboard/) {
- $type = 'Bulletin Board';
+ $type = 'Discussion Board';
}
if ($$unread{$ressymb}{'enclink'}) {
$disclink = $$unread{$ressymb}{'enclink'}.'?symb='.$$unread{$ressymb}{'encsymb'};
@@ -1309,6 +1940,8 @@ sub display_coursediscussion {
}
$r->print("\n");
}
+ } elsif ($itemserror) {
+ $r->print(''.$itemserror.' ');
} else {
$r->print(''.$lt{'noun'}.' ');
}
@@ -1326,11 +1959,12 @@ sub display_coursenormalmail {
foreach my $msg (@{$newmsgs}) {
$mailcount ++;
my $css_class = $mailcount%2?' class="LC_odd_row"':'';
- $r->print(''.$mailcount.
- '. '.
- $msg->{'shortsub'}.' '.
- $msg->{'from'}.':'.$msg->{'fromdom'}.' '.
- $msg->{'sendtime'}.' ');
+ $r->print(''.$mailcount
+ .'. '
+ .$msg->{'shortsub'}.' '
+ .$msg->{'from'}.':'.$msg->{'fromdom'}.' '
+ .$msg->{'sendtime'}.' ');
}
} else {
$r->print(''.
@@ -1411,24 +2045,34 @@ sub store_interval_setting {
my ($uname,$udom,$cid,$interval_titles) = @_;
my %interval_settings = ();
my $result;
- if (defined($env{'form.interval'})) {
- $interval_settings{$cid.':interval'} = $env{'form.interval'};
+ my $context = $env{'form.intervaltype'};
+ if ($env{'form.interval'} ne '') {
+ if ($context eq 'oldroles') {
+ $interval_settings{$cid.':oldroleinterval'} = $env{'form.interval'};
+ } elsif ($context eq 'newroles') {
+ $interval_settings{$cid.':newroleinterval'} = $env{'form.interval'};
+ } elsif ($context eq 'crslogin') {
+ $interval_settings{$cid.':crslogininterval'} = $env{'form.interval'};
+ } else {
+ $interval_settings{$cid.':interval'} = $env{'form.interval'};
+ }
my $outcome = &Apache::lonnet::put('nohist_whatsnew',
\%interval_settings,$udom,$uname);
if ($outcome eq 'ok') {
- $result = &mt('Interval set to version changes [_1]',
- ''.$$interval_titles{$env{'form.interval'}}.' ');
-
+ if (ref($interval_titles->{$context}) eq 'HASH') {
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('New filter setting: [_1].',''.
+ $interval_titles->{$context}->{$env{'form.interval'}}.' ').' ');
+ }
} else {
my $lctype = lc(&Apache::loncommon::course_type());
- &Apache::lonnet::logthis('Error saving whatsnew interval setting'.
+ &Apache::lonnet::logthis('Error saving whatsnew '.$context.' interval setting'.
' '.$outcome.' for '.$uname.':'.$udom.' in '.$lctype.' '.$cid);
- $result = &mt('Unable to set interval to [_1] due to [_2].',
- ''.$$interval_titles{$env{'form.interval'}}.' ',
- ''.$outcome.' . ');
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('Unable to set interval to [_1] due to [_2].',
+ ''.$interval_titles->{$context}->{$env{'form.interval'}}.' ',
+ ''.$outcome.' '),1);
}
}
- return $result;
+ return &Apache::loncommon::confirmwrapper($result);
}
sub store_discussion_setting {
@@ -1440,20 +2084,20 @@ sub store_discussion_setting {
my $outcome = &Apache::lonnet::put('nohist_whatsnew',
\%discussion_settings,$udom,$uname);
if ($outcome eq 'ok') {
- $result = &mt('Count unread posts in discussions display set to [_1]',
- ''.$env{'form.countunread'}.' ');
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('Count unread posts in discussions display set to [_1]',
+ ''.&mt($env{'form.countunread'}).' ').' ');
} else {
my $lctype = lc(&Apache::loncommon::course_type());
&Apache::lonnet::logthis('Error saving whatsnew countunread setting'.
' '.$outcome.' for '.$uname.':'.$udom.' in '.$lctype.' '.$cid);
- $result = &mt('Unable to set "number unread posts display" to [_1]'.
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('Unable to set "number unread posts display" to [_1]'.
' due to [_2].',
- ''.$env{'form.countunread'}.' ',
- ''.$outcome.' . ');
+ ''.&mt($env{'form.countunread'}).' ',
+ ''.$outcome.' '),1);
}
}
- return $result;
+ return &Apache::loncommon::confirmwrapper($result);
}
sub store_courseinit_setting {
@@ -1478,27 +2122,29 @@ sub store_courseinit_setting {
\%courseinit_settings,$udom,$uname);
if ($outcome eq 'ok') {
if ($page_control eq 'global preferences') {
- $result = &mt("Page displayed after role selection in $lctype now set by user's global preferences .");
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt("Page displayed after role selection in $lctype now set by [_1]user's global preferences[_2].",'',' '));
} else {
- $result = &mt('Page displayed after role selection in this '.$lctype.' set to [_2] ',$lctype,$$initpage{$env{'form.courseinit_page'}});
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('Page displayed after role selection in this '.$lctype.' set to [_1].'
+ ,''.$$initpage{$env{'form.courseinit_page'}}.' '));
}
} else {
&Apache::lonnet::logthis('Error saving whatsnew courseinit '.
'setting: '.$outcome.' for '.$uname.
':'.$udom.' in '.$lctype.' '.$cid);
if ($page_control eq 'global preferences') {
- $result = &mt('Unable to set control of page display to [_1]'.
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('Unable to set control of page display to [_1]'.
' due to [_2].',
''.$page_control.' ',
- ''.$outcome.' . ');
+ ''.$outcome.' '),1);
} else {
- $result = &mt('Unable to set page display, after role selection, for this '.$lctype.' to [_2] due to [_3] . ',
- $$initpage{$env{'form.courseinit_page'}},$outcome);
+ $result = &Apache::lonhtmlcommon::confirm_success(&mt('Unable to set page display, after role selection, for this '.$lctype.' to [_1] due to [_2].'
+ ,''.$$initpage{$env{'form.courseinit_page'}}.' '
+ ,''.$outcome.' '),1);
}
}
}
}
- return $result;
+ return &Apache::loncommon::confirmwrapper($result);
}
sub start_box {
@@ -1530,24 +2176,46 @@ sub start_box {
if ($$show{$caller}) {
$r->print('
-
+
');
}
} elsif (($caller eq 'versionchanges') && ($$show{$caller})) {
if ($$show{$caller}) {
$r->print('
-
+
');
}
} elsif ($caller eq 'coursediscussion') {
if ($$show{$caller}) {
$r->print('
-
+
+ ');
+ }
+ } elsif (($caller eq 'newroles') && ($$show{$caller})) {
+ if ($$show{$caller}) {
+ $r->print('
+
+
');
}
- }
+ } elsif (($caller eq 'oldroles') && ($$show{$caller})) {
+ if ($$show{$caller}) {
+ $r->print('
+
+
+ ');
+ }
+ } elsif (($caller eq 'crslogin') && ($$show{$caller})) {
+ if ($$show{$caller}) {
+ $r->print('
+
+
+ ');
+ }
+ }
+
$r->print('