--- loncom/interface/multidownload.pl	2007/04/30 17:38:09	1.20
+++ loncom/interface/multidownload.pl	2007/05/05 17:26:27	1.24
@@ -2,7 +2,7 @@
 # CGI-script to allow download of all essay submissions of 
 # multiple students.
 #
-# $Id: multidownload.pl,v 1.20 2007/04/30 17:38:09 banghart Exp $
+# $Id: multidownload.pl,v 1.24 2007/05/05 17:26:27 banghart Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -34,7 +34,6 @@ use File::Basename;
 use File::Copy;
 use IO::File;
 use Apache::lonhtmlcommon();
-use Apache::grades;
 use Apache::lonnavmaps;
 use Apache::lonnet;
 use Apache::loncommon();
@@ -75,7 +74,7 @@ if (&Apache::lonnet::allowed('vgr',$scop
     my $partlist = $res->parts();
     my ($zipout) = ($symb =~ /^.*\/(.+)\.problem$/);
     $zipout =~ s/\s/_/g;
-    $zipout .= ".zip";
+    $zipout .= "$identifier.zip";
     my $courseid = $env{'request.course.id'};
     my @stuchecked = split(/\n/,$env{'cgi.'.$identifier.'.students'});
     my @parts = split(/\n/,$env{'cgi.'.$identifier.'.parts'});
@@ -84,12 +83,17 @@ if (&Apache::lonnet::allowed('vgr',$scop
     my $udom = $env{'user.domain'};
     my $unique_user = $uname.":".$udom;
     &mkpath($doc_zip_root."/zipdir/$unique_user/$unique_path",0,0700);
+    if (!open MANIFEST, ">$doc_zip_root/zipdir/$unique_user/$unique_path/manifest.txt") {
+        &Apache::lonnet::logthis("Problem making manifest");
+    }
+    print MANIFEST &mt("Files contained in this zip:\n");
     my $file_problem = 0;
     foreach my $stu (@stuchecked) {
         my %files_saved;
         my ($stuname,$studom,$fullname) = split(/:/,$stu);
         my %record = &Apache::lonnet::restore($symb,$courseid,$studom,$stuname);
         my $file_url = '/uploaded/'.$studom.'/'.$stuname.'/portfolio';
+        print MANIFEST $fullname."\n";
         foreach my $partid (@$partlist) {
             my @ids = $res->responseIds($partid);
             foreach my $respid(@ids) {
@@ -97,6 +101,7 @@ if (&Apache::lonnet::allowed('vgr',$scop
                 foreach my $file (split(',',$record{"resource.$partid.$respid.portfiles"})) {
                     $file = $file_url.$file;
                     my ($file_name_only) = ($file =~ /^.*\/(.+$)/);
+                    print MANIFEST "\t$file_name_only \n";
                     &Apache::lonnet::repcopy($file);
                     my $source = &Apache::lonnet::filelocation("",$file);
                     my $destination = "$doc_zip_root/zipdir/$unique_user/$unique_path/$stuname/part$partid/resp$respid/$file_name_only";
@@ -118,14 +123,22 @@ if (&Apache::lonnet::allowed('vgr',$scop
             }
         }
     }
+    
     &mkpath($doc_zip_root."/zipout/$unique_user",0,0700);
-    my $statement = "cd $doc_zip_root/zipdir/$unique_user/$unique_path\n";
-    $statement .= "zip -r $doc_zip_root/zipout/$unique_user/$zipout * > /dev/null";
-    system($statement);
+    my $statement;
+    if (! -e "$doc_zip_root/zipout/$unique_user/$zipout") {
+        $statement = "cd $doc_zip_root/zipdir/$unique_user/$unique_path\n";
+        $statement .= "zip -r $doc_zip_root/zipout/$unique_user/$zipout * > /dev/null";
+        system($statement);
+    } else {
+        # should happen only if user reloads page 
+        &Apache::lonnet::logthis("$zipout is already there");
+    }
     $statement = "rm -rf $doc_zip_root/zipdir/$unique_user/$unique_path";
     system($statement);
     print('<a href="/zipspool/zipout/'.$unique_user.'/'.$zipout.'">'.
             &mt("Click to download").'</a><br />');
+    close MANIFEST;
 } else {
     print(&mt('You are not authorized to download student submissions.'));
 }