--- loncom/interface/portfolio.pm	2011/10/17 12:41:30	1.233
+++ loncom/interface/portfolio.pm	2013/04/11 14:59:49	1.240
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.233 2011/10/17 12:41:30 raeburn Exp $
+# $Id: portfolio.pm,v 1.240 2013/04/11 14:59:49 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -63,7 +63,7 @@ sub group_form_data {
     return $output;
 } 
 
-# receives a file name and path stub from username/userfiles/portfolio/
+# receives a filename and path stub from username/userfiles/portfolio/
 # returns an anchor tag consisting encoding filename and currentpath
 sub make_anchor {
     my ($url, $anchor_fields, $inner_text) = @_;
@@ -122,6 +122,7 @@ END
                  .'<input name="uploaddoc" type="file" />'
                  .'<input type="hidden" name="currentpath" value="'.$current_path.'" />'
                  .'<input type="hidden" name="action" value="'.$env{"form.action"}.'" />'
+                 .'<input type="hidden" name="symb" value="'.$env{"form.symb"}.'" />'
                  .'<input type="hidden" name="fieldname" value="'.$env{"form.fieldname"}.'" />'
                  .'<input type="hidden" name="mode" value="'.$env{"form.mode"}.'" />'
                  .'<input type="submit" name="storeupl" value="'.$lt{'upload'}.'" />'
@@ -139,6 +140,7 @@ END
                  .'<input name="newdir" type="text" />'.$groupitem
                  .'<input type="hidden" name="currentpath" value="'.$current_path.'" />'
                  .'<input type="hidden" name="action" value="'.$env{"form.action"}.'" />'
+                 .'<input type="hidden" name="symb" value="'.$env{"form.symb"}.'" />'
                  .'<input type="hidden" name="fieldname" value="'.$env{"form.fieldname"}.'" />'
                  .'<input type="hidden" name="mode" value="'.$env{"form.mode"}.'" />'
                  .'<input type="submit" name="createdir" value="'.$lt{'createdir'}.'" />'
@@ -155,6 +157,7 @@ END
         'selectfile'    => $port_path,
         'currentpath'   => '/',
         'mode'          => $env{"form.mode"},
+        'symb'          => $env{"form.symb"},
         'fieldname'     => $env{"form.fieldname"},
         'continue'      => $env{"form.continue"}
     );
@@ -168,6 +171,7 @@ END
                 'selectfile' => $tree[$i],
                 'currentpath' => $newCurrentPath,
                 'mode' => $env{"form.mode"},
+                'symb' => $env{"form.symb"},
                 'fieldname' => $env{"form.fieldname"},
                 'continue' => $env{"form.continue"}
             );
@@ -177,7 +181,7 @@ END
     $r->print('</span>');
     $r->print(&Apache::loncommon::help_open_topic('Portfolio ChangeDirectory'));
     &Apache::lonhtmlcommon::store_recent($namespace,$current_path,$current_path);
-    $r->print('<br /><form method="post" action="'.$url.'?mode='.$env{"form.mode"}.'&amp;fieldname='.$env{"form.fieldname"}.&group_args());
+    $r->print('<br /><form method="post" action="'.$url.'?mode='.$env{"form.mode"}.'&amp;fieldname='.$env{"form.fieldname"}.'&amp;symb='.$env{'form.symb'}.&group_args());
     $r->print('">'.
 	      &Apache::lonhtmlcommon::select_recent($namespace,'currentpath',
 						    'this.form.submit();'));
@@ -447,6 +451,7 @@ sub display_directory {
                     'selectfile'    => $filename.'/',
                     'currentpath'   => $current_path.$filename.'/',
                     'mode'          => $env{"form.mode"},
+                    'symb'          => $env{"form.symb"},
                     'fieldname'     => $env{"form.fieldname"},
                     'continue'      => $env{"form.continue"}
                 );  
@@ -554,6 +559,7 @@ sub display_directory {
         $r->print('
             <input type="hidden" name="continue" value="true" />
             <input type="hidden" name="fieldname" value="'.$env{'form.fieldname'}.'" />
+            <input type="hidden" name="symb" value="'.$env{'form.symb'}.'" />
             <input type="hidden" name="mode" value="selectfile" />
             <p>
             <input type="submit" name="submit" value="'.&mt('Select checked files, and continue selecting').'" /><br />
@@ -641,9 +647,10 @@ sub done {
         'showversions' => $env{'form.showversions'},
         'currentpath' => $env{'form.currentpath'},
         'fieldname' => $env{'form.fieldname'},
+        'symb'      => $env{'form.symb'},
         'mode'      => $env{'form.mode'}
     );
-    my $result = '<h3>'.&make_anchor($url,\%anchor_fields,&mt($message)).'</h3>';
+    my $result = '<p>'.&make_anchor($url,\%anchor_fields,&mt($message)).'</p>';
     return $result;
 }
 
@@ -663,7 +670,7 @@ sub delete {
             $r->print('<p>'.&mt('Delete [_1]?',&display_file(undef,\@files)).'</p>');
             &close_form($r,$url);
         } else {
-            $r->print("No file was checked to delete.<br />");
+            $r->print('<p class="LC_warning">'.&mt('No file was checked to delete.').'</p>');
             $r->print(&done(undef,$url));
         }
     }
@@ -802,7 +809,7 @@ sub rename_confirmed {
         return;
     }
     if ($filenewname ne $env{'form.filenewname'}) {
-        $r->print(&mt("The new file name was changed from:<br />[_1] to [_2]",
+        $r->print(&mt("The new filename was changed from:<br />[_1] to [_2]",
 		      '<strong>'.&display_file('',$env{'form.filenewname'}).'</strong>',
 		      '<strong>'.&display_file('',$filenewname).'</strong>'));
     }
@@ -974,11 +981,11 @@ sub build_access_summary {
                 $showstart = &mt('Deleted');
                 $showend = $showstart;
             } else {
-                $showstart = localtime($start);
+                $showstart = &Apache::lonlocal::locallocaltime($start);
                 if ($end == 0) {
                     $showend = &mt('No end date');
                 } else {
-                    $showend = localtime($end);
+                    $showend = &Apache::lonlocal::locallocaltime($end);
                 }
             }
             $r->print('<td>'.&mt($scope_desc{$scope}));
@@ -2090,6 +2097,7 @@ sub hidden_elems {
     }
     return <<END;
 <input type="hidden" name="currentpath" value="$env{'form.currentpath'}" />
+<input type="hidden" name="symb" value="$env{'form.symb'}" />
 <input type="hidden" name="fieldname" value="$env{'form.fieldname'}" />
 <input type="hidden" name="mode" value="$env{'form.mode'}" />
 <input type="hidden" name="showversions" value="$env{'form.showversions'}" />
@@ -2111,7 +2119,10 @@ sub print_dependency_form {
             $r->print('<h3>'.&mt("Reference Information").'</h3>');
         }
         if ($num) {
-            $r->print('<p>'.&mt("Completed upload of the file. This file contained references to other files. You must upload the referenced files or else the uploaded file may not work properly.").'</p>'.
+            $r->print('<p>'.&mt('Completed upload of the file.').' '.
+                      &mt('This file contained references to other files.').' '.
+                      &mt('You must upload the referenced files or else the uploaded file may not work properly.').
+                      '</p>'.
                       '<p>'.&mt("Please select the locations from which the referenced files are to be uploaded.").'</p>'.
                        $embedded.
                        '<p>'.&mt('or').'</p>'.&done('Return to directory',$url));
@@ -2368,12 +2379,13 @@ sub get_port_path {
 
 sub missing_priv {
     my ($r,$url,$priv) = @_;
-    my $longtext = {
+    my %longtext = 
+        &Apache::lonlocal::texthash(
                       upload => 'upload files',
                       delete => 'delete files',
                       rename => 'rename files',
                       setacl => 'set access controls for files',
-                   };
+    );
     my $escpath = &HTML::Entities::encode($env{'form.currentpath'},'&<>"');
     my $rtnlink = '<a href="'.$url;
     if ($url =~ /\?/) {
@@ -2383,13 +2395,13 @@ sub missing_priv {
     }
     $rtnlink .= 'currentpath='.$escpath;
     $r->print('<h3>'.&mt('Action disallowed').'</h3>');
-    $r->print(&mt('You do not have sufficient privileges to [_1] ',
-                  $longtext->{$priv}));
+    $r->print(&mt('You do not have sufficient privileges to [_1]',
+                  $longtext{$priv}));
     if (defined($env{'form.group'})) {
-        $r->print(&mt("in the group's group portfolio."));
+        $r->print(' '.&mt("in the group's group portfolio."));
         $rtnlink .= &group_args()
     } else {
-        $r->print(&mt('in this portfolio.'));
+        $r->print(' '.&mt('in this portfolio.'));
     }
     $rtnlink .= '">'.&mt('Return to directory').'</a>';
     $r->print('<br />'.$rtnlink);
@@ -2451,6 +2463,7 @@ sub embedded_form_elems {
     my ($container) = @_;
     my $state = <<STATE;
     <input type="hidden" name="currentpath" value="$env{'form.currentpath'}" />
+    <input type="hidden" name="symb" value="$env{'form.symb'}" />
     <input type="hidden" name="fieldname" value="$env{'form.fieldname'}" />
     <input type="hidden" name="mode" value="$env{'form.mode'}" />
     <input type="hidden" name="container" value="$container" />
@@ -2467,7 +2480,7 @@ sub handler {
     &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
          ['selectfile','currentpath','meta','lockinfo','currentfile','action',
 	  'fieldname','mode','rename','continue','group','access','setnum',
-          'cnum','cdom','type','setroles','showversions','ref']);
+          'cnum','cdom','type','setroles','showversions','ref','symb']);
     my ($uname,$udom,$portfolio_root,$url,$caller,$title,$group,$grp_desc);
     if ($r->uri =~ m|^(/adm/)([^/]+)|) {
         $url = $1.$2;
@@ -2570,15 +2583,45 @@ sub handler {
         }
     }
     $r->rflush();
+    # Check if access to portfolio is blocked by one or more blocking events in courses.
     my ($blocked,$blocktext) = 
         &Apache::loncommon::blocking_status('port',$uname,$udom);
     if ($blocked) {
-         $r->print($blocktext);
-         $r->print(&Apache::loncommon::end_page());
-         return OK;
+        my $evade_block;
+        # If portfolio display is in a window popped up from a "Select Portfolio Files"
+        # link in a .task resource, check if access to the task included proctor validation
+        # of check-in to a slot limited by IP.
+        # If so, and the slot is between its open and close dates, override the block. 
+        if ($env{'request.course.id'} && $env{'form.symb'}) {
+            (undef,undef,my $res) = &Apache::lonnet::decode_symb($env{'form.symb'});
+            if ($res =~ /\.task$/i) {
+                my %history =
+                    &Apache::lonnet::restore($env{'form.symb'},$env{'request.course.id'},
+                                             $env{'user.domain'},$env{'user.name'});
+                my $version = $history{'resource.0.version'};
+                if ($history{'resource.'.$version.'.0.checkedin'}) {
+                    if ($history{'resource.'.$version.'.0.checkedin.slot'}) {
+                        my %slot = &Apache::lonnet::get_slot($history{'resource.'.$version.'.0.checkedin.slot'});
+                        if ($slot{'ip'}) {
+                            if (&Apache::loncommon::check_ip_acc($slot{'ip'})) {
+                                my $now = time;
+                                if (($slot{'slottime'} < $now) && ($slot{'endtime'} > $now)) {
+                                    $evade_block = 1;
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+        unless ($evade_block) {
+            $r->print($blocktext);
+            $r->print(&Apache::loncommon::end_page());
+            return OK;
+        }
     }
     if (($env{'form.storeupl'}) & (!$env{'form.uploaddoc.filename'})){
-   	$r->print('<span class="LC_error">');
+   	$r->print('<span class="LC_warning">');
    	$r->print(&mt('No file was selected to upload.').' ');
 	$r->print(&mt('To upload a file, click <strong>Browse...</strong> and select a file, then click <strong>Upload</strong>.'));
 	$r->print('</span>');
@@ -2618,8 +2661,11 @@ sub handler {
         }
     } elsif ($env{'form.action'} eq 'modify_orightml') {
         if ($can_upload) {
-            $r->print(&Apache::loncommon::modify_html_refs('portfolio',$port_path,$uname,$udom,$group,$portfolio_root,$group));
-            $r->print(&done('Return to directory',$url));
+            my $result = 
+                &Apache::loncommon::modify_html_refs('portfolio',$port_path,$uname,$udom,$group,
+                                                     $portfolio_root,$group);
+            $r->print($result.
+                      &done('Return to directory',$url));
         } else {
             &missing_priv($r,$url,'upload');
         }