--- loncom/interface/portfolio.pm 2004/11/02 14:35:42 1.53 +++ loncom/interface/portfolio.pm 2005/12/19 20:41:45 1.91 @@ -29,51 +29,72 @@ use Apache::lonnet; use Apache::lontexconvert; use Apache::lonfeedback; use Apache::lonlocal; +use Apache::lonnet; # receives a file name and path stub from username/userfiles/portfolio/ # returns an anchor tag consisting encoding filename and currentpath sub make_anchor { - my ($filename, $current_path) = @_; - my $anchor = ''.$filename.''; + my ($filename, $current_path, $current_mode, $field_name, $continue_select) = @_; + if ($continue_select ne 'true') {$continue_select = 'false'}; + my $anchor = ''.$filename.''; return $anchor; } my $dirptr=16384; sub display_common { my ($r,$current_path,$is_empty,$dir_list)=@_; my $iconpath= $r->dir_config('lonIconsURL') . "/"; - $r->print(''); - $r->print('
'); - my $displayOut = '
'; - $displayOut .= ''. - ''. - ''. - ''. - ''. - '
'; - $r->print($displayOut); - $r->print('
'); - $displayOut = '
'; - $displayOut .= ''. - ''. - ''. - ''. - ''. - '
'; - $r->print($displayOut); - $r->print('
'); + my %text=&Apache::lonlocal::texthash('upload' => 'Upload', + 'upload_label' => + 'Upload file to current directory:', + 'createdir' => 'Create Subdirectory', + 'createdir_label' => + 'Create subdirectory in current directory:'); + $r->print(<<"TABLE"); + + + + + + + + + + + + + +
+ $text{'upload_label'} + + + + + + + +
+ $text{'createdir_label'} + + + + + + + +
+TABLE my @tree = split (/\//,$current_path); - $r->print(''.&make_anchor('portfolio','/').'/'); + $r->print(''.&make_anchor('portfolio','/',$env{"form.mode"},$env{"form.fieldname"},$env{"form.continue"}).'/'); if (@tree > 1){ my $newCurrentPath = ''; for (my $i = 1; $i< @tree; $i++){ $newCurrentPath .= $tree[$i].'/'; - $r->print(&make_anchor($tree[$i],'/'.$newCurrentPath).'/'); + $r->print(&make_anchor($tree[$i],'/'.$newCurrentPath, $env{"form.mode"},$env{"form.fieldname"}, $env{"form.continue"}).'/'); } } $r->print(''); &Apache::lonhtmlcommon::store_recent('portfolio',$current_path,$current_path); - #Fixme -- remove from recent those paths that are deleted - $r->print('
'. + $r->print('
'. &Apache::lonhtmlcommon::select_recent('portfolio','currentpath', 'this.form.submit();')); $r->print("
"); @@ -82,98 +103,36 @@ sub display_directory { my ($r,$current_path,$is_empty,$dir_list)=@_; my $iconpath= $r->dir_config('lonIconsURL') . "/"; my $display_out; - my %locked_files=&Apache::lonnet::dump('file_permissions', - $ENV{'user.domain'},$ENV{'user.name'}); - my $locked_file; - foreach my $key (keys %locked_files) { - $locked_file .= $locked_files{$key}.':'; - } - if ($is_empty && ($current_path ne '/')) { - $display_out = '
'. - ''. - ''. - ''. - ''. - '
'; - - $r->print($display_out); - return; - } - $r->print(''. - ''); - my $href_location="/uploaded/$ENV{'user.domain'}/$ENV{'user.name'}/portfolio$current_path"; - foreach my $line (sort - { - my ($afile)=split('&',$a,2); - my ($bfile)=split('&',$b,2); - return (lc($afile) cmp lc($bfile)); - } (@$dir_list)) { - #$strip holds directory/file name - #$dom - my ($filename,$dom,undef,$testdir,undef,undef,undef,undef,$size,undef,$mtime,undef,undef,undef,$obs,undef)=split(/\&/,$line,16); - if ($Apache::lonhomework::results{"resource.$ENV{'user.domain'}.$ENV{'user.name'}.$filename"}eq'true'){ - &Apache::lonnet::logthis("found submitted file"); - &Apache::lonnet::logthis("resource.$ENV{'user.domain'}.$ENV{'user.name'}.$filename"); - } else { - &Apache::lonnet::logthis("$filename not found submitted file"); - &Apache::lonnet::logthis("resource.$ENV{'user.domain'}.$ENV{'user.name'}.$filename"); - } - if (($filename ne '.') && ($filename ne '..')) { - if ($dirptr&$testdir) { - $r->print(''); - $r->print(''); - $r->print(''); - $r->print(''); - } else { - $r->print(''); - $r->print(''); - $r->print(''); - $r->print(''); - $r->print(''); - $r->print(''); - $r->print(''); - } - } - } -# pink bg -# blue bg -# $r->print(&display_directory($current_path, $currentFile, @dir_list)); -# $r->print('>
Actions NameSizeLast Modified
Go to ...'.&make_anchor($filename.'/',$current_path.$filename.'/').'
-
- - - - -
-
'. - $filename.''.$size.''.&Apache::lonlocal::locallocaltime($mtime).'
'); -# $r->print(&display_actions($current_path, $currentFile, $isEmpty)); - $r->print('
'); -} -sub display_file_select { - my ($r,$current_path,$is_empty,$dir_list)=@_; - my $iconpath= $r->dir_config('lonIconsURL') . "/"; - my $display_out; + my $select_mode; + my $checked_files; + my %locked_files = &Apache::lonnet::get_marked_as_readonly_hash ($env{'user.domain'},$env{'user.name'}); + if ($env{"form.mode"} eq 'selectfile'){ + &select_files($r); + $checked_files =&Apache::lonnet::files_in_path($env{'user.name'},$env{'form.currentpath'}); + $select_mode = 'true'; + } if ($is_empty && ($current_path ne '/')) { $display_out = '
'. ''. ''. ''. ''. - '
'; $r->print($display_out); return; } - $r->print(''. + if ($select_mode eq 'true') { + $r->print('
'. ''); - my $href_location="/uploaded/$ENV{'user.domain'}/$ENV{'user.name'}/portfolio$current_path"; - $r->print(''); + $r->print(''); + } else { + $r->print('
Select NameSizeLast Modified
'. + ''); + $r->print(''); + } + my $href_location="/uploaded/$env{'user.domain'}/$env{'user.name'}/portfolio$current_path"; + my $href_edit_location="/editupload/$env{'user.domain'}/$env{'user.name'}/portfolio$current_path/"; foreach my $line (sort { my ($afile)=split('&',$a,2); @@ -183,18 +142,38 @@ sub display_file_select { #$strip holds directory/file name #$dom my ($filename,$dom,undef,$testdir,undef,undef,undef,undef,$size,undef,$mtime,undef,undef,undef,$obs,undef)=split(/\&/,$line,16); - if (($filename ne '.') && ($filename ne '..')) { + $filename =~ s/\s+$//; + if (($filename ne '.') && ($filename ne '..') && ($filename !~ /\.meta$/ ) && ($filename !~ /(.*)\.(.*)\.(.*)/)) { if ($dirptr&$testdir) { - $r->print(''); + if ($select_mode eq 'true'){ + $r->print(''); + } else { + $r->print(''); + } $r->print(''); - $r->print(''); + $r->print(''); $r->print(''); } else { $r->print(''); - $r->print(''); - $r->print(''); + if ($select_mode eq 'true'){ + $r->print(''); + } else { + if (exists $locked_files{$current_path.$filename}){ + $r->print(''); + } else { + my $cat=''.&mt('Catalog Information').
+			    ''; + $r->print(' + '); + } + } + $r->print(''); $r->print(''); $r->print(''); @@ -203,22 +182,37 @@ sub display_file_select { } } } - $r->print('
Actions NameSizeLast Modified
Go to ...'.&make_anchor($filename.'/',$current_path.$filename.'/').''.&make_anchor($filename.'/',$current_path.$filename.'/',$env{'form.mode'},$env{"form.fieldname"},$env{'form.continue'}).'
- - print("CHECKED"); + } + $r->print('>Locked + Rename'.$cat.' + '. $filename.''.$size.'
+ if ($select_mode eq 'true') { + $r->print(' + + + +
- '); + '); + } else { + $r->print(' + + + + '); + } } sub open_form { my ($r)=@_; + my @files=&Apache::loncommon::get_env_multiple('form.selectfile'); $r->print('
'); $r->print(''); + $env{'form.action'}.'" />'); $r->print(''); - $r->print(''); + foreach (@files) { + $r->print(''); + } $r->print(''); + $env{'form.currentpath'}.'" />'); } sub close_form { @@ -228,7 +222,7 @@ sub close_form { $r->print('

+ $env{'form.currentpath'}.'" />

'); @@ -236,34 +230,67 @@ sub close_form { sub display_file { my ($path,$filename)=@_; - if (!defined($path)) { $path=$ENV{'form.currentpath'}; } - if (!defined($filename)) { $filename=$ENV{'form.selectfile'}; } - return ''.$path.$filename.''; + my $display_file_text; + if (!defined($path)) { $path=$env{'form.currentpath'}; } + if (!defined($filename)) { + $filename=$env{'form.selectfile'}; + $display_file_text = ''.$path.$filename.''; + } elsif (ref($filename) eq "ARRAY") { + foreach (@$filename) { + $display_file_text .= ''.$path.$_.'
'; + } + } elsif (ref($filename) eq "SCALAR") { + $display_file_text = ''.$path.$filename.''; + } + return $display_file_text; } sub done { + my ($message)=@_; + unless (defined $message) { + $message='Done'; + } return ('

'.&mt('Done').'

'); + $env{'form.currentpath'}. + '&fieldname='.$env{'form.fieldname'}. + '&mode='.$env{'form.mode'}. + '">'.&mt($message).''); } sub delete { my ($r)=@_; - &open_form($r); - $r->print('

'.&mt('Delete').' '.&display_file().'?

'); - &close_form($r); + my @check; + my $file_name = $env{'form.currentpath'}.$env{'form.selectfile'}; + my @files=&Apache::loncommon::get_env_multiple('form.selectfile'); + + if (&Apache::lonnet::is_locked($file_name,$env{'user.domain'},$env{'user.name'} ) eq 'true') { + $r->print ("The file is locked and cannot be deleted.
"); + $r->print(&done('Back')); + } else { + if (scalar(@files)) { + &open_form($r); + $r->print('

'.&mt('Delete').' '.&display_file(undef,\@files).'?

'); + &close_form($r); + } else { + $r->print("No file was checked to delete.
"); + $r->print(&done()); + } + } } sub delete_confirmed { my ($r)=@_; - my $result=&Apache::lonnet::removeuserfile($ENV{'user.name'}, - $ENV{'user.domain'},'portfolio'. - $ENV{'form.currentpath'}. - $ENV{'form.selectfile'}); - if ($result ne 'ok') { + my @files=&Apache::loncommon::get_env_multiple('form.selectfile'); + my $result; + foreach my $delete_file (@files) { + $result=&Apache::lonnet::removeuserfile($env{'user.name'}, + $env{'user.domain'},'portfolio'. + $env{'form.currentpath'}. + $delete_file); + if ($result ne 'ok') { $r->print(' An error occured ('.$result. - ') while trying to delete '.&display_file().'
'); + ') while trying to delete '.&display_file(undef, $delete_file).'

'); + } } $r->print(&done()); } @@ -277,11 +304,10 @@ sub delete_dir { sub delete_dir_confirmed { my ($r)=@_; - my $directory_name = $ENV{'form.currentpath'}; - $directory_name =~ m/\/$/; - $directory_name = $`; - my $result=&Apache::lonnet::removeuserfile($ENV{'user.name'}, - $ENV{'user.domain'},'portfolio'. + my $directory_name = $env{'form.currentpath'}; + $directory_name =~ s|/$||; # remove any trailing slash + my $result=&Apache::lonnet::removeuserfile($env{'user.name'}, + $env{'user.domain'},'portfolio'. $directory_name); if ($result ne 'ok') { @@ -298,22 +324,28 @@ sub delete_dir_confirmed { for (my $i=1; $i < (@dirs - 1); $i ++){ $directory_name .= $dirs[$i].'/'; } - $ENV{'form.currentpath'} = $directory_name; + $env{'form.currentpath'} = $directory_name; } $r->print(&done()); } sub rename { my ($r)=@_; - &open_form($r); - $r->print('

'.&mt('Rename').' '.&display_file().' to - ?

'); - &close_form($r); + my $file_name = $env{'form.currentpath'}.$env{'form.rename'}; + if (&Apache::lonnet::is_locked($file_name,$env{'user.domain'},$env{'user.name'}) eq 'true') { + $r->print ("The file is locked and cannot be renamed.
"); + $r->print(&done()); + } else { + &open_form($r); + $r->print('

'.&mt('Rename').' '.&display_file().' to + ?

'); + &close_form($r); + } } sub rename_confirmed { my ($r)=@_; - my $filenewname=&Apache::lonnet::clean_filename($ENV{'form.filenewname'}); + my $filenewname=&Apache::lonnet::clean_filename($env{'form.filenewname'}); if ($filenewname eq '') { $r->print(''. &mt("Error: no valid filename was provided to rename to."). @@ -322,82 +354,144 @@ sub rename_confirmed { return; } my $result= - &Apache::lonnet::renameuserfile($ENV{'user.name'},$ENV{'user.domain'}, - 'portfolio'.$ENV{'form.currentpath'}.$ENV{'form.selectfile'}, - 'portfolio'.$ENV{'form.currentpath'}.$ENV{'form.filenewname'}); + &Apache::lonnet::renameuserfile($env{'user.name'},$env{'user.domain'}, + 'portfolio'.$env{'form.currentpath'}.$env{'form.selectfile'}, + 'portfolio'.$env{'form.currentpath'}.$filenewname); if ($result ne 'ok') { $r->print(' An errror occured ('.$result. ') while trying to rename '.&display_file().' to '. &display_file(undef,$filenewname).'
'); } + if ($filenewname ne $env{'form.filenewname'}) { + $r->print("The new file name was changed from:
".$env{'form.filenewname'}." to $filenewname "); + } $r->print(&done()); } sub select_files { my ($r)=@_; - my $java_script =(< function finishSelect() { - fileList = ""; +ENDSMP + $javascript .= 'fileList = "'.$java_files.'";'; + $javascript .= (< ENDSMP - $r->print($java_script); + $r->print($javascript); $r->print("

Select portfolio files

- Check as many as you wish in response to the essay problem.
"); + Check as many as you wish in response to the problem.
"); + my @otherfiles=&Apache::lonnet::files_not_in_path($env{'user.name'}, $env{'form.currentpath'}); + if (@otherfiles) { + $r->print("Files selected from other directories:
"); + foreach my $file (@otherfiles) { + $r->print($file."
"); + } + } } sub upload { my ($r)=@_; - my $fname=$ENV{'form.uploaddoc.filename'}; - my $filesize = (length($ENV{'form.uploaddoc'})) / 1000; #express in k (1024?) + my $fname=$env{'form.uploaddoc.filename'}; + my $filesize = (length($env{'form.uploaddoc'})) / 1000; #express in k (1024?) my $disk_quota = 20000; # expressed in k $fname=&Apache::lonnet::clean_filename($fname); - my $portfolio_root = &Apache::loncommon::propath($ENV{'user.domain'}, - $ENV{'user.name'}). + my $portfolio_root = &Apache::loncommon::propath($env{'user.domain'}, + $env{'user.name'}). '/userfiles/portfolio'; # Fixme --- Move the checking for existing file to LOND error return - my @dir_list=&Apache::lonnet::dirlist($ENV{'form.currentpath'}, - $ENV{'user.domain'}, - $ENV{'user.name'},$portfolio_root); + my @dir_list=&Apache::lonnet::dirlist($env{'form.currentpath'}, + $env{'user.domain'}, + $env{'user.name'},$portfolio_root); my $found_file = 0; + my $locked_file = 0; foreach my $line (@dir_list) { - my ($filename)=split(/\&/,$line,2); - if ($filename eq $fname){ + my ($file_name)=split(/\&/,$line,2); + if ($file_name eq $fname){ $found_file = 1; + if (&Apache::lonnet::is_locked($env{'form.currentpath'}.$file_name,$env{'user.domain'},$env{'user.name'} ) eq 'true') { + $locked_file = 1; + } } } - my $current_disk_usage = &Apache::lonnet::diskusage($ENV{'user.domain'}, $ENV{'user.name'},$portfolio_root); + my $current_disk_usage = &Apache::lonnet::diskusage($env{'user.domain'}, $env{'user.name'},$portfolio_root); if (($current_disk_usage + $filesize) > $disk_quota){ - $r->print('Unable to upload '.$fname.' (size = '.$filesize.' kilobytes. Disk quota will be exceeded.'. + $r->print('Unable to upload '.$fname.' (size = '.$filesize.' kilobytes). Disk quota will be exceeded.'. '
Disk quota is '.$disk_quota.' kilobytes. Your current disk usage is '.$current_disk_usage.' kilobytes.'); + $r->print(&done('Back')); } - elsif ($found_file){ - $r->print('Unable to upload '.$fname.', a file by that name was found in '.$ENV{'form.currentpath'}.''. - '
To upload, rename or delete existing '.$fname.' in '.$ENV{'form.currentpath'}); + elsif ($found_file){ + if ($locked_file){ + $r->print('Unable to upload '.$fname.', a locked file by that name was found in portfolio'.$env{'form.currentpath'}.''. + '
You will be able to rename or delete existing '.$fname.' after a grade has been assigned.'); + $r->print(&done('Back')); + } else { + $r->print('Unable to upload '.$fname.', a file by that name was found in portfolio'.$env{'form.currentpath'}.''. + '
To upload, rename or delete existing '.$fname.' in portfolio'.$env{'form.currentpath'}); + $r->print(&done('Back')); + } } else { my $result=&Apache::lonnet::userfileupload('uploaddoc','', - 'portfolio'.$ENV{'form.currentpath'}); + 'portfolio'.$env{'form.currentpath'}); if ($result !~ m|^/uploaded/|) { $r->print(' An errror occured ('.$result. ') while trying to upload '.&display_file().'
'); + $r->print(&done('Back')); + } else { + $r->print(&done()); } } - $r->print(&done()); } - +sub lock_info { + my ($r) = @_; + my %current_permissions = &Apache::lonnet::dump('file_permissions',$env{'user.domain'},$env{'user.name'}); + my $file_name = $env{'form.lockinfo'}; + foreach my $key(keys(%current_permissions)) { + if ($file_name eq $key) { + foreach my $array_item (@{$current_permissions{$key}}) { + if (ref($array_item)) { + $r->print(''.$key.' was submitted in response to problem: '. + &Apache::lonnet::gettitle($$array_item[0]).'
'); + my %course_description = &Apache::lonnet::coursedescription($$array_item[1]); + $r->print('In the course: '.$course_description{'description'}.'
'); + # $r->print('the third is '.$$array_item[2].'
'); + # $r->print("item is $$array_item[0]
and $$array_item[0]"); + } + } + } + } + $r->print(&done('Back')); + return 'ok'; +} sub createdir { my ($r)=@_; - my $newdir=&Apache::lonnet::clean_filename($ENV{'form.newdir'}); + my $newdir=&Apache::lonnet::clean_filename($env{'form.newdir'}); if ($newdir eq '') { $r->print(''. &mt("Error: no directory name was provided."). @@ -405,12 +499,12 @@ sub createdir { $r->print(&done()); return; } - my $portfolio_root = &Apache::loncommon::propath($ENV{'user.domain'}, - $ENV{'user.name'}). + my $portfolio_root = &Apache::loncommon::propath($env{'user.domain'}, + $env{'user.name'}). '/userfiles/portfolio'; - my @dir_list=&Apache::lonnet::dirlist($ENV{'form.currentpath'}, - $ENV{'user.domain'}, - $ENV{'user.name'},$portfolio_root); + my @dir_list=&Apache::lonnet::dirlist($env{'form.currentpath'}, + $env{'user.domain'}, + $env{'user.name'},$portfolio_root); my $found_file = 0; foreach my $line (@dir_list) { my ($filename)=split(/\&/,$line,2); @@ -422,70 +516,91 @@ sub createdir { $r->print(' Unable to create a directory named '.$newdir. ' a file or directory by that name already exists.
'); } else { - my $result=&Apache::lonnet::mkdiruserfile($ENV{'user.name'}, - $ENV{'user.domain'},'portfolio'.$ENV{'form.currentpath'}.$newdir); + my $result=&Apache::lonnet::mkdiruserfile($env{'user.name'}, + $env{'user.domain'},'portfolio'.$env{'form.currentpath'}.$newdir); if ($result ne 'ok') { $r->print(' An errror occured ('.$result. ') while trying to create a new directory '.&display_file().'
'); } } + if ($newdir ne $env{'form.newdir'}) { + $r->print("The new directory name was changed from:
".$env{'form.newdir'}." to $newdir "); + } $r->print(&done()); } sub handler { # this handles file management my $r = shift; - my $portfolio_root = &Apache::loncommon::propath($ENV{'user.domain'}, - $ENV{'user.name'}). + my $portfolio_root = &Apache::loncommon::propath($env{'user.domain'}, + $env{'user.name'}). '/userfiles/portfolio'; + &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, + ['selectfile','currentpath','meta','lockinfo', + 'currentfile','action','fieldname','mode','rename','continue']); &Apache::loncommon::no_cache($r); &Apache::loncommon::content_type($r,'text/html'); $r->send_http_header; # Give the LON-CAPA page header - $r->print(''. + my $html=&Apache::lonxml::xmlbegin(); + $r->print($html.'<head><title>'. &mt('Portfolio Manager'). - "\n". - &Apache::loncommon::bodytag('Portfolio Manager')); + "\n"); + if ($env{"form.mode"} eq 'selectfile'){ + $r->print(&Apache::loncommon::bodytag('Portfolio Manager',undef,undef,1)); + } else { + $r->print(&Apache::loncommon::bodytag('Portfolio Manager')); + } $r->rflush(); - &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, - ['selectfile','currentpath', - 'currentfile','action','fieldname','mode']); - if (($ENV{'form.storeupl'} eq 'Upload') & (!$ENV{'form.uploaddoc.filename'})){ + if (($env{'form.storeupl'}) & (!$env{'form.uploaddoc.filename'})){ $r->print(' No file was selected to upload.'. 'To upload a file, click Browse...'. ', select a file, then click Upload,'); } - if ($ENV{'form.uploaddoc.filename'}) { + if ($env{'form.meta'}) { + &open_form($r); +# $r->print(&edit_meta_data($r, $env{'form.currentpath'}.$env{'form.selectfile'})); + $r->print('Edit the meta data
'); + &close_form($r); + } + if ($env{'form.store'}) { + } + + if ($env{'form.uploaddoc.filename'}) { &upload($r); - } elsif ($ENV{'form.action'} eq 'delete' && $ENV{'form.confirmed'}) { + } elsif ($env{'form.action'} eq 'delete' && $env{'form.confirmed'}) { &delete_confirmed($r); - } elsif ($ENV{'form.action'} eq 'delete') { + } elsif ($env{'form.action'} eq 'delete') { &delete($r); - } elsif ($ENV{'form.action'} eq 'deletedir' && $ENV{'form.confirmed'}) { + } elsif ($env{'form.action'} eq 'deletedir' && $env{'form.confirmed'}) { &delete_dir_confirmed($r); - } elsif ($ENV{'form.action'} eq 'deletedir'){ + } elsif ($env{'form.action'} eq 'deletedir'){ &delete_dir($r); - } elsif ($ENV{'form.action'} eq 'rename' && $ENV{'form.confirmed'}) { + } elsif ($env{'form.action'} eq 'rename' && $env{'form.confirmed'}) { &rename_confirmed($r); - } elsif ($ENV{'form.action'} eq 'rename') { + } elsif ($env{'form.rename'}) { + $env{'form.selectfile'} = $env{'form.rename'}; + $env{'form.action'} = 'rename'; &rename($r); - } elsif ($ENV{'form.createdir'}) { + } elsif ($env{'form.createdir'}) { &createdir($r); + } elsif ($env{'form.lockinfo'}) { + &lock_info($r); } else { my $current_path='/'; - if ($ENV{'form.currentpath'}) { - $current_path = $ENV{'form.currentpath'}; + if ($env{'form.currentpath'}) { + $current_path = $env{'form.currentpath'}; } my @dir_list=&Apache::lonnet::dirlist($current_path, - $ENV{'user.domain'}, - $ENV{'user.name'},$portfolio_root); + $env{'user.domain'}, + $env{'user.name'},$portfolio_root); if ($dir_list[0] eq 'no_such_dir'){ # two main reasons for this: # 1) never been here, so directory structure not created # 2) back-button navigation after deleting a directory if ($current_path eq '/'){ - &Apache::lonnet::mkdiruserfile($ENV{'user.name'}, - $ENV{'user.domain'},'portfolio'); + &Apache::lonnet::mkdiruserfile($env{'user.name'}, + $env{'user.domain'},'portfolio'); } else { # some directory that snuck in get rid of the directory # from the recent pulldown, just in case @@ -495,21 +610,16 @@ sub handler { } # now grab the directory list again, for the first time @dir_list=&Apache::lonnet::dirlist($current_path, - $ENV{'user.domain'}, - $ENV{'user.name'},$portfolio_root); + $env{'user.domain'}, + $env{'user.name'},$portfolio_root); } # need to know if directory is empty so it can be removed if desired my $is_empty=(@dir_list == 2); &display_common($r,$current_path,$is_empty,\@dir_list); - if ($ENV{"form.mode"} eq 'selectfile'){ - &select_files($r); - &display_file_select($r,$current_path,$is_empty,\@dir_list); - } else { - &display_directory($r,$current_path,$is_empty,\@dir_list); - } + &display_directory($r,$current_path,$is_empty,\@dir_list); $r->print("\n\n"); - return OK; } + return OK; } 1; __END__