--- loncom/interface/portfolio.pm 2006/07/19 21:59:10 1.121.2.8 +++ loncom/interface/portfolio.pm 2006/08/06 16:48:44 1.147 @@ -1,7 +1,7 @@ # The LearningOnline Network # portfolio browser # -# $Id: portfolio.pm,v 1.121.2.8 2006/07/19 21:59:10 albertel Exp $ +# $Id: portfolio.pm,v 1.147 2006/08/06 16:48:44 banghart Exp $ # # Copyright Michigan State University Board of Trustees # @@ -146,6 +146,28 @@ TABLE $r->print("</form>"); } +sub display_directory_line { + my ($r,$select_mode,$fullpath, $filename, $mtime, $size, $css_class, + $line, $access_controls, $curr_access, $now, $version_flag, + $href_location, $url, $current_path, $access_admin_text, $versions)=@_; + # my ($filename,$dom,undef,$testdir,undef,undef,undef,undef,$size,undef,$mtime,undef,undef,undef,$obs,undef)=split(/\&/,$line,16); + $r->print('<tr class="'.$css_class.'">'); + $r->print($line); + $r->print('<td><img alt="" src="'.&Apache::loncommon::icon($filename).'" /></td>'); + $r->print('<td>'.$$version_flag{$filename}.'</td><td><a href="'.$href_location.$filename.'">'. + $filename.'</a></td>'); + $r->print('<td>'.$size.'</td>'); + $r->print('<td>'.&Apache::lonlocal::locallocaltime($mtime).'</td>'); + if ($select_mode ne 'true') { + $r->print('<td><span style="white-space: nowrap">'. + &mt($curr_access).' '); + $r->print('<a href="'.$url.'?access='.$filename. + '&currentpath='.$current_path.&group_args(). + '">'.$access_admin_text.'</a></span></td>'); + } + $r->print('</tr>'.$/); +} + sub display_directory { my ($r,$url,$current_path,$is_empty,$dir_list,$group,$can_upload, $can_modify,$can_delete,$can_setacl)=@_; @@ -186,19 +208,20 @@ sub display_directory { if ($select_mode eq 'true') { $r->print('<form method="post" name="checkselect" action="'.$url.'">'); $r->print('<table id="LC_browser">'. - '<tr><th>Select</th><th> </th><th>Name</th><th>Size</th><th>Last Modified</th></tr>'); + '<tr><th>Select</th><th> </th><th> </th><th>Name</th><th>Size</th><th>Last Modified</th></tr>'); } else { $r->print('<form method="post" action="'.$url.'">'); $r->print('<table id="LC_browser">'. - '<tr><th colspan="2">Actions</th><th> </th><th>Name</th><th>Size</th><th>Last Modified</th><th>Current Access Status</th></tr>'); + '<tr><th colspan="2">Actions</th><th> </th><th> </th><th>Name</th><th>Size</th><th>Last Modified</th><th>Current Access Status</th></tr>'); } $r->print("\n".&group_form_data()."\n"); my $href_location="/uploaded/$udom/$uname/$port_path".$current_path; my $href_edit_location="/editupload/$udom/$uname/$port_path".$current_path; my @dir_lines; + my @version_lines; my %versioned; - foreach my $line (sort + foreach my $dir_line (sort { my ($afile)=split('&',$a,2); my ($bfile)=split('&',$b,2); @@ -206,18 +229,34 @@ sub display_directory { } (@$dir_list)) { #$strip holds directory/file name #$dom - my ($filename,$dom,undef,$testdir,undef,undef,undef,undef,$size,undef,$mtime,undef,undef,undef,$obs,undef)=split(/\&/,$line,16); + my ($filename,$dom,undef,$testdir,undef,undef,undef,undef,$size,undef,$mtime,undef,undef,undef,$obs,undef)=split(/\&/,$dir_line,16); $filename =~ s/\s+$//; my ($fname,$version,$extension) = &Apache::grades::file_name_version_ext($filename); if ($version) { - $versioned{$fname} .= $version.","; + push(@version_lines, [$filename,$dom,$testdir,$size,$mtime,$obs]); + $versioned{$fname.'.'.$extension} .= $version.","; + } else { + push(@dir_lines, [$filename,$dom,$testdir,$size,$mtime,$obs]); } - push(@dir_lines, [$filename,$dom,$testdir,$size,$mtime,$obs]); } - foreach my $line (@dir_lines) { - my ($filename,$dom,$testdir,$size,$mtime,$obs) = @$line; + foreach my $dir_line (@dir_lines) { + my ($filename,$dom,$testdir,$size,$mtime,$obs) = @$dir_line; my ($fname,$version,$extension) = &Apache::grades::file_name_version_ext($filename); if (($filename ne '.') && ($filename ne '..') && ($filename !~ /\.meta$/ ) && ($filename !~ /(.*)\.(\d+)\.([^\.]*)$/)) { + my %version_flag; + my $show_versions; + if ($env{'form.showversions'} eq $filename) { + $show_versions = 'true'; + } + if (exists($versioned{$filename})) { + if ($show_versions) { + $version_flag{$filename} = '<a href="portfolio"><img class="LC_icon" alt="'.&mt('opened folder').'" src="'.$iconpath.'folder_pointer_opened.gif" /></a>'; + } else { + $version_flag{$filename} = '<a href="portfolio?showversions='.$filename.'"><img class="LC_icon" alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_pointer_closed.gif" /></a>'; + } + } else { + $version_flag{$filename} = ' '; + } if ($dirptr&$testdir) { my $colspan='colspan="2"'; if ($select_mode eq 'true'){ @@ -225,18 +264,12 @@ sub display_directory { } $r->print('<tr class="LC_browser_folder"><td '.$colspan.'><img alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_closed.gif" /></td>'); $r->print('<td>Go to ...</td>'); - $r->print('<td>'.&make_anchor($url,$filename.'/',$current_path.$filename.'/',$env{'form.mode'},$env{"form.fieldname"},$env{'form.continue'}).'</td>'); + $r->print('<td>'.$version_flag{$filename}.'</td><td>'.&make_anchor($url,$filename.'/',$current_path.$filename.'/',$env{'form.mode'},$env{"form.fieldname"},$env{'form.continue'}).'</td>'); $r->print('</tr>'); } else { my $css_class = 'LC_browser_file'; my $line; - my $version_flag; - if (exists($versioned{$fname})) { - $version_flag = "*"; - } else { - $version_flag = ""; - } - my $fullpath = $current_path.$filename; + my $fullpath = $current_path.$filename; $fullpath = &prepend_group($fullpath); if ($select_mode eq 'true') { $line='<td><input type="checkbox" name="checkfile" value="'.$filename.'"'; @@ -258,16 +291,14 @@ sub display_directory { $line .= '<input type="checkbox" name="selectfile" value="'.$filename.'" />'; } if ($can_modify) { - my $cat='<img alt="'.&mt('Catalog Information'). + my $cat='<img class="LC_icon" alt="'.&mt('Catalog Information'). '" src="'.&Apache::loncommon::lonhttpdurl('/res/adm/pages/catalog.gif').'" />'; $line .= '<a href="'.$url.'?rename='.$filename.'&currentpath='.$current_path.&group_args().'">Rename</a>'; - $line .= '</td><td><a href="'.$href_edit_location.$filename.'.meta">'.$cat.'</a>'; + $line .= '</td><td>'.'<a href="'.$href_edit_location.$filename.'.meta">'.$cat.'</a>'; } $line .= '</td>'; } } - $r->print('<tr class="'.$css_class.'">'); - $r->print($line); my $curr_access; if ($select_mode ne 'true') { my $pub_access = 0; @@ -301,19 +332,21 @@ sub display_directory { $curr_access = join('+ ',@allaccesses); } } - $r->print('<td><img alt="" src="'.&Apache::loncommon::icon($filename).'" /></td>'); - $r->print('<td><a href="'.$href_location.$filename.'">'. - $filename.'</a></td>'); - $r->print('<td>'.$size.'</td>'); - $r->print('<td>'.&Apache::lonlocal::locallocaltime($mtime).'</td>'); - if ($select_mode ne 'true') { - $r->print('<td><span style="white-space: nowrap">'. - &mt($curr_access).' '); - $r->print('<a href="'.$url.'?access='.$filename. - '&currentpath='.$current_path.&group_args(). - '">'.$access_admin_text.'</a></span></td>'); + &display_directory_line($r,$select_mode,$fullpath, $filename, $mtime, $size, $css_class, $line, + \%access_controls, $curr_access,$now, \%version_flag, $href_location, + $url, $current_path, $access_admin_text); + if ($show_versions) { + foreach my $dir_line (@version_lines) { + my ($v_filename,$dom,$testdir,$size,$mtime,$obs) = @$dir_line; + my ($v_fname,$version,$v_extension) = &Apache::grades::file_name_version_ext($v_filename); + $line = '<td colspan="2"> </td>'; + if (($v_fname eq $fname)&&($v_extension eq $extension)) { + &display_directory_line($r,$select_mode,$fullpath, $v_filename, $mtime, $size, + $css_class, $line, \%access_controls, $curr_access, $now, + \%version_flag, $href_location, $url, $current_path, $access_admin_text, 1); + } + } } - $r->print('</tr>'.$/); } } } @@ -539,23 +572,13 @@ sub display_access { $uname); my %access_controls = &Apache::lonnet::get_access_controls($current_permissions,$group,$file_name); my $aclcount = keys(%access_controls); - my $header = '<h3>'.&mt('Allowing others to retrieve portfolio file: [_1]', - $port_path.$env{'form.currentpath'}. - $env{'form.access'}).'</h3>'; - my $info .= - &mt('Access to this file by others can be set to be one or more of the following types: public, passphrase-protected or conditional.'). - '<br /><ul><li>'. - &mt('Public files are available to anyone without the need for login.'). - '</li><li>'. - &mt('Passphrase-protected files do not require log-in, but will require the viewer to enter the passphrase you set.'). - '</li>'. - #'<li>'. - #&mt('Conditional files are accessible to logged-in users with accounts in the LON-CAPA network, who satisfy the conditions you set.'). - #'<br />'. - #&mt('The conditions can include affiliation with a particular course or group, or a user account in a specific domain.'). - #'<br />'. - #&mt('Alternatively access can be granted to people with specific LON-CAPA usernames and domains.'). - '</li></ul>'; + my $header = '<h3>'.&mt('Allowing others to retrieve file: [_1]',$port_path.$env{'form.currentpath'}.$env{'form.access'}).'</h3>'; + my $info .= &mt('Access to this file by others can be set to be one or more of the following types: public, passphrase-protected or conditional.').'<br /><ul><li>'.&mt('Public files are available to anyone without the need for login.').'</li><li>'.&mt('Passphrase-protected files do not require log-in, but will require the viewer to enter the passphrase you set.').'</li><li>'.&mt('Conditional files are accessible to logged-in users with accounts in the LON-CAPA network, who satisfy the conditions you set.').'<br />'.&mt('The conditions can include affiliation with a particular course or group, or a user account in a specific domain.').'<br />'.&mt('Alternatively access can be granted to people with specific LON-CAPA usernames and domains.').'</li></ul>'; + + if ($group eq '') { + $info .= (&mt("Direct others to the 'Display file listing' link (shown when there are viewable files) on your personal information page:<br /><a href='/adm/$udom/$uname/aboutme'>http://$ENV{'SERVER_NAME'}/adm/$udom/$uname/aboutme</a>")); + } + if ($can_setacl) { &open_form($r,$url); $r->print($header.$info); @@ -730,7 +753,7 @@ sub update_access { } } my $file_name = $env{'form.currentpath'}.$env{'form.selectfile'}; - $r->print('<h3>'.&mt('Allowing others to retrieve portfolio file: [_1]', + $r->print('<h3>'.&mt('Allowing others to retrieve file: [_1]', $port_path.$file_name).'</h3>'."\n"); $file_name = &prepend_group($file_name); my ($uname,$udom) = &get_name_dom(); @@ -996,25 +1019,24 @@ sub access_setting_table { $passwd.'" /></td>'); $r->print(&Apache::loncommon::end_data_table_row()); $r->print(&Apache::loncommon::end_data_table()); - - #$r->print('</td></tr><tr><td colspan="3"> </td></tr><tr><td valign="top">'); - #&access_element($r,'domains',\%acl_count,\@domains,$access_controls,$now,$then); - #$r->print('</td><td> </td><td valign="top">'); - #&access_element($r,'users',\%acl_count,\@users,$access_controls,$now,$then); - #$r->print('</td></tr><tr><td colspan="3"></td></tr><tr>'); - #if (@courses > 0 || @groups > 0) { - # $r->print('<td colspan="3" valign="top">'); - #} else { - # $r->print('<td valign="top">'); - #} - #&access_element($r,'course',\%acl_count,\@courses,$access_controls,$now,$then); - #$r->print('</td>'); - #if (@courses > 0 || @groups > 0) { - # $r->print('</tr><tr><td colspan="3"> </td></tr><tr><td colspan="3" valign="top">'); - #} else { - # $r->print('<td> </td><td valign="top">'); - #} - #&access_element($r,'group',\%acl_count,\@groups,$access_controls,$now,$then); + $r->print('</td></tr><tr><td colspan="3"> </td></tr><tr><td valign="top">'); + &access_element($r,'domains',\%acl_count,\@domains,$access_controls,$now,$then); + $r->print('</td><td> </td><td valign="top">'); + &access_element($r,'users',\%acl_count,\@users,$access_controls,$now,$then); + $r->print('</td></tr><tr><td colspan="3"></td></tr><tr>'); + if (@courses > 0 || @groups > 0) { + $r->print('<td colspan="3" valign="top">'); + } else { + $r->print('<td valign="top">'); + } + &access_element($r,'course',\%acl_count,\@courses,$access_controls,$now,$then); + $r->print('</td>'); + if (@courses > 0 || @groups > 0) { + $r->print('</tr><tr><td colspan="3"> </td></tr><tr><td colspan="3" valign="top">'); + } else { + $r->print('<td> </td><td valign="top">'); + } + &access_element($r,'group',\%acl_count,\@groups,$access_controls,$now,$then); $r->print('</td></tr></table>'); } @@ -1468,10 +1490,6 @@ sub upload { $file_name = $env{'form.currentpath'}.$file_name; $file_name = &prepend_group($file_name); $found_file = 1; - # FIXME I think this is incorrect, prepend_group took care of this? - if (defined($group)) { - $file_name = $group.'/'.$file_name; - } if (&Apache::lonnet::is_locked($file_name,$udom,$uname) eq 'true') { $locked_file = 1; } @@ -1712,8 +1730,8 @@ sub handler { &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, ['selectfile','currentpath','meta','lockinfo','currentfile','action', 'fieldname','mode','rename','continue','group','access','setnum', - 'cnum','cdom','type','setroles']); - my ($uname,$udom,$portfolio_root,$url,$group,$caller,$title,$grp_desc); + 'cnum','cdom','type','setroles','showversions','ref']); + my ($uname,$udom,$portfolio_root,$url,$caller,$title,$group,$grp_desc); if ($r->uri =~ m|^(/adm/)([^/]+)|) { $url = $1.$2; $caller = $2;