--- loncom/interface/portfolio.pm 2008/04/16 23:11:06 1.191 +++ loncom/interface/portfolio.pm 2008/11/28 16:10:20 1.197 @@ -1,7 +1,7 @@ # The LearningOnline Network # portfolio browser # -# $Id: portfolio.pm,v 1.191 2008/04/16 23:11:06 raeburn Exp $ +# $Id: portfolio.pm,v 1.197 2008/11/28 16:10:20 bisitz Exp $ # # Copyright Michigan State University Board of Trustees # @@ -93,7 +93,9 @@ sub display_common { 'Upload file to current directory:', 'createdir' => 'Create Subdirectory', 'createdir_label' => - 'Create subdirectory in current directory:'); + 'Create subdirectory in current directory:', + 'parse' => 'If HTML file, upload embedded images/multimedia/css/linked files' + ); my $escuri = &HTML::Entities::encode($r->uri,'&<>"'); my $help_fileupload = &Apache::loncommon::help_open_topic('Portfolio AddFiles'); my $help_createdir = &Apache::loncommon::help_open_topic('Portfolio CreateDirectory'); @@ -101,6 +103,17 @@ sub display_common { # FIXME: This line should be deleted once Portfolio uses breadcrumbs $r->print(&Apache::loncommon::help_open_topic('Portfolio About', &mt('Help on the portfolio'))); + my $parse_check; + if (!&suppress_embed_prompt()) { + $parse_check = <<"END"; + <br /> + <span class="LC_nobreak"> + <label>$text{'parse'} + <input type="checkbox" name="parserflag" checked="checked" /> + </label> + </span> +END + } $r->print(<<"TABLE"); <table id="LC_portfolio_actions"> <tr id="LC_portfolio_upload"> @@ -115,7 +128,9 @@ sub display_common { <input type="hidden" name="action" value="$env{"form.action"}" /> <input type="hidden" name="fieldname" value="$env{"form.fieldname"}" /> <input type="hidden" name="mode" value="$env{"form.mode"}" /> - <input type="submit" name="storeupl" value="$text{'upload'}" />$help_fileupload + <input type="submit" name="storeupl" value="$text{'upload'}" /> +$help_fileupload +$parse_check </form> </td> </tr> @@ -176,7 +191,7 @@ sub display_directory_line { $href_location, $url, $current_path, $access_admin_text, $versions)=@_; my $fullpath = &prepend_group($current_path.$filename); - $r->print('<tr class="'.$css_class.'">'); + $r->print(&Apache::loncommon::start_data_table_row()); $r->print($line); # contains first two cells of table my $lock_info; if ($version_flag) { # versioned can't be versioned, so TRUE when root file @@ -212,15 +227,19 @@ sub display_directory_line { $r->print('<td>'.$size.'</td>'); $r->print('<td>'.&Apache::lonlocal::locallocaltime($mtime).'</td>'); if ($select_mode ne 'true') { - $r->print('<td><span style="white-space: nowrap">'. - &mt($curr_access).' '); + $r->print('<td class="'.$css_class.'"> </td>'); # Display status + $r->print('<td><span class="LC_nobreak">' + .&mt($curr_access).' ' + ); my %anchor_fields = ( 'access' => $filename, 'currentpath' => $current_path ); $r->print(&make_anchor($url, \%anchor_fields, $access_admin_text).'</span></td>'); + } else { + $r->print('<td class="'.$css_class.'"> </td>'); # Display status } - $r->print('</tr>'.$/); + $r->print(&Apache::loncommon::end_data_table_row().$/); } sub display_directory { @@ -262,21 +281,30 @@ sub display_directory { } if ($select_mode eq 'true') { $r->print('<form method="post" name="checkselect" action="'.$url.'">'); - $r->print('<table id="LC_browser">'. - '<tr><th>Select</th><th> </th><th> </th><th>Name</th><th>Size</th><th>Last Modified</th></tr>'); + $r->print(&Apache::loncommon::start_data_table() + .&Apache::loncommon::start_data_table_header_row() + .'<th>'.&mt('Select').'</th>' + .'<th> </th><th> </th>' + .'<th>'.&mt('Name').'</th>' + .'<th>'.&mt('Size').'</th>' + .'<th>'.&mt('Last Modified').'</th>' + .'<th> </th>' + .&Apache::loncommon::end_data_table_header_row() + ); } else { $r->print('<form method="post" action="'.$url.'">'); $r->print(&Apache::loncommon::help_open_topic('Portfolio FileList', &mt('Using the portfolio file list'))); - $r->print('<table id="LC_browser">'. - '<tr>' + $r->print(&Apache::loncommon::start_data_table() + .&Apache::loncommon::start_data_table_header_row() .'<th colspan="2">'.&mt('Actions'). &Apache::loncommon::help_open_topic('Portfolio FileAction').'</th>' .'<th> </th><th> </th>' .'<th>'.&mt('Name').&Apache::loncommon::help_open_topic('Portfolio OpenFile').'</th>' .'<th>'.&mt('Size').'</th>' .'<th>'.&mt('Last Modified').'</th>' + .'<th> </th>' .'<th>'.&mt('Current Access Status').&Apache::loncommon::help_open_topic('Portfolio ShareFile').'</th>' - .'</tr>'); + .&Apache::loncommon::end_data_table_header_row()); } $r->print("\n".&group_form_data()."\n"); @@ -334,12 +362,17 @@ sub display_directory { $version_flag = ' '; } if ($dirptr&$testdir) { - my $colspan='colspan="2"'; + my $colspan_folder=''; + my $colspan_fill=''; if ($select_mode eq 'true'){ - undef($colspan); + $colspan_fill=' colspan="3"'; + } else { + $colspan_folder=' colspan="2"'; + $colspan_fill=' colspan="4"'; } - $r->print('<tr class="LC_browser_folder"><td '.$colspan.'><img alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_closed.gif" /></td>'); - $r->print('<td>'.&mt('Go to ...').'</td>'); + $r->print('<tr class="LC_browser_folder">'); + $r->print('<td'.$colspan_folder.'><img alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_closed.gif" /></td>' + .'<td>'.&mt('Go to ...').'</td>'); my %anchor_fields = ( 'selectfile' => $filename.'/', 'currentpath' => $current_path.$filename.'/', @@ -347,7 +380,9 @@ sub display_directory { 'fieldname' => $env{"form.fieldname"}, 'continue' => $env{"form.continue"} ); - $r->print('<td>'.$version_flag.'</td><td>'.&make_anchor($url,\%anchor_fields,$filename.'/').'</td>'); + $r->print('<td>'.$version_flag.'</td>' + .'<td>'.&make_anchor($url,\%anchor_fields,$filename.'/').'</td>'); + $r->print('<td'.$colspan_fill.'> </td>'); $r->print('</tr>'); } else { my $css_class = 'LC_browser_file'; @@ -355,7 +390,7 @@ sub display_directory { if ($select_mode eq 'true') { $line='<td><input type="checkbox" name="checkfile" value="'.$filename.'"'; if ($$checked_files{$filename} eq 'selected') { - $line.=" checked "; + $line.=' checked="checked" '; } $line.=' /></td>'; } else { @@ -438,7 +473,7 @@ sub display_directory { } } if ($select_mode eq 'true') { - $r->print('</table> + $r->print(&Apache::loncommon::end_data_table().' <input type="hidden" name="continue" value="true" /> <input type="hidden" name="fieldname" value="'.$env{'form.fieldname'}.'" /> <input type="hidden" name="mode" value="selectfile" /> @@ -447,10 +482,10 @@ sub display_directory { <input type="hidden" name="currentpath" value="'.$current_path.'" /> </form>'); } else { - $r->print('</table>'); + $r->print(&Apache::loncommon::end_data_table()); if ($can_delete) { $r->print(' - <input type="submit" name="doit" value="'.&mt('Delete Checked Files').'" />'. + <input type="submit" name="doit" value="'.&mt('Delete Selected').'" />'. &Apache::loncommon::help_open_topic('Portfolio DeleteFile').' <input type="hidden" name="action" value="delete" /> <input type="hidden" name="currentpath" value="'.$current_path.'" /> @@ -1801,10 +1836,17 @@ sub check_for_upload { sub upload { my ($r,$url,$group)=@_; my $fname=&Apache::lonnet::clean_filename($env{'form.uploaddoc.filename'}); - - my ($state,$msg) = &check_for_upload($env{'form.currentpath'}, - $fname,$group,'uploaddoc'); - + my $disk_quota = &get_quota($group); + my $portfolio_root = &get_portfolio_root(); + my $port_path = &get_port_path(); + my ($uname,$udom) = &get_name_dom($group); + my $getpropath = 1; + my $current_disk_usage = &Apache::lonnet::diskusage($udom,$uname,$portfolio_root,$getpropath); + my ($state,$msg) = + &Apache::loncommon::check_for_upload($env{'form.currentpath'},$fname, + $group,'uploaddoc',$portfolio_root, + $port_path,$disk_quota, + $current_disk_usage,$uname,$udom); if ($state eq 'will_exceed_quota' || $state eq 'file_locked' || $state eq 'file_exists' ) { @@ -1812,11 +1854,11 @@ sub upload { return; } - my $port_path = &get_port_path(); my (%allfiles,%codebase,$mode); if ($env{'form.uploaddoc.filename'} =~ m/(\.htm|\.html|\.shtml)$/i) { - $mode = 'parse'; - + if ($env{'form.parserflag'}) { + $mode = 'parse'; + } } my $result= &Apache::lonnet::userfileupload('uploaddoc','', @@ -1828,73 +1870,27 @@ sub upload { $r->print(&done('Back',$url)); } else { if (%allfiles) { - my $state = <<STATE; + if (!&suppress_embed_prompt()) { + my $state = <<STATE; <input type="hidden" name="action" value="upload_embedded" /> <input type="hidden" name="currentpath" value="$env{'form.currentpath'}" /> <input type="hidden" name="fieldname" value="$env{'form.fieldname'}" /> <input type="hidden" name="mode" value="$env{'form.mode'}" /> STATE - $r->print("<h2>".&mt("Reference Warning")."</h2>"); - $r->print("<p>".&mt("Completed upload of the file. This file contained references to other files. You must upload the referenced files or else the uploaded file may not work properly.")."</p>"); - $r->print("<p>".&mt("Please select the locations from which the referenced files are to be uploaded.")."</p>"); - $r->print(&Apache::londocs::ask_for_embedded_content('/adm/portfolio',$state,\%allfiles,\%codebase, + $r->print("<h2>".&mt("Reference Warning")."</h2>"); + $r->print("<p>".&mt("Completed upload of the file. This file contained references to other files. You must upload the referenced files or else the uploaded file may not work properly.")."</p>"); + $r->print("<p>".&mt("Please select the locations from which the referenced files are to be uploaded.")."</p>"); + $r->print(&Apache::loncommon::ask_for_embedded_content('/adm/portfolio',$state,\%allfiles,\%codebase, {'error_on_invalid_names' => 1, 'ignore_remote_references' => 1,})); - $r->print('<p>Or '.&done('Return to directory',$url).'</p>'); + $r->print('<p>Or '.&done('Return to directory',$url).'</p>'); + } } else { $r->print(&done(undef,$url)); } } } -sub upload_embedded { - my ($r,$url,$group)=@_; - for (my $i=0; $i<$env{'form.number_embedded_items'}; $i++) { - next if (!exists($env{'form.embedded_item_'.$i.'.filename'})); - my $orig_uploaded_filename = - $env{'form.embedded_item_'.$i.'.filename'}; - - $env{'form.embedded_orig_'.$i} = - &unescape($env{'form.embedded_orig_'.$i}); - my ($path,$fname) = - ($env{'form.embedded_orig_'.$i} =~ m{(.*/)([^/]*)}); - # no path, whole string is fname - if (!$fname) { $fname = $env{'form.embedded_orig_'.$i} }; - - $path = $env{'form.currentpath'}.$path; - $fname = &Apache::lonnet::clean_filename($fname); - - my ($state,$msg) = &check_for_upload($path,$fname,$group, - 'embedded_item_'.$i); - - if ($state eq 'will_exceed_quota' - || $state eq 'file_locked' - || $state eq 'file_exists' ) { - $r->print($msg); - next; - } - - my $port_path = &get_port_path(); - my $src_path = $env{'form.embedded_orig_'.$i}; - $env{'form.embedded_item_'.$i.'.filename'}=$fname; - - my $result= - &Apache::lonnet::userfileupload('embedded_item_'.$i,'', - $port_path.$path); - if ($result !~ m|^/uploaded/|) { - $r->print('<span class="LC_error">' - .&mt('An error occurred ([_1]) while trying to upload [_2] for embedded element [_3].' - ,$result,$orig_uploaded_filename,$env{'form.embedded_orig_'.$i}) - .'</span><br />'); - next; - } else { - $r->print("<p> Uploaded ". - &display_file($port_path.$path,$fname).'</p>'); - } - } - $r->print(&done(undef,$url)); -} - sub lock_info { my ($r,$url,$group) = @_; my ($uname,$udom) = &get_name_dom($group); @@ -2134,6 +2130,17 @@ sub get_quota { return $disk_quota; } +sub suppress_embed_prompt { + my $suppress_prompt = 0; + if (($env{'request.role'} =~ /^st/) && ($env{'request.course.id'} ne '')) { + if ($env{'course.'.$env{'request.course.id'}.'.suppress_embed_prompt'} eq 'yes') { + $suppress_prompt = 1; + } + } + return $suppress_prompt; +} + + sub handler { # this handles file management my $r = shift; @@ -2258,7 +2265,14 @@ sub handler { } } elsif ($env{'form.action'} eq 'upload_embedded') { if ($can_upload) { - &upload_embedded($r,$url,$group); + my $disk_quota = &get_quota($group); + my $getpropath = 1; + my $current_disk_usage = + &Apache::lonnet::diskusage($udom,$uname,$portfolio_root,$getpropath); + $r->print( + &Apache::loncommon::upload_embedded('portfolio',$port_path,$uname,$udom, + $group,$portfolio_root,$group,$disk_quota,$current_disk_usage)); + $r->print(&done(undef,$url)); } else { &missing_priv($r,$url,'upload'); } @@ -2336,7 +2350,7 @@ sub handler { &Apache::lonhtmlcommon::clear_breadcrumbs(); $r->print(&coursegrp_portfolio_header($udom,$uname,$grp_desc)); } - my @dir_list=&get_dir_list($portfolio_root,undef,$group); + my @dir_list=&get_dir_list($portfolio_root,$current_path,$group); if ($dir_list[0] eq 'no_such_dir'){ # two main reasons for this: # 1) never been here, so directory structure not created @@ -2352,9 +2366,7 @@ sub handler { $current_path = '/'; # force it back to the root } # now grab the directory list again, for the first time - @dir_list= - &Apache::lonnet::dirlist($portfolio_root.$current_path, - $udom,$uname,$getpropath); + @dir_list=&get_dir_list($portfolio_root,$current_path,$group); } # need to know if directory is empty so it can be removed if desired my $is_empty=(@dir_list == 2);