--- loncom/interface/portfolio.pm	2008/06/16 23:34:12	1.195
+++ loncom/interface/portfolio.pm	2008/11/28 18:18:39	1.199
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.195 2008/06/16 23:34:12 raeburn Exp $
+# $Id: portfolio.pm,v 1.199 2008/11/28 18:18:39 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -87,13 +87,12 @@ sub display_common {
         my $groupitem = &group_form_data();
 
         my $iconpath= $r->dir_config('lonIconsURL') . "/";
-        my %text=&Apache::lonlocal::texthash(
+        my %lt=&Apache::lonlocal::texthash(
 					 'upload' => 'Upload',
-					 'upload_label' =>  
-					 'Upload file to current directory:',
+					 'upload_label' => 'Upload file to current directory',
 					 'createdir' => 'Create Subdirectory',
 					 'createdir_label' => 
-					 'Create subdirectory in current directory:',
+					 'Create subdirectory in current directory',
                                          'parse' => 'If HTML file, upload embedded images/multimedia/css/linked files'
                                             );
         my $escuri = &HTML::Entities::encode($r->uri,'&<>"');
@@ -108,50 +107,51 @@ sub display_common {
             $parse_check = <<"END";
         <br />
         <span class="LC_nobreak">
-         <label>$text{'parse'}
+         <label>$lt{'parse'}
          <input type="checkbox" name="parserflag" checked="checked" />
          </label>
         </span>
 END
         }
-        $r->print(<<"TABLE"); 
-<table id="LC_portfolio_actions">
-  <tr id="LC_portfolio_upload">
-    <td class="LC_label">
-      $text{'upload_label'}
-    </td>
-    <td class="LC_value">
-      <form method="post" enctype="multipart/form-data" action="$escuri">
-        $groupitem 
-        <input name="uploaddoc" type="file" />
-	<input type="hidden" name="currentpath" value="$current_path" />
-	<input type="hidden" name="action" value="$env{"form.action"}" />
-	<input type="hidden" name="fieldname" value="$env{"form.fieldname"}" />
-	<input type="hidden" name="mode" value="$env{"form.mode"}" />
-	<input type="submit" name="storeupl" value="$text{'upload'}" />
-$help_fileupload
-$parse_check
-      </form>
-    </td>
-  </tr>
-  <tr id="LC_portfolio_createdir">
-    <td class="LC_label">
-      $text{'createdir_label'}
-    </td>
-    <td class="LC_value">
-      <form method="post" action="$escuri">
-        <input name="newdir" type="input" />$groupitem
-        <input type="hidden" name="currentpath" value="$current_path" />
-        <input type="hidden" name="action" value="$env{"form.action"}" />
-        <input type="hidden" name="fieldname" value="$env{"form.fieldname"}" />
-        <input type="hidden" name="mode" value="$env{"form.mode"}" />
-        <input type="submit" name="createdir" value="$text{'createdir'}" />$help_createdir
-      </form>
-    </td>
-  </tr>
-</table>
-TABLE
-    }
+
+        $r->print('<div>');
+        # Upload File
+        $r->print('<div class="LC_left_float">'
+                 .'<form method="post" enctype="multipart/form-data" action="'.$escuri.'">'
+                 .'<fieldset>'
+                 .'<legend>'.$lt{'upload_label'}.'</legend>'
+                 .$groupitem 
+                 .'<input name="uploaddoc" type="file" />'
+                 .'<input type="hidden" name="currentpath" value="'.$current_path.'" />'
+                 .'<input type="hidden" name="action" value="'.$env{"form.action"}.'" />'
+                 .'<input type="hidden" name="fieldname" value="'.$env{"form.fieldname"}.'" />'
+                 .'<input type="hidden" name="mode" value="'.$env{"form.mode"}.'" />'
+                 .'<input type="submit" name="storeupl" value="'.$lt{'upload'}.'" />'
+                 .$help_fileupload
+                 .$parse_check
+                 .'</fieldset>'
+                 .'</form>'
+                 .'</div>'
+        );
+        # Create Subdirectory
+        $r->print('<div class="LC_left_float">'
+                 .'<form method="post" action="'.$escuri.'">'
+                 .'<fieldset>'
+                 .'<legend>'.$lt{'createdir_label'}.'</legend>'
+                 .'<input name="newdir" type="input" />'.$groupitem
+                 .'<input type="hidden" name="currentpath" value="'.$current_path.'" />'
+                 .'<input type="hidden" name="action" value="'.$env{"form.action"}.'" />'
+                 .'<input type="hidden" name="fieldname" value="'.$env{"form.fieldname"}.'" />'
+                 .'<input type="hidden" name="mode" value="'.$env{"form.mode"}.'" />'
+                 .'<input type="submit" name="createdir" value="'.$lt{'createdir'}.'" />'
+                 .$help_createdir
+                 .'</fieldset>'
+                 .'</form>'
+                 .'</div>'
+        );
+        $r->print('</div>');
+    } # end "if can_upload"
+
     my @tree = split (/\//,$current_path);
     my %anchor_fields = (
         'selectfile'    => $port_path,
@@ -191,7 +191,7 @@ sub display_directory_line {
 	$href_location, $url, $current_path, $access_admin_text, $versions)=@_;
 
     my $fullpath =  &prepend_group($current_path.$filename);
-    $r->print('<tr class="'.$css_class.'">');
+    $r->print(&Apache::loncommon::start_data_table_row());
     $r->print($line); # contains first two cells of table
     my $lock_info;
     if ($version_flag) { # versioned can't be versioned, so TRUE when root file
@@ -227,15 +227,19 @@ sub display_directory_line {
     $r->print('<td>'.$size.'</td>');
     $r->print('<td>'.&Apache::lonlocal::locallocaltime($mtime).'</td>');
     if ($select_mode ne 'true') {
-	$r->print('<td><span style="white-space: nowrap">'.
-		  &mt($curr_access).'&nbsp;&nbsp;&nbsp;');
+        $r->print('<td class="'.$css_class.'">&nbsp;&nbsp;</td>'); # Display status
+        $r->print('<td><span class="LC_nobreak">'
+                 .&mt($curr_access).'&nbsp;&nbsp;&nbsp;'
+       );
         my %anchor_fields = (
             'access' => $filename,
             'currentpath' => $current_path
         );
 	$r->print(&make_anchor($url, \%anchor_fields, $access_admin_text).'</span></td>');
+    } else {
+        $r->print('<td class="'.$css_class.'">&nbsp;&nbsp;</td>'); # Display status
     }
-    $r->print('</tr>'.$/);
+    $r->print(&Apache::loncommon::end_data_table_row().$/);
 }
 
 sub display_directory {
@@ -267,7 +271,9 @@ sub display_directory {
         $display_out = '<form method="post" action="'.$url.'">'.
 	    &group_form_data().
         '<input type="hidden" name="action" value="deletedir" />'.
+        '<p>'.
         '<input type="submit" name="deletedir" value="'.&mt("Delete Directory").'" />'.
+        '</p>'.
         '<input type="hidden" name="selectfile" value="" />'.
         '<input type="hidden" name="currentpath" value="'.$current_path.'" />'.
         '</form>';
@@ -277,21 +283,30 @@ sub display_directory {
     }
     if ($select_mode eq 'true') {
         $r->print('<form method="post" name="checkselect" action="'.$url.'">');
-        $r->print('<table id="LC_browser">'.
-            '<tr><th>Select</th><th>&nbsp;</th><th>&nbsp;</th><th>Name</th><th>Size</th><th>Last Modified</th></tr>');
+        $r->print(&Apache::loncommon::start_data_table()
+                 .&Apache::loncommon::start_data_table_header_row()
+                 .'<th>'.&mt('Select').'</th>'
+                 .'<th>&nbsp;</th><th>&nbsp;</th>'
+                 .'<th>'.&mt('Name').'</th>'
+                 .'<th>'.&mt('Size').'</th>'
+                 .'<th>'.&mt('Last Modified').'</th>'
+                 .'<th>&nbsp;</th>'
+                 .&Apache::loncommon::end_data_table_header_row()
+        );
     } else {
         $r->print('<form method="post" action="'.$url.'">');
 	$r->print(&Apache::loncommon::help_open_topic('Portfolio FileList',
 						      &mt('Using the portfolio file list')));
-        $r->print('<table id="LC_browser">'.
-                  '<tr>'
+        $r->print(&Apache::loncommon::start_data_table()
+                 .&Apache::loncommon::start_data_table_header_row()
                  .'<th colspan="2">'.&mt('Actions'). &Apache::loncommon::help_open_topic('Portfolio FileAction').'</th>'
                  .'<th>&nbsp;</th><th>&nbsp;</th>'
                  .'<th>'.&mt('Name').&Apache::loncommon::help_open_topic('Portfolio OpenFile').'</th>'
                  .'<th>'.&mt('Size').'</th>'
                  .'<th>'.&mt('Last Modified').'</th>'
+                 .'<th>&nbsp;</th>'
                  .'<th>'.&mt('Current Access Status').&Apache::loncommon::help_open_topic('Portfolio ShareFile').'</th>'
-                 .'</tr>');
+                 .&Apache::loncommon::end_data_table_header_row());
     }
     $r->print("\n".&group_form_data()."\n");
 
@@ -349,12 +364,17 @@ sub display_directory {
     	        $version_flag = '&nbsp;';
     	    }
             if ($dirptr&$testdir) {
-		my $colspan='colspan="2"';
+		my $colspan_folder='';
+		my $colspan_fill='';
                 if ($select_mode eq 'true'){
-		    undef($colspan);
+                    $colspan_fill=' colspan="3"';
+                } else {
+                    $colspan_folder=' colspan="2"';
+                    $colspan_fill=' colspan="4"';
                 }
-		$r->print('<tr class="LC_browser_folder"><td '.$colspan.'><img alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_closed.gif" /></td>');
-                $r->print('<td>'.&mt('Go to ...').'</td>');
+		$r->print('<tr class="LC_browser_folder">');
+                $r->print('<td'.$colspan_folder.'><img alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_closed.gif" /></td>'
+                         .'<td>'.&mt('Go to ...').'</td>');
                 my %anchor_fields = (
                     'selectfile'    => $filename.'/',
                     'currentpath'   => $current_path.$filename.'/',
@@ -362,7 +382,9 @@ sub display_directory {
                     'fieldname'     => $env{"form.fieldname"},
                     'continue'      => $env{"form.continue"}
                 );  
-                $r->print('<td>'.$version_flag.'</td><td>'.&make_anchor($url,\%anchor_fields,$filename.'/').'</td>'); 
+                $r->print('<td>'.$version_flag.'</td>'
+                         .'<td>'.&make_anchor($url,\%anchor_fields,$filename.'/').'</td>'); 
+                $r->print('<td'.$colspan_fill.'>&nbsp;</td>');
                 $r->print('</tr>'); 
             } else {
 		my $css_class = 'LC_browser_file';
@@ -370,7 +392,7 @@ sub display_directory {
                 if ($select_mode eq 'true') {
                     $line='<td><input type="checkbox" name="checkfile" value="'.$filename.'"';
 		    if ($$checked_files{$filename} eq 'selected') {
-                        $line.=" checked ";
+                        $line.=' checked="checked" ';
                     }
 		    $line.=' /></td>';
                 } else {
@@ -453,20 +475,24 @@ sub display_directory {
         }
     }
     if ($select_mode eq 'true') {
-        $r->print('</table>
+        $r->print(&Apache::loncommon::end_data_table().'
             <input type="hidden" name="continue" value="true" />
             <input type="hidden" name="fieldname" value="'.$env{'form.fieldname'}.'" />
             <input type="hidden" name="mode" value="selectfile" />
-            <input type="submit" name="submit" value="Select checked files, and continue selecting." /><br />
-            <input type="button" name="doit" onClick= "finishSelect();" value="Select checked files, and close window" />
+            <p>
+            <input type="submit" name="submit" value="'.&mt('Select checked files, and continue selecting').'" /><br />
+            <input type="button" name="doit" onClick= "finishSelect();" value="'.&mt('Select checked files, and close window').'" />
+            </p>
             <input type="hidden" name="currentpath" value="'.$current_path.'" />
         </form>');        
     } else {
-        $r->print('</table>');
+        $r->print(&Apache::loncommon::end_data_table());
         if ($can_delete) {
             $r->print('
-        <input type="submit" name="doit" value="'.&mt('Delete Checked Files').'" />'.
+        <p>
+        <input type="submit" name="doit" value="'.&mt('Delete Selected').'" />'.
 	&Apache::loncommon::help_open_topic('Portfolio DeleteFile').'
+        </p>
         <input type="hidden" name="action" value="delete" />
         <input type="hidden" name="currentpath" value="'.$current_path.'" />
         </form>'
@@ -1753,15 +1779,28 @@ ENDSMP
         </script>
 ENDSMP
     $r->print($javascript);
-    $r->print("<h1>".&mt('Select portfolio files')."</h1>".
-                &mt('Check as many as you wish in response to the problem.')."<br />");
+    $r->print("<h1>".&mt('Select portfolio files')."</h1>");
     my @otherfiles=&Apache::lonnet::files_not_in_path($env{'user.name'}, $env{'form.currentpath'});
     if (@otherfiles) {
-	$r->print("<strong>".&mt('Files selected from other directories:')."</strong><br />");
+	$r->print(&Apache::loncommon::start_data_table()
+                 .&Apache::loncommon::start_data_table_header_row()
+                 .'<th>'.&mt('Files selected from other directories:')."</th>"
+                 .&Apache::loncommon::end_data_table_header_row()
+        );
 	foreach my $file (@otherfiles) {
-	    $r->print($file."<br />");
+	    $r->print(&Apache::loncommon::start_data_table_row()
+                     .'<td>'.$file."</td>"
+                     .&Apache::loncommon::end_data_table_row()
+            );
 	}
+        $r->print(&Apache::loncommon::end_data_table()
+                 .'<br />'
+        );
     }
+    $r->print('<div>'
+             .&mt('Check as many files as you wish in response to the problem:')
+             .'</div>'
+    );
 }