--- loncom/interface/slotrequest.pm	2013/05/21 18:54:15	1.118
+++ loncom/interface/slotrequest.pm	2019/06/24 03:23:36	1.125.2.3.4.1
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler for requesting to have slots added to a students record
 #
-# $Id: slotrequest.pm,v 1.118 2013/05/21 18:54:15 raeburn Exp $
+# $Id: slotrequest.pm,v 1.125.2.3.4.1 2019/06/24 03:23:36 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -37,7 +37,7 @@ use Apache::lonnet;
 use Apache::lonnavmaps();
 use Date::Manip;
 use lib '/home/httpd/lib/perl/';
-use LONCAPA;
+use LONCAPA qw(:DEFAULT :match);
 
 sub fail {
     my ($r,$code)=@_;
@@ -56,12 +56,22 @@ sub fail {
 }
 
 sub start_page {
-    my ($r,$title,$brcrum)=@_;
+    my ($r,$title,$brcrum,$js)=@_;
     my $args;
     if (ref($brcrum) eq 'ARRAY') {
         $args = {bread_crumbs => $brcrum};
     }
-    $r->print(&Apache::loncommon::start_page($title,undef,$args));
+    if (($env{'form.requestattempt'}) || ($env{'form.command'} eq 'manageresv')) {
+        my %loaditems = (
+                           onload => 'javascript:uncheckSlotRadio();',
+                        );
+        if (ref($args) eq 'HASH') {
+            $args->{'add_entries'} = \%loaditems;
+        } else {
+            $args = { 'add_entries' => \%loaditems };
+        }
+    }
+    $r->print(&Apache::loncommon::start_page($title,$js,$args));
 }
 
 sub end_page {
@@ -69,6 +79,194 @@ sub end_page {
     $r->print(&Apache::loncommon::end_page());
 }
 
+sub reservation_js {
+    my ($slots,$consumed_uniqueperiods,$available,$got_slots,$symb) = @_;
+    return unless ((ref($slots) eq 'HASH') && (ref($available) eq 'ARRAY'));
+    my $toskip;
+    if ($symb eq '') {
+        $toskip = { symb => 1, };
+    }
+    my ($i,$j) = (0,0);
+    my $js;
+    foreach my $slot (sort
+        { return $slots->{$a}->{'starttime'} <=> $slots->{$b}->{'starttime'} }
+                    (keys(%{$slots})))  {
+
+        next if (!&allowed_slot($slot,$slots->{$slot},$symb,$slots,
+                                $consumed_uniqueperiods,$toskip));
+        $js .= "    slotstart[$i]='$slots->{$slot}->{'starttime'}';\n".
+               "    slotend[$i]='$slots->{$slot}->{'endtime'}';\n".
+               "    slotname[$i]='$slot';\n";
+        if (($symb) && (ref($got_slots) eq 'ARRAY')) {
+            if (grep(/^\Q$slot\E$/,@{$got_slots})) {
+                $js .= "    currslot[$j]='$slot';\n";
+                $j++;
+            }
+        }
+        $i++;
+        push(@{$available},$slot);
+    }
+    if ($j) {
+        $js = "    var currslot = new Array($j);\n\n$js";
+    }
+    my %alerts = &Apache::lonlocal::texthash (
+                                                none    => 'No reservable time slots found',
+                                                invalid => 'Invalid date format',
+                                             );
+    return <<"ENDSCRIPT";
+<script type="text/javascript">
+// <![CDATA[
+function updateSlotDisplay(form,num,slotpickradio) {
+    var slotstart = new Array($i);
+    var slotend = new Array($i);
+    var slotname = new Array($i);
+$js
+
+    if (slotpickradio == 'all') {
+        for (var i=0; i<$i; i++) {
+            if (document.getElementById('LC_slotrow_'+num+'_'+slotname[i])) {
+                document.getElementById('LC_slotrow_'+num+'_'+slotname[i]).style.display = '';
+            }
+            if (document.getElementById('LC_slotsearch_'+num)) {
+                document.getElementById('LC_slotsearch_'+num).style.display = 'block';
+            }
+        }
+    } else {
+        if (slotpickradio == 'show') {
+            for (var i=0; i<$i; i++) {
+                if (document.getElementById('LC_slotrow_'+num+'_'+slotname[i])) {
+                    document.getElementById('LC_slotrow_'+num+'_'+slotname[i]).style.display = 'none';
+                }
+            }
+            for (var j=0; j<$j; j++) {
+                if (document.getElementById('LC_slotrow_'+num+'_'+currslot[j])) {
+                    document.getElementById('LC_slotrow_'+num+'_'+currslot[j]).style.display = '';
+                }
+            }
+            if (document.getElementById('LC_slotsearch_'+num)) {
+                document.getElementById('LC_slotsearch_'+num).style.display = 'block';
+            }
+        } else {
+            var numberRegExp = /^[0-9]+\$/;
+            var startm = form.start_month.options[form.start_month.selectedIndex].value;
+            var startd = form.start_day.value;
+            startd=startd.trim();
+            var starty = form.start_year.value;
+            starty=starty.trim();
+            var endm = form.end_month.options[form.end_month.selectedIndex].value;
+            var endd = form.end_day.value;
+            endd=endd.trim();
+            var endy = form.end_year.value;
+            endy=endy.trim();
+            if (numberRegExp.test(endd) && numberRegExp.test(endy) && numberRegExp.test(startd) && numberRegExp.test(starty)) {
+                var startdate = startm+"/"+startd+"/"+starty;
+                var starttime = new Date(startdate).getTime();
+                starttime = starttime/1000;
+                var starth = form.start_hour.options[form.start_hour.selectedIndex].value;
+                if (numberRegExp.test(starth)) {
+                    starth = parseInt(starth);
+                    if (starth > 0 && starth <= 23) {
+                        starttime += 3600 * starth;
+                    }
+                }
+                var enddate = endm+"/"+endd+"/"+endy;
+                var endtime = new Date(enddate).getTime();
+                endtime = endtime/1000;
+                var endh = form.end_hour.options[form.end_hour.selectedIndex].value;
+                if (numberRegExp.test(endh)) {
+                    endh = parseInt(endh);
+                    if (endh > 0 && endh <= 23) {
+                        endtime += 3600 * endh;
+                    }
+                }
+
+                var shown = 0;
+                for (var i=0; i<$i; i++) {
+                    if ((slotstart[i] >= starttime) && (slotend[i] <= endtime)) {
+                        if (document.getElementById('LC_slotrow_'+num+'_'+slotname[i])) {
+                            document.getElementById('LC_slotrow_'+num+'_'+slotname[i]).style.display = '';
+                            shown ++;
+                        }
+                    } else {
+                        if (document.getElementById('LC_slotrow_'+num+'_'+slotname[i])) {
+                            document.getElementById('LC_slotrow_'+num+'_'+slotname[i]).style.display = 'none';
+                        }
+                    }
+                }
+                if (document.getElementById('LC_slotsearch_'+num)) {
+                    if (shown) {
+                        document.getElementById('LC_slotsearch_'+num).style.display = 'block';
+                    } else {
+                        document.getElementById('LC_slotsearch_'+num).style.display = 'none';
+                    }
+                }
+                if (shown == 0) {
+                    alert('$alerts{"none"}');
+                }
+            } else {
+                alert('$alerts{"invalid"}');
+            }
+        }
+    }
+    return;
+}
+
+function toggleSlotDisplay(form,num) {
+    if (form.slotpick.length) {
+        for (var i=0; i<form.slotpick.length; i++) {
+            if (form.slotpick[i].checked) {
+                var val = form.slotpick[i].value;
+                if (document.getElementById('LC_slotfilter_'+num)) {
+                    document.getElementById('LC_slotsearch_'+num).style.display = 'none';
+                    if (val == 'filter') {
+                        document.getElementById('LC_slotfilter_'+num).style.display = 'block';
+                    } else {
+                        document.getElementById('LC_slotfilter_'+num).style.display = 'none';
+                        if (val == 'all') {
+                            updateSlotDisplay(form,num,val);
+                        } else {
+                            updateSlotDisplay(form,num,val);
+                        }
+                    }
+                }
+                break;
+            }
+        }
+    }
+    return false;
+}
+
+if (!document.getElementsByClassName) {
+    function getElementsByClassName(node, classname) {
+        var a = [];
+        var re = new RegExp('(^| )'+classname+'( |$)');
+        var els = node.getElementsByTagName("*");
+        for(var i=0,j=els.length; i<j; i++)
+            if(re.test(els[i].className))a.push(els[i]);
+        return a;
+    }
+}
+
+function uncheckSlotRadio() {
+    var slotpicks;
+    if (document.getElementsByClassName) {
+        slotpicks = document.getElementsByClassName('LC_slotpick_radio');
+    } else {
+        slotpicks = getElementsByClassName(document.body,'LC_slotpick_radio');
+    }
+    if (slotpicks.length) {
+        for (var i=0; i<slotpicks.length; i++) {
+            slotpicks[i].checked = false;  
+        }
+    }
+}
+// ]]>
+</script>
+ENDSCRIPT
+
+}
+
+
 =pod
 
  slot_reservations db
@@ -121,7 +319,6 @@ sub check_for_reservation {
     my ($symb,$mode)=@_;
     my $student = &Apache::lonnet::EXT("resource.0.availablestudent", $symb,
 				       $env{'user.domain'}, $env{'user.name'});
-
     my $course = &Apache::lonnet::EXT("resource.0.available", $symb,
 				    $env{'user.domain'}, $env{'user.name'});
     my @slots = (split(/:/,$student), split(/:/, $course));
@@ -218,16 +415,19 @@ sub check_for_conflict {
     if (!defined($new_slot->{'uniqueperiod'})) { return undef; }
 
     if (!ref($consumed_uniqueperiods)) {
-	$consumed_uniqueperiods = &get_consumed_uniqueperiods($slots);
-        if (ref($consumed_uniqueperiods) eq 'HASH') {
-	    if (&Apache::lonnet::error(%$consumed_uniqueperiods)) {
-	        return 'error: Unable to determine current status';
-	    }
+        if ($consumed_uniqueperiods =~ /^error: /) {
+            return $consumed_uniqueperiods;
         } else {
-            return 'error: Unable to determine current status';
+	    $consumed_uniqueperiods = &get_consumed_uniqueperiods($slots);
+            if (ref($consumed_uniqueperiods) eq 'HASH') {
+	        if (&Apache::lonnet::error(%$consumed_uniqueperiods)) {
+	            return 'error: Unable to determine current status';
+	        }
+            } else {
+                return 'error: Unable to determine current status';
+            }
         }
-    }
-    
+    } 
     my ($new_uniq_start,$new_uniq_end) = @{$new_slot->{'uniqueperiod'}};
     foreach my $slot_name (keys(%$consumed_uniqueperiods)) {
 	my ($start,$end)=@{$consumed_uniqueperiods->{$slot_name}};
@@ -504,14 +704,20 @@ sub release_reservation {
         return (0,'error: Unable to determine current status');
     }
     my $passed_resource = $navmap->getBySymb($symb);
-    if ($passed_resource->is_map()) {
-	my ($a_resource) = 
-	    $navmap->retrieveResources($passed_resource, 
-				       sub {$_[0]->is_problem()},0,1);
-	$symb = $a_resource->symb();
+    if (ref($passed_resource)) {
+        if ($passed_resource->is_map()) {
+	    my ($a_resource) = 
+                $navmap->retrieveResources($passed_resource, 
+                                           sub {$_[0]->is_problem()},0,1);
+            $symb = $a_resource->symb();
+        }
+    } else {
+        unless ($mgr eq 'F') {
+            return (0,'error: Unable to determine current status');
+        }
     }
 
-    # get parameter string, check for existance, rebuild string with the slot
+    # get parameter string, check for existence, rebuild string with the slot
     my $student = &Apache::lonnet::EXT("resource.0.availablestudent",
                                        $symb,$udom,$uname);
     my @slots = split(/:/,$student);
@@ -523,13 +729,39 @@ sub release_reservation {
     }
     my $new_param = join(':',@new_slots);
 
+    # Get value of useslots parameter in effect for this user.
+    # If value is map or map_map, then the parm level is 2 (i.e.,
+    # non-recursive enclosing map/folder level for specific user)
+    # and the symb for this reservation in slot_reservations.db
+    # will be the symb of the map itself.
+
+    my $use_slots = &Apache::lonnet::EXT("resource.0.useslots",
+                                         $symb,$udom,$uname);
+    &Apache::lonxml::debug("use_slots is  $use_slots<br />");
+
+    if (&Apache::lonnet::error($use_slots)) {
+        return (0,'error: Unable to determine current status');
+    }
+
+    my $parm_level = 1;
+    my $parm_symb = $passed_resource->symb();
+    if ($use_slots eq 'map' || $use_slots eq 'map_map') {
+        $parm_level = 2;
+        unless ($passed_resource->is_map()) {
+            my ($map) = &Apache::lonnet::decode_symb($parm_symb);
+            $parm_symb = &Apache::lonnet::symbread($map);
+        }
+    }
+
     my ($cnum,$cdom)=&get_course();
 
-    # get slot reservations, check if user has one, if so remove reservation
+    # get slot reservations, check if user has one for the
+    # correct symb, and if so, remove the reservation
     my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
 				       "^$slot_name\0");
     foreach my $entry (keys(%consumed)) {
-	if ( $consumed{$entry}->{'name'} eq ($uname.':'.$udom) ) {
+        if (($consumed{$entry}->{'name'} eq $uname.':'.$udom) &&
+            ($consumed{$entry}->{'symb'} eq $parm_symb)) {
 	    &Apache::lonnet::del('slot_reservations',[$entry],
 				 $cdom,$cnum);
             my %storehash = (
@@ -538,25 +770,13 @@ sub release_reservation {
                                action  => 'release',
                                context => $env{'form.context'},
                         );
-            &Apache::lonnet::write_log('slotreservationslog',\%storehash,
-                                       1,$uname,$udom,$cnum,$cdom);
-            &Apache::lonnet::write_log($cdom.'_'.$cnum.'_slotlog',\%storehash,
-                                       1,$uname,$udom,$uname,$udom);
+            &Apache::lonnet::write_log('course','slotreservationslog',
+                                       \%storehash,1,$uname,$udom,$cnum,$cdom);
+            &Apache::lonnet::write_log('course',$cdom.'_'.$cnum.'_slotlog',
+                                       \%storehash,1,$uname,$udom,$uname,$udom);
 	}
     }
 
-    my $use_slots = &Apache::lonnet::EXT("resource.0.useslots",
-					 $symb,$udom,$uname);
-    &Apache::lonxml::debug("use_slots is  $use_slots<br />");
-
-    if (&Apache::lonnet::error($use_slots)) { 
-	return (0,'error: Unable to determine current status');
-    }
-
-    my $parm_level = 1;
-    if ($use_slots eq 'map' || $use_slots eq 'map_map') {
-	$parm_level = 2;
-    }
     # store new parameter string
     my $result=&Apache::lonparmset::storeparm_by_symb($symb,
 						      '0_availablestudent',
@@ -635,9 +855,15 @@ sub get_slot {
     if ($slot_name && $slot_name ne $conflictable_slot) {
 	my %slot=&Apache::lonnet::get_slot($slot_name);
 	my $description1=&get_description($slot_name,\%slot);
+        my $slottype1=$slot{'type'};
 	%slot=&Apache::lonnet::get_slot($env{'form.slotname'});
 	my $description2=&get_description($env{'form.slotname'},\%slot);
-	if ($slot_name ne $env{'form.slotname'}) {
+        if ($slottype1 eq 'preassigned') {
+            $r->print('<p>'.&mt('You already have a reservation: "[_1]", assigned by your instructor.',
+                                $description1).'</p>'.
+                      '<p>'.&mt('Your instructor must unassign it before you can make a new reservation.').
+                      '</p>');
+        } elsif ($slot_name ne $env{'form.slotname'}) {
 	    $r->print(<<STUFF);
 <form method="post" action="/adm/slotrequest">
    <input type="hidden" name="symb" value="$env{'form.symb'}" />
@@ -696,7 +922,7 @@ STUFF
     }
 
     my %lt = &Apache::lonlocal::texthash(
-        'request' => 'Availibility list',
+        'request' => 'Availability list',
         'try'     => 'Try again?',
         'or'      => 'or',
     );
@@ -735,7 +961,7 @@ STUFF
 }
 
 sub allowed_slot {
-    my ($slot_name,$slot,$symb,$slots,$consumed_uniqueperiods)=@_;
+    my ($slot_name,$slot,$symb,$slots,$consumed_uniqueperiods,$toskip)=@_;
 
     #already started
     if ($slot->{'starttime'} < time) {
@@ -811,7 +1037,9 @@ sub allowed_slot {
     # not allowed for this resource
     if (defined($slot->{'symb'})
 	&& $slot->{'symb'} ne $symb) {
-	return 0;
+        unless ((ref($toskip) eq 'HASH') && ($toskip->{'symb'})) {
+	    return 0;
+        }
     }
 
     my $conflict = &check_for_conflict($symb,$slot_name,$slot,$slots,
@@ -839,77 +1067,116 @@ sub get_description {
 }
 
 sub show_choices {
-    my ($r,$symb,$formname)=@_;
-
-    my ($cnum,$cdom)=&get_course();
-    my %slots = &Apache::lonnet::get_course_slots($cnum,$cdom);
-    my $consumed_uniqueperiods = &get_consumed_uniqueperiods(\%slots);
-    if (ref($consumed_uniqueperiods) eq 'HASH') {
-        if (&Apache::lonnet::error(%$consumed_uniqueperiods)) {
-            $r->print('<span class="LC_error">'.
-                      &mt('An error occurred determining slot availability').
-                      '</span>');
-            return;
-        }
-    } elsif ($consumed_uniqueperiods =~ /^error: /) {
-        $r->print('<span class="LC_error">'.
-                  &mt('An error occurred determining slot availability').
-                  '</span>');
-        return;
-    }
-    my (@available,$output);
+    my ($r,$symb,$formname,$num,$slots,$consumed_uniqueperiods,$available,$got_slots)=@_;
+    my $output;
     &Apache::lonxml::debug("Checking Slots");
-    my @got_slots=&check_for_reservation($symb,'allslots');
-    if ($got_slots[0] =~ /^error: /) {
-        $r->print('<span class="LC_error">'.
-                  &mt('An error occurred determining slot availability').
-                  '</span>');
+    if (!ref($available) eq 'ARRAY') {
         return;
     }
-    foreach my $slot (sort 
-		      { return $slots{$a}->{'starttime'} <=> $slots{$b}->{'starttime'} }
-		      (keys(%slots)))  {
-
-	&Apache::lonxml::debug("Checking Slot $slot");
-	next if (!&allowed_slot($slot,$slots{$slot},$symb,\%slots,
-				$consumed_uniqueperiods));
-
-        push(@available,$slot);
-    }
-    if (!@available) {
-        $output = '<div class="LC_info">'.&mt('No available times.');
+    if (!@{$available}) {
+        $output = '<span class="LC_info">'.&mt('No available times.').'</span>';
         if ($env{'form.command'} ne 'manageresv') {
             $output .= ' <a href="/adm/flip?postdata=return:">'.
                        &mt('Return to last resource').'</a>';
         }
-        $output .= '</div>';
         $r->print($output);
         return;
     }
+    if (@{$available} > 1) {
+        my $numavailable = scalar(@{$available});
+        my $numreserved = 0;
+        my $js;
+        my $j = 0;
+        foreach my $got (@{$got_slots}) {
+            unless (($got eq '') || (!defined($got))) {
+                $numreserved ++;
+                if ($env{'form.command'} eq 'manageresv') {
+                    $js .= "    currslot[$j]='$got';\n";
+                    $j++;
+                }
+            }
+        }
+        my $showfilter = 'none';
+        $output .= '<fieldset><legend>'.&mt('Actions').'</legend>'."\n".
+                   '<form method="post" name="reservationdisplay_'.$num.
+                   '" action="" onsubmit="toggleSlotDisplay(this.form,'."'$num'".');">';
+        my @options = ('all','filter');
+        if ($numreserved) {
+            unshift(@options,'show');
+        }
+        my %resmenu = &Apache::lonlocal::texthash (
+                                         show   => 'Show current reservation',
+                                         all    => 'Show all', 
+                                         filter => 'Search by date',
+                     );
+        foreach my $option (@options) {
+            my $onclick = "toggleSlotDisplay(this.form,'$num');";
+            if (($option eq 'show') && ($env{'form.command'} eq 'manageresv')) {  
+                $onclick .= "currSlotDisplay$num(this.form,'$num');"; 
+            }
+            $output .= '<span class="LC_nobreak"><label>'.
+                       '<input type="radio" class="LC_slotpick_radio" name="slotpick" value="'.
+                       $option.'" onclick="'.$onclick.'" />'.
+                       $resmenu{$option}.
+                       '</label></span>'.('&nbsp;' x3)."\n";
+        }
+        $output .= '</form>';
+        my $chooserform = 'reservationchooser_'.$num;
+        my $starttime = $slots->{$available->[0]}->{'starttime'};
+        my $endtime = $slots->{$available->[-1]}->{'starttime'};
+        if ($env{'form.command'} eq 'manageresv') {
+            $output .= <<"ENDSCRIPT";
+
+<script type="text/javascript">
+// <![CDATA[
+function currSlotDisplay$num() {
+    var currslot = new Array($numreserved);
+$js    
+    for (var j=0; j<$numreserved; j++) {
+        if (document.getElementById('LC_slotrow_$num\_'+currslot[j])) {
+            document.getElementById('LC_slotrow_$num\_'+currslot[j]).style.display = '';
+        }
+    }
+}
+// ]]>
+</script>
+
+ENDSCRIPT
+        }
+        $output .=
+            '<div id="LC_slotfilter_'.$num.'" style="display:'.$showfilter.'">'.
+            '<form method="post" name="'.$chooserform.'" action="">'.
+            '<table><tr><td>'.&mt('Open after').'</td><td>'.
+            &Apache::lonhtmlcommon::date_setter($chooserform,'start',$starttime,'','','','','','','',1,1).
+            '</td></tr><tr><td>'.&mt('Closed before').'</td><td>'.
+            &Apache::lonhtmlcommon::date_setter($chooserform,'end',$endtime,'','','','','','','',1,1).
+            '</td></tr></table><br />'.
+            '<input type="button" name="slotfilter" value="Search for reservable slots" onclick="updateSlotDisplay(this.form,'."'$num'".');" />'.
+            '</form></div><div id="LC_slotsearch_'.$num.'" style="display:none"><hr />';
+    }
     if ($env{'form.command'} eq 'manageresv') {
-        $output = '<table border="0">';
+        $output .= '<table border="0">';
     } else {
-        $output = &Apache::loncommon::start_data_table();
+        $output .= &Apache::loncommon::start_data_table();
     }
-    foreach my $slot (@available) { 
-	my $description=&get_description($slot,$slots{$slot});
+    foreach my $slot (@{$available}) {
+	my $description=&get_description($slot,$slots->{$slot});
 	my $form;
-	if ((grep(/^\Q$slot\E$/,@got_slots)) ||
-	    &space_available($slot,$slots{$slot},$symb)) {
+	if ((grep(/^\Q$slot\E$/,@{$got_slots})) ||
+	    &space_available($slot,$slots->{$slot},$symb)) {
 	    my $text=&mt('Select');
 	    my $command='get';
-	    if (grep(/^\Q$slot\E$/,@got_slots)) {
+	    if (grep(/^\Q$slot\E$/,@{$got_slots})) {
 		$text=&mt('Drop Reservation');
 		$command='release';
 	    } else {
-		my $conflict = &check_for_conflict($symb,$slot,$slots{$slot},
-						   \%slots,
-						   $consumed_uniqueperiods);
+		my $conflict = &check_for_conflict($symb,$slot,$slots->{$slot},
+						   $slots,$consumed_uniqueperiods);
                 if ($conflict) {
                     if ($conflict =~ /^error: /) {
                         $form = '<span class="LC_error">'.
-                                &mt('Slot: [_1] has unknown status.',$description).
-                                '</span>';
+                                 &mt('Slot: [_1] has unknown status.',$description).
+                                 '</span>';
                     } else {
 		        $text=&mt('Change Reservation');
 		        $command='get';
@@ -918,15 +1185,16 @@ sub show_choices {
 	    }
 	    my $escsymb=&escape($symb);
             if (!$form) {
+                my $name;
                 if ($formname) {
-                    $formname = 'name="'.$formname.'" ';
+                     $name = 'name="'.$formname.'"';
                 }
                 my $context = 'user';
                 if ($env{'form.command'} eq 'manageresv') {
                     $context = 'usermanage';
                 }
 	        $form=<<STUFF;
-   <form method="post" action="/adm/slotrequest" $formname>
+   <form method="post" action="/adm/slotrequest" $name>
      <input type="submit" name="Select" value="$text" />
      <input type="hidden" name="symb" value="$escsymb" />
      <input type="hidden" name="slotname" value="$slot" />
@@ -939,9 +1207,9 @@ STUFF
             $form = &mt('Unavailable');
         }
         if ($env{'form.command'} eq 'manageresv') {
-            $output .= '<tr>';
+            $output .= '<tr id="LC_slotrow_'.$num.'_'.$slot.'" >';
         } else {
-	    $output .= &Apache::loncommon::start_data_table_row();
+	    $output .= &Apache::loncommon::start_data_table_row('','LC_slotrow_'.$num.'_'.$slot);
         }
         $output .= " 
  <td>$form</td>
@@ -955,9 +1223,13 @@ STUFF
     if ($env{'form.command'} eq 'manageresv') {
         $output .= '</table>';
     } else {
-       $output .= &Apache::loncommon::end_data_table();
+        $output .= &Apache::loncommon::end_data_table();
+    }
+    if (@{$available} > 1) {
+        $output .= '</div></fieldset>';
     }
     $r->print($output);
+    return;
 }
 
 sub to_show {
@@ -1211,11 +1483,11 @@ sub show_table {
            <td valign="top">
             <table>
               <tr>
-                <td rowspan="2">Deleted slots:</td>
-                <td><label>'.$show_radio.'Show</label></td>
+                <td rowspan="2">'.&mt('Deleted slots:').'</td>
+                <td><label>'.$show_radio.&mt('Show').'</label></td>
               </tr>
               <tr>
-                <td><label>'.$hide_radio.'Hide</label></td>
+                <td><label>'.$hide_radio.&mt('Hide').'</label></td>
               </tr>
             </table>
 	  </td>
@@ -1224,15 +1496,16 @@ sub show_table {
     $r->print('</div>');
     $r->print('<p><input type="submit" name="start" value="'.&mt('Update Display').'" /></p>');
     my $linkstart='<a href="/adm/slotrequest?command=showslots&amp;order=';
-    $r->print(&Apache::loncommon::start_data_table().
-	      &Apache::loncommon::start_data_table_header_row().'
-	       <th></th>');
+    my $tableheader = &Apache::loncommon::start_data_table().
+                      &Apache::loncommon::start_data_table_header_row().'
+                      <th></th>';
     foreach my $which (@show_order) {
 	if ($which ne 'proctor' && exists($show{$which})) {
-	    $r->print('<th>'.$linkstart.$which.'">'.$show_fields{$which}.'</a></th>');
+	    $tableheader .= '<th>'.$linkstart.$which.'">'.$show_fields{$which}.'</a></th>';
 	}
     }
-    $r->print(&Apache::loncommon::end_data_table_header_row());
+    $tableheader .= &Apache::loncommon::end_data_table_header_row();
+    my $shownheader = 0;
 
     my %name_cache;
     my $slotsort = sub {
@@ -1381,30 +1654,39 @@ sub show_table {
                                                delete => 'Delete',
                                                slotlog => 'History',
         );
-	my $edit=(<<"EDITLINK");
+        my ($edit,$delete,$showlog,$remove_all);
+        if ($mgr) {
+	    $edit=(<<"EDITLINK");
 <a href="/adm/helper/newslot.helper?name=$slot">$lt{'edit'}</a>
 EDITLINK
 
-	my $delete=(<<"DELETELINK");
+	    $delete=(<<"DELETELINK");
 <a href="/adm/slotrequest?command=delete&amp;slotname=$slot">$lt{'delete'}</a>
 DELETELINK
 
-        my $showlog=(<<"LOGLINK");
+            $remove_all=&remove_link($slot,'remove all').'<br />';
+
+            if ($ids eq '') {
+                undef($remove_all);
+            } else {
+                undef($delete);
+            }
+        }
+
+        $showlog=(<<"LOGLINK");
 <a href="/adm/slotrequest?command=slotlog&amp;slotname=$slot">$lt{'slotlog'}</a>
 LOGLINK
 
-        my $remove_all=&remove_link($slot,'remove all').'<br />';
-
-        if ($ids eq '') {
-            undef($remove_all);
-        } else {
-            undef($delete);
-        }
 	if ($slots{$slot}{'type'} ne 'schedulable_student') {
             undef($showlog); 
 	    undef($remove_all);
 	}
 
+        unless ($shownheader) {
+            $r->print($tableheader);
+            $shownheader = 1;
+        }
+
 	my $row_start=&Apache::loncommon::start_data_table_row();
 	my $row_end=&Apache::loncommon::end_data_table_row();
         $r->print($row_start.
@@ -1473,12 +1755,17 @@ $row_end
 STUFF
         }
     }
-    $r->print(&Apache::loncommon::end_data_table().'</form>');
+    if ($shownheader) {
+        $r->print(&Apache::loncommon::end_data_table());
+    } else {
+        $r->print('<p>'.&mt('No slots meet the criteria for display').'</p>');
+    }
+    $r->print('</form>');
     return;
 }
 
 sub manage_reservations {
-    my ($r,$crstype) = @_;
+    my ($r,$crstype,$slots,$consumed_uniqueperiods,$allavailable) = @_;
     my $navmap = Apache::lonnavmaps::navmap->new();
     $r->print('<p>'
              .&mt('Instructors may use a reservation system to place restrictions on when and where assignments can be worked on.')
@@ -1497,6 +1784,19 @@ sub manage_reservations {
         &Apache::lonnet::logthis('Manage Reservations - could not create navmap object in '.lc($crstype).':'.$env{'request.course.id'});
         return;
     }
+    if (ref($consumed_uniqueperiods) eq 'HASH') {
+        if (&Apache::lonnet::error(%$consumed_uniqueperiods)) {
+            $r->print('<span class="LC_error">'.
+                      &mt('An error occurred determining slot availability.').
+                      '</span>');
+            return;
+        }
+    } elsif ($consumed_uniqueperiods =~ /^error: /) {
+        $r->print('<span class="LC_error">'.
+                  &mt('An error occurred determining slot availability.').
+                  '</span>');
+        return;
+    }
     my (%parent,%shownparent,%container,%container_title,%contents);
     my ($depth,$count,$reservable,$lastcontainer,$rownum) = (0,0,0,0,0);
     my @backgrounds = ("LC_odd_row","LC_even_row");
@@ -1635,15 +1935,38 @@ sub manage_reservations {
                     }
                 }
                 if ($hasaction) {
-                    $result .= '<td valgn="middle">'.$msg.'</td>'.
-                               '<td valign="middle">'.('&nbsp;' x6);
+                    $result .= '<td valign="top">'.$msg.'</td>'.
+                               '<td valign="top">';
                 } else {
                     $result .= '<td colspan="2" valign="middle">'.$msg.'</td>';
                 }
                 $r->print($result);
                 if ($hasaction) {
-                    my $formname = 'manageres_'.$reservable;
-                    &show_choices($r,$symb,$formname);
+                    my @got_slots=&check_for_reservation($symb,'allslots');
+                    if ($got_slots[0] =~ /^error: /) {
+                        $r->print('<span class="LC_error">'.
+                                  &mt('An error occurred determining slot availability.').
+                                  '</span>');
+                    } else {
+                        my $formname = 'manageres_'.$reservable;
+                        if (ref($allavailable) eq 'ARRAY') {
+                            my @available;
+                            if (ref($slots) eq 'HASH') {
+                                foreach my $slot (@{$allavailable}) {
+                                # not allowed for this resource
+                                    if (ref($slots->{$slot}) eq 'HASH') {
+                                        if ((defined($slots->{$slot}->{'symb'})) && 
+                                            ($slots->{$slot}->{'symb'} ne $symb)) {
+                                            next;
+                                        }
+                                    }
+                                    push(@available,$slot);
+                                }
+                            }  
+                            &show_choices($r,$symb,$formname,$reservable,$slots,$consumed_uniqueperiods,
+                                          \@available,\@got_slots);
+                        }
+                    }
                     $r->print('</td>');
                 }
                 $r->print('</tr>');
@@ -1793,16 +2116,19 @@ sub show_reservations {
     if ($showntablehdr) {
         $r->print(&Apache::loncommon::end_data_table().'<br />');
         if (($curr{'page'} > 1) || ($more_records)) {
-            $r->print('<table><tr>');
+            $r->print('<p>');
             if ($curr{'page'} > 1) {
-                $r->print('<td><a href="javascript:chgPage('."'previous'".');">'.&mt('Previous [_1] changes',$curr{'show'}).'</a></td>');
+                $r->print('<input type="button" onclick="javascript:chgPage('."'previous'".');" value="'.
+                          &mt('Previous [_1] changes',$curr{'show'}).'" />');
             }
             if ($more_records) {
-                $r->print('<td><a href="javascript:chgPage('."'next'".');">'.&mt('Next [_1] changes',$curr{'show'}).'</a></td>');
+                $r->print('<input type="button" onclick="javascript:chgPage('."'next'".');" value="'.
+                          &mt('Next [_1] changes',$curr{'show'}).'" />');
             }
-            $r->print('</tr></table>');
+            $r->print('</p>');
             $r->print(<<"ENDSCRIPT");
 <script type="text/javascript">
+// <![CDATA[
 function chgPage(caller) {
     if (caller == 'previous') {
         document.$formname.page.value --;
@@ -1813,6 +2139,7 @@ function chgPage(caller) {
     document.$formname.submit();
     return;
 }
+// ]]>
 </script>
 ENDSCRIPT
         }
@@ -2002,14 +2329,16 @@ sub show_reservations_log {
     if ($showntablehdr) {
         $r->print(&Apache::loncommon::end_data_table().'<br />');
         if (($curr{'page'} > 1) || ($more_records)) {
-            $r->print('<table><tr>');
+            $r->print('<p>');
             if ($curr{'page'} > 1) {
-                $r->print('<td><a href="javascript:chgPage('."'previous'".');">'.&mt('Previous [_1] changes',$curr{'show'}).'</a></td>');
+                $r->print('<input type="button" onclick="javascript:chgPage('."'previous'".');" value="'.
+                          &mt('Previous [_1] changes',$curr{'show'}).'" />');
             }
             if ($more_records) {
-                $r->print('<td><a href="javascript:chgPage('."'next'".');">'.&mt('Next [_1] changes',$curr{'show'}).'</a></td>');
+                $r->print('<input type="button" onclick="javascript:chgPage('."'next'".');" value="'.
+                          &mt('Next [_1] changes',$curr{'show'}).'" />');
             }
-            $r->print('</tr></table>');
+            $r->print('</p>');
             $r->print(<<"ENDSCRIPT");
 <script type="text/javascript">
 function chgPage(caller) {
@@ -2149,8 +2478,9 @@ sub display_filter {
         }
         $output .= '</select></td>';
     }
-    $output .= '<td>&nbsp;&nbsp;</td><td valign="middle"><input type="submit" value="'.
-               &mt('Update Display').'" /></tr></table>'.
+    $output .= '<td>&nbsp;&nbsp;</td></tr></table>'.
+               '<p><input type="submit" value="'.
+               &mt('Update Display').'" /></p>'.
                '<p class="LC_info">'.
                &mt('Only changes made from servers running LON-CAPA [_1] or later are displayed.'
                   ,'2.9.0');
@@ -2298,7 +2628,7 @@ ENDPICK
 }
 
 sub csvupload_javascript_reverse_associate {
-    my $error1=&mt('You need to specify the name, starttime, endtime and a type');
+    my $error1=&mt('You need to specify the name, start time, end time and a type.');
     return(<<ENDPICK);
   function verify(vf) {
     var foundstart=0;
@@ -2324,7 +2654,7 @@ ENDPICK
 }
 
 sub csvupload_javascript_forward_associate {
-    my $error1=&mt('You need to specify the name, starttime, endtime and a type');
+    my $error1=&mt('You need to specify the name, start time, end time and a type.');
   return(<<ENDPICK);
   function verify(vf) {
     var foundstart=0;
@@ -2465,8 +2795,12 @@ sub csv_upload_assign {
 	}
 
 	if ($entries{$fields{'startreserve'}}) {
-	    $slot{'startreserve'}=
-		&UnixDate($entries{$fields{'startreserve'}},"%s");
+            my $date = &UnixDate($entries{$fields{'startreserve'}},"%s");
+            if ($date eq '') {
+                push(@errors,"$name -- No reservation start time set for slot -- value provided had invalid format");
+            } else {
+                $slot{'startreserve'} = $date;
+            }
 	}
 	if (defined($slot{'startreserve'})
 	    && $slot{'startreserve'} > $slot{'starttime'}) {
@@ -2475,8 +2809,12 @@ sub csv_upload_assign {
 	}
 
         if ($entries{$fields{'endreserve'}}) {
-            $slot{'endreserve'}=
-                &UnixDate($entries{$fields{'endreserve'}},"%s");
+            my $date = &UnixDate($entries{$fields{'endreserve'}},"%s");
+            if ($date eq '') {
+                push(@errors,"$name -- No reservation end time set for slot -- value provided had invalid format");
+            } else {
+                $slot{'endreserve'} = $date;
+            }
         }
         if (defined($slot{'endreserve'})
             && $slot{'endreserve'} > $slot{'starttime'}) {
@@ -2504,14 +2842,46 @@ sub csv_upload_assign {
 		$slot{$key}=$entries{$fields{$key}};
 	    }
 	}
-
+        if ($entries{$fields{'allowedusers'}}) {
+            $entries{$fields{'allowedusers'}} =~ s/^\s+//;
+            $entries{$fields{'allowedusers'}} =~ s/\s+$//;
+            my @allowedusers;
+            foreach my $poss (split(/\s*,\s*/,$entries{$fields{'allowedusers'}})) {
+                my ($possuname,$possudom) = split(/:/,$poss);
+                if (($possuname =~ /^$match_username$/) && ($possudom =~ /^$match_domain$/)) {
+                    unless (grep(/^\Q$poss\E$/,@allowedusers)) {
+                        push(@allowedusers,$poss);
+                    }
+                }
+            }
+            if (@allowedusers > 0) {
+                $slot{'allowedusers'} = join(',',@allowedusers);
+            }
+        }
+        if ($entries{$fields{'allowedsections'}}) {
+            $entries{$fields{'allowedsections'}} =~ s/^\s+//;
+            $entries{$fields{'allowedsections'}} =~ s/\s+$//;
+            my @allowedsections;
+            foreach my $poss (split(/\s*,\s*/,$entries{$fields{'allowedsections'}})) {
+                if (($poss !~ /\W/) && ($poss ne 'none')) {
+                    unless (grep(/^\Q$poss\E$/,@allowedsections)) {
+                        push(@allowedsections,$poss);
+                    }
+                }
+            }
+            if (@allowedsections > 0) {
+                $slot{'allowedsections'} = join(',',@allowedsections);
+            }
+        }
 	if ($entries{$fields{'uniqueperiod'}}) {
-	    my ($start,$end)=split(',',$entries{$fields{'uniqueperiod'}});
-	    my @times=(&UnixDate($start,"%s"),
-		       &UnixDate($end,"%s"));
-	    $slot{'uniqueperiod'}=\@times;
+            my ($start,$end)= map { &UnixDate($_,"%s"); } split(',',$entries{$fields{'uniqueperiod'}});
+            if (($start ne '') && ($end ne '')) {
+                $slot{'uniqueperiod'}=[$start,$end];
+            } else {
+                push(@errors,"$name -- Slot's unique period ignored -- one or both of the comma separated values for start and end had an invalid format");
+            }
 	}
-	if (defined($slot{'uniqueperiod'})
+	if (ref($slot{'uniqueperiod'}) eq 'ARRAY' 
 	    && $slot{'uniqueperiod'}[0] > $slot{'uniqueperiod'}[1]) {
 	    push(@errors,"$name not created -- Slot's unique period start time is later than the unique period's end time.");
 	    next;
@@ -2576,6 +2946,7 @@ sub handler {
 
     my $vgr=&Apache::lonnet::allowed('vgr',$env{'request.course.id'});
     my $mgr=&Apache::lonnet::allowed('mgr',$env{'request.course.id'});
+    my (%slots,$consumed_uniqueperiods);
     if ($env{'form.command'} eq 'showslots') {
         if (($vgr ne 'F') && ($mgr ne 'F')) {
             $env{'form.command'} = 'manageresv'; 
@@ -2596,9 +2967,14 @@ sub handler {
         if (ref($brcrum) eq 'ARRAY') {
             push(@{$brcrum},{href=>"/adm/slotrequest?command=showresv",text=>$title});
         }
-    } elsif ($env{'form.command'} eq 'manageresv') {
-        $title = 'Manage Reservations';
-        $brcrum =[{href=>"/adm/slotrequest?command=manageresv",text=>$title}];
+    } elsif (($env{'form.requestattempt'}) || ($env{'form.command'} eq 'manageresv')) {  
+        if ($env{'form.command'} eq 'manageresv') {
+            $title = 'Manage Reservations';
+            $brcrum =[{href=>"/adm/slotrequest?command=manageresv",text=>$title}];
+        }
+        my ($cnum,$cdom)=&get_course();
+        %slots = &Apache::lonnet::get_course_slots($cnum,$cdom);
+        $consumed_uniqueperiods = &get_consumed_uniqueperiods(\%slots);
     } elsif ($vgr eq 'F') {
         if ($env{'form.command'} =~ /^(slotlog|showslots|uploadstart|csvuploadmap|csvuploadassign|delete|release|remove_registration)$/) {
             $brcrum =[{href=>"/adm/slotrequest?command=showslots",
@@ -2622,11 +2998,23 @@ sub handler {
     } else {
         $brcrum =[];
     }
-    &start_page($r,$title,$brcrum);
+    my ($symb,$js,$available,$allavailable,$got_slots);
+    $available = [];
+    if ($env{'form.requestattempt'}) {
+        $symb=&unescape($env{'form.symb'});
+        @{$got_slots}=&check_for_reservation($symb,'allslots');
+    }
+    if (($env{'form.requestattempt'}) || ($env{'form.command'} eq 'manageresv')) {
+        $js = &reservation_js(\%slots,$consumed_uniqueperiods,$available,$got_slots,$symb);
+    }
+    &start_page($r,$title,$brcrum,$js);
 
     if ($env{'form.command'} eq 'manageresv') {
+        $allavailable = $available;
+        undef($available);
+        undef($got_slots);
         my $crstype = &Apache::loncommon::course_type();
-        &manage_reservations($r,$crstype);
+        &manage_reservations($r,$crstype,\%slots,$consumed_uniqueperiods,$allavailable);
     } elsif ($env{'form.command'} eq 'showresv') {
         &show_reservations($r,$env{'form.uname'},$env{'form.udom'});
     } elsif ($env{'form.command'} eq 'showslots' && $vgr eq 'F') {
@@ -2656,7 +3044,7 @@ sub handler {
 	    }
 	    &csv_upload_map($r);
 	}
-    } elsif ($env{'form.command'} eq 'slotlog' && $mgr eq 'F') {
+    } elsif (($env{'form.command'} eq 'slotlog') && ($vgr eq 'F')) {
         &show_reservations_log($r);
     } else {
 	my $symb=&unescape($env{'form.symb'});
@@ -2683,7 +3071,9 @@ sub handler {
 	    return OK;
 	}
 	if ($env{'form.requestattempt'}) {
-	    &show_choices($r,$symb);
+            $r->print('<div class="LC_left_float">'); 
+	    &show_choices($r,$symb,undef,undef,\%slots,$consumed_uniqueperiods,$available,$got_slots);
+            $r->print('</div><div style="padding:0;clear:both;margin:0;border:0"></div>');
 	} elsif ($env{'form.command'} eq 'release') {
 	    &release_slot($r,$symb);
 	} elsif ($env{'form.command'} eq 'get') {