--- loncom/interface/slotrequest.pm 2005/11/18 16:26:47 1.31 +++ loncom/interface/slotrequest.pm 2009/03/01 03:23:18 1.89 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Handler for requesting to have slots added to a students record # -# $Id: slotrequest.pm,v 1.31 2005/11/18 16:26:47 albertel Exp $ +# $Id: slotrequest.pm,v 1.89 2009/03/01 03:23:18 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -34,34 +34,35 @@ use Apache::Constants qw(:common :http : use Apache::loncommon(); use Apache::lonlocal; use Apache::lonnet; +use Apache::lonnavmaps(); use Date::Manip; +use lib '/home/httpd/lib/perl/'; +use LONCAPA; sub fail { my ($r,$code)=@_; if ($code eq 'not_valid') { $r->print('<p>'.&mt('Unable to understand what resource you wanted to sign up for.').'</p>'); - + } elsif ($code eq 'not_available') { + $r->print('<p>'.&mt('No slots are available.').'</p>'); } elsif ($code eq 'not_allowed') { $r->print('<p>'.&mt('Not allowed to sign up or change reservations at this time.').'</p>'); } else { $r->print('<p>'.&mt('Failed.').'</p>'); } - $r->print('<p><a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); + &return_link($r); &end_page($r); } sub start_page { my ($r,$title)=@_; - my $html=&Apache::lonxml::xmlbegin(); - $r->print($html.'<head><title>'.&mt($title).'</title></head>'); - $r->print(&Apache::loncommon::bodytag($title)); + $r->print(&Apache::loncommon::start_page($title)); } sub end_page { my ($r)=@_; - $r->print(&Apache::loncommon::endbodytag().'</html>'); + $r->print(&Apache::loncommon::end_page()); } =pod @@ -76,7 +77,7 @@ sub end_page { =cut sub get_course { - (undef,my $courseid)=&Apache::lonxml::whichuser(); + (undef,my $courseid)=&Apache::lonnet::whichuser(); my $cdom=$env{'course.'.$courseid.'.domain'}; my $cnum=$env{'course.'.$courseid.'.num'}; return ($cnum,$cdom); @@ -89,7 +90,9 @@ sub get_reservation_ids { my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum, "^$slot_name\0"); - + if (&Apache::lonnet::error(%consumed)) { + return 'error: Unable to determine current status'; + } my ($tmp)=%consumed; if ($tmp=~/^error: 2 / ) { return 0; @@ -111,7 +114,7 @@ sub space_available { } sub check_for_reservation { - my ($symb)=@_; + my ($symb,$mode)=@_; my $student = &Apache::lonnet::EXT("resource.0.availablestudent", $symb, $env{'user.domain'}, $env{'user.name'}); @@ -124,7 +127,20 @@ sub check_for_reservation { my ($cnum,$cdom)=&get_course(); my %slots=&Apache::lonnet::get('slots', [@slots], $cdom, $cnum); - foreach my $slot_name (@slots) { + if (&Apache::lonnet::error($student) + || &Apache::lonnet::error($course) + || &Apache::lonnet::error(%slots)) { + return 'error: Unable to determine current status'; + } + my @got; + foreach my $slot_name (sort { + if (ref($slots{$a}) && ref($slots{$b})) { + return $slots{$a}{'starttime'} <=> $slots{$b}{'starttime'} + } + if (ref($slots{$a})) { return -1;} + if (ref($slots{$b})) { return 1;} + return 0; + } @slots) { next if (!defined($slots{$slot_name}) || !ref($slots{$slot_name})); &Apache::lonxml::debug(time." $slot_name ". @@ -133,50 +149,127 @@ sub check_for_reservation { if ($slots{$slot_name}->{'endtime'} > time && $slots{$slot_name}->{'startreserve'} < time) { # between start of reservation times and end of slot - return($slot_name, $slots{$slot_name}); + if ($mode eq 'allslots') { + push(@got,$slot_name); + } else { + return($slot_name, $slots{$slot_name}); + } } } + if ($mode eq 'allslots' && @got) { + return @got; + } return (undef,undef); } +sub get_consumed_uniqueperiods { + my ($slots) = @_; + my $navmap=Apache::lonnavmaps::navmap->new; + if (!defined($navmap)) { + return 'error: Unable to determine current status'; + } + my @problems = $navmap->retrieveResources(undef, + sub { $_[0]->is_problem() },1,0); + my %used_slots; + foreach my $problem (@problems) { + my $symb = $problem->symb(); + my $student = &Apache::lonnet::EXT("resource.0.availablestudent", + $symb, $env{'user.domain'}, + $env{'user.name'}); + my $course = &Apache::lonnet::EXT("resource.0.available", + $symb, $env{'user.domain'}, + $env{'user.name'}); + if (&Apache::lonnet::error($student) + || &Apache::lonnet::error($course)) { + return 'error: Unable to determine current status'; + } + foreach my $slot (split(/:/,$student), split(/:/, $course)) { + $used_slots{$slot}=1; + } + } + + if (!ref($slots)) { + my ($cnum,$cdom)=&get_course(); + my %slots=&Apache::lonnet::get('slots', [keys(%used_slots)], $cdom, $cnum); + if (&Apache::lonnet::error(%slots)) { + return 'error: Unable to determine current status'; + } + $slots = \%slots; + } + + my %consumed_uniqueperiods; + foreach my $slot_name (keys(%used_slots)) { + next if (!defined($slots->{$slot_name}) || + !ref($slots->{$slot_name})); + + next if (!defined($slots->{$slot_name}{'uniqueperiod'}) || + !ref($slots->{$slot_name}{'uniqueperiod'})); + $consumed_uniqueperiods{$slot_name} = + $slots->{$slot_name}{'uniqueperiod'}; + } + return \%consumed_uniqueperiods; +} + sub check_for_conflict { - my ($symb,$new_slot_name)=@_; - my $student = &Apache::lonnet::EXT("resource.0.availablestudent", $symb, - $env{'user.domain'}, $env{'user.name'}); - my $course = &Apache::lonnet::EXT("resource.0.available", $symb, - $env{'user.domain'}, $env{'user.name'}); - my @slots = (split(/:/,$student), split(/:/, $course)); - my ($cnum,$cdom)=&get_course(); - my %slots=&Apache::lonnet::get('slots', [@slots], $cdom, $cnum); - foreach my $slot_name (@slots) { - next if (!defined($slots{$slot_name}) || - !ref($slots{$slot_name})); + my ($symb,$new_slot_name,$new_slot,$slots,$consumed_uniqueperiods)=@_; + + if (!defined($new_slot->{'uniqueperiod'})) { return undef; } - next if (!defined($slots{$slot_name}->{'uniqueperiod'}) || - !ref($slots{$slot_name}->{'uniqueperiod'})); - my ($start,$end)=@{$slots{$slot_name}->{'uniqueperiod'}}; - if ($start<time && time < $end) { + if (!ref($consumed_uniqueperiods)) { + $consumed_uniqueperiods = &get_consumed_uniqueperiods($slots); + if (ref($consumed_uniqueperiods) eq 'HASH') { + if (&Apache::lonnet::error(%$consumed_uniqueperiods)) { + return 'error: Unable to determine current status'; + } + } else { + return 'error: Unable to determine current status'; + } + } + + my ($new_uniq_start,$new_uniq_end) = @{$new_slot->{'uniqueperiod'}}; + foreach my $slot_name (keys(%$consumed_uniqueperiods)) { + my ($start,$end)=@{$consumed_uniqueperiods->{$slot_name}}; + if (! + ($start < $new_uniq_start && $end < $new_uniq_start) || + ($start > $new_uniq_end && $end > $new_uniq_end )) { return $slot_name; } } return undef; - } sub make_reservation { - my ($slot_name,$slot,$symb)=@_; - - my ($cnum,$cdom)=&get_course(); + my ($slot_name,$slot,$symb,$cnum,$cdom)=@_; my $value=&Apache::lonnet::EXT("resource.0.availablestudent",$symb, $env{'user.domain'},$env{'user.name'}); &Apache::lonxml::debug("value is $value<br />"); + + my $use_slots = &Apache::lonnet::EXT("resource.0.useslots",$symb, + $env{'user.domain'},$env{'user.name'}); + &Apache::lonxml::debug("use_slots is $use_slots<br />"); + + if (&Apache::lonnet::error($value) + || &Apache::lonnet::error($use_slots)) { + return 'error: Unable to determine current status'; + } + + my $parm_symb = $symb; + my $parm_level = 1; + if ($use_slots eq 'map' || $use_slots eq 'map_map') { + my ($map) = &Apache::lonnet::decode_symb($symb); + $parm_symb = &Apache::lonnet::symbread($map); + $parm_level = 2; + } + foreach my $other_slot (split(/:/, $value)) { if ($other_slot eq $slot_name) { my %consumed=&Apache::lonnet::dump('slot_reservations', $cdom, $cnum, "^$slot_name\0"); - - my $me=$env{'user.name'}.'@'.$env{'user.domain'}; + if (&Apache::lonnet::error($value)) { + return 'error: Unable to determine current status'; + } + my $me=$env{'user.name'}.':'.$env{'user.domain'}; foreach my $key (keys(%consumed)) { if ($consumed{$key}->{'name'} eq $me) { my $num=(split('\0',$key))[1]; @@ -190,7 +283,9 @@ sub make_reservation { if (!defined($max)) { $max=99999; } my (@ids)=&get_reservation_ids($slot_name); - + if (&Apache::lonnet::error(@ids)) { + return 'error: Unable to determine current status'; + } my $last=0; foreach my $id (@ids) { my $num=(split('\0',$id))[1]; @@ -204,9 +299,9 @@ sub make_reservation { return undef; } - my %reservation=('name' => $env{'user.name'}.'@'.$env{'user.domain'}, + my %reservation=('name' => $env{'user.name'}.':'.$env{'user.domain'}, 'timestamp' => time, - 'symb' => $symb); + 'symb' => $parm_symb); my $success=&Apache::lonnet::newput('slot_reservations', {"$slot_name\0$wanted" => @@ -218,12 +313,7 @@ sub make_reservation { if ($value) { $new_value=$value.':'.$new_value; } - my $result=&Apache::lonparmset::storeparm_by_symb($symb, - '0_availablestudent', - 1, $new_value, 'string', - $env{'user.name'}, - $env{'user.domain'}); - &Apache::lonxml::debug("hrrm $result"); + &store_slot_parm($symb,$slot_name,$parm_level,$new_value,$cnum,$cdom); return $wanted; } @@ -231,17 +321,193 @@ sub make_reservation { return undef; } +sub store_slot_parm { + my ($symb,$slot_name,$parm_level,$new_value,$cnum,$cdom) = @_; + my $result=&Apache::lonparmset::storeparm_by_symb($symb, + '0_availablestudent', + $parm_level, $new_value, + 'string', + $env{'user.name'}, + $env{'user.domain'}); + &Apache::lonxml::debug("hrrm $result"); + my %storehash = ( + symb => $symb, + slot => $slot_name, + action => 'reserve', + context => $env{'form.context'}, + ); + + &Apache::lonnet::instructor_log('slotreservationslog',\%storehash, + '',$env{'user.name'},$env{'user.domain'}, + $cnum,$cdom); + return; +} + +sub remove_registration { + my ($r) = @_; + if ($env{'form.entry'} ne 'remove all') { + return &remove_registration_user($r); + } + my $slot_name = $env{'form.slotname'}; + my %slot=&Apache::lonnet::get_slot($slot_name); + + my ($cnum,$cdom)=&get_course(); + my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum, + "^$slot_name\0"); + if (&Apache::lonnet::error(%consumed)) { + $r->print("<p><span class=\"LC_error\">".&mt('A network error has occurred.').'</span></p>'); + return; + } + if (!%consumed) { + $r->print('<p>'.&mt('Slot [_1] has no reservations.', + '<tt>'.$slot_name.'</tt>').'</p>'); + return; + } + + my @names = map { $consumed{$_}{'name'} } (sort(keys(%consumed))); + my $names = join(' ',@names); + + my $msg = &mt('Remove all of [_1] from slot [_2]?',$names,$slot_name); + &remove_registration_confirmation($r,$msg,['entry','slotname','context']); +} + +sub remove_registration_user { + my ($r) = @_; + + my $slot_name = $env{'form.slotname'}; + + my $name = &Apache::loncommon::plainname($env{'form.uname'}, + $env{'form.udom'}); + + my $title = &Apache::lonnet::gettitle($env{'form.symb'}); + + my $msg = &mt('Remove [_1] from slot [_2] for [_3]', + $name,$slot_name,$title); + + &remove_registration_confirmation($r,$msg,['uname','udom','slotname', + 'entry','symb','context']); +} + +sub remove_registration_confirmation { + my ($r,$msg,$inputs) =@_; + + my $hidden_input; + foreach my $parm (@{$inputs}) { + $hidden_input .= + '<input type="hidden" name="'.$parm.'" value="' + .&HTML::Entities::encode($env{'form.'.$parm},'"<>&\'').'" />'."\n"; + } + my %lt = &Apache::lonlocal::texthash('yes' => 'Yes', + 'no' => 'No',); + $r->print(<<"END_CONFIRM"); +<p> $msg </p> +<form action="/adm/slotrequest" method="post"> + <input type="hidden" name="command" value="release" /> + <input type="hidden" name="button" value="yes" /> + $hidden_input + <input type="submit" value="$lt{'yes'}" /> +</form> +<form action="/adm/slotrequest" method="post"> + <input type="hidden" name="command" value="showslots" /> + <input type="submit" value="$lt{'no'}" /> +</form> +END_CONFIRM + +} + +sub release_all_slot { + my ($r,$mgr)=@_; + + my $slot_name = $env{'form.slotname'}; + + my ($cnum,$cdom)=&get_course(); + + my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum, + "^$slot_name\0"); + + $r->print('<p>'.&mt('Releasing reservations').'</p>'); + + foreach my $entry (sort { $consumed{$a}{'name'} cmp + $consumed{$b}{'name'} } (keys(%consumed))) { + my ($uname,$udom) = split(':',$consumed{$entry}{'name'}); + my ($result,$msg) = + &release_reservation($slot_name,$uname,$udom, + $consumed{$entry}{'symb'},$mgr); + if (!$result) { + $r->print('<p><span class="LC_error">'.&mt($msg).'</span></p>'); + } else { + $r->print("<p>$msg</p>"); + } + $r->rflush(); + } + $r->print('<p><a href="/adm/slotrequest?command=showslots">'. + &mt('Return to slot list').'</a></p>'); + &return_link($r); +} + sub release_slot { - my ($r,$symb,$slot_name,$inhibit_return_link)=@_; + my ($r,$symb,$slot_name,$inhibit_return_link,$mgr)=@_; if ($slot_name eq '') { $slot_name=$env{'form.slotname'}; } - my ($cnum,$cdom)=&get_course(); + + my ($uname,$udom) = ($env{'user.name'}, $env{'user.domain'}); + if ($mgr eq 'F' + && defined($env{'form.uname'}) && defined($env{'form.udom'})) { + ($uname,$udom) = ($env{'form.uname'}, $env{'form.udom'}); + } + + if ($mgr eq 'F' + && defined($env{'form.symb'})) { + $symb = &unescape($env{'form.symb'}); + } + + my ($result,$msg) = + &release_reservation($slot_name,$uname,$udom,$symb,$mgr); + if (!$result) { + $r->print('<p><span class="LC_error">'.&mt($msg).'</span></p>'); + } else { + $r->print("<p>$msg</p>"); + } + + if ($mgr eq 'F') { + $r->print('<p><a href="/adm/slotrequest?command=showslots">'. + &mt('Return to slot list').'</a></p>'); + } + + if (!$inhibit_return_link) { &return_link($r); } + return $result; +} + +sub release_reservation { + my ($slot_name,$uname,$udom,$symb,$mgr) = @_; + my %slot=&Apache::lonnet::get_slot($slot_name); + my $description=&get_description($slot_name,\%slot); + + if ($mgr ne 'F') { + if ($slot{'starttime'} < time) { + return (0,&mt('Not allowed to release Reservation: [_1], as it has already ended.',$description)); + } + } + + # if the reservation symb is for a map get a resource in that map + # to check slot parameters on + my $navmap=Apache::lonnavmaps::navmap->new; + if (!defined($navmap)) { + return (0,'error: Unable to determine current status'); + } + my $passed_resource = $navmap->getBySymb($symb); + if ($passed_resource->is_map()) { + my ($a_resource) = + $navmap->retrieveResources($passed_resource, + sub {$_[0]->is_problem()},0,1); + $symb = $a_resource->symb(); + } # get parameter string, check for existance, rebuild string with the slot - - my @slots = split(/:/,&Apache::lonnet::EXT("resource.0.availablestudent", - $symb,$env{'user.domain'}, - $env{'user.name'})); + my $student = &Apache::lonnet::EXT("resource.0.availablestudent", + $symb,$udom,$uname); + my @slots = split(/:/,$student); + my @new_slots; foreach my $exist_slot (@slots) { if ($exist_slot eq $slot_name) { next; } @@ -249,138 +515,277 @@ sub release_slot { } my $new_param = join(':',@new_slots); + my ($cnum,$cdom)=&get_course(); + # get slot reservations, check if user has one, if so remove reservation my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum, "^$slot_name\0"); foreach my $entry (keys(%consumed)) { - if ( $consumed{$entry}->{'name'} eq - ($env{'user.name'}.'@'.$env{'user.domain'}) ) { + if ( $consumed{$entry}->{'name'} eq ($uname.':'.$udom) ) { &Apache::lonnet::del('slot_reservations',[$entry], $cdom,$cnum); + my %storehash = ( + symb => $symb, + slot => $slot_name, + action => 'release', + context => $env{'form.context'}, + ); + &Apache::lonnet::instructor_log('slotreservationslog',\%storehash, + 1,$uname,$udom,$cnum,$cdom); } } + + my $use_slots = &Apache::lonnet::EXT("resource.0.useslots", + $symb,$udom,$uname); + &Apache::lonxml::debug("use_slots is $use_slots<br />"); + + if (&Apache::lonnet::error($use_slots)) { + return (0,'error: Unable to determine current status'); + } + + my $parm_level = 1; + if ($use_slots eq 'map' || $use_slots eq 'map_map') { + $parm_level = 2; + } # store new parameter string my $result=&Apache::lonparmset::storeparm_by_symb($symb, '0_availablestudent', - 1, $new_param, 'string', - $env{'user.name'}, - $env{'user.domain'}); + $parm_level, $new_param, + 'string', $uname, $udom); + my $msg; + if ($mgr eq 'F') { + $msg = &mt('Released Reservation for user: [_1]',"$uname:$udom"); + } else { + $msg = &mt('Released Reservation: [_1]',$description); + } + return (1,$msg); +} + +sub delete_slot { + my ($r)=@_; + + my $slot_name = $env{'form.slotname'}; my %slot=&Apache::lonnet::get_slot($slot_name); - my $description=&get_description($env{'form.slotname'},\%slot); - $r->print("<p>Released Reservation: $description</p>"); - if (!$inhibit_return_link) { - $r->print('<p><a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); + + my ($cnum,$cdom)=&get_course(); + my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum, + "^$slot_name\0"); + my ($tmp) = %consumed; + if ($tmp =~ /error: 2/) { undef(%consumed); } + + if (%slot && !%consumed) { + $slot{'type'} = 'deleted'; + my $ret = &Apache::lonnet::cput('slots', {$slot_name => \%slot}, + $cdom, $cnum); + if ($ret eq 'ok') { + $r->print('<p>'.&mt('Slot [_1] marked as deleted.','<tt>'.$slot_name.'</tt>').'</p>'); + } else { + $r->print('<p><span class="LC_error">'.&mt('An error occurred when attempting to delete slot: [_1]','<tt>'.$slot_name.'</tt>')." ($ret)</span></p>"); + } + } else { + if (%consumed) { + $r->print('<p>'.&mt('Slot [_1] has active reservations.','<tt>'.$slot_name.'</tt>').'</p>'); + } else { + $r->print('<p>'.&mt('Slot [_1] does not exist.','<tt>'.$slot_name.'</tt>').'</p>'); + } } - return 1; + $r->print('<p><a href="/adm/slotrequest?command=showslots">'. + &mt('Return to slot list').'</a></p>'); + &return_link($r); +} + +sub return_link { + my ($r) = @_; + $r->print('<p><a href="/adm/flip?postdata=return:">'. + &mt('Return to last resource').'</a></p>'); } sub get_slot { - my ($r,$symb)=@_; + my ($r,$symb,$conflictable_slot,$inhibit_return_link)=@_; + + my %slot=&Apache::lonnet::get_slot($env{'form.slotname'}); + my $slot_name=&check_for_conflict($symb,$env{'form.slotname'},\%slot); - my $slot_name=&check_for_conflict($symb,$env{'form.slotname'}); - if ($slot_name) { + if ($slot_name =~ /^error: (.*)/) { + $r->print('<p><span class="LC_error">' + .&mt('An error occurred while attempting to make a reservation. ([_1])',$1) + .'</span></p>'); + &return_link($r); + return 0; + } + if ($slot_name && $slot_name ne $conflictable_slot) { my %slot=&Apache::lonnet::get_slot($slot_name); my $description1=&get_description($slot_name,\%slot); %slot=&Apache::lonnet::get_slot($env{'form.slotname'}); my $description2=&get_description($env{'form.slotname'},\%slot); - $r->print("<p>Already have a reservation: $description1</p>"); + $r->print('<p>'.&mt('Already have a reservation: [_1].',$description1).'</p>'); if ($slot_name ne $env{'form.slotname'}) { $r->print(<<STUFF); -<form method="POST" action="/adm/slotrequest"> +<form method="post" action="/adm/slotrequest"> <input type="hidden" name="symb" value="$env{'form.symb'}" /> <input type="hidden" name="slotname" value="$env{'form.slotname'}" /> <input type="hidden" name="releaseslot" value="$slot_name" /> <input type="hidden" name="command" value="change" /> STUFF - $r->print("<p>You can either "); - $r->print(<<STUFF); - <input type="submit" name="change" value="Change" /> -STUFF - $r->print(' your reservation from <b>'.$description1.'</b> to <b>'. - $description2. - '</b> <br />or <a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); + $r->print('<p>' + .&mt('You can either [_1]Change[_2] your reservation from [_3] to [_4] or' + ,'<input type="submit" name="change" value="' + ,'" />' + ,'<b>'.$description1.'</b>' + ,'<b>'.$description2.'</b>') + .'<br /></p>' + ); + &return_link($r); $r->print(<<STUFF); </form> STUFF } else { - $r->print('<p><a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); + &return_link($r); } - return; + return 0; } - my %slot=&Apache::lonnet::get_slot($env{'form.slotname'}); + + my ($cnum,$cdom)=&get_course(); my $reserved=&make_reservation($env{'form.slotname'}, - \%slot,$symb); + \%slot,$symb,$cnum,$cdom); my $description=&get_description($env{'form.slotname'},\%slot); if (defined($reserved)) { - if ($reserved > -1) { - $r->print("<p>Success: $description</p>"); - $r->print('<p><a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); - return; + my $retvalue = 0; + if ($slot_name =~ /^error: (.*)/) { + $r->print('<p><span class="LC_error">' + .&mt('An error occurred while attempting to make a reservation. ([_1])',$1) + .'</span></p>'); + } elsif ($reserved > -1) { + $r->print('<p>'.&mt('Success: [_1]',$description).'</p>'); + $retvalue = 1; } elsif ($reserved < 0) { - $r->print("<p>Already reserved: $description</p>"); - $r->print('<p><a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); - return; + $r->print('<p>'.&mt('Already reserved: [_1]',$description).'</p>'); } + if (!$inhibit_return_link) { &return_link($r); } + return 1; } my %lt=('request'=>"Availibility list", - 'try' =>'Try again'); + 'try' =>'Try again?', + 'or' => 'or'); %lt=&Apache::lonlocal::texthash(%lt); + my $extra_input; + if ($conflictable_slot) { + $extra_input='<input type="hidden" name="releaseslot" value="'.$env{'form.slotname'}.'" />'; + } + + $r->print('<p>'.&mt('[_1]Failed[_2] to reserve a slot for [_3].','<span class="LC_warning">','</span>',$description).'</p>'); $r->print(<<STUFF); -<p> <font color="red">Failed</font> to reserve a spot for $description. </p> <p> -<form method="POST" action="/adm/slotrequest"> +<form method="post" action="/adm/slotrequest"> <input type="submit" name="Try Again" value="$lt{'try'}" /> <input type="hidden" name="symb" value="$env{'form.symb'}" /> <input type="hidden" name="slotname" value="$env{'form.slotname'}" /> - <input type="hidden" name="command" value="get" /> + <input type="hidden" name="command" value="$env{'form.command'}" /> + $extra_input </form> -? </p> <p> -or -<form method="POST" action="/adm/slotrequest"> +$lt{'or'} +<form method="post" action="/adm/slotrequest"> <input type="hidden" name="symb" value="$env{'form.symb'}" /> <input type="submit" name="requestattempt" value="$lt{'request'}" /> </form> -</p> -or STUFF - $r->print('<p><a href="/adm/flip?postdata=return:">'. - &mt('Return to last resource').'</a></p>'); - return; + + if (!$inhibit_return_link) { + $r->print(&mt('or').'</p>').&return_link($r); + } else { + $r->print('</p>'); + } + return 0; } sub allowed_slot { - my ($slot_name,$slot,$symb)=@_; + my ($slot_name,$slot,$symb,$slots,$consumed_uniqueperiods)=@_; + #already started if ($slot->{'starttime'} < time) { - # all open slot to be schedulable - #return 0; + return 0; } &Apache::lonxml::debug("$slot_name starttime good"); + #already ended if ($slot->{'endtime'} < time) { return 0; } &Apache::lonxml::debug("$slot_name endtime good"); + # not allowed to pick this one if (defined($slot->{'type'}) && $slot->{'type'} ne 'schedulable_student') { return 0; } &Apache::lonxml::debug("$slot_name type good"); + + # reserve time not yet started + if ($slot->{'startreserve'} > time) { + return 0; + } + &Apache::lonxml::debug("$slot_name reserve good"); + + my $userallowed=0; + # its for a different set of users + if (defined($slot->{'allowedsections'})) { + if (!defined($env{'request.role.sec'}) + && grep(/^No section assigned$/, + split(',',$slot->{'allowedsections'}))) { + $userallowed=1; + } + if (defined($env{'request.role.sec'}) + && grep(/^\Q$env{'request.role.sec'}\E$/, + split(',',$slot->{'allowedsections'}))) { + $userallowed=1; + } + if (defined($env{'request.course.groups'})) { + my @groups = split(/:/,$env{'request.course.groups'}); + my @allowed_sec = split(',',$slot->{'allowedsections'}); + foreach my $group (@groups) { + if (grep {$_ eq $group} (@allowed_sec)) { + $userallowed=1; + last; + } + } + } + } + &Apache::lonxml::debug("$slot_name sections is $userallowed"); + + # its for a different set of users + if (defined($slot->{'allowedusers'}) + && grep(/^\Q$env{'user.name'}:$env{'user.domain'}\E$/, + split(',',$slot->{'allowedusers'}))) { + $userallowed=1; + } + + if (!defined($slot->{'allowedusers'}) + && !defined($slot->{'allowedsections'})) { + $userallowed=1; + } + + &Apache::lonxml::debug("$slot_name user is $userallowed"); + return 0 if (!$userallowed); + # not allowed for this resource if (defined($slot->{'symb'}) && $slot->{'symb'} ne $symb) { return 0; } + + my $conflict = &check_for_conflict($symb,$slot_name,$slot,$slots, + $consumed_uniqueperiods); + if ($conflict =~ /^error: /) { + return 0; + } elsif ($conflict ne '') { + if ($slots->{$conflict}{'starttime'} < time) { + return 0; + } + } &Apache::lonxml::debug("$slot_name symb good"); return 1; } @@ -401,37 +806,73 @@ sub show_choices { my ($cnum,$cdom)=&get_course(); my %slots=&Apache::lonnet::dump('slots',$cdom,$cnum); + my $consumed_uniqueperiods = &get_consumed_uniqueperiods(\%slots); + if (ref($consumed_uniqueperiods) eq 'HASH') { + if (&Apache::lonnet::error(%$consumed_uniqueperiods)) { + $r->print('<span class="LC_error">'. + &mt('An error occurred determining slot availability'). + '</span>'); + return; + } + } elsif ($consumed_uniqueperiods =~ /^error: /) { + $r->print('<span class="LC_error">'. + &mt('An error occurred determining slot availability'). + '</span>'); + return; + } my $available; - $r->print('<table border="1">'); &Apache::lonxml::debug("Checking Slots"); - my ($got_slot)=&check_for_reservation($symb); + my @got_slots=&check_for_reservation($symb,'allslots'); + if ($got_slots[0] =~ /^error: /) { + $r->print('<span class="LC_error">'. + &mt('An error occurred determining slot availability'). + '</span>'); + return; + } + $r->print('<table border="1">'); foreach my $slot (sort { return $slots{$a}->{'starttime'} <=> $slots{$b}->{'starttime'} } (keys(%slots))) { &Apache::lonxml::debug("Checking Slot $slot"); - next if (!&allowed_slot($slot,$slots{$slot})); + next if (!&allowed_slot($slot,$slots{$slot},undef,\%slots, + $consumed_uniqueperiods)); $available++; my $description=&get_description($slot,$slots{$slot}); my $form=&mt('Unavailable'); - if (($slot eq $got_slot) || + if ((grep(/^\Q$slot\E$/,@got_slots)) || &space_available($slot,$slots{$slot},$symb)) { my $text=&mt('Select'); my $command='get'; - if ($slot eq $got_slot) { - $text=&mt('Free Reservation'); + if (grep(/^\Q$slot\E$/,@got_slots)) { + $text=&mt('Drop Reservation'); $command='release'; + } else { + my $conflict = &check_for_conflict($symb,$slot,$slots{$slot}, + \%slots, + $consumed_uniqueperiods); + if ($conflict) { + if ($conflict =~ /^error: /) { + $r->print('<tr><td><span class="LC_error" colspan="2">' + .&mt('Slot: [_1] has unknown status.',$description) + .'</span></td></tr>'); + } else { + $text=&mt('Change Reservation'); + $command='get'; + } + } } - my $escsymb=&Apache::lonnet::escape($symb); + my $escsymb=&escape($symb); $form=<<STUFF; - <form method="POST" action="/adm/slotrequest"> + <form method="post" action="/adm/slotrequest"> <input type="submit" name="Select" value="$text" /> <input type="hidden" name="symb" value="$escsymb" /> <input type="hidden" name="slotname" value="$slot" /> <input type="hidden" name="command" value="$command" /> + <input type="hidden" name="context" value="user" /> </form> STUFF } @@ -444,17 +885,38 @@ STUFF } if (!$available) { - $r->print('<tr><td>No available times. <a href="/adm/flip?postdata=return:">'. + $r->print('<tr><td>'.&mt('No available times.'). + ' <a href="/adm/flip?postdata=return:">'. &mt('Return to last resource').'</a></td></tr>'); } $r->print('</table>'); } sub to_show { - my ($when,$slot) = @_; + my ($slotname,$slot,$when,$deleted,$name) = @_; my $time=time; my $week=60*60*24*7; - if ($when eq 'now') { + + if ($deleted eq 'hide' && $slot->{'type'} eq 'deleted') { + return 0; + } + + if ($name && $name->{'value'} =~ /\w/) { + if ($name->{'type'} eq 'substring') { + if ($slotname !~ /\Q$name->{'value'}\E/) { + return 0; + } + } + if ($name->{'type'} eq 'exact') { + if ($slotname eq $name->{'value'}) { + return 0; + } + } + } + + if ($when eq 'any') { + return 1; + } elsif ($when eq 'now') { if ($time > $slot->{'starttime'} && $time < $slot->{'endtime'}) { return 1; @@ -493,6 +955,30 @@ sub to_show { return 1; } +sub remove_link { + my ($slotname,$entry,$uname,$udom,$symb) = @_; + + my $remove = &mt('Remove'); + + if ($entry eq 'remove all') { + $remove = &mt('Remove All'); + undef($uname); + undef($udom); + } + + $slotname = &escape($slotname); + $entry = &escape($entry); + $uname = &escape($uname); + $udom = &escape($udom); + $symb = &escape($symb); + + return <<"END_LINK"; + <a href="/adm/slotrequest?command=remove_registration&slotname=$slotname&entry=$entry&uname=$uname&udom=$udom&symb=$symb&context=manage" + >($remove)</a> +END_LINK + +} + sub show_table { my ($r,$mgr)=@_; @@ -503,83 +989,177 @@ sub show_table { } my $available; if ($mgr eq 'F') { + # FIXME: This line should be deleted once Slots uses breadcrumbs + $r->print(&Apache::loncommon::help_open_topic('Slot About', 'Help on slots')); + $r->print('<div>'); - $r->print('<form method="POST" action="/adm/slotrequest"> + $r->print('<form method="post" action="/adm/slotrequest"> <input type="hidden" name="command" value="uploadstart" /> <input type="submit" name="start" value="'.&mt('Upload Slot List').'" /> </form>'); - $r->print('<form method="POST" action="/adm/helper/newslot.helper"> + $r->print(&Apache::loncommon::help_open_topic('Slot CommaDelimited')); + $r->print('<form method="post" action="/adm/helper/newslot.helper"> <input type="submit" name="newslot" value="'.&mt('Create a New Slot').'" /> </form>'); + $r->print(&Apache::loncommon::help_open_topic('Slot AddInterface')); $r->print('</div>'); } - my %Saveable_Parameters = ('show' => 'array', - 'when' => 'scalar', - 'order' => 'scalar'); - - &Apache::loncommon::store_course_settings('slotrequest',\%Saveable_Parameters); - &Apache::loncommon::restore_course_settings('slotrequest',\%Saveable_Parameters); + my %Saveable_Parameters = ('show' => 'array', + 'when' => 'scalar', + 'order' => 'scalar', + 'deleted' => 'scalar', + 'name_filter_type' => 'scalar', + 'name_filter_value' => 'scalar', + ); + &Apache::loncommon::store_course_settings('slotrequest', + \%Saveable_Parameters); + &Apache::loncommon::restore_course_settings('slotrequest', + \%Saveable_Parameters); + &Apache::grades::init_perm(); + my ($classlist,$section,$fullname)=&Apache::grades::getclasslist('all'); + &Apache::grades::reset_perm(); + # what to display filtering my %show_fields=&Apache::lonlocal::texthash( - 'name' => 'Slot Name', - 'description' => 'Description', - 'type' => 'Type', - 'starttime' => 'Start time', - 'endtime' => 'End Time', - 'startreserve' => 'Time students can start reserving', - 'secret' => 'Secret Word', - 'maxspace' => 'Maxium # of students', - 'ip' => 'IP or DNS restrictions', - 'symb' => 'Resource slot is restricted to.', - 'uniqueperiod' => 'Period of time slot is unique', - 'proctor' => 'List of proctors'); + 'name' => 'Slot Name', + 'description' => 'Description', + 'type' => 'Type', + 'starttime' => 'Start time', + 'endtime' => 'End Time', + 'startreserve' => 'Time students can start reserving', + 'secret' => 'Secret Word', + 'space' => '# of students/max', + 'ip' => 'IP or DNS restrictions', + 'symb' => 'Resource slot is restricted to.', + 'allowedsections' => 'Sections slot is restricted to.', + 'allowedusers' => 'Users slot is restricted to.', + 'uniqueperiod' => 'Period of time slot is unique', + 'scheduled' => 'Scheduled Students', + 'proctor' => 'List of proctors'); my @show_order=('name','description','type','starttime','endtime', - 'startreserve','secret','maxspace','ip','symb', - 'uniqueperiod','proctor'); + 'startreserve','secret','space','ip','symb', + 'allowedsections','allowedusers','uniqueperiod', + 'scheduled','proctor'); my @show = (exists($env{'form.show'})) ? &Apache::loncommon::get_env_multiple('form.show') : keys(%show_fields); my %show = map { $_ => 1 } (@show); + #when filtering setup my %when_fields=&Apache::lonlocal::texthash( - 'now' => 'Open now', + 'now' => 'Open now', 'nextweek' => 'Open within the next week', 'lastweek' => 'Were open last week', 'willopen' => 'Will open later', - 'wereopen' => 'Were open'); - my @when_order=('now','nextweek','lastweek','willopen','wereopen'); + 'wereopen' => 'Were open', + 'any' => 'Anytime', + ); + my @when_order=('any','now','nextweek','lastweek','willopen','wereopen'); $when_fields{'select_form_order'} = \@when_order; my $when = (exists($env{'form.when'})) ? $env{'form.when'} : 'now'; - $r->print('<form method="POST" action="/adm/slotrequest"> + #display of students setup + my %stu_display_fields= + &Apache::lonlocal::texthash('username' => 'User name', + 'fullname' => 'Full name', + ); + my @stu_display_order=('fullname','username'); + my @stu_display = + (exists($env{'form.studisplay'})) ? &Apache::loncommon::get_env_multiple('form.studisplay') + : keys(%stu_display_fields); + my %stu_display = map { $_ => 1 } (@stu_display); + + #name filtering setup + my %name_filter_type_fields= + &Apache::lonlocal::texthash('substring' => 'Substring', + 'exact' => 'Exact', + #'reg' => 'Regular Expression', + ); + my @name_filter_type_order=('substring','exact'); + + $name_filter_type_fields{'select_form_order'} = \@name_filter_type_order; + my $name_filter_type = + (exists($env{'form.name_filter_type'})) ? $env{'form.name_filter_type'} + : 'substring'; + my $name_filter = {'type' => $name_filter_type, + 'value' => $env{'form.name_filter_value'},}; + + + #deleted slot filtering + #default to hide if no value + $env{'form.deleted'} ||= 'hide'; + my $hide_radio = + &Apache::lonhtmlcommon::radio('deleted',$env{'form.deleted'},'hide'); + my $show_radio = + &Apache::lonhtmlcommon::radio('deleted',$env{'form.deleted'},'show'); + + $r->print('<form method="post" action="/adm/slotrequest"> <input type="hidden" name="command" value="showslots" />'); $r->print('<div>'); - $r->print('<table class="inline"><tr><th>'.&mt('Show').'</th><th>'.&mt('Open').'</th></tr><tr><td>'.&Apache::loncommon::multiple_select_form('show',\@show,6,\%show_fields,\@show_order). - '</td><td>'.&Apache::loncommon::select_form($when,'when',%when_fields). - '</td></tr></table>'); + $r->print('<table class="inline"> + <tr><th>'.&mt('Show').'</th> + <th>'.&mt('Student Display').'</th> + <th>'.&mt('Open').'</th> + <th>'.&mt('Slot Name Filter').'</th> + <th>'.&mt('Options').'</th> + </tr> + <tr><td>'.&Apache::loncommon::multiple_select_form('show',\@show,6,\%show_fields,\@show_order). + '</td> + <td> + '.&Apache::loncommon::multiple_select_form('studisplay',\@stu_display, + 6,\%stu_display_fields, + \@stu_display_order).' + </td> + <td>'.&Apache::loncommon::select_form($when,'when',%when_fields). + '</td> + <td>'.&Apache::loncommon::select_form($name_filter_type, + 'name_filter_type', + %name_filter_type_fields). + '<br />'. + &Apache::lonhtmlcommon::textbox('name_filter_value', + $env{'form.name_filter_value'}, + 15). + '</td> + <td> + <table> + <tr> + <td rowspan="2">Deleted slots:</td> + <td><label>'.$show_radio.'Show</label></td> + </tr> + <tr> + <td><label>'.$hide_radio.'Hide</label></td> + </tr> + </table> + </td> + </tr> + </table>'); $r->print('</div>'); $r->print('<p><input type="submit" name="start" value="'.&mt('Update Display').'" /></p>'); my $linkstart='<a href="/adm/slotrequest?command=showslots&order='; - $r->print('<table class="thinborder"> -<tr> - <th></th>'); + $r->print(&Apache::loncommon::start_data_table(). + &Apache::loncommon::start_data_table_header_row().' + <th></th>'); foreach my $which (@show_order) { if ($which ne 'proctor' && exists($show{$which})) { $r->print('<th>'.$linkstart.$which.'">'.$show_fields{$which}.'</a></th>'); } } - $r->print('<th>Scheduled Students</th></tr>'); + $r->print(&Apache::loncommon::end_data_table_header_row()); my %name_cache; my $slotsort = sub { - if ($env{'form.order'}=~/^(type|description|endtime|startreserve|maxspace|ip|symb)$/) { + if ($env{'form.order'}=~/^(type|description|endtime|startreserve|ip|symb|allowedsections|allowedusers)$/) { if (lc($slots{$a}->{$env{'form.order'}}) ne lc($slots{$b}->{$env{'form.order'}})) { return (lc($slots{$a}->{$env{'form.order'}}) cmp lc($slots{$b}->{$env{'form.order'}})); } + } elsif ($env{'form.order'} eq 'space') { + if ($slots{$a}{'maxspace'} ne $slots{$b}{'maxspace'}) { + return ($slots{$a}{'maxspace'} cmp $slots{$b}{'maxspace'}); + } } elsif ($env{'form.order'} eq 'name') { if (lc($a) cmp lc($b)) { return lc($a) cmp lc($b); @@ -599,20 +1179,50 @@ sub show_table { } return $slots{$a}->{'starttime'} <=> $slots{$b}->{'starttime'}; }; + + my %consumed; + if (exists($show{'scheduled'}) || exists($show{'space'}) ) { + %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum); + my ($tmp)=%consumed; + if ($tmp =~ /^error: /) { undef(%consumed); } + } + foreach my $slot (sort $slotsort (keys(%slots))) { - if (!&to_show($when,$slots{$slot})) { next; } + if (!&to_show($slot,$slots{$slot},$when, + $env{'form.deleted'},$name_filter)) { next; } if (defined($slots{$slot}->{'type'}) && $slots{$slot}->{'type'} ne 'schedulable_student') { #next; } my $description=&get_description($slot,$slots{$slot}); - my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum, - "^$slot\0"); - my $ids; - foreach my $entry (sort(keys(%consumed))) { - my (undef,$id)=split("\0",$entry); - $ids.= $id.'-> '.$consumed{$entry}->{'name'}.'<br />'; + my ($id_count,$ids); + + if (exists($show{'scheduled'}) || exists($show{'space'}) ) { + my $re_str = "$slot\0"; + my @this_slot = grep(/^\Q$re_str\E/,keys(%consumed)); + $id_count = scalar(@this_slot); + if (exists($show{'scheduled'})) { + foreach my $entry (sort { $consumed{$a}{name} cmp + $consumed{$b}{name} } + (@this_slot)) { + my (undef,$id)=split("\0",$entry); + my ($uname,$udom) = split(':',$consumed{$entry}{'name'}); + $ids.= '<span class="LC_nobreak">'; + foreach my $item (@stu_display_order) { + if ($stu_display{$item}) { + if ($item eq 'fullname') { + $ids.=$fullname->{"$uname:$udom"}.' '; + } elsif ($item eq 'username') { + $ids.="<tt>$uname:$udom</tt> "; + } + } + } + $ids.=&remove_link($slot,$entry,$uname,$udom, + $consumed{$entry}{'symb'}).'</span><br />'; + } + } } + my $start=($slots{$slot}->{'starttime'}? &Apache::lonlocal::locallocaltime($slots{$slot}->{'starttime'}):''); my $end=($slots{$slot}->{'endtime'}? @@ -622,9 +1232,10 @@ sub show_table { my $unique; if (ref($slots{$slot}{'uniqueperiod'})) { - $unique=localtime($slots{$slot}{'uniqueperiod'}[0]).','. + $unique=localtime($slots{$slot}{'uniqueperiod'}[0]).', '. localtime($slots{$slot}{'uniqueperiod'}[1]); } + my $title; if (exists($slots{$slot}{'symb'})) { my (undef,undef,$res)= @@ -633,16 +1244,38 @@ sub show_table { $title = &Apache::lonnet::gettitle($slots{$slot}{'symb'}); $title='<a href="'.$res.'?symb='.$slots{$slot}{'symb'}.'">'.$title.'</a>'; } + + my $allowedsections; + if (exists($show{'allowedsections'})) { + $allowedsections = + join(', ',sort(split(/\s*,\s*/, + $slots{$slot}->{'allowedsections'}))); + } + + my @allowedusers; + if (exists($show{'allowedusers'})) { + @allowedusers= map { + my ($uname,$udom)=split(/:/,$_); + my $fullname=$name_cache{$_}; + if (!defined($fullname)) { + $fullname = &Apache::loncommon::plainname($uname,$udom); + $fullname =~s/\s/ /g; + $name_cache{$_} = $fullname; + } + &Apache::loncommon::aboutmewrapper($fullname,$uname,$udom); + } (sort(split(/\s*,\s*/,$slots{$slot}->{'allowedusers'}))); + } + my $allowedusers=join(', ',@allowedusers); + my @proctors; my $rowspan=1; my $colspan=1; if (exists($show{'proctor'})) { $rowspan=2; @proctors= map { - my ($uname,$udom)=split(/@/,$_); + my ($uname,$udom)=split(/:/,$_); my $fullname=$name_cache{$_}; if (!defined($fullname)) { - &Apache::lonnet::logthis("Gettign $uname $udom"); $fullname = &Apache::loncommon::plainname($uname,$udom); $fullname =~s/\s/ /g; $name_cache{$_} = $fullname; @@ -652,26 +1285,35 @@ sub show_table { } my $proctors=join(', ',@proctors); - my $edit=(<<EDITFORM); -<form method="POST" action="/adm/helper/newslot.helper"> - <input type="hidden" name="name" value="$slot" /> - <input type="submit" name="Edit" value="Edit" /> -</form> -EDITFORM - my $edit=(<<EDITLINK); + my $edit=(<<"EDITLINK"); <a href="/adm/helper/newslot.helper?name=$slot">Edit</a> EDITLINK - - $r->print("<tr>\n<td rowspan=\"$rowspan\">$edit</td>\n"); + + my $delete=(<<"DELETELINK"); +<a href="/adm/slotrequest?command=delete&slotname=$slot">Delete</a> +DELETELINK + + my $remove_all=&remove_link($slot,'remove all').'<br />'; + + if ($ids ne '') { undef($delete); } + if ($slots{$slot}{'type'} ne 'schedulable_student' + || $ids eq '') { + undef($remove_all); + } + + my $row_start=&Apache::loncommon::start_data_table_row(); + my $row_end=&Apache::loncommon::end_data_table_row(); + $r->print($row_start. + "\n<td rowspan=\"$rowspan\">$edit $delete</td>\n"); if (exists($show{'name'})) { $colspan++;$r->print("<td>$slot</td>"); } - if (exists($show{'type'})) { - $colspan++;$r->print("<td>$slots{$slot}->{'type'}</td>\n"); - } if (exists($show{'description'})) { $colspan++;$r->print("<td>$description</td>\n"); } + if (exists($show{'type'})) { + $colspan++;$r->print("<td>$slots{$slot}->{'type'}</td>\n"); + } if (exists($show{'starttime'})) { $colspan++;$r->print("<td>$start</td>\n"); } @@ -684,8 +1326,15 @@ EDITLINK if (exists($show{'secret'})) { $colspan++;$r->print("<td>$slots{$slot}{'secret'}</td>\n"); } - if (exists($show{'maxspace'})) { - $colspan++;$r->print("<td>$slots{$slot}{'maxspace'}</td>\n"); + if (exists($show{'space'})) { + my $display = $id_count; + if ($slots{$slot}{'maxspace'}>0) { + $display.='/'.$slots{$slot}{'maxspace'}; + if ($slots{$slot}{'maxspace'} <= $id_count) { + $display = '<strong>'.$display.' (full) </strong>'; + } + } + $colspan++;$r->print("<td>$display</td>\n"); } if (exists($show{'ip'})) { $colspan++;$r->print("<td>$slots{$slot}{'ip'}</td>\n"); @@ -693,19 +1342,28 @@ EDITLINK if (exists($show{'symb'})) { $colspan++;$r->print("<td>$title</td>\n"); } + if (exists($show{'allowedsections'})) { + $colspan++;$r->print("<td>$allowedsections</td>\n"); + } + if (exists($show{'allowedusers'})) { + $colspan++;$r->print("<td>$allowedusers</td>\n"); + } if (exists($show{'uniqueperiod'})) { $colspan++;$r->print("<td>$unique</td>\n"); } - $colspan++;$r->print("<td>$ids</td>\n</tr>\n"); + if (exists($show{'scheduled'})) { + $colspan++;$r->print("<td>$remove_all $ids</td>\n"); + } + $r->print("$row_end\n"); if (exists($show{'proctor'})) { $r->print(<<STUFF); -<tr> +$row_start <td colspan="$colspan">$proctors</td> -</tr> +$row_end STUFF } } - $r->print('</table>'); + $r->print('</table></form>'); } sub upload_start { @@ -715,7 +1373,7 @@ sub upload_start { $result.=' <b>'. &mt('Specify a file containing the slot definitions.'). '</b></td></tr>'."\n"; - $result.='<tr bgcolor=#ffffe6><td>'."\n"; + $result.='<tr bgcolor="#ffffe6"><td>'."\n"; my $upfile_select=&Apache::loncommon::upfile_select_html(); my $ignore=&mt('Ignore First Line'); $result.=<<ENDUPFORM; @@ -742,9 +1400,11 @@ sub csvuploadmap_header { my $checked=(($env{'form.noFirstLine'})?' checked="checked"':''); my $ignore=&mt('Ignore First Line'); + my $help_field = &Apache::loncommon::help_open_topic('Slot SelectingField'); + $r->print(<<ENDPICK); <form method="post" enctype="multipart/form-data" action="/adm/slotrequest" name="slotupload"> -<h3>Identify fields</h3> +<h3>Identify fields $help_field</h3> Total number of records found in file: $distotal <hr /> Enter as many fields as you can. The system will inform you and bring you back to this page if the data selected is insufficient to create the slots.<hr /> @@ -768,11 +1428,12 @@ ENDPICK sub csvuploadmap_footer { my ($request,$i,$keyfields) =@_; + my $buttontext = &mt('Create Slots'); $request->print(<<ENDPICK); </table> <input type="hidden" name="nfields" value="$i" /> <input type="hidden" name="keyfields" value="$keyfields" /> -<input type="button" onClick="javascript:verify(this.form)" value="Create Slots" /><br /> +<input type="button" onClick="javascript:verify(this.form)" value="$buttontext" /><br /> </form> ENDPICK } @@ -877,7 +1538,10 @@ sub csvupload_fields { ['maxspace','Maximum number of reservations'], ['symb','Resource Restriction'], ['uniqueperiod','Date range of slot exclusion'], - ['secret','Secret word proctor uses to validate']); + ['secret','Secret word proctor uses to validate'], + ['allowedsections','Sections slot is restricted to'], + ['allowedusers','Users slot is restricted to'], + ); } sub csv_upload_assign { @@ -886,7 +1550,7 @@ sub csv_upload_assign { my @slotdata = &Apache::loncommon::upfile_record_sep(); if ($env{'form.noFirstLine'}) { shift(@slotdata); } my %fields=&Apache::grades::get_fields(); - $r->print('<h3>Creating Slots</h3>'); + $r->print('<h3>'.&mt('Creating Slots').'</h3>'); my $cname=$env{'course.'.$env{'request.course.id'}.'.num'}; my $cdom=$env{'course.'.$env{'request.course.id'}.'.domain'}; my $countdone=0; @@ -924,31 +1588,58 @@ sub csv_upload_assign { if ($entries{$fields{'endtime'}}) { $slot{'endtime'}=&UnixDate($entries{$fields{'endtime'}},"%s"); } + + # start/endtime must be defined and greater than zero + if (!$slot{'starttime'}) { + push(@errors,"$name not created -- Invalid start time"); + next; + } + if (!$slot{'endtime'}) { + push(@errors,"$name not created -- Invalid end time"); + next; + } + if ($slot{'starttime'} > $slot{'endtime'}) { + push(@errors,"$name not created -- Slot starts after it ends"); + next; + } + if ($entries{$fields{'startreserve'}}) { $slot{'startreserve'}= &UnixDate($entries{$fields{'startreserve'}},"%s"); } + if (defined($slot{'startreserve'}) + && $slot{'startreserve'} > $slot{'starttime'}) { + push(@errors,"$name not created -- Slot's reservation start time is after the slot's start time."); + next; + } + foreach my $key ('ip','proctor','description','maxspace', 'secret','symb') { if ($entries{$fields{$key}}) { $slot{$key}=$entries{$fields{$key}}; } } + if ($entries{$fields{'uniqueperiod'}}) { my ($start,$end)=split(',',$entries{$fields{'uniqueperiod'}}); my @times=(&UnixDate($start,"%s"), &UnixDate($end,"%s")); $slot{'uniqueperiod'}=\@times; } + if (defined($slot{'uniqueperiod'}) + && $slot{'uniqueperiod'}[0] > $slot{'uniqueperiod'}[1]) { + push(@errors,"$name not created -- Slot's unique period start time is later than the unique period's end time."); + next; + } &Apache::lonnet::cput('slots',{$name=>\%slot},$cdom,$cname); $r->print('.'); $r->rflush(); $countdone++; } - $r->print("<p>Created $countdone slots\n</p>"); + $r->print('<p>'.&mt('Created [quant,_1,slot]',$countdone)."\n".'</p>'); foreach my $error (@errors) { - $r->print("<p>$error\n</p>"); + $r->print('<p><span class="LC_warning">'.$error.'</span></p>'."\n"); } &show_table($r,$mgr); return ''; @@ -976,6 +1667,16 @@ sub handler { if ($env{'form.command'} eq 'showslots' && $vgr eq 'F') { &show_table($r,$mgr); + } elsif ($env{'form.command'} eq 'remove_registration' && $mgr eq 'F') { + &remove_registration($r); + } elsif ($env{'form.command'} eq 'release' && $mgr eq 'F') { + if ($env{'form.entry'} eq 'remove all') { + &release_all_slot($r,$mgr); + } else { + &release_slot($r,undef,undef,undef,$mgr); + } + } elsif ($env{'form.command'} eq 'delete' && $mgr eq 'F') { + &delete_slot($r); } elsif ($env{'form.command'} eq 'uploadstart' && $mgr eq 'F') { &upload_start($r); } elsif ($env{'form.command'} eq 'csvuploadmap' && $mgr eq 'F') { @@ -992,14 +1693,23 @@ sub handler { &csv_upload_map($r); } } else { - my $symb=&Apache::lonnet::unescape($env{'form.symb'}); - my (undef,undef,$res)=&Apache::lonnet::decode_symb($symb); - if ($res !~ /\.task$/) { + my $symb=&unescape($env{'form.symb'}); + if (!defined($symb)) { &fail($r,'not_valid'); return OK; } + my (undef,undef,$res)=&Apache::lonnet::decode_symb($symb); + my $useslots = &Apache::lonnet::EXT("resource.0.useslots",$symb); + if ($useslots ne 'resource' + && $useslots ne 'map' + && $useslots ne 'map_map') { + &fail($r,'not_available'); + return OK; + } $env{'request.symb'}=$symb; - my ($status) = &Apache::lonhomework::check_task_access('0'); + my $type = ($res =~ /\.task$/) ? 'Task' + : 'problem'; + my ($status) = &Apache::lonhomework::check_slot_access('0',$type); if ($status eq 'CAN_ANSWER' || $status eq 'NEEDS_CHECKIN' || $status eq 'WAITING_FOR_GRADE') { @@ -1013,10 +1723,11 @@ sub handler { } elsif ($env{'form.command'} eq 'get') { &get_slot($r,$symb); } elsif ($env{'form.command'} eq 'change') { - &release_slot($r,$symb,$env{'form.releaseslot'},1); - &get_slot($r,$symb); + if (&get_slot($r,$symb,$env{'form.releaseslot'},1)) { + &release_slot($r,$symb,$env{'form.releaseslot'}); + } } else { - $r->print("<p>Unknown command: ".$env{'form.command'}."</p>"); + $r->print('<p>'.&mt('Unknown command: [_1]',$env{'form.command'}).'</p>'); } } &end_page($r);