--- loncom/interface/slotrequest.pm 2005/12/14 22:26:10 1.37
+++ loncom/interface/slotrequest.pm 2006/03/07 21:47:06 1.51
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Handler for requesting to have slots added to a students record
#
-# $Id: slotrequest.pm,v 1.37 2005/12/14 22:26:10 raeburn Exp $
+# $Id: slotrequest.pm,v 1.51 2006/03/07 21:47:06 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -34,6 +34,7 @@ use Apache::Constants qw(:common :http :
use Apache::loncommon();
use Apache::lonlocal;
use Apache::lonnet;
+use Apache::lonnavmaps();
use Date::Manip;
sub fail {
@@ -47,8 +48,7 @@ sub fail {
$r->print('
'.&mt('Failed.').'
');
}
- $r->print(''.
- &mt('Return to last resource').'
');
+ &return_link($r);
&end_page($r);
}
@@ -89,7 +89,9 @@ sub get_reservation_ids {
my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
"^$slot_name\0");
-
+ if (&network_error(%consumed)) {
+ return 'error: Unable to determine current status';
+ }
my ($tmp)=%consumed;
if ($tmp=~/^error: 2 / ) {
return 0;
@@ -111,7 +113,7 @@ sub space_available {
}
sub check_for_reservation {
- my ($symb)=@_;
+ my ($symb,$mode)=@_;
my $student = &Apache::lonnet::EXT("resource.0.availablestudent", $symb,
$env{'user.domain'}, $env{'user.name'});
@@ -124,7 +126,19 @@ sub check_for_reservation {
my ($cnum,$cdom)=&get_course();
my %slots=&Apache::lonnet::get('slots', [@slots], $cdom, $cnum);
- foreach my $slot_name (@slots) {
+ if (&network_error($student) || &network_error($course) ||
+ &network_error(%slots)) {
+ return 'error: Unable to determine current status';
+ }
+ my @got;
+ foreach my $slot_name (sort {
+ if (ref($slots{$a}) && ref($slots{$b})) {
+ return $slots{$a}{'starttime'} <=> $slots{$b}{'starttime'}
+ }
+ if (ref($slots{$a})) { return -1;}
+ if (ref($slots{$b})) { return 1;}
+ return 0;
+ } @slots) {
next if (!defined($slots{$slot_name}) ||
!ref($slots{$slot_name}));
&Apache::lonxml::debug(time." $slot_name ".
@@ -133,29 +147,81 @@ sub check_for_reservation {
if ($slots{$slot_name}->{'endtime'} > time &&
$slots{$slot_name}->{'startreserve'} < time) {
# between start of reservation times and end of slot
- return($slot_name, $slots{$slot_name});
+ if ($mode eq 'allslots') {
+ push(@got,$slot_name);
+ } else {
+ return($slot_name, $slots{$slot_name});
+ }
}
}
+ if ($mode eq 'allslots' && @got) {
+ return @got;
+ }
return (undef,undef);
}
+sub get_consumed_uniqueperiods {
+ my ($slots) = @_;
+ my $navmap=Apache::lonnavmaps::navmap->new;
+ my @problems = $navmap->retrieveResources(undef,
+ sub { $_[0]->is_problem() },1,0);
+ my %used_slots;
+ foreach my $problem (@problems) {
+ my $symb = $problem->symb();
+ my $student = &Apache::lonnet::EXT("resource.0.availablestudent",
+ $symb, $env{'user.domain'},
+ $env{'user.name'});
+ my $course = &Apache::lonnet::EXT("resource.0.available",
+ $symb, $env{'user.domain'},
+ $env{'user.name'});
+ if (&network_error($student) || &network_error($course)) {
+ return 'error: Unable to determine current status';
+ }
+ foreach my $slot (split(/:/,$student), split(/:/, $course)) {
+ $used_slots{$slot}=1;
+ }
+ }
+
+ if (!ref($slots)) {
+ my ($cnum,$cdom)=&get_course();
+ my %slots=&Apache::lonnet::get('slots', [keys(%used_slots)], $cdom, $cnum);
+ if (&network_error(%slots)) {
+ return 'error: Unable to determine current status';
+ }
+ $slots = \%slots;
+ }
+
+ my %consumed_uniqueperiods;
+ foreach my $slot_name (keys(%used_slots)) {
+ next if (!defined($slots->{$slot_name}) ||
+ !ref($slots->{$slot_name}));
+
+ next if (!defined($slots->{$slot_name}{'uniqueperiod'}) ||
+ !ref($slots->{$slot_name}{'uniqueperiod'}));
+ $consumed_uniqueperiods{$slot_name} =
+ $slots->{$slot_name}{'uniqueperiod'};
+ }
+ return \%consumed_uniqueperiods;
+}
+
sub check_for_conflict {
- my ($symb,$new_slot_name)=@_;
- my $student = &Apache::lonnet::EXT("resource.0.availablestudent", $symb,
- $env{'user.domain'}, $env{'user.name'});
- my $course = &Apache::lonnet::EXT("resource.0.available", $symb,
- $env{'user.domain'}, $env{'user.name'});
- my @slots = (split(/:/,$student), split(/:/, $course));
- my ($cnum,$cdom)=&get_course();
- my %slots=&Apache::lonnet::get('slots', [@slots], $cdom, $cnum);
- foreach my $slot_name (@slots) {
- next if (!defined($slots{$slot_name}) ||
- !ref($slots{$slot_name}));
+ my ($symb,$new_slot_name,$new_slot,$slots,$consumed_uniqueperiods)=@_;
+
+ if (!defined($new_slot->{'uniqueperiod'})) { return undef; }
- next if (!defined($slots{$slot_name}->{'uniqueperiod'}) ||
- !ref($slots{$slot_name}->{'uniqueperiod'}));
- my ($start,$end)=@{$slots{$slot_name}->{'uniqueperiod'}};
- if ($start{'uniqueperiod'}};
+ foreach my $slot_name (keys(%$consumed_uniqueperiods)) {
+ my ($start,$end)=@{$consumed_uniqueperiods->{$slot_name}};
+ if (!
+ ($start < $new_uniq_start && $end < $new_uniq_start) ||
+ ($start > $new_uniq_end && $end > $new_uniq_end )) {
return $slot_name;
}
}
@@ -163,6 +229,14 @@ sub check_for_conflict {
}
+sub network_error {
+ my ($result) = @_;
+ if ($result =~ /^(con_lost|no_such_host|error: [^2])/) {
+ return 1;
+ }
+ return 0;
+}
+
sub make_reservation {
my ($slot_name,$slot,$symb)=@_;
@@ -171,11 +245,17 @@ sub make_reservation {
my $value=&Apache::lonnet::EXT("resource.0.availablestudent",$symb,
$env{'user.domain'},$env{'user.name'});
&Apache::lonxml::debug("value is $value ");
+ if (&network_error($value)) {
+ return 'error: Unable to determine current status';
+ }
+
foreach my $other_slot (split(/:/, $value)) {
if ($other_slot eq $slot_name) {
my %consumed=&Apache::lonnet::dump('slot_reservations', $cdom,
$cnum, "^$slot_name\0");
-
+ if (&network_error($value)) {
+ return 'error: Unable to determine current status';
+ }
my $me=$env{'user.name'}.'@'.$env{'user.domain'};
foreach my $key (keys(%consumed)) {
if ($consumed{$key}->{'name'} eq $me) {
@@ -190,7 +270,9 @@ sub make_reservation {
if (!defined($max)) { $max=99999; }
my (@ids)=&get_reservation_ids($slot_name);
-
+ if (&network_error(@ids)) {
+ return 'error: Unable to determine current status';
+ }
my $last=0;
foreach my $id (@ids) {
my $num=(split('\0',$id))[1];
@@ -275,7 +357,16 @@ sub release_slot {
&& defined($env{'form.symb'})) {
$symb = $env{'form.symb'};
}
+ my %slot=&Apache::lonnet::get_slot($slot_name);
+ my $description=&get_description($env{'form.slotname'},\%slot);
+ if ($mgr ne 'F') {
+ if ($slot{'starttime'} < time) {
+ $r->print("Not allowed to release Reservation: $description, as it has already ended.
");
+ &return_link($r);
+ return 0;
+ }
+ }
# get parameter string, check for existance, rebuild string with the slot
my @slots = split(/:/,&Apache::lonnet::EXT("resource.0.availablestudent",
$symb,$udom,$uname));
@@ -302,17 +393,12 @@ sub release_slot {
'0_availablestudent',
1, $new_param, 'string',
$uname,$udom);
- my %slot=&Apache::lonnet::get_slot($slot_name);
- my $description=&get_description($env{'form.slotname'},\%slot);
$r->print("Released Reservation: $description
");
if ($mgr eq 'F') {
$r->print(''.
&mt('Return to slot list').'
');
}
- if (!$inhibit_return_link) {
- $r->print(''.
- &mt('Return to last resource').'
');
- }
+ if (!$inhibit_return_link) { &return_link($r); }
return 1;
}
@@ -325,6 +411,8 @@ sub delete_slot {
my ($cnum,$cdom)=&get_course();
my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
"^$slot_name\0");
+ my ($tmp) = %consumed;
+ if ($tmp =~ /error: 2/) { undef(%consumed); }
if (%slot && !%consumed) {
$slot{'type'} = 'deleted';
@@ -344,6 +432,11 @@ sub delete_slot {
}
$r->print(''.
&mt('Return to slot list').'
');
+ &return_link($r);
+}
+
+sub return_link {
+ my ($r) = @_;
$r->print(''.
&mt('Return to last resource').'
');
}
@@ -351,7 +444,14 @@ sub delete_slot {
sub get_slot {
my ($r,$symb)=@_;
- my $slot_name=&check_for_conflict($symb,$env{'form.slotname'});
+ my %slot=&Apache::lonnet::get_slot($env{'form.slotname'});
+ my $slot_name=&check_for_conflict($symb,$env{'form.slotname'},\%slot);
+
+ if ($slot_name =~ /^error: (.*)/) {
+ $r->print("An error occured while attempting to make a reservation. ($1)
");
+ &return_link($r);
+ return;
+ }
if ($slot_name) {
my %slot=&Apache::lonnet::get_slot($slot_name);
my $description1=&get_description($slot_name,\%slot);
@@ -372,33 +472,30 @@ STUFF
STUFF
$r->print(' your reservation from '.$description1.' to '.
$description2.
- ' or '.
- &mt('Return to last resource').' ');
+ ' or ');
+ &return_link($r);
$r->print(<
STUFF
} else {
- $r->print(''.
- &mt('Return to last resource').'
');
+ &return_link($r);
}
return;
}
- my %slot=&Apache::lonnet::get_slot($env{'form.slotname'});
+
my $reserved=&make_reservation($env{'form.slotname'},
\%slot,$symb);
my $description=&get_description($env{'form.slotname'},\%slot);
if (defined($reserved)) {
- if ($reserved > -1) {
+ if ($slot_name =~ /^error: (.*)/) {
+ $r->print("An error occured while attempting to make a reservation. ($1)
");
+ } elsif ($reserved > -1) {
$r->print("Success: $description
");
- $r->print(''.
- &mt('Return to last resource').'
');
- return;
} elsif ($reserved < 0) {
$r->print("Already reserved: $description
");
- $r->print(''.
- &mt('Return to last resource').'
');
- return;
}
+ &return_link($r);
+ return;
}
my %lt=('request'=>"Availibility list",
@@ -425,35 +522,78 @@ or
or
STUFF
- $r->print(''.
- &mt('Return to last resource').'
');
+
+ &return_link($r);
return;
}
sub allowed_slot {
- my ($slot_name,$slot,$symb)=@_;
+ my ($slot_name,$slot,$symb,$slots,$consumed_uniqueperiods)=@_;
+
#already started
if ($slot->{'starttime'} < time) {
# all open slot to be schedulable
#return 0;
}
&Apache::lonxml::debug("$slot_name starttime good");
+
#already ended
if ($slot->{'endtime'} < time) {
return 0;
}
&Apache::lonxml::debug("$slot_name endtime good");
+
# not allowed to pick this one
if (defined($slot->{'type'})
&& $slot->{'type'} ne 'schedulable_student') {
return 0;
}
&Apache::lonxml::debug("$slot_name type good");
+
+ my $userallowed=0;
+ # its for a different set of users
+ if (defined($slot->{'allowedsections'})) {
+ if (!defined($env{'request.role.sec'})
+ && grep(/^No section assigned$/,
+ split(',',$slot->{'allowedsections'}))) {
+ $userallowed=1;
+ }
+ if (defined($env{'request.role.sec'})
+ && grep(/^\Q$env{'request.role.sec'}\E$/,
+ split(',',$slot->{'allowedsections'}))) {
+ $userallowed=1;
+ }
+ }
+ &Apache::lonxml::debug("$slot_name sections is $userallowed");
+
+ # its for a different set of users
+ if (defined($slot->{'allowedusers'})
+ && grep(/^\Q$env{'user.name'}:$env{'user.domain'}\E$/,
+ split(',',$slot->{'allowedusers'}))) {
+ $userallowed=1;
+ }
+
+ if (!defined($slot->{'allowedusers'})
+ && !defined($slot->{'allowedsections'})) {
+ $userallowed=1;
+ }
+
+ &Apache::lonxml::debug("$slot_name user is $userallowed");
+ return 0 if (!$userallowed);
+
# not allowed for this resource
if (defined($slot->{'symb'})
&& $slot->{'symb'} ne $symb) {
return 0;
}
+
+ my $conflict = &check_for_conflict($symb,$slot_name,$slot,$slots,
+ $consumed_uniqueperiods);
+ if ($conflict) {
+ if ($slots->{$conflict}{'starttime'} < time) {
+ return 0;
+ }
+ }
&Apache::lonxml::debug("$slot_name symb good");
return 1;
}
@@ -474,29 +614,39 @@ sub show_choices {
my ($cnum,$cdom)=&get_course();
my %slots=&Apache::lonnet::dump('slots',$cdom,$cnum);
+ my $consumed_uniqueperiods = &get_consumed_uniqueperiods(\%slots);
my $available;
$r->print('');
&Apache::lonxml::debug("Checking Slots");
- my ($got_slot)=&check_for_reservation($symb);
+ my @got_slots=&check_for_reservation($symb,'allslots');
foreach my $slot (sort
{ return $slots{$a}->{'starttime'} <=> $slots{$b}->{'starttime'} }
(keys(%slots))) {
&Apache::lonxml::debug("Checking Slot $slot");
- next if (!&allowed_slot($slot,$slots{$slot}));
+ next if (!&allowed_slot($slot,$slots{$slot},undef,\%slots,
+ $consumed_uniqueperiods));
$available++;
my $description=&get_description($slot,$slots{$slot});
my $form=&mt('Unavailable');
- if (($slot eq $got_slot) ||
+ if ((grep(/^\Q$slot\E$/,@got_slots)) ||
&space_available($slot,$slots{$slot},$symb)) {
my $text=&mt('Select');
my $command='get';
- if ($slot eq $got_slot) {
+ if (grep(/^\Q$slot\E$/,@got_slots)) {
$text=&mt('Free Reservation');
$command='release';
+ } else {
+ my $conflict = &check_for_conflict($symb,$slot,$slots{$slot},
+ \%slots,
+ $consumed_uniqueperiods);
+ if ($conflict) {
+ $text=&mt('Change Reservation');
+ $command='get';
+ }
}
my $escsymb=&Apache::lonnet::escape($symb);
$form=< 'scalar',
'deleted' => 'scalar',
);
- &Apache::loncommon::store_course_settings('slotrequest',\%Saveable_Parameters);
- &Apache::loncommon::restore_course_settings('slotrequest',\%Saveable_Parameters);
+ &Apache::loncommon::store_course_settings('slotrequest',
+ \%Saveable_Parameters);
+ &Apache::loncommon::restore_course_settings('slotrequest',
+ \%Saveable_Parameters);
+ &Apache::grades::init_perm();
+ my ($classlist,$section,$fullname)=&Apache::grades::getclasslist('all');
+ &Apache::grades::reset_perm();
my %show_fields=&Apache::lonlocal::texthash(
- 'name' => 'Slot Name',
- 'description' => 'Description',
- 'type' => 'Type',
- 'starttime' => 'Start time',
- 'endtime' => 'End Time',
- 'startreserve' => 'Time students can start reserving',
- 'secret' => 'Secret Word',
- 'maxspace' => 'Maximum # of students',
- 'ip' => 'IP or DNS restrictions',
- 'symb' => 'Resource slot is restricted to.',
- 'uniqueperiod' => 'Period of time slot is unique',
- 'proctor' => 'List of proctors');
+ 'name' => 'Slot Name',
+ 'description' => 'Description',
+ 'type' => 'Type',
+ 'starttime' => 'Start time',
+ 'endtime' => 'End Time',
+ 'startreserve' => 'Time students can start reserving',
+ 'secret' => 'Secret Word',
+ 'maxspace' => 'Maximum # of students',
+ 'ip' => 'IP or DNS restrictions',
+ 'symb' => 'Resource slot is restricted to.',
+ 'allowedsections' => 'Sections slot is restricted to.',
+ 'allowedusers' => 'Users slot is restricted to.',
+ 'uniqueperiod' => 'Period of time slot is unique',
+ 'scheduled' => 'Scheduled Students',
+ 'proctor' => 'List of proctors');
my @show_order=('name','description','type','starttime','endtime',
- 'startreserve','secret','maxspace','ip','symb',
- 'uniqueperiod','proctor');
+ 'startreserve','secret','maxspace','ip','symb',
+ 'allowedsections','allowedusers','uniqueperiod',
+ 'scheduled','proctor');
my @show =
(exists($env{'form.show'})) ? &Apache::loncommon::get_env_multiple('form.show')
: keys(%show_fields);
@@ -652,6 +811,16 @@ sub show_table {
my $when = (exists($env{'form.when'})) ? $env{'form.when'}
: 'now';
+ my %stu_display_fields=
+ &Apache::lonlocal::texthash('username' => 'User name',
+ 'fullname' => 'Full name',
+ );
+ my @stu_display_order=('fullname','username');
+ my @stu_display =
+ (exists($env{'form.studisplay'})) ? &Apache::loncommon::get_env_multiple('form.studisplay')
+ : keys(%stu_display_fields);
+ my %stu_display = map { $_ => 1 } (@stu_display);
+
my $hide_radio =
&Apache::lonhtmlcommon::radio('deleted',$env{'form.deleted'},'hide');
my $show_radio =
@@ -662,11 +831,17 @@ sub show_table {
$r->print('');
$r->print('
'.&mt('Show').'
+ '.&mt('Student Display').'
'.&mt('Open').'
'.&mt('Options').'
'.&Apache::loncommon::multiple_select_form('show',\@show,6,\%show_fields,\@show_order).
'
+
+ '.&Apache::loncommon::multiple_select_form('studisplay',\@stu_display,
+ 6,\%stu_display_fields,
+ \@stu_display_order).'
+
'.&Apache::loncommon::select_form($when,'when',%when_fields).
'
@@ -693,11 +868,10 @@ sub show_table {
$r->print(' '.$linkstart.$which.'">'.$show_fields{$which}.' ');
}
}
- $r->print('Scheduled Students ');
my %name_cache;
my $slotsort = sub {
- if ($env{'form.order'}=~/^(type|description|endtime|startreserve|maxspace|ip|symb)$/) {
+ if ($env{'form.order'}=~/^(type|description|endtime|startreserve|maxspace|ip|symb|allowedsections|allowedusers)$/) {
if (lc($slots{$a}->{$env{'form.order'}})
ne lc($slots{$b}->{$env{'form.order'}})) {
return (lc($slots{$a}->{$env{'form.order'}})
@@ -729,16 +903,29 @@ sub show_table {
#next;
}
my $description=&get_description($slot,$slots{$slot});
- my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
- "^$slot\0");
my $ids;
- foreach my $entry (sort(keys(%consumed))) {
- my (undef,$id)=split("\0",$entry);
- my ($uname,$udom) = split('@',$consumed{$entry}{'name'});
- my $name = &Apache::loncommon::plainname($uname,$udom);
- $ids.= ''.$name.&remove_link($slot,$entry,$uname,$udom,
- $consumed{$entry}{'symb'})
- .' ';
+ if (exists($show{'scheduled'})) {
+ my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
+ "^$slot\0");
+ my ($tmp)=%consumed;
+ if ($tmp !~ /^error: /) {
+ foreach my $entry (sort(keys(%consumed))) {
+ my (undef,$id)=split("\0",$entry);
+ my ($uname,$udom) = split('@',$consumed{$entry}{'name'});
+ $ids.= '';
+ foreach my $item (@stu_display_order) {
+ if ($stu_display{$item}) {
+ if ($item eq 'fullname') {
+ $ids.=$fullname->{"$uname:$udom"}.' ';
+ } elsif ($item eq 'username') {
+ $ids.="$uname\@$udom ";
+ }
+ }
+ }
+ $ids.=&remove_link($slot,$entry,$uname,$udom,
+ $consumed{$entry}{'symb'}).' ';
+ }
+ }
}
my $start=($slots{$slot}->{'starttime'}?
@@ -763,6 +950,28 @@ sub show_table {
$title=''.$title.' ';
}
+ my $allowedsections;
+ if (exists($show{'allowedsections'})) {
+ $allowedsections =
+ join(', ',sort(split(/\s*,\s*/,
+ $slots{$slot}->{'allowedsections'})));
+ }
+
+ my @allowedusers;
+ if (exists($show{'allowedusers'})) {
+ @allowedusers= map {
+ my ($uname,$udom)=split(/:/,$_);
+ my $fullname=$name_cache{$_};
+ if (!defined($fullname)) {
+ $fullname = &Apache::loncommon::plainname($uname,$udom);
+ $fullname =~s/\s/ /g;
+ $name_cache{$_} = $fullname;
+ }
+ &Apache::loncommon::aboutmewrapper($fullname,$uname,$udom);
+ } (sort(split(/\s*,\s*/,$slots{$slot}->{'allowedusers'})));
+ }
+ my $allowedusers=join(', ',@allowedusers);
+
my @proctors;
my $rowspan=1;
my $colspan=1;
@@ -772,7 +981,6 @@ sub show_table {
my ($uname,$udom)=split(/@/,$_);
my $fullname=$name_cache{$_};
if (!defined($fullname)) {
- &Apache::lonnet::logthis("Gettign $uname $udom");
$fullname = &Apache::loncommon::plainname($uname,$udom);
$fullname =~s/\s/ /g;
$name_cache{$_} = $fullname;
@@ -822,10 +1030,15 @@ DELETELINK
if (exists($show{'symb'})) {
$colspan++;$r->print("$title \n");
}
- if (exists($show{'uniqueperiod'})) {
- $colspan++;$r->print("$unique \n");
+ if (exists($show{'allowedsections'})) {
+ $colspan++;$r->print("$allowedsections \n");
+ }
+ if (exists($show{'allowedusers'})) {
+ $colspan++;$r->print("$allowedusers \n");
+ }
+ if (exists($show{'scheduled'})) {
+ $colspan++;$r->print("$ids \n\n");
}
- $colspan++;$r->print("$ids \n\n");
if (exists($show{'proctor'})) {
$r->print(<
@@ -1006,7 +1219,10 @@ sub csvupload_fields {
['maxspace','Maximum number of reservations'],
['symb','Resource Restriction'],
['uniqueperiod','Date range of slot exclusion'],
- ['secret','Secret word proctor uses to validate']);
+ ['secret','Secret word proctor uses to validate'],
+ ['allowedsections','Sections slot is restricted to'],
+ ['allowedusers','Users slot is restricted to'],
+ );
}
sub csv_upload_assign {
@@ -1151,8 +1367,9 @@ sub handler {
} elsif ($env{'form.command'} eq 'get') {
&get_slot($r,$symb);
} elsif ($env{'form.command'} eq 'change') {
- &release_slot($r,$symb,$env{'form.releaseslot'},1);
- &get_slot($r,$symb);
+ if (&release_slot($r,$symb,$env{'form.releaseslot'},1)) {
+ &get_slot($r,$symb);
+ }
} else {
$r->print("Unknown command: ".$env{'form.command'}."
");
}