CVS log for loncom/interface/slotrequest.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Remove trailing whitespace.  No code changes.

- For 2.11.4 (modified)
  Fix typo in 1.125.2.10.2.1

- For 2.11.4 (modified)
  Reverse change in 1.125.2.9; include changes in 1.136, 1.137 (part),
  1.141 (part), 1.145

- Codong style

- Bug 6754 LON-CAPA as LTI Consumer
  Support for access control using slots for both "gradable" and "non-gradable"
  external tools.

- Accommodate argument changes in &selectbox() and &prettyinput() in lonmeta.pm
  rev. 1.255.

- For 2.11
  Backport 1.143

- For users with 'vgr' priv include 'Slots' help item at right of header row
  on 'Manage Slots' page. Help icon to right of 'Create Slot' button now
  points to 'Slot_About' help item in place of 'Slot AddInterface' help item.

- For 2.11.2 (modified).
  Include changes in 1.141 (modified) and 1.142.

- For 2.11
  Remove call to is_tool() function in lonnavmaps.pm, as it is not in 2.11

- For 2.11
  Backport 1.141, 1.142

- Remove span tags and assign LC_error class to enclosing p tags.
- Remove some training white space.
- Standard indent is 4 spaces.

- Bug 6911.
  Support student changing of a reservation where slot being added and slot
  being dropped both have exclusivity ranges which overlap. In this scenario
  symb associated with dropped slot can differ from current slot.

- For 2.11.2 (modified).
  Include changes in 1.138, 1.139, and 1.140

- For 2.11
  Backport 1.140

- Bug 6911

- For 2.11
  Backport 1.135

- For 2.11
  Backport 1.139

- Missed in rev. 1.116 changes.
- First arg passed to lonnet::write_log() needs to be context called.
  (lonnet.pm rev. 1.1188 change)

- For 2.11
  - Backport 1.138

- Bug 5915

- Bug 6754 LON-CAPA as LTI Consumer
  Support for access control using slots for both "gradable" and "non-gradable"
  external tools.

- Bug 6754 LON-CAPA as LTI Consumer
  Support for access control using slots, and also for time interval
  for external tools set to be "gradable".

- For 2.11.2 (modified)
  - Include changes in 1.135.

- Sanity checking

- Remove trailing white space.

- For 2.11
  - Backport 1.133

- If user has vgr priv but not mgr priv in a course ...
  - Don't display "Edit" or "Delete" links for each slot
  - Allow access to reservation log for slot (via "History" link).
- Some small UI changes
  - Use buttons in place of links for "Previous" and "Next" in log display
  - Move "Update Display: button to its own line in log display and slot display
  - Suppress table header in slot display, if there are no slots to show.

- For 2.11
  - Backport 1.128.

- For 2.11
  - Backport 1.132

- Display error message when creating slotadeom an upoaded slot definitions
  file upload if date/time format invalid.

- Slots can now require each student to check-in from a unique IP address
  when using a particular slot for a specific resource. The IP address of
  the student's computer is then tied to that student's access to the resource
  thereafter, until the end date of the slot.
  (Intended use case is high stakes online testing where students are using
  computers with statically assigned IP addresses).

- Usage restriction for a particular slot can be for one or more .sequences
  and/or .pages (in which casethe slot may be used for all resources within
  those map(s)), or for one or more specific .problem(s).

- Reservations screen for students.
  - Maintain alternating background colors when toggling hide/display
    for resources with slot control within folders.

- Values user selected in hour dropdown lists for "Open after" and
 "Closed before" when using "Search by date" display of slots were not used.

- Reservations screen for students.
  - If all problems in a folder have useslots set to map or map_map and
    slotstatus is the same for each problem, slot actions menu shown for
    folder, and rows for individual resources are hidden.
  - Arrow to left of folder icon toggles display.

- Usage restriction for slot can be for a .sequence or .page, in which case
  the slot may be used for all resources within that map.

- Typo.

- Bug 6796. Fields: "allowedsections" and "allowedusers" are advertised
  as being available for assignment to columns in uploaded slot list (csv file)
  - Add code to include validated data assigned to either of those fields
    into the stored slot definition(s).

- Sanity checking to avoid ISE in the case where a slot was reserved for a
  resource which is now hidden, or has been removed from the course.

"Reservations" screen for students.
  - Efficiency improvements
     - Information about all slots and consumed_uniqueperiods rerieved once,
       even if there are multiple resources which employ slots to control
       access.
  - User interface improvements in the case where there are many possible
    slots to choose from.  If more than a single possible slot, display
    menu to show current reservation, or search for reservations in a
    date/time range, or show all possible.

- Bug 6743.  Issue restricted to Domain Coordinators.
  Prevent table showing available slots when using "Sign-up for time to work".
  for time to work" for a resource in a course.

Fix wording typos

Internationalization: Added missing &mt() calls

- Wording Change.
  - Top level of main content area now called: 'Main Content' in place of
    'Main Course Documents', for consistency with tab names.

Improvements and corrections related to uploading users [lonuserutils.pm] and uploading slot definitions [slotrequest.pm]

- Internationalization, Wording:
    - Exclcude HTML from mt arguments
    - Re-use existing phrases
    - Consistent wording
    - Added missing mt calls [slotrequest.pm]
    - Corrected mt parameters (first param. is 1, not 2) [lonuserutils.pm, de.pm]
    - Better fitting headline: "Upload..." [slotrequest.pm]
    - Added/adjusted related phrases [de.pm]

- Improved and consistent screen layout:
    - Consistent layout (order of elements, style, spacing, floating, ...)
    - Better fitting headline level
    - Improved floating of screen elements and help links
    - Added check for specified file (though redirection to next screen occurs nevertheless) [lonuserutils.pm]
    - Additional warning, if no records are found in the specified file
    - Added links to existing help files
    - Moved option "Ignore First Line" and button "Reverse Association" to function box
    - Removed some <hr /> and <br />

- Other improvements:
    - XHTML: Proper inclusion of JavaScript [slotrequest.pm]
    - Corrected unbalanced tags:
          - Removed additional table closure [slotrequest.pm]
          - Removed additional div closure [lonuserutils.pm]
          (- form closure still missing in lonuserutils.pm)
    - Simplified code for "No slots" message and added info style [slotrequest.pm]

- Add the new first arg ($context) to places where &lonnet::write_log() is
  called.
- Reverse order of username and domain args in write_log() and
  callers in lonnet.pm for consistency with original calls in londocs.pm,
  lonparmset.pm, slotrequest.pm.

- Subroutine name change in lonnet.pm. Update places where called.
  - old name: instructor_log
  - temporary name (lonnet.pm rev. 1.1184): write_rolelog
  - new name: write_log

- Use <div> for message, to separate it from inline menu.

- Force display of text below inline menu items when reservation unavailable.

- RESERVABLE_LATER status provides appropriate message on manage reservations screen
- devalidate allslots cache when changes made to a slot.

- Can define end time for student schedulable slot reservations.
- Wording change for slot helper to clarify what 'Any time' means
  for slot reservations, or for when slot is uniquely selectable.

- Clarification of slot reservation change process by student.
- "Make no change" on screen displayed after clicking "Change reservation"  button for an existing reservation, allows student to exit.
- Record that student made no change if slot is configured to send messages.

- For slots schedulable by student slot setting to send message(s)
  when student reserves slot or releases reservation
- Make wording clearer on screen displayed when student wishes to
  swap reservations when uniqueperiod constraint applies.

- Bug 6251.
  - Third arg is now a ref to a hash, instead of a hash.
  - New (optional) fourth arg, is an additional attribute for the
    select tag, e.g., an onchange action.
- Update calls to loncommon::select_form() accordingly.

- Need to pass $symb as third arg to &allowed_slot() for slots restricted by symb to be available for the corresponding symb.

- Accommodate Communities
  - (C)course -> (C)community

- Accommodate Communities
 - (S)student(s) -> (M)member(s)
   (C)course -> (C)community

- Only show text about slot listing if there are any resources with slot control.

- Set server version cut-off to the corresponding production release version.

- Correcting the server version number modified in 1.100.

Upload Slot List:
- Replaced table with special colors by standard pick_box
- Removed double table closure
- Wording: Replaced "Upload Data" by "Next" to indicate that further steps will follow until actual upload.
- Optimized item order: Upload/Next button at bottom now
- Localization: Added missing &mt call to button text
- XHTML: lower case HTML attributes (onClick)

loncreateuser.pm:
- Removed double data_table start (-> rev. 1.301)
- Removed unneeded <br> between header and page content
- Separate row for "Update Display" Button

loncreateuser.pm, lonslotrequest.pm:
- Corrected server version &mt() calls
- Replaced special note style for version note by standard info style

loncreateuser.pm, lonslotrequest.pm, lonroles.pm:
- Consistent and optimized wording (server version)

de.pm, zh.pm:
- Corresponding wording updates
- Additions of missing phrases

Removed deprecated attribute "noshade" from <hr>
and XHTML conform tag closure

- Backport 1.98.

- Remove unnecessary concatenation operator.

XHTML conform selected/checked/multiple HTML attributes
and optimized spacing

XHTML:
- XHTML conform <img> tag closure
- Added some missing alt attributes to <img>

XHTML:
Added quotation marks to HTML attribute values

- Wording change.
    "student-reservable" replaces "student-schedulable"

- Don't show "History" link for slot in slot listing if not student-schedulable
- Show warning if slot history page reached for unknown slot or for non-student-schedulable slot.

- Added line breaks in script code in manage_reservations output
- Message about no transactions to display:
    - Corrected typo
    - Added info style

- Bug 5822.
  - logging of changes to student-schedulable slots in nohist_$cdom_$cnum_slotlog.db file in a student's directory in lonUsers.
  - users can view their own reservation history via "Reservations History link on "Manage Reservations" page.
  - CCs/instructors can view history of reservation changes for a particular slot from "History" link in slots table
  - CCs/instructors can view reservation changes for a particular student.
- use standard data tabling display
- users without vgr privilege can view reservation status for all resources in a course which use slots
- loncommon::sorted_slots() used to sort slots by start time.
- Breadcrumbs added
- Missing &mt()

*** Work in progress ... future amalgamation of code used for log display expected. ***

Standard texthash calls:
- Direct call
- Keys and values in (single) quotes
- Standard indent

- Bug 5822. Work in progress.
  - Log slot reservation transactions in nohist_slotreservationslog.db in course
    using lonnet::instructor_log().

Optimized &mt() call related to change in slotrequest.pm 1.87
- Don't concatenate translations ("Change")
- Corrected 2. (now 3.) parameter (missing "_")
- Excluded paragraph closure from mt call

- Missing &mt().
- Move <tt> </tt> tags outside translatable string in &mt() call.
- xhtml.

- Bug 5888.
&check_for_conflict() can return undef.

- Check that navmap objects could be created to avoid ISEs.
- Response from &get_consumed_uniqueperiods() will be a scalar if this type of error occurred, not a hashref - check for this.

Replaced
  <nobr>...</nobr>
by
  <span class="LC_nobreak">...</span>

- lonsearchcat.pm: Added missing start tag for nobreak area
- lonsurveyreports.pm: Added missing end tag for nobreak area

Typo.

Past tense of "occur" is "occurred" (rr!)
Also added some missing &mt() calls and corrected some other little typos

When using calls to &Apache::lonnet::EXT(), request a scalar explicitly, to avoid similar problems to those eencountered in bug 5578, following the change in lonnet.pm rev 1.927 which enabled EXT() to return the level a parameter is set at, if an array was requested.

- map and map_map reservations store the map as their symb of the
  reservation occurred for, need to fetch a symb for a resource in the map
  to remove the parameter

- bug#5232

- css

- forgot to remove comment

- preventing students from reserving a slot if it is already underway

- reverse the order of slot reserving first get the new slot then release the old one

- bug #5232 show slot fullness

- extra ws

Added blue help links to slotrequest.pm

- backport 1.71

- BUG#5066, need to unescape the symb...

 backport 1.70

- Part of BUG#5066

- complte the move of whichuser() from lonnxml -> lonnet

- BUG#4892 slots restricted ato a group weren't working

- morph to use new lonnet provided error detector

- new useslots status of 'map_map'

- databling

- unique period wasn't being displayed
- valid xhtml

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

- missed a @ -> :

- remove 'Request another attmpt button' from the non-slot based acces mode
- Improve error message if yuser some how requests a new from a resource that is not a slto based access mechanism

- chaning the value from sequence to map to better represent it's scope

- make useslots be confiugrable so students can make a slot registration apply at the sequence level

- adding more slot validation to the creation interfaces

- switching to use the more official : as domain username seperator (rather tahn @, since MSU will want @ in valid usernames)

- forward port 1.48.2.3

- link looks better in the scheduabled students display area

- backport 1.54 1.55

- add ability to remove all student reservations from a slot quickly

- filter which slots to show based on name

- backport 1.53

- check the startresrve time

- converting some interface pages to stop generating </body> <head> </head> </html> and use the helper functions instead

- allow users into slots with no restrictions

- respect the allowedsections and allowedusers slot attributes

- adding allowedsections and allowed users restrictions to slot specifications

- unique periods need tobe check across the whole course

- scheduled students is an optional column now

- add the username to scedule student display

- remove some moved lines (BUG#4650)

- allowed_slot checks for uniqueperiod conflicts for conflicting slots that have started

- unique period was not being checked properl, students could make multiple
  reservations
- better display for what slots are currently allowed and whether thye conflict
  with a previously reserved slot
- was checking the startime of a slot improperly when student tried to free a
  slot
- when getting the next reservation pick the one that occurs next

- more use of &return_link()

- some more error checks

- check for network erros in a variety of cases

- was allowing users to release reservations for expired slots

- unable to delete slots if the slot_reservations.db didn't exist

typo.

- student can sign up fro slots for problems

- control whther slots marked deleted show

- mark a slot as deleted

- can now remove a user for a slot reservation

- BUG#4461 - remove old edit form

- don't allow user to create bad slots

- adding time restricttors

- can pick what parts of a slot to see

- fix a typo
- change title for slot management
- add new slot button
- improve proctor display

- uh no.

	Beginning to handle single and multiple selection of
	instructor defined keyword list.

- Can now edit a slot

- don't print Wed Dec 31 19:00:00 1969 when times are unset

- show slot reserve time
- name sort works now

- allow use of a secret word rather than the password (optionally)

- can now sort slots by various criteria
- proctor names are links to their aboutme pages, and their name shows up

- make the proctor column lokk 'better'

- don't need a symb to view slots

- need to pass mgr around a bit more

- remove some debug

- er typo

- adding in startreserve

- upload CSV files of slot information now works

- show all slots for now

- typo

- you should be able to see the table of slots even if you are in a slot

- add moe info to the slot screen

- remove debug info

- restrict students from chaging slots while waiting for grade or in an open slot

- silly to change reservations from slot1 to slot1
- wasn't handling the case of a full up slot completely correctly
- was getting double return links when changing slots
- freed slots were still thought of as not free

- can now change a reservation or freee one

- adding uniqueperiod - time period in which a another slot of an overlapping unique period can't be scheduled
- instructors can also see the full reservation table

- after requesting a new slot the 'request a new time' button disappears
- this requires a new slot info to be set 'startreserve'

- can actually aquire a reservation
- respects starttime/endtime/type/symb restrctions on slots
- sets the parameter associated with the slot
- doesn't allow a user to reserve a slot several times

- can display the slots now
- code for making a reservation written but untested

- adding slot requesting handler