--- loncom/interface/spreadsheet/assesscalc.pm	2005/05/17 18:01:58	1.48
+++ loncom/interface/spreadsheet/assesscalc.pm	2006/04/06 20:24:13	1.52
@@ -1,5 +1,5 @@
 #
-# $Id: assesscalc.pm,v 1.48 2005/05/17 18:01:58 albertel Exp $
+# $Id: assesscalc.pm,v 1.52 2006/04/06 20:24:13 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -290,7 +290,8 @@ Returns: The value of a parameter, or ''
 
 This function cascades through the possible levels searching for a value for
 a parameter.  The levels are checked in the following order:
-user, course (at section level and course level), map, and lonnet::metadata.
+user, course (at group, section level and course level), map, and 
+lonnet::metadata.
 This function uses %parmhash, which must be tied prior to calling it.
 This function also requires %courseopt and %useropt to be initialized for
 this user and course.
@@ -301,11 +302,12 @@ this user and course.
 ##################################################
 sub parmval {
     my $self = shift;
-    my ($what,$symb,$uname,$udom,$csec,$recurse,$mapname,$id,$fn)=@_;
-    $uname = $self->{'name'}    if (! defined($uname));
-    $udom  = $self->{'domain'}  if (! defined($udom));
-    $csec  = $self->{'section'} if (! defined($csec));
-    $symb  = $self->{'symb'}    if (! defined($symb));
+    my ($what,$symb,$uname,$udom,$csec,$recurse,$mapname,$id,$fn,$cgroup)=@_;
+    $uname  = $self->{'name'}    if (! defined($uname));
+    $udom   = $self->{'domain'}  if (! defined($udom));
+    $csec   = $self->{'section'} if (! defined($csec));
+    $cgroup = $self->{'group'}   if (! defined($cgroup)); 
+    $symb   = $self->{'symb'}    if (! defined($symb));
     #
     my $result='';
     #
@@ -323,6 +325,10 @@ sub parmval {
     my $courseprefix = $self->{'cid'};
     my $usercourseprefix = $uname.'_'.$udom.'_'.$self->{'cid'};
     #
+    my $grplevel=$courseprefix.'.['.$cgroup.'].'.$what;
+    my $grplevelr=$courseprefix.'.['.$cgroup.'].'.$symbparm;
+    my $grplevelm=$courseprefix.'.['.$cgroup.'].'.$mapparm;
+    #
     my $seclevel  = $courseprefix.'.['.$csec.'].'.$what;
     my $seclevelr = $courseprefix.'.['.$csec.'].'.$symbparm;
     my $seclevelm = $courseprefix.'.['.$csec.'].'.$mapparm;
@@ -334,12 +340,18 @@ sub parmval {
     my $ucourselevel  = $usercourseprefix.'.'.$what;
     my $ucourselevelr = $usercourseprefix.'.'.$symbparm;
     my $ucourselevelm = $usercourseprefix.'.'.$mapparm;
-   # check user
+    # check user
     if (defined($uname)) {
         return $useropt{$ucourselevelr} if (defined($useropt{$ucourselevelr}));
         return $useropt{$ucourselevelm} if (defined($useropt{$ucourselevelm}));
         return $useropt{$ucourselevel}  if (defined($useropt{$ucourselevel}));
     }
+    # check group
+    if (defined($cgroup)) {
+        return $courseopt{$grplevelr} if (defined($courseopt{$grplevelr}));
+        return $courseopt{$grplevelm} if (defined($courseopt{$grplevelm}));
+        return $courseopt{$grplevel}  if (defined($courseopt{$grplevel}));
+    }
     # check section
     if (defined($csec)) {
         return $courseopt{$seclevelr} if (defined($courseopt{$seclevelr}));
@@ -703,15 +715,17 @@ sub parameter_part_is_valid {
         return 1;
     }
     #
-    my (undef,$part) = 
-        ($parameter =~ m/^(resource|stores|parameter)_([^_]+)_.*/);
-    if (exists($self->{'Parts'})          && 
-        exists($self->{'Parts'}->{$part}) &&
-        $self->{'Parts'}->{$part} ) {
-        return 1;
-    } else {
-        return 0;
+    my ($start,@pieces)=split('_',$parameter);
+    if ( $start !~ m/^(resource|stores|parameter)$/) { return 0; }
+    while (@pieces) {
+        pop(@pieces);
+        my $testpart=join('_',@pieces);
+	if (exists($self->{'Parts'}->{$testpart}) &&
+	    $self->{'Parts'}->{$testpart} ) {
+	    return 1;
+	}
     }
+    return 0;
 }
 
 sub compute {
@@ -786,9 +800,15 @@ sub compute {
         if ($parm =~ /_submission$/ && $value =~ /(\{|\})/) {
             $value = 'witheld';
         }
-        #$value = 'q{'.$value.'}' if ($value =~/([^\d\.]|\.\.)/);
+        $value = 'q{'.$value.'}' if ($value =~/([^\d\.]|\.\.)/);
         $c{$parm} = $value;
     }
+    foreach my $cell (grep(/^A/,keys(%f))) {
+        # Clean out any bad formulas
+	next if (exists($c{$f{$cell}}));
+	next if ($cell eq 'A0');
+	delete($f{$cell});
+    }
     $self->formulas(\%f);
     $self->constants(\%c);
     $self->calcsheet();
@@ -837,7 +857,7 @@ sub sett {
 		&& $self->{'constants'}->{$formula} ne ''
 		) {
 		$Apache::Spreadsheet::sheet_values{$cell}=
-		    $self->{'constants'}->{$formula};
+		    eval($self->{'constants'}->{$formula});
             }
         } else {
             $t{$cell}=$formula;