CVS log for loncom/interface/spreadsheet/assesscalc.pm

Up to [LON-CAPA] / loncom / interface / spreadsheet

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Bug 4373. Ability to set map-level parameters which apply recursively
  to subfolders.

Internationalization: Added missing &mt() calls

- Check $navmap is an object.

- allow [&EXPANDSUM()] to span lines

- notice and announce when errors occur trying to calculate spreadsheets

- replacing incorrect E-oh-FFDD with E-zero-FFDD

- backport 1.55

- the map url in the parameter definition is without a version

typo

Determination of parameters for spreadsheet now correctly cascades for cases where a user has multiple active groups. Also groups are passed in argument list for Spreadsheet object as array reference. Lastly lonnet::get_users_groups function modified to only return user's active groups, except in case when user status has expired (and default end access date for students has also passed), in which case user's groups which were still active less than 24 hours before default end date are also included in user's groups. [For consistency with students groups returned by loncoursedata::get_students_groups()].

Making group-based parameters apply in spreadsheet, using same cascading precedence scheme as used for parmset.

- BUG#4410 was not doing an exhaustive search for possible part info

- remove any formulas that don't have an associated const

- didn't mean to commit that, it makes things faster, but likely can cause problems

- only go get the pretty names of the parameters if we are going to actually show them

- err got the arg order wrong there

- some formatting changes

- mimize the size of sheet_values

- moving the decode_symb out of the way inner loop saves us about 2 seconds, down to about 11.5 secodns to complet calc a student now (from 93)

- slightly better test

- connection aborted only changes after trying to do $r->rflush( or enough $r->print()) no need tocheck hundreds of times a second

- checking if a partid is hidden can be 'expensive' only chek if we have a parmaeter sitting there

- minimizing the number of elments in %t, and moving sheet_values to be out int Spreadsheet not in the safe space (student level sheet not taking aroun 0.5 seconds to compute)

- ENV -> env

Updated to use loncommon::create_workbook.  Spreadsheets were slightly
modified to use formats.

Changed to use navmaps.

- sprs cascade changes for bug#1444

- parameter identifiers can conatin things more interesting then \w

consolidate some of the multitude of functions out there that try to format and display the student's 'fullname'

These fixes should go on S10 as soon as possible.

Spreadsheet.pm: Fix to handle the case when a spreadsheet object is
created without a valid username/domain passed to new().

assesscalc.pm: Fix to ignore stored data which does not contain the username
and domain.

lonspreadsheet.pm: Fix to not do stupid things that got us in this mess
in the first place (only accept form parameters which have values and do not
send out form parameters without values).

Fix: now specifies what a non number is instead of specifying what a number
is.  Needs to go on all production servers if Guy has a chance to look it
over.  Also for 1.1.x.

Fixes horrible bug.  Should go on production servers immediately and
definately in 1.1.x.

Fix parameters passed in to excel_rows and csv_rows.  Should go in 1.1

Backport of changes to make spreadsheet report calculation errors and not
save bogus data.

Fix bug in error reporting where errors in computation of the spreadsheet
were not reported and bad cache values were stored away.
Added in Spreadsheet: &set_badcalc, &badcalc, &set_calcerror, &calcerror,
and &html_report_error.  These are used to keep track of computation errors
and to report them to the user.  The &save_export_data routines were all
modified to not store data when an error has occured.

Fix bug 55: Hide part information from spreadsheet for hidden parts.

Remove redundant aborted connect check.

Internationalize/localize

- backport 1.25

Added loncoursedata::clear_internal_caches() and calls to it in
&lonstatistics::Gather_Student_Data (used by statistics),
lonstudentassessment.pm (chart), assesscalc.pm (spreadsheet).  Should
go into 1.0.2 if possible.

- backport changes to make problemstatus work better

Fix error in blackout dates so we no longer show the forbidden data when
there is no answerdate set.

- decode_symb

Cache student performance data (only make 1 call to get_current_state)
Cache export rows and write them only when asked to or when the computations
are done.

1. Be more vigilent about clearing user parameter caches (%useropt)
2. Added 'loadtime' value to %useropt which prevents it from being requested
   again and again just because the student did not have any data...
   (how many times will I create and fix the same bug?)
3. Break compute method down to facilitate testing.
4. More fatal warning enduced robustness in a few if statements.

Hiding symb-splitting behind &decode_symb

Clear package variables on both normal completion and on interruption.

Minor modifications brought about due to making warnings fatal.

- Fixes for BUG#1991, (maybe packages.tab will finally be handled correctly? One can only hope)
- Made thes changes I said I was going to in the bugreport (copied below for conviene and commit padding)
1) stop metadata from parsing packages.tab values and sticking them in the
metadata of the problem
2) add new function get pacakages_tab_default() to lonnet, takeas a full parm
signifier (resource.partid_responseid.name) (just like EXT takes) figures out
what kind of response/part the things is and returns the proper default value
from packages.tab
3) add to EXT to check this new function for the packages.tab default for
anythings it can't find a value for
4) check that all other parmval funtions also do this

4) turned out to be assesscalc.pm and lonnavmaps.pm, and executive decision was made to leave lonparmset.pm out of the fix, as there is nothing the user can do about these values, adn they see the defaults appear in the 'Current session value' column.

(as it is it would be difficult to add these values to the parmset screen, one would need a colun at the very end that said "if ther are no other values set anywhere else, we'll use this one.)

Anyhoo.

Fix bug which caused discussion/evaluation/feedback/tutoring to not
be picked up for titles.

Paler yellow.

Bug 1729 - color hints on export/import rows.  The color of the export
row of the assessment sheet is the same as the import row of the
student sheet.  The export row of the student sheet is the same color
as the import rows of the course level sheet.

Handle course data caching properly.

Fixes bugs 1513 and 1516. Every time a new row is added to a spreadsheet
the spreadsheet will be saved.
&set_row_numbers now actually keeps track of the maximum row found, which
can be useful if you need to add a new row...
Also fixed bug in caching of spreadsheets - was storing the 'join'd version
of the formulas when I expected a hash reference.

Added $spreadsheet->initialize() subroutine to take care of specific
initialization needed for each sheet.  assesscalc now has a list of
mandatory parameters (Bug 1514) but is running in to problems with
bug 1513.

Fix display/editability of cells in assessment sheet.

CSV output implemented.

Added output selector and implemented excel output.

Moved $spreadsheet->display() to Spreadsheet.pm instead of having it reside
    three times in the descendents of the spreadsheet object.
Moved $spreadsheet->outsheet_excel() to Spreadsheet.pm for the same reason.
Created Spreadsheet::output_selector, which allows the user to select the
    output mode they desire.
Created $spreadsheet->excel_output_row which takes care of writing a row
    to an excel worksheet.
classcalc.pm, studentcalc.pm, and assesscalc.pm each had the same work done
on them:
  Created &excel_rows(), which writes the body of the spreadsheets to
     an excel file.
  Rewrote &get_title to return an array of title lines.
  Created &get_html_title to return an HTML version of the results of
     &get_title.

classcalc.pm and Spreadsheet.pm each have the following change:
    Created &html_header to return appropriate HTML for the spreadsheet.

No longer save the results of computation of temporary spreadsheets.
Added Spreadsheet->temporary() to handle the getting and setting of the flag
which indicates a spreadsheet is temporary.  studentcalc.pm and assesscalc.pm
check this flag before saving their export rows.

Perl does not automagically convert the string '"1"' to 1, so we must only
quote those parameters which are non-numeric.

Added 'blackout' support.  A blackout occurs when an assessment has a part
flagged with 'problemstatus' equal to 'no'.  This prevents the display of
the students performance on the part until the answerdate has passed.

Spreadsheet.pm contains &blackout, which returns the blackout status of
the current spreadsheet.

assesscalc.pm contains code which
    a) causes the computation of the spreadsheet to determine the
       blackout status
    b) forces the recomputation of the spreadsheet if the user is a student.
  Obviously (b) is less than ideal and a new approach should be found.

studentcalc.pm's outsheet_html subroutine now supresses the display of the
export (aka 'summary') row, as well as the rows of any assessments which
are under blackout.

If the value is '', we should store away '' and not "''".

All parameters are treated as strings, which fixes a most insidious bug.
Course level parameter data is no longer cached with the students name
prepended.  &parmval reflects this change as well.
Removed excess &logthis call.

Modified $spreadsheet->title() subroutines to look prettier, link to the
students 'aboutme' page, and call &Apache::loncoursedata::GetUserName.

Nearly complete reworking of spreadsheet.

lonspreadsheet.pm holds a few utility functions and the handler, which
creates a spreadsheet and tells it to display itself.

Spreadsheet.pm is the base definition of the spreadsheet object.
classcalc.pm, studentcalc.pm, and assesscalc.pm are implementations of the
spreadsheets.

There are missing pieces - excel and csv output, limiting by section
permissions, the ability to add extra 'header' rows to the student and
course level sheets, and students are still allowed to view the assessment
level sheets (will disable this soon).

Computing and editing of the spreadsheet have been tested and have been
given a preliminary seal of approval.