--- loncom/interface/spreadsheet/lonspreadsheet.pm	2008/12/11 14:55:20	1.52
+++ loncom/interface/spreadsheet/lonspreadsheet.pm	2011/09/26 12:15:39	1.59
@@ -1,5 +1,5 @@
 #
-# $Id: lonspreadsheet.pm,v 1.52 2008/12/11 14:55:20 bisitz Exp $
+# $Id: lonspreadsheet.pm,v 1.59 2011/09/26 12:15:39 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -64,6 +64,7 @@ use Apache::lonnet;
 use Apache::lonhtmlcommon;
 use Apache::lonlocal;
 use Apache::loncoursedata();
+use Apache::lonquickgrades();
 use HTML::Entities();
 
 ##
@@ -73,12 +74,12 @@ use HTML::Entities();
 sub textfield {
     my ($title,$name,$value)=@_;
     return "\n<p><b>$title:</b><br />".
-        '<input type=text name="'.$name.'" size=80 value="'.$value.'" />';
+        '<input type="text" name="'.$name.'" size="80" value="'.$value.'" />';
 }
 
 sub hiddenfield {
     my ($name,$value)=@_;
-    return '<input type=hidden name="'.$name.'" value="'.$value.'" />'."\n";
+    return '<input type="hidden" name="'.$name.'" value="'.$value.'" />'."\n";
 }
 
 sub selectbox {
@@ -86,7 +87,7 @@ sub selectbox {
     my $selout="\n<p><b>$title:</b><br />".'<select name="'.$name.'">';
     foreach (sort keys(%options)) {
         $selout.='<option value="'.$_.'"';
-        if ($_ eq $value) { $selout.=' selected'; }
+        if ($_ eq $value) { $selout.=' selected="selected"'; }
         $selout.='>'.&mt($options{$_}).'</option>';
     }
     return $selout.'</select>';
@@ -146,7 +147,7 @@ sub file_dialogs {
         $truefilename.'" />'.
         '</span>';
     my $makedefault_dialog = '<input type="submit" name="makedefault" '.
-        'value="'.&mt('Save as & Make This Sheet the Default').'"/>';
+        'value="'.&mt('Save as &amp; Make This Sheet the Default').'"/>';
     #
     my $link = '<a href="javascript:openbrowser'.
         "('sheet','loadfilename','spreadsheet')\">".&mt('Select Spreadsheet File')."</a>";
@@ -165,17 +166,18 @@ END
     foreach my $sheetfilename ($spreadsheet->othersheets()) {
         $load_dialog .= '    <option value="'.$sheetfilename.'"';
         if ($filename eq $sheetfilename) {
-            $load_dialog .= ' selected';
+            $load_dialog .= ' selected="selected"';
             $default_filename_set = 1;
         }
         $load_dialog .= '>'.$sheetfilename."</option>\n";
     }
     $load_dialog .= "</select>\n</td><td>&nbsp;</td></tr>\n</table>\n";
         #
+    my $headline = &mt('File Dialogs');
     $result .=<<END;
 <!-- 
     <fieldset title="File Dialogs" >
-    <legend>File Dialogs</legend>
+    <legend>$headline</legend>
   -->
 <!-- load / save dialogs -->
 <table cellspacing="2">
@@ -199,16 +201,6 @@ END
 sub handler {
     my $r=shift;
     #
-    # Overload checking
-    #
-    # Check this server
-    my $loaderror=&Apache::lonnet::overloaderror($r);
-    if ($loaderror) { return $loaderror; }
-    # Check the course homeserver
-    $loaderror= &Apache::lonnet::overloaderror($r,
-                      $env{'course.'.$env{'request.course.id'}.'.home'});
-#    if ($loaderror) { return $loaderror; } 
-    #
     # HTML Header
     #
     if ($r->header_only) {
@@ -226,15 +218,39 @@ sub handler {
             $r->uri.":opa:0:0:Cannot modify spreadsheet";
         return HTTP_NOT_ACCEPTABLE; 
     }
+    my ($sheettype) = ($r->uri=~/\/(\w+)$/);
     my $courseid = $env{'request.course.id'};
+
+    ##
+    ## Check permissions
+    my $allowed_to_edit = &Apache::lonnet::allowed('mgr',
+                                                $env{'request.course.id'});
+    # Only those instructors/tas/whatevers with complete access
+    # (not section restricted) are able to modify spreadsheets.
+    my $allowed_to_view =  &Apache::lonnet::allowed('vgr',
+                                                $env{'request.course.id'});
+    if (! $allowed_to_view) {
+        $allowed_to_view = &Apache::lonnet::allowed('vgr',
+                    $env{'request.course.id'}.'/'.$env{'request.course.sec'});
+        # Those who are restricted by section are allowed to view.
+        # The routines in lonstatistics which decide which students'
+        # will be shown take care of the restriction by section.
+    }
+
     #
-    # Do not allow students to continue if standard or external grading is in
-    # effect.
+    # Do not allow users without vgr or mgr priv to continue unless 
+    # grading type is set to spreadsheet. 
     #
-    if ($env{'request.role'} =~ /^st\./) {
-        if ($env{'course.'.$courseid.'.grading'} eq 'standard' ||
-	    $env{'course.'.$courseid.'.grading'} eq 'external' ) {
-            return HTTP_NOT_ACCEPTABLE;
+
+    if ((!$allowed_to_view) && (!$allowed_to_edit)) {
+        if ($env{'course.'.$courseid.'.grading'} eq 'spreadsheet') {
+            if ($sheettype ne 'studentcalc') {
+                $r->internal_redirect('/adm/studentcalc');
+                return OK;
+            }
+        } else {
+            $r->internal_redirect('/adm/quickgrades');
+            return OK;
         }
     }
     #
@@ -252,7 +268,6 @@ sub handler {
     }
     #
     # Determine basic information about the spreadsheet
-    my ($sheettype) = ($r->uri=~/\/(\w+)$/);
     #
     my $symb   = undef;
     $symb = $env{'form.usymb'} if (exists($env{'form.usymb'}));
@@ -275,29 +290,13 @@ sub handler {
                                                     $env{'request.course.id'});
     }
 
-    ##
-    ## Check permissions
-    my $allowed_to_edit = &Apache::lonnet::allowed('mgr',
-                                                $env{'request.course.id'});
-    # Only those instructors/tas/whatevers with complete access
-    # (not section restricted) are able to modify spreadsheets.
-    my $allowed_to_view =  &Apache::lonnet::allowed('vgr',
-                                                $env{'request.course.id'});
-    if (! $allowed_to_view) {
-        $allowed_to_view = &Apache::lonnet::allowed('vgr',
-                    $env{'request.course.id'}.'/'.$env{'request.course.sec'});
-        # Those who are restricted by section are allowed to view.
-        # The routines in lonstatistics which decide which students' 
-        # will be shown take care of the restriction by section.
-    }
     #
     # Only those able to view others grades will be allowed to continue 
     # if they are not requesting their own.
     if ($sheettype eq 'classcalc') {
-        if (! $allowed_to_view) {
-	    $env{'user.error.msg'}=
-		$r->uri.":vgr:0:0:Access Permission Denied";
-	    return HTTP_NOT_ACCEPTABLE; 
+        if (!$allowed_to_view) {
+            $r->internal_redirect('/adm/studentcalc');
+            return OK;
 	}
     }
     if ((($name   ne $env{'user.name'} ) ||
@@ -404,8 +403,17 @@ ENDSCRIPT
           bug   => 'Spreadsheet'});
     $r->print(&Apache::loncommon::start_page('Grades Spreadsheet',$js).
               &Apache::lonhtmlcommon::breadcrumbs('Spreadsheet',
-						  'Spreadsheet_About').
-              '<form action="'.$r->uri.'" name="sheet" method="post">');
+						  'Spreadsheet_About'));
+
+    #
+    # Tabs
+    # 
+    &Apache::lonquickgrades::startGradeScreen($r,'spreadsheet');
+
+    #
+    # Open the form
+    # 
+    $r->print('<form action="'.$r->uri.'" name="sheet" method="post">');
     $r->print(&hiddenfield('sname'  ,$env{'form.sname'}).
               &hiddenfield('sdomain',$env{'form.sdomain'}).
               &hiddenfield('usymb'  ,$env{'form.usymb'}));
@@ -427,7 +435,7 @@ ENDSCRIPT
         if (exists($env{'form.recalc'})) {
             &Apache::loncoursedata::delete_caches($env{'requres.course.id'});
         }
-        if ($env{'form.recalc'} eq 'ilovewastingtime') {
+        if ($env{'form.recalc'} eq 'expireallsheets') {
             &Apache::lonnet::logthis('spreadsheet expired: entire course');
             # expire ALL spreadsheets
             &Apache::lonnet::expirespread('','','studentcalc');
@@ -547,7 +555,7 @@ END
     $r->print(&hiddenfield('filename',$filename));
     #
     # Keep track of the number of times we have been called, sort of.
-    $r->print(&hiddenfield('not_first_run','whatever'));
+    $r->print(&hiddenfield('not_first_run','1'));
     #
     if (exists($env{'form.not_first_run'}) || $sheettype ne 'classcalc') {
         $r->print($spreadsheet->get_html_title());
@@ -557,7 +565,9 @@ END
         $r->rflush();
         $spreadsheet->display($r);
     }
-    $r->print('</form>'.&Apache::loncommon::end_page());
+    $r->print('</form>');
+    &Apache::lonquickgrades::endGradeScreen($r);
+    $r->print(&Apache::loncommon::end_page());
     $spreadsheet->clear_package();
     return OK;
 }