--- loncom/interface/spreadsheet/lonspreadsheet.pm	2003/10/11 14:04:54	1.27
+++ loncom/interface/spreadsheet/lonspreadsheet.pm	2005/08/29 21:04:52	1.42
@@ -1,5 +1,5 @@
 #
-# $Id: lonspreadsheet.pm,v 1.27 2003/10/11 14:04:54 www Exp $
+# $Id: lonspreadsheet.pm,v 1.42 2005/08/29 21:04:52 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -72,8 +72,8 @@ use HTML::Entities();
 
 sub textfield {
     my ($title,$name,$value)=@_;
-    return "\n<p><b>$title:</b><br>".
-        '<input type=text name="'.$name.'" size=80 value="'.$value.'">';
+    return "\n<p><b>$title:</b><br />".
+        '<input type=text name="'.$name.'" size=80 value="'.$value.'" />';
 }
 
 sub hiddenfield {
@@ -83,7 +83,7 @@ sub hiddenfield {
 
 sub selectbox {
     my ($title,$name,$value,%options)=@_;
-    my $selout="\n<p><b>$title:</b><br>".'<select name="'.$name.'">';
+    my $selout="\n<p><b>$title:</b><br />".'<select name="'.$name.'">';
     foreach (sort keys(%options)) {
         $selout.='<option value="'.$_.'"';
         if ($_ eq $value) { $selout.=' selected'; }
@@ -100,9 +100,10 @@ sub file_dialogs {
     my $message = '';
     ##
     ## Deal with saving the spreadsheet
-    if ((exists($ENV{'form.save'}) || exists($ENV{'form.makedefault'})) && 
-        exists($ENV{'form.savefilename'})) {
-        $spreadsheet->filename($ENV{'form.savefilename'});
+    $spreadsheet->check_formulas_loaded();
+    if ((exists($env{'form.save'}) || exists($env{'form.makedefault'})) && 
+        exists($env{'form.savefilename'})) {
+        $spreadsheet->filename($env{'form.savefilename'});
         my $save_status = $spreadsheet->save();
         if ($save_status ne 'ok') {
             $message .= "An error occurred while saving the spreadsheet".
@@ -110,22 +111,22 @@ sub file_dialogs {
         } else {
             $message .= "Spreadsheet saved as ".$spreadsheet->filename();
         }
-    } elsif (exists($ENV{'form.newformula'}) && 
-             exists($ENV{'form.cell'})       && 
-             $ENV{'form.cell'} ne '' ) {
+    } elsif (exists($env{'form.newformula'}) && 
+             exists($env{'form.cell'})       && 
+             $env{'form.cell'} ne '' ) {
         ##
         ## Make any requested modifications to the spreadsheet
-        $spreadsheet->modify_cell($ENV{'form.cell'},
-                                  $ENV{'form.newformula'});
+        $spreadsheet->modify_cell($env{'form.cell'},
+                                  $env{'form.newformula'});
         $spreadsheet->save_tmp();
         # output that we are dealing with a temporary file
         $result .=&hiddenfield('workcopy',$sheettype);
-        if ($ENV{'form.newformula'} !~ /^\s*$/) {
+        if ($env{'form.newformula'} !~ /^\s*$/) {
             $message .='<table><tr>'.
-              '<td valign="top"><pre>'.&mt('Cell').' '.$ENV{'form.cell'}.' = </pre></td>'.
-              '<td><pre>'.$ENV{'form.newformula'}."</pre></td></tr></table>\n";
+              '<td valign="top"><pre>'.&mt('Cell').' '.$env{'form.cell'}.' = </pre></td>'.
+              '<td><pre>'.$env{'form.newformula'}."</pre></td></tr></table>\n";
         } else {
-            $message .= &mt('Deleted contents of cell').' '.$ENV{'form.cell'}.'.';
+            $message .= &mt('Deleted contents of cell').' '.$env{'form.cell'}.'.';
         }
     }
     ##
@@ -162,7 +163,7 @@ sub file_dialogs {
 END
     my $default_filename_set = 0;
     foreach my $sheetfilename ($spreadsheet->othersheets()) {
-        $load_dialog .= '    <option name="'.$sheetfilename.'"';
+        $load_dialog .= '    <option value="'.$sheetfilename.'"';
         if ($filename eq $sheetfilename) {
             $load_dialog .= ' selected';
             $default_filename_set = 1;
@@ -205,7 +206,7 @@ sub handler {
     if ($loaderror) { return $loaderror; }
     # Check the course homeserver
     $loaderror= &Apache::lonnet::overloaderror($r,
-                      $ENV{'course.'.$ENV{'request.course.id'}.'.home'});
+                      $env{'course.'.$env{'request.course.id'}.'.home'});
 #    if ($loaderror) { return $loaderror; } 
     #
     # HTML Header
@@ -219,17 +220,20 @@ sub handler {
     # Roles Checking
     #
     # Needs to be in a course
-    if (! $ENV{'request.course.fn'}) { 
+    if (! $env{'request.course.fn'}) { 
         # Not in a course, or not allowed to modify parms
-        $ENV{'user.error.msg'}=
+        $env{'user.error.msg'}=
             $r->uri.":opa:0:0:Cannot modify spreadsheet";
         return HTTP_NOT_ACCEPTABLE; 
     }
-    my $courseid = $ENV{'request.course.id'};
+    my $courseid = $env{'request.course.id'};
     #
-    # Do not allow students to continue if standard grading is in effect.
-    if ($ENV{'request.role'} =~ /^st\./) {
-        if ($ENV{'course.'.$courseid.'.grading'} eq 'standard') {
+    # Do not allow students to continue if standard or external grading is in
+    # effect.
+    #
+    if ($env{'request.role'} =~ /^st\./) {
+        if ($env{'course.'.$courseid.'.grading'} eq 'standard' ||
+	    $env{'course.'.$courseid.'.grading'} eq 'external' ) {
             return HTTP_NOT_ACCEPTABLE;
         }
     }
@@ -237,37 +241,40 @@ sub handler {
     # Get query string for limited number of parameters
     #
     &Apache::loncommon::get_unprocessed_cgi
-        ($ENV{'QUERY_STRING'},['sname','sdomain','usymb','filename','recalc']);
+        ($ENV{'QUERY_STRING'},['sname','sdomain','usymb','filename','recalc',
+                               'output_format','not_first_run']);
     #
     # Deal with restricted student permissions 
     #
-    if ($ENV{'request.role'} =~ /^st\./) {
-        delete $ENV{'form.cell'}       if (exists($ENV{'form.cell'}));
-        delete $ENV{'form.newformula'} if (exists($ENV{'form.newformula'}));
+    if ($env{'request.role'} =~ /^st\./) {
+        delete $env{'form.cell'}       if (exists($env{'form.cell'}));
+        delete $env{'form.newformula'} if (exists($env{'form.newformula'}));
     }
     #
     # Determine basic information about the spreadsheet
     my ($sheettype) = ($r->uri=~/\/(\w+)$/);
     #
     my $symb   = undef;
-    $symb = $ENV{'form.usymb'} if (exists($ENV{'form.usymb'}));
-    my $name   = $ENV{'user.name'};
-    my $domain = $ENV{'user.domain'};
-    if (exists($ENV{'form.sname'})) {
-        $name   = $ENV{'form.sname'};
-        $domain = $ENV{'form.sdomain'};
+    $symb = $env{'form.usymb'} if (exists($env{'form.usymb'}));
+    my $name   = $env{'user.name'};
+    my $domain = $env{'user.domain'};
+    if (exists($env{'form.sname'}) && $env{'form.sname'} ne '') {
+        $name   = $env{'form.sname'};
+        $domain = $env{'form.sdomain'};
     }
+    $env{'form.sname'} = $name;
+    $env{'form.sdomain'} = $domain;
     ##
     ## Check permissions
     my $allowed_to_edit = &Apache::lonnet::allowed('mgr',
-                                                $ENV{'request.course.id'});
+                                                $env{'request.course.id'});
     # Only those instructors/tas/whatevers with complete access
     # (not section restricted) are able to modify spreadsheets.
     my $allowed_to_view =  &Apache::lonnet::allowed('vgr',
-                                                $ENV{'request.course.id'});
+                                                $env{'request.course.id'});
     if (! $allowed_to_view) {
         $allowed_to_view = &Apache::lonnet::allowed('vgr',
-                    $ENV{'request.course.id'}.'/'.$ENV{'request.course.sec'});
+                    $env{'request.course.id'}.'/'.$env{'request.course.sec'});
         # Those who are restricted by section are allowed to view.
         # The routines in lonstatistics which decide which students' 
         # will be shown take care of the restriction by section.
@@ -277,20 +284,20 @@ sub handler {
     # if they are not requesting their own.
     if ($sheettype eq 'classcalc') {
         if (! $allowed_to_view) {
-	    $ENV{'user.error.msg'}=
+	    $env{'user.error.msg'}=
 		$r->uri.":vgr:0:0:Access Permission Denied";
 	    return HTTP_NOT_ACCEPTABLE; 
 	}
     }
-    if ((($name   ne $ENV{'user.name'} ) ||
-         ($domain ne $ENV{'user.domain'})) && $sheettype ne 'classcalc') {
+    if ((($name   ne $env{'user.name'} ) ||
+         ($domain ne $env{'user.domain'})) && $sheettype ne 'classcalc') {
         # Check that the student is in their section?
-        if (exists($ENV{'request.course.sec'}) && 
-            $ENV{'request.course.sec'} ne '' ) {
-            my $stu_sec = &Apache::lonnet::usection($domain,$name,
-                                                    $ENV{'request.course.id'});
-            if ($stu_sec ne $ENV{'request.course.sec'}) {
-		$ENV{'user.error.msg'}=
+        if (exists($env{'request.course.sec'}) && 
+            $env{'request.course.sec'} ne '' ) {
+            my $stu_sec = &Apache::lonnet::getsection($domain,$name,
+						    $env{'request.course.id'});
+            if ($stu_sec ne $env{'request.course.sec'}) {
+		$env{'user.error.msg'}=
 		    $r->uri.":vgr:0:0:Requested student not in your section.";
 		return HTTP_NOT_ACCEPTABLE; 
             }
@@ -321,8 +328,8 @@ sub handler {
         my $extra_javascript = 
             &Apache::loncommon::browser_and_searcher_javascript();
         $r->print(<<ENDSCRIPT);
-<script language="JavaScript">
-
+<script type="text/javascript">
+//<!--
     $extra_javascript
 
     var editwin;
@@ -355,53 +362,74 @@ sub handler {
             editwin.close();
         }
 
-        editwin = window.open($nothing,'CellEditWin','height=280,width=480,scrollbars=no,resizeable=yes,alwaysRaised=yes,dependent=yes',true);
+        editwin = window.open($nothing,'CellEditWin','height=280,width=480,scrollbars=no,resizable=yes,alwaysRaised=yes,dependent=yes',true);
         editwin.document.write(edit_text);
     }
+//-->
 </script>
 ENDSCRIPT
     }
+    &Apache::lonhtmlcommon::clear_breadcrumbs();
+    &Apache::lonhtmlcommon::add_breadcrumb
+        ({href  => $r->uri,
+          title => 'Spreadsheet',
+          text  => 'Spreadsheet',
+          faq   => 134,
+          bug   => 'Spreadsheet'});
     $r->print('</head>'.&Apache::loncommon::bodytag('Grades Spreadsheet').
+              &Apache::lonhtmlcommon::breadcrumbs(undef,'Spreadsheet').
               '<form action="'.$r->uri.'" name="sheet" method="post">');
-    $r->print(&hiddenfield('sname'  ,$ENV{'form.sname'}).
-              &hiddenfield('sdomain',$ENV{'form.sdomain'}).
-              &hiddenfield('usymb'  ,$ENV{'form.usymb'}));
+    $r->print(&hiddenfield('sname'  ,$env{'form.sname'}).
+              &hiddenfield('sdomain',$env{'form.sdomain'}).
+              &hiddenfield('usymb'  ,$env{'form.usymb'}));
     $r->rflush();
     ##
     ## Determine the filename to use
     my $filename = undef;
     if ($allowed_to_edit) {
-        $filename = $ENV{'form.filename'} if (exists($ENV{'form.filename'}));
+        $filename = $env{'form.filename'} if (exists($env{'form.filename'}));
         #
-        if (exists($ENV{'form.load'}) && exists($ENV{'form.loadfilename'})) {
-            $filename = $ENV{'form.loadfilename'};
-            $ENV{'form.workcopy'} = 'no';
+        if (exists($env{'form.load'}) && exists($env{'form.loadfilename'})) {
+            $filename = $env{'form.loadfilename'};
+            $env{'form.workcopy'} = 'no';
         }
     }
     ##
     ## Take care of "backdoor" spreadsheet expiration / recalc stuff
-    if ($allowed_to_edit && exists($ENV{'form.recalc'})) {
-        if (exists($ENV{'form.recalc'})) {
-            &Apache::loncoursedata::delete_caches($ENV{'requres.course.id'});
+    if ($allowed_to_edit && exists($env{'form.recalc'})) {
+        if (exists($env{'form.recalc'})) {
+            &Apache::loncoursedata::delete_caches($env{'requres.course.id'});
         }
-        if ($ENV{'form.recalc'} eq 'ilovewastingtime') {
-            &Apache::lonnet::logthis('ilovewastingtime');
+        if ($env{'form.recalc'} eq 'ilovewastingtime') {
+            &Apache::lonnet::logthis('spreadsheet expired: entire course');
             # expire ALL spreadsheets
             &Apache::lonnet::expirespread('','','studentcalc');
             &Apache::lonnet::expirespread('','','assesscalc');
-        } elsif ($ENV{'form.recalc'} =~ /^symb:/) {
+            $r->print('<h3>'.
+                      &mt('Expired spreadsheet caches for all students').
+                      '</h3>');
+        } elsif ($env{'form.recalc'} =~ /^symb:/) {
             # expire for all students on this symb
-            my ($symb) = ($ENV{'form.recalc'} =~ /^symb:(.*)$/);
-            &Apache::lonnet::logthis('symb = '.$symb);
+            my ($symb) = ($env{'form.recalc'} =~ /^symb:(.*)$/);
+            &Apache::lonnet::logthis('spreadsheet expired: symb = '.$symb);
             &Apache::lonnet::expirespread('','','assesscalc',$symb);
             &Apache::lonnet::expirespread('','','studentcalc');
-        } elsif ($ENV{'form.recalc'} =~ /^student:/) {
+            $r->print('<h3>'.
+              &mt('Expired spreadsheet caches for all students for symb  [_1]',
+                  $symb).
+                      '</h3>');
+        } elsif ($env{'form.recalc'} =~ /^student:/) {
             # expire all assessment spreadsheets for this user
-            my ($sname,$sdom) = ($ENV{'form.recalc'}=~/^student:(.*):(.*)$/);
-            &Apache::lonnet::logthis('student = '.$sname.':'.$sdom);
+            my ($sname,$sdom) = ($env{'form.recalc'}=~/^student:(.*):(.*)$/);
+            &Apache::lonnet::logthis('spreadsheet expired: student = '.
+                                     $sname.'@'.$sdom);
             if (defined($sname) && defined($sdom)) {
                 &Apache::lonnet::expirespread($sname,$sdom,'assesscalc');
                 &Apache::lonnet::expirespread($sname,$sdom,'studentcalc');
+                $r->print('<h3>'.
+                          &mt('Expired spreadsheet caches for student [_1]',
+                              $sname.'@'.$sdom).
+                          '</h3>');
             }
         }
     }
@@ -431,7 +459,7 @@ ENDSCRIPT
     ## Editing/loading/saving
     if ($allowed_to_edit) {
         my ($html,$action_message) = &file_dialogs($spreadsheet);
-        if ($ENV{'form.makedefault'}) {
+        if ($env{'form.makedefault'}) {
             $spreadsheet->make_default();
             if ($action_message) {
                 $action_message .= '<br />';
@@ -446,8 +474,10 @@ ENDSCRIPT
             }
             $action_message .= '.';
         }
-        $r->print('<table><tr><td>'.$spreadsheet->html_header().'</td>'.
-                  '<td valign="bottom">'.$html."</td></tr></table>\n");
+        $r->print('<table><tr><td valign="top">'.
+                  $spreadsheet->html_header().
+                  '</td>'.
+                  '<td valign="center">'.$html."</td></tr></table>\n");
         if ($action_message ne '') {
             $r->print(<<END);
 <table>
@@ -466,11 +496,9 @@ END
     $r->rflush();
     #
     $r->print("<table><tr>");
-    if ($sheettype eq 'classcalc') {
-        $r->print('<td><input type="submit" value="'.
-		  &mt('Generate Spreadsheet').'" />'.
-                  '</td>');
-    }
+    $r->print('<td><input type="submit" value="'.
+              &mt('Generate Spreadsheet').'" />'.
+              '</td>');
     if ($allowed_to_view) {
         $r->print('<td>'.
                   &Apache::loncommon::help_open_topic("Spreadsheet_About",
@@ -491,7 +519,7 @@ END
     # Keep track of the number of times we have been called, sort of.
     $r->print(&hiddenfield('not_first_run','whatever'));
     #
-    if (exists($ENV{'form.not_first_run'}) || $sheettype ne 'classcalc') {
+    if (exists($env{'form.not_first_run'}) || $sheettype ne 'classcalc') {
         $r->print($spreadsheet->get_html_title());
         if ($allowed_to_view || $allowed_to_edit) {
             $r->print($spreadsheet->parent_link());
@@ -500,6 +528,7 @@ END
         $spreadsheet->display($r);
     }
     $r->print('</form></body></html>');
+    $spreadsheet->clear_package();
     return OK;
 }