CVS log for loncom/interface/spreadsheet/lonspreadsheet.pm

Up to [LON-CAPA] / loncom / interface / spreadsheet

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  Backport 1.66, 1.67

- Bug 6955 IP-based blocking. Pass user'sIP address as third arg to
  loncommon::blockcheck() and second to loncommon::blocking_status().

- For 2.11.2 (modified)
  Include changes in 1.66

- For 2.11.3 (modified)
  Include changes in 1.66

- Blocking of user actions during an exam can include a student's access to
  course grades via the "Grades" menu item, and to a "detailed score sheet"
  if grading is set to use the Spreadsheet.

- For 2.11
  - Backport 1.62, 1.63, 1.64, 1.65

XHTML: action attribute in <form> tag required (dummy attribute added)

XHTML: JavaScript event handlers in lower case

- Cell editing: Internationalization and consistent wording of button texts
- Last Action: Internationalization and consistent layout

Internationalization

- For 2.11.
  - Reverse changes in 1.58. ("3.0" grading interface).

- Backport 1.57, 1.59, 1.60, 1.61.

- sname:sdomain need to be correct.

- Missing localization.
- Add <span>s (with suitable classes) for messages.

- Replace permission checking based on role (e.g., student) with
  checking based on privileges.
- In cases where /adm/classcalc is requested, but role's privileges
  prevent display:
   - internal redirection to /adm/studentcalc, if current grading mechansim
     is spreadsheet.
   - internal redirection to /adm/quickgrades otherwise.

Work-in-progress: Grading

Directly jump to Course Preferences

Overload was not a good idea. Let the operating system take care of this.

- Avoid HTML encoding conflicts:
    Don't use unescaped "&"
- Better separation of content and style
    Moved quotation marks and bold tags from mt text to script code
- Consistent wording and highlighting of Back and Next buttons
    (course initialization helper)
- Cloning courses helper screen:
    - Added some missing phrases to translation files (de.pm, zh.pm)
    - Wording: It's usernames, not names (who are allowed to clone)
- Wording (de.pm)

- XHTML conform selected
- Localization: Added &mt() call to fieldset legend text

XHTML: Added quotes to HTML attribute values in input fields

Replaced
  <nobr>...</nobr>
by
  <span class="LC_nobreak">...</span>

- lonsearchcat.pm: Added missing start tag for nobreak area
- lonsurveyreports.pm: Added missing end tag for nobreak area

- BUG#5347 use the auto resizing textarea code in the spreadsheet popup editor window

Close the document stream when writing is finished.

- add default help to spread sheet

- update spreadsheet access links

Determination of parameters for spreadsheet now correctly cascades for cases where a user has multiple active groups. Also groups are passed in argument list for Spreadsheet object as array reference. Lastly lonnet::get_users_groups function modified to only return user's active groups, except in case when user status has expired (and default end access date for students has also passed), in which case user's groups which were still active less than 24 hours before default end date are also included in user's groups. [For consistency with students groups returned by loncoursedata::get_students_groups()].

- end_page

- start_page

Making group-based parameters apply in spreadsheet, using same cascading precedence scheme as used for parmset.

- #self->{'section'} never got set

- BUG#4301 - SPRS saving was fuzting things up

- need to undef $navmap so that the hashes are untied

- ENV -> env

- eliminating usection in favor of getsection

Modified to use inline progress window.

Bug 2945: Give DCs links to expire spreadsheet caches.

No longer translate before calling lonhtmlcommon::add_breadcrumb and
lonhtmlcommon::breadcrumb.

- backport 1.34, 1.35

No need for this debugging code.

These fixes should go on S10 as soon as possible.

Spreadsheet.pm: Fix to handle the case when a spreadsheet object is
created without a valid username/domain passed to new().

assesscalc.pm: Fix to ignore stored data which does not contain the username
and domain.

lonspreadsheet.pm: Fix to not do stupid things that got us in this mess
in the first place (only accept form parameters which have values and do not
send out form parameters without values).

Added lonhtmlcommon breadcrumbs.

Help buttons

Always show the 'generate spreadsheet' button, regardless of the type of
spreadsheet.

- BUG#2389, new gradin mode external, doesn't show points on quickgrades, but also doesn't show link to SPRS

- apparently it is resizable not resizeable

HTML fixups.

Internationalize and fix "seperate".

Clear out data caches when we do any recalculations.

At least output the right headers.

Don't die entirely on a bad attempt to save spreadsheet.
Report the current filename when save is successful, not just what the
user told us to make the filename.

Minor modifications brought about due to making warnings fatal.

Fixed missing </select> in load file dialog.

Added spreadsheet help links.

help-less spreadsheet, in case 1.0 goes out without spreadsheet help
files being written.

Added help links. (not all links are valid at this time)
Added intentionally undocumented feature to expire spreadsheets.  Thus if
someone REALLY needs to expire all their spreadsheets they can ask us
first and we can tell them how to do so.  Also allow expiration of a
single student or a single symb if you know the secret words.

Larger edit window because the small one was driving me nuts.
Not neccessary for 1.0

Implement standard grading for spreadsheet by not allowing anyone with a
student role to view the spreadsheet if standard grading is in effect.

Added rflush after spreadsheet headers are output so the user doesn't have
to wait forever before they see anything.

Use loncommon::no_cache to plead not to be cached.

Proper error handling call.

Need the 'generate spreadsheet' button to be present in case you need
to change the section or enrollment status.

Bug 1793: If allowed did not return true for viewing the entire classes
spreadsheet, try it by section.  This lets TAs and Instructors assigned
tos specific sections view the course and student level spreadsheets for
their section ONLY.  Also check to determine if, at the student level,
the student is enrolled in the section the instructor is limited to.
This prevents TAs from viewing students outside their scope.

Interface changes:
make default has been changed to 'save and make default' and this functionality
has been implemented.
The description of the action last taken is no longer displayed in the middle
of the load/save table and instead appears below it.
The description of the last action taken is clearer and more cleanly presented.

Reworked spreadsheet filename handling.

Bug #1689: Users get confused between browsing the local file system and
browsing RES.

The official word is now "Select".

Added $spreadsheet->initialize() subroutine to take care of specific
initialization needed for each sheet.  assesscalc now has a list of
mandatory parameters (Bug 1514) but is running in to problems with
bug 1513.

Fix to load file selector not having a value selected.

Removing lonmenu call.

Moved load/save dialog generation to seperate subroutine.
Reworked placement of UI elements.
Added 'browse' link for  selection (part of Bug 657) of published
spreadsheets.  These are not currently supported, but this is the first step.

Added output selector and implemented excel output.

Moved $spreadsheet->display() to Spreadsheet.pm instead of having it reside
    three times in the descendents of the spreadsheet object.
Moved $spreadsheet->outsheet_excel() to Spreadsheet.pm for the same reason.
Created Spreadsheet::output_selector, which allows the user to select the
    output mode they desire.
Created $spreadsheet->excel_output_row which takes care of writing a row
    to an excel worksheet.
classcalc.pm, studentcalc.pm, and assesscalc.pm each had the same work done
on them:
  Created &excel_rows(), which writes the body of the spreadsheets to
     an excel file.
  Rewrote &get_title to return an array of title lines.
  Created &get_html_title to return an HTML version of the results of
     &get_title.

classcalc.pm and Spreadsheet.pm each have the following change:
    Created &html_header to return appropriate HTML for the spreadsheet.

Minor revision to permissions checking.  Added '$allowed_to_view' and
replaced '$editing_is_allowed' with '$allowed_to_edit'.
Only present link to parent sheet if the user is allowed to view or edit
grades.

Access to assessment level spreadsheets requires 'mgr' (modify grades)
privileges.

Nearly complete reworking of spreadsheet.

lonspreadsheet.pm holds a few utility functions and the handler, which
creates a spreadsheet and tells it to display itself.

Spreadsheet.pm is the base definition of the spreadsheet object.
classcalc.pm, studentcalc.pm, and assesscalc.pm are implementations of the
spreadsheets.

There are missing pieces - excel and csv output, limiting by section
permissions, the ability to add extra 'header' rows to the student and
course level sheets, and students are still allowed to view the assessment
level sheets (will disable this soon).

Computing and editing of the spreadsheet have been tested and have been
given a preliminary seal of approval.