--- loncom/interface/statistics/lonproblemanalysis.pm 2004/10/04 19:10:26 1.91 +++ loncom/interface/statistics/lonproblemanalysis.pm 2004/10/05 14:03:45 1.93 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonproblemanalysis.pm,v 1.91 2004/10/04 19:10:26 matthew Exp $ +# $Id: lonproblemanalysis.pm,v 1.93 2004/10/05 14:03:45 matthew Exp $ # # Copyright Michigan State University Board of Trustees # @@ -619,9 +619,9 @@ sub OR_tries_analysis { foreach my $foilid (@{$concept->{'foils'}}) { for (my $try=$mintries;$try<=$maxtries;$try++) { # concept analysis data - $concept_data[$j]->{'_correct'} += + $concept_data[$j]->[$try]->{'_correct'} += $response_data{$foilid}->[$try]->{'_correct'}; - $concept_data[$j]->{'_total'} += + $concept_data[$j]->[$try]->{'_total'} += $response_data{$foilid}->[$try]->{'_total'}; # # foil analysis data @@ -663,19 +663,32 @@ sub OR_tries_analysis { if (defined($Concepts)) { $num_concepts = scalar(@$Concepts); } # for (my $try=$mintries;$try<=$maxtries;$try++) { + if (! defined($response_data{'_total'}->[$try]) || + $response_data{'_total'}->[$try] == 0) { + if ($try > 1) { + $analysis_html.= ''. + &mt('None of the selected students attempted the problem more than [_1] times.',$try-1). + ''; + } else { + $analysis_html.= ''. + &mt('None of the selected students have attempted the problem').''; + } + last; + } my $concept_graph=''; if ($num_concepts > 1) { # # Create concept plot my @concept_plot_data; for (my $j=0;$j<=$#concept_data;$j++) { - my $total = $concept_data[$j]->{'_total'}; + my $total = $concept_data[$j]->[$try]->{'_total'}; if ($total == 0) { $concept_plot_data[$j] = 0; } else { $concept_plot_data[$j] = 100 * sprintf('%0.3f', - $concept_data[$j]->{'_correct'} / $total); + $concept_data[$j]->[$try]->{'_correct'} / + $total); } } #