--- loncom/interface/statistics/lonproblemanalysis.pm 2004/12/02 21:53:33 1.106 +++ loncom/interface/statistics/lonproblemanalysis.pm 2005/02/22 04:32:46 1.112 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonproblemanalysis.pm,v 1.106 2004/12/02 21:53:33 matthew Exp $ +# $Id: lonproblemanalysis.pm,v 1.112 2005/02/22 04:32:46 matthew Exp $ # # Copyright Michigan State University Board of Trustees # @@ -37,7 +37,6 @@ use Apache::lonstathelpers(); use Apache::lonstudentsubmissions(); use HTML::Entities(); use Time::Local(); -use Spreadsheet::WriteExcel(); use capa; my $plotcolors = ['#33ff00', @@ -53,9 +52,7 @@ my @SubmitButtons = ({ name => 'PrevProb text => 'Next Problem' }, { name => 'break'}, { name => 'SelectAnother', - text => 'Choose a different Problem' }, - { name => 'ExcelOutput', - text => 'Produce Excel Output' }); + text => 'Choose a different Problem' }); sub BuildProblemAnalysisPage { my ($r,$c)=@_; @@ -84,10 +81,7 @@ sub BuildProblemAnalysisPage { &Apache::lonstathelpers::manage_caches($r,'Statistics','stats_status'); $r->rflush(); # - # Support for numerical and radio response isn't complete enough to - # include in 1.2 release. - # my $problem_types = '(option|radiobutton|numerical)'; - my $problem_types = '.';#(option)'; + my $problem_types = '(option|radiobutton|numerical)'; if (exists($ENV{'form.problemchoice'}) && ! exists($ENV{'form.SelectAnother'})) { foreach my $button (@SubmitButtons) { @@ -266,9 +260,10 @@ sub numerical_response_analysis { $respid,$students); if ($c->aborted()) { return; }; # - my $responses = &numerical_classify_responses($response_data,$correct, - $restriction_function); - if ($responses->{'_count'} == 0) { + my ($responses,$stats) = + &numerical_classify_responses($response_data,$correct, + $restriction_function); + if ($stats->{'submission_count'} == 0) { $analysis_html.= ''. &mt($no_data_message,$plot_num,@extra_data). @@ -280,16 +275,16 @@ sub numerical_response_analysis { ''. ''. &mt($stats_message, - $responses->{'_count'}, - $responses->{'_correct'}, - $responses->{'_count'}-$responses->{'_correct'}, - $responses->{'_students'}, + $stats->{'submission_count'}, + $stats->{'correct_count'}, + $stats->{'incorrect_count'}, + $stats->{'students'}, @extra_data). ''. ''.''. - &numerical_plot_percent($r,$responses).''. + &numerical_plot_percent($r,$responses,$stats).''. ''. - &numerical_plot_differences($r,$responses).''. + &numerical_plot_differences($r,$responses,$stats).''. ''; } if ($post_message ne '') { @@ -304,40 +299,22 @@ sub numerical_response_analysis { } sub numerical_plot_percent { - my ($r,$responses) = @_; + my ($r,$responses,$stats) = @_; # - my $total = $responses->{'_count'}; + my $total = $stats->{'submission_count'}; return '' if ($total == 0); - my $minbin = 5; - while (my ($interval,$submissions) = each(%$responses)) { - next if ($interval =~ /^_/); - my ($ans,$ans_low,$ans_high) = split(" ",$interval); - my $low_percent = abs(100*($ans-$ans_low)/$ans); - my $high_percent = abs(100*($ans_high-$ans)/$ans); - if ($minbin > $high_percent) { $minbin = $high_percent; } - if ($minbin > $low_percent) { $minbin = $low_percent; } - } - # + my $min_bin_size = $stats->{'min_abs'}; + my $low_bin = $stats->{'lowest_ans'}-$stats->{'max_bin_size'}; + my $high_bin = $stats->{'highest_ans'}+$stats->{'max_bin_size'}; my @bins; - if ($minbin < 1) { - @bins = ('0.1','0.5','1.0','1.5','2.0','2.5','3.0','4.0','5.0',10,20,50,100); - } elsif ($minbin < 2) { - @bins = ('0.5','1.0','1.5','2.0','2.5','3.0','4.0','5.0',10,20,50,100); - } elsif ($minbin < 5) { - @bins = (1,2,3,4,5,10,25,50,75,100,200); - } elsif ($minbin < 10) { - @bins = (2,4,6,8,10,12,15,20,25,30,50,75,100,200); - } else { - @bins = (5,10,15,20,25,30,50,75,100,200); + for (my $num = $low_bin;$num <= $high_bin;$num+=($min_bin_size/2)) { + push(@bins,$num); } - my @labels = (1..scalar(@bins)); # my @correct; my @incorrect; my @count; - while (my ($interval,$submissions) = each(%$responses)) { - next if ($interval =~ /^_/); - my ($ans,$ans_low,$ans_high) = split(" ",$interval); + while (my ($ans,$submissions) = each(%$responses)) { while (my ($submission,$counts) = each(%$submissions)) { my ($correct_count,$incorrect_count) = @$counts; my $scaled_value = abs(($submission-$ans)/$ans); @@ -351,13 +328,32 @@ sub numerical_plot_percent { } } # - my @plot_correct; - my @plot_incorrect; + # Skip empty bins + my (@plot_correct,@plot_incorrect,@new_bins,@new_count); + my $min_skip = 2; for (my $i=0;$i<=$#bins;$i++) { - $plot_correct[$i] = $correct[$i]*100/$total; - $plot_incorrect[$i] = $incorrect[$i]*100/$total; + my $sum=0; + for (my $j=-$min_skip;$j<=$min_skip && $i+$j<=$#bins;$j++) { + $sum += $correct[$i+$j] + $incorrect[$i+$j]; + } + if ($sum) { + push(@new_bins,$bins[$i]); + push(@plot_correct,$correct[$i]); + push(@plot_incorrect,$incorrect[$i]); + push(@new_count,$correct[$i]+$incorrect[$i]); + } + } + @correct = @plot_correct; + @incorrect = @plot_incorrect; + @count = @new_count; + @bins = @new_bins; + for (my $i=0;$i<=$#bins;$i++) { + $plot_correct[$i] *= 100/$total; + $plot_incorrect[$i] *= 100/$total; } + # my $title = &mt('Distribution by Percent'); + my @labels = (1..scalar(@bins)); my $graph = &Apache::loncommon::DrawBarGraph ($title,'Percent difference from correct','Number of answers', 100,['#33FF00','#FF3300'],\@labels,\@plot_correct,\@plot_incorrect, @@ -369,41 +365,24 @@ sub numerical_plot_percent { } sub numerical_plot_differences { - my ($r,$responses) = @_; + my ($r,$responses,$stats) = @_; # - my $total = $responses->{'_count'}; + my $total = $stats->{'submission_count'}; return '' if ($total == 0); - my $minbin = undef; - my $maxbin = undef; - while (my ($interval,$submissions) = each(%$responses)) { - next if ($interval =~ /^_/); - my ($ans,$ans_low,$ans_high) = split(" ",$interval); - my $low_diff = abs($ans-$ans_low); - my $high_diff = abs($ans_high-$ans); - if (! defined($maxbin)) { $maxbin = $low_diff;} - if (! defined($minbin)) { $minbin = $low_diff;} - # - if ($minbin > $high_diff) { $minbin = $high_diff; } - if ($minbin > $low_diff ) { $minbin = $low_diff; } - # - if ($maxbin < $high_diff) { $maxbin = $high_diff; } - if ($maxbin < $low_diff ) { $maxbin = $low_diff; } - } # my @bins; my @labels; # Hmmmm, should switch to absolute difference for (my $i=1;$i<=20;$i++) { - push(@bins,$i*$minbin/2); + push(@bins,$i/2); push(@labels,$i); } # my @correct; my @incorrect; my @count; - while (my ($interval,$submissions) = each(%$responses)) { - next if ($interval =~ /^_/); - my ($ans,$ans_low,$ans_high) = split(" ",$interval); + while (my ($ans,$submissions) = each(%$responses)) { + next if ($ans =~ /^_/); while (my ($submission,$counts) = each(%$submissions)) { my ($correct_count,$incorrect_count) = @$counts; my $value = abs($submission-$ans); @@ -435,65 +414,95 @@ sub numerical_plot_differences { } sub numerical_classify_responses { - &Apache::lonnet::logthis('--------------'); my ($full_row_data,$correct,$function) = @_; my %submission_data; my %students; + my %stats; my $max=0; foreach my $row (@$full_row_data) { -# &Apache::lonnet::logthis(' row = '.join(',',@$row)); my %subm = &hashify_attempt($row); if (ref($correct) eq 'HASH') { - $subm{'correct'} = $correct->{$subm{'student'}}->{'answer'}; - $subm{'unit'} = $correct->{$subm{'student'}}->{'unit'}; + my $s_correct = $correct->{$subm{'student'}}; + $subm{'correct'} = $s_correct->{'answer'}; + foreach my $item ('unit','ans_low','ans_high') { + $subm{$item} = $s_correct->{$item}; + } } else { # This probably never happens.... $subm{'correct'} = $correct->{'answer'}; $subm{'unit'} = $correct->{'unit'}; } + # + my $abs_low =abs($subm{'correct'}-$subm{'ans_low'}); + my $abs_high=abs($subm{'correct'}-$subm{'ans_high'}); + if (! defined($stats{'min_abs'}) || + $stats{'min_abs'} > $abs_low) { + $stats{'min_abs'} = $abs_low; + } + if ($stats{'min_abs'} > $abs_high) { + $stats{'min_abs'} = $abs_high; + } + if (! defined($stats{'max_abs'}) || + $stats{'max_abs'} < $abs_low) { + $stats{'max_abs'} = $abs_low; + } + if ($stats{'max_abs'} < $abs_high) { + $stats{'max_abs'} = $abs_high; + } + my $low_percent = 100 * abs($abs_low / $subm{'correct'}); + my $high_percent = 100 * abs($abs_high / $subm{'correct'}); + if (! defined($stats{'min_percent'}) || + $stats{'min_percent'} > $low_percent) { + $stats{'min_percent'} = $low_percent; + } + if ($stats{'min_percent'} > $high_percent) { + $stats{'min_percent'} = $high_percent; + } + if (! defined($stats{'max_percent'}) || + $stats{'max_percent'} < $low_percent) { + $stats{'max_percent'} = $low_percent; + } + if ($stats{'max_percent'} < $high_percent) { + $stats{'max_percent'} = $high_percent; + } + if (! defined($stats{'lowest_ans'}) || + $stats{'lowest_ans'} > $subm{'correct'}) { + $stats{'lowest_ans'} = $subm{'correct'}; + } + if (! defined($stats{'highest_ans'}) || + $stats{'highest_ans'} < $subm{'correct'}) { + $stats{'highest_ans'} = $subm{'correct'}; + } + # $subm{'submission'} =~ s/=\d+\s*$//; if (&$function(\%subm)) { my $scaled = '1'; my ($sname,$sdom) = split(':',$subm{'student'}); - # Note that $subm{'unit'} is modified by the following call - # We do not use it again but you should be aware just in case. -# my ($myunit,$mysub) = ($subm{'unit'},$subm{'submission'}); -# $myunit = 'm'; -# # &Apache::lonnet::logthis($myunit); -# my $result = -# &capa::caparesponse_get_real_response($myunit, -# $mysub, -# \$scaled); -# # &Apache::lonnet::logthis(' '.$myunit.':'.$subm{'unit'}. -# # ' '.$mysub.':'.$subm{'submission'}.'; '.$result); -# next if (! defined($scaled)); + my ($myunit,$mysub) = ($subm{'unit'},$subm{'submission'}); + my $result = + &capa::caparesponse_get_real_response($myunit, + $mysub, + \$scaled); + &Apache::lonnet::logthis('scaled = '.$scaled.' result ='.$result); + next if (! defined($scaled)); # next if ($result ne '6'); -# my $submission = $scaled; - my $submission = $subm{'submission'}; + my $submission = $scaled; $students{$subm{'student'}}++; + $stats{'submission_count'}++; if (&numerical_submission_is_correct($subm{'award'})) { - &Apache::lonnet::logthis('correct:'.$submission.':'.$subm{'correct'}); - $submission_data{'_correct'}++; - $submission_data{'_count'}++; + $stats{'correct_count'}++; $submission_data{$subm{'correct'}}->{$submission}->[0]++; } elsif (&numerical_submission_is_incorrect($subm{'award'})) { - &Apache::lonnet::logthis('incorrect:'.$submission.':'.$subm{'correct'}); - $submission_data{'_count'}++; + $stats{'incorrect_count'}++; $submission_data{$subm{'correct'}}->{$submission}->[1]++; } - my $value = - $submission_data{$subm{'correct'}}->{$submission}->[0]+ - $submission_data{$subm{'correct'}}->{$submission}->[1]; - if ($max < $value) { $max = $value; } } } - $submission_data{'_max'} = $max; - $submission_data{'_students'}=scalar(keys(%students)); - return \%submission_data; + $stats{'students'}=scalar(keys(%students)); + return (\%submission_data,\%stats); } sub numerical_submission_is_correct { my ($award) = @_; - &Apache::lonnet::logthis('award = "'.$award.'"'); if ($award =~ /^(APPROX_ANS|EXACT_ANS)$/) { return 1; } else { @@ -546,7 +555,10 @@ sub numerical_determine_answers { my ($r,$resource,$partid,$respid,$students)=@_; my $c = $r->connection(); # - # FIX ME: May need progress dialog updates + my %prog_state=&Apache::lonhtmlcommon::Create_PrgWin + ($r,'Student Answer Compilation Status', + 'Student Answer Compilation Progress', scalar(@$students), + 'inline',undef,'Statistics','stats_status'); # # Read in the cache (if it exists) before we start timing things. &Apache::lonstathelpers::ensure_proper_cache($resource->{'symb'}); @@ -564,13 +576,16 @@ sub numerical_determine_answers { $sdom); # make the key my $key = $partid.'.'.$respid; - $correct->{$sname.':'.$sdom}->{'answer'} = - $analysis->{$key.'.answer'}->[0]; - $correct->{$sname.':'.$sdom}->{'unit'} = - $analysis->{$key.'.unit'}->[0]; + foreach my $item ('answer','unit','ans_high','ans_low') { + $correct->{$sname.':'.$sdom}->{$item} = + $analysis->{$key.'.'.$item}->[0]; + } $answers{$analysis->{$key.'.answer'}->[0]}++; + &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state, + &mt('last student')); } &Apache::lonstathelpers::write_analysis_cache(); + &Apache::lonhtmlcommon::Close_PrgWin($r,\%prog_state); return ($correct,\%answers); } @@ -913,7 +928,6 @@ sub RR_concept_plot { } else { $incorrect_by_concept{$concept->{'name'}} += $foil_data->{$foil}->{$choice}; - } } } @@ -1138,30 +1152,22 @@ sub OptionResponseAnalysis { ''); } else { $r->rflush(); - if (exists($ENV{'form.ExcelOutput'})) { - my $result = &OR_excel_sheet($r,$resource, - $PerformanceData, - $problem_data); - $r->print($result); + if ($ENV{'form.AnalyzeOver'} eq 'tries') { + my $analysis_html = &OR_tries_analysis($r, + $PerformanceData, + $problem_data); + $r->print($analysis_html); + $r->rflush(); + } elsif ($ENV{'form.AnalyzeOver'} eq 'time') { + my $analysis_html = &OR_time_analysis($PerformanceData, + $problem_data); + $r->print($analysis_html); $r->rflush(); } else { - if ($ENV{'form.AnalyzeOver'} eq 'tries') { - my $analysis_html = &OR_tries_analysis($r, - $PerformanceData, - $problem_data); - $r->print($analysis_html); - $r->rflush(); - } elsif ($ENV{'form.AnalyzeOver'} eq 'time') { - my $analysis_html = &OR_time_analysis($PerformanceData, - $problem_data); - $r->print($analysis_html); - $r->rflush(); - } else { - $r->print('

'. - &mt('The analysis you have selected is '. - 'not supported at this time'). - '

'); - } + $r->print('

'. + &mt('The analysis you have selected is '. + 'not supported at this time'). + '

'); } } } @@ -1176,6 +1182,9 @@ sub OR_tries_analysis { my $mintries = 1; my $maxtries = $ENV{'form.NumPlots'}; my ($table,$Foils,$Concepts) = &build_foil_index($ORdata); + if (! defined($Concepts)) { + $Concepts = []; + } my %response_data = &OR_analyze_by_tries($r,$PerformanceData, $mintries,$maxtries); my $analysis = ''; @@ -1591,210 +1600,6 @@ sub OR_time_process_data { scalar(keys(%distinct_students))); } -######################################################### -######################################################### -## -## Excel output -## -######################################################### -######################################################### -sub build_student_data_worksheet { - my ($workbook,$format) = @_; - my $rows_output = 3; - my $cols_output = 0; - my $worksheet = $workbook->addworksheet('Student Data'); - $worksheet->write($rows_output++,0,'Student Data',$format->{'h3'}); - my @Headers = ('full name','username','domain','section', - "student\nnumber",'identifier'); - $worksheet->write_row($rows_output++,0,\@Headers,$format->{'header'}); - my @Students = @Apache::lonstatistics::Students; - my $studentrows = &Apache::loncoursedata::get_student_data(\@Students); - my %ids; - foreach my $row (@$studentrows) { - my ($mysqlid,$student) = @$row; - $ids{$student}=$mysqlid; - } - foreach my $student (@Students) { - my $name_domain = $student->{'username'}.':'.$student->{'domain'}; - $worksheet->write_row($rows_output++,0, - [$student->{'fullname'}, - $student->{'username'},$student->{'domain'}, - $student->{'section'},$student->{'id'}, - $ids{$name_domain}]); - } - return $worksheet; -} - -sub OR_excel_sheet { - my ($r,$resource,$performance_data,$ORdata) = @_; - my $response = ''; - my (undef,$Foils,$Concepts) = &build_foil_index($ORdata); - # - # Create excel worksheet - my $filename = '/prtspool/'. - $ENV{'user.name'}.'_'.$ENV{'user.domain'}.'_'. - time.'_'.rand(1000000000).'.xls'; - my $workbook = Spreadsheet::WriteExcel->new('/home/httpd'.$filename); - if (! defined($workbook)) { - $r->log_error("Error creating excel spreadsheet $filename: $!"); - $r->print('

'.&mt("Unable to create new Excel file. ". - "This error has been logged. ". - "Please alert your LON-CAPA administrator"). - '

'); - return undef; - } - # - $workbook->set_tempdir('/home/httpd/perl/tmp'); - my $format = &Apache::loncommon::define_excel_formats($workbook); - # - # Create and populate main worksheets - my $problem_data_sheet = $workbook->addworksheet('Problem Data'); - my $student_data_sheet = &build_student_data_worksheet($workbook,$format); - my $response_data_sheet = $workbook->addworksheet('Response Data'); - foreach my $sheet ($problem_data_sheet,$student_data_sheet, - $response_data_sheet) { - $sheet->write(0,0,$resource->{'title'},$format->{'h2'}); - $sheet->write(1,0,$resource->{'src'},$format->{'h3'}); - } - # - my $result; - $result = &OR_build_problem_data_worksheet($problem_data_sheet,$format, - $Concepts,$ORdata); - if ($result ne 'okay') { - # Do something useful - } - $result = &OR_build_response_data_worksheet($response_data_sheet,$format, - $performance_data,$Foils, - $ORdata); - if ($result ne 'okay') { - # Do something useful - } - $response_data_sheet->activate(); - # - # Close the excel file - $workbook->close(); - # - # Write a link to allow them to download it - $result .= '

'.&mt('Excel Raw Data Output').'

'. - '

'. - &mt('Your Excel spreadsheet.'). - '

'."\n"; - return $result; -} - -sub OR_build_problem_data_worksheet { - my ($worksheet,$format,$Concepts,$ORdata) = @_; - my $rows_output = 3; - my $cols_output = 0; - $worksheet->write($rows_output++,0,'Problem Structure',$format->{'h3'}); - ## - ## - my @Headers; - if (@$Concepts > 1) { - @Headers = ("Concept\nNumber",'Concept',"Foil\nNumber", - 'Foil Name','Foil Text','Correct value'); - } else { - @Headers = ('Foil Number','FoilName','Foil Text','Correct value'); - } - $worksheet->write_row($rows_output++,0,\@Headers,$format->{'header'}); - my %Foildata = %{$ORdata->{'_Foils'}}; - my $conceptindex = 1; - my $foilindex = 1; - foreach my $concept (@$Concepts) { - my @FoilsInConcept = @{$concept->{'foils'}}; - my $firstfoil = shift(@FoilsInConcept); - if (@$Concepts > 1) { - $worksheet->write_row($rows_output++,0, - [$conceptindex, - $concept->{'name'}, - $foilindex++, - $Foildata{$firstfoil}->{'name'}, - $Foildata{$firstfoil}->{'text'}, - $Foildata{$firstfoil}->{'value'},]); - } else { - $worksheet->write_row($rows_output++,0, - [ $foilindex++, - $Foildata{$firstfoil}->{'name'}, - $Foildata{$firstfoil}->{'text'}, - $Foildata{$firstfoil}->{'value'},]); - } - foreach my $foilid (@FoilsInConcept) { - if (@$Concepts > 1) { - $worksheet->write_row($rows_output++,0, - ['', - '', - $foilindex, - $Foildata{$foilid}->{'name'}, - $Foildata{$foilid}->{'text'}, - $Foildata{$foilid}->{'value'},]); - } else { - $worksheet->write_row($rows_output++,0, - [$foilindex, - $Foildata{$foilid}->{'name'}, - $Foildata{$foilid}->{'text'}, - $Foildata{$foilid}->{'value'},]); - } - } continue { - $foilindex++; - } - } continue { - $conceptindex++; - } - $rows_output++; - $rows_output++; - ## - ## Option data output - $worksheet->write($rows_output++,0,'Options',$format->{'header'}); - foreach my $string (@{$ORdata->{'_Options'}}) { - $worksheet->write($rows_output++,0,$string); - } - return 'okay'; -} - -sub OR_build_response_data_worksheet { - my ($worksheet,$format,$performance_data,$Foils,$ORdata)=@_; - my $rows_output = 3; - my $cols_output = 0; - $worksheet->write($rows_output++,0,'Response Data',$format->{'h3'}); - $worksheet->set_column(1,1,20); - $worksheet->set_column(2,2,13); - my @Headers = ('identifier','time','award detail','attempt'); - foreach my $foil (@$Foils) { - push (@Headers,$foil.' submission'); - push (@Headers,$foil.' grading'); - } - $worksheet->write_row($rows_output++,0,\@Headers,$format->{'header'}); - # - foreach my $row (@$performance_data) { - next if (! defined($row)); - my ($student,$award,$grading,$submission,$time,$tries) = @$row; - my @Foilgrades = split('&',$grading); - my @Foilsubs = split('&',$submission); - my %response_data; - for (my $j=0;$j<=$#Foilgrades;$j++) { - my ($foilid,$correct) = split('=',$Foilgrades[$j]); - my (undef,$submission) = split('=',$Foilsubs[$j]); - $submission = &Apache::lonnet::unescape($submission); - $response_data{$foilid.' submission'}=$submission; - $response_data{$foilid.' award'}=$correct; - } - $worksheet->write($rows_output,$cols_output++,$student); - $worksheet->write($rows_output,$cols_output++, - &Apache::lonstathelpers::calc_serial($time),$format->{'date'}); - $worksheet->write($rows_output,$cols_output++,$award); - $worksheet->write($rows_output,$cols_output++,$tries); - foreach my $foilid (@$Foils) { - $worksheet->write($rows_output,$cols_output++, - $response_data{$foilid.' submission'}); - $worksheet->write($rows_output,$cols_output++, - $response_data{$foilid.' award'}); - } - $rows_output++; - $cols_output = 0; - } - return; -} - sub build_foil_index { my ($ORdata) = @_; return if (! exists($ORdata->{'_Foils'}));