--- loncom/interface/statistics/lonproblemanalysis.pm 2004/11/10 21:23:10 1.104 +++ loncom/interface/statistics/lonproblemanalysis.pm 2005/02/16 17:43:20 1.111 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonproblemanalysis.pm,v 1.104 2004/11/10 21:23:10 matthew Exp $ +# $Id: lonproblemanalysis.pm,v 1.111 2005/02/16 17:43:20 matthew Exp $ # # Copyright Michigan State University Board of Trustees # @@ -37,7 +37,7 @@ use Apache::lonstathelpers(); use Apache::lonstudentsubmissions(); use HTML::Entities(); use Time::Local(); -use Spreadsheet::WriteExcel(); +use capa; my $plotcolors = ['#33ff00', '#0033cc', '#990000', '#aaaa66', '#663399', '#ff9933', @@ -52,9 +52,7 @@ my @SubmitButtons = ({ name => 'PrevProb text => 'Next Problem' }, { name => 'break'}, { name => 'SelectAnother', - text => 'Choose a different Problem' }, - { name => 'ExcelOutput', - text => 'Produce Excel Output' }); + text => 'Choose a different Problem' }); sub BuildProblemAnalysisPage { my ($r,$c)=@_; @@ -83,10 +81,7 @@ sub BuildProblemAnalysisPage { &Apache::lonstathelpers::manage_caches($r,'Statistics','stats_status'); $r->rflush(); # - # Support for numerical and radio response isn't complete enough to - # include in 1.2 release. - # my $problem_types = '(option|radiobutton|numerical)'; - my $problem_types = '.';#(option)'; + my $problem_types = '(option|radiobutton|numerical)'; if (exists($ENV{'form.problemchoice'}) && ! exists($ENV{'form.SelectAnother'})) { foreach my $button (@SubmitButtons) { @@ -201,6 +196,13 @@ sub numerical_response_analysis { 'stats_status'); $r->print(&numerical_one_dimensional_plot($r,600,150,$answers)); } + # + if (ref($response_data) ne 'ARRAY') { + $r->print('

'. + &mt('There is no submission data for this resource'). + '

'); + return; + } my $analysis_html = ''; for (my $plot_num = 1;$plot_num<=$ENV{'form.NumPlots'};$plot_num++) { my $restriction_function; @@ -253,13 +255,12 @@ sub numerical_response_analysis { $no_data_message = 'No data for [_2] to [_3]'; } # - my ($correct,$intervals,$answers) = - &numerical_response_determine_intervals($r,$resource,$partid, - $respid,$students); + my ($correct,$answers) = + &numerical_determine_answers($r,$resource,$partid, + $respid,$students); if ($c->aborted()) { return; }; # - my $responses = &numerical_classify_responses($response_data, - $correct, + my $responses = &numerical_classify_responses($response_data,$correct, $restriction_function); if ($responses->{'_count'} == 0) { $analysis_html.= @@ -301,15 +302,15 @@ sub numerical_plot_percent { # my $total = $responses->{'_count'}; return '' if ($total == 0); - my $minbin = 0.5; + my $minbin = 5; while (my ($interval,$submissions) = each(%$responses)) { next if ($interval =~ /^_/); my ($ans,$ans_low,$ans_high) = split(" ",$interval); - my $low_percent = abs(($ans-$ans_low)/$ans); - my $high_percent = abs(($ans_high-$ans)/$ans); + my $low_percent = abs(100*($ans-$ans_low)/$ans); + my $high_percent = abs(100*($ans_high-$ans)/$ans); if ($minbin > $high_percent) { $minbin = $high_percent; } if ($minbin > $low_percent) { $minbin = $low_percent; } - } + } # my @bins; if ($minbin < 1) { @@ -428,26 +429,43 @@ sub numerical_plot_differences { } sub numerical_classify_responses { + &Apache::lonnet::logthis('--------------'); my ($full_row_data,$correct,$function) = @_; my %submission_data; my %students; my $max=0; foreach my $row (@$full_row_data) { +# &Apache::lonnet::logthis(' row = '.join(',',@$row)); my %subm = &hashify_attempt($row); if (ref($correct) eq 'HASH') { - $subm{'correct'} = $correct->{$subm{'student'}}; - } else { - $subm{'correct'} = $correct; + $subm{'correct'} = $correct->{$subm{'student'}}->{'answer'}; + $subm{'unit'} = $correct->{$subm{'student'}}->{'unit'}; + } else { # This probably never happens.... + $subm{'correct'} = $correct->{'answer'}; + $subm{'unit'} = $correct->{'unit'}; } $subm{'submission'} =~ s/=\d+\s*$//; if (&$function(\%subm)) { - my $submission = $subm{'submission'}; + my $scaled = '1'; + my ($sname,$sdom) = split(':',$subm{'student'}); + # Note that $subm{'unit'} is modified by the following call + # We do not use it again but you should be aware just in case. + my ($myunit,$mysub) = ($subm{'unit'},$subm{'submission'}); + my $result = + &capa::caparesponse_get_real_response($myunit, + $mysub, + \$scaled); + next if (! defined($scaled)); + next if ($result ne '6'); + my $submission = $scaled; $students{$subm{'student'}}++; if (&numerical_submission_is_correct($subm{'award'})) { + &Apache::lonnet::logthis('correct:'.$submission.':'.$subm{'correct'}); $submission_data{'_correct'}++; $submission_data{'_count'}++; $submission_data{$subm{'correct'}}->{$submission}->[0]++; } elsif (&numerical_submission_is_incorrect($subm{'award'})) { + &Apache::lonnet::logthis('incorrect:'.$submission.':'.$subm{'correct'}); $submission_data{'_count'}++; $submission_data{$subm{'correct'}}->{$submission}->[1]++; } @@ -464,6 +482,7 @@ sub numerical_classify_responses { sub numerical_submission_is_correct { my ($award) = @_; + &Apache::lonnet::logthis('award = "'.$award.'"'); if ($award =~ /^(APPROX_ANS|EXACT_ANS)$/) { return 1; } else { @@ -512,7 +531,7 @@ sub numerical_bin_table { return $table; } -sub numerical_response_determine_intervals { +sub numerical_determine_answers { my ($r,$resource,$partid,$respid,$students)=@_; my $c = $r->connection(); # @@ -522,9 +541,6 @@ sub numerical_response_determine_interva &Apache::lonstathelpers::ensure_proper_cache($resource->{'symb'}); # my $correct; - # %intervals differs from %answers because it may be possible for two - # students to have the same correct answer but different intervals. - my %intervals; my %answers; foreach my $student (@$students) { last if ($c->aborted()); @@ -537,15 +553,14 @@ sub numerical_response_determine_interva $sdom); # make the key my $key = $partid.'.'.$respid; - my $interval = join(' ',($analysis->{$key.'.answer'}->[0], - $analysis->{$key.'.ans_low'}->[0], - $analysis->{$key.'.ans_high'}->[0])); - $correct->{$sname.':'.$sdom} = $interval; - $intervals{$interval}++; + $correct->{$sname.':'.$sdom}->{'answer'} = + $analysis->{$key.'.answer'}->[0]; + $correct->{$sname.':'.$sdom}->{'unit'} = + $analysis->{$key.'.unit'}->[0]; $answers{$analysis->{$key.'.answer'}->[0]}++; } &Apache::lonstathelpers::write_analysis_cache(); - return ($correct,\%intervals,\%answers); + return ($correct,\%answers); } # @@ -571,7 +586,11 @@ sub numerical_one_dimensional_plot { } } # - my $h_scale = ($width-10)/($max_x-$min_x); + my $min_max_difference = $max_x - $min_x; + if (! defined($min_max_difference) || $min_max_difference == 0) { + $min_max_difference = 1; + } + my $h_scale = ($width-10)/$min_max_difference; # my $ticscale = 5; if ($max_y * $ticscale > $height/2) { @@ -601,7 +620,6 @@ sub numerical_one_dimensional_plot { } $plot .= ''; my $plotresult = &Apache::lonxml::xmlparse($r,'web',$plot); - my $result = '
'. '
'. ''.&mt('Distribution of correct answers').''. @@ -652,33 +670,6 @@ sub circle { return &arc($x,$y,$radius,$radius,0,360,$color,$thickness,$filled); } -sub build_student_data_worksheet { - my ($workbook,$format) = @_; - my $rows_output = 3; - my $cols_output = 0; - my $worksheet = $workbook->addworksheet('Student Data'); - $worksheet->write($rows_output++,0,'Student Data',$format->{'h3'}); - my @Headers = ('full name','username','domain','section', - "student\nnumber",'identifier'); - $worksheet->write_row($rows_output++,0,\@Headers,$format->{'header'}); - my @Students = @Apache::lonstatistics::Students; - my $studentrows = &Apache::loncoursedata::get_student_data(\@Students); - my %ids; - foreach my $row (@$studentrows) { - my ($mysqlid,$student) = @$row; - $ids{$student}=$mysqlid; - } - foreach my $student (@Students) { - my $name_domain = $student->{'username'}.':'.$student->{'domain'}; - $worksheet->write_row($rows_output++,0, - [$student->{'fullname'}, - $student->{'username'},$student->{'domain'}, - $student->{'section'},$student->{'id'}, - $ids{$name_domain}]); - } - return $worksheet; -} - ######################################################### ######################################################### ## @@ -700,6 +691,9 @@ sub radio_response_analysis { my $analysis_html; my $foildata = $problem_analysis->{'_Foils'}; my ($table,$foils,$concepts) = &build_foil_index($problem_analysis); + if (! defined($concepts)) { + $concepts = []; + } # my %true_foils; my $num_true = 0; @@ -894,6 +888,7 @@ sub ensure_start_end_times { sub RR_concept_plot { my ($concepts,$foil_data,$title) = @_; + &Apache::lonnet::logthis('got to RR_concept_plot'); # my %correct_by_concept; my %incorrect_by_concept; @@ -908,7 +903,6 @@ sub RR_concept_plot { } else { $incorrect_by_concept{$concept->{'name'}} += $foil_data->{$foil}->{$choice}; - } } } @@ -942,6 +936,7 @@ sub RR_concept_plot { sub RR_create_percent_selected_plot { my ($concepts,$foils,$foil_data,$title) = @_; + &Apache::lonnet::logthis('got to RR_create_percent_selected_plot'); # if ($foil_data->{'_count'} == 0) { return ''; }; my %correct_selections; @@ -1013,6 +1008,7 @@ sub RR_create_percent_selected_plot { sub RR_create_stacked_selection_plot { my ($foils,$foil_data,$title,$true_foils)=@_; # + &Apache::lonnet::logthis('got to RR_create_stacked_selection_plot'); my @dataset; # array of array refs - multicolor rows $datasets[row]->[col] my @labels; my $count; @@ -1133,30 +1129,22 @@ sub OptionResponseAnalysis { ''); } else { $r->rflush(); - if (exists($ENV{'form.ExcelOutput'})) { - my $result = &OR_excel_sheet($r,$resource, - $PerformanceData, - $problem_data); - $r->print($result); + if ($ENV{'form.AnalyzeOver'} eq 'tries') { + my $analysis_html = &OR_tries_analysis($r, + $PerformanceData, + $problem_data); + $r->print($analysis_html); + $r->rflush(); + } elsif ($ENV{'form.AnalyzeOver'} eq 'time') { + my $analysis_html = &OR_time_analysis($PerformanceData, + $problem_data); + $r->print($analysis_html); $r->rflush(); } else { - if ($ENV{'form.AnalyzeOver'} eq 'tries') { - my $analysis_html = &OR_tries_analysis($r, - $PerformanceData, - $problem_data); - $r->print($analysis_html); - $r->rflush(); - } elsif ($ENV{'form.AnalyzeOver'} eq 'time') { - my $analysis_html = &OR_time_analysis($PerformanceData, - $problem_data); - $r->print($analysis_html); - $r->rflush(); - } else { - $r->print('

'. - &mt('The analysis you have selected is '. - 'not supported at this time'). - '

'); - } + $r->print('

'. + &mt('The analysis you have selected is '. + 'not supported at this time'). + '

'); } } } @@ -1171,6 +1159,9 @@ sub OR_tries_analysis { my $mintries = 1; my $maxtries = $ENV{'form.NumPlots'}; my ($table,$Foils,$Concepts) = &build_foil_index($ORdata); + if (! defined($Concepts)) { + $Concepts = []; + } my %response_data = &OR_analyze_by_tries($r,$PerformanceData, $mintries,$maxtries); my $analysis = ''; @@ -1258,7 +1249,7 @@ sub OR_tries_analysis { # $concept_graph = &Apache::loncommon::DrawBarGraph ('Correct Concepts','Concept Number','Percent Correct', - 100,$plotcolors,undef,\@concept_plot_data); + 100,$plotcolors,undef,\@concept_plot_data,{xskip=>1}); } # # Create Foil Plots @@ -1296,7 +1287,7 @@ sub OR_tries_analysis { # my $correct_graph = &Apache::loncommon::DrawBarGraph ('Correct Statements','Statement','% Answered Correct', - 100,$plotcolors,\@Labels,$Datasets[0]); + 100,$plotcolors,\@Labels,$Datasets[0],{xskip=>1}); # # @@ -1308,7 +1299,7 @@ sub OR_tries_analysis { $response_data{'_correct'}->[$try]; my $incorrect_graph = &Apache::loncommon::DrawBarGraph ('Incorrect Statements','Statement','% Chosen Incorrectly', - 100,$plotcolors,\@Labels,@Datasets); + 100,$plotcolors,\@Labels,@Datasets,{xskip=>1}); $analysis_html.= '
'. ''. @@ -1502,7 +1493,8 @@ sub OR_Foil_Time_Analysis { 100, $plotcolors, undef, - $plotdata[0]); + $plotdata[0], + {xskip=>1}); for (my $j=0; $j< scalar(@{$plotdata[0]});$j++) { $plotdata[0]->[$j]=0; } @@ -1513,7 +1505,7 @@ sub OR_Foil_Time_Analysis { 100, $plotcolors, undef, - @plotdata); + @plotdata,{xskip=>1}); return ($correct_plot,$incorrect_plot); } @@ -1544,7 +1536,7 @@ sub OR_Concept_Time_Analysis { 100, $plotcolors, undef, - \@plotdata); + \@plotdata,{xskip=>1}); } sub OR_time_process_data { @@ -1585,183 +1577,6 @@ sub OR_time_process_data { scalar(keys(%distinct_students))); } -######################################################### -######################################################### -## -## Excel output -## -######################################################### -######################################################### -sub OR_excel_sheet { - my ($r,$resource,$performance_data,$ORdata) = @_; - my $response = ''; - my (undef,$Foils,$Concepts) = &build_foil_index($ORdata); - # - # Create excel worksheet - my $filename = '/prtspool/'. - $ENV{'user.name'}.'_'.$ENV{'user.domain'}.'_'. - time.'_'.rand(1000000000).'.xls'; - my $workbook = Spreadsheet::WriteExcel->new('/home/httpd'.$filename); - if (! defined($workbook)) { - $r->log_error("Error creating excel spreadsheet $filename: $!"); - $r->print('

'.&mt("Unable to create new Excel file. ". - "This error has been logged. ". - "Please alert your LON-CAPA administrator"). - '

'); - return undef; - } - # - $workbook->set_tempdir('/home/httpd/perl/tmp'); - my $format = &Apache::loncommon::define_excel_formats($workbook); - # - # Create and populate main worksheets - my $problem_data_sheet = $workbook->addworksheet('Problem Data'); - my $student_data_sheet = &build_student_data_worksheet($workbook,$format); - my $response_data_sheet = $workbook->addworksheet('Response Data'); - foreach my $sheet ($problem_data_sheet,$student_data_sheet, - $response_data_sheet) { - $sheet->write(0,0,$resource->{'title'},$format->{'h2'}); - $sheet->write(1,0,$resource->{'src'},$format->{'h3'}); - } - # - my $result; - $result = &OR_build_problem_data_worksheet($problem_data_sheet,$format, - $Concepts,$ORdata); - if ($result ne 'okay') { - # Do something useful - } - $result = &OR_build_response_data_worksheet($response_data_sheet,$format, - $performance_data,$Foils, - $ORdata); - if ($result ne 'okay') { - # Do something useful - } - $response_data_sheet->activate(); - # - # Close the excel file - $workbook->close(); - # - # Write a link to allow them to download it - $result .= '

'.&mt('Excel Raw Data Output').'

'. - '

'. - &mt('Your Excel spreadsheet.'). - '

'."\n"; - return $result; -} - -sub OR_build_problem_data_worksheet { - my ($worksheet,$format,$Concepts,$ORdata) = @_; - my $rows_output = 3; - my $cols_output = 0; - $worksheet->write($rows_output++,0,'Problem Structure',$format->{'h3'}); - ## - ## - my @Headers; - if (@$Concepts > 1) { - @Headers = ("Concept\nNumber",'Concept',"Foil\nNumber", - 'Foil Name','Foil Text','Correct value'); - } else { - @Headers = ('Foil Number','FoilName','Foil Text','Correct value'); - } - $worksheet->write_row($rows_output++,0,\@Headers,$format->{'header'}); - my %Foildata = %{$ORdata->{'_Foils'}}; - my $conceptindex = 1; - my $foilindex = 1; - foreach my $concept (@$Concepts) { - my @FoilsInConcept = @{$concept->{'foils'}}; - my $firstfoil = shift(@FoilsInConcept); - if (@$Concepts > 1) { - $worksheet->write_row($rows_output++,0, - [$conceptindex, - $concept->{'name'}, - $foilindex++, - $Foildata{$firstfoil}->{'name'}, - $Foildata{$firstfoil}->{'text'}, - $Foildata{$firstfoil}->{'value'},]); - } else { - $worksheet->write_row($rows_output++,0, - [ $foilindex++, - $Foildata{$firstfoil}->{'name'}, - $Foildata{$firstfoil}->{'text'}, - $Foildata{$firstfoil}->{'value'},]); - } - foreach my $foilid (@FoilsInConcept) { - if (@$Concepts > 1) { - $worksheet->write_row($rows_output++,0, - ['', - '', - $foilindex, - $Foildata{$foilid}->{'name'}, - $Foildata{$foilid}->{'text'}, - $Foildata{$foilid}->{'value'},]); - } else { - $worksheet->write_row($rows_output++,0, - [$foilindex, - $Foildata{$foilid}->{'name'}, - $Foildata{$foilid}->{'text'}, - $Foildata{$foilid}->{'value'},]); - } - } continue { - $foilindex++; - } - } continue { - $conceptindex++; - } - $rows_output++; - $rows_output++; - ## - ## Option data output - $worksheet->write($rows_output++,0,'Options',$format->{'header'}); - foreach my $string (@{$ORdata->{'_Options'}}) { - $worksheet->write($rows_output++,0,$string); - } - return 'okay'; -} - -sub OR_build_response_data_worksheet { - my ($worksheet,$format,$performance_data,$Foils,$ORdata)=@_; - my $rows_output = 3; - my $cols_output = 0; - $worksheet->write($rows_output++,0,'Response Data',$format->{'h3'}); - $worksheet->set_column(1,1,20); - $worksheet->set_column(2,2,13); - my @Headers = ('identifier','time','award detail','attempt'); - foreach my $foil (@$Foils) { - push (@Headers,$foil.' submission'); - push (@Headers,$foil.' grading'); - } - $worksheet->write_row($rows_output++,0,\@Headers,$format->{'header'}); - # - foreach my $row (@$performance_data) { - next if (! defined($row)); - my ($student,$award,$grading,$submission,$time,$tries) = @$row; - my @Foilgrades = split('&',$grading); - my @Foilsubs = split('&',$submission); - my %response_data; - for (my $j=0;$j<=$#Foilgrades;$j++) { - my ($foilid,$correct) = split('=',$Foilgrades[$j]); - my (undef,$submission) = split('=',$Foilsubs[$j]); - $submission = &Apache::lonnet::unescape($submission); - $response_data{$foilid.' submission'}=$submission; - $response_data{$foilid.' award'}=$correct; - } - $worksheet->write($rows_output,$cols_output++,$student); - $worksheet->write($rows_output,$cols_output++, - &Apache::lonstathelpers::calc_serial($time),$format->{'date'}); - $worksheet->write($rows_output,$cols_output++,$award); - $worksheet->write($rows_output,$cols_output++,$tries); - foreach my $foilid (@$Foils) { - $worksheet->write($rows_output,$cols_output++, - $response_data{$foilid.' submission'}); - $worksheet->write($rows_output,$cols_output++, - $response_data{$foilid.' award'}); - } - $rows_output++; - $cols_output = 0; - } - return; -} - sub build_foil_index { my ($ORdata) = @_; return if (! exists($ORdata->{'_Foils'}));