CVS log for loncom/interface/statistics/lonproblemstatistics.pm

Up to [LON-CAPA] / loncom / interface / statistics

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11.4 (modified)
  Include changes in 1.127

- For 2.11
  - Backport 1.128.

- Fix ranges used in array slices to generate @BottomSet and @TopSet used
  to compute degree of discrimination.

- Bug 6754 LON-CAPA as LTI Consumer
  - Grading screens can be used to display passback transactions, and
    for override of scores etc., for external tools set to be "gradable".

- For 2.11
  - Backport 1.125, 1.126.

Fix wording typos

- Corrected unbalanced tags
- XHTML
- Internationalization:
    - Added missing &mt() calls
    - Time window info for Excel:
        - Improved output
        - Corrected start date (use correct variable)

- For 2.11
  - Backport 1.123, 1.124.

- Modify one change in rev. 1.123: revert to using square brackets in phrase to
  translate by escaping both [ and ] with a tilde.
  (see: http://perldoc.perl.org/Locale/Maketext.html).

- Internationalization and localization of labels in and for statistical graphs
- Use more descriptive "long_title" in plot graph option list if available
- Improved quantity handling in compiling data phrase
- Consistent styles (warning/info style, no headline)
- XHTML: "selected"

- Added missing phrases and translations to de.pm
- Corrected some translations related to statistics
- Consistent translation

- For 2.11
  - Reverse changes for 1.119 - they require "3.0" grading interface.

- changed headlines to normal text with info/error/warning style where necessary
- changed tables to data tables to unify UI

Part of Bug #6576: store part and instance info for statistics

Bug 6455 - Progress Indicator now jQuery. Still need to test across browsers.

Add statistics and reports under "grading"

- Bug 6119 Anonymous surveys.

- Use standard style for info messages
- Removed several unnecessary trailing white spaces

XHTML conform multiple selection

Optimized option selection tables for statistics:
- Use LON-CAPA standard tables
- Added missing &mt() calls
- XHTML conform "checked" and "selected" usage
- Added info/warning/error style to info/warning/error messages
- Added text "Options" to headline of options column
- Added horizontal line before and after problem output for better separation of problem content and rest of screen

Additional changes:
lonproblemanalysis.pm:
    - Now uses LON-CAPA standard table for foil value table
    - Moved status bar from inside the options table to under it
lonproblemstatistics.pm:
    - Moved Graph option from under the table to inside option table
lonstudentsubmissions.pm:
    - Moved output_selector from headline to extra column inside option table

Optimized status display:
- Set text box for display purposes only to readonly
- Use standard nobreak style
- Same paragraph structure for similar pages

Past tense of "occur" is "occurred" (rr!)
Also added some missing &mt() calls and corrected some other little typos

When using calls to &Apache::lonnet::EXT(), request a scalar explicitly, to avoid similar problems to those eencountered in bug 5578, following the change in lonnet.pm rev 1.927 which enabled EXT() to return the level a parameter is set at, if an array was requested.

- more re fix ups

Bug 4954.  Filter title changed from "Enrollment Status" to "Access Status".  Access Status selections in lonhtmlcommon set to:
Currently Has Access
Will Have Future Access
Previously Had Access
Any Access Status
See comment appended to bug 4954 for more information.
Documentation updated to include ability to selectively display students with future access.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

Adding groups filter to STATS functionality. New tables added (dom_course_groupnames and dom_course_studentgroups).

- update statistics calls to bread crumbs

Fix bug 4537; degree of discrimation should be much more useful and
accurate now.

- some stat reports were not cleaningup the navmap cglobal which menat the course hashes weren't untied

- ENV -> env

Bug 4034:ISE on excel output.  Woops.

lonstatistics.pm:Removed package variable @SelectedSections.
    Added &get_selected_sections
    Added &section_and_enrollment_description to provide a brief
        description of those students selected for statistics work
        (hopefully this descriptive line will make it in to bug reports).
Added &section_and_enrollment_description to all statistics pages
Replaced use of @SelectedSections with &get_selected_sections in statistics
    pages.

Updated to use loncommon::create_workbook.  Spreadsheets were slightly
modified to use formats.

Make the problem weight a selectable output instead of outputting it every
    time statistics are computed.

Fix bug where Excel output failed.

Allow output of problem weight.

loncoursedata.pm: changed &get_sum_of_scores to take symb instead of a
'resource' hash.
lonproblemstatistics: navmapification is complete.  Required addition of
package variables $navmap and @sequences.

Added problem weight output for research.

Added tries_per_correct

More information for research only.

Bug 3262: %wrong plot is now re-implemented.

&statistics_html_table_data: do not send 'nan' or other text into sprintf
with a numeric format as the data is reported as 0.0.

&compute_discrimination_factor: added check to return 'nan' if we are
unable to rank the students.

Added help link for statistics on sequences.

Turn computing the degree of discrimination on by default.

Statistics are not valide on surveys.

Unified cache handling among statistics routines.  All use inlined progress
dialog.
&lonstatistics:&Gather_Full_Student_data now takes $formname and $inputname
    for inlined progress dialog.
&lonstathelpers: All calls to lonstatistics::Sequences_with_Assess now pass
    parameter 'all' in for mode.  Added &manage_caches which takes care of
    updating student data at the right times.  "right times" may need some
    work.  &GetStudentAnswers now takes $formname, $inputname as parameters.
&lonproblemanalysis, &lonproblemstatistics, and &lonsubmissiontimeanalysis:
    Use lonstathelpers::manage_caches and inline progress dialog.
&lonstudentsubmissions: Uses lonstathelpers::manage_caches and inlines prgwin
    Uses inlined prgwin to display further status data.

More commented out code for data mining - the response types used in each
problem part can no be reported.

Added commented-out code to help Behrouz gather research data on problems.
Added excel format field support to excel data output.

lonmeta.pm: Added degree of discrimination output.
Added 'detailed assessment statistical data' output, a table of classes,
sections, and various statistics which make up the 'overall assessment
statistical data'.
lonmetadata.pm: Documented data storage in nohist_resevaldata.db
&process_dynmaic_metadata now uses a weighted average for statistics, and
reports the sum of the maximum number of students per class as 'stdno',
since there may be multiple entries per class.
Added &dynamic_metadata_storage which prepares statistical data for
storage in nohist_resevaldata.db.
lonproblemstatistics.pm: Use lonmetadata::dynamic_metadata_storage to prepare
storage of dynamic metadata.

Moved storage of dynamic metadata from loncoursedata to lonproblemstatistics.
lonproblemstatistics now only stores the dynamic metadata when the stats are
computed for all sections.
Discrimination factor computations now respect start and end times.
Modified loncoursedata::rank_students_by_scores_on_resources and
loncoursedata::get_sum_of_scores to support time constraints.

lonstathelpers: Added &sections_description to begin consolidating code
lonproblemstatistics: Added excel output of sequence statistics, now use
formats for headers in the worksheet.  Added a call to
&compute_sequence_statistics in &compute_all_statistics.
Fixed bug where the count mean for sequences was not stored.

degrees and tries statistics plots: Change title based on width of plot,
changed names of plot that appear in selection box, now appear at the top
of the drop-down list instead of the bottom, added y-axis label to
the tries statistics plot.

Make sure we compute the data we need to plot.
@Fields and @SeqFields: Stop modifying what should be static data structures
by using different keys for items selected by default and those currently
selected.

Bug 539: Report KR-21 reliability statistic

loncoursedata.pm:
  Added &limit_by_start_end_time to consolidate $starttime and $endtime code.
  Added &score_stats and &count_stats to return summary data on the scores
    and problem correct counts.

lonproblemstatistics:
  Added description of @Fields data structures
  Added @SeqFields, &output_sequence_statistics, &sequence_html_header,
    &sequence_html_output, and &compute_sequence_statistics.

Reporting statistics on sequences (instead of problems) is still being
fleshed out, interface wise.  No Excel output is available for sequence
statistics at this time.

Fix bug where the problem count was accurate but misleading: what really
matters is the number of problem parts.

Fixed bug with "#YES" not appearing in selection box (and thus always being
output) and made field selections a remembered course environment value.

Added ability to select which statistics will be printed out.

Removed some logging code.  Fixed bug with stats display always being in
'ungrouped' mode.

Added "Mean and S.D. of Tries" plot.

Complete rewrite/reworking of code and signifigant rewrite of interface.
Added combined DoDiff and DoDisc plot.

Remove debug spew.

First stab at degree of discrimination computation.
loncoursedata:
    Added $weight_table, &populate_weight_table,
    &rank_students_by_scores_on_resources, &get_sum_of_scores, and
    &limit_by_section_and_status
lonproblemstatistics:
    Added degree of discrimination to @Fields,
    &compute_discrimination_factor, and modified &get_statistics to call
    the latter.

loncoursedata: &get_problem_statistics now supports limiting statistics
    by time.
lonproblemstatistics: Now supports limiting statistics by time.
    Made text of output options more concise to save real estate.

No longer translate before calling lonhtmlcommon::breadcrumbs
and lonhtmlcommong::add_breadcrumb.

Translate text passed in to &Apache::lonhtmlcommon::breadcrumbs and
&Apache::lonhtmlcommon::add_breadcrumb.

Modified to use &Apache::htmlcommon breadcrumb routines.

Further changes reflecting new MySQL table structure.

Added \@Labels to DrawBarGraph inputs (labels on the x-axis).

Added help link to Statistics_Overall_Key.tex.

Bug 2371 is fixed!

Use Apache::loncommon::clean_excel_name() to avoid crashes on course names
with illegal characters in them.

Use the new &Apache::loncommon::store_course_settings and
restore_course_settings subroutines to remember form settings.
lonstatistics.pm was changed to not parse the student enrollment status
form elements before calling the sub-module routines which present the
interface.  Now each of the sub-modules (statistics/*) must call
&Apache::lonstatistics::PrepareClasslist(); at the right time.

- backport 1.58

Update to use &Apache::loncommon::DrawBarGraph().
Removed DrawGraph routine.

Localization of lonproblemstatistics.pm.

Fix bug 2126.

Moved CreateAndParseOutputSelector from lonproblemstatistics to
lonstatistics as I intend to use it elsewhere in the statistics universe.

Moving &Gather_Student_data to lonstatistics as it will be needed by
lonclassifystudent.pm.

Bug 1663 - brief explainatory notes about the statistics fields are now
included in Excel output.  Ought to go in to 1.0.

Interface changes - get rid of drop down box of reports.  Move
'Clear Caches' button to below chart/stat selection boxes.

Bug 1611 - links to problems on stats page now work.

Interface cleanups - 'Update Display' is no more.
"Generate Statistics" and "Generate Chart" buttons now appear below the
selection dialogs, obviating the need for explainatory verbage.
Added a brief instructional messages to the classlist display.
Cleaned up the output of just a table in the single student mode.

Change table headings to match the rest of the interface.

lonstatistics.pm:  Now checks the status of the student before loading them
   in to the @Students array.  The student status selection box is no longer
   a part of the main statistics interface (top line of the display).
lonproblemstatistics.pm and lonstudentassessment.pm have been modified to
   include the student status selector in their interface.

Modified to accept a hash ref from loncoursedata::get_problem_statistics.
Fields output is now configured in one place instead of 3.  The @Fields array
holds the description of each field, its format, and much more.
Removed the output options 'Degree of Difficulty Plot' and 'Percent Wrong
Plot' (see below).
Plots are now available from the 'ungrouped statistics' page.
&statistics_html_table_data now loops through @Fields to determine its behavior.
Added &statistics_table_header to output the proper fields and links for the
HTML statistics tables.
&get_statistics (the wrapper for loncoursedata::get_problem_statistics) now
requires the sequence, resource, part, and problem number as inputs in order
to add extra data to the returned hash reference.

Implemented wrapper for &Apache::loncoursedata::get_problem_statistics to
deal with the situation where 'any' section is selected for statistics
generation.

Added beginnings of POD.
Added prompt for the user to hit 'update display' on the first run.
Removed problem part supression from html grouped by sequence display
   because it just did not work right.
Added default output mode choice.
'Mod' is now displayed as an integer (which it is) instead of %5.2f.

Fix bug - graph.png does not plot values of 'nan' very well, so pass 0 instead.

Added graph output.
Added problem number accounting to &output_html* subroutines.
Added parameter $option to &output_html_ungrouped to deal with the display
      of problem numbers.
Removed &stats_row_from_hash because it was dumb.
Modified &statistics_html_table_data to take an $options string instead
      of a flag.
Removed &BuildGraphicChart, &CreateProblemStatisticsTableHeading
      &BuildStatisticsTable, &TableRow, &setbgcolor, and
      &ProblemStatisticsButtons.
Added &plot_statistics
Rewrote &DrawGraph entirely.  Requires version 1.21 of graph.png.

&output_excel which writes the data to an Excel file.

Changes to prevent the display of the problem part when all the problems
ONLY have a part 0.
Reworked the logic on sorting in &output_html_ungrouped.

Implemented sorting of statistics.  Still more to do but it works well.

Removed GDBM_File dependence.
Removed &InitializeProblemStatistics, &ExtractStudentData, &SortDivideByTries,
&SortProblems, and &CalculateStatistics.

Added: &CreateInterface and shamelessly ripped off &OutputDescriptions and
&CreateAndParseOutputSelect from lonstudentassessment.pm.
Added &Gather_Student_Data to ensure the student data is up to date.

Rewrote &BuildProblemStatisticsPage to call &CreateInterface,
&Gather_Student_Data, and the proper output functions.

Added &output_html_grouped_by_sequence
Added &output_html_ungrouped which is not fully implemented at this time.

lonstatistics.pm:
   POD cleanups
   @SelectedSections is set when we read the classlist.
   Added variables $top_map, @Sequences, and @Assessments.  These are
      initialized by &PrepareCourseData($r).
   Added &PrepareCourseData($r) which is essentially a wrapper for
      &Apache::loncoursedata::get_sequence_assessment_data().
   Added &MapSelect() to output a <select> box for sequences.  Not tested.
   Added &SectionSelect(..) to output a <select> box for sections.  Tested.
   Added &DisplayClasslist($r) which displays a table of the current classlist
      that is sortable by each column.  Does not bother with 'update time' as
      this should not be an issue for the user.  Tested.
   Added call to &PrepareCourseData by the handler.
lonpercentage.pm, lonproblemanalysis.pm, lonproblemstatistics.pm,
lonstudentassessment.pm: modified to call &Apache::lonstatistics::SectionSelect
   instead of the method in lonhtmlcommon.pm.

- using png now

- Fixes  BUG#1033 was getting 'Unable to tie database.2' on stats screens

cleaning the code

Fixed a bug in computing the Max value in Wrong percentage of problems.
(I think it relates to bug 899)

CV: ----------------------------------------------------------------------

fixed bug #899
sepate the degree of difficulty and %worong garph in relation to every homework set

Worked on build chart graph to fix bug #899
It needs more work.

Bug #802 is fixed.

Was still writing to the non-nohist version of resevaldata

Fixed an error for map selection in problem statistics.  Added a new
module that will display a graph of percentage correctness for
a problem or series of problems based on input.  It doesn't quite
look correct yet, because of graph.gif.  I will have to edit graph.gif
in order to get ranges for the x axis etc.  This was also an
experiment to see multiple dependent selections.  Will probably do
that with student assessment next, but with students.

Had a duplicate my declaration of a variable.

Added the storing of certain pieces of data from the statistics table
into metadata back into the code.

Fixed the number not updating in the status window for update all students
button.  Also fixed some tieing to hash problems for lonproblemstatistics
and lonproblemanalysis.

Fixed a problem with statistics calculations, acts funny when testing near
zero.  Fixed sequence displays for problem statistics so that the sequences
are in the proper order.  Same with problem analysis.  Also removed
discussion column from statistics.

Now problem statistics will display its problems in tables based on its
sequence with a sequence title.  It can also display the problems all
together, based on the new button Sort All Problems/Sort Within Sequence.
This button also allows the user to sort within the sequence or sort
all the problems as one group.

The second thing is that now problem statistics uses an initialization
function as does the chart from its page.  This allows the data
to be updated (like a change in status) to be seen while still in chart
mode instead of having to go back to problem statistics main page to
get the statistics data updated.

Added section selection to problem statistics and problem analysis.
Fixed some divide by zeros in lonproblemstatistics.
Broke up the table of option response problems and gave them the
heading of the sequence in which they lie.

Discriminant factors now work again.

Fixed the map selection to use the new cached data.  Basically moved the
map selection from the extraction to the printing.

Now the degree of difficulty and percent wrong graphs work correctly.  There
data is based off of the cached statistical data.

Added cached data for problem statistics.  Now it will store the data
it calculates for the statistics formulas and other constant data.
Currently, it doesn't know if a student's course data has been updated.

Added ability to hide and show the legend on the problem statistics
report using a button.

First, added unescaping of $key in lond dump command.
Next, I added a new way to download student course data.  There are now
two functions for storing data, DownloadStudentCourseData and
DownloadStudentCourseDataSeparate.  These two functions base their running
on input parameters.  The option parameters are whether or not to check
the date for downloading, whether or not to store all the dumped data or
extract out the data you want, whether or not to display a status window.
The extracting data parameter will be best utilized if someone adds in the
ability to send a list of what parameters are desired and perhaps some simple
commands to affect how that data is processed, like tries, sum would
sum record the sum of all the tries for a student.  This is just an idea.

Currently, I have all the statistics modules using the extract ability.
This slightly increases in download time, but drastically reduces cache
size.  Possible ideas include pushing the extract to the lond side with a
list of parameter/commands, or even downloading everything to a temp cache,
then extract the necessary data into the cache then removing the temp
cache.  There are lots of other possibilities, which can change the download
time, cache size, and other factors.  Now, only loncoursedata handles the
downloading of data to a hash.

lonstudentassessment was changed slightly to remove ' ' as a link if the
student actually hadn't attempted the problem.

lonproblemanalysis was updated for the new str2hash type functions.  There
are a couple of (cludges/fixes) for it.  Depending on whether or not the
str2hash type functions are changed, these may or may not need to be
updated.

lonproblemstatistics was drastically overhauled.  Most of the processing
was removed.  Now, it just does its few statistics functions and outputs
the table.  Currently, I broke the graph, discussion column, and
discriminant factor columns.  These will be fixed on the next commit soon.
There is also no caching done.  This will also be remedied soon.  The
problem that will need attention with caching is to know when to update
the statistics cached data when a student's course data is updated.

Lastly, I plan to add perhaps a toggle legend display button, another graph
button(percentage correct), a button to send the CSV format(not just display),
and add a toggle button for sorting within a sequence and sorting all
the problems.

Also, I changed the look and feel to be the same as the class list page.
Also, the displaying of sequence headers and child sequences are not
working.  This will be fixed, but thought will be put into how best to
make it look and have a similiar fill for all the table combinations.

- i think the last of bug#574

- fixes bug#257, moved resevaldata.db to nohist_resevaldata.db, and deletes hist file

- After installing these diffs you need to do a make install before restarting the webserver

Loading the graphical chart completed

Fixed a bug in sorting the statistics table

Sorting the statistics table works properly

Added in some flushes and changed where some of the modules print.  Also,
fixed download all so that if you stop it, and then select something
else it won't continue to download.

Edited the Statistics table to resort the table. (It needs more work)

started to fix sorting the table. It needs more work.

Updated some of the cache data keys being used.

First, added the parenthesis thing to the GDBM stuff.  Fixed the interface
problem statistics so that the buttons work correctly.  How the data
is interpretted is not finished.

Fixed a bug in making a link to a problem resource in statististics table.

Fixed some important bugs in calculating and displaying the discrimination factor

Found a bug in loading discrimination factor.
It needs more work to fix.

Many changes made to load statistics table in new method that applied in chart and statistics perl modules.

Distinguished between problem statistics module and activity log perl module

removed all global variables
Started to work with stats table in new method of caching the student data
PS:(It needs more work)

Removing global variables

Broke lonstatistics up.  Now the bulk of the code that generate the
html pages for the different forms have there own module.  Some minor
modifications were necessary to accomplish this.

Also added default student selected on student assessment page is now
all students.  The full name links on the classlist page now take
you to the student assessment page with that student selected.  I
had forgotten to put the post data in the get_unprocessed_cgi
function call.