--- loncom/interface/statistics/lonstathelpers.pm 2012/06/21 13:46:10 1.70 +++ loncom/interface/statistics/lonstathelpers.pm 2015/06/09 21:23:02 1.74 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonstathelpers.pm,v 1.70 2012/06/21 13:46:10 goltermann Exp $ +# $Id: lonstathelpers.pm,v 1.74 2015/06/09 21:23:02 damieng Exp $ # # Copyright Michigan State University Board of Trustees # @@ -143,7 +143,7 @@ sub problem_selector { my $Str; my $jsadd=''; if ($onclick) { - $jsadd="onClick='$onclick'"; + $jsadd="onclick='$onclick'"; } $Str = &Apache::loncommon::start_scrollbox(($smallbox?'420px':'620px'), ($smallbox?'400px':'600px'), @@ -286,7 +286,8 @@ END END if (ref($anoncounter) eq 'HASH') { if (keys(%{$anoncounter}) > 0) { - my $anonwarning = &mt('Your selection includes both problems with and without anonymous submissions.').'\n'.&mt('You must select either only anonymous or only named problems.').'\n\n'.&mt('If a selection contains both anonymous and named parts, [_1]use the Anoymous/Named buttons to ensure selections will be either all anonymous [_1]or all named.','\n'); + my $anonwarning = &mt('Your selection includes both problems with and without anonymous submissions.')."\n".&mt('You must select either only anonymous or only named problems.')."\n\n".&mt('If a selection contains both anonymous and named parts,[_1]use the Anonymous/Named buttons to ensure selections will be either all anonymous[_1]or all named.',"\n"); + &js_escape(\$anonwarning); $checkanonjs = <<"END"; <script type="text/javascript" language="JavaScript"> @@ -1385,9 +1386,9 @@ sub limit_by_time_form { $Str .= '<fieldset>'; my $timecheckbox = '<input type="checkbox" name="limit_by_time" '; if (&limit_by_time()) { - $timecheckbox .= ' checked '; + $timecheckbox .= 'checked="checked" '; } - $timecheckbox .= 'OnChange="javascript:toggle_limitby_activity(this.checked);" '; + $timecheckbox .= 'onchange="javascript:toggle_limitby_activity(this.checked);" '; $timecheckbox .= ' />'; $Str .= '<legend><label>'.&mt('[_1] Limit by time',$timecheckbox).'</label></legend>'; $Str .= &mt('Start Time: [_1]',$startdateform).'<br />';