--- loncom/interface/statistics/lonstudentassessment.pm 2003/02/28 21:19:00 1.30 +++ loncom/interface/statistics/lonstudentassessment.pm 2003/03/06 21:12:54 1.36 @@ -1,6 +1,6 @@ # The LearningOnline Network with CAPA # -# $Id: lonstudentassessment.pm,v 1.30 2003/02/28 21:19:00 matthew Exp $ +# $Id: lonstudentassessment.pm,v 1.36 2003/03/06 21:12:54 matthew Exp $ # # Copyright Michigan State University Board of Trustees # @@ -54,7 +54,23 @@ use Apache::lonstatistics; use Apache::lonhtmlcommon; use Apache::loncoursedata; use Apache::lonnet; # for logging porpoises -use GDBM_File; +use Spreadsheet::WriteExcel; + +####################################################### +####################################################### +=pod + +=item Package Variables + +=over 4 + +=item $Statistics Hash ref to store student data. Indexed by symb, + contains hashes with keys 'score' and 'max'. + +=cut + +####################################################### +####################################################### my $Statistics; @@ -63,27 +79,40 @@ my $Statistics; =pod -=item &BuildStudentAssessmentPage() +=item $show_links 'yes' or 'no' for linking to student performance data -Inputs: +=item $output_mode 'html', 'excel', or 'csv' for output mode -=over 4 +=item $show 'all', 'totals', or 'scores' determines how much data is output + +=cut -=item $cacheDB The name of the cache file used to store student data +####################################################### +####################################################### +my $show_links; +my $output_mode; +my $show; -=item $students Array ref containing the name(s) of the students -selected for display +####################################################### +####################################################### +# End of package variable declarations -=item $courseID The ID of the course +=pod -=item $formName The name of the html form - 'Statistics' +=back -=item $headings Array ref of headings to show +=cut -=item $spacing A string of spaces +####################################################### +####################################################### + +=pod + +=item &BuildStudentAssessmentPage() + +Inputs: -=item $studentInformation Array ref of possible headings for student info -('fullname','section',...) +=over 4 =item $r Apache Request @@ -98,36 +127,93 @@ selected for display sub BuildStudentAssessmentPage { my ($r,$c)=@_; undef($Statistics); - # + # Print out the HTML headers for the interface + # This also parses the output mode selector + # This step must always be done. $r->print(&CreateInterface()); + $r->print(''); $r->rflush(); + if (! exists($ENV{'form.notfirstrun'})) { + $r->print(< + +Please make your selections in the boxes above and hit +the button marked "Update Display". + +

+ENDMSG +# $r->print(&OutputDescriptions()); + return; + } + # + # + my $initialize = \&html_initialize; + my $output_student = \&html_outputstudent; + my $finish = \&html_finish; + # + if ($output_mode eq 'excel') { + $initialize = \&excel_initialize; + $output_student = \&excel_outputstudent; + $finish = \&excel_finish; + } elsif ($output_mode eq 'multi-sheet excel') { + $initialize = \&multi_sheet_excel_initialize; + $output_student = \&multi_sheet_excel_outputstudent; + $finish = \&multi_sheet_excel_finish; + } elsif ($output_mode eq 'csv') { + $initialize = \&csv_initialize; + $output_student = \&csv_outputstudent; + $finish = \&csv_finish; + } # - $r->print(&CreateTableHeadings()); if($c->aborted()) { return ; } - - my $Count = 0; - $r->print('
'."\n");
+    #
+    # Call the initialize routine selected above
+    $initialize->($r);
     foreach my $student (@Apache::lonstatistics::Students) {
-        if($c->aborted()) { return ; }
-        $r->print(&ChartOutputStudent($student));
-        # output it
-
-        $Count++;
-        if($Count % 5 == 0) {
-            $r->print("
\n
");
+        if($c->aborted()) { 
+            $finish->($r);
+            return ; 
         }
-
-        $r->rflush();
+        # Call the output_student routine selected above
+        $output_student->($r,$student);
     }
-    $r->print('
'."\n"); - my $Str; + # Call the "finish" routine selected above + $finish->($r); + # return; } ####################################################### ####################################################### +sub get_student_fields_to_show { + my @to_show = @Apache::lonstatistics::SelectedStudentData; + foreach (@to_show) { + if ($_ eq 'all') { + @to_show = @Apache::lonstatistics::StudentDataOrder; + last; + } + } + return @to_show; +} + +sub get_sequences_to_show { + my @Sequences; + foreach my $map_symb (@Apache::lonstatistics::SelectedMaps) { + foreach my $sequence (@Apache::lonstatistics::Sequences) { + next if ($sequence->{'symb'} ne $map_symb && $map_symb ne 'all'); + next if ($sequence->{'num_assess'} < 1); + push (@Sequences,$sequence); + } + } + return @Sequences; +} + + +####################################################### +####################################################### + =pod =item &CreateInterface() @@ -151,7 +237,8 @@ sub CreateInterface { $Str .= ''; $Str .= 'Sections'; $Str .= 'Student Data'; - $Str .= 'Sequences and Folders'; + $Str .= 'Problem Sets'; + $Str .= 'Output Format'; $Str .= ''."\n"; # $Str .= ''."\n"; @@ -170,78 +257,204 @@ sub CreateInterface { $Str .= ''."\n"; $Str .= &Apache::lonstatistics::MapSelect('Maps','multiple,all',5, $only_seq_with_assessments); + $Str .= ''."\n"; + $Str .= &CreateAndParseOutputSelector(); $Str .= ''."\n"; $Str .= ''."\n"; return $Str; } - ####################################################### ####################################################### =pod -=item Table Output Routines - -=over 4 +=item &CreateAndParseOutputSelector() =cut ####################################################### ####################################################### -{ - my $padding; +my @OutputOptions = + ({ name => 'HTML, with links', + value => 'html, with links', + description => 'Output HTML with each symbol linked to the problem '. + 'which generated it.', + mode => 'html', + show => 'all', + show_links => 'yes', + }, + { name => 'HTML, without links', + value => 'html, without links', + description => 'Output HTML. By not including links, the size of the'. + ' web page is greatly reduced. If your browser crashes on the '. + 'full display, try this.', + mode => 'html', + show => 'all', + show_links => 'no', + }, + { name => 'HTML, scores only', + value => 'html, scores only', + description => 'Output HTML, only showing the total number of correct'. + ' problems (or problem parts) and not the maximum possible for '. + 'each student', + mode => 'html', + show => 'scores', + show_links => 'no', + }, + { name => 'HTML, totals', + value => 'html, totals', + description => 'Output HTML, but only the summary statistics for each'. + ' sequence selected.', + mode => 'html', + show => 'totals', + show_links => 'no', + }, + { name => 'Excel, scores only', + value => 'excel, scores only', + description => 'Output an Excel file (compatable with Excel 95), '. + 'with a single column for each sequence showing the students '. + 'score.', + mode => 'excel', + show => 'scores', + show_links => 'no', + }, + { name => 'Excel, totals', + value => 'excel, totals', + description => 'Output an Excel file (compatable with Excel 95), '. + 'with two columns for each sequence, the students score on the '. + 'sequence and the students maximum possible on the sequence', + mode => 'excel', + show => 'totals', + show_links => 'no', + }, + { name => 'multi-sheet Excel', + value => 'multi-sheet excel', + description => 'Output an Excel file (compatable with Excel 95), '. + 'with a seperate worksheet for each sequence you have selected '. + 'the data for each problem part '. + '(number of tries, status, points awarded) will be listed.', + mode => 'multi-sheet excel', + show => 'totals', + show_links => 'no', + }, + { name => 'multi-sheet Excel, by section', + value => 'multi-sheet excel, by section', + description => 'Output an Excel file (compatable with Excel 95), '. + 'with a seperate worksheet for each sequence you have selected '. + 'the data for each problem part '. + '(number of tries, status, points awarded) will be listed. '. + 'There will be one Excel workbook for each section selected.', + mode => 'multi-sheet excel', + show => 'by section', + show_links => 'no', + }, + { name => 'CSV, everything', + value => 'csv, everything', + description => '', + mode => 'csv', + show => 'all', + show_links => 'no', + }, + { name => 'CSV, scores only', + value => 'csv, scores only', + description => '', + mode => 'csv', + show => 'scores', + show_links => 'no', + }, + { name => 'CSV, totals', + value => 'csv, totals', + description => '', + mode => 'csv', + show => 'totals', + show_links => 'no', + }, + ); -####################################################### -####################################################### - -=pod - -=item &CreateTableHeadings() - -Create HTML for the columns of student data to show. -Called by &BuildStudentAssessmentPage(). Calls -&Apache::lonhtmlcommon::CreateHeadings(). +sub OutputDescriptions { + my $Str = ''; + $Str .= "

Output Modes

\n"; + $Str .= "
\n"; + foreach my $outputmode (@OutputOptions) { + $Str .="
".$outputmode->{'name'}."
\n"; + $Str .="
".$outputmode->{'description'}."
\n"; + } + $Str .= "
\n"; + return $Str; +} -Inputs: +sub CreateAndParseOutputSelector { + my $Str = ''; + my $elementname = 'outputmode'; + # + # Format for output options is 'mode, restrictions'; + my $selected = 'html, with links'; + if (exists($ENV{'form.'.$elementname})) { + if (ref($ENV{'form.'.$elementname} eq 'ARRAY')) { + $selected = $ENV{'form.'.$elementname}->[0]; + } else { + $selected = $ENV{'form.'.$elementname}; + } + } + # + # Set package variables describing output mode + $show_links = 'no'; + $output_mode = 'html'; + $show = 'all'; + foreach my $option (@OutputOptions) { + next if ($option->{'value'} ne $selected); + $output_mode = $option->{'mode'}; + $show = $option->{'show'}; + $show_links = $option->{'show_links'}; + } -=over 4 + # + # Build the form element + $Str = qq/"; + return $Str; +} -=item $cache The ubiquitous cache +####################################################### +####################################################### -=item $spacing A string of spaces +=pod -=item $infoKeys Array ref to names of keys to display from the cache -which describe students +=head2 HTML output routines -=item $infoHeadings Array ref to headings of columns for student info +=item &html_initialize($r) -=item $sequenceKeys Array ref of names of keys to use to retrieve sequence -data from the cache +Create labels for the columns of student data to show. -=item $sequenceHeadings Array ref of names of sequences used for output. +=item &html_outputstudent($r,$student) -=back +Return a line of the chart for a student. -Returns: A string containing the HTML of the table headings. +=item &html_finish($r) =cut ####################################################### ####################################################### -sub CreateTableHeadings { +{ + my $padding; + my $count; + +sub html_initialize { + my ($r) = @_; # $padding = ' 'x3; + $count = 0; # - my $Str = '
';
+    my $Str = "
\n";
     # First, the @StudentData fields need to be listed
-    my @to_show = @Apache::lonstatistics::SelectedStudentData;
-    foreach (@to_show) {
-        if ($_ eq 'all') {
-            @to_show = @Apache::lonstatistics::StudentDataOrder;
-            last;
-        }
-    }
+    my @to_show = &get_student_fields_to_show();
     foreach my $field (@to_show) {
         my $title=$Apache::lonstatistics::StudentData{$field}->{'title'};
         my $base =$Apache::lonstatistics::StudentData{$field}->{'base_width'};
@@ -249,48 +462,31 @@ sub CreateTableHeadings {
         $Str .= $title.' 'x($width-$base).$padding;
     }
     # Now the selected sequences need to be listed
-    foreach my $map_symb (@Apache::lonstatistics::SelectedMaps) {
-        foreach my $sequence (@Apache::lonstatistics::Sequences) {
-            next if ($sequence->{'symb'} ne $map_symb && $map_symb ne 'all');
-            next if ($sequence->{'num_assess'} < 1);
-            my $title = $sequence->{'title'};
-            my $base  = $sequence->{'base_width'};
-            my $width = $sequence->{'width'};
-            $Str .= $title.' 'x($width-$base).$padding;
-        }
+    foreach my $sequence (&get_sequences_to_show) {
+        my $title = $sequence->{'title'};
+        my $base  = $sequence->{'base_width'};
+        my $width = $sequence->{'width'};
+        $Str .= $title.' 'x($width-$base).$padding;
     }
-    $Str .= 'total';
-    $Str .= "
\n";
-    return $Str;
+    $Str .= "total (of shown problems)
\n"; + $Str .= "
";
+    $r->print($Str);
+    $r->rflush();
+    return;
 }
 
-#######################################################
-#######################################################
-
-=pod
-
-=item &ChartOutputStudent($student)
-
-Return a line of the chart for a student.
-
-=cut
-
-#######################################################
-#######################################################
-sub ChartOutputStudent {
-    my $student = shift;
+sub html_outputstudent {
+    my ($r,$student) = @_;
     my $Str = '';
-    # First, the @StudentData fields need to be listed
-    my @to_show = @Apache::lonstatistics::SelectedStudentData;
-    foreach (@to_show) {
-        if ($_ eq 'all') {
-            @to_show = @Apache::lonstatistics::StudentDataOrder;
-            last;
-        }
+    #
+    if($count++ % 5 == 0 && $count > 0) {
+        $r->print("
");
     }
+    # First, the @StudentData fields need to be listed
+    my @to_show = &get_student_fields_to_show();
     foreach my $field (@to_show) {
         my $title=$student->{$field};
-        my $base =scalar(my @Tmp = split(//,$title));
+        my $base = length($title);
         my $width=$Apache::lonstatistics::StudentData{$field}->{'width'};
         $Str .= $title.' 'x($width-$base).$padding;
     }
@@ -304,22 +500,37 @@ sub ChartOutputStudent {
     }
     if (scalar(@tmp) < 1) {
         $Str .= 'No Course Data'."\n";
-        return $Str;
+        $r->print($Str);
+        $r->rflush();
+        return;
     }
     #
     # By sequence build up the data
     my $studentstats;
-    foreach my $map_symb (@Apache::lonstatistics::SelectedMaps) {
-        foreach my $seq (@Apache::lonstatistics::Sequences) {
-            next if ($map_symb ne $seq->{'symb'} && $map_symb ne 'all');
-            next if ($seq->{'num_assess'} < 1);
-            my ($performance,$score,$seq_max) =
-                &StudentPerformanceOnSequence($student,\%StudentsData,
-                                              $seq,'linkify');
-            $Str .= $performance.$padding;
-            $studentstats->{$seq->{'symb'}}->{'score'}= $score;
-            $studentstats->{$seq->{'symb'}}->{'max'}  = $seq_max;
+    my $PerformanceStr = '';
+    foreach my $seq (&get_sequences_to_show) {
+        my ($performance,$score,$seq_max) =
+            &StudentPerformanceOnSequence($student,\%StudentsData,
+                                          $seq,$show_links);
+        my $ratio = $score.'/'.$seq_max;
+        #
+        if ($show eq 'totals') {
+            $performance = ' 'x(length($seq_max)-length($score)).$ratio;
+            $performance .= ' 'x($seq->{'width'}-length($performance));
+        } elsif ($show eq 'scores') {
+            $performance = $score;
+            $performance .= ' 'x($seq->{'width'}-length($performance));
+        } else {
+            # Pad with extra spaces
+            $performance .= ' 'x($seq->{'width'}-$seq_max-
+                                 length($ratio)
+                                 ).$ratio;
         }
+        #
+        $Str .= $performance.$padding;
+        #
+        $studentstats->{$seq->{'symb'}}->{'score'}= $score;
+        $studentstats->{$seq->{'symb'}}->{'max'}  = $seq_max;
     }
     #
     # Total it up and store the statistics info.
@@ -330,24 +541,329 @@ sub ChartOutputStudent {
         $score += $seq_stats->{'score'};
         $max   += $seq_stats->{'max'};
     }
-    my $scorelength = scalar(my @tmp1 = split(//,$score));
-    my $maxlength   = scalar(my @tmp2 = split(//,$max));
-    $Str .= ' '.' 'x($maxlength-$scorelength).$score.'/'.$max;
+    $Str .= ' '.' 'x(length($max)-length($score)).$score.'/'.$max;
     $Str .= " \n";
-    return $Str;
+    $r->print($Str);
+    #
+    $r->rflush();
+    return;
 }    
 
+sub html_finish {
+    my ($r) = @_;
+    $r->print("
\n"); + $r->rflush(); + return; +} + +} + ####################################################### ####################################################### =pod -=back +=head2 Multi-Sheet EXCEL subroutines + +=item &multi_sheet_excel_initialize($r) + +=item &multi_sheet_excel_outputstudent($r,$student) + +=item &multi_sheet_excel_finish($r) =cut ####################################################### ####################################################### +{ + +sub multi_sheet_excel_initialize { + my ($r)=@_; + $r->print("

Not yet implemented

"); + # + # Estimate the size of the file. We would like to have < 5 megs of data. + my $max_size = 5000000; + my $num_students = scalar(@Apache::lonstatistics::Students); + my $num_sequences = 0; + my $num_data_per_part = 2; # 'status' and 'numtries' + my $fields_per_student = scalar(&get_student_fields_to_show()); + my $bytes_per_field = 20; # Back of the envelope calculation + foreach my $seq (&get_sequences_to_show) { + $num_sequences++ if ($seq->{'num_assess'} > 0); + $fields_per_student += $num_data_per_part * $seq->{'num_assess_parts'}; + } + my $size_estimate = $fields_per_student*$num_students*$bytes_per_field; + # + # Compute number of workbooks + my $num_workbooks = 1; + if ($size_estimate > $max_size) { # try to stay under 5 megs + $num_workbooks += int($size_estimate / $max_size); + } + if ($show eq 'by section') { + if (@Apache::lonstatistics::SelectedSections > 1 && + $Apache::lonstatistics::SelectedSections[0] ne 'all') { + $num_workbooks = scalar(@Apache::lonstatistics::SelectedSections); + } else { + # @Apache::lonstatistics::Sections contains 'all' as well. + $num_workbooks = scalar(@Apache::lonstatistics::Sections) - 1; + } + } + + $r->print("Maximum allowed size: ".$max_size." bytes
"); + $r->print("Number of students: ".$num_students."
"); + $r->print("Number of fields per student: ".$fields_per_student."
"); + $r->print("Total number of fields: ".($fields_per_student*$num_students). + "
"); + $r->print("Bytes per field: ".$bytes_per_field." (estimated)"."
"); + $r->print("Estimated size: ".$size_estimate." bytes
"); + $r->print("Number of workbooks: ".$num_workbooks."
"); + $r->rflush(); + return; +} + +sub multi_sheet_excel_outputstudent { + my ($r,$student) = @_; +} + +sub multi_sheet_excel_finish { + my ($r) = @_; +} + +} +####################################################### +####################################################### + +=pod + +=head2 EXCEL subroutines + +=item &excel_initialize($r) + +=item &excel_outputstudent($r,$student) + +=item &excel_finish($r) + +=cut + +####################################################### +####################################################### +{ + +my $excel_sheet; +my $excel_workbook; + +my $filename; +my $rows_output; +my $cols_output; + +my %prog_state; # progress window state + +sub excel_initialize { + my ($r) = @_; + # + $filename = '/prtspool/'. + $ENV{'user.name'}.'_'.$ENV{'user.domain'}.'_'. + time.'_'.rand(1000000000).'.xls'; + # + $excel_workbook = undef; + $excel_sheet = undef; + # + $rows_output = 0; + $cols_output = 0; + # + # Create sheet + $excel_workbook = Spreadsheet::WriteExcel->new('/home/httpd'.$filename); + # + # Check for errors + if (! defined($excel_workbook)) { + $r->log_error("Error creating excel spreadsheet $filename: $!"); + $r->print("Problems creating new Excel file. ". + "This error has been logged. ". + "Please alert your LON-CAPA administrator"); + return ; + } + # + # The excel spreadsheet stores temporary data in files, then put them + # together. If needed we should be able to disable this (memory only). + # The temporary directory must be specified before calling 'addworksheet'. + # File::Temp is used to determine the temporary directory. + $excel_workbook->set_tempdir($Apache::lonnet::tmpdir); + # + # Add a worksheet + my $sheetname = $ENV{'course.'.$ENV{'request.course.id'}.'.description'}; + if (length($sheetname) > 31) { + $sheetname = substr($sheetname,0,31); + } + $excel_sheet = $excel_workbook->addworksheet($sheetname); + # + # Put the course description in the header + $excel_sheet->write($rows_output,$cols_output++, + $ENV{'course.'.$ENV{'request.course.id'}.'.description'}); + $cols_output += 3; + # + # Put a description of the sections listed + my $sectionstring = ''; + my @Sections = @Apache::lonstatistics::SelectedSections; + if (scalar(@Sections) > 1) { + if (scalar(@Sections) > 2) { + my $last = pop(@Sections); + $sectionstring = "Sections ".join(', ',@Sections).', and '.$last; + } else { + $sectionstring = "Sections ".join(' and ',@Sections); + } + } else { + if ($Sections[0] eq 'all') { + $sectionstring = "All sections"; + } else { + $sectionstring = "Section ".$Sections[0]; + } + } + $excel_sheet->write($rows_output,$cols_output++,$sectionstring); + $cols_output += scalar(@Sections); + # + # Put the date in there too + $excel_sheet->write($rows_output,$cols_output++, + 'Compiled on '.localtime(time)); + # + $rows_output++; + # + # Add the student headers + $cols_output = 0; + foreach my $field (&get_student_fields_to_show()) { + $excel_sheet->write($rows_output,$cols_output++,$field); + } + # + # Add the Sequence Headers + foreach my $seq (&get_sequences_to_show) { + $excel_sheet->write($rows_output,$cols_output,$seq->{'title'}); + if ($show eq 'totals') { + $excel_sheet->write($rows_output+1,$cols_output,'score'); + $excel_sheet->write($rows_output+1,$cols_output+1,'maximum'); + $cols_output += 2; + } else { + $cols_output++; + } + } + # + # Bookkeeping + if ($show eq 'totals') { + $rows_output += 2; + } else { + $rows_output += 1; + } + # + # Let the user know what we are doing + my $studentcount = scalar(@Apache::lonstatistics::Students); + $r->print("

Compiling Excel spreadsheet for ". + $studentcount.' student'); + $r->print('s') if ($studentcount > 1); + $r->print("

\n"); + $r->rflush(); + # + # Initialize progress window + %prog_state=&Apache::lonhtmlcommon::Create_PrgWin + ($r,'Excel File Compilation Status', + 'Excel File Compilation Progress', $studentcount); + # + return; +} + +sub excel_outputstudent { + my ($r,$student) = @_; + return if (! defined($excel_sheet)); + $cols_output=0; + # + # Write out student data + my @to_show = &get_student_fields_to_show(); + foreach my $field (@to_show) { + $excel_sheet->write($rows_output,$cols_output++,$student->{$field}); + } + # + # Get student assessment data + my %StudentsData; + my @tmp = &Apache::loncoursedata::get_current_state($student->{'username'}, + $student->{'domain'}, + undef, + $ENV{'request.course.id'}); + if ((scalar @tmp > 0) && ($tmp[0] !~ /^error:/)) { + %StudentsData = @tmp; + } + # + # Write out sequence scores and totals data + foreach my $seq (&get_sequences_to_show) { + my ($performance,$score,$seq_max) = + &StudentPerformanceOnSequence($student,\%StudentsData, + $seq,'no'); + if ($show eq 'totals' || $show eq 'scores') { + $excel_sheet->write($rows_output,$cols_output++,$score); + } + if ($show eq 'totals') { + $excel_sheet->write($rows_output,$cols_output++,$seq_max); + } + } + # + # Bookkeeping + $rows_output++; + $cols_output=0; + # + # Update the progress window + &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state,'last student'); + return; +} + +sub excel_finish { + my ($r) = @_; + return if (! defined($excel_sheet)); + # + # Write the excel file + $excel_workbook->close(); + my $c = $r->connection(); + # + return if($c->aborted()); + # + # Close the progress window + &Apache::lonhtmlcommon::Close_PrgWin($r,\%prog_state); + # + # Tell the user where to get their excel file + $r->print('
'. + 'Your Excel spreadsheet.'."\n"); + $r->rflush(); + return; +} + +} +####################################################### +####################################################### + +=pod + +=head2 CSV output routines + +=item &csv_initialize($r) + +=item &csv_outputstudent($r,$student) + +=item &csv_finish($r) + +=cut + +####################################################### +####################################################### +{ + +sub csv_initialize{ + my ($r) = @_; + $r->print("

Not implemented yet

"); + return; +} + +sub csv_outputstudent { + my ($r,$student) = @_; +} + +sub csv_finish { + my ($r) = @_; +} } @@ -378,8 +894,8 @@ Inputs: ####################################################### sub StudentPerformanceOnSequence { my ($student,$studentdata,$seq,$links) = @_; + $links = 'no' if (! defined($links)); my $Str = ''; - my $output_width = 0; my ($sum,$max) = (0,0); foreach my $resource (@{$seq->{'contents'}}) { next if ($resource->{'type'} ne 'assessment'); @@ -426,8 +942,7 @@ sub StudentPerformanceOnSequence { } } # - $output_width++; - if (defined($links) && $symbol ne ' ') { + if ($links eq 'yes' && $symbol ne ' ') { $symbol = '