--- loncom/interface/statistics/lonstudentassessment.pm	2010/12/04 14:41:13	1.163
+++ loncom/interface/statistics/lonstudentassessment.pm	2023/04/07 16:46:44	1.177
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonstudentassessment.pm,v 1.163 2010/12/04 14:41:13 www Exp $
+# $Id: lonstudentassessment.pm,v 1.177 2023/04/07 16:46:44 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -282,7 +282,7 @@ sub next_and_previous_buttons {
     # Build the 'all students' button
     my $all = '';
     $all .= '<input type="button" value="'.&mt('All Students').'" '.
-            '" onclick="document.Statistics.SelectedStudent.value='.
+            ' onclick="document.Statistics.SelectedStudent.value='.
             "''".';'.'document.Statistics.submit();" />';
     $Str .= $previousbutton.('&nbsp;'x5).$all.('&nbsp;'x5).$nextbutton;
     return $Str;
@@ -364,10 +364,6 @@ sub CreateInterface {
     $Str .= &CreateAndParseOutputDataSelector();
     $Str .= '</td></tr>'."\n";
     $Str .= '</table>'."\n";
-    $Str .= '<p>'
-           .&mt('Status:').' '
-           .'<input type="text" name="stats_status" size="60" value="" readonly="readonly" />'
-           .'</p>';
     $Str .= '<input type="submit" name="selectstudent" value="'.
         &mt('Select One Student').'" />';
     $Str .= '&nbsp;'x5;
@@ -434,7 +430,7 @@ my @OutputOptions =
 
 sub OutputDescriptions {
     my $Str = '';
-    $Str .= "<h2>Output Formats</h2>\n";
+    $Str .= '<h2>'.&mt('Output Formats')."</h2>\n";
     $Str .= "<dl>\n";
     foreach my $outputmode (@OutputOptions) {
 	$Str .="    <dt>".$outputmode->{'name'}."</dt>\n";
@@ -469,7 +465,7 @@ sub CreateAndParseOutputSelector {
     $Str = qq/<select size="5" name="$elementname">/;
     foreach my $option (@OutputOptions) {
         $Str .= "\n".'    <option value="'.$option->{'value'}.'"';
-        $Str .= " selected " if ($option->{'value'} eq $selected);
+        $Str .= ' selected="selected"' if ($option->{'value'} eq $selected);
         $Str .= ">".&mt($option->{'name'})."<\/option>";
     }
     $Str .= "\n</select>";
@@ -586,7 +582,7 @@ sub CreateAndParseOutputDataSelector {
     $Str = qq/<select size="5" name="$elementname">/;
     foreach my $option (@OutputDataOptions) {
         $Str .= "\n".'    <option value="'.$option->{'value'}.'"';
-        $Str .= " selected " if ($option->{'value'} eq $chosen_output->{'value'});
+        $Str .= ' selected="selected"' if ($option->{'value'} eq $chosen_output->{'value'});
         $Str .= ">".&mt($option->{'name'})."<\/option>";
     }
     $Str .= "\n</select>";
@@ -609,7 +605,7 @@ sub count_parts {
 sub get_resources {
     my ($navmap,$sequence) = @_;
     my @resources = $navmap->retrieveResources($sequence,
-                                               sub { shift->is_problem(); },
+                                               sub { shift->is_gradable(); },
                                                0,0,0);
     return @resources;
 }
@@ -748,11 +744,12 @@ NEW_WINDOW_CHECKBOX
                             length($title)
                             )).$padding;
     }
-    $total_sum_width = length($total_count)+1;
+    $total_sum_width = length($total_count);
+    if ($total_sum_width < 6) {
+        $total_sum_width = 6;
+    }
     $Str .= "    total</pre>\n";
     $Str .= "<pre>";
-    $r->print($Str);
-    $r->rflush();
 
     $r->print(<<JS);
 <script type="text/javascript">
@@ -813,13 +810,13 @@ JS
     }
     #
     # Initialize progress window
-    %prog_state=&Apache::lonhtmlcommon::Create_PrgWin
-        ($r,'HTML Chart Status',
-         'HTML Chart Progress', $studentcount,
-         'inline',undef,'Statistics','stats_status');
     #
+    %prog_state=&Apache::lonhtmlcommon::Create_PrgWin($r,$studentcount);
     &Apache::lonhtmlcommon::Update_PrgWin($r,\%prog_state,
                                           'Processing first student');
+    $r->print($Str);
+    $r->rflush();
+
     return;
 }
 
@@ -844,6 +841,7 @@ sub html_outputstudent {
         if ($field eq 'comments') {
             $title = '<a href="/adm/'.$student->{'domain'}.'/'.$student->{'username'}.'/'.'aboutme#coursecomment">'.&mt('Comments').'</a>';
         }
+        utf8::decode($title);
         my $base = length($title);
         my $width=$Apache::lonstatistics::StudentData{$field}->{'width'};
         $Str .= $title.' 'x($width-$base).$padding;
@@ -877,16 +875,18 @@ sub html_outputstudent {
     my $PerformanceStr = '';
     foreach my $seq (@sequences) {
         my $symb = $seq->symb;
+        my $randompick = $seq->randompick();
         my ($performance,$performance_length,$score,$seq_max,$rawdata);
         if ($chosen_output->{'tries'}) {
             ($performance,$performance_length,$score,$seq_max,$rawdata) =
                 &student_tries_on_sequence($student,\%StudentsData,
-                                           $navmap,$seq,$show_links);
+                                           $navmap,$seq,$show_links,$randompick);
         } else {
             ($performance,$performance_length,$score,$seq_max,$rawdata) =
                 &student_performance_on_sequence($student,\%StudentsData,
                                                  $navmap,$seq,$show_links,
-                                                 $chosen_output->{ignore_weight});
+                                                 $chosen_output->{ignore_weight},
+                                                 $randompick);
         }
         my $ratio='';
         if ($chosen_output->{'every_problem'} && 
@@ -941,6 +941,7 @@ sub html_outputstudent {
         $score = sprintf("%.2f",$score);
         $score = (' 'x(6-length($score))).$score;
     }
+    $max = sprintf("%.2f",$max);
     $Str .= ' '.' 'x($total_sum_width-length($score)).$score.' / '.$max;
     $Str .= " \n";
     #
@@ -1106,9 +1107,9 @@ sub excel_initialize {
         &Apache::lonstatistics::selected_sequences_with_assessments();
     if (! ref($navmap)) {
         # Unable to get data, so bail out
-        $r->print("<h3>".
+        $r->print('<p class="LC_error">'.
                   &mt('Unable to retrieve course information.').
-                  '</h3>');
+                  '</p>');
     }
     #
     my $total_columns = scalar(&get_student_fields_to_show());
@@ -1123,9 +1124,9 @@ sub excel_initialize {
     }
     my $too_many_cols_error_message = 
         '<h2>'.&mt('Unable to Complete Request').'</h2>'.$/.
-        '<p>'.&mt('LON-CAPA is unable to produce your Excel spreadsheet because your selections will result in more than 255 columns.  Excel allows only 255 columns in a spreadsheet.').'</p>'.$/.
-        '<p>'.&mt('You may consider reducing the number of <b>Sequences or Folders</b> you have selected.').'</p>'.$/.
-        '<p>'.&mt('LON-CAPA can produce <b>CSV</b> files of this data or Excel files of the <b>Scores Summary</b> data.').'</p>'.$/;
+        '<p class="LC_warning">'.&mt('LON-CAPA is unable to produce your Excel spreadsheet because your selections will result in more than 255 columns.  Excel allows only 255 columns in a spreadsheet.').'</p>'.$/.
+        '<p>'.&mt('You may consider reducing the number of [_1]Sequences or Folders[_2] you have selected.','<b>','</b>').'</p>'.$/.
+        '<p>'.&mt('LON-CAPA can produce [_1]CSV[_2] files of this data or Excel files of the [_1]Scores Summary[_2] data.','<b>','</b>').'</p>'.$/;
     if ($chosen_output->{'base'} eq 'tries' && $total_columns > 255) {
         $r->print($too_many_cols_error_message);
         $request_aborted = 1;
@@ -1182,7 +1183,7 @@ sub excel_initialize {
     my $sectionstring = '';
     my @Sections = &Apache::lonstatistics::get_selected_sections();
     $excel_sheet->write($header_row,$cols_output++,
-                        &Apache::lonstatistics::section_and_enrollment_description('plaintext'),
+                        &Apache::lonstatistics::section_and_enrollment_description('localized'),
                         $format->{'h3'});
     #
     # Put the date in there too
@@ -1206,7 +1207,7 @@ sub excel_initialize {
     # Add the student headers
     $cols_output = 0;
     foreach my $field (&get_student_fields_to_show()) {
-        $excel_sheet->write($resource_name_row,$cols_output++,$field,
+        $excel_sheet->write($resource_name_row,$cols_output++,&mt($field),
                             $format->{'bold'});
     }
     #
@@ -1455,10 +1456,7 @@ sub excel_initialize {
     $r->rflush();
     #
     # Initialize progress window
-    %prog_state=&Apache::lonhtmlcommon::Create_PrgWin
-        ($r,'Excel File Compilation Status',
-         'Excel File Compilation Progress', $studentcount,
-         'inline',undef,'Statistics','stats_status');
+    %prog_state=&Apache::lonhtmlcommon::Create_PrgWin($r,$studentcount);
     #
     &Apache::lonhtmlcommon::Update_PrgWin($r,\%prog_state,
                                           'Processing first student');
@@ -1498,6 +1496,7 @@ sub excel_outputstudent {
     my %maximum_cell_translation;
     foreach my $seq (@sequences) {
         my $symb = $seq->symb;
+        my $randompick = $seq->randompick();
         $cols_output = $formula_data{$symb}->{'Excel:startcol'};
         # Keep track of cells to translate in total cell
         $total_cell_translation{$formula_data{$symb}->{'Excel:scorecell'}} = 
@@ -1512,12 +1511,13 @@ sub excel_outputstudent {
         if ($chosen_output->{'tries'} || $chosen_output->{'correct'}){
             ($performance,$performance_length,$score,$seq_max,$rawdata) =
                 &student_tries_on_sequence($student,\%StudentsData,
-                                           $navmap,$seq,'no');
+                                           $navmap,$seq,'no',$randompick);
         } else {
             ($performance,$performance_length,$score,$seq_max,$rawdata) =
                 &student_performance_on_sequence($student,\%StudentsData,
                                                  $navmap,$seq,'no',
-                                                 $chosen_output->{ignore_weight});
+                                                 $chosen_output->{ignore_weight},
+                                                 $randompick);
         } 
         if ($chosen_output->{'every_problem'}) {
             if ($chosen_output->{'correct'}) {
@@ -1650,30 +1650,28 @@ sub csv_initialize{
         &Apache::lonstatistics::selected_sequences_with_assessments();
     if (! ref($navmap)) {
         # Unable to get data, so bail out
-        $r->print("<h3>".
+        $r->print('p class="LC_error">'.
                   &mt('Unable to retrieve course information.').
-                  '</h3>');
+                  '</p>');
     }
     #
     # Deal with unimplemented requests
     $request_aborted = undef;
     if ($chosen_output->{'base'} =~ /final table/) {
-        $r->print(<<END);
-<h2>Unable to Complete Request</h2>
-<p>
-The <b>Summary Table (Scores)</b> option is not available for non-HTML output.
-</p>
-END
+        $r->print(
+            '<h2>'.&mt('Unable to Complete Request').'</h2>'
+           .'<p class="LC_warning">'
+           .&mt('The [_1]Summary Table (Scores)[_2] option'
+               .' is not available for non-HTML output.','<b>','</b>')
+           .'</p>'
+        );
        $request_aborted = 1;
     }
     return if ($request_aborted);
     #
     # Initialize progress window
     my $studentcount = scalar(@Apache::lonstatistics::Students);
-    %prog_state=&Apache::lonhtmlcommon::Create_PrgWin
-        ($r,'CSV File Compilation Status',
-         'CSV File Compilation Progress', $studentcount,
-         'inline',undef,'Statistics','stats_status');
+    %prog_state=&Apache::lonhtmlcommon::Create_PrgWin($r,$studentcount);
     #
     # Open a file
     ($outputfile,$filename) = &Apache::loncommon::create_text_file($r,'csv');
@@ -1779,16 +1777,18 @@ sub csv_outputstudent {
     my $total = 0;
     my $maximum = 0;
     foreach my $seq (@sequences) {
+        my $randompick = $seq->randompick();
         my ($performance,$performance_length,$score,$seq_max,$rawdata);
         if ($chosen_output->{'tries'}){
             ($performance,$performance_length,$score,$seq_max,$rawdata) =
                 &student_tries_on_sequence($student,\%StudentsData,
-                                           $navmap,$seq,'no');
+                                           $navmap,$seq,'no',$randompick);
         } else {
             ($performance,$performance_length,$score,$seq_max,$rawdata) =
                 &student_performance_on_sequence($student,\%StudentsData,
                                                  $navmap,$seq,'no',
-                                                 $chosen_output->{ignore_weight});
+                                                 $chosen_output->{ignore_weight},
+                                                 $randompick);
         }
         if ($chosen_output->{'every_problem'}) {
             if ($chosen_output->{'correct'}) {
@@ -1889,7 +1889,7 @@ Inputs:
 #######################################################
 #######################################################
 sub student_tries_on_sequence {
-    my ($student,$studentdata,$navmap,$seq,$links) = @_;
+    my ($student,$studentdata,$navmap,$seq,$links,$randompick) = @_;
     $links = 'no' if (! defined($links));
     my $Str = '';
     my ($sum,$max) = (0,0);
@@ -1975,17 +1975,17 @@ sub student_tries_on_sequence {
                  ($links eq 'all')) {
                 my $link = '/adm/grades'.
                     '?symb='.&escape($resource->shown_symb).
-                        '&student='.$student->{'username'}.
-                            '&userdom='.$student->{'domain'}.
-                                '&command=submission';
+                        '&amp;student='.$student->{'username'}.
+                            '&amp;userdom='.$student->{'domain'}.
+                                '&amp;command=submission';
                 $symbol = &link($symbol, $link);
             }
             $value .= $symbol;
         }
         $Str .= $value;
     }
-    if ($seq->randompick()) {
-        $max = $seq->randompick();
+    if ($randompick) {
+        $max = $randompick;
     }
     if (! $hasdata && $sum == 0) {
         $sum = ' ';
@@ -2050,7 +2050,7 @@ Inputs:
 #######################################################
 #######################################################
 sub student_performance_on_sequence {
-    my ($student,$studentdata,$navmap,$seq,$links,$awarded_only) = @_;
+    my ($student,$studentdata,$navmap,$seq,$links,$awarded_only,$randompick) = @_;
     $links = 'no' if (! defined($links));
     my $Str = ''; # final result string
     my ($score,$max) = (0,0);
@@ -2059,9 +2059,11 @@ sub student_performance_on_sequence {
     my @ScoreData = ();
     my $partscore;
     my $hasdata = 0; # flag, 0 if there were no submissions on the sequence
+    my %ptsfreq;
     foreach my $resource (&get_resources($navmap,$seq)) {
         my $symb = $resource->symb;
         my $resource_data = $studentdata->{$symb};
+        my $resmax = 0;
         foreach my $part (@{$resource->parts()}) {
             $partscore = undef;
             my $weight;
@@ -2077,6 +2079,7 @@ sub student_performance_on_sequence {
             }
             #
             $max += $weight; # see the 'excused' branch below...
+            $resmax += $weight;
             $performance_length++; # one character per part
             $symbol = ' '; # default to space
             #
@@ -2130,13 +2133,24 @@ sub student_performance_on_sequence {
             if ( ($links eq 'yes' && $symbol ne ' ') || ($links eq 'all')) {
                 my $link = '/adm/grades' .
                     '?symb='.&escape($resource->shown_symb).
-                    '&student='.$student->{'username'}.
-                    '&userdom='.$student->{'domain'}.
-                    '&command=submission';
+                    '&amp;student='.$student->{'username'}.
+                    '&amp;userdom='.$student->{'domain'}.
+                    '&amp;command=submission';
                 $symbol = &link($symbol, $link);
             }
             $Str .= $symbol;
         }
+        if ($ptsfreq{$resmax}) {
+            $ptsfreq{$resmax} ++;
+        } else {
+            $ptsfreq{$resmax} = 1;
+        }
+    }
+    if ($randompick) {
+        my @uniquetotals = keys(%ptsfreq);
+        if ((@uniquetotals == 1) && ($ptsfreq{$uniquetotals[0]} > 0)) {
+            $max = $max * $randompick/$ptsfreq{$uniquetotals[0]};
+        }
     }
     if (! $hasdata && $score == 0) {
         $score = ' ';