--- loncom/interface/statistics/lonstudentsubmissions.pm	2011/11/21 20:12:36	1.65
+++ loncom/interface/statistics/lonstudentsubmissions.pm	2014/03/28 15:07:01	1.71
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonstudentsubmissions.pm,v 1.65 2011/11/21 20:12:36 raeburn Exp $
+# $Id: lonstudentsubmissions.pm,v 1.71 2014/03/28 15:07:01 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -196,9 +196,9 @@ sub BuildStudentSubmissionsPage {
                 $threshold = 10;
             }
         }
-        $r->print('<h4>'.
+        $r->print('<p>'.
                   &Apache::lonstatistics::section_and_enrollment_description().
-                  '</h4>');
+                  '</p>');
         if (! scalar(@Problems) || ! defined($Problems[0])) {
             $r->print(&mt('resource is undefined'));
         } elsif (!$show_named && @Students < $threshold) {
@@ -330,7 +330,7 @@ sub prepare_html_output {
     my $student_column_count = scalar(@student_columns);
     $headers{'problem'} = qq{<th colspan="$student_column_count">\&nbsp;</th>};
     foreach my $field (@student_columns) {
-        $headers{'student'}.= '<th>'.ucfirst($field).'</th>';
+        $headers{'student'}.= '<th>'.&mt(ucfirst($field)).'</th>';
     }
     #
     # we put the headers into the %headers hash
@@ -414,7 +414,8 @@ sub prepare_html_output {
             qq{<th colspan="$student_column_count">\&nbsp;</th>}.
             $headers{'response'};
     }
-    my $full_header = $/.'<table>'.$/;
+    #my $full_header = $/.'<table>'.$/;
+    my $full_header = $/.&Apache::loncommon::start_data_table().$/;
     $full_header .= '<tr align="left">'.$headers{'problem'}.'</tr>'.$/;
     if ($nonempty_part_headers) {
         $full_header .= '<tr align="left">'.$headers{'part'}.'</tr>'.$/;
@@ -425,11 +426,10 @@ sub prepare_html_output {
     # Main loop
     my $count;
     $r->print($/.$full_header.$/);
-    my $row_class = 'odd';   # css 
     foreach my $student (@$students) {
         my $student_row_data;
         if ($count++ >= 30) {
-            $r->print('</table>'.$/.$full_header.$/);
+            $r->print(&Apache::loncommon::end_data_table().$/.$full_header.$/);
             $count = 0;
         }
         last if ($c->aborted());
@@ -527,11 +527,6 @@ sub prepare_html_output {
         next if (! $maxrow && ! scalar(@essays));
         #
         # Go through the problem data and output a row.
-        if ($row_class eq 'even') {
-            $row_class = 'odd'; 
-        } else {
-            $row_class = 'even'; 
-        }
         my $printed_something;
         for (my $rows_output = 0;$rows_output<$maxrow;$rows_output++) {
             my $html;
@@ -555,22 +550,23 @@ sub prepare_html_output {
                 }
             }
             if (! $no_data) {
-                $r->print(qq{<tr class="$row_class">$student_row_data$html</tr>}.$/);
+                $r->print(&Apache::loncommon::start_data_table_row().$student_row_data.$html.
+                          &Apache::loncommon::end_data_table_row().$/);
                 $printed_something=1;
             }
         }
         if (@essays) {
-            my $tr = qq{<tr class="$row_class">};
+            my $tr = &Apache::loncommon::start_data_table_row();
             my $td = qq{<td  valign="top" class="essay" colspan="$total_col">};
             if (! $printed_something) {
-                $r->print($tr.$student_row_data.'</tr>'.$/);
+                $r->print($tr.$student_row_data.&Apache::loncommon::end_data_table_row().$/);
             }
             $r->print($tr.$td.
                       join('</td></tr>'.$/.$tr.$td,@essays).'</td></tr>'.$/);
             undef(@essays);
         }
     } # end of student loop
-    $r->print('</table>'.$/);
+    $r->print(&Apache::loncommon::end_data_table().$/);
     return;
 }
 
@@ -735,8 +731,29 @@ sub html_non_essay_results {
                 push(@values,$response->{$original_header});
             }
         }
+        # FIXME: Bug #6700 - Properly process multiple answer fields
+        # Would be a good place here but the data needs to be properly
+        # compiled somewhere before.
+        #      elsif (($resptype =~ /^(numerical|formula|custom)$/) &&
+        #             (submission) && (ref)) {
+        #        de-ref...: push(@values,$response->{$original_header}); }
     } else {
-        @values = map { $response->{$_}; } @$headers;
+        foreach my $original_header (@$headers) {
+            if ($original_header eq 'Time') {
+                push(@values,&Apache::lonlocal::locallocaltime($response->{$original_header}));
+            } elsif (($original_header eq 'Submission') &&
+                    !($resptype =~ /^(radiobutton|option|match|rank)$/)) {
+                # encode all submissions which have not been encoded above
+                push(@values,&HTML::Entities::encode($response->{$original_header},'<>&"'));
+            } elsif (($original_header eq 'Correct') &&
+                     ($resptype eq 'radiobutton')) {
+                # encode foil separators
+                push(@values,&HTML::Entities::encode($response->{$original_header},'&'));
+            } else {
+                # A normal column
+                push(@values,$response->{$original_header});
+            }
+        }
     }
     my $td = '<td valign="top">';
     my $str = $td.join('</td>'.$td,@values).'</td>';
@@ -787,9 +804,9 @@ sub prepare_excel_output {
         $lastprob = $prob;
     }
     if ($columncount > 255) {
-        $r->print('<h1>'.&mt('Unable to complete request').'</h1>'.$/.
-                  '<p>'.&mt('LON-CAPA is unable to produce your Excel spreadsheet because your selections will result in more than 255 columns.  Excel allows only 255 columns in a spreadsheet.').'</p>'.$/.
-                  '<p>'.&mt('Consider selecting fewer problems to generate reports on, or reducing the number of items per problem.  Or use HTML or CSV output.').'</p>'.$/);
+        $r->print('<p class="LC_error">'.&mt('Unable to complete request').'</p>'.$/.
+                  '<p class="LC_warning">'.&mt('LON-CAPA is unable to produce your Excel spreadsheet because your selections will result in more than 255 columns.  Excel allows only 255 columns in a spreadsheet.').'</p>'.$/.
+                  '<p class="LC_warning">'.&mt('Consider selecting fewer problems to generate reports on, or reducing the number of items per problem.  Or use HTML or CSV output.').'</p>'.$/);
         if (ref($lastprob)) {
             $r->print('<p>'.&mt('The last problem that will fit in the current spreadsheet is [_1].',$lastprob->compTitle).'</p>');
         }
@@ -799,14 +816,14 @@ sub prepare_excel_output {
     #
     # Print out a message telling them what we are doing
     if (scalar(@$Problems) > 1) {
-        $r->print('<h2>'.
+        $r->print('<p class="LC_info">'.
                   &mt('Preparing Excel spreadsheet of student responses to [_1] problems',
                       scalar(@$Problems)).
-                  '</h2>');
+                  '</p>');
     } else {
-        $r->print('<h2>'.
+        $r->print('<p class="LC_info">'.
                   &mt('Preparing Excel spreadsheet of student responses').
-                  '</h2>');
+                  '</p>');
     }
     $r->rflush();
     #
@@ -814,7 +831,17 @@ sub prepare_excel_output {
     my ($workbook,$filename,$format) = 
         &Apache::loncommon::create_workbook($r);
     return if (! defined($workbook));
-    my $worksheet  = $workbook->addworksheet('Student Submission Data');
+
+    # Worksheet name
+    # The length of a worksheet name in Excel 95 is limited to 31 characters.
+    # Let's make sure to not exceed the maximum length in the translation files.
+    # Otherwise, no Excel file would be created.
+    my $worksheetname = &mt('Student Submission Data');
+    if (length($worksheetname) > 31) {
+        # nice way to cut off too long name
+        $worksheetname = substr($worksheetname,0,28,).'...';
+    }
+    my $worksheet  = $workbook->addworksheet($worksheetname);
     #
     # Add headers to the worksheet
     my $rows_output = 0;
@@ -827,13 +854,13 @@ sub prepare_excel_output {
     my $partid_row = $rows_output++;
     my $respid_row = $rows_output++;
     my $header_row = $rows_output++;
-    $worksheet->write($title_row ,0,'Problem Title',$format->{'bold'});
-    $worksheet->write($partid_row,0,'Part ID',$format->{'bold'});
-    $worksheet->write($respid_row,0,'Response ID',$format->{'bold'});
+    $worksheet->write($title_row ,0,&mt('Problem Title'),$format->{'bold'});
+    $worksheet->write($partid_row,0,&mt('Part ID'),$format->{'bold'});
+    $worksheet->write($respid_row,0,&mt('Response ID'),$format->{'bold'});
     # Student headers
     my @StudentColumns = &get_student_columns($show_named);
     foreach my $field (@StudentColumns) {
-        $worksheet->write($header_row,$cols_output++,ucfirst($field),
+        $worksheet->write($header_row,$cols_output++,&mt(ucfirst($field)),
                           $format->{'bold'});
     }
     # Problem headers
@@ -875,10 +902,7 @@ sub prepare_excel_output {
     }
     #
     # Populate the worksheet with the student data
-    my %prog_state=&Apache::lonhtmlcommon::Create_PrgWin
-        ($r,'Excel File Compilation Status',
-         'Excel File Compilation Progress', 
-         scalar(@$Students),'inline',undef,'Statistics','stats_status');
+    my %prog_state=&Apache::lonhtmlcommon::Create_PrgWin($r,scalar(@$Students));
     my $max_row = $rows_output;
     foreach my $student (@$Students) {
         last if ($c->aborted());
@@ -955,8 +979,7 @@ sub prepare_excel_output {
                 }
             }
         }
-        &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state,
-                                                 'last student');
+        &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state,'last student');
     }
     &Apache::lonhtmlcommon::Close_PrgWin($r,\%prog_state);
     #
@@ -1065,14 +1088,11 @@ sub prepare_csv_output {
     my ($r,$problems,$students,$anoncounter,$show_named) = @_;
     my $c = $r->connection();
     #
-    $r->print('<h2>'.
-              &mt('Generating CSV report of student responses').'</h2>');
+    $r->print('<p class="LC_info">'.
+              &mt('Generating CSV report of student responses').'</p>');
     #
     # Progress window
-    my %prog_state=&Apache::lonhtmlcommon::Create_PrgWin
-        ($r,'CSV File Compilation Status',
-         'CSV File Compilation Progress', 
-         scalar(@$students),'inline',undef,'Statistics','stats_status');
+    my %prog_state=&Apache::lonhtmlcommon::Create_PrgWin($r,scalar(@$students));
     
     $r->rflush();
     #
@@ -1222,8 +1242,7 @@ sub prepare_csv_output {
             print $outputfile $/;
         }
         undef(@rows);
-        &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state,
-                                                 'last student');
+        &Apache::lonhtmlcommon::Increment_PrgWin($r,\%prog_state,'last student');
     }
     close($outputfile);
     #
@@ -1240,7 +1259,7 @@ sub prepare_csv_output {
 sub csv_format_item {
     my ($item,$type) = @_;
     if ($type eq 'Time') {
-        $item = localtime($item);
+        $item = &Apache::lonlocal::locallocaltime($item);
     }
     $item =&Apache::loncommon::csv_translate($item); 
     return $item;
@@ -1347,12 +1366,6 @@ sub CreateInterface {
     $Str .= &Apache::loncommon::end_data_table_row();
     $Str .= &Apache::loncommon::end_data_table();
     #
-    $Str .= '<p><span class="LC_nobreak">'
-           .&mt('Status: [_1]',
-                    '<input type="text" name="stats_status"'
-                   .' size="60" value="" readonly="readonly" />')
-           .'</span></p>';
-    ##
     return $Str;
 }